syzbot suspects this issue was fixed by commit:
commit b83764f9220a4a14525657466f299850bbc98de9
Author: Miao-chen Chou
Date: Tue Jun 30 03:15:00 2020 +
Bluetooth: Fix kernel oops triggered by hci_adv_monitors_clear()
bisection log:
On Sat, Sep 05, 2020 at 12:19:08AM +, Michael Kelley wrote:
[...]
> >
> > @@ -462,7 +576,13 @@ static int __vmbus_open(struct vmbus_channel
> > *newchannel,
> > open_msg->openid = newchannel->offermsg.child_relid;
> > open_msg->child_relid = newchannel->offermsg.child_relid;
> >
Linus,
Please git pull the following tag:
git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.9-rc4-tag
xen: branch for v5.9-rc4
It contains a small series for fixing a problem with Xen PVH guests
when running as backends (e.g. as dom0). Mapping other guests' memory
now is
Hello,
syzbot found the following issue on:
HEAD commit:dc1a9bf2 octeontx2-pf: Add UDP segmentation offload support
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=13959d1590
kernel config: https://syzkaller.appspot.com/x/.config?x=b6856d16f78d8fa9
On Sat, Sep 05, 2020 at 05:45:02PM -0400, Joel Fernandes wrote:
> On Sat, Sep 05, 2020 at 05:24:06PM -0400, Joel Fernandes wrote:
> > Hi Paul,
> >
> > On Thu, Sep 03, 2020 at 01:06:39PM -0700, Paul E. McKenney wrote:
> > > On Wed, Sep 02, 2020 at 08:54:10AM -0700, Paul E. McKenney wrote:
> > > >
syzbot has found a reproducer for the following issue on:
HEAD commit:3b3ea602 x86: add failure injection to get/put/clear_user
git tree: https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=1323233590
kernel config:
Free the skb if usb_submit_urb fails on rx_urb. And free the urb
no matter usb_submit_urb succeeds or not in rtl8xxxu_submit_int_urb.
Signed-off-by: Chris Chiu
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git
This comment is outdated and no longer reflects the actual implementation
of af_packet.c.
Reasons for the new comment:
1.
In this file, the function packet_snd first reserves a headroom of
length (dev->hard_header_len + dev->needed_headroom).
Then if the socket is a SOCK_DGRAM socket, it calls
> From: Jakub Kicinski
> Sent: Saturday, September 5, 2020 4:27 PM
> [...]
> On Fri, 4 Sep 2020 19:52:18 -0700 Dexuan Cui wrote:
> > mlx5_suspend()/resume() keep the network interface, so during hibernation
> > netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence
> >
On 9/4/20 8:22 AM, Changbin Du wrote:
> This moves the KCSAN kconfig items under menu 'Generic Kernel Debugging
> Instruments' where UBSAN resides.
>
> Signed-off-by: Changbin Du
LGTM. Thanks.
Reviewed-by: Randy Dunlap
Tested-by: Randy Dunlap
> ---
> lib/Kconfig.debug | 4 +---
> 1 file
On Sat, Sep 5, 2020 at 6:51 AM John Hubbard wrote:
>
> On 9/4/20 6:16 PM, Souptick Joarder wrote:
> > Hi Andrew,
> >
> > On Wed, Sep 2, 2020 at 3:00 AM John Hubbard wrote:
> >>
> >> On 9/1/20 2:21 PM, Souptick Joarder wrote:
> >>> First, when memory allocation for sg_list_unaligned failed, there
Add function to build prefetch iommu pages command
Signed-off-by: Wesley Sheng
---
drivers/iommu/amd/amd_iommu_types.h | 2 ++
drivers/iommu/amd/iommu.c | 19 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/iommu/amd/amd_iommu_types.h
syzbot suspects this issue was fixed by commit:
commit b83764f9220a4a14525657466f299850bbc98de9
Author: Miao-chen Chou
Date: Tue Jun 30 03:15:00 2020 +
Bluetooth: Fix kernel oops triggered by hci_adv_monitors_clear()
bisection log:
On Fri, Sep 4, 2020 at 5:30 AM Sami Tolvanen wrote:
>
> This patch series adds support for building x86_64 and arm64 kernels
> with Clang's Link Time Optimization (LTO).
>
> In addition to performance, the primary motivation for LTO is
> to allow Clang's Control-Flow Integrity (CFI) to be used in
On Sun, Sep 06, 2020 at 06:34:08AM +0900, Stafford Horne wrote:
> On Sat, Sep 05, 2020 at 03:57:14PM +0200, Luc Van Oostenryck wrote:
> > On Sat, Sep 05, 2020 at 10:19:35PM +0900, Stafford Horne wrote:
> >
> > Hi,
> >
> > The change for 64-bit get_user() looks good to me.
> > But I wonder, given
On Mon, Aug 10, 2020 at 06:33:30AM +0200, Michał Mirosław wrote:
> This removes regulator_lock/unlock() calls around
> regulator_notifier_call_chain() as they are redundant - drivers
> already have to guarantee regulator_dev's existence during the call.
>
> This should make reasoing about the
On Fri, 4 Sep 2020 22:21:59 +0800 Landen Chao wrote:
> +static int
> +mt7531_cpu_port_config(struct dsa_switch *ds, int port)
> +{
> + struct mt7530_priv *priv = ds->priv;
> + phy_interface_t interface;
> + int speed;
> +
> + switch (port) {
> + case 5:
> + if
On Fri, 4 Sep 2020 22:21:57 +0800 Landen Chao wrote:
> +static bool
> +mt7530_phy_mode_supported(struct dsa_switch *ds, int port,
> + const struct phylink_link_state *state)
> {
> struct mt7530_priv *priv = ds->priv;
> - u32 mcr_cur, mcr_new;
>
> switch
On Fri, 4 Sep 2020 22:21:58 +0800 Landen Chao wrote:
> @@ -32,10 +33,13 @@ Required properties for the child nodes within ports
> container:
>
> - reg: Port address described must be 6 for CPU port and from 0 to 5 for
> user ports.
> -- phy-mode: String, must be either "trgmii" or
06.09.2020 02:16, Michał Mirosław пишет:
> On Sat, Sep 05, 2020 at 11:41:20PM +0300, Dmitry Osipenko wrote:
>> Hello!
>>
>> This series performs refactoring of the Tegra I2C driver code and hardens
>> the atomic-transfer mode.
> [...]
>
> Pending comments, all LGTM.
Thank you!
05.09.2020 23:41, Dmitry Osipenko пишет:
> Apparently barrier() was intended to reduce possibility of racing
> with the interrupt handler, but driver's code evolved significantly
> and today's driver enables interrupt only when it waits for completion
> notification. Hence barrier() has no good
On Fri, 4 Sep 2020 19:52:18 -0700 Dexuan Cui wrote:
> mlx5_suspend()/resume() keep the network interface, so during hibernation
> netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence
> netvsc_resume() should call netvsc_vf_changed() to switch the data path
> back to the VF
On Sat, Sep 5, 2020 at 3:24 PM Xie He wrote:
>
> Hi Willem,
>
> I have a question about the function dev_validate_header used in
> af_packet.c. Can you help me? Thanks!
>
> I see when the length of the data is smaller than hard_header_len, and
> when the user is "capable" enough, the function
On Sat, Sep 05, 2020 at 11:41:20PM +0300, Dmitry Osipenko wrote:
> Hello!
>
> This series performs refactoring of the Tegra I2C driver code and hardens
> the atomic-transfer mode.
[...]
Pending comments, all LGTM.
Best Regards,
Michał Mirosław
On Sat, Sep 05, 2020 at 03:59:04PM -0700, Randy Dunlap wrote:
> On 9/5/20 3:23 PM, Arvind Sankar wrote:
> > The x86 boot protocol requires the kernel command line to be a
> > NUL-terminated string of length at most COMMAND_LINE_SIZE (including the
> > terminating NUL). In case the bootloader
06.09.2020 01:51, Michał Mirosław пишет:
> On Sun, Sep 06, 2020 at 01:24:14AM +0300, Dmitry Osipenko wrote:
>> 06.09.2020 01:10, Michał Mirosław пишет:
>>> On Sat, Sep 05, 2020 at 11:41:31PM +0300, Dmitry Osipenko wrote:
Factor out runtime PM and hardware initialization into separate function
On Fri, 4 Sep 2020 21:01:57 +0800 Wang Hai wrote:
> DIGITAL_NFC_DEP_REQ_RES_TAILROOM is never used after it was introduced.
> DIGITAL_NFC_DEP_REQ_RES_HEADROOM is no more used after below
> commit e8e7f4217564 ("NFC: digital: Remove useless call to skb_reserve()")
> Remove them.
>
> Reported-by:
On Fri, 4 Sep 2020 20:58:58 +0800 Wang Hai wrote:
> Remove SRVL_CTRL_PKT_SIZE which is defined more than once.
>
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
Applied, thanks.
On 9/5/20 3:23 PM, Arvind Sankar wrote:
> The x86 boot protocol requires the kernel command line to be a
> NUL-terminated string of length at most COMMAND_LINE_SIZE (including the
> terminating NUL). In case the bootloader messed up and the command line
> is too long (hence not NUL-terminated),
On Sun, Sep 06, 2020 at 01:53:56AM +0300, Dmitry Osipenko wrote:
> 06.09.2020 01:47, Michał Mirosław пишет:
> > On Sat, Sep 05, 2020 at 11:41:50PM +0300, Dmitry Osipenko wrote:
> >> Make all comments to be consistent in regards to capitalization and
> >> punctuation, correct spelling and grammar
06.09.2020 01:49, Michał Mirosław пишет:
> On Sun, Sep 06, 2020 at 01:36:20AM +0300, Dmitry Osipenko wrote:
>> 06.09.2020 01:23, Michał Mirosław пишет:
>>> On Sat, Sep 05, 2020 at 11:41:36PM +0300, Dmitry Osipenko wrote:
The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much
06.09.2020 01:47, Michał Mirosław пишет:
> On Sat, Sep 05, 2020 at 11:41:50PM +0300, Dmitry Osipenko wrote:
>> Make all comments to be consistent in regards to capitalization and
>> punctuation, correct spelling and grammar errors.
> [...]
>> -/* Rounds down to not include partial word at the
On Sun, Sep 06, 2020 at 01:24:14AM +0300, Dmitry Osipenko wrote:
> 06.09.2020 01:10, Michał Mirosław пишет:
> > On Sat, Sep 05, 2020 at 11:41:31PM +0300, Dmitry Osipenko wrote:
> >> Factor out runtime PM and hardware initialization into separate function
> >> in order have a cleaner error
On Fri, Sep 04, 2020 at 03:59:59PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Sep 04, 2020 at 01:27:16PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Sep 04, 2020 at 11:23:57PM +0800, Changbin Du escreveu:
> > > Same as 'perf probe -F', this patch adds filter support for the ftrace
On Sun, Sep 06, 2020 at 01:36:20AM +0300, Dmitry Osipenko wrote:
> 06.09.2020 01:23, Michał Mirosław пишет:
> > On Sat, Sep 05, 2020 at 11:41:36PM +0300, Dmitry Osipenko wrote:
> >> The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much in
> >> regards to readability and generation
On Tue, Sep 01, 2020 at 07:53:46PM -0700, Kees Cook wrote:
> We don't want to depend on the linker's orphan section placement
> heuristics as these can vary between linkers, and may change between
> versions. All sections need to be explicitly handled in the linker script.
>
> Now that all
On Sat, Sep 05, 2020 at 11:41:50PM +0300, Dmitry Osipenko wrote:
> Make all comments to be consistent in regards to capitalization and
> punctuation, correct spelling and grammar errors.
[...]
> - /* Rounds down to not include partial word at the end of buf */
> + /* rounds down to not
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 9322c47b21b9e05d7f9c037aa2c472e9f0dc7f3b
commit: 793b08e2efff3ec020c5c5861d00ed394fcdd488 powerpc/kexec: Move kexec
files into a dedicated subdir.
date: 10 months ago
config:
06.09.2020 01:23, Michał Mirosław пишет:
> On Sat, Sep 05, 2020 at 11:41:36PM +0300, Dmitry Osipenko wrote:
>> The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much in
>> regards to readability and generation of the code, hence let's remove it
>> to clean up code a tad.
> [...]
>>
The pull request you sent on Sat, 5 Sep 2020 13:46:48 +0200:
> https://github.com/ojeda/linux.git tags/clang-format-for-linus-v5.9-rc4
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/dd9fb9bb3340c791a2be106fdc895db75f177343
Thank you!
--
Deet-doot-dot, I am a bot.
The pull request you sent on Sat, 5 Sep 2020 13:37:52 +0200:
> https://github.com/ojeda/linux.git tags/auxdisplay-for-linus-v5.9-rc4
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/dd9fb9bb3340c791a2be106fdc895db75f177343
Thank you!
--
Deet-doot-dot, I am a bot.
The pull request you sent on Sat, 5 Sep 2020 14:01:25 +0200:
> https://github.com/ojeda/linux.git tags/compiler-attributes-for-linus-v5.9-rc4
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/dd9fb9bb3340c791a2be106fdc895db75f177343
Thank you!
--
Deet-doot-dot, I am a
The pull request you sent on Sat, 5 Sep 2020 01:08:56 +:
> git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git/ tags/arc-5.9-rc4
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/70187f7727d4ddd8282b576ece93ca233e88b19e
Thank you!
--
Deet-doot-dot, I am a
On Fri, 4 Sep 2020 16:37:27 +0800 Luo bin wrote:
> The bugs fixed in this patchset have been present since the following
> commits:
> patch #1: Fixes: 00e57a6d4ad3 ("net-next/hinic: Add Tx operation")
> patch #2: Fixes: 5e126e7c4e52 ("hinic: add firmware update support")
Applied.
On Fri, Sep 4, 2020 at 8:55 AM Bjorn Andersson
wrote:
>
> Based on previous attempts and discussions this is the latest attempt at
> inheriting stream mappings set up by the bootloader, for e.g. boot splash or
> efifb.
>
> Per Will's request this builds on the work by Jordan and Rob for the
Hi Willem,
I have a question about the function dev_validate_header used in
af_packet.c. Can you help me? Thanks!
I see when the length of the data is smaller than hard_header_len, and
when the user is "capable" enough, the function will accept it and pad
it with 0s, without validating the
06.09.2020 01:10, Michał Mirosław пишет:
> On Sat, Sep 05, 2020 at 11:41:31PM +0300, Dmitry Osipenko wrote:
>> Factor out runtime PM and hardware initialization into separate function
>> in order have a cleaner error unwinding in the probe function.
> [...]
>> +ret =
The string functions can currently not be used safely in early boot
code, at least on x86, as some of that code will be executing out of
the identity mapping rather than kernel virtual address space.
Instrumentation options that insert accesses to any global data will
cause a crash.
I'm proposing
The x86 boot protocol requires the kernel command line to be a
NUL-terminated string of length at most COMMAND_LINE_SIZE (including the
terminating NUL). In case the bootloader messed up and the command line
is too long (hence not NUL-terminated), use strscpy to copy the command
line into
On Sat, Sep 05, 2020 at 11:41:36PM +0300, Dmitry Osipenko wrote:
> The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much in
> regards to readability and generation of the code, hence let's remove it
> to clean up code a tad.
[...]
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++
String functions can be useful in early boot, but using instrumented
versions can be problematic: eg on x86, some of the early boot code is
executing out of an identity mapping rather than the kernel virtual
addresses. Accessing any global variables at this point will lead to a
crash.
Tracing and
Am Sonntag, 6. September 2020, 00:01:55 CEST schrieb Heiko Stübner:
> Am Montag, 31. August 2020, 10:47:48 CEST schrieb Jianqun Xu:
> > Make pinctrl-rockchip driver to be tristate module, support to build as
> > a module, this is useful for GKI.
> >
> > Signed-off-by: Jianqun Xu
>
>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 9322c47b21b9e05d7f9c037aa2c472e9f0dc7f3b
commit: 57430471e2fa60a412e220fa3014567e792aaa6f drm/amdgpu: Add support for
USBC PD FW download
date: 6 months ago
compiler: hppa-linux-gcc (GCC) 9.3.0
If you
Hi,
Am Montag, 31. August 2020, 10:50:10 CEST schrieb Jianqun Xu:
> Add valid check for gpio bank.
Please add more description on where this happened.
> Change-Id: Ia4609c3045b5df7879beab3c15d791ff54a1f49b
Please drop the change-id.
> Signed-off-by: Jianqun Xu
> ---
>
On Sat, Sep 05, 2020 at 11:41:31PM +0300, Dmitry Osipenko wrote:
> Factor out runtime PM and hardware initialization into separate function
> in order have a cleaner error unwinding in the probe function.
[...]
> + ret = tegra_i2c_init_runtime_pm_and_hardware(i2c_dev);
[...]
This one doesn't
Am Montag, 31. August 2020, 10:47:51 CEST schrieb Jianqun Xu:
> Add valid check for gpio bank.
As this obviously fixes a problem you encountered please elaborate a bit more.
Just so that people reading the log later understand when this issue surfaced.
Also - maybe even more important - why is
06.09.2020 00:56, Michał Mirosław пишет:
> On Sat, Sep 05, 2020 at 11:41:30PM +0300, Dmitry Osipenko wrote:
>> Use clk-bulk helpers and factor out clocks initialization into separate
>> function in order to make code cleaner.
> [...]
>> --- a/drivers/i2c/busses/i2c-tegra.c
>> +++
On 9/4/20 12:50 AM, Kishon Vijay Abraham I wrote:
> Add documentation to help users use pci-epf-ntb function driver and
> existing host side NTB infrastructure for NTB functionality.
>
> Signed-off-by: Kishon Vijay Abraham I
> ---
> Documentation/PCI/endpoint/index.rst | 1 +
>
On 9/4/20 4:52 PM, Russ Weight wrote:
> Extend the FPGA Intel Security Manager class driver to
> include an update/filename sysfs node that can be used
> to initiate a security update. The filename of a secure
> update file (BMC image, FPGA image, Root Entry Hash image,
> or Code Signing Key
Am Montag, 31. August 2020, 10:47:50 CEST schrieb Jianqun Xu:
> Remove totally irq mappings create in probe, the gpio irq mapping will
> be created when do
> gpio_to_irq ->
> rockchip_gpio_to_irq ->
> irq_create_mapping
>
> This patch can speed up system boot on, also
Am Montag, 31. August 2020, 10:47:48 CEST schrieb Jianqun Xu:
> Make pinctrl-rockchip driver to be tristate module, support to build as
> a module, this is useful for GKI.
>
> Signed-off-by: Jianqun Xu
Reviewed-by: Heiko Stuebner
> ---
> drivers/pinctrl/Kconfig| 2 +-
>
On Sat, Sep 05, 2020 at 11:41:30PM +0300, Dmitry Osipenko wrote:
> Use clk-bulk helpers and factor out clocks initialization into separate
> function in order to make code cleaner.
[...]
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
[...]
> static const struct
Am Montag, 31. August 2020, 10:47:49 CEST schrieb Jianqun Xu:
> There need to enable pclk_gpio when do irq_create_mapping, since it will
> do access to gpio controller.
>
> Signed-off-by: Jianqun Xu
Reviewed-by: Heiko Stuebner
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 2 ++
> 1 file
Hi,
Am Dienstag, 1. September 2020, 12:13:16 CEST schrieb kernel test robot:
> Hi Jianqun,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on rockchip/for-next]
> [also build test ERROR on pinctrl/devel v5.9-rc3 next-20200828]
> [If your patch is applied to the
From: Heiko Stuebner
The Rockchip pinctrl driver needs to handle information from Devicetree
so only makes sense getting compiled on systems with CONFIG_OF enabled.
This also fixes a problem found by the "kernel-test-robot" when compiling
the driver on test-builds that do not have CONFIG_OF
Hello,
syzbot found the following issue on:
HEAD commit:b51594df Merge tag 'docs-5.9-3' of git://git.lwn.net/linux
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12bcc1c190
kernel config: https://syzkaller.appspot.com/x/.config?x=e1c560d0f4e121c9
On Sat, Sep 05, 2020 at 05:24:06PM -0400, Joel Fernandes wrote:
> Hi Paul,
>
> On Thu, Sep 03, 2020 at 01:06:39PM -0700, Paul E. McKenney wrote:
> > On Wed, Sep 02, 2020 at 08:54:10AM -0700, Paul E. McKenney wrote:
> > > On Tue, Sep 01, 2020 at 06:51:28PM -0700, Davidlohr Bueso wrote:
> > > > On
On Sat, Sep 05, 2020 at 03:57:14PM +0200, Luc Van Oostenryck wrote:
> On Sat, Sep 05, 2020 at 10:19:35PM +0900, Stafford Horne wrote:
>
> Hi,
>
> The change for 64-bit get_user() looks good to me.
> But I wonder, given that openrisc is big-endian, what will happen
> you have the opposite
On Fri, 4 Sep 2020 14:37:28 -0700 Florian Fainelli wrote:
> Changes in v2:
>
> - export of_update_property() to permit building bcm_sf2 as a module
> - provided a better explanation of the problem being solved after
> explaining it to Andrew during the v1 review
Applied, thanks everyone!
Hi Paul,
On Thu, Sep 03, 2020 at 01:06:39PM -0700, Paul E. McKenney wrote:
> On Wed, Sep 02, 2020 at 08:54:10AM -0700, Paul E. McKenney wrote:
> > On Tue, Sep 01, 2020 at 06:51:28PM -0700, Davidlohr Bueso wrote:
> > > On Tue, 01 Sep 2020, Paul E. McKenney wrote:
> > >
> > > > And it appears that
On 9/5/20 2:03 PM, Nícolas F. R. A. Prado wrote:
> Commit 91ebc1facd77 ("scsi: core: remove Scsi_Cmnd typedef") removed
> the Scsi_cmnd typedef but it was still mentioned in a paragraph in the
> "SCSI mid_level - lower_level driver interface" documentation page.
> Remove this obsolete paragraph.
>
Commit 91ebc1facd77 ("scsi: core: remove Scsi_Cmnd typedef") removed
the Scsi_cmnd typedef but it was still mentioned in a paragraph in the
"SCSI mid_level - lower_level driver interface" documentation page.
Remove this obsolete paragraph.
Suggested-by: Randy Dunlap
Suggested-by: Jonathan Corbet
On 9/4/20 4:52 PM, Russ Weight wrote:
> Extend the MAX10 BMC Security Engine driver to provide a
> handler to expose the canceled code signing key (CSK) bit
> vectors. These use the standard bitmap list format
> (e.g. 1,2-6,9).
>
> Signed-off-by: Russ Weight
> Reviewed-by: Wu Hao
> ---
>
Hello!
This series performs refactoring of the Tegra I2C driver code and hardens
the atomic-transfer mode.
Changelog:
v4: - Reordered patches in the fixes/features/cleanups order like it was
suggested by Andy Shevchenko.
- Now using clk-bulk API, which was suggested by Andy
The error message prints number of vIRQ, which isn't a useful information.
In practice devm_request_irq() never fails, hence let's remove the bogus
message in order to make code cleaner.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 4 +---
1 file changed, 1 insertion(+),
The "non_hs_mode" divisor value is fixed, thus there is no need to have
the variable i2c_dev.clk_divisor_non_hs_mode struct member. Let's remove
it and move the mode selection into tegra_i2c_init() where it can be
united with the timing selection.
Signed-off-by: Dmitry Osipenko
---
Factor out runtime PM and hardware initialization into separate function
in order have a cleaner error unwinding in the probe function.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 68 +++---
1 file changed, 38 insertions(+), 30 deletions(-)
Technically the tegra_i2c_flush_fifos() may fail and transfer should be
aborted in this case, but this shouldn't ever happen in practice unless
there is a bug somewhere in the driver. Let's add the error check just
for completeness.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
Driver now uses devm_platform_get_and_ioremap_resource() which replaces
the typical boilerplate code and makes code cleaner.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c
Use common helper for retrieval of the interrupt number in order to make
code cleaner. Note that platform_get_irq() prints error message by itself.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
It doesn't make sense to conditionalize the div-clk rate changes because
rate is fixed and it won't ever change once it's set at the driver's probe
time. All further changes are NO-OPs because CCF caches rate and skips
rate-change if rate is unchanged.
Signed-off-by: Dmitry Osipenko
---
Use a single reset_control_reset() instead of assert/deasset couple in
order to make code cleaner a tad. Note that the reset_control_reset()
uses 1 microsecond delay instead of 2 that was used previously, but this
shouldn't matter. In addition don't ignore potential error of the reset
control by
Use clk-bulk helpers and factor out clocks initialization into separate
function in order to make code cleaner.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 184 -
1 file changed, 65 insertions(+), 119 deletions(-)
diff --git
Reorder the definition of variables in the code in order to make code
easier to read.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 44 ++
1 file changed, 18 insertions(+), 26 deletions(-)
diff --git
Apparently barrier() was intended to reduce possibility of racing
with the interrupt handler, but driver's code evolved significantly
and today's driver enables interrupt only when it waits for completion
notification. Hence barrier() has no good use anymore, let's remove it.
Signed-off-by:
Signed-off-by: Jonathan Neuschäfer
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e4647c84c987e..b85671736108e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17699,6 +17699,7 @@ S: Supported
W:
The driver's probe function code is a bit difficult to read. This patch
reorders code of the probe function, forming groups of code that are easy
to work with. The reset_control_get() now may return -EPROBE_DEFER on
newer Tegra SoCs because they use BPMP driver that provides reset controls
and
The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much in
regards to readability and generation of the code, hence let's remove it
to clean up code a tad.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 17 -
1 file changed, 8 insertions(+), 9
This prevents the chapter headings from showing up in the table of
contents in filesystems/index.html.
Note that I didn't pick "UBIFS Authentication" as the document title,
because there is a chapter of the same name, and Sphinx complains about
multiple headings with the same name:
In these two patches, I add ubifs-authentication.rst to MAINTAINERS and
add a heading to prevent the chapter headings from being listed in
filesystems/index.html.
v2:
- Rebased on 5.9-rc3
- Removed patches that have become obsolete
v1:
-
Improve coding style of the tegra_i2c_wait_for_config_load() function by
removing need to wrap code in order make it more readable and to adhere to
the common kernel coding style.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 34 --
1 file
Drop '_timeout' postfix from the wait/poll completion function names in
order to make the names shorter, making code cleaner a tad.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 33 +++--
1 file changed, 15
Reorder location of functions in the code in order to have definition
of functions closer to the place of the invocation. This change makes
easier to navigate around the code and removes the need to have a
prototype for tegra_i2c_init().
Signed-off-by: Dmitry Osipenko
---
The driver's code is inconsistent in regards to the error values checking.
The correct way should be to check both positive and negative values.
This patch cleans up the error-checks in the code. Note that the
pm_runtime_get_sync() could return positive value on success, hence only
relevant parts
Rename variable "reg" to "val" in order to better reflect the actual usage
of the variable in the code and to make naming consistent with the rest of
the code.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
Rename "ret" variables to "err" in order to make code a bit more
expressive, emphasizing that the returned value is a error code.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff
Some places in the code are missing newlines or have unnecessary
whitespaces and newlines. This creates inconsistency of the code and
hurts readability. This patch removes the unnecessary and adds necessary
whitespaces / newlines, clears indentation of the code.
Signed-off-by: Dmitry Osipenko
Consolidate error handling in tegra_i2c_xfer_msg() into a common code
path in order to make code cleaner.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c
Use proper spelling of "NVIDIA" and don't designate driver as Tegra2-only
since newer SoC generations are supported as well.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c
This patch unifies style of all messages in the driver by starting them
with a lowercase letter and using consistent capitalization and wording
for all messages.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 33 -
1 file changed, 12
1 - 100 of 364 matches
Mail list logo
