[PATCH] sgl_alloc_order: memory leak

2020-09-19 Thread Douglas Gilbert
Noticed that when sgl_alloc_order() failed with order > 0 that free memory on my machine shrank. That function shouldn't call sgl_free() on its error path since that is only correct when order==0 . Signed-off-by: Douglas Gilbert --- lib/scatterlist.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 2/2] Input: atmel_mxt_ts - wake mXT1386 from deep-sleep mode

2020-09-19 Thread Wang, Jiada
Hi Dmitry On 2020/09/20 4:49, Dmitry Osipenko wrote: 18.09.2020 18:55, Wang, Jiada пишет: ...   +static void mxt_wake(struct mxt_data *data) +{ +    struct i2c_client *client = data->client; +    struct device *dev = >client->dev; +    struct device_node *np = dev->of_node; +    union

INVESTMENT OFFER / OFFRE D’INVESTISSEMENT

2020-09-19 Thread Mr Tolar OKANSE
INVESTMENT OFFER I am Mr Tolar OKANSE, financial advisor, property and private assets. I found your contact through a search through the Internet and I apologize for this unexpected intrusion on my part and the surprised effect it may cause given everything that is currently happening on the

drivers/vdpa/mlx5/core/resources.c:33: undefined reference to `mlx5_cmd_exec'

2020-09-19 Thread kernel test robot
-20200919 (attached as .config) compiler: riscv32-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout

Re: [PATCH] mm/gup: protect unpin_user_pages() against npages==-ERRNO

2020-09-19 Thread John Hubbard
On 9/19/20 8:03 PM, Souptick Joarder wrote: On Thu, Sep 17, 2020 at 1:11 PM Dan Carpenter wrote: On Wed, Sep 16, 2020 at 11:57:06PM -0700, John Hubbard wrote: As suggested by Dan Carpenter, fortify unpin_user_pages() just a bit, against a typical caller mistake: check if the npages arg is

[git pull] Input updates for v5.9-rc5

2020-09-19 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Just a couple of driver quirks. Changelog: - Hans de Goede (1): Input: i8042 - add Entroware Proteus EL07R4 to nomux and reset

[GIT PULL] Kbuild fixes for v5.9-rc6

2020-09-19 Thread Masahiro Yamada
Hi Linus, Please pull more fixes. Thanks. The following changes since commit 856deb866d16e29bd65952e0289066f6078af773: Linux 5.9-rc5 (2020-09-13 16:06:00 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git

Re: [PATCH] mm/gup: protect unpin_user_pages() against npages==-ERRNO

2020-09-19 Thread Souptick Joarder
On Thu, Sep 17, 2020 at 1:11 PM Dan Carpenter wrote: > > On Wed, Sep 16, 2020 at 11:57:06PM -0700, John Hubbard wrote: > > As suggested by Dan Carpenter, fortify unpin_user_pages() just a bit, > > against a typical caller mistake: check if the npages arg is really a > > -ERRNO value, which would

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Al Viro
On Sat, Sep 19, 2020 at 05:14:41PM -0700, Andy Lutomirski wrote: > > 2) have you counted the syscalls that do and do not need that? > > No. Might be illuminating... > > 3) how many of those realistically *can* be unified with their > > compat counterparts? [hint: ioctl(2) cannot] > > There

Re: [PATCH] tee: fix some comment typos in header files

2020-09-19 Thread Gustavo A. R. Silva
Hi, Here is another one you can solve: $ git grep -nw overlfow net/sctp/tsnmap.c:78:* overlfow our map Thanks -- Gustavo On 9/19/20 20:58, Elvira Khabirova wrote: > struct tee_param: revc -> recv. > TEE_IOC_SUPPL_SEND: typo introduced by copy-pasting, replace invalid > description with

[PATCH] misc: mic: scif: Fix error handling path

2020-09-19 Thread Souptick Joarder
Inside __scif_pin_pages(), when map_flags != SCIF_MAP_KERNEL it will call pin_user_pages_fast() to map nr_pages. However, pin_user_pages_fast() might fail with a return value -ERRNO. The return value is stored in pinned_pages->nr_pages. which in turn is passed to unpin_user_pages(), which expects

[PATCH] tee: fix some comment typos in header files

2020-09-19 Thread Elvira Khabirova
struct tee_param: revc -> recv. TEE_IOC_SUPPL_SEND: typo introduced by copy-pasting, replace invalid description with description from the according argument struct. Signed-off-by: Elvira Khabirova --- include/linux/tee_drv.h | 2 +- include/uapi/linux/tee.h | 2 +- 2 files changed, 2

Re: [PATCH] wireless: ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()

2020-09-19 Thread Brooke Basile
On 9/11/20 3:14 AM, Brooke Basile wrote: Calls to usb_kill_anchored_urbs() after usb_kill_urb() on multiprocessor systems create a race condition in which usb_kill_anchored_urbs() deallocates the URB before the completer callback is called in usb_kill_urb(), resulting in a use-after-free. To fix

Re: [PULL REQUEST] i2c for 5.9

2020-09-19 Thread pr-tracker-bot
The pull request you sent on Sat, 19 Sep 2020 18:02:06 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c8d1a46f943877c08d1154a6f90f43a245a671cf Thank you! -- Deet-doot-dot, I am a

[PATCH] x86/boot: Delay BSP init until after FPU initialization

2020-09-19 Thread Mike Hommey
FPU initialization handles the clearcpuid command line argument. If it comes after BSP init, clearcpuid cannot be used to disable features that trigger some parts of the BSP init code. Signed-off-by: Mike Hommey --- arch/x86/kernel/cpu/common.c | 7 --- 1 file changed, 4 insertions(+), 3

Re: R: [PATCH v2 4/4] dt-bindings: net: Document use of mac-address-increment

2020-09-19 Thread Andrew Lunn
On Sun, Sep 20, 2020 at 02:39:39AM +0200, ansuels...@gmail.com wrote: > > > > -Messaggio originale- > > Da: Andrew Lunn > > Inviato: domenica 20 settembre 2020 02:31 > > A: Ansuel Smith > > Cc: Miquel Raynal ; Richard Weinberger > > ; Vignesh Raghavendra ; Rob Herring > > ; David S.

R: [PATCH v2 4/4] dt-bindings: net: Document use of mac-address-increment

2020-09-19 Thread ansuelsmth
> -Messaggio originale- > Da: Andrew Lunn > Inviato: domenica 20 settembre 2020 02:31 > A: Ansuel Smith > Cc: Miquel Raynal ; Richard Weinberger > ; Vignesh Raghavendra ; Rob Herring > ; David S. Miller ; Jakub > Kicinski ; Heiner Kallweit ; > Russell King ; Frank Rowand > ; Boris

Apply For Your Business Loans

2020-09-19 Thread Loan
Our Financial Loan Grant scheme is Handled by the NAT-WEST BANK( NATIONAL WESTMINSTER BANK INTERNATIONAL.) apply Now !!! For Offer of over $3000- $30million or your countries currency, funding support for Loan from National West-minister Bank." For more information, Contact us via email:

Re: [PATCH v2 4/4] dt-bindings: net: Document use of mac-address-increment

2020-09-19 Thread Andrew Lunn
> + mac-address-increment: > +description: > + The MAC address can optionally be increased (or decreased using > + negative values) from the original value readed (from a nvmem cell Read is irregular, there is no readed, just read. > + for example). This can be used if the

Re: [PATCH v3 2/2] net: mdio-ipq4019: add Clause 45 support

2020-09-19 Thread Andrew Lunn
> + > +/* 0 = Clause 22, 1 = Clause 45 */ > +#define MDIO_MODE_BITBIT(8) How about calling this MDIO_MODE_C45 > + /* Enter Clause 45 mode */ > + data = readl(priv->membase + MDIO_MODE_REG); > + > + data |= MDIO_MODE_BIT; > + > +

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Andy Lutomirski
On Sat, Sep 19, 2020 at 4:24 PM Al Viro wrote: > > On Sat, Sep 19, 2020 at 03:53:40PM -0700, Andy Lutomirski wrote: > > > > It would not be a win - most of the syscalls don't give a damn > > > about 32bit vs. 64bit... > > > > Any reasonable implementation would optimize it out for syscalls that

[PATCH v2 1/2] exfat: add exfat_update_inode()

2020-09-19 Thread Tetsuhiro Kohada
Integrate exfat_sync_inode() and mark_inode_dirty() as exfat_update_inode() Also, return the result of _exfat_write_inode () when sync is specified. Signed-off-by: Tetsuhiro Kohada --- Changes in v2 - no change fs/exfat/exfat_fs.h | 2 +- fs/exfat/file.c | 5 + fs/exfat/inode.c|

[PATCH v2 2/2] exfat: aggregate dir-entry updates into __exfat_write_inode().

2020-09-19 Thread Tetsuhiro Kohada
The following function writes the updated inode information as dir-entry by themselves. - __exfat_truncate() - exfat_map_cluster() - exfat_find_empty_entry() Aggregate these writes into __exfat_write_inode(). Also, in __exfat_write_inode(), rename 'on_disk_size' to 'filesize' and add

Re: [PATCH net-next v2 0/3] 100base Fx link modes

2020-09-19 Thread David Miller
From: Dan Murphy Date: Fri, 18 Sep 2020 14:14:50 -0500 > As per patch https://lore.kernel.org/patchwork/patch/1300241/ the link > modes for 100base FX full and half duplex modes did not exist. Adding these > link modes to the core and ethtool allow devices like the DP83822, DP83869 and >

Re: [PATCH net-next] net/packet: Fix a comment about network_header

2020-09-19 Thread David Miller
From: Xie He Date: Fri, 18 Sep 2020 06:56:16 -0700 > skb->nh.raw has been renamed as skb->network_header in 2007, in > commit b0e380b1d8a8 ("[SK_BUFF]: unions of just one member don't get > anything done, kill them") > > So here we change it to the new name. > > Cc:

Re: [PATCH 1/2] ethtool: improve compat ioctl handling

2020-09-19 Thread David Miller
From: Arnd Bergmann Date: Fri, 18 Sep 2020 14:05:18 +0200 > --- a/net/ethtool/ioctl.c > +++ b/net/ethtool/ioctl.c ... > +static inline bool ethtool_translate_compat(void) > +{ Please don't use the inline keyword in foo.c files. Thank you.

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Al Viro
On Sat, Sep 19, 2020 at 03:53:40PM -0700, Andy Lutomirski wrote: > > It would not be a win - most of the syscalls don't give a damn > > about 32bit vs. 64bit... > > Any reasonable implementation would optimize it out for syscalls that don’t > care. Or it could be explicit: > >

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Andy Lutomirski
> On Sep 19, 2020, at 3:41 PM, Al Viro wrote: > > On Sat, Sep 19, 2020 at 03:23:54PM -0700, Andy Lutomirski wrote: >> On Sep 19, 2020, at 3:09 PM, Al Viro wrote: >>> >>> On Fri, Sep 18, 2020 at 05:16:15PM +0200, Christoph Hellwig wrote: > On Fri, Sep 18, 2020 at 02:58:22PM

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Al Viro
On Sat, Sep 19, 2020 at 03:23:54PM -0700, Andy Lutomirski wrote: > > > On Sep 19, 2020, at 3:09 PM, Al Viro wrote: > > > > On Fri, Sep 18, 2020 at 05:16:15PM +0200, Christoph Hellwig wrote: > >>> On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote: > >>> Said that, why not provide a

[PATCH v2 4/4] dt-bindings: net: Document use of mac-address-increment

2020-09-19 Thread Ansuel Smith
Two new bindings are now supported by the of_net driver to increase (or decrease) a mac-address. This can be very useful in case where the system extract the mac-address for the device from a dedicated partition and have a generic mac-address that needs to be incremented based on the device

[PATCH v2 2/4] dt-bindings: mtd: partition: Document use of nvmem-provider

2020-09-19 Thread Ansuel Smith
Document the use of this 2 new bindings, nvmem-provider and nvmem-cell, used to describe the nvmem cell that the subpartition provide to the nvmem api and the system. Nvmem cell are direct subnode of the subpartition and are skipped by the 'fixed-partitions' parser if they contain the 'nvmem-cell'

[PATCH v2 1/4] mtd: Add nvmem support for mtd nvmem-providers

2020-09-19 Thread Ansuel Smith
Introduce 2 new bindings for the mtd structure. Mtd partitions can be set as 'nvmem-provider' and any subpartition defined with the tag 'nvmem-cell' are skipped by the 'fixed-partitions' parser and registred as a nvmem cell by the nvmem api. Signed-off-by: Ansuel Smith --- drivers/mtd/mtdcore.c

[PATCH v2 3/4] of_net: add mac-address-increment support

2020-09-19 Thread Ansuel Smith
Lots of embedded devices use the mac-address of other interface extracted from nvmem cells and increments it by one or two. Add two bindings to integrate this and directly use the right mac-address for the interface. Some example are some routers that use the gmac mac-address stored in the art

[PATCH v2 0/4] Actually implement nvmem support for mtd

2020-09-19 Thread Ansuel Smith
The mtd support for the nvmem api has been stalled from 2018 with a patch half pushed hoping that a scheme is found for the mtd name later. This pathset try to address this and add a very needed feature for the mac-address. My solution to the already discussed problem here [1] is to keep it

Re: [PATCH 1/4] ARM/omap1: switch to use dma_direct_set_offset for lbus DMA offsets

2020-09-19 Thread Janusz Krzysztofik
Hi Tony, On Friday, September 18, 2020 7:49:33 A.M. CEST Tony Lindgren wrote: > * Christoph Hellwig [200917 17:37]: > > Switch the omap1510 platform ohci device to use dma_direct_set_offset > > to set the DMA offset instead of using direct hooks into the DMA > > mapping code and remove the now

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Andy Lutomirski
> On Sep 19, 2020, at 3:09 PM, Al Viro wrote: > > On Fri, Sep 18, 2020 at 05:16:15PM +0200, Christoph Hellwig wrote: >>> On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote: >>> Said that, why not provide a variant that would take an explicit >>> "is it compat" argument and use it there?

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Andy Lutomirski
> On Sep 19, 2020, at 2:16 PM, Arnd Bergmann wrote: > > On Sat, Sep 19, 2020 at 6:21 PM Andy Lutomirski wrote: >>> On Fri, Sep 18, 2020 at 8:16 AM Christoph Hellwig wrote: >>> On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote: Said that, why not provide a variant that would take

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Al Viro
On Fri, Sep 18, 2020 at 05:16:15PM +0200, Christoph Hellwig wrote: > On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote: > > Said that, why not provide a variant that would take an explicit > > "is it compat" argument and use it there? And have the normal > > one pass in_compat_syscall() to

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Finn Thain
On Sat, 19 Sep 2020, Arnd Bergmann wrote: > On Sat, Sep 19, 2020 at 6:21 PM Andy Lutomirski wrote: > > On Fri, Sep 18, 2020 at 8:16 AM Christoph Hellwig wrote: > > > On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote: > > > > Said that, why not provide a variant that would take an explicit

[PATCH 4/4] dt-bindings: net: Document use of mac-address-increment

2020-09-19 Thread Ansuel Smith
Two new bindings are now supported by the of_net driver to increase (or decrease) a mac-address. This can be very useful in case where the system extract the mac-address for the device from a dedicated partition and have a generic mac-address that needs to be incremented based on the device

[PATCH 1/4] mtd: Add nvmem support for mtd nvmem-providers

2020-09-19 Thread Ansuel Smith
Introduce 2 new bindings for the mtd structure. Mtd partitions can be set as 'nvmem-provider' and any subpartition defined with the tag 'nvmem-cell' are skipped by the 'fixed-partitions' parser and registred as a nvmem cell by the nvmem api. Signed-off-by: Ansuel Smith --- drivers/mtd/mtdcore.c

[PATCH 0/4] Actually implement nvmem support for mtd

2020-09-19 Thread Ansuel Smith
The mtd support for the nvmem api has been stalled from 2018 with a patch half pushed hoping that a scheme is found for the mtd name later. This pathset try to address this and add a very needed feature for the mac-address. My solution to the already discussed problem here [1] is to keep it

[PATCH 3/4] of_net: add mac-address-increment support

2020-09-19 Thread Ansuel Smith
Lots of embedded devices use the mac-address of other interface extracted from nvmem cells and increments it by one or two. Add two bindings to integrate this and directly use the right mac-address for the interface. Some example are some routers that use the gmac mac-address stored in the art

[PATCH 2/4] dt-bindings: mtd: partition: Document use of nvmem-provider

2020-09-19 Thread Ansuel Smith
Document the use of this 2 new bindings, nvmem-provider and nvmem-cell, used to describe the nvmem cell that the subpartition provide to the nvmem api and the system. Nvmem cell are direct subnode of the subpartition and are skipped by the 'fixed-partitions' parser if they contain the 'nvmem-cell'

My Dear in the lord

2020-09-19 Thread Mrs. Mina A. Brunel
My Dear in the lord My name is Mrs. Mina A. Brunel I am a Norway Citizen who is living in Burkina Faso, I am married to Mr. Brunel Patrice, a politicians who owns a small gold company in Burkina Faso; He died of Leprosy and Radesyge, in year February 2010, During his lifetime he deposited

[PATCH v2] regulator: unexport regulator_lock/unlock()

2020-09-19 Thread Michał Mirosław
regulator_lock/unlock() was used only to guard regulator_notifier_call_chain(). As no users remain, make the functions internal. Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 6 ++ include/linux/regulator/driver.h | 3 --- 2 files changed, 2 insertions(+), 7

[PATCH v7 3/4] input: elants: read touchscreen size for EKTF3624

2020-09-19 Thread Michał Mirosław
EKTF3624 as present in Asus TF300T tablet has touchscreen size encoded in different registers. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 84 -- 1 file changed, 79 insertions(+), 5

[PATCH v7 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreen

2020-09-19 Thread Michał Mirosław
This series cleans up the driver a bit and implements changes needed to support EKTF3624-based touchscreen used in Asus TF300T, Google Nexus 7 and similar Tegra3-based tablets. --- v2: extended with Dmitry's patches (replaced v1 patches 3 and 4) v3: rebased for v5.7-rc1 v4: rebased onto v5.7-rc2+

[PATCH v7 2/4] input: elants: support old touch report format

2020-09-19 Thread Michał Mirosław
Support ELAN touchpad sensor with older firmware as found on eg. Asus Transformer Pads. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 36 ++ 1 file changed, 25 insertions(+), 11

[PATCH v7 4/4] input: elants: support 0x66 reply opcode for reporting touches

2020-09-19 Thread Michał Mirosław
From: Dmitry Osipenko eKTF3624 touchscreen firmware uses two variants of the reply opcodes for reporting touch events: one is 0x63 (used by older firmware) and other is 0x66 (used by newer firmware). The 0x66 variant is equal to 0x63 of eKTH3500, while 0x63 needs small adjustment of the touch

[PATCH v7 1/4] input: elants: document some registers and values

2020-09-19 Thread Michał Mirosław
Add information found in downstream kernels, to make the code less magic. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git

[PATCH] staging:r8188eu: replace WIFI_REASON_CODE enum with native ieee80211_reasoncode

2020-09-19 Thread Ivan Safonov
WIFI_REASON_CODE is duplication of enum ieee80211_reasoncode. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 +-- drivers/staging/rtl8188eu/include/wifi.h | 31 --- 2 files changed, 2 insertions(+), 33 deletions(-) diff --git

Re: [PATCH net-next] net: neterion: Remove set but not used variable

2020-09-19 Thread David Miller
From: Zheng Yongjun Date: Sat, 19 Sep 2020 15:40:47 +0800 > @@ -179,7 +175,7 @@ enum vxge_hw_status vxge_hw_vpath_intr_disable( > (u32)VXGE_HW_INTR_MASK_ALL, > _reg->vpath_general_int_mask); > > - val64 = VXGE_HW_TIM_CLR_INT_EN_VP(1 << (16 - vpath->vp_id)); > +

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-19 Thread Arnd Bergmann
On Sat, Sep 19, 2020 at 6:21 PM Andy Lutomirski wrote: > On Fri, Sep 18, 2020 at 8:16 AM Christoph Hellwig wrote: > > On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote: > > > Said that, why not provide a variant that would take an explicit > > > "is it compat" argument and use it there?

Re: [PATCH net-next] net: micrel: Remove set but not used variable

2020-09-19 Thread David Miller
From: Zheng Yongjun Date: Sat, 19 Sep 2020 10:32:35 +0800 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/micrel/ksz884x.c: In function rx_proc: > drivers/net/ethernet/micrel/ksz884x.c:4981:6: warning: variable ‘rx_status’ > set but not used

Re: [PATCH net-next] net: liquidio: Remove set but not used variable

2020-09-19 Thread David Miller
From: Zheng Yongjun Date: Sat, 19 Sep 2020 09:31:23 +0800 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function > lio_pci_readq: > drivers/net/ethernet/cavium/liquidio/octeon_device.c:1327:6: warning: > variable ‘val32’ set but

Re: [PATCH net-next] net: e1000: Remove set but not used variable

2020-09-19 Thread David Miller
From: Zheng Yongjun Date: Sat, 19 Sep 2020 09:50:20 +0800 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/intel/e1000/e1000_hw.c: In function > e1000_phy_init_script: > drivers/net/ethernet/intel/e1000/e1000_hw.c:132:6: warning: variable > ‘ret_val’ set but not used

Re: [PATCH net-next] net: marvell: Remove set but not used variable

2020-09-19 Thread David Miller
From: Zheng Yongjun Date: Sat, 19 Sep 2020 10:05:50 +0800 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/marvell/pxa168_eth.c: In function pxa168_eth_change_mtu: > drivers/net/ethernet/marvell/pxa168_eth.c:1190:6: warning: variable ‘retval’ > set but not used

Re: 答复: [PATCH net-next] net: microchip: Remove set but not used variable

2020-09-19 Thread David Miller
From: zhengyongjun Date: Sat, 19 Sep 2020 03:02:39 + > This is the bad patch, please ignore it, thank you very much. Please do not quote your entire patch when you reply like this. It makes the reply look like a brand new patch to our patchwork tracking system, which makes more work for

Re: [PATCH net-next] net: natsemi: Remove set but not used variable

2020-09-19 Thread David Miller
From: Zheng Yongjun Date: Sat, 19 Sep 2020 10:46:44 +0800 > @@ -1226,8 +1226,8 @@ static int ns83820_get_link_ksettings(struct net_device > *ndev, > > /* read current configuration */ > cfg = readl(dev->base + CFG) ^ SPDSTS_POLARITY; > - tanar = readl(dev->base + TANAR); >

Re: [PATCH net-next] net: microchip: Remove set but not used variable

2020-09-19 Thread David Miller
From: Zheng Yongjun Date: Sat, 19 Sep 2020 10:39:09 +0800 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend: > drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ > set but not used

Re: [PATCH net-next] net: microchip: Remove set but not used variable

2020-09-19 Thread David Miller
From: Zheng Yongjun Date: Sat, 19 Sep 2020 10:37:32 +0800 > `ret` is never used, so remove it. You are not removing it: > @@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev) > /* Host sets PME_En, put D3hot */ > ret = pci_prepare_to_sleep(pdev); > > -

Re: [PATCH v3 2/2] mailbox: Add Broadcom STB mailbox driver

2020-09-19 Thread Jim Quinlan
On Sat, Sep 19, 2020 at 3:32 PM Randy Dunlap wrote: > > Hi Jim, > > On 9/19/20 12:22 PM, Jim Quinlan wrote: > > --- > > drivers/mailbox/Kconfig | 12 +++ > > drivers/mailbox/Makefile | 2 + > > drivers/mailbox/brcmstb-mailbox.c | 173 ++ > > 3

Re: [Linux-kernel-mentees] [PATCH] fs: fix KMSAN uninit-value bug by initializing nd in do_file_open_root

2020-09-19 Thread Anant Thazhemadam
On 19-09-2020 17:03, Anant Thazhemadam wrote: > On 19-09-2020 22:25, Al Viro wrote: >> On Sat, Sep 19, 2020 at 05:17:27PM +0100, Al Viro wrote: >> >>> Lovely... That would get an empty path and non-directory for a starting >>> point, but it should end up with LAST_ROOT in nd->last_type. Which

[PATCH v2] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-19 Thread Drew Fustini
Document the values in pinctrl-single,pins when #pinctrl-cells = <2> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2") Reported-by: Trent Piepho Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini --- v2 change: -

[PATCH] HID: multitouch: Lenovo X1 Tablet Gen3 trackpoint and buttons

2020-09-19 Thread Mikael Wikström
One more device that needs 40d5bb87 to resolve regression for the trackpoint and three mouse buttons on the type cover of the Lenovo X1 Tablet Gen3. It is probably also needed for the Lenovo X1 Tablet Gen2 with PID 0x60a3 Signed-off-by: Mikael Wikström --- drivers/hid/hid-ids.h| 1 +

[PATCH] ARM: dts: am335x: guardian: switch to AM33XX_PADCONF

2020-09-19 Thread Drew Fustini
Change the pin defintions from AM33XX_IOPAD to AM33XX_PADCONF macro so that it correctly handles changes to #pinctrl-cells. Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2") Reported-by: Trent Piepho Link:

Re: [PATCH v2] staging: media: atomisp: Fix error path in lm3554_probe()

2020-09-19 Thread Alex Dewar
On 2020-09-03 19:24, Alex Dewar wrote: The error path for lm3554_probe() contains a number of bugs, including: * resource leaks * jumping to error labels out of sequence * not setting the return value appropriately Ping? Fix it up and give the labels more memorable names. This issue

Re: [PATCH v2 2/2] Input: atmel_mxt_ts - wake mXT1386 from deep-sleep mode

2020-09-19 Thread Dmitry Osipenko
18.09.2020 18:55, Wang, Jiada пишет: ... >>>   +static void mxt_wake(struct mxt_data *data) >>> +{ >>> +    struct i2c_client *client = data->client; >>> +    struct device *dev = >client->dev; >>> +    struct device_node *np = dev->of_node; >>> +    union i2c_smbus_data dummy; >>> + >>> +    if

Re: [PATCH] checkpatch: extend author Signed-off-by check for split From: header

2020-09-19 Thread Joe Perches
On Sun, 2020-09-20 at 01:08 +0530, Dwaipayan Ray wrote: > On Sun, Sep 20, 2020 at 12:06 AM Lukas Bulwahn > wrote: > > On Sat, 19 Sep 2020, Joe Perches wrote: > > > On Sat, 2020-09-19 at 20:12 +0200, Lukas Bulwahn wrote: > > > > On Sat, 19 Sep 2020, Joe Perches wrote: > > > > > On Sat, 2020-09-19

Re: [PATCH] checkpatch: extend author Signed-off-by check for split From: header

2020-09-19 Thread Dwaipayan Ray
On Sun, Sep 20, 2020 at 12:06 AM Lukas Bulwahn wrote: > > > > On Sat, 19 Sep 2020, Joe Perches wrote: > > > On Sat, 2020-09-19 at 20:12 +0200, Lukas Bulwahn wrote: > > > > > > On Sat, 19 Sep 2020, Joe Perches wrote: > > > > > > > On Sat, 2020-09-19 at 13:42 +0530, Dwaipayan Ray wrote: > > > > >

[PATCH 2/3] drm/atomic: Use kthread worker for nonblocking commits

2020-09-19 Thread Rob Clark
From: Rob Clark This will allow us to more easily switch scheduling rules based on what userspace wants. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_atomic_helper.c | 13 include/drm/drm_atomic.h| 31 + 2 files changed, 40

[PATCH 0/3] drm: commit_work scheduling

2020-09-19 Thread Rob Clark
From: Rob Clark The android userspace treats the display pipeline as a realtime problem. And arguably, if your goal is to not miss frame deadlines (ie. vblank), it is. (See https://lwn.net/Articles/809545/ for the best explaination that I found.) But this presents a problem with using

[PATCH 3/3] drm: Add a client-cap to set scheduling mode

2020-09-19 Thread Rob Clark
From: Rob Clark Add DRM_CLIENT_CAP_SCHED_MODE so that userspace can control the scheduling mode for nonblocking atomic commits. Userspace such as android, which treats the display pipeline as realtime (SCHED_FIFO) should set DRM_CLIENT_CAP_SCHED_FIFO to prevent userspace components of the

[PATCH 1/3] drm/crtc: Introduce per-crtc kworker

2020-09-19 Thread Rob Clark
From: Rob Clark This will be used for non-block atomic commits. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_crtc.c | 11 +++ include/drm/drm_crtc.h | 8 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index

Re: [PATCH 2/2] staging: media: atomisp: Remove unhelpful info message

2020-09-19 Thread Alex Dewar
On 2020-09-03 19:31, Alex Dewar wrote: We don't really need to know that the LED pin reset successfully. Ping? Signed-off-by: Alex Dewar --- drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH] power: supply: charger-manager: Tidy function

2020-09-19 Thread Alex Dewar
On 2020-09-02 17:58, Alex Dewar wrote: check_charging_duration() contains some copy-pasted code, which makes it less readable. Refactor the function to be a bit tidier. Ping? I've also fixed a couple of typos. Signed-off-by: Alex Dewar --- drivers/power/supply/charger-manager.c | 39

Re: [PATCH v3 2/2] mailbox: Add Broadcom STB mailbox driver

2020-09-19 Thread Randy Dunlap
Hi Jim, On 9/19/20 12:22 PM, Jim Quinlan wrote: > --- > drivers/mailbox/Kconfig | 12 +++ > drivers/mailbox/Makefile | 2 + > drivers/mailbox/brcmstb-mailbox.c | 173 ++ > 3 files changed, 187 insertions(+) > create mode 100644

Re: [PATCH] drm/bridge: dw-mipi-dsi: Use kmemdup cf. kmalloc+memcpy

2020-09-19 Thread Alex Dewar
On 2020-09-11 13:57, Neil Armstrong wrote: On 09/09/2020 21:02, Alex Dewar wrote: kmemdup can be used instead of kmalloc+memcpy. Replace an occurrence of this pattern. Friendly ping? Issue identified with Coccinelle. Signed-off-by: Alex Dewar ---

Re: [PATCH] staging: media: atomisp: Don't do unnecessary zeroing of memory

2020-09-19 Thread Alex Dewar
On 2020-09-09 21:48, Alex Dewar wrote: In a few places in pci/sh_css_params.c, memset is used to zero memory immediately before it is freed. As none of these structs appear to contain sensitive information, just remove the calls to memset. Friendly ping? Suggested-by: Dan Carpenter

Re: [PATCH v2] PCI: keystone: Enable compile-testing on !ARM

2020-09-19 Thread Alex Dewar
On 2020-09-06 20:51, Alex Dewar wrote: Currently the Keystone driver can only be compile-tested on ARM, but this restriction seems unnecessary. Get rid of it to increase test coverage. Friendly ping? Build-tested with allyesconfig on x86, ppc, mips and riscv. Signed-off-by: Alex Dewar ---

[PATCH v2] net: dsa: mt7530: Add some return-value checks

2020-09-19 Thread Alex Dewar
In mt7531_cpu_port_config(), if the variable port is neither 5 nor 6, then variable interface will be used uninitialised. Change the function to return -EINVAL in this case. As the return value of mt7531_cpu_port_config() is never checked (even though it returns an int) add a check in the correct

[PATCH v3 1/2] dt-bindings: Add bindings for BrcmSTB SCMI mailbox driver

2020-09-19 Thread Jim Quinlan
Bindings are added. Only one interrupt is needed because we do not yet employ the SCMI p2a channel. Signed-off-by: Jim Quinlan --- .../bindings/mailbox/brcm,brcmstb-mbox.yaml | 39 +++ 1 file changed, 39 insertions(+) create mode 100644

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Jason Gunthorpe
On Sat, Sep 19, 2020 at 07:27:30PM +0200, Greg Kroah-Hartman wrote: > > It's probably heresy, but why do I need to integrate into the RDMA > > subsystem ? > > I understand your reasoning about networking (Ethernet) as the driver > > connects to the kernel networking stack (netdev), but with RDMA

[PATCH v3 2/2] mailbox: Add Broadcom STB mailbox driver

2020-09-19 Thread Jim Quinlan
This is a simple mailbox driver to be used by the SCMI protocol stack. It only implements the agent-to-platform channel; we may implement the platform-to-agent channel in the future. An unusual aspect of this driver is how the completion of an SCMI message is indicated. An SCMI message is

[PATCH v3 0/2] mailbox: Add Broadcom STB mailbox driver

2020-09-19 Thread Jim Quinlan
Patchset Summary: Adds a simple mailbox driver to be used by the ARM SCMI drivers. v3: Commit "mailbox: Add Broadcom STB mailbox driver" -- Fixed indentation on Kconfig file (RandyD). v2: Commit "mailbox: Add Broadcom STB mailbox driver" -- Remove the Kconfig dependency on SMP

Re: [PATCH -next v2] usb: gadget: lpc32xx_udc: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-19 Thread Vladimir Zapolskiy
On 9/19/20 5:52 AM, Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

2020-09-19 Thread Linus Torvalds
On Sat, Sep 19, 2020 at 10:39 AM Matthew Wilcox wrote: > > My concern with that is people might use kmap() and then pass the address > to a different task. So we need to audit the current users of kmap() > and convert any that do that into using vmap() instead. Ahh. Yes, I guess they might do

Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher

2020-09-19 Thread LABBE Corentin
On Fri, Sep 18, 2020 at 06:09:15PM +1000, Herbert Xu wrote: > On Fri, Sep 18, 2020 at 10:06:58AM +0200, LABBE Corentin wrote: > > > > But I think only me will see it and since I already have this on my TODO > > list, I dont see any interest to leave it failing. > > Furthermore, having a clean BE

[PATCH v2] dmaengine: qcom: Add ADM driver

2020-09-19 Thread Jonathan McDowell
Add the DMA engine driver for the QCOM Application Data Mover (ADM) DMA controller found in the MSM8x60 and IPQ/APQ8064 platforms. The ADM supports both memory to memory transactions and memory to/from peripheral device transactions. The controller also provides flow control capabilities for

[tip: x86/cpu] KVM: SVM: Don't flush cache if hardware enforces cache coherency across encryption domains

2020-09-19 Thread tip-bot2 for Krish Sadhukhan
The following commit has been merged into the x86/cpu branch of tip: Commit-ID: e1ebb2b49048c4767cfa0d8466f9c701e549fa5e Gitweb: https://git.kernel.org/tip/e1ebb2b49048c4767cfa0d8466f9c701e549fa5e Author:Krish Sadhukhan AuthorDate:Thu, 17 Sep 2020 21:20:38 Committer:

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Andrew Lunn
On Sat, Sep 19, 2020 at 07:43:28PM +0300, Oded Gabbay wrote: > It's probably heresy, but why do I need to integrate into the RDMA subsystem ? Hi Oded I don't know the RDMA subsystem at all. So i will give a more generic answer. Are you reinventing things which a subsystem core already has? The

Re: [PATCH] checkpatch: extend author Signed-off-by check for split From: header

2020-09-19 Thread Lukas Bulwahn
On Sat, 19 Sep 2020, Joe Perches wrote: > On Sat, 2020-09-19 at 20:12 +0200, Lukas Bulwahn wrote: > > > > On Sat, 19 Sep 2020, Joe Perches wrote: > > > > > On Sat, 2020-09-19 at 13:42 +0530, Dwaipayan Ray wrote: > > > > Checkpatch did not handle cases where the author From: header > > > >

Re: [PATCH] checkpatch: extend author Signed-off-by check for split From: header

2020-09-19 Thread Joe Perches
On Sat, 2020-09-19 at 20:12 +0200, Lukas Bulwahn wrote: > > On Sat, 19 Sep 2020, Joe Perches wrote: > > > On Sat, 2020-09-19 at 13:42 +0530, Dwaipayan Ray wrote: > > > Checkpatch did not handle cases where the author From: header > > > was split into two lines. The author string went empty and >

Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro

2020-09-19 Thread hpa
On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski wrote: >On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig >wrote: >> >> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote: >> > sys_move_pages() is an optional syscall, and once we remove >> > the compat version of it in favor of

Re: [PATCH AUTOSEL 5.4 265/330] drm/amd/powerplay: try to do a graceful shutdown on SW CTF

2020-09-19 Thread Sasha Levin
On Fri, Sep 18, 2020 at 09:57:37AM -0400, Alex Deucher wrote: On Fri, Sep 18, 2020 at 3:17 AM Quan, Evan wrote: [AMD Official Use Only - Internal Distribution Only] Hi @Sasha Levin @Deucher, Alexander, The following changes need to be applied also. Otherwise, you may see unexpected shutdown

Re: [PATCH 2/2] Add a new sysctl knob: unprivileged_userfaultfd_user_mode_only

2020-09-19 Thread Nick Kralevich
On Fri, Sep 4, 2020 at 5:36 PM Lokesh Gidra wrote: > > On Thu, Sep 3, 2020 at 8:34 PM Andrea Arcangeli wrote: > > > > 1) why don't you enforce the block of kernel initiated faults with > >seccomp-bpf instead of adding a sysctl value 2? Is the sysctl just > >an optimization to remove a

Re: [PATCH] checkpatch: extend author Signed-off-by check for split From: header

2020-09-19 Thread Lukas Bulwahn
On Sat, 19 Sep 2020, Joe Perches wrote: > On Sat, 2020-09-19 at 13:42 +0530, Dwaipayan Ray wrote: > > Checkpatch did not handle cases where the author From: header > > was split into two lines. The author string went empty and > > checkpatch generated a false NO_AUTHOR_SIGN_OFF warning. > >

Re: [PATCH AUTOSEL 5.4 101/330] powerpc/powernv/ioda: Fix ref count for devices with their own PE

2020-09-19 Thread Sasha Levin
On Fri, Sep 18, 2020 at 08:35:06AM +0200, Frederic Barrat wrote: Le 18/09/2020 à 03:57, Sasha Levin a écrit : From: Frederic Barrat [ Upstream commit 05dd7da76986937fb288b4213b1fa10dbe0d1b33 ] This patch is not desirable for stable, for 5.4 and 4.19 (it was already flagged by autosel

Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support

2020-09-19 Thread Marek Behun
Besides Pavel's note about the __attribute__((nonnull)) position Reviewed-by: Marek Behún

  1   2   3   4   >