[PATCH] scsi: isci: Fix a typo in a comment

2020-10-02 Thread Christophe JAILLET
s/remtoe/remote/ and add a missing '.' Signed-off-by: Christophe JAILLET --- drivers/scsi/isci/remote_node_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/isci/remote_node_table.h b/drivers/scsi/isci/remote_node_table.h index 721ab982d2ac..0ddfdda2b248

Re: [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address

2020-10-02 Thread Anant Thazhemadam
On 03-10-2020 04:08, David Miller wrote: > From: Anant Thazhemadam > Date: Fri, 2 Oct 2020 17:04:13 +0530 > >> But this patch is about ensuring that an uninitialized variable's >> value (whatever that may be) is not set as the ethernet address >> blindly (without any form of checking if

Re: [PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-02 Thread Benjamin Poirier
On 2020-10-03 07:59 +0800, Coiby Xu wrote: > This fixes commit 0107635e15ac > ("staging: qlge: replace pr_err with netdev_err") which introduced an > build breakage of missing `struct ql_adapter *qdev` for some functions > and a warning of type mismatch with dumping enabled, i.e., > > $ make

Re: [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address

2020-10-02 Thread Anant Thazhemadam
On 02-10-2020 19:59, Petko Manolov wrote: > On 20-10-02 17:35:25, Anant Thazhemadam wrote: >> Yes, this clears things up for me. I'll see to it that this gets done in a >> v3. > If set_ethernet_addr() fail, don't return error, but use eth_hw_addr_random() > instead to set random MAC address

Re: [PATCH] selftests/vm: 10x speedup for hmm-tests

2020-10-02 Thread John Hubbard
On 10/2/20 10:23 PM, SeongJae Park wrote: On Fri, 2 Oct 2020 18:17:21 -0700 John Hubbard wrote: This patch reduces the running time for hmm-tests from about 10+ seconds, to just under 1.0 second, for an approximately 10x speedup. That brings it in line with most of the other tests in

Re: [PATCH v6 4/5] PCI: only return true when dev io state is really changed

2020-10-02 Thread Ethan Zhao
Sinan, On Sat, Oct 3, 2020 at 12:08 AM Sinan Kaya wrote: > > On 9/30/2020 3:05 AM, Ethan Zhao wrote: > > When uncorrectable error happens, AER driver and DPC driver interrupt > > handlers likely call > > > >pcie_do_recovery() > >->pci_walk_bus() > > ->report_frozen_detected() > > >

[PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

2020-10-02 Thread Si-Wei Liu
Pinned pages are not properly accounted particularly when mapping error occurs on IOTLB update. Clean up dangling pinned pages for the error path. As the inflight pinned pages, specifically for memory region that strides across multiple chunks, would need more than one free page for book keeping

[PATCH v3 1/2] vhost-vdpa: fix vhost_vdpa_map() on error condition

2020-10-02 Thread Si-Wei Liu
vhost_vdpa_map() should remove the iotlb entry just added if the corresponding mapping fails to set up properly. Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend") Signed-off-by: Si-Wei Liu --- drivers/vhost/vdpa.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v3 0/2] vhost-vdpa mapping error path fixes

2020-10-02 Thread Si-Wei Liu
Commit 4c8cf31885f6 ("vhost: introduce vDPA-based backend") has following issues in the failure path of IOTLB update: 1) vhost_vdpa_map() does not clean up dangling iotlb entry upon mapping failure 2) vhost_vdpa_process_iotlb_update() has leakage of pinned pages in case of vhost_vdpa_map()

[PULL REQUEST] i2c for 5.9

2020-10-02 Thread Wolfram Sang
Linus, some more driver fixes from I2C. Please pull. Thanks, Wolfram The following changes since commit ba4f184e126b751d1bffad5897f263108befc780: Linux 5.9-rc6 (2020-09-20 16:33:55 -0700) are available in the Git repository at:

Re: [PATCH 4/4] x86/cpu/topology: Implement the CPU type sysfs interface

2020-10-02 Thread kernel test robot
Hi Ricardo, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on tip/master driver-core/driver-core-testing linus/master v5.9-rc7 next-20201002] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH] selftests/vm: 10x speedup for hmm-tests

2020-10-02 Thread SeongJae Park
On Fri, 2 Oct 2020 18:17:21 -0700 John Hubbard wrote: > This patch reduces the running time for hmm-tests from about 10+ > seconds, to just under 1.0 second, for an approximately 10x speedup. > That brings it in line with most of the other tests in selftests/vm, > which mostly run in < 1 sec. >

mmotm 2020-10-02-22-22 uploaded

2020-10-02 Thread akpm
The mm-of-the-moment snapshot 2020-10-02-22-22 has been uploaded to https://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: https://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You

Re: [PATCH v39 16/24] x86/sgx: Add a page reclaimer

2020-10-02 Thread Haitao Huang
When I turn on CONFIG_PROVE_LOCKING, kernel reports following suspicious RCU usages. Not sure if it is an issue. Just reporting here: [ +34.337095] = [ +0.01] WARNING: suspicious RCU usage [ +0.02] 5.9.0-rc6-lock-sgx39 #1 Not tainted [ +0.01]

Re: [PATCH] FIX the comment of struct jbd2_journal_handle

2020-10-02 Thread Theodore Y. Ts'o
On Wed, Sep 23, 2020 at 01:12:31AM +0800, Hui Su wrote: > the struct name was modified long ago, but the comment still > use struct handle_s. > > Signed-off-by: Hui Su Tnanks, applied. I updated the commit summary to be: jbd2: fix the comment of struct jbd2_journal_handle

Re: [PATCH] ext4: fix leaking sysfs kobject after failed mount

2020-10-02 Thread Theodore Y. Ts'o
On Thu, Sep 24, 2020 at 11:08:59AM +0200, Jan Kara wrote: > On Tue 22-09-20 09:24:56, Eric Biggers wrote: > > From: Eric Biggers > > > > ext4_unregister_sysfs() only deletes the kobject. The reference to it > > needs to be put separately, like ext4_put_super() does. > > > > This addresses the

[PATCH v39 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson An SGX runtime must be aware of the exceptions, which happen inside an enclave. Introduce a vDSO call that wraps EENTER/ERESUME cycle and returns the CPU exception back to the caller exactly when it happens. Kernel fixups the exception information to RDI, RSI and RDX.

[PATCH v39 13/24] x86/sgx: Add SGX_IOC_ENCLAVE_ADD_PAGES

2020-10-02 Thread Jarkko Sakkinen
Add an ioctl, which performs ENCLS[EADD] that adds new visible page to an enclave, and optionally ENCLS[EEXTEND] operations that hash the page to the enclave measurement. By visible we mean a page that can be mapped to the address range of an enclave. Acked-by: Jethro Beekman Tested-by: Jethro

[PATCH v39 15/24] x86/sgx: Add SGX_IOC_ENCLAVE_PROVISION

2020-10-02 Thread Jarkko Sakkinen
Provisioning Certification Enclave (PCE), the root of trust for other enclaves, generates a signing key from a fused key called Provisioning Certification Key. PCE can then use this key to certify an attestation key of a Quoting Enclave (QE), e.g. we get the chain of trust down to the hardware if

[PATCH v39 16/24] x86/sgx: Add a page reclaimer

2020-10-02 Thread Jarkko Sakkinen
There is a limited amount of EPC available. Therefore, some of it must be copied to the regular memory, and only subset kept in the SGX reserved memory. While kernel cannot directly access enclave memory, SGX provides a set of ENCLS leaf functions to perform reclaiming. Implement a page reclaimer

[PATCH v39 19/24] x86/fault: Add helper function to sanitize error code

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson Add helper function to sanitize error code to prepare for vDSO exception fixup, which will expose the error code to userspace and runs before set_signal_archinfo(), i.e. suppresses the signal when fixup is successful. Acked-by: Jethro Beekman Signed-off-by: Sean

[PATCH v39 20/24] x86/traps: Attempt to fixup exceptions in vDSO before signaling

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson vDSO functions can now leverage an exception fixup mechanism similar to kernel exception fixup. For vDSO exception fixup, the initial user is Intel's Software Guard Extensions (SGX), which will wrap the low-level transitions to/from the enclave, i.e. EENTER and ERESUME

[PATCH v39 18/24] x86/vdso: Add support for exception fixup in vDSO functions

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson The basic concept and implementation is very similar to the kernel's exception fixup mechanism. The key differences are that the kernel handler is hardcoded and the fixup entry addresses are relative to the overall table as opposed to individual entries. Hardcoding

[PATCH v39 17/24] x86/sgx: Add ptrace() support for the SGX driver

2020-10-02 Thread Jarkko Sakkinen
Intel Sofware Guard eXtensions (SGX) allows creation of executable blobs called enclaves, which cannot be accessed by default when not executing inside the enclave. Enclaves can be entered by only using predefined memory addresses, which are defined when the enclave is loaded. However, enclaves

[PATCH v39 23/24] docs: x86/sgx: Document SGX micro architecture and kernel internals

2020-10-02 Thread Jarkko Sakkinen
Document the Intel SGX kernel architecture. The fine-grained micro architecture details can be looked up from Intel SDM Volume 3D. Cc: linux-...@vger.kernel.org Acked-by: Randy Dunlap Co-developed-by: Sean Christopherson Signed-off-by: Sean Christopherson Signed-off-by: Jarkko Sakkinen ---

[PATCH v39 22/24] selftests/x86: Add a selftest for SGX

2020-10-02 Thread Jarkko Sakkinen
Add a selftest for SGX. It is a trivial test where a simple enclave copies one 64-bit word of memory between two memory locations. Cc: Shuah Khan Cc: linux-kselft...@vger.kernel.org Signed-off-by: Jarkko Sakkinen --- tools/testing/selftests/Makefile | 1 +

[PATCH v39 24/24] x86/sgx: Update MAINTAINERS

2020-10-02 Thread Jarkko Sakkinen
Add the maintainer information for the SGX subsystem. Cc: Thomas Gleixner Cc: Borislav Petkov Signed-off-by: Jarkko Sakkinen --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b81aad6f7f97..ca1995b1ef45 100644 --- a/MAINTAINERS +++

[PATCH v39 10/24] mm: Add 'mprotect' hook to struct vm_operations_struct

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson Background == 1. SGX enclave pages are populated with data by copying data to them from normal memory via an ioctl() (SGX_IOC_ENCLAVE_ADD_PAGES). 2. It is desirable to be able to restrict those normal memory data sources. For instance, to ensure that the

[PATCH v39 14/24] x86/sgx: Add SGX_IOC_ENCLAVE_INIT

2020-10-02 Thread Jarkko Sakkinen
Add an ioctl that performs ENCLS[EINIT], which locks down the measurement and initializes the enclave for entrance. After this, new pages can no longer be added. Acked-by: Jethro Beekman Tested-by: Jethro Beekman Tested-by: Haitao Huang Tested-by: Chunyang Hui Tested-by: Jordan Hand

[PATCH v39 07/24] x86/cpu/intel: Add nosgx kernel parameter

2020-10-02 Thread Jarkko Sakkinen
Add kernel parameter to disable Intel SGX kernel support. Tested-by: Sean Christopherson Reviewed-by: Sean Christopherson Reviewed-by: Darren Kenny Signed-off-by: Jarkko Sakkinen --- Documentation/admin-guide/kernel-parameters.txt | 2 ++ arch/x86/kernel/cpu/feat_ctl.c | 9

[PATCH v39 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-10-02 Thread Jarkko Sakkinen
Add an ioctl that performs ENCLS[ECREATE], which creates SGX Enclave Control Structure for the enclave. SECS contains attributes about the enclave that are used by the hardware and cannot be directly accessed by software, as SECS resides in the EPC. One essential field in SECS is a field that

[PATCH v39 01/24] x86/cpufeatures: x86/msr: Add Intel SGX hardware bits

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson Add X86_FEATURE_SGX from CPUID.(EAX=7, ECX=1), which informs whether the CPU has SGX. Add X86_FEATURE_SGX1 and X86_FEATURE_SGX2 from CPUID.(EAX=12H, ECX=0), which describe the level of SGX support available [1]. Add IA32_FEATURE_CONTROL.SGX_ENABLE. BIOS can use this

[PATCH v39 05/24] x86/sgx: Add wrappers for ENCLS leaf functions

2020-10-02 Thread Jarkko Sakkinen
ENCLS is a ring 0 instruction, which contains a set of leaf functions for managing an enclave. Enclaves are measured and signed software entities, which are protected by asserting the outside memory accesses and memory encryption. Add a two-layer macro system along with an encoding scheme to

[PATCH v39 09/24] x86/sgx: Add __sgx_alloc_epc_page() and sgx_free_epc_page()

2020-10-02 Thread Jarkko Sakkinen
Add __sgx_alloc_epc_page(), which iterates through EPC sections and borrows a page structure that is not used by anyone else. When a page is no longer needed it must be released with sgx_free_epc_page(). This function implicitly calls ENCLS[EREMOVE], which will return the page to the uninitialized

[PATCH v39 00/24] Intel SGX foundations

2020-10-02 Thread Jarkko Sakkinen
Intel(R) SGX is a set of CPU instructions that can be used by applications to set aside private regions of code and data. The code outside the enclave is disallowed to access the memory inside the enclave by the CPU access control. There is a new hardware unit in the processor called Memory

[PATCH v39 04/24] x86/sgx: Add SGX microarchitectural data structures

2020-10-02 Thread Jarkko Sakkinen
Define the SGX microarchitectural data structures used by various SGX opcodes. This is not an exhaustive representation of all SGX data structures but only those needed by the kernel. The data structures are described in: Intel SDM: 37.6 INTEL® SGX DATA STRUCTURES OVERVIEW Acked-by: Jethro

[PATCH v39 02/24] x86/cpufeatures: x86/msr: Add Intel SGX Launch Control hardware bits

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson Add X86_FEATURE_SGX_LC, which informs whether or not the CPU supports SGX Launch Control. Add MSR_IA32_SGXLEPUBKEYHASH{0, 1, 2, 3}, which when combined contain a SHA256 hash of a 3072-bit RSA public key. SGX backed software packages, so called enclaves, are always

[PATCH v39 06/24] x86/cpu/intel: Detect SGX support

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson Configure SGX as part of feature control MSR initialization and update the associated X86_FEATURE flags accordingly. Because the kernel will require the LE hash MSRs to be writable when running native enclaves, disable X86_FEATURE_SGX (and all derivatives) if SGX

[PATCH v39 11/24] x86/sgx: Add SGX enclave driver

2020-10-02 Thread Jarkko Sakkinen
Intel Software Guard eXtensions (SGX) is a set of CPU instructions that can be used by applications to set aside private regions of code and data. The code outside the SGX hosted software entity is prevented from accessing the memory inside the enclave by the CPU. We call these entities enclaves.

[PATCH v39 03/24] x86/mm: x86/sgx: Signal SIGSEGV with PF_SGX

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson Include SGX bit to the PF error codes and throw SIGSEGV with PF_SGX when a #PF with SGX set happens. CPU throws a #PF with the SGX set in the event of Enclave Page Cache Map (EPCM) conflict. The EPCM is a CPU-internal table, which describes the properties for a enclave

[PATCH v39 08/24] x86/sgx: Initialize metadata for Enclave Page Cache (EPC) sections

2020-10-02 Thread Jarkko Sakkinen
From: Sean Christopherson Enumerate Enclave Page Cache (EPC) sections via CPUID and add the data structures necessary to track EPC pages so that they can be easily borrowed for different uses. Embed section index to the first eight bits of the EPC page descriptor. Existing client hardware

[git pull] Input updates for v5.9-rc7

2020-10-02 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. A couple more drover quirks, now enabling newer trackpoints from Synaptics for real. Changelog: - Jiri Kosina (1): Input: i8042

Re: [PATCHv3 1/1] ext4: Optimize file overwrites

2020-10-02 Thread Theodore Y. Ts'o
On Fri, Sep 18, 2020 at 10:36:35AM +0530, Ritesh Harjani wrote: > In case if the file already has underlying blocks/extents allocated > then we don't need to start a journal txn and can directly return > the underlying mapping. Currently ext4_iomap_begin() is used by > both DAX & DIO path. We can

drivers/net/ethernet/huawei/hinic/hinic_main.c:796:25: sparse: sparse: cast to restricted __be16

2020-10-02 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d3d45f8220d60a0b2cf8fb2be4e6ffd9008e commit: 1f62cfa19a619f82c098468660b7950477101d45 hinic: add net_device_ops associated with vf date: 5 months ago config: x86_64-randconfig-s022-20201003 (attached

Re: [PATCH] [v2] ext4: Fix error handling code in add_new_gdb

2020-10-02 Thread Theodore Y. Ts'o
On Sat, Aug 29, 2020 at 10:54:02AM +0800, Dinghao Liu wrote: > When ext4_journal_get_write_access() fails, we should > terminate the execution flow and release n_group_desc, > iloc.bh, dind and gdb_bh. > > Signed-off-by: Dinghao Liu Thanks, applied. - Ted

Re: [PATCH] compat: move strut compat_iovec out of #ifdef CONFIG_COMPAT

2020-10-02 Thread Al Viro
On Fri, Oct 02, 2020 at 08:15:12AM +0200, Christoph Hellwig wrote: > ping? This is needed to unbreak the work.iov_iter branch that is in > for-next. Folded into "iov_iter: refactor rw_copy_check_uvector and import_iovec" and force-pushed...

Re: [PATCH 2/4] x86/cpu: Describe hybrid CPUs in cpuinfo_x86

2020-10-02 Thread kernel test robot
Hi Ricardo, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on tip/master driver-core/driver-core-testing linus/master v5.9-rc7 next-20201002] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v3 4/7] dma-buf: heaps: Skip sync if not mapped

2020-10-02 Thread John Stultz
This patch is basically a port of Ørjan Eide's similar patch for ION https://lore.kernel.org/lkml/20200414134629.54567-1-orjan.e...@arm.com/ Only sync the sg-list of dma-buf heap attachment when the attachment is actually mapped on the device. dma-bufs may be synced at any time. It can be

[PATCH v3 6/7] dma-buf: dma-heap: Keep track of the heap device struct

2020-10-02 Thread John Stultz
Keep track of the heap device struct. This will be useful for special DMA allocations and actions. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Chris Goldsworthy Cc: Ørjan Eide Cc:

[PATCH v3 2/7] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation

2020-10-02 Thread John Stultz
Since the heap-helpers logic ended up not being as generic as hoped, move the heap-helpers dma_buf_ops implementations into the cma_heap directly. This will allow us to remove the heap_helpers code in a following patch. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc:

[PATCH v3 3/7] dma-buf: heaps: Remove heap-helpers code

2020-10-02 Thread John Stultz
The heap-helpers code was not as generic as initially hoped and it is now not being used, so remove it from the tree. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Chris Goldsworthy Cc:

[PATCH v3 5/7] dma-buf: system_heap: Allocate higher order pages if available

2020-10-02 Thread John Stultz
While the system heap can return non-contiguous pages, try to allocate larger order pages if possible. This will allow slight performance gains and make implementing page pooling easier. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren

[PATCH v3 1/7] dma-buf: system_heap: Rework system heap to use sgtables instead of pagelists

2020-10-02 Thread John Stultz
In preparation for some patches to optmize the system heap code, rework the dmabuf exporter to utilize sgtables rather then pageslists for tracking the associated pages. This will allow for large order page allocations, as well as more efficient page pooling. In doing so, the system heap stops

[PATCH v3 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap

2020-10-02 Thread John Stultz
This adds a heap that allocates non-contiguous buffers that are marked as writecombined, so they are not cached by the CPU. This is useful, as most graphics buffers are usually not touched by the CPU or only written into once by the CPU. So when mapping the buffer over and over between devices,

[PATCH v3 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

2020-10-02 Thread John Stultz
Hey All, So this is another revision of my patch series to performance optimizations to the dma-buf system heap. Unfortunately, in working these up, I realized the heap-helpers infrastructure we tried to add to miniimize code duplication is not as generic as we intended. For some heaps it makes

Re: [PATCH v4 1/3] iommu/tegra-smmu: Use fwspec in tegra_smmu_(de)attach_dev

2020-10-02 Thread Dmitry Osipenko
03.10.2020 02:53, Nicolin Chen пишет: > On Fri, Oct 02, 2020 at 11:12:18PM +0300, Dmitry Osipenko wrote: >> 02.10.2020 22:45, Nicolin Chen пишет: >>> On Fri, Oct 02, 2020 at 05:41:50PM +0300, Dmitry Osipenko wrote: 02.10.2020 09:08, Nicolin Chen пишет: > static int

Re: [PATCHv2 1/3] ext4: Refactor ext4_overwrite_io() to take ext4_map_blocks as argument

2020-10-02 Thread Theodore Y. Ts'o
On Sat, Aug 22, 2020 at 05:04:35PM +0530, Ritesh Harjani wrote: > Refactor ext4_overwrite_io() to take struct ext4_map_blocks > as it's function argument with m_lblk and m_len filled > from caller > > There should be no functionality change in this patch. > > Signed-off-by: Ritesh Harjani > ---

[tip:timers/core] BUILD SUCCESS 1b80043ed21894eca888157145b955df02887995

2020-10-02 Thread kernel test robot
defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201002 x86_64

Re: [PATCH 4/4] x86/cpu/topology: Implement the CPU type sysfs interface

2020-10-02 Thread Randy Dunlap
On 10/2/20 6:17 PM, Ricardo Neri wrote: > +u32 arch_get_cpu_type(int cpu) > +{ > + struct cpuinfo_x86 *c = _data(cpu); > + > + if (cpu < 0 || cpu >= nr_cpu_ids) > + return 0; > + > + return c->x86_cpu_type;> +} Hi, Consider using #include and array_index_nospec() to

Re: [PATCH 1/4] drivers core: Introduce CPU type sysfs interface

2020-10-02 Thread Randy Dunlap
On 10/2/20 6:17 PM, Ricardo Neri wrote: > +/** > + * arch_get_cpu_type() - Get the CPU type number > + * @cpu: Index of the CPU of which the index is needed > + * > + * Get the CPU type number of @cpu, a non-zero unsigned 32-bit number that Are you sure that @cpu is non-zero? > + * uniquely

Re: [PATCH v2] scsi: ufs-exynos: use devm_platform_ioremap_resource_byname()

2020-10-02 Thread Martin K. Petersen
On Wed, 16 Sep 2020 10:40:17 +0200, Bean Huo wrote: > Use devm_platform_ioremap_resource_byname() to simplify the code. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: ufs: ufs-exynos: Use devm_platform_ioremap_resource_byname() https://git.kernel.org/mkp/scsi/c/2dd39fad92a1 -- Martin

Re: [PATCH v3] mailbox: mediatek: Fix handling of platform_get_irq() error

2020-10-02 Thread Chun-Kuang Hu
Krzysztof Kozlowski 於 2020年8月28日 週五 上午2:25寫道: > > platform_get_irq() returns -ERRNO on error. In such case casting to u32 > and comparing to 0 would pass the check. > Reviewed-by: Chun-Kuang Hu > Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver") > Signed-off-by: Krzysztof

Re: [PATCH v38 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-10-02 Thread Jarkko Sakkinen
On Fri, Oct 02, 2020 at 07:23:55PM -0500, Haitao Huang wrote: > On Tue, 15 Sep 2020 06:28:30 -0500, Jarkko Sakkinen > wrote: > > > Add an ioctl that performs ENCLS[ECREATE], which creates SGX Enclave > > Control Structure for the enclave. SECS contains attributes about the > > enclave that are

Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-10-02 Thread Chun-Kuang Hu
Hi, Jassi: Jassi Brar 於 2020年10月3日 週六 上午4:30寫道: > > On Sun, Sep 27, 2020 at 6:04 PM Chun-Kuang Hu wrote: > > > > CMDQ helper provide timer to detect execution timeout, but DRM driver > > could have a better way to detect execution timeout by vblank IRQ. > > For DRM, CMDQ command should execute

[rcu:rcu/next] BUILD SUCCESS d6dc6c311e779d1d01e9395f27bf6f4315db5502

2020-10-02 Thread kernel test robot
powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201002 x86_64 randconfig-a001-20201002 x86_64 randconfig-a002-20201002 x86_64

Re: [PATCH v2 2/6] fpga: m10bmc-sec: create max10 bmc security engine

2020-10-02 Thread Randy Dunlap
On 10/2/20 6:24 PM, Russ Weight wrote: > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index c534cc80f398..2380d36b08c7 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -235,4 +235,15 @@ config IFPGA_SEC_MGR > region and for the BMC. Select this option to

Re: [PATCH 0/7] hisi_sas: Add runtime PM support for v3 hw

2020-10-02 Thread Martin K. Petersen
John, > This series adds runtime PM support for v3 hw. Consists of: > - Switch to new PM suspend and resume framework > - Add links to devices to ensure host cannot be suspended while devices > are not > - Filter out phy events during suspend to avoid deadlock > - Add controller RPM support >

include/linux/sched/topology.h:237:9: error: implicit declaration of function 'cpu_logical_map'

2020-10-02 Thread kernel test robot
Hi Rafael, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d3d45f8220d60a0b2cf8fb2be4e6ffd9008e commit: 5b5642075c317e67ea342a2fb8023a8e754a5002 Merge branches 'pm-em' and 'pm-core' date: 9 weeks ago config:

Re: virtiofs: WARN_ON(out_sgs + in_sgs != total_sgs)

2020-10-02 Thread Qian Cai
vsock_loopback vmw_vsock_virtio_transport_common vmw_vsock_vmci_transport vsock mpls_router vmw_vmci ip_tunnel as [ 9863.474555] ata_piix fuse serio_raw libata e1000 sunrpc dm_mirror dm_region_hash dm_log dm_mod [ 9863.535805] CPU: 16 PID: 286083 Comm: trinity-c5 Kdump: loaded Not tainted 5.9.0-rc

Re: [PATCH][next] bpf: verifier: Use fallthrough pseudo-keyword

2020-10-02 Thread Yonghong Song
On 10/2/20 4:42 PM, Gustavo A. R. Silva wrote: Replace /* fallthrough */ comments with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva

Re: Litmus test for question from Al Viro

2020-10-02 Thread Jon Masters
On 10/1/20 12:15 PM, Alan Stern wrote: On Wed, Sep 30, 2020 at 09:51:16PM -0700, Paul E. McKenney wrote: Hello! Al Viro posted the following query: fun question regarding barriers, if you have time for that

Re: WARNING in ieee80211_bss_info_change_notify

2020-10-02 Thread syzbot
syzbot has bisected this issue to: commit 135f971181d779c96ff3725c1a350a721785cc66 Author: Alex Deucher Date: Mon Nov 20 22:49:53 2017 + drm/amdgpu: don't skip attributes when powerplay is enabled bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=120f55bd90 start

Re: [PATCH 0/4] scsi: arcmsr: Fix timer stop and support new adapter ARC-1886 series

2020-10-02 Thread Martin K. Petersen
ching, > This patch series are against to mkp's 5.10/scsi-queue. > > 1. Remove unnecessary syntax. > 2. Fix device hot-plug monitoring timer stop. > 3. Add supporting ARC-1886 series Raid controllers. > 4. Update driver version to v1.50.00.02-20200819. Applied to 5.10/scsi-staging, thanks! --

include/linux/topology.h:119:9: error: implicit declaration of function 'cpu_logical_map'

2020-10-02 Thread kernel test robot
Hi Fangrui, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d4fce2e20ffed59eb5db7780fcbbb0a21decef74 commit: ca9b31f6bb9c6aa9b4e5f0792f39a97bbffb8c51 Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross

Re: [PATCH 0/3] x86: Add initial support to discover Intel hybrid CPUs

2020-10-02 Thread Luck, Tony
On Sat, Oct 03, 2020 at 03:39:29AM +0200, Thomas Gleixner wrote: > On Fri, Oct 02 2020 at 13:19, Ricardo Neri wrote: > > Add support to discover and enumerate CPUs in Intel hybrid parts. A hybrid > > part has CPUs with more than one type of micro-architecture. Thus, certain > > features may only

Re: [PATCH] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-02 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-02 15:09:19) > Connection state is set incorrectly happen at either failure of link train > or cable plugged in while suspended. This patch fixes these problems. > This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. > > Signed-off-by: Kuogee Hsieh Any

Re: [PATCH net-next 7/8] net: ethernet: ti: am65-cpsw: prepare xmit/rx path for multi-port devices in mac-only mode

2020-10-02 Thread David Miller
From: Grygorii Strashko Date: Thu, 1 Oct 2020 13:52:57 +0300 > This patch adds multi-port support to TI AM65x CPSW driver xmit/rx path in > preparation for adding support for multi-port devices, like Main CPSW0 on > K3 J721E SoC or future CPSW3g on K3 AM64x SoC. > Hence DMA channels are

Re: [PATCH] scsi: qedf: remove redundant assignment to variable 'rc'

2020-10-02 Thread Martin K. Petersen
Jing, > This assignment is meaningless, so remove it. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH v6 1/4] remoteproc: core: Add ops to enable custom coredump functionality

2020-10-02 Thread Siddharth Gupta
Each remoteproc might have different requirements for coredumps and might want to choose the type of dumps it wants to collect. This change allows remoteproc drivers to specify their own custom dump function to be executed in place of rproc_coredump. If the coredump op is not specified by the

[PATCH v6 0/4] Introduce mini-dump support for remoteproc

2020-10-02 Thread Siddharth Gupta
Sometimes firmware sizes can be in tens of MB's and reading all the memory during coredump can consume lot of time and memory. Introducing support for mini-dumps. Mini-dump contains smallest amount of useful information, that could help to debug subsystem crashes. During bootup memory is

Re: [Linux-kernel-mentees][PATCH 0/2] reorder members of structures in virtio_net for optimization

2020-10-02 Thread David Miller
From: Anant Thazhemadam Date: Wed, 30 Sep 2020 10:47:20 +0530 > The structures virtnet_info and receive_queue have byte holes in > middle, and their members could do with some rearranging > (order-of-declaration wise) in order to overcome this. > > Rearranging the members helps in: > *

[PATCH v6 3/4] remoteproc: qcom: Add capability to collect minidumps

2020-10-02 Thread Siddharth Gupta
This patch adds support for collecting minidump in the event of remoteproc crash. Parse the minidump table based on remoteproc's unique minidump-id, read all memory regions from the remoteproc's minidump table entry and expose the memory to userspace. The remoteproc platform driver can choose to

[PATCH v6 4/4] remoteproc: qcom: Add minidump id for sm8150 modem

2020-10-02 Thread Siddharth Gupta
Add minidump id for modem in sm8150 chipset so that the regions to be included in the coredump generated upon a crash is based on the minidump tables in SMEM instead of those in the ELF header. Signed-off-by: Siddharth Gupta --- drivers/remoteproc/qcom_q6v5_pas.c | 1 + 1 file changed, 1

[PATCH v6 2/4] remoteproc: coredump: Add minidump functionality

2020-10-02 Thread Siddharth Gupta
This change adds a new kind of core dump mechanism which instead of dumping entire program segments of the firmware, dumps sections of the remoteproc memory which are sufficient to allow debugging the firmware. This function thus uses section headers instead of program headers during creation of

Re: [PATCH -next] scsi: snic: convert to use DEFINE_SEQ_ATTRIBUTE macro

2020-10-02 Thread Martin K. Petersen
Liu, > Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] vhost-vdpa: fix page pinning leakage in error path

2020-10-02 Thread Jason Wang
On 2020/10/2 上午4:23, Si-Wei Liu wrote: Pinned pages are not properly accounted particularly when mapping error occurs on IOTLB update. Clean up dangling pinned pages for the error path. As the inflight pinned pages, specifically for memory region that strides across multiple chunks, would need

Re: Litmus test for question from Al Viro

2020-10-02 Thread Alan Stern
On Thu, Oct 01, 2020 at 02:30:48PM -0700, Paul E. McKenney wrote: > > Not the way I would have done it, but okay. I would have modeled the > > kfree by setting a and b both to some sentinel value. > > Might be well worth pursuing! But how would you model the address > dependencies in that

Re: [PATCH 3/3] task_work: use TIF_TASKWORK if available

2020-10-02 Thread Thomas Gleixner
On Fri, Oct 02 2020 at 17:38, Oleg Nesterov wrote: > On 10/02, Thomas Gleixner wrote: >> >> I think it's fundamentaly wrong that we have several places and several >> flags which handle task_work_run() instead of having exactly one place >> and one flag. > > Damn yes, agreed. Actually there are

Re: [PATCH] scsi: mvumi: Fix error return in mvumi_io_attach()

2020-10-02 Thread Martin K. Petersen
Jing, > Fix to return error code PTR_ERR() from the error handling case instead > of 0. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V5 3/3] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2020-10-02 Thread Stephen Boyd
Quoting Roja Rani Yarubandi (2020-10-01 01:44:25) > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c > b/drivers/i2c/busses/i2c-qcom-geni.c > index aee2a1dd2c62..56d3fbfe7eb6 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -380,6 +380,36 @@ static

Re: [PATCH 0/3] x86: Add initial support to discover Intel hybrid CPUs

2020-10-02 Thread Thomas Gleixner
On Fri, Oct 02 2020 at 13:19, Ricardo Neri wrote: > Add support to discover and enumerate CPUs in Intel hybrid parts. A hybrid > part has CPUs with more than one type of micro-architecture. Thus, certain > features may only be present in a specific CPU type. > > It is useful to know the type of

Re: [PATCH v6 11/14] misc: bcm-vk: add BCM_VK_QSTATS

2020-10-02 Thread Florian Fainelli
On 10/2/2020 2:23 PM, Scott Branden wrote: Add BCM_VK_QSTATS Kconfig option to allow for enabling debug VK queue statistics. These statistics keep track of max, abs_max, and average for the messages queues. Co-developed-by: Desmond Yan Signed-off-by: Desmond Yan Signed-off-by: Scott

[PATCH V8 5/5] platform/x86: Intel PMT Crashlog capability driver

2020-10-02 Thread David E. Box
From: Alexander Duyck Add support for the Intel Platform Monitoring Technology crashlog interface. This interface provides a few sysfs values to allow for controlling the crashlog telemetry interface as well as a character driver to allow for mapping the crashlog memory region so that it can be

[PATCH V8 4/5] platform/x86: Intel PMT Telemetry capability driver

2020-10-02 Thread David E. Box
From: Alexander Duyck PMT Telemetry is a capability of the Intel Platform Monitoring Technology. The Telemetry capability provides access to device telemetry metrics that provide hardware performance data to users from read-only register spaces. With this driver present the intel_pmt directory

[PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

2020-10-02 Thread David E. Box
Add PCIe Designated Vendor-Specific Extended Capability (DVSEC) and defines for the header offsets. Defined in PCIe r5.0, sec 7.9.6. Signed-off-by: David E. Box Acked-by: Bjorn Helgaas Reviewed-by: Andy Shevchenko --- include/uapi/linux/pci_regs.h | 5 + 1 file changed, 5 insertions(+)

[PATCH V8 3/5] platform/x86: Intel PMT class driver

2020-10-02 Thread David E. Box
From: Alexander Duyck Intel Platform Monitoring Technology is meant to provide a common way to access telemetry and system metrics. Register mappings are not provided by the driver. Instead, a GUID is read from a header for each endpoint. The GUID identifies the device and is to be used with an

[PATCH V8 0/5] Intel Platform Monitoring Technology

2020-10-02 Thread David E. Box
Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring capabilities on a device. With customers increasingly asking for hardware telemetry, engineers not only have to figure out how to measure and collect data, but also how to deliver it and

[PATCH V8 2/5] mfd: Intel Platform Monitoring Technology support

2020-10-02 Thread David E. Box
Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring facilities. PMT supports multiple types of monitoring capabilities. This driver creates platform devices for each type so that they may be managed by capability specific drivers (to be

request!! .

2020-10-02 Thread Angela Campbell
I am sorry for interrupting your day, with due respect trust and humility, I write to you this proposal, which I believe would be of great interest to you. I am looking for a reliable and capable partner that will assist my family and I to transfer funds to his personal or company account for

Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized

2020-10-02 Thread Martin K. Petersen
John, > corrects: drivers/target/target_core_user.c:688:6: warning: 'page' may be used > uninitialized Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

  1   2   3   4   5   6   7   8   9   10   >