[PATCH v2 1/1] scsi: ufs: Fix unexpected values get from ufshcd_read_desc_param()

2020-10-21 Thread Can Guo
Since WB feature has been added, WB related sysfs entries can be accessed even when an UFS device does not support WB feature. In that case, the descriptors which are not supported by the UFS device may be wrongly reported when they are accessed from their corrsponding sysfs entries. Fix it by

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-21 Thread Hannes Reinecke
On 10/21/20 4:10 PM, Sergei Shtepa wrote: The 10/21/2020 16:31, Hannes Reinecke wrote: I do understand where you are coming from, but then we already have a dm-snap which does exactly what you want to achieve. Of course, that would require a reconfiguration of the storage stack on the machine,

[PATCH 3/3] Documentation: introduce a param "irqflood_suppress"

2020-10-21 Thread Pingfan Liu
The param "irqflood_suppress" is helpful for capture kernel to survive irq flood. Signed-off-by: Pingfan Liu Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Jisheng Zhang Cc: Andrew Morton Cc: "Guilherme G. Piccoli" Cc: Petr Mladek Cc: Marc Zyngier Cc: Linus Walleij Cc: afzal mohammed Cc:

[PATCH 1/3] kernel/watchdog: show irq percentage if irq floods

2020-10-21 Thread Pingfan Liu
In kdump case, the capture kernel has no chance to shutdown devices, and leave the devices in unstable state. Irq flood is one of the consequence. When irq floods, the kernel is totally occupies by irq. Currently, there may be nothing or just soft lockup warning showed in console. It is better

[PATCH 2/3] kernel/watchdog: suppress max irq when irq floods

2020-10-21 Thread Pingfan Liu
The capture kernel should try its best to save the crash info. Normally, irq flood is caused by some trivial devices, which has no impact on saving vmcore. Introducing a parameter "irqflood_suppress" to enable suppress irq flood. Signed-off-by: Pingfan Liu Cc: Thomas Gleixner Cc: Peter

[PATCH 0/3] warn and suppress irqflood

2020-10-21 Thread Pingfan Liu
I hit a irqflood bug on powerpc platform, and two years ago, on a x86 platform. When the bug happens, the kernel is totally occupies by irq. Currently, there may be nothing or just soft lockup warning showed in console. It is better to warn users with irq flood info. In the kdump case, the

Re: [PATCH] PM / sysfs: Expose suspend resume driver flags in sysfs

2020-10-21 Thread Chen Yu
Hi Greg, thanks for taking a look at this. On Thu, Oct 22, 2020 at 07:31:43AM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 22, 2020 at 11:23:24AM +0800, Chen Yu wrote: > > Currently there are 4 driver flags to control system suspend/resume > > behavior: DPM_FLAG_NO_DIRECT_COMPLETE,

Re: [PATCH v8 -tip 13/26] kernel/entry: Add support for core-wide protection of kernel-mode

2020-10-21 Thread Li, Aubrey
On 2020/10/20 9:43, Joel Fernandes (Google) wrote: > Core-scheduling prevents hyperthreads in usermode from attacking each > other, but it does not do anything about one of the hyperthreads > entering the kernel for any reason. This leaves the door open for MDS > and L1TF attacks with concurrent

Re: [PATCH 0/4] vDPA: API for reporting IOVA range

2020-10-21 Thread Jason Wang
On 2020/10/21 下午10:45, Michael S. Tsirkin wrote: On Wed, Jun 17, 2020 at 11:29:43AM +0800, Jason Wang wrote: Hi All: This series introduces API for reporing IOVA range. This is a must for userspace to work correclty: - for the process that uses vhost-vDPA directly to properly allocate

[PATCH v2] i2c: designware: call i2c_dw_read_clear_intrbits_slave() once

2020-10-21 Thread Michael Wu
If some bits were cleared by i2c_dw_read_clear_intrbits_slave() in i2c_dw_isr_slave() and not handled immediately, those cleared bits would not be shown again by later i2c_dw_read_clear_intrbits_slave(). They therefore were forgotten to be handled. i2c_dw_read_clear_intrbits_slave() should be

[PATCH] net-veth: Fix memleak in veth_newlink

2020-10-21 Thread Dinghao Liu
When rtnl_configure_link() fails, peer needs to be freed just like when register_netdevice() fails. Signed-off-by: Dinghao Liu --- drivers/net/veth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 8c737668008a..6c68094399cc 100644 ---

Re: [PATCH v4 5/5] riscv: Add numa support for riscv64 platform

2020-10-21 Thread Anup Patel
On Tue, Oct 6, 2020 at 5:48 AM Atish Patra wrote: > > Use the generic numa implementation to add NUMA support for RISC-V. > This is based on Greentime's patch[1] but modified to use generic NUMA > implementation and few more fixes. > > [1] https://lkml.org/lkml/2020/1/10/233 > > Co-developed-by:

Re: [PATCH v4 4/5] riscv: Add support pte_protnone and pmd_protnone if CONFIG_NUMA_BALANCING

2020-10-21 Thread Anup Patel
On Tue, Oct 6, 2020 at 5:48 AM Atish Patra wrote: > > From: Greentime Hu > > These two functions are used to distinguish between PROT_NONENUMA > protections and hinting fault protections. > > Signed-off-by: Greentime Hu > --- > arch/riscv/include/asm/pgtable.h | 20 > 1

Re: [PATCH v4 3/5] riscv: Separate memory init from paging init

2020-10-21 Thread Anup Patel
On Tue, Oct 6, 2020 at 5:48 AM Atish Patra wrote: > > Currently, we perform some memory init functions in paging init. But, > that will be an issue for NUMA support where DT needs to be flattened > before numa initialization and memblock_present can only be called > after numa initialization. > >

Re: [PATCH] usb: typec: Expose Product Type VDOs via sysfs

2020-10-21 Thread Prashant Malani
Hi Greg, Thanks for taking a look. On Wed, Oct 21, 2020 at 10:30 PM Greg KH wrote: > > On Wed, Oct 21, 2020 at 02:18:02PM -0700, Prashant Malani wrote: > > A PD-capable device can return up to 3 Product Type VDOs as part of its > > DiscoverIdentity Response (USB PD Spec, Rev 3.0, Version 2.0,

Re: [PATCH] PM / sysfs: Expose suspend resume driver flags in sysfs

2020-10-21 Thread Greg Kroah-Hartman
On Thu, Oct 22, 2020 at 11:23:24AM +0800, Chen Yu wrote: > Currently there are 4 driver flags to control system suspend/resume > behavior: DPM_FLAG_NO_DIRECT_COMPLETE, DPM_FLAG_SMART_PREPARE, > DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME. Make these flags > visible in sysfs as read-only to

Re: [PATCH] usb: typec: Expose Product Type VDOs via sysfs

2020-10-21 Thread Greg KH
On Wed, Oct 21, 2020 at 02:18:02PM -0700, Prashant Malani wrote: > A PD-capable device can return up to 3 Product Type VDOs as part of its > DiscoverIdentity Response (USB PD Spec, Rev 3.0, Version 2.0, Section > 6.4.4.3.1). Add a sysfs attribute to expose these to userspace. You forgot to add

kvm+nouveau induced lockdep gripe

2020-10-21 Thread Mike Galbraith
I've only as yet seen nouveau lockdep gripage when firing up one of my full distro KVM's. [ 91.655613] == [ 91.655614] WARNING: possible circular locking dependency detected [ 91.655614] 5.9.1-rt18-rt #5 Tainted: G S E [

Re: Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-21 Thread dinghao . liu
> > On 21.10.20 07:21, Dinghao Liu wrote: > > When rtnl_configure_link() fails, peer needs to be > > freed just like when register_netdevice() fails. > > > > Signed-off-by: Dinghao Liu > > Acked-by: Oliver Hartkopp > > Btw. as the vxcan.c driver bases on veth.c the same issue can be found >

ltp or kvm triggerable lockdep alloc_pid() deadlock gripe

2020-10-21 Thread Mike Galbraith
Greetings, The gripe below is repeatable in two ways here, boot with nomodeset so nouveau doesn't steal the lockdep show when I then fire up one of my (oink) full distro VM's, or from an ltp directory ./runltp -f cpuset with the attached subset of controllers file placed in ./runtest dir.

[RFC PATCH v3] tools/x86: add kcpuid tool to show raw CPU features

2020-10-21 Thread Feng Tang
End users frequently want to know what features their processor supports, independent of what the kernel supports. /proc/cpuinfo is great. It is omnipresent and since it is provided by the kernel it is always as up to date as the kernel. But, it could be ambiguous about processor features which

Re: [RESEND PATCH v18 0/4] overlayfs override_creds=off & nested get xattr fix

2020-10-21 Thread Eric Biggers
On Wed, Oct 21, 2020 at 08:18:59AM -0700, Mark Salyzyn wrote: > Mark Salyzyn (3): > Add flags option to get xattr method paired to __vfs_getxattr > overlayfs: handle XATTR_NOSECURITY flag for get xattr method > overlayfs: override_creds=off option bypass creator_cred > > Mark Salyzyn + John

Re: [PATCH V2 2/8] drm/lima: Unconditionally call dev_pm_opp_of_remove_table()

2020-10-21 Thread Viresh Kumar
On 28-08-20, 11:37, Viresh Kumar wrote: > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > find the OPP table with error -ENODEV (i.e. OPP table not present for > the device). And we can call dev_pm_opp_of_remove_table() > unconditionally here. > > Reviewed-by: Qiang Yu

Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()

2020-10-21 Thread Viresh Kumar
On 21-10-20, 09:58, Rob Clark wrote: > On Wed, Oct 21, 2020 at 12:24 AM Viresh Kumar wrote: > > > > On 05-10-20, 11:56, Viresh Kumar wrote: > > > On 28-08-20, 11:37, Viresh Kumar wrote: > > > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > > > > find the OPP table with

Re: [PATCH 4/5] RISC-V: Protect .init.text & .init.data

2020-10-21 Thread Anup Patel
On Thu, Oct 22, 2020 at 7:01 AM Atish Patra wrote: > > On Fri, Oct 16, 2020 at 11:24 AM Atish Patra wrote: > > > > On Tue, Oct 13, 2020 at 10:24 PM Atish Patra wrote: > > > > > > On Tue, Oct 13, 2020 at 6:21 PM Jim Wilson wrote: > > > > > > > > On Tue, Oct 13, 2020 at 3:25 PM Atish Patra > >

[PATCH V3 4/4] misc: vop: mapping kernel memory to user space as noncached

2020-10-21 Thread Sherry Sun
Mapping kernel space memory to user space as noncached, since user space need check the updates of avail_idx and device page flags timely. Signed-off-by: Joakim Zhang Signed-off-by: Sherry Sun --- drivers/misc/mic/vop/vop_vringh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH V3 1/4] misc: vop: change the way of allocating vring and device page

2020-10-21 Thread Sherry Sun
Allocate vrings use dma_alloc_coherent is a common way in kernel. As the memory interacted between two systems should use consistent memory to avoid caching effects, same as device page memory. The orginal way use __get_free_pages and dma_map_single to allocate and map vring, but not use

[PATCH V3 3/4] misc: vop: simply return the saved dma address instead of virt_to_phys

2020-10-21 Thread Sherry Sun
The device page and vring should use consistent memory which are allocated by dma_alloc_coherent api, when user space wants to get its physical address, virt_to_phys cannot be used, should simply return the saved device page dma address by get_dp_dma callback and the vring dma address saved in

[PATCH V3 0/4] Change vring space from nomal memory to dma coherent memory

2020-10-21 Thread Sherry Sun
Changes in V3: 1. Change the device page allocation method of the Intel mic layer in Patch 1 to align with the vring allocation. 2. Move the vring physical address changes in mmap callback from Prach 3 to 1. 3. Use must_be_zero instead of directly deleting used_address_updated in Patch 2 to avoid

[PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

2020-10-21 Thread Sherry Sun
We don't need to allocate and reassign the used ring here and remove the used_address_updated flag.Since RC has allocated the entire vring, including the used ring. Simply add the corresponding offset can get the used ring address. If following the orginal way to reassign the used ring, will

[PATCH v3 1/3] ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels

2020-10-21 Thread Alexandru Stan
The extra 0 only adds one point in the userspace visible range, so this change is almost a noop with the current driver behavior. We don't need the 0% point, userspace seems to handle this just fine because it uses the bl_power property to turn off the display. Furthermore after adding

[PATCH v3 3/3] backlight: pwm_bl: Fix interpolation

2020-10-21 Thread Alexandru Stan
The previous behavior was a little unexpected, its properties/problems: 1. It was designed to generate strictly increasing values (no repeats) 2. It had quantization errors when calculating step size. Resulting in unexpected jumps near the end of some segments. Example settings:

[PATCH v3 2/3] arm64: dts: qcom: trogdor: Add brightness-levels

2020-10-21 Thread Alexandru Stan
We want userspace to represent the human perceived brightness. Since the led drivers and the leds themselves don't have a linear response to the value we give them in terms of perceived brightness, we'll bake the curve into the dts. The panel also doesn't have a good response under 5%, so we'll

[PATCH v3 0/3] PWM backlight interpolation adjustments

2020-10-21 Thread Alexandru Stan
I was trying to adjust the brightness-levels for the trogdor boards: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2291209 Like on a lot of panels, trogdor's low end needs to be cropped, and now that we have the interpolation stuff I wanted to make use of it and bake

Re: [PATCH v2 5/6] crypto: lib/sha256 - Unroll LOAD and BLEND loops

2020-10-21 Thread Eric Biggers
On Tue, Oct 20, 2020 at 04:39:56PM -0400, Arvind Sankar wrote: > Unrolling the LOAD and BLEND loops improves performance by ~8% on x86_64 > (tested on Broadwell Xeon) while not increasing code size too much. > > Signed-off-by: Arvind Sankar > --- Looks good, Reviewed-by: Eric Biggers

Re: [PATCH] drm/amd/display: fix a possible NULL pointer dereference in bios_parser_get_src_obj()

2020-10-21 Thread Alex Deucher
On Mon, Oct 19, 2020 at 8:38 AM estherbdf <603571...@qq.com> wrote: > > [Why] the func bios_parser_get_src_obj () is similar to > bios_parser_get_dst_obj () which is fixed by the > commit("drm/amd/display: Banch of smatch error and warning > fixes in DC"). > the symbol 'id' is uninitialized

Re: [PATCH v2 4/6] crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64

2020-10-21 Thread Eric Biggers
On Tue, Oct 20, 2020 at 04:39:55PM -0400, Arvind Sankar wrote: > This reduces code size substantially (on x86_64 with gcc-10 the size of > sha256_update() goes from 7593 bytes to 1952 bytes including the new > SHA256_K array), and on x86 is slightly faster than the full unroll > (tesed on

Re: [PATCH v2 3/6] crypto: lib/sha256 - Clear W[] in sha256_update() instead of sha256_transform()

2020-10-21 Thread Eric Biggers
On Tue, Oct 20, 2020 at 04:39:54PM -0400, Arvind Sankar wrote: > The temporary W[] array is currently zeroed out once every call to > sha256_transform(), i.e. once every 64 bytes of input data. Moving it to > sha256_update() instead so that it is cleared only once per update can > save about 2-3%

RE: [PATCH] scsi: ufs: make sure scan sequence for multiple hosts

2020-10-21 Thread Chanho Park
> > Did you mean /dev/disk/by-[part]label/ symlink? It's quite reasonable to > > use them by udev in userspace such as initramfs but some cases does not > use > > initramfs or initrd. In that case, we need to load the root > > device(/dev/sda[N]) directly from kernel. > > Please use udev or

Re: [PATCH v2 2/6] crypto: lib/sha256 - Don't clear temporary variables

2020-10-21 Thread Eric Biggers
On Tue, Oct 20, 2020 at 04:39:53PM -0400, Arvind Sankar wrote: > The assignments to clear a through h and t1/t2 are optimized out by the > compiler because they are unused after the assignments. > > These variables shouldn't be very sensitive: t1/t2 can be calculated > from a through h, so they

Re: [PATCH] drm/amdgpu: remove unneeded break

2020-10-21 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 19, 2020 at 11:08 AM Harry Wentland wrote: > > On 2020-10-19 10:55 a.m., Christian König wrote: > > Am 19.10.20 um 16:43 schrieb t...@redhat.com: > >> From: Tom Rix > >> > >> A break is not needed if it is preceded by a return or break > >> > >>

Re: [PATCH] sched/fair: check for idle core

2020-10-21 Thread Viresh Kumar
On 21-10-20, 20:11, Rafael J. Wysocki wrote: > On Wednesday, October 21, 2020 3:10:26 PM CEST Peter Zijlstra wrote: > > On Wed, Oct 21, 2020 at 02:19:50PM +0200, Peter Zijlstra wrote: > > > On Wed, Oct 21, 2020 at 01:56:55PM +0200, Julia Lawall wrote: > > > > Prior to 5.8, my machine was using

RE: [PATCH] scsi: megaraid_sas: use spin_lock() in hard IRQ

2020-10-21 Thread Tianxianting
Thanks, Do you mean Megasas raid can be used in m68k arch? -Original Message- From: Finn Thain [mailto:fth...@telegraphics.com.au] Sent: Thursday, October 22, 2020 10:25 AM To: tianxianting (RD) Cc: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com;

[PATCH v2] firmware: gsmi: Drop the use of dma_pool_* API functions

2020-10-21 Thread Furquan Shaikh
GSMI driver uses dma_pool_* API functions for buffer allocation because it requires that the SMI buffers are allocated within 32-bit physical address space. However, this does not work well with IOMMU since there is no real device and hence no domain associated with the device. Since this is not

Re: [PATCH 2/2] venus: venc: fix handlig of S_SELECTION and G_SELECTION

2020-10-21 Thread vgarodia
Hi Tomasz, On 2020-10-13 19:09, Tomasz Figa wrote: Hi Vikash, On Tue, Oct 13, 2020 at 02:56:21PM +0530, vgaro...@codeaurora.org wrote: On 2020-10-08 19:51, Tomasz Figa wrote: > On Wed, Oct 7, 2020 at 9:33 PM wrote: > > > > Hi Tomasz, > > > > On 2020-10-01 20:47, Tomasz Figa wrote: > > > On

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-10-21 Thread Daeho Jeong
> The use of ?: here is a bit strange. How about: > > return algorithm < COMPRESS_MAX && f2fs_cops[algorithm] != NULL; > Ack > Likewise, EINVAL tends to be over-used, which makes it ambiguous. Maybe use > ENOPKG for the case where algorithm < COMPRESS_MAX but the algorithm wasn't >

Re: [PATCH v2 1/6] crypto: Use memzero_explicit() for clearing state

2020-10-21 Thread Eric Biggers
On Tue, Oct 20, 2020 at 04:39:52PM -0400, Arvind Sankar wrote: > Without the barrier_data() inside memzero_explicit(), the compiler may > optimize away the state-clearing if it can tell that the state is not > used afterwards. At least in lib/crypto/sha256.c:__sha256_final(), the > function can

Re: [PATCH v2 05/15] perf session: introduce decompressor into trace reader object

2020-10-21 Thread Namhyung Kim
On Thu, Oct 22, 2020 at 1:00 AM Alexey Budankov wrote: > > > Introduce decompressor to trace reader object so that decompression > could be executed on per trace file basis separately for every > trace file located in trace directory. I'm slightly uncomfortable with the word 'trace' here as it's

Re: [PATCH v2 6/6] crypto: lib/sha - Combine round constants and message schedule

2020-10-21 Thread Eric Biggers
On Tue, Oct 20, 2020 at 04:39:57PM -0400, Arvind Sankar wrote: > Putting the round constants and the message schedule arrays together in > one structure saves one register, which can be a significant benefit on > register-constrained architectures. On x86-32 (tested on Broadwell > Xeon), this

Re: [PATCH v2 04/15] perf session: move reader object definition to header file

2020-10-21 Thread Namhyung Kim
On Thu, Oct 22, 2020 at 12:59 AM Alexey Budankov wrote: > > > Move definition of reader to session header file to be shared > among different source files. Introduce reference to active > reader object from session object. > > Signed-off-by: Alexey Budankov Acked-by: Namhyung Kim Thanks

Re: [PATCH v2 03/15] perf data: open data directory in read access mode

2020-10-21 Thread Namhyung Kim
On Thu, Oct 22, 2020 at 12:58 AM Alexey Budankov wrote: > > > Open files located at trace data directory in case read access > mode is requested. File are opened and its fds assigned to > perf_data dir files especially for loading data directories > content in perf report mode. > > Signed-off-by:

Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-21 Thread Daeho Jeong
Yep, it sounds more clear~ 2020년 10월 22일 (목) 오후 1:22, Eric Biggers 님이 작성: > > On Thu, Oct 22, 2020 at 12:58:47PM +0900, Daeho Jeong wrote: > > + if (!f2fs_compressed_file(inode)) { > > + inode_unlock(inode); > > + return -EINVAL; > > + } > > How about using ENODATA

[PATCH] thermal: imx: Do NOT return -EPROBE_DEFER when "#cooling-cells" is present

2020-10-21 Thread Anson Huang
The legacy CPU cooling should ONLY be used when "#cooling-cells" is NOT present in cpu node, current implementation for registering legacy cooling always return -EPROBE_DEFER when cpufreq is NOT ready, that will cause thermal driver probe failed when cpufreq failed to probe with a non

Re: [PATCH v2 01/15] perf session: introduce trace file path to be shown in raw trace dump

2020-10-21 Thread Namhyung Kim
Hi, On Thu, Oct 22, 2020 at 12:56 AM Alexey Budankov wrote: > > > Extend reader, ordered_event and decomp objects to contain path > of a trace file being displayed. > > Signed-off-by: Alexey Budankov Acked-by: Namhyung Kim Thanks Namhyung > --- > tools/perf/util/ordered-events.h | 1 + >

Re: [PATCH v2 02/15] perf report: output trace file name in raw trace dump

2020-10-21 Thread Namhyung Kim
On Thu, Oct 22, 2020 at 12:57 AM Alexey Budankov wrote: > > > Print path and name of a trace file into raw dump (-D) > @. Print offset of PERF_RECORD_COMPRESSED > record instead of zero for decompressed records: > 0x22...@perf.data [0x30]: event: 9 > or > 0x15c...@perf.data/data.7 [0x30]:

Re: [PATCH] kbuild: Use uname for LINUX_COMPILE_HOST detection

2020-10-21 Thread Masahiro Yamada
On Tue, Oct 20, 2020 at 6:35 PM Chris Down wrote: > > `hostname` may not be present on some systems as it's not mandated by > POSIX/SUSv4. This isn't just a theoretical problem: on Arch Linux, > `hostname` is provided by `inetutils`, which isn't part of the base > distribution. > >

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-10-21 Thread Eric Biggers
On Thu, Oct 22, 2020 at 12:58:48PM +0900, Daeho Jeong wrote: > diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c > index 7895186cc765..3b58a41223f8 100644 > --- a/fs/f2fs/compress.c > +++ b/fs/f2fs/compress.c > @@ -514,6 +514,11 @@ bool f2fs_is_compress_backend_ready(struct inode *inode) >

Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-21 Thread Eric Biggers
On Thu, Oct 22, 2020 at 12:58:47PM +0900, Daeho Jeong wrote: > + if (!f2fs_compressed_file(inode)) { > + inode_unlock(inode); > + return -EINVAL; > + } How about using ENODATA here? EINVAL tends to be used for lots of different reasons, and it's not always clear

Re: [PATCH] kunit: Fix kunit.py --raw_output option

2020-10-21 Thread Brendan Higgins
On Wed, Oct 21, 2020 at 8:05 PM David Gow wrote: > > Due to the raw_output() function on kunit_parser.py actually being a > generator, it only runs if something reads the lines it returns. Since > we no-longer do that (parsing doesn't actually happen if raw_output is > enabled), it was not

Re: Performance regressions in "boot_time" tests in Linux 5.8 Kernel

2020-10-21 Thread b...@redhat.com
Hi Rahul, On 10/20/20 at 03:26pm, Rahul Gopakumar wrote: > >> Here, do you mean it even cost more time with the patch applied? > > Yes, we ran it multiple times and it looks like there is a > very minor increase with the patch. > ..  > On 10/20/20 at 01:45pm, Rahul Gopakumar wrote: > > Hi

[PATCH v2 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-21 Thread Daeho Jeong
From: Daeho Jeong Added a new F2FS_IOC_GET_COMPRESS_OPTION ioctl to get file compression option of a file. struct f2fs_comp_option { u8 algorithm; => compression algorithm => 0:lzo, 1:lz4, 2:zstd, 3:lzorle u8 log_cluster_size; => log scale cluster size

[PATCH v2 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-10-21 Thread Daeho Jeong
From: Daeho Jeong Added a new F2FS_IOC_SET_COMPRESS_OPTION ioctl to change file compression option of a file. struct f2fs_comp_option { u8 algorithm; => compression algorithm => 0:lzo, 1:lz4, 2:zstd, 3:lzorle u8 log_cluster_size; => log scale cluster

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread Randy Dunlap
On 10/21/20 8:43 PM, Theodore Y. Ts'o wrote: > On Wed, Oct 21, 2020 at 04:07:15PM -0700, Randy Dunlap wrote: >>> I'm don't particularly care how this gets achieved, but please think >>> about how to make it easy for a kernel developer to run a specific set >>> of subsystem unit tests. (In fact,

Re: [PATCH v2 1/3] backlight: pwm_bl: Fix interpolation

2020-10-21 Thread Alexandru Stan
On Wed, 14 Oct 2020 at 23:55, Geert Uytterhoeven wrote: > > Hi Alexandru, > > On Tue, Oct 13, 2020 at 1:57 PM Alexandru Stan wrote: > > Whenever num-interpolated-steps was larger than the distance > > between 2 consecutive brightness levels the table would get really > > discontinuous. The slope

[PATCH] mm,thp,shmem: limit shmem THP alloc gfp_mask

2020-10-21 Thread Rik van Riel
The allocation flags of anonymous transparent huge pages can be controlled through the files in /sys/kernel/mm/transparent_hugepage/defrag, which can help the system from getting bogged down in the page reclaim and compaction code when many THPs are getting allocated simultaneously. However, the

Re: [PATCH rfc 0/2] mm: cma: make cma_release() non-blocking

2020-10-21 Thread Xiaqing (A)
On 2020/10/22 10:45, Roman Gushchin wrote: On Thu, Oct 22, 2020 at 09:54:53AM +0800, Xiaqing (A) wrote: On 2020/10/17 6:52, Roman Gushchin wrote: This small patchset makes cma_release() non-blocking and simplifies the code in hugetlbfs, where previously we had to temporarily drop

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread Theodore Y. Ts'o
On Wed, Oct 21, 2020 at 04:07:15PM -0700, Randy Dunlap wrote: > > I'm don't particularly care how this gets achieved, but please think > > about how to make it easy for a kernel developer to run a specific set > > of subsystem unit tests. (In fact, being able to do something like > > "kunit.py

Re: [PATCH net] selftests: mptcp: depends on built-in IPv6

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 17:35:32 -0700 (PDT) Mat Martineau wrote: > > Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a > > consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no > > longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6 > > will stay

linux-next: Tree for Oct 22

2020-10-21 Thread Stephen Rothwell
Hi all, Since the merge window is open, please do not add any v5.11 material to your linux-next included branches until after v5.10-rc1 has been released. Changes since 20201021: The pci tree gained a conflict against Linus' tree. Non-merge commits (relative to Linus' tree): 2341 2721 files

[PATCH] Docs/bpf: Improve bpf_design_QA.rst

2020-10-21 Thread Rhys Rustad-Elliott
- Rephrase wording such that the file flows better - Improve consistency with respect to word use, grammar and style - Remove point on loops not being supported as BPF now has support for bounded loops Signed-off-by: Rhys Rustad-Elliott --- Documentation/bpf/bpf_design_QA.rst | 382

Re: [PATCH v4] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 10:30:43 -0400 Michael S. Tsirkin wrote: > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > When control vq is not negotiated, that commit causes a crash: > > [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! Applied, thank you!

Re: [RFCv2 05/16] x86/kvm: Make VirtIO use DMA API in KVM guest

2020-10-21 Thread Halil Pasic
On Tue, 20 Oct 2020 09:18:48 +0300 "Kirill A. Shutemov" wrote: > VirtIO for KVM is a primary way to provide IO. All memory that used for > communication with the host has to be marked as shared. > > The easiest way to archive that is to use DMA API that already knows how > to deal with shared

[PATCH v2] KVM: arm64: ARM_SMCCC_ARCH_WORKAROUND_1 doesn't return SMCCC_RET_NOT_REQUIRED

2020-10-21 Thread Stephen Boyd
According to the SMCCC spec[1](7.5.2 Discovery) the ARM_SMCCC_ARCH_WORKAROUND_1 function id only returns 0, 1, and SMCCC_RET_NOT_SUPPORTED. 0 is "workaround required and safe to call this function" 1 is "workaround not required but safe to call this function" SMCCC_RET_NOT_SUPPORTED is "might

RE: [PATCH] scsi: megaraid_sas: use spin_lock() in hard IRQ

2020-10-21 Thread Finn Thain
On Thu, 22 Oct 2020, Tianxianting wrote: > Do you mean Megasas raid can be used in m68k arch? m68k is one example of an architecture on which the unstated assumptions in your patch would be invalid. Does this help to clarify what I wrote? If Megasas raid did work on m68k, I'm sure it could

Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-10-21 Thread Tzung-Bi Shih
Hi, sorry for jumping into your discussion but I am trying to summarize them to make sure we are on the same page. Pardon me to manually copy-and-paste partial sentences to quote. ACK: - Don't expose DAI connections in compatible strings. - Use "model" DT property to make the card more

Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error

2020-10-21 Thread Kees Cook
On Thu, Oct 22, 2020 at 03:00:06AM +0300, Dmitry Osipenko wrote: > 22.10.2020 02:40, Kees Cook пишет: > > On Thu, Oct 22, 2020 at 01:57:37AM +0300, Dmitry Osipenko wrote: > >> The vfp_kmode_exception() function now is unreachable using relative > >> branching in THUMB2 kernel configuration,

Re: [RFCv2 14/16] KVM: Handle protected memory in __kvm_map_gfn()/__kvm_unmap_gfn()

2020-10-21 Thread Halil Pasic
On Tue, 20 Oct 2020 09:18:57 +0300 "Kirill A. Shutemov" wrote: > We cannot access protected pages directly. Use ioremap() to > create a temporary mapping of the page. The mapping is destroyed > on __kvm_unmap_gfn(). > > The new interface gfn_to_pfn_memslot_protected() is used to detect if > the

[PATCH v3 1/2] usb: dwc3: Trigger a GCTL soft reset when switching modes in DRD

2020-10-21 Thread John Stultz
From: Yu Chen With the current dwc3 code on the HiKey960 we often see the COREIDLE flag get stuck off in __dwc3_gadget_start(), which seems to prevent the reset irq and causes the USB gadget to fail to initialize. We had seen occasional initialization failures with older kernels but with recent

[PATCH v3 2/2] usb: dwc3: Fix DRD mode change sequence following programming guide

2020-10-21 Thread John Stultz
In reviewing the previous patch, Thinh Nguyen pointed out that the DRD mode change sequence should be like the following when switching from host -> device according to the programming guide (for all DRD IPs): 1. Reset controller with GCTL.CoreSoftReset 2. Set GCTL.PrtCapDir(device) 3. Soft reset

Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

2020-10-21 Thread Finn Thain
On Wed, 21 Oct 2020, Laurent Vivier wrote: > Le 21/10/2020 à 01:43, Finn Thain a écrit : > > > Laurent, can we avoid the irq == 0 warning splat like this? > > > > diff --git a/drivers/tty/serial/pmac_zilog.c > > b/drivers/tty/serial/pmac_zilog.c > > index 96e7aa479961..7db600cd8cc7 100644 > >

Re: [PATCH v4] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Jason Wang
On 2020/10/21 下午10:30, Michael S. Tsirkin wrote: This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. When control vq is not negotiated, that commit causes a crash: [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! [ 72.230266] invalid opcode: [#1] PREEMPT SMP [

[PATCH] PM / sysfs: Expose suspend resume driver flags in sysfs

2020-10-21 Thread Chen Yu
Currently there are 4 driver flags to control system suspend/resume behavior: DPM_FLAG_NO_DIRECT_COMPLETE, DPM_FLAG_SMART_PREPARE, DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME. Make these flags visible in sysfs as read-only to get a brief understanding of the expected behavior of each

Re: [PATCH] usb: typec: Expose Product Type VDOs via sysfs

2020-10-21 Thread Benson Leung
Hi Prashant, On Wed, Oct 21, 2020 at 02:18:02PM -0700, Prashant Malani wrote: > A PD-capable device can return up to 3 Product Type VDOs as part of its > DiscoverIdentity Response (USB PD Spec, Rev 3.0, Version 2.0, Section > 6.4.4.3.1). Add a sysfs attribute to expose these to userspace. > >

drm_modes: signed integer overflow

2020-10-21 Thread Randy Dunlap
Hi, With linux-next 20201021, when booting up, I am seeing this: [0.560896] UBSAN: signed-integer-overflow in ../drivers/gpu/drm/drm_modes.c:765:20 [0.560903] 2376000 * 1000 cannot be represented in type 'int' [0.560909] CPU: 3 PID: 7 Comm: kworker/u16:0 Not tainted 5.9.0-next

[PATCH] kunit: Fix kunit.py --raw_output option

2020-10-21 Thread David Gow
Due to the raw_output() function on kunit_parser.py actually being a generator, it only runs if something reads the lines it returns. Since we no-longer do that (parsing doesn't actually happen if raw_output is enabled), it was not printing anything. Fixes:

Re: [PATCH v7 3/4] docs: Add documentation for userspace client interface

2020-10-21 Thread Jeffrey Hugo
On 10/21/2020 11:46 AM, Hemant Kumar wrote: Hi Jeff, On 10/21/20 8:28 AM, Jeffrey Hugo wrote: On 10/16/2020 10:04 PM, Hemant Kumar wrote: +release Should this be "close" since close() is the actual function userspace would call? I was keeping kernel driver in mind while writing this, i can

Re: [RFC PATCH net-next 7/9] net: dsa: microchip: ksz9477: add hardware time stamping support

2020-10-21 Thread Richard Cochran
On Thu, Oct 22, 2020 at 02:39:35AM +0300, Vladimir Oltean wrote: > So how _does_ that work for TI PHYTER? > > As far as we understand, the PHYTER appears to autonomously mangle PTP packets > in the following way: > - subtracting t2 on RX from the correctionField of the Pdelay_Req > - adding t3 on

Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

2020-10-21 Thread Michael Ellerman
Laurent Vivier writes: > Le 20/10/2020 à 20:32, Greg KH a écrit : >> On Tue, Oct 20, 2020 at 08:19:26PM +0200, Laurent Vivier wrote: >>> Le 20/10/2020 à 19:37, Greg KH a écrit : On Tue, Oct 20, 2020 at 06:37:41PM +0200, Laurent Vivier wrote: > Le 20/10/2020 à 18:28, Greg KH a écrit :

Re: [f2fs-dev] [PATCH] f2fs: add compr_inode and compr_blocks sysfs nodes

2020-10-21 Thread Daeho Jeong
Yep, It sounds good to me. 2020년 10월 21일 (수) 오후 3:08, Chao Yu 님이 작성: > > On 2020/10/16 13:14, Daeho Jeong wrote: > > From: Daeho Jeong > > > > Added compr_inode to show compressed inode count and compr_blocks to > > show compressed block count in sysfs. > > As there are so many entries in

Re: [PATCH rfc 0/2] mm: cma: make cma_release() non-blocking

2020-10-21 Thread Roman Gushchin
On Thu, Oct 22, 2020 at 09:54:53AM +0800, Xiaqing (A) wrote: > > > On 2020/10/17 6:52, Roman Gushchin wrote: > > > This small patchset makes cma_release() non-blocking and simplifies > > the code in hugetlbfs, where previously we had to temporarily drop > > hugetlb_lock around the cma_release()

PING: [PATCH] block: add io_error stat for block device

2020-10-21 Thread zhenwei pi
Hi, Jens What do you think about this, adding io error stat for block devices is reasonable? On 9/10/20 10:20 AM, zhenwei pi wrote: Currently if hitting block req error, block layer only prints error log with a rate limitation. Then agent has to parse kernel log to record what happens. In

Re: [RFC PATCH net-next 7/9] net: dsa: microchip: ksz9477: add hardware time stamping support

2020-10-21 Thread Richard Cochran
I'm just catching up with this. Really. Truly. Please -- Include the maintainer on CC for such patches! In case you don't know who that is, you can always consult the MAINTAINERS file. There you will find the following entry. PTP HARDWARE CLOCK SUPPORT M: Richard Cochran L:

[PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-21 Thread Joe Perches
Use a more generic form for __section that requires quotes to avoid complications with clang and gcc differences. Remove the quote operator # from compiler_attributes.h __section macro. Convert all unquoted __section(foo) uses to quoted __section("foo"). Also convert

Re: [PATCH v2 02/20] kvm: x86/mmu: Introduce tdp_iter

2020-10-21 Thread Yu Zhang
On Wed, Oct 21, 2020 at 11:08:52AM -0700, Ben Gardon wrote: > On Wed, Oct 21, 2020 at 7:59 AM Yu Zhang wrote: > > > > On Wed, Oct 14, 2020 at 11:26:42AM -0700, Ben Gardon wrote: > > > The TDP iterator implements a pre-order traversal of a TDP paging > > > structure. This iterator will be used in

Re: [PATCH rfc 0/2] mm: cma: make cma_release() non-blocking

2020-10-21 Thread Roman Gushchin
On Wed, Oct 21, 2020 at 05:15:53PM -0700, Mike Kravetz wrote: > On 10/16/20 3:52 PM, Roman Gushchin wrote: > > This small patchset makes cma_release() non-blocking and simplifies > > the code in hugetlbfs, where previously we had to temporarily drop > > hugetlb_lock around the cma_release() call.

Re: [PATCH v4 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

2020-10-21 Thread Chanwoo Choi
On 10/22/20 11:30 AM, Dmitry Osipenko wrote: > Hello Chanwoo, > > 20.10.2020 06:04, Chanwoo Choi пишет: >> @@ -1354,55 +1365,71 @@ static ssize_t governor_store(struct device *dev, >> struct device_attribute *attr, >> struct devfreq *df = to_devfreq(dev); >> int ret; >> char

Re: [PATCH v4 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

2020-10-21 Thread Chanwoo Choi
On 10/22/20 11:30 AM, Dmitry Osipenko wrote: > 20.10.2020 06:04, Chanwoo Choi пишет: >> /** >> * struct devfreq_governor - Devfreq policy governor >> * @node: list node - contains registered devfreq governors >> * @name: Governor's name >> + * @attr: Governor's

Re: [PATCH v4 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

2020-10-21 Thread Dmitry Osipenko
Hello Chanwoo, 20.10.2020 06:04, Chanwoo Choi пишет: > @@ -1354,55 +1365,71 @@ static ssize_t governor_store(struct device *dev, > struct device_attribute *attr, > struct devfreq *df = to_devfreq(dev); > int ret; > char str_governor[DEVFREQ_NAME_LEN + 1]; > - const struct

Re: [PATCH v4 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

2020-10-21 Thread Dmitry Osipenko
20.10.2020 06:04, Chanwoo Choi пишет: > /** > * struct devfreq_governor - Devfreq policy governor > * @node:list node - contains registered devfreq governors > * @name:Governor's name > + * @attr:Governor's sysfs attribute flag > * @flags:

Re: [PATCH] scsi: megaraid_sas: use spin_lock() in hard IRQ

2020-10-21 Thread Finn Thain
On Wed, 21 Oct 2020, Xianting Tian wrote: > Since we already in hard IRQ context when running megasas_isr(), On m68k, hard irq context does not mean interrupts are disabled. Are there no other architectures in that category? > so use spin_lock() is enough, which is faster than

  1   2   3   4   5   6   7   8   9   >