Re: [PATCH] PM / Domains: Fix integer overflows on u32 bit multiplies

2021-02-07 Thread Pavel Machek
On Sun 2021-02-07 22:46:48, Colin King wrote: > From: Colin Ian King > > There are three occurrances of u32 variables being multiplied by > 1000 using 32 bit multiplies and the result being assigned to a > 64 bit signed integer. These can potentially lead to a 32 bit > overflows, so fix this by

[PATCH v2] mtd: spi-nor: winbond: Add support for w25q512jvq

2021-02-07 Thread Shuhao Mai
Add support for w25q512jvq. This is of the same series chip with w25q256jv, which is already supported, but with size doubled and different JEDEC ID. Tested on Intel whitley platform with dd from/to the flash for read/write respectly, and flash_erase for erasing the flash. Signed-off-by: Shuhao

RE: [PATCH v2 6/9] scsi: ufshpb: Add hpb dev reset response

2021-02-07 Thread Avri Altman
> > + if (hpb->is_hcm) { > > + struct ufshpb_lu *h; > > + struct scsi_device *sdev; > > + > > + shost_for_each_device(sdev, hba->host) { > > I haven't test it yet, but this line shall cause recursive spin lock - > in current

Re: [PATCH v13 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2021-02-07 Thread Steen Hegelund
Hi Vinod, On Thu, 2021-02-04 at 13:31 +0530, Vinod Koul wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On 29-01-21, 14:07, Steen Hegelund wrote: > > Add the Microchip Sparx5 ethernet serdes PHY driver for the 6G, 10G > > and 25G > >

Re: [PATCH] optee: simplify i2c access

2021-02-07 Thread Jorge Ramirez-Ortiz, Foundries
On 08/02/21, Jens Wiklander wrote: > Hi Jorge, > > On Wed, Jan 27, 2021 at 11:41 AM Jens Wiklander > wrote: > > > > Hi Arnd, > > > > On Mon, Jan 25, 2021 at 12:38 PM Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > Storing a bogus i2c_client structure on the stack adds overhead

[PATCH V2 4/4] Squashfs: add more sanity checks in xattr id lookup

2021-02-07 Thread Phillip Lougher
Sysbot has reported a warning where a kmalloc() attempt exceeds the maximum limit. This has been identified as corruption of the xattr_ids count when reading the xattr id lookup table. This patch adds a number of additional sanity checks to detect this corruption and others. 1. It checks for a

Re: [PATCH] fcntl: make F_GETOWN(EX) return 0 on dead owner task

2021-02-07 Thread Cyrill Gorcunov
On Wed, Feb 03, 2021 at 03:41:56PM +0300, Pavel Tikhomirov wrote: > Currently there is no way to differentiate the file with alive owner > from the file with dead owner but pid of the owner reused. That's why > CRIU can't actually know if it needs to restore file owner or not, > because if it

Re: [PATCH] kbuild: simplify access to the kernel's version

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote: > Instead of storing the version in a single integer and having various > kernel (and userspace) code how it's constructed, export individual > (major, patchlevel, sublevel) components and simplify kernel code that > uses it. > > This

[PATCH V2 3/4] Squashfs: add more sanity checks in inode lookup

2021-02-07 Thread Phillip Lougher
Sysbot has reported an "slab-out-of-bounds read" error which has been identified as being caused by a corrupted "ino_num" value read from the inode. This could be because the metadata block is uncompressed, or because the "compression" bit has been corrupted (turning a compressed block into an

[PATCH v2 1/2] mei: bus: simplify mei_cl_device_remove()

2021-02-07 Thread Uwe Kleine-König
The driver core only calls a bus' remove function when there is actually a driver and a device. So drop the needless check and assign cldrv earlier. (Side note: The check for cldev being non-NULL is broken anyhow, because to_mei_cl_device() is a wrapper around container_of() for a member that is

[PATCH v2 2/2] mei: bus: change remove callback to return void

2021-02-07 Thread Uwe Kleine-König
The driver core ignores the return value of mei_cl_device_remove() so passing an error value doesn't solve any problem. As most mei drivers' remove callbacks return 0 unconditionally and returning a different value doesn't have any effect, change this prototype to return void and return 0

[PATCH 1/2] sched/features: Fix hrtick reprogramming

2021-02-07 Thread Juri Lelli
Hung tasks and RCU stall cases were reported on systems which were not 100% busy. Investigation of such unexpected cases (no sign of potential starvation caused by tasks hogging the system) pointed out that the periodic sched tick timer wasn't serviced anymore after a certain point and that caused

[PATCH v2 0/2] mei: bus: Some cleanups

2021-02-07 Thread Uwe Kleine-König
Hello, changes since v1: - Added a missing ; found by kernel test robot, thanks - Added an Ack for Guenter rangediff can be found below. Uwe Kleine-König (2): mei: bus: simplify mei_cl_device_remove() mei: bus: change remove callback to return void drivers/misc/mei/bus.c | 11

[PATCH 2/2] sched/features: Distinguish between NORMAL and DEADLINE hrtick

2021-02-07 Thread Juri Lelli
The HRTICK feature has traditionally been servicing configurations that need precise preemptions point for NORMAL tasks. More recently, the feature has been extended to also service DEADLINE tasks with stringent runtime enforcement needs (e.g., runtime < 1ms with HZ=1000). Enabling HRTICK sched

[PATCH 0/2] HRTICK reprogramming and optimization

2021-02-07 Thread Juri Lelli
Hi All, Hung tasks and RCU stall cases were reported on systems which were not 100% busy. Investigation of such unexpected cases (no sign of potential starvation caused by tasks hogging the system) pointed out that the periodic sched tick timer wasn't serviced anymore after a certain point and

Re: [RESEND PATCH v3 3/5] misc: Add Synopsys DesignWare xData IP driver to Kconfig

2021-02-07 Thread Leon Romanovsky
On Tue, Feb 02, 2021 at 05:56:36PM +0100, Gustavo Pimentel wrote: > Add Synopsys DesignWare xData IP driver to Kconfig. > > This driver enables/disables the PCIe traffic generator module > pertain to the Synopsys DesignWare prototype. > > Signed-off-by: Gustavo Pimentel > --- >

Re: [PATCH v2] memory: tegra186-emc: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-07 Thread Krzysztof Kozlowski
On Sun, 7 Feb 2021 at 09:03, Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > drivers/memory/tegra/tegra186-emc.c:158:0-23: WARNING: > tegra186_emc_debug_max_rate_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE. > > drivers/memory/tegra/tegra186-emc.c:128:0-23: WARNING: >

[PATCH v1] kvm: x86: Revise guest_fpu xcomp_bv field

2021-02-07 Thread Jing Liu
Bit 63 of the XCOMP_BV field indicates that the save area is in the compacted format and the remaining bits indicate the states that have space allocated in the save area, not only user states. Since fpstate_init() has initialized xcomp_bv, let's just use that. Signed-off-by: Jing Liu ---

Re: [PATCH v19 2/3] scsi: ufs: L2P map management for HPB read

2021-02-07 Thread Can Guo
On 2021-01-29 13:30, Daejun Park wrote: This is a patch for managing L2P map in HPB module. The HPB divides logical addresses into several regions. A region consists of several sub-regions. The sub-region is a basic unit where L2P mapping is managed. The driver loads L2P mapping data of each

[PATCH] powerpc/32: Preserve cr1 in exception prolog stack check to fix build error

2021-02-07 Thread Christophe Leroy
THREAD_ALIGN_SHIFT = THREAD_SHIFT + 1 = PAGE_SHIFT + 1 Maximum PAGE_SHIFT is 18 for 256k pages so THREAD_ALIGN_SHIFT is 19 at the maximum. No need to clobber cr1, it can be preserved when moving r1 into CR when we check stack overflow. This reduces the number of instructions in Machine Check

[PATCH] MAINTAINERS: rectify BROADCOM PMB (POWER MANAGEMENT BUS) DRIVER

2021-02-07 Thread Lukas Bulwahn
Commit 8bcac4011ebe ("soc: bcm: add PM driver for Broadcom's PMB") includes a new MAINTAINERS section BROADCOM PMB (POWER MANAGEMENT BUS) DRIVER with 'drivers/soc/bcm/bcm-pmb.c', but the file was actually added at 'drivers/soc/bcm/bcm63xx/bcm-pmb.c'. Hence, ./scripts/get_maintainer.pl

TLS for 5.10

2021-02-07 Thread Wadepohl, Wolfram
smime.p7m Description: S/MIME encrypted message

Re: [PATCH] staging: octeon: remove braces from single-line block

2021-02-07 Thread Alexander Sverdlin
Hi! On 06/02/2021 21:17, Phillip Potter wrote: > This removes the braces from the if statement that checks the > physical node return value in cvm_oct_phy_setup_device, as this > block contains only one statement. Fixes a style warning. > > Signed-off-by: Phillip Potter Reviewed-by: Alexander

RE: [PATCH] seccomp: Improve performance by optimizing memory barrier

2021-02-07 Thread Wanghongzhe (Hongzhe, EulerOS)
> From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Monday, February 8, 2021 2:44 PM > To: Wanghongzhe (Hongzhe, EulerOS) > Cc: keesc...@chromium.org; l...@amacapital.net; w...@chromium.org; > a...@kernel.org; dan...@iogearbox.net; and...@kernel.org; ka...@fb.com; > songliubrav...@fb.com;

Re: [PATCH] optee: simplify i2c access

2021-02-07 Thread Jens Wiklander
Hi Jorge, On Wed, Jan 27, 2021 at 11:41 AM Jens Wiklander wrote: > > Hi Arnd, > > On Mon, Jan 25, 2021 at 12:38 PM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > Storing a bogus i2c_client structure on the stack adds overhead and > > causes a compile-time warning: > > > >

[RFC PATCH v3] MIPS: tlbex: Avoid access invalid address when pmd is modifying

2021-02-07 Thread hev
From: wangrui When modifying pmd through THP, invalid address access may occurs in the tlb handler. Because the tlb handler loads value of pmd twice, one is used for huge page testing and the other is used to load pte. So these two values may be different: CPU 0: (app)

Re: [96e8740] [PATCH 2/2] Staging: wimax: i2400m: some readability improvements.

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 10:11:24PM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Hello, developers! > Sorry for the late answer. As you know - i am a newbie and it is my first > kernel patch. > After reading kernelnewbies.or, ./Documentation/process/ files and viewing > FOSDEM's

Re: [PATCH v7 4/7] crypto: add ecc curve and expose them

2021-02-07 Thread Ard Biesheuvel
On Mon, 8 Feb 2021 at 07:37, Vitaly Chikunov wrote: > > Herbert, > > On Fri, Jan 29, 2021 at 02:00:04PM +1100, Herbert Xu wrote: > > On Thu, Jan 28, 2021 at 09:49:41PM -0500, Stefan Berger wrote: > > > > > > In my patch series I initially had registered the akciphers under the > > > names > > >

Re: [PATCH v14 00/11] support reserving crashkernel above 4G on arm64 kdump

2021-02-07 Thread chenzhou
Hi all, Friendly ping... On 2021/1/30 15:10, Chen Zhou wrote: > There are following issues in arm64 kdump: > 1. We use crashkernel=X to reserve crashkernel below 4G, which > will fail when there is no enough low memory. > 2. If reserving crashkernel above 4G, in this case, crash dump > kernel

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-07 Thread Tero Kristo
On 26/01/2021 14:45, Lee Jones wrote: This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is the last set. Clock is clean after this. Lee Jones (21): clk: zynq: pll: Fix kernel-doc

Re: [PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-07 Thread Sergey Senozhatsky
On (21/02/05 15:23), John Ogness wrote: > If message sizes average larger than expected (more than 32 > characters), the data_ring will wrap before the desc_ring. Once the > data_ring wraps, it will start invalidating descriptors. These > invalid descriptors hang around until they are eventually

Re: [PATCH] seccomp: Improve performance by optimizing memory barrier

2021-02-07 Thread Leon Romanovsky
On Mon, Feb 01, 2021 at 08:49:41PM +0800, wanghongzhe wrote: > If a thread(A)'s TSYNC flag is set from seccomp(), then it will > synchronize its seccomp filter to other threads(B) in same thread > group. To avoid race condition, seccomp puts rmb() between > reading the mode and filter in seccomp

Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-07 Thread Sergey Senozhatsky
On (21/02/06 13:41), Muchun Song wrote: > We found a deadlock bug on our server when the kernel panic. It can be > described in the following diagram. > > CPU0: CPU1: > panic rcu_dump_cpu_stacks >

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-07 Thread Eli Cohen
On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote: > > On 2021/2/6 上午7:07, Si-Wei Liu wrote: > > > > > > On 2/3/2021 11:36 PM, Eli Cohen wrote: > > > When a change of memory map occurs, the hardware resources are destroyed > > > and then re-created again with the new memory map. In

Re: [PATCH] MAINTAINERS: repair file pattern in MEDIATEK IOMMU DRIVER

2021-02-07 Thread Yong Wu
On Mon, 2021-02-08 at 07:10 +0100, Lukas Bulwahn wrote: > Commit 6af4873852c4 ("MAINTAINERS: Add entry for MediaTek IOMMU") mentions > the pattern 'drivers/iommu/mtk-iommu*', but the files are actually named > with an underscore, not with a hyphen. > > Hence, ./scripts/get_maintainer.pl

Re: [PATCH v7 4/7] crypto: add ecc curve and expose them

2021-02-07 Thread Vitaly Chikunov
Herbert, On Fri, Jan 29, 2021 at 02:00:04PM +1100, Herbert Xu wrote: > On Thu, Jan 28, 2021 at 09:49:41PM -0500, Stefan Berger wrote: > > > > In my patch series I initially had registered the akciphers under the names > > ecc-nist-p192 and ecc-nist-p256 but now, in V4, joined them together as > >

Re: [PATCH v2 6/9] scsi: ufshpb: Add hpb dev reset response

2021-02-07 Thread Can Guo
On 2021-02-02 16:30, Avri Altman wrote: The spec does not define what is the host's recommended response when the device send hpb dev reset response (oper 0x2). We will update all active hpb regions: mark them and do that on the next read. Signed-off-by: Avri Altman ---

Re: [RFC PATCH v4 00/17] virtio/vsock: introduce SOCK_SEQPACKET support

2021-02-07 Thread Arseny Krasnov
On 07.02.2021 19:20, Michael S. Tsirkin wrote: > On Sun, Feb 07, 2021 at 06:12:56PM +0300, Arseny Krasnov wrote: >> This patchset impelements support of SOCK_SEQPACKET for virtio >> transport. >> As SOCK_SEQPACKET guarantees to save record boundaries, so to >> do it, two new packet

Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-07 Thread Samuel Holland
On 2/8/21 12:28 AM, Samuel Holland wrote: > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error > pointers to optional clocks were replaced by NULL to simplify the resume > callback implementation. However, that commit missed that the IS_ERR > check in mv64xxx_of_config should

Re: linux-next: build warning after merge of the v4l-dvb tree

2021-02-07 Thread Mauro Carvalho Chehab
Em Mon, 8 Feb 2021 11:32:08 +1100 Stephen Rothwell escreveu: > Hi all, > > After merging the v4l-dvb tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > WARNING: modpost: drivers/media/i2c/rdacm21-camera_module: > 'max9271_set_serial_link' exported twice.

[PATCH] drivers: firmware: xilinx: Fix dereferencing freed memory

2021-02-07 Thread Rajan Vaja
From: Tejas Patel Fix smatch warning: drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data' Use hash_for_each_safe for safe removal of hash entry. Fixes: acfdd18591ea ("firmware: xilinx: Use hash-table for api feature check")

[PATCH net-next RESEND 5/5] net: stmmac: dwmac-sun8i: Add a shutdown callback

2021-02-07 Thread Samuel Holland
The Ethernet MAC and PHY are usually major consumers of power on boards which may not be able to fully power off (those with no PMIC). Powering down the MAC and internal PHY saves power while these boards are "off". Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland ---

[PATCH net-next RESEND 4/5] net: stmmac: dwmac-sun8i: Minor probe function cleanup

2021-02-07 Thread Samuel Holland
Adjust the spacing and use an explicit "return 0" in the success path to make the function easier to parse. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH net-next RESEND 0/5] dwmac-sun8i cleanup and shutdown hook

2021-02-07 Thread Samuel Holland
These patches clean up some things I noticed while fixing suspend/resume behavior. The first four are minor code improvements. The last one adds a shutdown hook to minimize power consumption on boards without a PMIC. Now that the fixes series is merged, I'm resending this series rebased on top of

[PATCH net-next RESEND 2/5] net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check

2021-02-07 Thread Samuel Holland
sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered, so there is no need to do it again here. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH net-next RESEND 1/5] net: stmmac: dwmac-sun8i: Return void from PHY unpower

2021-02-07 Thread Samuel Holland
This is a deinitialization function that always returned zero, and that return value was always ignored. Have it return void instead. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH net-next RESEND 3/5] net: stmmac: dwmac-sun8i: Use reset_control_reset

2021-02-07 Thread Samuel Holland
Use the appropriate function instead of reimplementing it, and update the error message to match the code. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v2 1/1] riscv/kasan: add KASAN_VMALLOC support

2021-02-07 Thread Alex Ghiti
Hi Nylon, Le 1/22/21 à 10:56 PM, Palmer Dabbelt a écrit : On Fri, 15 Jan 2021 21:58:35 PST (-0800), nyl...@andestech.com wrote: It references to x86/s390 architecture. >> So, it doesn't map the early shadow page to cover VMALLOC space. Prepopulate top level page table for the range that would

[PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-07 Thread Samuel Holland
In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error pointers to optional clocks were replaced by NULL to simplify the resume callback implementation. However, that commit missed that the IS_ERR check in mv64xxx_of_config should be replaced with a NULL check. As a result, the

[PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-07 Thread Samuel Holland
In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error pointers to optional clocks were replaced by NULL to simplify the resume callback implementation. However, that commit missed that the IS_ERR check in mv64xxx_of_config should be replaced with a NULL check. As a result, the

Incorrect RSS page accounting of processes with multiple mapping pages

2021-02-07 Thread Shu Ming
Hi, I believe there is an unexpected RES page accounting when doing multiple page mapping. The sample code was pasted below. In the sample code, The same 1g pages are mapped for three times. And it is expected that the process gets 1g RES instead of 3g RES pages(top command showed result).

Re: [PATCH] fs/buffer.c: Add checking buffer head stat before clear

2021-02-07 Thread Shaokun Zhang
Hi Andrew, 在 2021/2/6 7:45, Andrew Morton 写道: > On Wed, 3 Feb 2021 14:14:50 +0800 Shaokun Zhang > wrote: > >> From: Yang Guo >> >> clear_buffer_new() is used to clear buffer new stat. When PAGE_SIZE >> is 64K, most buffer heads in the list are not needed to clear. >> clear_buffer_new() has an

[PATCH] MAINTAINERS: repair file pattern in MEDIATEK IOMMU DRIVER

2021-02-07 Thread Lukas Bulwahn
Commit 6af4873852c4 ("MAINTAINERS: Add entry for MediaTek IOMMU") mentions the pattern 'drivers/iommu/mtk-iommu*', but the files are actually named with an underscore, not with a hyphen. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains: warning: no file matches F:

[PATCH] nfc: st-nci: Remove unnecessary variable

2021-02-07 Thread samirweng1979
From: wengjianfeng The variable r is defined at the beginning and initialized to 0 until the function returns r, and the variable r is not reassigned.Therefore, we do not need to define the variable r, just return 0 directly at the end of the function. Signed-off-by: wengjianfeng ---

[RFC PATCH v2] MIPS: tlbex: Avoid access invalid address when pmd is modifying

2021-02-07 Thread hev
From: wangrui When modifying pmd through THP, invalid address access may occurs in the tlb handler. Because the tlb handler loads value of pmd twice, one is used for huge page testing and the other is used to load pte. So these two values may be different: CPU 0: (app)

Please I Need Your Help

2021-02-07 Thread Salma Malek
How are you today, Please accept my sincere apologies if my email does not meet your business or personal ethics, I really like to have a good relationship with you, and I have a special reason why I decided to contact you because of the urgency of my situation here. I came across your e-mail

[PATCH] kernel: exit.c: fix a spacing coding style

2021-02-07 Thread jiahao
Add some spaces before and after the operator. Signed-off-by: jiahao --- kernel/exit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/exit.c b/kernel/exit.c index 04029e3..ffc507e 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -888,7 +888,7 @@

Re: [PATCH] gpiolib: cdev: convert stream-like files from

2021-02-07 Thread Bartosz Golaszewski
On Sun, Feb 7, 2021 at 10:00 AM Yang Li wrote: > > Eliminate the following coccicheck warning: > ./drivers/gpio/gpiolib-cdev.c:2307:7-23: WARNING: gpio_fileops: .read() > has stream semantic; safe to change nonseekable_open -> stream_open. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li >

Re: [RFC PATCH v2] taskstats: add /proc/taskstats to fetch pid/tgid status

2021-02-07 Thread Balbir Singh
On Fri, Feb 05, 2021 at 10:43:02AM +0800, Weiping Zhang wrote: > On Fri, Feb 5, 2021 at 8:08 AM Balbir Singh wrote: > > > > On Thu, Feb 04, 2021 at 10:37:20PM +0800, Weiping Zhang wrote: > > > On Thu, Feb 4, 2021 at 6:20 PM Balbir Singh wrote: > > > > > > > > On Sun, Jan 31, 2021 at 05:16:47PM

Re: [PATCH] dax: fix default return code of range_parse()

2021-02-07 Thread Ruan Shiyang
ping On 2021/1/26 上午10:13, Shiyang Ruan wrote: The return value of range_parse() indicates the size when it is positive. The error code should be negative. Signed-off-by: Shiyang Ruan --- drivers/dax/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-07 Thread Eli Cohen
On Sat, Feb 06, 2021 at 04:29:24AM -0800, Si-Wei Liu wrote: > While virtq is stopped, get_vq_state() is supposed to > be called to get sync'ed with the latest internal > avail_index from device. The saved avail_index is used > to restate the virtq once device is started. Commit >

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-07 Thread Jason Wang
On 2021/2/5 下午11:34, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang I don't exactly get why we need to split the modern driver out, and it can confuse people who are used to be seeing virtio-pci. The virtio-pci module still

Re: [PATCH 1/3] mlx5_vdpa: should exclude header length and fcs from mtu

2021-02-07 Thread Eli Cohen
On Sat, Feb 06, 2021 at 04:29:22AM -0800, Si-Wei Liu wrote: > When feature VIRTIO_NET_F_MTU is negotiated on mlx5_vdpa, > 22 extra bytes worth of MTU length is shown in guest. > This is because the mlx5_query_port_max_mtu API returns > the "hardware" MTU value, which does not just contain the >

Re: [PATCH 2/3] mlx5_vdpa: fix feature negotiation across device reset

2021-02-07 Thread Eli Cohen
On Sat, Feb 06, 2021 at 04:29:23AM -0800, Si-Wei Liu wrote: > The mlx_features denotes the capability for which > set of virtio features is supported by device. In > principle, this field needs not be cleared during > virtio device reset, as this capability is static > and does not change across

RE: [RFC PATCH v3 1/2] mempinfd: Add new syscall to provide memory pin

2021-02-07 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: David Rientjes [mailto:rient...@google.com] > Sent: Monday, February 8, 2021 3:18 PM > To: Song Bao Hua (Barry Song) > Cc: Matthew Wilcox ; Wangzhou (B) > ; linux-kernel@vger.kernel.org; > io...@lists.linux-foundation.org; linux...@kvack.org; >

linux-next: build failure after merge of the kvm tree

2021-02-07 Thread Stephen Rothwell
Hi all, After merging the kvm tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/gvt/kvmgt.c: In function 'kvmgt_page_track_add': drivers/gpu/drm/i915/gvt/kvmgt.c:1706:12: error: passing argument 1 of 'spin_lock' from incompatible pointer type

[PATCHv2 2/3] media: uvcvideo: add ROI auto controls

2021-02-07 Thread Sergey Senozhatsky
From: Sergey Senozhatsky This patch adds support for Region of Interest bmAutoControls. ROI control is a compound data type: Control Selector CT_REGION_OF_INTEREST_CONTROL Mandatory Requests SET_CUR, GET_CUR, GET_MIN, GET_MAX, GET_DEF wLength 10 Offset FieldSize 0

[PATCHv2 1/3] media: v4l UAPI docs: document ROI selection targets

2021-02-07 Thread Sergey Senozhatsky
From: Sergey Senozhatsky Document new v4l2-selection target which will be used for the Region of Interest v4l2 control. Signed-off-by: Sergey Senozhatsky --- .../media/v4l/selection-api-configuration.rst | 23 +++ .../media/v4l/v4l2-selection-targets.rst | 21

[PATCHv2 0/3] Add UVC 1.5 Region Of Interest control to uvcvideo

2021-02-07 Thread Sergey Senozhatsky
Hello, RFC This patch set adds UVC 1.5 Region of Interest support. v1->v2: - Address Laurent's comments Sergey Senozhatsky (3): media: v4l UAPI docs: document ROI selection targets media: uvcvideo: add ROI auto controls media: uvcvideo: add UVC 1.5 ROI control

[PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-02-07 Thread Sergey Senozhatsky
From: Sergey Senozhatsky This patch implements parts of UVC 1.5 Region of Interest (ROI) control, using the uvcvideo selection API. There are several things to mention here. First, UVC 1.5 defines CT_DIGITAL_WINDOW_CONTROL; and ROI rectangle coordinates "must be within the current Digital

Re: drivers/opp/of.c:842:12: warning: stack frame size of 2064 bytes in function '_of_add_opp_table_v2'

2021-02-07 Thread Viresh Kumar
On 07-02-21, 04:09, kernel test robot wrote: > f47b72a15a9679 drivers/base/power/opp/of.c Viresh Kumar 2016-05-05 841 /* > Initializes OPP tables based on new bindings */ > 5ed4cecd75e902 drivers/opp/of.cViresh Kumar 2018-09-12 @842 > static int _of_add_opp_table_v2(struct

Re: [RFC 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE

2021-02-07 Thread Anshuman Khandual
On 2/4/21 12:31 PM, Anshuman Khandual wrote: > The following warning gets triggered while trying to boot a 64K page size > without THP config kernel on arm64 platform. > > WARNING: CPU: 5 PID: 124 at mm/vmstat.c:1080 __fragmentation_index+0xa4/0xc0 > Modules linked in: > CPU: 5 PID: 124 Comm:

Re: [PATCH 1/3] mlx5_vdpa: should exclude header length and fcs from mtu

2021-02-07 Thread Jason Wang
On 2021/2/6 下午8:29, Si-Wei Liu wrote: When feature VIRTIO_NET_F_MTU is negotiated on mlx5_vdpa, 22 extra bytes worth of MTU length is shown in guest. This is because the mlx5_query_port_max_mtu API returns the "hardware" MTU value, which does not just contain the Ethernet payload, but includes

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-07 Thread Jason Wang
On 2021/2/6 下午8:29, Si-Wei Liu wrote: While virtq is stopped, get_vq_state() is supposed to be called to get sync'ed with the latest internal avail_index from device. The saved avail_index is used to restate the virtq once device is started. Commit b35ccebe3ef7 introduced the

Re: [PATCH 2/3] mlx5_vdpa: fix feature negotiation across device reset

2021-02-07 Thread Jason Wang
On 2021/2/6 下午8:29, Si-Wei Liu wrote: The mlx_features denotes the capability for which set of virtio features is supported by device. In principle, this field needs not be cleared during virtio device reset, as this capability is static and does not change across reset. In fact, the current

Re: [PATCH 1/4] mm/highmem: Lift memcpy_[to|from]_page to core

2021-02-07 Thread Chaitanya Kulkarni
On 2/7/21 19:13, Ira Weiny wrote: >>> +static inline void memcpy_from_page(char *to, struct page *page, size_t >>> offset, size_t len) >> How about following ? >> static inline void memcpy_from_page(char *to, struct page *page, size_t >> offset, >> size_t len)

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-07 Thread Jason Wang
On 2021/2/6 上午7:07, Si-Wei Liu wrote: On 2/3/2021 11:36 PM, Eli Cohen wrote: When a change of memory map occurs, the hardware resources are destroyed and then re-created again with the new memory map. In such case, we need to restore the hardware available and used indices. The driver

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-07 Thread Anshuman Khandual
On 2/5/21 11:23 PM, Mathieu Poirier wrote: > On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: >> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is >> accessible via the system registers. The TRBE supports different addressing >> modes including CPU

Re: [PATCH V3 17/19] vdpa: set the virtqueue num during register

2021-02-07 Thread Jason Wang
On 2021/2/5 下午11:27, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:01PM +0800, Jason Wang wrote: This patch delay the queue number setting to vDPA device registering. This allows us to probe the virtqueue numbers between device allocation and registering. Reviewed-by: Stefano

Re: [PATCH V3 18/19] virtio_vdpa: don't warn when fail to disable vq

2021-02-07 Thread Jason Wang
On 2021/2/5 下午11:24, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:02PM +0800, Jason Wang wrote: There's no guarantee that the device can disable a specific virtqueue through set_vq_ready(). One example is the modern virtio-pci device. So this patch removes the warning.

[PATCH RESEND] rsi: remove redundant assignment

2021-02-07 Thread samirweng1979
From: wengjianfeng INVALID_QUEUE has been used as a return value,it is not necessary to assign it to q_num,so just return INVALID_QUEUE. Signed-off-by: wengjianfeng --- drivers/net/wireless/rsi/rsi_91x_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH v3 09/13] vhost/vdpa: remove vhost_vdpa_config_validate()

2021-02-07 Thread Jason Wang
On 2021/2/5 下午10:17, Stefano Garzarella wrote: On Fri, Feb 05, 2021 at 08:32:37AM -0500, Michael S. Tsirkin wrote: On Fri, Feb 05, 2021 at 10:16:51AM +0100, Stefano Garzarella wrote: On Fri, Feb 05, 2021 at 11:27:32AM +0800, Jason Wang wrote: > > On 2021/2/5 上午1:22, Stefano Garzarella wrote:

Re: [PATCH v16 11/12] powerpc: Use OF alloc and free for FDT

2021-02-07 Thread Michael Ellerman
Rob Herring writes: > On Thu, Feb 4, 2021 at 10:42 AM Lakshmi Ramasubramanian > wrote: ... >> diff --git a/arch/powerpc/kexec/elf_64.c b/arch/powerpc/kexec/elf_64.c >> index d0e459bb2f05..51d2d8eb6c1b 100644 >> --- a/arch/powerpc/kexec/elf_64.c >> +++ b/arch/powerpc/kexec/elf_64.c >> @@ -19,6

Re: [PATCH v3 1/7] seqnum_ops: Introduce Sequence Number Ops

2021-02-07 Thread Randy Dunlap
Hi-- Comments are inline. On 2/3/21 10:11 AM, Shuah Khan wrote: > Sequence Number api provides interfaces for unsigned atomic up counters. > > There are a number of atomic_t usages in the kernel where atomic_t api > is used for counting sequence numbers and other statistical counters. > Several

[RFC PATCH v1] MIPS: tlbex: Avoid access invalid address when pmd is modifying

2021-02-07 Thread hev
From: wangrui When modifying pmd through THP, invalid address access may occurs in the tlb handler. Because the tlb handler loads value of pmd twice, one is used for huge page testing and the other is used to load pte. So these two values may be different: CPU 0: (app)

Re: [PATCH RFC 3/7] kvm: x86: XSAVE state and XFD MSRs context switch

2021-02-07 Thread Liu, Jing2
On 2/7/2021 7:49 PM, Borislav Petkov wrote: On Sun, Feb 07, 2021 at 10:42:52AM -0500, Jing Liu wrote: diff --git a/arch/x86/kernel/fpu/init.c b/arch/x86/kernel/fpu/init.c index 7e0c68043ce3..fbb761fc13ec 100644 --- a/arch/x86/kernel/fpu/init.c +++ b/arch/x86/kernel/fpu/init.c @@ -145,6

[RFC v4 PATCH] usb: xhci-mtk: improve bandwidth scheduling with TT

2021-02-07 Thread Chunfeng Yun
When the USB headset is plug into an external hub, sometimes can't set config due to not enough bandwidth, so need improve LS/FS INT/ISOC bandwidth scheduling with TT. Fixes: 08e469de87a2 ("usb: xhci-mtk: supports bandwidth scheduling with multi-TT") Signed-off-by: Yaqii Wu Signed-off-by:

Re: [PATCH] mm/memtest: Add ARCH_USE_MEMTEST

2021-02-07 Thread Anshuman Khandual
On 2/5/21 2:50 PM, Vladimir Murzin wrote: > Hi Anshuman, > > On 2/5/21 4:10 AM, Anshuman Khandual wrote: >> early_memtest() does not get called from all architectures. Hence enabling >> CONFIG_MEMTEST and providing a valid memtest=[1..N] kernel command line >> option might not trigger the

Re: [PATCH 1/4] mm/highmem: Lift memcpy_[to|from]_page to core

2021-02-07 Thread Ira Weiny
On Sun, Feb 07, 2021 at 01:46:47AM +, Chaitanya Kulkarni wrote: > On 2/5/21 18:35, ira.we...@intel.com wrote: > > +static inline void memmove_page(struct page *dst_page, size_t dst_off, > > + struct page *src_page, size_t src_off, > > + size_t

[PATCH] cpufreq: schedutil: Don't use the limits_changed flag any more

2021-02-07 Thread Yue Hu
From: Yue Hu The limits_changed flag was introduced by commit 600f5badb78c ("cpufreq: schedutil: Don't skip freq update when limits change") due to race condition where need_freq_update is cleared in get_next_freq() which causes reducing the CPU frequency is ineffective while busy. But now, the

Re: [PATCH] mm/memtest: Add ARCH_USE_MEMTEST

2021-02-07 Thread Anshuman Khandual
On 2/5/21 1:05 PM, Max Filippov wrote: > On Thu, Feb 4, 2021 at 8:10 PM Anshuman Khandual > wrote: >> >> early_memtest() does not get called from all architectures. Hence enabling >> CONFIG_MEMTEST and providing a valid memtest=[1..N] kernel command line >> option might not trigger the memory

Re: Linux 5.11-rc7

2021-02-07 Thread Randy Dunlap
On 2/7/21 2:32 PM, Linus Torvalds wrote: > So it's the biggest sporting day of the year here in the US, when > everybody is getting ready to watch the yearly top TV commercials, > occasionally interrupted by some odd handegg carrying competition that > I still haven't figured out the rules for

[PATCH v2] staging: gasket: fix indentation and lines ending with open parenthesis

2021-02-07 Thread Mahak Gupta
This patch fixes warnings of 'checkpatch.pl'. According to Linux coding guidelines, code should be aligned properly to match with open parenthesis and lines should not end with open parenthesis. Signed-off-by: Mahak Gupta --- Changes since v1: - Use temporary variables to shorten long lines.

[PATCH] staging: gasket: fix indentation and lines ending with open parenthesis

2021-02-07 Thread Mahak Gupta
This patch fixes warnings of 'checkpatch.pl'. According to Linux coding guidelines, code should be aligned properly to match with open parenthesis and lines should not end with open parenthesis. Signed-off-by: Mahak Gupta --- Changes since v1: - Use temporary variables to shorten long lines.

Re: ANNOUNCE: pahole v1.20 (gcc11 DWARF5's default, lots of ELF sections, BTF)

2021-02-07 Thread Sedat Dilek
On Thu, Feb 4, 2021 at 11:07 PM Arnaldo Carvalho de Melo wrote: > > Hi, > > The v1.20 release of pahole and its friends is out, mostly > addressing problems related to gcc 11 defaulting to DWARF5 for -g, > available at the usual places: > > Main git repo: > >

[PATCH RESEND] mwl8k: assign value when defining variables

2021-02-07 Thread samirweng1979
From: wengjianfeng define refilled and then assign value to it, which should do that at the same time. Signed-off-by: wengjianfeng --- drivers/net/wireless/marvell/mwl8k.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/mwl8k.c

Re: [PATCH 7/8] mm: memcontrol: consolidate lruvec stat flushing

2021-02-07 Thread Shakeel Butt
On Fri, Feb 5, 2021 at 10:28 AM Johannes Weiner wrote: > > There are two functions to flush the per-cpu data of an lruvec into > the rest of the cgroup tree: when the cgroup is being freed, and when > a CPU disappears during hotplug. The difference is whether all CPUs or > just one is being

RE: [RFC PATCH v3 1/2] mempinfd: Add new syscall to provide memory pin

2021-02-07 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: owner-linux...@kvack.org [mailto:owner-linux...@kvack.org] On Behalf Of > Matthew Wilcox > Sent: Monday, February 8, 2021 2:31 PM > To: Song Bao Hua (Barry Song) > Cc: Wangzhou (B) ; linux-kernel@vger.kernel.org; > io...@lists.linux-foundation.org;

[PATCH RESEND] wl1251: cmd: remove redundant assignment

2021-02-07 Thread samirweng1979
From: wengjianfeng -ENOMEM has been used as a return value,it is not necessary to assign it, and if kzalloc fail,not need free it,so just return -ENOMEM when kzalloc fail. Signed-off-by: wengjianfeng --- drivers/net/wireless/ti/wl1251/cmd.c | 36 1 file

drivers/soundwire/stream.c:260:12: warning: stack frame size of 2832 bytes in function 'sdw_program_port_params'

2021-02-07 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 61556703b610a104de324e4f061dc6cf7b218b46 commit: 41ff91741c25d4987bf0405fa219b9eb339f24ee soundwire: stream: use FIELD_{GET|PREP} date: 5 months ago config: powerpc64-randconfig-r014-20210207 (attached

  1   2   3   4   5   6   >