Re: [PATCH] mtd: spi-nor: sfdp: Fix out of bound array access

2021-02-18 Thread Mathieu Dubois-Briand
Hi, I just came across this commit (9166f4af32db) in spi-nor/for-5.12: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=spi-nor/for-5.12=9166f4af32db74e1544a2149aef231ff24515ea3. So I believe this patch isn't needed anymore. Thanks, Mathieu

Re: [PATCH v12 13/14] mm/vmalloc: Hugepage vmalloc mappings

2021-02-18 Thread Nicholas Piggin
Excerpts from Ding Tianhong's message of February 19, 2021 1:45 pm: > Hi Nicholas: > > I met some problem for this patch, like this: > > kva = vmalloc(3*1024k); > > remap_vmalloc_range(xxx, kva, xxx) > > It failed because that the check for page_count(page) is null so return, it > break the

[PATCH] Revert "driver core: Set fw_devlink=on by default"

2021-02-18 Thread Greg Kroah-Hartman
This reverts commit e590474768f1cc04852190b61dec692411b22e2a. While things are _almost_ there and working for almost all systems, there are still reported regressions happening, so let's revert this default for 5.12. We can bring it back in linux-next after 5.12-rc1 is out to get more testing

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Viresh Kumar
On 19-02-21, 14:41, Yue Hu wrote: > On Fri, 19 Feb 2021 09:39:33 +0530 > Viresh Kumar wrote: > > > On 19-02-21, 11:38, Yue Hu wrote: > > > There's a possibility: we will use the previous freq to update if > > > next_f is reduced for busy CPU if need_freq_update is set in > > >

Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type

2021-02-18 Thread Atul Gopinathan
On Fri, Feb 19, 2021 at 09:55:14AM +0300, Dan Carpenter wrote: > No problem. These days I have fibre to my house, but I still remember > trying to clone the kernel when I could only buy 20MB of data at a > time. :P Whoaa, that's tough! Respect to you for still trying to contribute to the

Re: [PATCH] staging: wlan-ng: Fixed incorrect type warning in p80211netdev.c

2021-02-18 Thread Ivan Safonov
On 2/17/21 6:42 PM, pritthijit.nath at icloud.com (Pritthijit Nath) wrote: This change fixes a sparse warning "incorrect type in argument 1 (different address spaces)". Signed-off-by: Pritthijit Nath --- drivers/staging/wlan-ng/p80211netdev.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] drm/radeon/dpm: fix non-restricted types with le16_to_cpu()

2021-02-18 Thread Yang Li
Fix the following sparse warnings: drivers/gpu/drm/radeon/rv6xx_dpm.c:1798:21: warning: cast to restricted __le32 drivers/gpu/drm/radeon/rv6xx_dpm.c:1799:22: warning: cast to restricted __le16 drivers/gpu/drm/radeon/rv6xx_dpm.c:1800:23: warning: cast to restricted __le16 Reported-by: Abaci Robot

Re: [PATCH] RISC-V: Enable CPU Hotplug in defconfigs

2021-02-18 Thread Palmer Dabbelt
On Mon, 08 Feb 2021 21:46:20 PST (-0800), Anup Patel wrote: The CPU hotplug support has been tested on QEMU, Spike, and SiFive Unleashed so let's enable it by default in RV32 and RV64 defconfigs. Signed-off-by: Anup Patel --- arch/riscv/configs/defconfig | 1 +

Re: [RFC][PATCH 2/2] x86/retpoline: Compress retpolines

2021-02-18 Thread Borislav Petkov
On Thu, Feb 18, 2021 at 05:59:40PM +0100, Peter Zijlstra wrote: > By using int3 as a speculation fence instead of lfence, we can shrink > the longest alternative to just 15 bytes: > > 0: e8 05 00 00 00 callq a <.altinstr_replacement+0xa> > 5: f3 90 pause >

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Jari Ruusu
On Thursday, February 18, 2021 7:44 PM, Greg Kroah-Hartman wrote: > > It was the other way around. Fine working in-tree driver got > > broken by backported "fixes". I did mention bit-rot. > > It did? Please let us stable maintainers know about, we will always > gladly revert problems patches.

Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip

2021-02-18 Thread Jarkko Sakkinen
On Wed, Feb 17, 2021 at 09:27:02PM -0400, Jason Gunthorpe wrote: > On Thu, Feb 18, 2021 at 12:14:11AM +0200, Jarkko Sakkinen wrote: > > On Tue, Feb 16, 2021 at 04:31:26PM +, David Laight wrote: > > > ... > > > > > > + get_device(>dev); > > > > > > + chip->devs.release = tpm_devs_release; >

Re: [PATCH RESEND V12 3/8] fuse: Definitions and ioctl for passthrough

2021-02-18 Thread Peng Tao
On Wed, Feb 17, 2021 at 9:41 PM Miklos Szeredi wrote: > > On Mon, Jan 25, 2021 at 4:31 PM Alessio Balsini wrote: > > > > Expose the FUSE_PASSTHROUGH interface to user space and declare all the > > basic data structures and functions as the skeleton on top of which the > > FUSE passthrough

Re: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform

2021-02-18 Thread Dan Carpenter
On Thu, Feb 18, 2021 at 07:50:27PM +, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > The preferred coding style is: > if (!StaAddr) > return; Above the Signed-off-by line. Also indenting is wrong. And it's hard to understand what you're saying. > > thank you

[PATCH] perf report: Create option to disable raw event ordering

2021-02-18 Thread Jin Yao
Warning "dso not found" is reported when using "perf report -D". 66702781413407 0x32c0 [0x30]: PERF_RECORD_SAMPLE(IP, 0x2): 28177/28177: 0x55e493e00563 period: 106578 addr: 0 ... thread: perf:28177 .. dso: 66702727832429 0x9dd8 [0x38]: PERF_RECORD_COMM exec: triad_loop:28177/28177

Re: [PATCH] Staging: rtl8723bs: code-style fix

2021-02-18 Thread Dan Carpenter
The subject is too vague. On Thu, Feb 18, 2021 at 04:33:10PM +, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > Checkpatch complains the constant needs to be on the right side of the > comparison. The preferred way is: > The commit message isn't complete and it has to go

Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type

2021-02-18 Thread Dan Carpenter
No problem. These days I have fibre to my house, but I still remember trying to clone the kernel when I could only buy 20MB of data at a time. :P regards, dan carpenter

[PATCH] btrfs: ref-verify: use 'inline void' keyword ordering

2021-02-18 Thread Randy Dunlap
Fix build warnings of function signature when CONFIG_STACKTRACE is not enabled by reordering the 'inline' and 'void' keywords. ../fs/btrfs/ref-verify.c:221:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] static void inline __save_stack_trace(struct ref_action

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Yue Hu
On Fri, 19 Feb 2021 09:39:33 +0530 Viresh Kumar wrote: > On 19-02-21, 11:38, Yue Hu wrote: > > There's a possibility: we will use the previous freq to update if > > next_f is reduced for busy CPU if need_freq_update is set in > > sugov_update_next_freq(). > > Right. > > > This possibility

Re: [PATCH] kthread: add kthread_mod_pending_delayed_work api

2021-02-18 Thread Yiwei Zhang‎
> 2. User triggered clean up races with the clean up triggered by > timeout. You try to handle this scenario by this patch. Yes, exactly. > 3. User does clean up after the clean up has already been done > by the timeout. This case is well handled. So only (2) has a potential race. Let me

Re: [PATCH ghak124 v3] audit: log nftables configuration change events

2021-02-18 Thread Richard Guy Briggs
On 2021-02-18 23:42, Florian Westphal wrote: > Richard Guy Briggs wrote: > > > If they appear in a batch tehy will be ignored, if the batch consists of > > > such non-modifying ops only then nf_tables_commit() returns early > > > because the transaction list is empty (nothing to do/change). > >

Re: [PATCH] staging: i2400m: use explicit host byte-order types in comparison

2021-02-18 Thread Greg Kroah-Hartman
On Fri, Feb 19, 2021 at 06:00:47AM +0530, karthik alapati wrote: > convert le32 types to host byte-order types before > comparison That says what you did, but not _why_ you did it. Please fix up and resend. thanks, greg k-h

[PATCH] btrfs: Remove unused variable ret

2021-02-18 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./fs/btrfs/disk-io.c:4403:5-8: Unneeded variable: "ret". Return "0" on line 4411. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- fs/btrfs/disk-io.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/disk-io.c

RE: [PATCH 2/4] iommu/vt-d: Enable write protect propagation from guest

2021-02-18 Thread Tian, Kevin
> From: Jacob Pan > Sent: Friday, February 19, 2021 5:31 AM > > Write protect bit, when set, inhibits supervisor writes to the read-only > pages. In guest supervisor shared virtual addressing (SVA), write-protect > should be honored upon guest bind supervisor PASID request. > > This patch

Re: [PATCH] perf machine: Use true and false for bool variable

2021-02-18 Thread kajoljain
On 2/18/21 2:54 PM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./tools/perf/util/machine.c:2000:9-10: WARNING: return of 0/1 in > function 'symbol__match_regex' with return type bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- >

Re: [PATCH v2 1/2] mm: Make alloc_contig_range handle free hugetlb pages

2021-02-18 Thread Oscar Salvador
On 2021-02-19 03:10, Mike Kravetz wrote: Those counts will be wrong as there are no huge pages on the node. I'll think about this more tomorrow. Pretty sure this is an issue, but I could be wrong. Just wanted to give a heads up. Yes, this is a problem, although the fixup would be to check

[PATCH 4/4] iommu/vt-d: Calculate and set flags for handle_mm_fault

2021-02-18 Thread Jacob Pan
Page requests are originated from the user page fault. Therefore, we shall set FAULT_FLAG_USER.  FAULT_FLAG_REMOTE indicates that we are walking an mm which is not guaranteed to be the same as the current->mm and should not be subject to protection key enforcement. Therefore, we should set 

[PATCH 3/4] iommu/vt-d: Reject unsupported page request modes

2021-02-18 Thread Jacob Pan
When supervisor/privilige mode SVM is used, we bind init_mm.pgd with a supervisor PASID. There should not be any page fault for init_mm. Execution request with DMA read is also not supported. This patch checks PRQ descriptor for both unsupported configurations, reject them both with invalid

[PATCH 1/4] iommu/vt-d: Enable write protect for supervisor SVM

2021-02-18 Thread Jacob Pan
Write protect bit, when set, inhibits supervisor writes to the read-only pages. In supervisor shared virtual addressing (SVA), where page tables are shared between CPU and DMA, IOMMU PASID entry WPE bit should match CR0.WP bit in the CPU. This patch sets WPE bit for supervisor PASIDs if CR0.WP is

[PATCH 0/4] Misc vSVA fixes for VT-d

2021-02-18 Thread Jacob Pan
Hi Baolu et al, This is a collection of SVA-related fixes. Thanks, Jacob Jacob Pan (4): iommu/vt-d: Enable write protect for supervisor SVM iommu/vt-d: Enable write protect propagation from guest iommu/vt-d: Reject unsupported page request modes iommu/vt-d: Calculate and set flags for

Re: [PATCH] staging: emxx_udc: remove unused variable driver_desc

2021-02-18 Thread Greg Kroah-Hartman
On Thu, Feb 18, 2021 at 10:41:07PM -0500, Sean Behan wrote: > Signed-off-by: Sean Behan > --- > drivers/staging/emxx_udc/emxx_udc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > b/drivers/staging/emxx_udc/emxx_udc.c > index

[PATCH 2/4] iommu/vt-d: Enable write protect propagation from guest

2021-02-18 Thread Jacob Pan
Write protect bit, when set, inhibits supervisor writes to the read-only pages. In guest supervisor shared virtual addressing (SVA), write-protect should be honored upon guest bind supervisor PASID request. This patch extends the VT-d portion of the IOMMU UAPI to include WP bit. WPE bit of the

Re: [PATCH V7 5/6] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi

2021-02-18 Thread Viresh Kumar
On 18-02-21, 23:20, Frank Rowand wrote: > Hi Viresh, > > I am in the wrong version with the comments below. You are at version 8 now. Yeah, it is fine. I have updated the patches already based on your comments. -- viresh

Re: [PATCH V7 5/6] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi

2021-02-18 Thread Frank Rowand
Hi Viresh, I am in the wrong version with the comments below. You are at version 8 now. -Frank On 2/18/21 3:02 PM, Frank Rowand wrote: > On 1/29/21 1:24 AM, Viresh Kumar wrote: >> In order to build-test the same unit-test files using fdtoverlay tool, >> move the device nodes from the existing

Re: Re: [PATCH] ASoC: Intel: Skylake: Fix missing check in skl_pcm_trigger

2021-02-18 Thread dinghao . liu
> > On 2/15/21 7:13 AM, Dinghao Liu wrote: > > When cmd == SNDRV_PCM_TRIGGER_STOP, we should also check > > the return value of skl_decoupled_trigger() just like what > > we have done in case SNDRV_PCM_TRIGGER_PAUSE_RELEASE. > > > > Signed-off-by: Dinghao Liu > > --- > >

Re: [PATCH V3 XRT Alveo 00/18] XRT Alveo driver overview

2021-02-18 Thread Lizhi Hou
On 02/18/2021 05:52 AM, Tom Rix wrote: On 2/17/21 10:40 PM, Lizhi Hou wrote: Hello, This is V3 of patch series which adds management physical function driver for Xilinx Alveo PCIe accelerator cards, https://www.xilinx.com/products/boards-and-kits/alveo.html This driver is part of Xilinx

Re: [PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices

2021-02-18 Thread Srinivasan Raju
Hi, Please find a few responses to the comments , We will fix rest of the comments and submit v14 of the patch. > Also, you *really* need some validation here, rather than blindly > trusting that the file is well-formed, otherwise you immediately have a > security issue here. The firmware is

Re: [PATCH v2 1/4] hmm: Device exclusive memory access

2021-02-18 Thread kernel test robot
Hi Alistair, Thank you for the patch! Yet something to improve: [auto build test ERROR on kselftest/next] [also build test ERROR on linus/master v5.11 next-20210218] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH V3 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-02-18 Thread Viresh Kumar
On 18-02-21, 16:36, Ionela Voinescu wrote: > Yes, we don't care if there is no cpufreq driver, as the use of AMUs won't > get initialised either. But we do care if there is a cpufreq driver that > does not support frequency invariance, which is the example above. > > The intention with the

Re: [PATCH v8 2/6] arm64: hyperv: Add Hyper-V clocksource/clockevent support

2021-02-18 Thread kernel test robot
Hi Michael, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on tip/timers/core efi/next linus/master v5.11 next-20210218] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH v2 1/4] hmm: Device exclusive memory access

2021-02-18 Thread Alistair Popple
2021 3:04:07 PM AEDT kernel test robot wrote: > External email: Use caution opening links or attachments > > > Hi Alistair, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on kselftest/next] > [also build test ERROR on linus

amdgpu, 5.11.0, suicide when input of monitor is switched

2021-02-18 Thread Norbert Preining
Hi all After switching inputs of the display I use (two computers are connected, one via DP and the current one via HDMI), the AMD GPU I use stopped sending signals to the display. The kernel log showed the following: [ 262.300879] [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]]

[PATCH 8/8] __unix_find_socket_byname(): don't pass hash and type separately

2021-02-18 Thread Al Viro
We only care about exclusive or of those, so pass that directly. Makes life simpler for callers as well... Signed-off-by: Al Viro --- net/unix/af_unix.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index

[PATCH 6/8] unix_bind_bsd(): move done_path_create() call after dealing with ->bindlock

2021-02-18 Thread Al Viro
Final preparations for doing unlink on failure past the successful mknod. We can't hold ->bindlock over ->mknod() or ->unlink(), since either might do sb_start_write() (e.g. on overlayfs). However, we can do it while holding filesystem and VFS locks - doing kern_path_create()

[PATCH 5/8] fold unix_mknod() into unix_bind_bsd()

2021-02-18 Thread Al Viro
Signed-off-by: Al Viro --- net/unix/af_unix.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index d7aeb4827747..36b88c8c438b 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -984,45

[PATCH 7/8] unix_bind_bsd(): unlink if we fail after successful mknod

2021-02-18 Thread Al Viro
We can do that more or less safely, since the parent is held locked all along. Yes, somebody might observe the object via dcache, only to have it disappear afterwards, but there's really no good way to prevent that. It won't race with other bind(2) or attempts to move the sucker elsewhere, or

[PATCH 3/8] unix_bind(): separate BSD and abstract cases

2021-02-18 Thread Al Viro
We do get some duplication that way, but it's minor compared to parts that are different. What we get is an ability to change locking in BSD case without making failure exits very hard to follow. Signed-off-by: Al Viro --- net/unix/af_unix.c | 52

[PATCH 4/8] unix_bind(): take BSD and abstract address cases into new helpers

2021-02-18 Thread Al Viro
unix_bind_bsd() and unix_bind_abstract() respectively. Signed-off-by: Al Viro --- net/unix/af_unix.c | 144 +++-- 1 file changed, 74 insertions(+), 70 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index

[PATCH 1/8] af_unix: take address assignment/hash insertion into a new helper

2021-02-18 Thread Al Viro
Duplicated logics in all bind variants (autobind, bind-to-path, bind-to-abstract) gets taken into a common helper. Signed-off-by: Al Viro --- net/unix/af_unix.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/net/unix/af_unix.c

[PATCH 2/8] unix_bind(): allocate addr earlier

2021-02-18 Thread Al Viro
>From 24439dbb7b78cb301c73254b364020e6a3f31902 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Thu, 18 Feb 2021 15:52:53 -0500 Subject: [PATCH 2/8] unix_bind(): allocate addr earlier makes it easier to massage; we do pay for that by extra work (kmalloc+memcpy+kfree) in some error cases, but those

Re: [PATCH v8 0/3] CPUFreq: Add support for opp-sharing cpus

2021-02-18 Thread Viresh Kumar
On 18-02-21, 22:23, Nicola Mazzucato wrote: > Hi Viresh, > > In this V8 I have addressed your comments: > - correct the goto in patch 1/3 > - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() LGTM. I will apply them after the merge window is over. Thanks. -- viresh

[PATCH] scsi: arcmsr: catch bounds error earlier and dont panic

2021-02-18 Thread Tong Zhang
pARCMSR_CDB is calculated from a base address + a value read from controller with some bit shifting, the value is not checked and could possibly overflow the buffer and cause panic. The buffer is allocated using dma_alloc_coherent and the size is acb->uncache_size. Instead of crashing the system,

[GIT PULL] xfs: new code for 5.12

2021-02-18 Thread Darrick J. Wong
Hi Linus, Please pull the following branch containing all the new xfs code for 5.12. There's a lot going on this time, which seems about right for this drama-filled year. Community developers added some code to speed up freezing when read-only workloads are still running, refactored the logging

Re: [PATCH] fs: export kern_path_locked

2021-02-18 Thread Al Viro
On Tue, Feb 16, 2021 at 06:00:34PM +, Al Viro wrote: > Sigh... OK, so we want something like > user_path_create() > vfs_mknod() > created = true > grab bindlock > > drop bindlock > if failed && created > vfs_unlink() >

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Viresh Kumar
On 19-02-21, 11:38, Yue Hu wrote: > There's a possibility: we will use the previous freq to update if next_f > is reduced for busy CPU if need_freq_update is set in > sugov_update_next_freq(). Right. > This possibility would happen now? And this > update is what we want if it happens? This is

Re: [PATCH v2 1/4] hmm: Device exclusive memory access

2021-02-18 Thread kernel test robot
Hi Alistair, Thank you for the patch! Yet something to improve: [auto build test ERROR on kselftest/next] [also build test ERROR on linus/master v5.11 next-20210218] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v8 7/9] crypto: hisilicon/hpre - add 'ECDH' algorithm

2021-02-18 Thread Herbert Xu
On Fri, Feb 19, 2021 at 09:25:13AM +0800, yumeng wrote: > > And p224 and p521 are the same as p384 (has no user and no > generic implementation), so they should be supported by HPRE later, > is it? Right. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

DID YOU RECEIVE MY MAIL?

2021-02-18 Thread Abdwabbo Maddah
-- Dear, I had sent you a mail but i don't think you received it that's why am writing you again.It is important you get back to me as soon as you can. Abd-Wabbo Maddah

Re: [PATCH v12 13/14] mm/vmalloc: Hugepage vmalloc mappings

2021-02-18 Thread Ding Tianhong
Hi Nicholas: I met some problem for this patch, like this: kva = vmalloc(3*1024k); remap_vmalloc_range(xxx, kva, xxx) It failed because that the check for page_count(page) is null so return, it break the some logic for current modules. because the new huge page is not valid for composed page.

[PATCH] Input: zinitix - fix return type of zinitix_init_touch()

2021-02-18 Thread Dmitry Torokhov
zinitix_init_touch() returns error code or 0 for success and therefore return type must be int, not bool. Fixes: 26822652c85e ("Input: add zinitix touchscreen driver") Reported-by: kernel test robot Reported-by: Jiapeng Chong Signed-off-by: Dmitry Torokhov ---

[PATCH] staging: emxx_udc: remove unused variable driver_desc

2021-02-18 Thread Sean Behan
Signed-off-by: Sean Behan --- drivers/staging/emxx_udc/emxx_udc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index 3536c03ff523..741147a4f0fe 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Yue Hu
On Thu, 18 Feb 2021 15:50:29 +0530 Viresh Kumar wrote: > On 18-02-21, 16:25, Yue Hu wrote: > > From: Yue Hu > > > > For busy CPU case, we do not need to avoid freq reduction if limits > > change since commit 600f5badb78c ("cpufreq: schedutil: Don't skip > > freq update when limits change"). >

[GIT PULL] iomap: new code for 5.12-rc1

2021-02-18 Thread Darrick J. Wong
Hi Linus, Please pull these new changes to the iomap code for 5.12. The big change in this cycle is some new code to make it possible for XFS to try unaligned directio overwrites without taking locks. If the block is fully written and within EOF (i.e. doesn't require any further fs

Re: [PATCH] Input: fix boolreturn.cocci warnings

2021-02-18 Thread Dmitry Torokhov
Hi, On Thu, Feb 18, 2021 at 05:59:53PM +0800, kernel test robot wrote: > From: kernel test robot > > drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in > function 'zinitix_init_touch' with return type bool > > Return statements in functions returning bool should use >

Re: [PATCH] Input: Use true and false for bool variable

2021-02-18 Thread Dmitry Torokhov
Hi, On Thu, Feb 18, 2021 at 06:23:55PM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in > function 'zinitix_init_touch' with return type bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-18 Thread Jason Wang
On 2021/2/18 8:43 下午, Si-Wei Liu wrote: On 2/17/2021 8:44 PM, Jason Wang wrote: On 2021/2/10 下午4:59, Si-Wei Liu wrote: On 2/9/2021 7:53 PM, Jason Wang wrote: On 2021/2/10 上午10:30, Si-Wei Liu wrote: On 2/8/2021 10:37 PM, Jason Wang wrote: On 2021/2/9 下午2:12, Eli Cohen wrote: On

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-18 Thread Lakshmi Ramasubramanian
On 2/18/21 5:13 PM, Thiago Jung Bauermann wrote: Lakshmi Ramasubramanian writes: On 2/18/21 4:07 PM, Mimi Zohar wrote: Hi Mimi, On Thu, 2021-02-18 at 14:33 -0800, Lakshmi Ramasubramanian wrote: of_kexec_alloc_and_setup_fdt() defined in drivers/of/kexec.c builds a new device tree object

Re: [PATCH v8 2/6] arm64: hyperv: Add Hyper-V clocksource/clockevent support

2021-02-18 Thread kernel test robot
Hi Michael, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on arm64/for-next/core] [also build test WARNING on tip/timers/core efi/next linus/master v5.11 next-20210218] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

mmotm 2021-02-18-18-29 uploaded

2021-02-18 Thread akpm
The mm-of-the-moment snapshot 2021-02-18-18-29 has been uploaded to https://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: https://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You

[PATCH v2 1/1] PCI/RCEC: Fix RCiEP capable devices RCEC association

2021-02-18 Thread Qiuxu Zhuo
Function rcec_assoc_rciep() incorrectly used "rciep->devfn" (a single byte encoding the device and function number) as the device number to check whether the corresponding bit was set in the RCiEPBitmap of the RCEC (Root Complex Event Collector) while enumerating over each bit of the RCiEPBitmap.

[PATCH v4 2/3] bus: mhi: core: Download AMSS image from appropriate function

2021-02-18 Thread Bhaumik Bhatt
During full boot chain firmware download, the PM state worker downloads the AMSS image after a blocking wait for the SBL execution environment change when running in PBL transition itself. Improve this design by having the host download the AMSS image from the SBL transition of PM state worker

[PATCH] bus: mhi: core: Move to polling method to wait for MHI ready

2021-02-18 Thread Bhaumik Bhatt
In certain devices, it is likely that there is no incoming MHI interrupt for a transition to MHI READY state. One such example is the move from Pass Through to an SBL or AMSS execution environment. In order to facilitate faster bootup times as there is no need to wait until timeout_ms completes,

[PATCH v4 0/3] Serialize execution environment changes for MHI

2021-02-18 Thread Bhaumik Bhatt
v4: -Addressed review comments for additional info logging for EE movements -Updated switch case for EE handling in mhi_intvec_threaded_handler() v3: -Update commit text to accurately reflect changes and reasoning based on reviews v2: -Add patch to clear devices when moving execution

[PATCH v4 1/3] bus: mhi: core: Clear devices when moving execution environments

2021-02-18 Thread Bhaumik Bhatt
When moving from SBL to mission mode execution environment, there is no remove callback notification to MHI client drivers which operate on SBL mode only. Client driver devices are being created in SBL or AMSS(mission mode) and only destroyed after power down or SYS_ERROR. If there exist any

[PATCH v4 3/3] bus: mhi: core: Process execution environment changes serially

2021-02-18 Thread Bhaumik Bhatt
In current design, whenever the BHI interrupt is fired, the execution environment is updated. This can cause race conditions and impede ongoing power up/down processing. For example, if a power down is in progress, MHI host updates to a local "disabled" execution environment. If a BHI interrupt

Re: [PATCH v2 1/2] mm: Make alloc_contig_range handle free hugetlb pages

2021-02-18 Thread Mike Kravetz
On 2/18/21 4:00 AM, Oscar Salvador wrote: > alloc_contig_range will fail if it ever sees a HugeTLB page within the > range we are trying to allocate, even when that page is free and can be > easily reallocated. > This has proofed to be problematic for some users of alloc_contic_range, > e.g: CMA

[PATCH v2 1/4] hmm: Device exclusive memory access

2021-02-18 Thread Alistair Popple
Some devices require exclusive write access to shared virtual memory (SVM) ranges to perform atomic operations on that memory. This requires CPU page tables to be updated to deny access whilst atomic operations are occurring. In order to do this introduce a new swap entry type

[PATCH v2 4/4] nouveau/svm: Implement atomic SVM access

2021-02-18 Thread Alistair Popple
Some NVIDIA GPUs do not support direct atomic access to system memory via PCIe. Instead this must be emulated by granting the GPU exclusive access to the memory. This is achieved by replacing CPU page table entries with special swap entries that fault on userspace access. The driver then grants

[PATCH v2 3/4] nouveau/svm: Refactor nouveau_range_fault

2021-02-18 Thread Alistair Popple
Call mmu_interval_notifier_insert() as part of nouveau_range_fault(). This doesn't introduce any functional change but makes it easier for a subsequent patch to alter the behaviour of nouveau_range_fault() to support GPU atomic operations. Signed-off-by: Alistair Popple ---

[PATCH v2 0/4] Add support for SVM atomics in Nouveau

2021-02-18 Thread Alistair Popple
This is the second version of a series to add support to Nouveau for atomic memory operations on OpenCL shared virtual memory (SVM) regions. This is achieved using the atomic PTE bits on the GPU to only permit atomic operations to system memory when a page is not mapped in userspace on the CPU.

[PATCH v2 2/4] hmm: Selftests for exclusive device memory

2021-02-18 Thread Alistair Popple
Adds some selftests for exclusive device memory. Signed-off-by: Alistair Popple --- lib/test_hmm.c | 124 ++ lib/test_hmm_uapi.h| 2 + tools/testing/selftests/vm/hmm-tests.c | 219 + 3 files changed, 345

Re: [PATCH] ntfs: check for valid standard information attribute

2021-02-18 Thread Anton Altaparmakov
Hi Andrew, Can you please push this one upstream? Thanks a lot in advance! Best regards, Anton > On 17 Feb 2021, at 15:59, Rustam Kovhaev wrote: > > we should check for valid STANDARD_INFORMATION attribute offset and > length before trying to access it > > Reported-and-tested-by:

RE: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices

2021-02-18 Thread Zhuo, Qiuxu
> ... > > I took your suggestion and came up with the following: > > Function rcec_assoc_rciep() incorrectly used "rciep->devfn" (a single > byte encoding the device and function number) as the device number to > check whether the corresponding bit was set in the RCiEPBitmap of the >

RE: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices

2021-02-18 Thread Zhuo, Qiuxu
>... > > We could probably add the following: > > Fixes: 507b460f8144 ("PCI/ERR: Add pcie_link_rcec() to associate RCiEPs") > OK. Will add this to the v2. Thanks! -Qiuxu

Re: [PATCH 3/3] vfio/type1: batch page pinning

2021-02-18 Thread Daniel Jordan
Alex Williamson writes: > This might not be the first batch we fill, I think this needs to unwind > rather than direct return. So it does, well spotted. And it's the same thing with the ENODEV case farther up. > Series looks good otherwise. Thanks for going through it!

RE: [PATCH v5 05/14] vfio/mdev: idxd: add basic mdev registration and helper functions

2021-02-18 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, February 17, 2021 5:33 AM > > On Tue, Feb 16, 2021 at 12:04:55PM -0700, Dave Jiang wrote: > > > > > + return remap_pfn_range(vma, vma->vm_start, pgoff, req_size, > pg_prot); > > > Nothing validated req_size - did you copy this from the Intel RDMA

Re: [PATCH 05/14] KVM: x86/mmu: Consult max mapping level when zapping collapsible SPTEs

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Mike Kravetz wrote: > On 2/18/21 8:23 AM, Sean Christopherson wrote: > > On Thu, Feb 18, 2021, Paolo Bonzini wrote: > >> On 13/02/21 01:50, Sean Christopherson wrote: > >>> > >>> pfn = spte_to_pfn(iter.old_spte); > >>> if (kvm_is_reserved_pfn(pfn) || > >>>

Re: [PATCH v8 7/9] crypto: hisilicon/hpre - add 'ECDH' algorithm

2021-02-18 Thread yumeng
在 2021/2/19 4:01, Herbert Xu 写道: On Thu, Feb 18, 2021 at 10:24:40AM +0800, yumeng wrote: Ecdh-nist-p384 is supported by HPRE now, currently there is no patch of the generic ecdh-nist-p384. In that case please leave it out until there is: 1) An in-kernel user of p384. 2) There is a

Re: [PATCH v5 4/5] x86/signal: Detect and prevent an alternate signal stack overflow

2021-02-18 Thread Andy Lutomirski
On Wed, Feb 3, 2021 at 9:27 AM Chang S. Bae wrote: > > The kernel pushes context on to the userspace stack to prepare for the > user's signal handler. When the user has supplied an alternate signal > stack, via sigaltstack(2), it is easy for the kernel to verify that the > stack size is

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-18 Thread Thiago Jung Bauermann
Lakshmi Ramasubramanian writes: > On 2/18/21 4:07 PM, Mimi Zohar wrote: > > Hi Mimi, > >> On Thu, 2021-02-18 at 14:33 -0800, Lakshmi Ramasubramanian wrote: >>> of_kexec_alloc_and_setup_fdt() defined in drivers/of/kexec.c builds >>> a new device tree object that includes architecture specific

Re: [PATCH v6 0/2] fix a NULL pointer bug and simplify the code

2021-02-18 Thread Jens Axboe
On 2/18/21 5:26 AM, Sun Ke wrote: > fix a NULL pointer bug and simplify the code > > v6: Just add if (nbd->recv_workq) to nbd_disconnect_and_put(). > v5: Adjust the title and add “Suggested-by”. > v4: Share exception handling code for if branches and > move put_nbd adjustment to a separate

[PATCH v3] IMA: support for duplicate measurement records

2021-02-18 Thread Tushar Sugandhi
IMA does not include duplicate file, buffer, or critical data measurement records since TPM extend is a very expensive operation. However, in some cases, the measurement of duplicate records is necessary to accurately determine the current state of the system. For instance - the file, buffer, or

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-18 Thread Lakshmi Ramasubramanian
On 2/18/21 4:07 PM, Mimi Zohar wrote: Hi Mimi, On Thu, 2021-02-18 at 14:33 -0800, Lakshmi Ramasubramanian wrote: of_kexec_alloc_and_setup_fdt() defined in drivers/of/kexec.c builds a new device tree object that includes architecture specific data for kexec system call. This should be defined

Re: [PATCH] arm64: dts: qcom: sc7180: Avoid glitching SPI CS at bootup on trogdor

2021-02-18 Thread Doug Anderson
Hi, On Thu, Feb 18, 2021 at 2:55 PM Douglas Anderson wrote: > > it's believed > that, under certain timing conditions, it could be getting the EC into > a confused state causing the EC driver to fail to probe. Believed => confirmed I _think_ is

Re: pstore: fix compression

2021-02-18 Thread Jiri Bohac
On Thu, Feb 18, 2021 at 12:30:03PM -0800, Kees Cook wrote: > Eek; thanks for the catch! thanks for applying the fix; BTW, with the compression broken, I was not getting any dmesg stored in ERST at all, not even uncompressed. After instrumenting the code with a lot of debug printks I found that

[PATCH v7 4/6] userfaultfd: add UFFDIO_CONTINUE ioctl

2021-02-18 Thread Axel Rasmussen
This ioctl is how userspace ought to resolve "minor" userfaults. The idea is, userspace is notified that a minor fault has occurred. It might change the contents of the page using its second non-UFFD mapping, or not. Then, it calls UFFDIO_CONTINUE to tell the kernel "I have ensured the page

[PATCH v7 3/6] userfaultfd: hugetlbfs: only compile UFFD helpers if config enabled

2021-02-18 Thread Axel Rasmussen
For background, mm/userfaultfd.c provides a general mcopy_atomic implementation. But some types of memory (i.e., hugetlb and shmem) need a slightly different implementation, so they provide their own helpers for this. In other words, userfaultfd is the only caller of these functions. This patch

[PATCH v7 5/6] userfaultfd: update documentation to describe minor fault handling

2021-02-18 Thread Axel Rasmussen
Reword / reorganize things a little bit into "lists", so new features / modes / ioctls can sort of just be appended. Describe how UFFDIO_REGISTER_MODE_MINOR and UFFDIO_CONTINUE can be used to intercept and resolve minor faults. Make it clear that COPY and ZEROPAGE are used for MISSING faults,

[PATCH v7 6/6] userfaultfd/selftests: add test exercising minor fault handling

2021-02-18 Thread Axel Rasmussen
Fix a dormant bug in userfaultfd_events_test(), where we did `return faulting_process(0)` instead of `exit(faulting_process(0))`. This caused the forked process to keep running, trying to execute any further test cases after the events test in parallel with the "real" process. Add a simple test

[PATCH v7 1/6] userfaultfd: add minor fault registration mode

2021-02-18 Thread Axel Rasmussen
This feature allows userspace to intercept "minor" faults. By "minor" faults, I mean the following situation: Let there exist two mappings (i.e., VMAs) to the same page(s). One of the mappings is registered with userfaultfd (in minor mode), and the other is not. Via the non-UFFD mapping, the

[PATCH v7 2/6] userfaultfd: disable huge PMD sharing for MINOR registered VMAs

2021-02-18 Thread Axel Rasmussen
As the comment says: for the MINOR fault use case, although the page might be present and populated in the other (non-UFFD-registered) half of the mapping, it may be out of date, and we explicitly want userspace to get a minor fault so it can check and potentially update the page's contents. Huge

  1   2   3   4   5   6   7   8   9   10   >