Re: [PATCH v2] ACPI: NFIT: Optimize nfit_mem_cmp() for efficiency

2023-10-18 Thread Kuan-Wei Chiu
On Wed, Oct 18, 2023 at 01:17:31PM +0200, Rafael J. Wysocki wrote: > On Fri, Oct 13, 2023 at 2:22 PM Kuan-Wei Chiu wrote: > > > > The original code used conditional branching in the nfit_mem_cmp > > function to compare two values and return -1, 1, or 0 based on the > > result. However, the

[PATCH] tracefs/eventfs: Modify mismatched function name

2023-10-18 Thread Jiapeng Chong
No functional modification involved. fs/tracefs/event_inode.c:864: warning: expecting prototype for eventfs_remove(). Prototype was for eventfs_remove_dir() instead. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6939 Signed-off-by: Jiapeng Chong ---

Re: [PATCH 2/2] mm: multi-gen lru: fix stat count

2023-10-18 Thread Yu Zhao
On Wed, Oct 18, 2023 at 8:17 PM Huan Yang wrote: > > Hi Yu Zhao, > > Thanks for your reply. > > 在 2023/10/19 0:21, Yu Zhao 写道: > > On Wed, Oct 18, 2023 at 2:22 AM Huan Yang wrote: > >> For multi-gen lru reclaim in evict_folios, like shrink_inactive_list, > >> gather folios which isolate to

Re: [PATCH 1/2] tracing: mm: multigen-lru: fix mglru trace

2023-10-18 Thread Huan Yang
在 2023/10/19 0:28, Yu Zhao 写道: On Wed, Oct 18, 2023 at 2:22 AM Huan Yang wrote: This patch add two reclaim stat: nr_promote: nr_pages shrink before promote by folio_update_gen. nr_demote: nr_pages NUMA demotion passed. The above isn't specific to MLGRU, so they should be in a separate

Re: [PATCH 2/2] mm: multi-gen lru: fix stat count

2023-10-18 Thread Huan Yang
Hi Yu Zhao, Thanks for your reply. 在 2023/10/19 0:21, Yu Zhao 写道: On Wed, Oct 18, 2023 at 2:22 AM Huan Yang wrote: For multi-gen lru reclaim in evict_folios, like shrink_inactive_list, gather folios which isolate to reclaim, and invoke shirnk_folio_list. But, when complete shrink, it not

Re: [PATCH 2/4] arm64: dts: qcom: qcm6490-fairphone-fp5: Add PM7250B thermals

2023-10-18 Thread Konrad Dybcio
On 10/13/23 10:09, Luca Weiss wrote: Configure the thermals for the CHARGER_SKIN_THERM and USB_CONN_THERM thermistors connected to PM7250B. Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 66 ++ 1 file changed, 66 insertions(+) diff

Re: [PATCH 4/4] arm64: dts: qcom: qcm6490-fairphone-fp5: Add PM7325 thermals

2023-10-18 Thread Konrad Dybcio
On 10/14/23 19:52, Luca Weiss wrote: On Samstag, 14. Oktober 2023 01:13:29 CEST Konrad Dybcio wrote: On 13.10.2023 10:09, Luca Weiss wrote: Configure the thermals for the QUIET_THERM, CAM_FLASH_THERM, MSM_THERM and RFC_CAM_THERM thermistors connected to PM7325. With this PMIC the software

Re: [PATCH] arm64: dts: qcom: msm8939-longcheer-l9100: Add proximity-near-level

2023-10-18 Thread André Apitzsch
Am Mittwoch, dem 18.10.2023 um 10:32 +0200 schrieb Konrad Dybcio: > > > On 10/17/23 22:03, André Apitzsch wrote: > > Am Dienstag, dem 17.10.2023 um 18:25 +0200 schrieb Konrad Dybcio: > > > > > > > > > On 10/16/23 22:18, André Apitzsch wrote: > > > > Consider an object near to the sensor when

Re: [PATCH 5/5] modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules

2023-10-18 Thread Luis Chamberlain
On Wed, Oct 18, 2023 at 07:31:46AM +0200, Christoph Hellwig wrote: > On Wed, Oct 18, 2023 at 01:30:18AM +0100, David Woodhouse wrote: > > > > But if we're going to tolerate the core kernel still exporting some > > stuff with EXPORT_SYMBOL, why isn't OK for a GPL-licensed module do to > > the

Re: [PATCH] eventfs: Use ERR_CAST() in eventfs_create_events_dir()

2023-10-18 Thread Kees Cook
On Wed, Oct 18, 2023 at 11:10:31AM -0700, Nathan Chancellor wrote: > When building with clang and CONFIG_RANDSTRUCT_FULL=y, there is an error > due to a cast in eventfs_create_events_dir(): > > fs/tracefs/event_inode.c:734:10: error: casting from randomized structure > pointer type 'struct

[PATCH] eventfs: Use ERR_CAST() in eventfs_create_events_dir()

2023-10-18 Thread Nathan Chancellor
AST(dentry); ei = kzalloc(sizeof(*ei), GFP_KERNEL); if (!ei) --- base-commit: 5ddd8baa4857709b4e5d84b376d735152851955b change-id: 20231018-ftrace-fix-clang-randstruct-0cb6899523ac Best regards, -- Nathan Chancellor

Re: [PATCH v6 3/4] remoteproc: zynqmp: add pm domains support

2023-10-18 Thread Mathieu Poirier
Good morning, On Thu, Oct 12, 2023 at 09:22:28PM -0700, Tanmay Shah wrote: > Use TCM pm domains extracted from device-tree > to power on/off TCM using general pm domain framework. > > Signed-off-by: Tanmay Shah > --- > > Changes in v6: > - Remove spurious change > - Handle errors in

Re: [PATCH v5 12/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC

2023-10-18 Thread Haitao Huang
On Wed, 18 Oct 2023 10:52:23 -0500, Michal Koutný wrote: On Wed, Oct 18, 2023 at 08:37:25AM -0700, Dave Hansen wrote: 1. Admin sets a limit 2. Enclave is created 3. Enclave hits limit, allocation fails I was actually about to suggest reorganizing the series to a part implementing this

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-18 Thread Steven Rostedt
On Wed, 18 Oct 2023 17:40:28 +0300 Francis Laniel wrote: > Changes since: > v1: > * Use EADDRNOTAVAIL instead of adding a new error code. > * Correct also this behavior for sysfs kprobe. > v2: > * Count the number of symbols corresponding to function name and return > EADDRNOTAVAIL if

Re: [PATCH 1/2] tracing: mm: multigen-lru: fix mglru trace

2023-10-18 Thread Yu Zhao
On Wed, Oct 18, 2023 at 2:22 AM Huan Yang wrote: > > This patch add two reclaim stat: > nr_promote: nr_pages shrink before promote by folio_update_gen. > nr_demote: nr_pages NUMA demotion passed. The above isn't specific to MLGRU, so they should be in a separate patchset. > And then, use

Re: [PATCH 2/2] mm: multi-gen lru: fix stat count

2023-10-18 Thread Yu Zhao
On Wed, Oct 18, 2023 at 2:22 AM Huan Yang wrote: > > For multi-gen lru reclaim in evict_folios, like shrink_inactive_list, > gather folios which isolate to reclaim, and invoke shirnk_folio_list. > > But, when complete shrink, it not gather shrink reclaim stat into sc, > we can't get info like

Re: [PATCH v5 12/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC

2023-10-18 Thread Michal Koutný
On Wed, Oct 18, 2023 at 08:37:25AM -0700, Dave Hansen wrote: > 1. Admin sets a limit > 2. Enclave is created > 3. Enclave hits limit, allocation fails I was actually about to suggest reorganizing the series to a part implementing this simple limiting and a subsequent part with the reclaim stuff

Re: [PATCH v5 12/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC

2023-10-18 Thread Dave Hansen
On 10/18/23 08:26, Haitao Huang wrote: > Maybe not in sense of killing something. My understanding memory.reclaim > does not necessarily invoke the OOM killer. But what I really intend to > say is we can have a separate knob for user to express the need for > reducing the current usage explicitly

Re: [PATCH v2 5/6] ACPI: NFIT: Replace acpi_driver with platform_driver

2023-10-18 Thread Wilczynski, Michal
On 10/17/2023 8:24 PM, Dan Williams wrote: > Michal Wilczynski wrote: >> NFIT driver uses struct acpi_driver incorrectly to register itself. >> This is wrong as the instances of the ACPI devices are not meant >> to be literal devices, they're supposed to describe ACPI entry of a >> particular

Re: [PATCH v5 12/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC

2023-10-18 Thread Haitao Huang
On Wed, 18 Oct 2023 08:55:12 -0500, Dave Hansen wrote: On 10/17/23 21:37, Haitao Huang wrote: Yes we can introduce misc.reclaim to give user a knob to forcefully reducing usage if that is really needed in real usage. The semantics would make force-kill VMs explicit to user. Do any other

Re: [PATCH v10 4/5] kprobes: freelist.h removed

2023-10-18 Thread Google
Hi, On Mon, 16 Oct 2023 22:23:14 +0900 Masami Hiramatsu (Google) wrote: > Hi Peter, > > This freelist has been introduced by you, is it OK to remove this because no > other user exists? I'll pick this on my probes/for-next branch. If there is any issue reported, I'll revert it. Thank you, >

Re: [PATCH v11 0/5] lib,kprobes: kretprobe scalability improvement

2023-10-18 Thread Google
Hi, On Tue, 17 Oct 2023 21:56:49 +0800 "wuqiang.matt" wrote: > This patch series introduces a scalable and lockless ring-array based > object pool to improve scalability of kretprobed routines. > > v11: > *) patchset rebased to branch probes/core of linux-trace.git > *) objpool:

[tip:sched/core] [sched/numa] f169c62ff7: autonuma-benchmark.numa01.seconds -32.0% improvement

2023-10-18 Thread kernel test robot
e as below: --> The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20231018/202310182223.6ef26fcb-oliver.s

Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

2023-10-18 Thread Francis Laniel
Hi! Le mercredi 18 octobre 2023, 09:30:20 EEST Masami Hiramatsu a écrit : > Hi Francis, > > On Thu, 31 Aug 2023 09:14:55 +0200 > > Francis Laniel wrote: > > Hi. > > > > Le mercredi 30 août 2023, 01:57:19 CEST Steven Rostedt a écrit : > > > On Fri, 25 Aug 2023 22:13:21 +0900 > > > > > >

[PATCH v5 1/2] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

2023-10-18 Thread Francis Laniel
Previously to this commit, if func matches several symbols, a kprobe, being either sysfs or PMU, would only be installed for the first matching address. This could lead to some misunderstanding when some BPF code was never called because it was attached to a function which was indeed not called,

[PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-18 Thread Francis Laniel
Hi. In the kernel source code, it exists different functions which share the same name but which have, of course, different addresses as they can be defined in different modules: # Kernel was compiled with CONFIG_NTFS_FS and CONFIG_NTFS3_FS as built-in. root@vm-amd64:~# grep ntfs_file_write_iter

Re: [PATCH v5 12/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC

2023-10-18 Thread Dave Hansen
On 10/17/23 21:37, Haitao Huang wrote: > Yes we can introduce misc.reclaim to give user a knob to forcefully > reducing usage if that is really needed in real usage. The semantics > would make force-kill VMs explicit to user. Do any other controllers do something like this? It seems odd.

Re: [PATCH v2] ACPI: NFIT: Optimize nfit_mem_cmp() for efficiency

2023-10-18 Thread Rafael J. Wysocki
On Fri, Oct 13, 2023 at 2:22 PM Kuan-Wei Chiu wrote: > > The original code used conditional branching in the nfit_mem_cmp > function to compare two values and return -1, 1, or 0 based on the > result. However, the list_sort comparison function only needs results > <0, >0, or =0. This patch

Re: [PATCH v3] ACPI: NFIT: Use cleanup.h helpers instead of devm_*()

2023-10-18 Thread Rafael J. Wysocki
On Wed, Oct 18, 2023 at 6:28 AM Dan Williams wrote: > > Michal Wilczynski wrote: > > The new cleanup.h facilities that arrived in v6.5-rc1 can replace the > > the usage of devm semantics in acpi_nfit_init_interleave_set(). That > > routine appears to only be using devm to avoid goto statements.

Re: [PATCH] neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section

2023-10-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Mon, 16 Oct 2023 14:49:04 +0200 you wrote: > When CONFIG_IPV6=n, and building with W=1: > > In file included from include/trace/define_trace.h:102, >from include/trace/events/neigh.h:255, >

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-longcheer-l9100: Enable RGB LED

2023-10-18 Thread Konrad Dybcio
On 10/13/23 22:51, André Apitzsch wrote: l9100 uses KTD2026 LED driver. Add it to the device tree. Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] arm64: dts: qcom: msm8916-longcheer-l8910: Enable RGB LED

2023-10-18 Thread Konrad Dybcio
On 10/13/23 22:51, André Apitzsch wrote: l8910 uses KTD2026 LED driver. Add it to the device tree. Tested-by: Stephan Gerhold Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: msm8939-longcheer-l9100: Add proximity-near-level

2023-10-18 Thread Konrad Dybcio
On 10/17/23 22:03, André Apitzsch wrote: Am Dienstag, dem 17.10.2023 um 18:25 +0200 schrieb Konrad Dybcio: On 10/16/23 22:18, André Apitzsch wrote: Consider an object near to the sensor when their distance is about 4 cm or below. Signed-off-by: André Apitzsch --- Reviewed-by: Konrad

[PATCH 0/2] some fix of multi-gen lru

2023-10-18 Thread Huan Yang
For multi-gen lru shrink_inactive trace, here are some mistake: First, nr_scanned in evict_folios means all folios which it touched in `get_nr_to_scan`(so not means nr_taken). So, we may get some info from trace like this: ``` kswapd0-89[000]64.887613: mm_vmscan_lru_shrink_inactive:

[PATCH 2/2] mm: multi-gen lru: fix stat count

2023-10-18 Thread Huan Yang
For multi-gen lru reclaim in evict_folios, like shrink_inactive_list, gather folios which isolate to reclaim, and invoke shirnk_folio_list. But, when complete shrink, it not gather shrink reclaim stat into sc, we can't get info like nr_dirty\congested in reclaim, and then control writeback, dirty

[PATCH 1/2] tracing: mm: multigen-lru: fix mglru trace

2023-10-18 Thread Huan Yang
This patch add two reclaim stat: nr_promote: nr_pages shrink before promote by folio_update_gen. nr_demote: nr_pages NUMA demotion passed. And then, use correct nr_scanned which evict_folios passed into trace_mm_vmscan_lru_shrink_inactive. Mistake info like this: ``` kswapd0-89[000]

Re: [PATCH 2/3] usb: typec: fsa4480: Add support to swap SBU orientation

2023-10-18 Thread Heikki Krogerus
Hi Luca, > > Shouldn't you loop through the endpoints? In any case: > > > > ep = fwnode_graph_get_next_endpoint(dev_fwnode(>client->dev, > > NULL)); > > The docs only mention one endpoint so I'm assuming just next_endpoint is > fine? I'm mostly concerned about what we may have in the

Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

2023-10-18 Thread Google
Hi Francis, On Thu, 31 Aug 2023 09:14:55 +0200 Francis Laniel wrote: > Hi. > > Le mercredi 30 août 2023, 01:57:19 CEST Steven Rostedt a écrit : > > On Fri, 25 Aug 2023 22:13:21 +0900 > > > > Masami Hiramatsu (Google) wrote: > > > > Excellent catch! Thank you, I will apply this patch and send