[PATCH -next] VDUSE: fix another doc underline warning

2024-02-22 Thread Randy Dunlap
Extend the underline for a heading to prevent a documentation build warning. Also spell "reconnection" correctly. Documentation/userspace-api/vduse.rst:236: WARNING: Title underline too short. HOW VDUSE devices reconnectoin works Fixes: 2b3fd606c662 ("Documentation: Add

[PATCH] ftrace: fix most kernel-doc warnings

2024-02-22 Thread Randy Dunlap
Reduce the number of kernel-doc warnings from 52 down to 10, i.e., fix 42 kernel-doc warnings by (a) using the Returns: format for function return values or (b) using "@var:" instead of "@var -" for function parameter descriptions. Fix one return values list so that it is formatted correctly when

Re: [RFC PATCH 11/14] csky/thread_info: Introduce TIF_NOTIFY_IPI flag

2024-02-22 Thread Guo Ren
On Wed, Feb 21, 2024 at 1:20 AM K Prateek Nayak wrote: > > Add support for TIF_NOTIFY_IPI on C-SKY. With TIF_NOTIFY_IPI, a sender > sending an IPI to an idle CPU in TIF_POLLING mode will set the > TIF_NOTIFY_IPI flag in the target's idle tasks's thread_info to pull the > CPU out of idle, as

Re: [PATCH v19 0/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-22 Thread Ankit Agrawal
>> Ankit Agrawal (3): >>   vfio/pci: rename and export do_io_rw() >>   vfio/pci: rename and export range_intersect_range >>   vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper >> >>  MAINTAINERS   |  16 +- >>  drivers/vfio/pci/Kconfig  |   2 + >> 

Re: [PATCH net-next v5] virtio_net: Support RX hash XDP hint

2024-02-22 Thread Xuan Zhuo
On Fri, 09 Feb 2024 13:57:25 +0100, Paolo Abeni wrote: > On Fri, 2024-02-09 at 18:39 +0800, Liang Chen wrote: > > On Wed, Feb 7, 2024 at 10:27 PM Paolo Abeni wrote: > > > > > > On Wed, 2024-02-07 at 10:54 +0800, Liang Chen wrote: > > > > On Tue, Feb 6, 2024 at 6:44 PM Paolo Abeni wrote: > > > >

[PATCH 1/2] tracing: Fix snapshot counter going between two tracers that use it

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Running the ftrace selftests caused the ring buffer mapping test to fail. Investigating, I found that the snapshot counter would be incremented every time a tracer that uses the snapshot is enabled even if the snapshot was used by the previous tracer. That is:

[PATCH 0/2] tracing: Fix snapshot accounting

2024-02-22 Thread Steven Rostedt
The ring buffer mapping test failed after running the ftrace tests. This was due to some mismatched snapshot accounting that left the snapshot counter enabled when it was not, which prevents the ring buffer from being mapped. Steven Rostedt (Google) (2): tracing: Fix snapshot counter

[PATCH 2/2] tracing: Decrement the snapshot if the snapshot trigger fails to register

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Running the ftrace selftests caused the ring buffer mapping test to fail. Investigating, I found that the snapshot counter would be incremented every time a snapshot trigger was added, even if that snapshot trigger failed. # cd /sys/kernel/tracing # echo

Re: [PATCH] virtiofs: limit the length of ITER_KVEC dio by max_nopage_rw

2024-02-22 Thread Hou Tao
Hi, On 2/23/2024 3:49 AM, Michael S. Tsirkin wrote: > On Wed, Jan 03, 2024 at 06:59:29PM +0800, Hou Tao wrote: >> From: Hou Tao >> >> When trying to insert a 10MB kernel module kept in a virtiofs with cache >> disabled, the following warning was reported: >> SNIP >> >> A feasible solution is

Re: [PATCH v9 10/15] x86/sgx: Add EPC reclamation in cgroup try_charge()

2024-02-22 Thread Haitao Huang
On Thu, 22 Feb 2024 15:26:05 -0600, Huang, Kai wrote: On 23/02/2024 6:09 am, Haitao Huang wrote: On Wed, 21 Feb 2024 05:06:02 -0600, Huang, Kai wrote: -int sgx_epc_cgroup_try_charge(struct sgx_epc_cgroup *epc_cg) +int sgx_epc_cgroup_try_charge(struct sgx_epc_cgroup *epc_cg, bool

Re: [PATCH v9 13/15] x86/sgx: Turn on per-cgroup EPC reclamation

2024-02-22 Thread Huang, Kai
On 23/02/2024 5:36 am, Haitao Huang wrote: On Wed, 21 Feb 2024 05:23:00 -0600, Huang, Kai wrote: On Mon, 2024-02-05 at 13:06 -0800, Haitao Huang wrote: From: Kristen Carlson Accardi Previous patches have implemented all infrastructure needed for per-cgroup EPC page tracking and

Re: [PATCH v9 08/15] x86/sgx: Implement EPC reclamation flows for cgroup

2024-02-22 Thread Huang, Kai
On 23/02/2024 6:20 am, Haitao Huang wrote: On Wed, 21 Feb 2024 05:00:27 -0600, Huang, Kai wrote: On Wed, 2024-02-21 at 00:44 -0600, Haitao Huang wrote: [...] > > Here the @nr_to_scan is reduced by the number of pages that are > isolated, but > not actually reclaimed (which is reflected by

Re: [PATCH v9 08/15] x86/sgx: Implement EPC reclamation flows for cgroup

2024-02-22 Thread Huang, Kai
On 23/02/2024 9:12 am, Haitao Huang wrote: On Wed, 21 Feb 2024 04:48:58 -0600, Huang, Kai wrote: On Wed, 2024-02-21 at 00:23 -0600, Haitao Huang wrote: StartHi Kai On Tue, 20 Feb 2024 03:52:39 -0600, Huang, Kai wrote: [...] > > So you introduced the work/workqueue here but there's no

Re: [PATCH v4 2/4] tracing/user_events: Introduce multi-format events

2024-02-22 Thread Steven Rostedt
On Thu, 22 Feb 2024 00:18:05 + Beau Belgrave wrote: > Currently user_events supports 1 event with the same name and must have > the exact same format when referenced by multiple programs. This opens > an opportunity for malicous or poorly thought through programs to malicious? ;-) --

Re: [PATCH v4 1/4] tracing/user_events: Prepare find/delete for same name events

2024-02-22 Thread Steven Rostedt
On Thu, 22 Feb 2024 00:18:04 + Beau Belgrave wrote: > The current code for finding and deleting events assumes that there will > never be cases when user_events are registered with the same name, but > different formats. Scenarios exist where programs want to use the same > name but have

Re: [PATCH v19 0/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-22 Thread Alex Williamson
On Tue, 20 Feb 2024 17:20:52 +0530 wrote: > From: Ankit Agrawal > > NVIDIA's upcoming Grace Hopper Superchip provides a PCI-like device > for the on-chip GPU that is the logical OS representation of the > internal proprietary chip-to-chip cache coherent interconnect. > > The device is

Re: [PATCH v9 10/15] x86/sgx: Add EPC reclamation in cgroup try_charge()

2024-02-22 Thread Huang, Kai
On 23/02/2024 6:09 am, Haitao Huang wrote: On Wed, 21 Feb 2024 05:06:02 -0600, Huang, Kai wrote: -int sgx_epc_cgroup_try_charge(struct sgx_epc_cgroup *epc_cg) +int sgx_epc_cgroup_try_charge(struct sgx_epc_cgroup *epc_cg, bool reclaim)  { -    return

[PATCH v2 4/4] tracing: Use EVENT_NULL_STR macro instead of open coding "(null)"

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The TRACE_EVENT macros has some dependency if a __string() field is NULL, where it will save "(null)" as the string. This string is also used by __assign_str(). It's better to create a single macro instead of having something that will not be caught by the

[PATCH v2 3/4] tracing: Use ? : shortcut in trace macros

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Instead of having: #define __assign_str(dst, src)\ memcpy(__get_str(dst), __data_offsets.dst##_ptr_ ? \ __data_offsets.dst##_ptr_ : "(null)", \

[PATCH v2 2/4] tracing: Do not calculate strlen() twice for __string() fields

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The TRACE_EVENT() macro handles dynamic strings by having: TP_PROTO(struct some_struct *s), TP_ARGS(s), TP_STRUCT__entry( __string(my_string, s->string) ), TP_fast_assign( __assign_str(my_string, s->string); ) TP_printk("%s",

[PATCH v2 1/4] tracing: Rework __assign_str() and __string() to not duplicate getting the string

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The TRACE_EVENT() macro handles dynamic strings by having: TP_PROTO(struct some_struct *s), TP_ARGS(s), TP_STRUCT__entry( __string(my_string, s->string) ), TP_fast_assign( __assign_str(my_string, s->string); ) TP_printk("%s",

[PATCH v2 0/4] tracing: Optimize __string()/__assign_str() processing

2024-02-22 Thread Steven Rostedt
The TRACE_EVENT() macro handles dynamic strings by having: TP_PROTO(struct some_struct *s), TP_ARGS(s), TP_STRUCT__entry( __string(my_string, s->string) ), TP_fast_assign( __assign_str(my_string, s->string); ) TP_printk("%s", __get_str(my_string)) There's even some code

Re: [PATCH] vduse: implement DMA sync callbacks

2024-02-22 Thread Michael S. Tsirkin
On Tue, Feb 20, 2024 at 01:01:36AM -0800, Christoph Hellwig wrote: > On Mon, Feb 19, 2024 at 06:06:06PM +0100, Maxime Coquelin wrote: > > Since commit 295525e29a5b ("virtio_net: merge dma > > operations when filling mergeable buffers"), VDUSE device > > require support for DMA's

Re: [PATCH v9 08/15] x86/sgx: Implement EPC reclamation flows for cgroup

2024-02-22 Thread Haitao Huang
On Wed, 21 Feb 2024 04:48:58 -0600, Huang, Kai wrote: On Wed, 2024-02-21 at 00:23 -0600, Haitao Huang wrote: StartHi Kai On Tue, 20 Feb 2024 03:52:39 -0600, Huang, Kai wrote: [...] > > So you introduced the work/workqueue here but there's no place which > actually > queues the work. IMHO

Re: [PATCH net-next v5] virtio_net: Support RX hash XDP hint

2024-02-22 Thread Michael S. Tsirkin
On Fri, Feb 09, 2024 at 01:57:25PM +0100, Paolo Abeni wrote: > On Fri, 2024-02-09 at 18:39 +0800, Liang Chen wrote: > > On Wed, Feb 7, 2024 at 10:27 PM Paolo Abeni wrote: > > > > > > On Wed, 2024-02-07 at 10:54 +0800, Liang Chen wrote: > > > > On Tue, Feb 6, 2024 at 6:44 PM Paolo Abeni wrote: >

Re: [PATCH 1/1] vhost: Added pad cleanup if vnet_hdr is not present.

2024-02-22 Thread Michael S. Tsirkin
On Mon, Jan 15, 2024 at 05:32:25PM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 15, 2024 at 09:48:40PM +0200, Andrew Melnychenko wrote: > > When the Qemu launched with vhost but without tap vnet_hdr, > > vhost tries to copy vnet_hdr from socket iter with size 0 > > to the page that may contain

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2024-02-22 Thread Michael S. Tsirkin
On Thu, Feb 01, 2024 at 12:47:39PM +0100, Tobias Huschle wrote: > I'll do some more testing with the cond_resched->schedule fix, check the > cgroup thing and wait for Peter then. > Will get back if any of the above yields some results. As I predicted, if you want attention from sched guys you

Re: [PATCH] virtiofs: limit the length of ITER_KVEC dio by max_nopage_rw

2024-02-22 Thread Michael S. Tsirkin
On Wed, Jan 03, 2024 at 06:59:29PM +0800, Hou Tao wrote: > From: Hou Tao > > When trying to insert a 10MB kernel module kept in a virtiofs with cache > disabled, the following warning was reported: > > [ cut here ] > WARNING: CPU: 2 PID: 439 at mm/page_alloc.c:4544

[PATCH 2/2] tracing: Do not calculate strlen() twice for __string() fields

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The TRACE_EVENT() macro handles dynamic strings by having: TP_PROTO(struct some_struct *s), TP_ARGS(s), TP_STRUCT__entry( __string(my_string, s->string) ), TP_fast_assign( __assign_str(my_string, s->string); ) TP_printk("%s",

[PATCH 0/2] tracing: Optimize __string()/__assign_str() processing

2024-02-22 Thread Steven Rostedt
The TRACE_EVENT() macro handles dynamic strings by having: TP_PROTO(struct some_struct *s), TP_ARGS(s), TP_STRUCT__entry( __string(my_string, s->string) ), TP_fast_assign( __assign_str(my_string, s->string); ) TP_printk("%s", __get_str(my_string)) There's even some

[PATCH 1/2] tracing: Rework __assign_str() and __string() to not duplicate getting the string

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The TRACE_EVENT() macro handles dynamic strings by having: TP_PROTO(struct some_struct *s), TP_ARGS(s), TP_STRUCT__entry( __string(my_string, s->string) ), TP_fast_assign( __assign_str(my_string, s->string); ) TP_printk("%s",

Re: [PATCH v2] PM: runtime: add tracepoint for runtime_status changes

2024-02-22 Thread Rafael J. Wysocki
On Wed, Feb 21, 2024 at 8:49 PM Vilas Bhat wrote: > > Existing runtime PM ftrace events (`rpm_suspend`, `rpm_resume`, > `rpm_return_int`) offer limited visibility into the exact timing of device > runtime power state transitions, particularly when asynchronous operations > are involved. When the

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2024-02-22 Thread Michael S. Tsirkin
On Tue, Jul 25, 2023 at 11:03:11AM +0800, Jason Wang wrote: > On Mon, Jul 24, 2023 at 3:18 PM Michael S. Tsirkin wrote: > > > > On Mon, Jul 24, 2023 at 02:52:49PM +0800, Jason Wang wrote: > > > On Mon, Jul 24, 2023 at 2:46 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Jul 21, 2023

Re: [PATCH v3 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-22 Thread Mathieu Poirier
Hi, On Wed, Feb 14, 2024 at 06:21:27PM +0100, Arnaud Pouliquen wrote: > The new TEE remoteproc device is used to manage remote firmware in a > secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is > introduced to delegate the loading of the firmware to the trusted > execution

Re: [PATCH] NFSD: Fix nfsd_clid_class use of __string_len() macro

2024-02-22 Thread Steven Rostedt
On Thu, 22 Feb 2024 13:25:34 -0500 Chuck Lever wrote: > Do you want me to take this through the nfsd tree, or would you like > an Ack from me so you can handle it as part of your clean up? Just > in case: > > Acked-by: Chuck Lever > As my patches depend on this, I can take it with your ack.

Re: [PATCH] NFSD: Fix nfsd_clid_class use of __string_len() macro

2024-02-22 Thread Chuck Lever
On Thu, Feb 22, 2024 at 12:28:28PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > I'm working on restructuring the __string* macros so that it doesn't need > to recalculate the string twice. That is, it will save it off when > processing __string() and the __assign_str() will

Re: [PATCH v3 5/7] dt-bindings: remoteproc: Add compatibility for TEE support

2024-02-22 Thread Rob Herring
On Wed, 14 Feb 2024 18:21:25 +0100, Arnaud Pouliquen wrote: > The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration > where the Cortex-M4 firmware is loaded by the Trusted execution Environment > (TEE). > For instance, this compatible is used in both the Linux and OP-TEE >

Re: [PATCH v9 08/15] x86/sgx: Implement EPC reclamation flows for cgroup

2024-02-22 Thread Haitao Huang
On Tue, 20 Feb 2024 03:52:39 -0600, Huang, Kai wrote: +/** + * sgx_epc_cgroup_reclaim_pages() - walk a cgroup tree and scan LRUs to reclaim pages + * @root: Root of the tree to start walking from. + * Return: Number of pages reclaimed. Just wondering, do you need to return @cnt

Re: [PATCH v2] mm: Update mark_victim tracepoints fields

2024-02-22 Thread Carlos Galo
On Thu, Feb 22, 2024 at 6:16 AM Michal Hocko wrote: > > On Wed 21-02-24 13:30:51, Carlos Galo wrote: > > On Tue, Feb 20, 2024 at 11:55 PM Michal Hocko wrote: > > > > > > Hi, > > > sorry I have missed this before. > > > > > > On Thu 11-01-24 21:05:30, Carlos Galo wrote: > > > > The current

[PATCH] NFSD: Fix nfsd_clid_class use of __string_len() macro

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" I'm working on restructuring the __string* macros so that it doesn't need to recalculate the string twice. That is, it will save it off when processing __string() and the __assign_str() will not need to do the work again as it currently does. Currently

Re: [PATCH v9 08/15] x86/sgx: Implement EPC reclamation flows for cgroup

2024-02-22 Thread Haitao Huang
On Wed, 21 Feb 2024 05:00:27 -0600, Huang, Kai wrote: On Wed, 2024-02-21 at 00:44 -0600, Haitao Huang wrote: [...] > > Here the @nr_to_scan is reduced by the number of pages that are > isolated, but > not actually reclaimed (which is reflected by @cnt). > > IIUC, looks you want to make this

Re: [PATCH v9 10/15] x86/sgx: Add EPC reclamation in cgroup try_charge()

2024-02-22 Thread Haitao Huang
On Wed, 21 Feb 2024 05:06:02 -0600, Huang, Kai wrote: -int sgx_epc_cgroup_try_charge(struct sgx_epc_cgroup *epc_cg) +int sgx_epc_cgroup_try_charge(struct sgx_epc_cgroup *epc_cg, bool reclaim) { - return misc_cg_try_charge(MISC_CG_RES_SGX_EPC, epc_cg->cg, PAGE_SIZE); + for

Re: [PATCH v9 13/15] x86/sgx: Turn on per-cgroup EPC reclamation

2024-02-22 Thread Haitao Huang
On Wed, 21 Feb 2024 05:23:00 -0600, Huang, Kai wrote: On Mon, 2024-02-05 at 13:06 -0800, Haitao Huang wrote: From: Kristen Carlson Accardi Previous patches have implemented all infrastructure needed for per-cgroup EPC page tracking and reclaiming. But all reclaimable EPC pages are still

Re: [PATCH v9 12/15] x86/sgx: Expose sgx_epc_cgroup_reclaim_pages() for global reclaimer

2024-02-22 Thread Haitao Huang
On Wed, 21 Feb 2024 05:10:36 -0600, Huang, Kai wrote: On Mon, 2024-02-05 at 13:06 -0800, Haitao Huang wrote: From: Kristen Carlson Accardi When cgroup is enabled, all reclaimable pages will be tracked in cgroup LRUs. The global reclaimer needs to start reclamation from the root cgroup.

Re: [syzbot] [virtualization?] linux-next boot error: WARNING: refcount bug in __free_pages_ok

2024-02-22 Thread Michael S. Tsirkin
On Thu, Feb 22, 2024 at 11:06:55AM +0800, Lei Yang wrote: > Hi All > > I hit a similar issue when doing a regression testing from my side. > For the error messages please help review the attachment. > > The latest commit: > commit c02197fc9076e7d991c8f6adc11759c5ba52ddc6 (HEAD -> master, >

Re: [PATCH v2] mm: Update mark_victim tracepoints fields

2024-02-22 Thread Michal Hocko
On Wed 21-02-24 13:30:51, Carlos Galo wrote: > On Tue, Feb 20, 2024 at 11:55 PM Michal Hocko wrote: > > > > Hi, > > sorry I have missed this before. > > > > On Thu 11-01-24 21:05:30, Carlos Galo wrote: > > > The current implementation of the mark_victim tracepoint provides only > > > the process

[PATCH] tracing: Use init_utsname()->release

2024-02-22 Thread John Garry
Instead of using UTS_RELEASE, use init_utsname()->release, which means that we don't need to rebuild the code just for the git head commit changing. Signed-off-by: John Garry --- I originally sent an RFC using new string uts_release, but that string is not needed as we can use

Re: [PATCH v4 0/6] LoongArch: Add pv ipi support on LoongArch VM

2024-02-22 Thread WANG Xuerui
On 2/22/24 18:06, maobibo wrote: On 2024/2/22 下午5:34, WANG Xuerui wrote: On 2/17/24 11:15, maobibo wrote: On 2024/2/15 下午6:25, WANG Xuerui wrote: On 2/15/24 18:11, WANG Xuerui wrote: Sorry for the late reply (and Happy Chinese New Year), and thanks for providing microbenchmark numbers! But

Re: [PATCH v4 0/6] LoongArch: Add pv ipi support on LoongArch VM

2024-02-22 Thread maobibo
On 2024/2/22 下午5:34, WANG Xuerui wrote: On 2/17/24 11:15, maobibo wrote: On 2024/2/15 下午6:25, WANG Xuerui wrote: On 2/15/24 18:11, WANG Xuerui wrote: Sorry for the late reply (and Happy Chinese New Year), and thanks for providing microbenchmark numbers! But it seems the more comprehensive

Re: [PATCH v3 0/7] Introduction of a remoteproc tee to load signed firmware

2024-02-22 Thread Naman Jain
On 2/22/2024 2:17 PM, Arnaud POULIQUEN wrote: Hello Naman, On 2/22/24 06:43, Naman Jain wrote: On 2/14/2024 10:51 PM, Arnaud Pouliquen wrote: Updates from the previous version [1]: This version proposes another approach based on an alternate load and boot of the coprocessor. Therefore, the

Re: [PATCH v4 0/6] LoongArch: Add pv ipi support on LoongArch VM

2024-02-22 Thread WANG Xuerui
On 2/17/24 11:15, maobibo wrote: On 2024/2/15 下午6:25, WANG Xuerui wrote: On 2/15/24 18:11, WANG Xuerui wrote: Sorry for the late reply (and Happy Chinese New Year), and thanks for providing microbenchmark numbers! But it seems the more comprehensive CoreMark results were omitted (that's also

Re: [PATCH v3] modules: wait do_free_init correctly

2024-02-22 Thread Changbin Du
On Wed, Feb 21, 2024 at 09:40:48AM -0800, Luis Chamberlain wrote: > + live-patching folks, > > Finally, things are starting to be much clearer. Thanks for the time > for working on this, some more comments below and a question which > I think deserves some attention. > > On Sat, Feb 17, 2024 at

Re: [PATCH v3 0/7] Introduction of a remoteproc tee to load signed firmware

2024-02-22 Thread Arnaud POULIQUEN
Hello Naman, On 2/22/24 06:43, Naman Jain wrote: > On 2/14/2024 10:51 PM, Arnaud Pouliquen wrote: >> Updates from the previous version [1]: >> >> This version proposes another approach based on an alternate load and boot >> of the coprocessor. Therefore, the constraint introduced by

Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-22 Thread Krzysztof Kozlowski
On 21/02/2024 23:45, Pavel Machek wrote: >>> +properties: >>> + compatible: >>> +const: usb-c-connector >>> + >>> + power-role: true >>> + >>> + data-role: true >>> + >>> + try-power-role: true >> >> I don't understand why do you have here properties. Do you see any