Re: [PATCH v2] workqueue: add function in event of workqueue_activate_work

2024-03-07 Thread Kassey Li
On 2024/3/8 10:23, Steven Rostedt wrote: On Fri, 8 Mar 2024 10:18:18 +0800 Kassey Li wrote: The trace event "workqueue_activate_work" only print work struct. However, function is the region of interest in a full sequence of work. Current workqueue_activate_work trace event output:

Re: [RFC][PATCH 0/4] Make bpf_jit and kprobes work with CONFIG_MODULES=n

2024-03-07 Thread Luis Chamberlain
On Thu, Mar 7, 2024 at 6:50 PM Masami Hiramatsu wrote: > > On Wed, 6 Mar 2024 17:58:14 -0800 > Song Liu wrote: > > > Hi Calvin, > > > > It is great to hear from you! :) > > > > On Wed, Mar 6, 2024 at 3:23 PM Calvin Owens wrote: > > > > > > On Wednesday 03/06 at 13:34 -0800, Luis Chamberlain

Re: [RFC][PATCH 0/4] Make bpf_jit and kprobes work with CONFIG_MODULES=n

2024-03-07 Thread Google
On Wed, 6 Mar 2024 17:58:14 -0800 Song Liu wrote: > Hi Calvin, > > It is great to hear from you! :) > > On Wed, Mar 6, 2024 at 3:23 PM Calvin Owens wrote: > > > > On Wednesday 03/06 at 13:34 -0800, Luis Chamberlain wrote: > > > On Wed, Mar 06, 2024 at 12:05:07PM -0800, Calvin Owens wrote: > >

Re: [RFC][PATCH 3/4] kprobes: Allow kprobes with CONFIG_MODULES=n

2024-03-07 Thread Google
On Thu, 7 Mar 2024 09:22:07 +0200 Mike Rapoport wrote: > On Wed, Mar 06, 2024 at 12:05:10PM -0800, Calvin Owens wrote: > > If something like this is merged down the road, it can go in at leisure > > once the module_alloc change is in: it's a one-way dependency. > > > > Signed-off-by: Calvin

Re: [RFC][PATCH 3/4] kprobes: Allow kprobes with CONFIG_MODULES=n

2024-03-07 Thread Google
On Wed, 6 Mar 2024 12:05:10 -0800 Calvin Owens wrote: > If something like this is merged down the road, it can go in at leisure > once the module_alloc change is in: it's a one-way dependency. > > Signed-off-by: Calvin Owens > --- > arch/Kconfig| 2 +- > kernel/kprobes.c

Re: [RFC][PATCH 0/4] Make bpf_jit and kprobes work with CONFIG_MODULES=n

2024-03-07 Thread Google
Hi, On Wed, 6 Mar 2024 13:34:40 -0800 Luis Chamberlain wrote: > On Wed, Mar 06, 2024 at 12:05:07PM -0800, Calvin Owens wrote: > > Hello all, > > > > This patchset makes it possible to use bpftrace with kprobes on kernels > > built without loadable module support. > > This is a step in the

Re: [PATCH v2] workqueue: add function in event of workqueue_activate_work

2024-03-07 Thread Steven Rostedt
On Fri, 8 Mar 2024 10:18:18 +0800 Kassey Li wrote: > The trace event "workqueue_activate_work" only print work struct. > However, function is the region of interest in a full sequence of work. > Current workqueue_activate_work trace event output: > > workqueue_activate_work: work struct

Re: [PATCH] workqueue: add function in event of workqueue_activate_work

2024-03-07 Thread Kassey Li
On 2024/3/8 9:50, Steven Rostedt wrote: On Fri, 8 Mar 2024 09:09:29 +0800 Kassey Li wrote: The trace event "workqueue_activate_work" only print work struct. However, function is the region of interest in a full sequence of work. Current workqueue_activate_work trace event output:

[PATCH v2] workqueue: add function in event of workqueue_activate_work

2024-03-07 Thread Kassey Li
The trace event "workqueue_activate_work" only print work struct. However, function is the region of interest in a full sequence of work. Current workqueue_activate_work trace event output: workqueue_activate_work: work struct ff88b4a0f450 With this change, workqueue_activate_work will

Re: [RFC][PATCH 1/4] module: mm: Make module_alloc() generally available

2024-03-07 Thread Google
Hi Calvin, On Wed, 6 Mar 2024 12:05:08 -0800 Calvin Owens wrote: > Both BPF_JIT and KPROBES depend on CONFIG_MODULES, but only require > module_alloc() itself, which can be easily separated into a standalone > allocator for executable kernel memory. Thanks for your work! As Luis pointed, it

Re: [PATCH] workqueue: add function in event of workqueue_activate_work

2024-03-07 Thread Steven Rostedt
On Fri, 8 Mar 2024 09:09:29 +0800 Kassey Li wrote: > The trace event "workqueue_activate_work" only print work struct. > However, function is the region of interest in a full sequence of work. > Current workqueue_activate_work trace event output: > > workqueue_activate_work: work struct

[PATCH] workqueue: add function in event of workqueue_activate_work

2024-03-07 Thread Kassey Li
The trace event "workqueue_activate_work" only print work struct. However, function is the region of interest in a full sequence of work. Current workqueue_activate_work trace event output: workqueue_activate_work: work struct ff88b4a0f450 With this change, workqueue_activate_work will

Re: [RFC][PATCH 3/4] kprobes: Allow kprobes with CONFIG_MODULES=n

2024-03-07 Thread Christophe Leroy
Le 06/03/2024 à 21:05, Calvin Owens a écrit : > [Vous ne recevez pas souvent de courriers de jcalvinow...@gmail.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > If something like this is merged down the road, it can go in at leisure > once

Re: [RFC][PATCH 2/4] bpf: Allow BPF_JIT with CONFIG_MODULES=n

2024-03-07 Thread Christophe Leroy
Le 06/03/2024 à 21:05, Calvin Owens a écrit : > [Vous ne recevez pas souvent de courriers de jcalvinow...@gmail.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > No BPF code has to change, except in struct_ops (for module refs). > > This

[PATCH] ipvs: allow netlink configuration from non-initial user namespace

2024-03-07 Thread Michael Weiß
Configuring ipvs in a non-initial user namespace using the genl netlink interface, e.g., by 'ipvsadm' is currently resulting in an '-EPERM'. This is due to the use of GENL_ADMIN_PERM flag in 'ip_vs_ctl.c'. Similarly to other genl interfaces, we switch to the use of GENL_UNS_ADMIN_PERM flag which

Re: [RFC PATCH] riscv: Implement HAVE_DYNAMIC_FTRACE_WITH_CALL_OPS

2024-03-07 Thread Puranjay Mohan
Hi Björn, On Thu, Mar 7, 2024 at 8:27 PM Björn Töpel wrote: > > Puranjay! > > Puranjay Mohan writes: > > > This patch enables support for DYNAMIC_FTRACE_WITH_CALL_OPS on RISC-V. > > This allows each ftrace callsite to provide an ftrace_ops to the common > > ftrace trampoline, allowing each

Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver

2024-03-07 Thread Abdellatif El Khlifi
Hi Mathieu, > > + do { > > + state_reg = readl(priv->reset_cfg.state_reg); > > + *rst_ack = EXTSYS_RST_ST_RST_ACK(state_reg); > > + > > + if (*rst_ack == EXTSYS_RST_ACK_RESERVED) { > > + dev_err(dev, "unexpected RST_ACK value: 0x%x\n", > > +

Re: [RFC PATCH] riscv: Implement HAVE_DYNAMIC_FTRACE_WITH_CALL_OPS

2024-03-07 Thread Björn Töpel
Puranjay! Puranjay Mohan writes: > This patch enables support for DYNAMIC_FTRACE_WITH_CALL_OPS on RISC-V. > This allows each ftrace callsite to provide an ftrace_ops to the common > ftrace trampoline, allowing each callsite to invoke distinct tracer > functions without the need to fall back to

Re: [RFC][PATCH 1/4] module: mm: Make module_alloc() generally available

2024-03-07 Thread Christophe Leroy
Hi Calvin, Le 06/03/2024 à 21:05, Calvin Owens a écrit : > [Vous ne recevez pas souvent de courriers de jcalvinow...@gmail.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > Both BPF_JIT and KPROBES depend on CONFIG_MODULES, but only require >

Re: [PATCH net-next v2 0/2] tcp: add two missing addresses when using trace

2024-03-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Mon, 4 Mar 2024 17:29:32 +0800 you wrote: > From: Jason Xing > > When I reviewed other people's patch [1], I noticed that similar things > also happen in tcp_event_skb class and tcp_event_sk_skb class. They >

Re: [RFC PATCH v3 0/7] Add virtio_rtc module and related changes

2024-03-07 Thread David Woodhouse
On Mon, 2023-12-18 at 08:38 +0100, Peter Hilber wrote: > RFC v3 updates > -- > > This series implements a driver for a virtio-rtc device conforming to spec > RFC v3 [1]. It now includes an RTC class driver with alarm, in addition to > the PTP clock driver already present before. > >

Re: [PATCH net-next v2 2/2] tcp: add tracing of skbaddr in tcp_event_skb class

2024-03-07 Thread Eric Dumazet
On Mon, Mar 4, 2024 at 10:29 AM Jason Xing wrote: > > From: Jason Xing > > Use the existing parameter and print the address of skbaddr > as other trace functions do. > > Signed-off-by: Jason Xing Reviewed-by: Eric Dumazet

Re: [PATCH net-next v2 1/2] tcp: add tracing of skb/skaddr in tcp_event_sk_skb class

2024-03-07 Thread Eric Dumazet
On Mon, Mar 4, 2024 at 10:29 AM Jason Xing wrote: > > From: Jason Xing > > Printing the addresses can help us identify the exact skb/sk > for those system in which it's not that easy to run BPF program. > As we can see, it already fetches those, then use it directly > and it will print like

Re: [PATCH -next v6 0/2] Make memory reclamation measurable

2024-03-07 Thread Michal Hocko
On Thu 07-03-24 15:40:29, Bixuan Cui wrote: [...] > Currently, with the help of kernel trace events or tools like Perfetto, we > can only see that kswapd is competing for CPU and the frequency of memory > reclamation triggers, but we do not have detailed information or metrics > about memory

Re: [RFC PATCH v3 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-07 Thread Lee Jones
> > > +static int pm886_initialize_subregmaps(struct pm886_chip *chip) > > > +{ > > > + struct device *dev = >client->dev; > > > + struct i2c_client *page; > > > + struct regmap *regmap; > > > + int err; > > > + > > > + /* regulators page */ > > > + page = devm_i2c_new_dummy_device(dev,

Re: [PATCH v3 2/3] dt-bindings: input: imagis: Document touch keys

2024-03-07 Thread Krzysztof Kozlowski
On 06/03/2024 15:40, Duje Mihanović wrote: > IST3032C (and possibly some other models) has touch keys. Document this. > > Signed-off-by: Duje Mihanović > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof