Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Gavin Shan
On 3/20/24 10:49, Michael S. Tsirkin wrote:> I think you are wasting the time with these tests. Even if it helps what does this tell us? Try setting a flag as I suggested elsewhere. Then check it in vhost. Or here's another idea - possibly easier. Copy the high bits from index into ring itself.

Re: [bug report] tracing/probes: Support $argN in return probe (kprobe and fprobe)

2024-03-19 Thread Google
On Tue, 19 Mar 2024 10:10:00 -0400 Steven Rostedt wrote: > On Tue, 19 Mar 2024 10:19:09 +0300 > Dan Carpenter wrote: > > > Hello Masami Hiramatsu (Google), > > > > Commit 25f00e40ce79 ("tracing/probes: Support $argN in return probe > > (kprobe and fprobe)") from Mar 4, 2024 (linux-next),

Re: [PATCH v6 7/8] selftests/ftrace: add kprobe test cases for VFS type "%pd" and "%pD"

2024-03-19 Thread Google
Hi Ye, Sorry for replying late. On Fri, 15 Mar 2024 14:55:39 +0800 Ye Bin wrote: > This patch adds test cases for new print format type "%pd/%pD".The test cases > test the following items: > 1. Test README if add "%pd/%pD" type; > 2. Test "%pd" type for dput(); > 3. Test "%pD" type for

Re: [PATCH v2 0/3] uprobes: two common case speed ups

2024-03-19 Thread Google
On Tue, 19 Mar 2024 09:19:19 -0700 Andrii Nakryiko wrote: > On Mon, Mar 18, 2024 at 9:21 PM Masami Hiramatsu wrote: > > > > Hi, > > > > On Mon, 18 Mar 2024 11:17:25 -0700 > > Andrii Nakryiko wrote: > > > > > This patch set implements two speed ups for uprobe/uretprobe runtime > > > execution

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Wed, Mar 20, 2024 at 09:56:58AM +1000, Gavin Shan wrote: > On 3/20/24 04:22, Will Deacon wrote: > > On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: > > > On 3/19/24 02:59, Will Deacon wrote: > > > > >drivers/virtio/virtio_ring.c | 12 +--- > > > > >1 file changed, 9

Re: [PATCH 0/8] tracing: Persistent traces across a reboot or crash

2024-03-19 Thread Steven Rostedt
On Sat, 9 Mar 2024 12:40:51 -0800 Kees Cook wrote: > The part I'd like to get wired up sanely is having pstore find the > nvdimm area automatically, but it never quite happened: > https://lore.kernel.org/lkml/CAGXu5jLtmb3qinZnX3rScUJLUFdf+pRDVPjy=cs4kutw9tl...@mail.gmail.com/ The automatic

Re: [PATCH 1/2] compiler_types: Ensure __diag_clang() is always available

2024-03-19 Thread Justin Stitt
Hi, On Tue, Mar 19, 2024 at 09:07:52AM -0700, Nathan Chancellor wrote: > Attempting to use __diag_clang() and build with GCC results in a build > error: > > include/linux/compiler_types.h:468:38: error: 'ignore' undeclared (first > use in this function); did you mean 'inode'? > 468 |

Re: [PATCH 2/2] tracing: Ignore -Wstring-compare with diagnostic macros

2024-03-19 Thread Steven Rostedt
On Tue, 19 Mar 2024 17:30:41 -0700 Justin Stitt wrote: > > diff --git a/include/trace/stages/stage6_event_callback.h > > b/include/trace/stages/stage6_event_callback.h > > index 83da83a0c14f..56a4eea5a48e 100644 > > --- a/include/trace/stages/stage6_event_callback.h > > +++

Re: [PATCH 2/2] tracing: Ignore -Wstring-compare with diagnostic macros

2024-03-19 Thread Justin Stitt
On Tue, Mar 19, 2024 at 9:08 AM Nathan Chancellor wrote: > > Commit b1afefa62ca9 ("tracing: Use strcmp() in __assign_str() WARN_ON() > check") addressed a clang warning, -Wstring-compare, with the use of > __builtin_constant_p() to dispatch to strcmp() if the source string is a > string literal

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Gavin Shan
On 3/20/24 04:22, Will Deacon wrote: On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: On 3/19/24 02:59, Will Deacon wrote: drivers/virtio/virtio_ring.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_ring.c

Re: [PATCH v2] workqueue: add function in event of workqueue_activate_work

2024-03-19 Thread kassey li
on 2024/3/8 10:23, Steven Rostedt wrote: On Fri, 8 Mar 2024 10:18:18 +0800 Kassey Li wrote: The trace event "workqueue_activate_work" only print work struct. However, function is the region of interest in a full sequence of work. Current workqueue_activate_work trace event output:

Re: [GIT PULL] tracing/tools: Updates for 6.9

2024-03-19 Thread Steven Rostedt
On Mon, 18 Mar 2024 18:41:13 +0100 Daniel Bristot de Oliveira wrote: > Steven, > > Tracing tooling updates for 6.9 > > Tracing: > - Update makefiles for latency-collector and RTLA, > using tools/build/ makefiles like perf does, inheriting > its benefits. For

Re: [PATCH 0/2] tracing: Fully silence instance of -Wstring-compare

2024-03-19 Thread Nathan Chancellor
On Tue, Mar 19, 2024 at 06:15:09PM -0400, Steven Rostedt wrote: > On Tue, 19 Mar 2024 09:07:51 -0700 > Nathan Chancellor wrote: > > > Hi all, > > > > This series fully resolves the new instance of -Wstring-compare from > > within the __assign_str() macro. The first patch resolves a build > >

Re: [PATCH 0/2] tracing: Fully silence instance of -Wstring-compare

2024-03-19 Thread Steven Rostedt
On Tue, 19 Mar 2024 09:07:51 -0700 Nathan Chancellor wrote: > Hi all, > > This series fully resolves the new instance of -Wstring-compare from > within the __assign_str() macro. The first patch resolves a build > failure with GCC that would be seen with just the second patch applied. > The

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-19 Thread Mike Christie
On 3/19/24 12:19 PM, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2024 at 03:40:53AM -0400, Michael S. Tsirkin wrote: >> On Tue, Mar 19, 2024 at 12:32:26AM -0700, syzbot wrote: >>> Hello, >>> >>> syzbot found the following issue on: >>> >>> HEAD commit:b3603fcb79b1 Merge tag 'dlm-6.9' of

Re: [GIT PULL] virtio: features, fixes

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 11:03:44AM -0700, Linus Torvalds wrote: > On Tue, 19 Mar 2024 at 00:41, Michael S. Tsirkin wrote: > > > > virtio: features, fixes > > > > Per vq sizes in vdpa. > > Info query for block devices support in vdpa. > > DMA sync callbacks in vduse. > > > > Fixes, cleanups. > >

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-19 Thread Stefan Hajnoczi
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 52998cdd8d3438df9a77c858a827b8932da1bb28 This is the last time virtio_scsi.c was touched. If the test passes then the issue is probably in another subsystem and we can bisect more recent commits. If it fails, then older

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Will Deacon
On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: > On 3/19/24 02:59, Will Deacon wrote: > > On Thu, Mar 14, 2024 at 05:49:23PM +1000, Gavin Shan wrote: > > > The issue is reported by Yihuang Yu who have 'netperf' test on > > > NVidia's grace-grace and grace-hopper machines. The

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Will Deacon
On Tue, Mar 19, 2024 at 03:36:31AM -0400, Michael S. Tsirkin wrote: > On Mon, Mar 18, 2024 at 04:59:24PM +, Will Deacon wrote: > > On Thu, Mar 14, 2024 at 05:49:23PM +1000, Gavin Shan wrote: > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > > > index

Re: [GIT PULL] virtio: features, fixes

2024-03-19 Thread Linus Torvalds
On Tue, 19 Mar 2024 at 00:41, Michael S. Tsirkin wrote: > > virtio: features, fixes > > Per vq sizes in vdpa. > Info query for block devices support in vdpa. > DMA sync callbacks in vduse. > > Fixes, cleanups. Grr. I thought the merge message was a bit too terse, but I let it slide. But only

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 01:19:23PM -0400, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2024 at 03:40:53AM -0400, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2024 at 12:32:26AM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit:

[PATCH] tracing: Just use strcmp() for testing __string() and __assign_str() match

2024-03-19 Thread Steven Rostedt
From: "Steven Rostedt (Google)" As __assign_str() no longer uses its "src" parameter, there's a check to make sure nothing depends on it being different than what was passed to __string(). It originally just compared the pointer passed to __string() with the pointer passed into __assign_str()

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-19 Thread Stefan Hajnoczi
On Tue, Mar 19, 2024 at 03:40:53AM -0400, Michael S. Tsirkin wrote: > On Tue, Mar 19, 2024 at 12:32:26AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:b3603fcb79b1 Merge tag 'dlm-6.9' of git://git.kernel.org/p.. > > git tree: upstream

Re: [GIT PULL] virtio: features, fixes

2024-03-19 Thread pr-tracker-bot
The pull request you sent on Tue, 19 Mar 2024 03:41:43 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d95fcdf4961d27a3d17e5c7728367197adc89b8d Thank you! -- Deet-doot-dot, I am a

Re: [PATCH v2 0/3] uprobes: two common case speed ups

2024-03-19 Thread Andrii Nakryiko
On Mon, Mar 18, 2024 at 9:21 PM Masami Hiramatsu wrote: > > Hi, > > On Mon, 18 Mar 2024 11:17:25 -0700 > Andrii Nakryiko wrote: > > > This patch set implements two speed ups for uprobe/uretprobe runtime > > execution > > path for some common scenarios: BPF-only uprobes (patches #1 and #2) and >

[PATCH 2/2] tracing: Ignore -Wstring-compare with diagnostic macros

2024-03-19 Thread Nathan Chancellor
Commit b1afefa62ca9 ("tracing: Use strcmp() in __assign_str() WARN_ON() check") addressed a clang warning, -Wstring-compare, with the use of __builtin_constant_p() to dispatch to strcmp() if the source string is a string literal and a direct comparison if not. Unfortunately, even with this change,

[PATCH 0/2] tracing: Fully silence instance of -Wstring-compare

2024-03-19 Thread Nathan Chancellor
+ include/trace/stages/stage6_event_callback.h | 5 + 2 files changed, 9 insertions(+) --- base-commit: 7604256cecef34a82333d9f78262d3180f4eb525 change-id: 20240319-tracing-fully-silence-wstring-compare-e71e2fd17b2a Best regards, -- Nathan Chancellor

[PATCH 1/2] compiler_types: Ensure __diag_clang() is always available

2024-03-19 Thread Nathan Chancellor
Attempting to use __diag_clang() and build with GCC results in a build error: include/linux/compiler_types.h:468:38: error: 'ignore' undeclared (first use in this function); did you mean 'inode'? 468 | __diag_ ## compiler(version, ignore, option) |

Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-19 Thread Tanmay Shah
On 3/19/24 12:29 AM, Krzysztof Kozlowski wrote: > On 11/03/2024 18:59, Tanmay Shah wrote: >> From: Radhey Shyam Pandey >> >> Introduce bindings for TCM memory address space on AMD-xilinx Zynq >> UltraScale+ platform. It will help in defining TCM in device-tree >> and make it's access platform

[ANNOUNCE] 5.10.212-rt104

2024-03-19 Thread Luis Claudio R. Goncalves
Hello RT-list! I'm pleased to announce the 5.10.212-rt104 stable release. This release is an update to the new stable 5.10.212 version and no RT changes have been performed. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git

Re: [PATCH 3/3] drivers: remoteproc: add Versal and Versal-NET support

2024-03-19 Thread Tanmay Shah
On 3/19/24 12:25 AM, Krzysztof Kozlowski wrote: > On 19/03/2024 02:06, Tanmay Shah wrote: >> >> >> On 3/17/24 1:55 PM, Krzysztof Kozlowski wrote: >>> On 15/03/2024 22:15, Tanmay Shah wrote: AMD-Xilinx Versal and Versal-NET are successor of ZynqMP platform. ZynqMP remoteproc driver

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-19 Thread Tanmay Shah
On 3/19/24 12:30 AM, Krzysztof Kozlowski wrote: > On 19/03/2024 01:51, Tanmay Shah wrote: >> Hello Krzysztof, >> >> Thanks for reviews. Please find my comments below. >> >> On 3/17/24 1:53 PM, Krzysztof Kozlowski wrote: >>> On 15/03/2024 22:15, Tanmay Shah wrote: AMD-Xilinx Versal-NET

Re: [bug report] tracing/probes: Support $argN in return probe (kprobe and fprobe)

2024-03-19 Thread Dan Carpenter
On Tue, Mar 19, 2024 at 10:10:00AM -0400, Steven Rostedt wrote: > On Tue, 19 Mar 2024 10:19:09 +0300 > Dan Carpenter wrote: > > > Hello Masami Hiramatsu (Google), > > > > Commit 25f00e40ce79 ("tracing/probes: Support $argN in return probe > > (kprobe and fprobe)") from Mar 4, 2024 (linux-next),

Re: [PATCH v2] net/ipv4: add tracepoint for icmp_send

2024-03-19 Thread Steven Rostedt
On Tue, 19 Mar 2024 20:13:52 +0800 (CST) wrote: > From: Peilin He > > Introduce a tracepoint for icmp_send, which can help users to get more > detail information conveniently when icmp abnormal events happen. > > 1. Giving an usecase example: > = > When an

Re: [bug report] tracing/probes: Support $argN in return probe (kprobe and fprobe)

2024-03-19 Thread Steven Rostedt
On Tue, 19 Mar 2024 10:19:09 +0300 Dan Carpenter wrote: > Hello Masami Hiramatsu (Google), > > Commit 25f00e40ce79 ("tracing/probes: Support $argN in return probe > (kprobe and fprobe)") from Mar 4, 2024 (linux-next), leads to the > following Smatch static checker warning: > >

Re: [RFC PATCH v3 0/7] Add virtio_rtc module and related changes

2024-03-19 Thread Peter Hilber
While the virtio-comment list is not available, now also CC'ing Parav, which may be interested in this virtio-rtc spec related discussion thread. On 14.03.24 15:19, David Woodhouse wrote: > On 14 March 2024 11:13:37 CET, Peter Hilber > wrote: >>> To a certain extent, as long as the virtio-rtc

[PATCH v2] net/ipv4: add tracepoint for icmp_send

2024-03-19 Thread xu.xin16
From: Peilin He Introduce a tracepoint for icmp_send, which can help users to get more detail information conveniently when icmp abnormal events happen. 1. Giving an usecase example: = When an application experiences packet loss due to an unreachable UDP destination

Re: [PATCH v7 0/3] vduse: add support for networking devices

2024-03-19 Thread Michael S. Tsirkin
On Thu, Feb 29, 2024 at 11:16:04AM +0100, Maxime Coquelin wrote: > Hello Michael, > > On 2/1/24 09:40, Michael S. Tsirkin wrote: > > On Thu, Feb 01, 2024 at 09:34:11AM +0100, Maxime Coquelin wrote: > > > Hi Jason, > > > > > > It looks like all patches got acked by you. > > > Any blocker to queue

Re: [PATCH] net: hns3: tracing: fix hclgevf trace event strings

2024-03-19 Thread Simon Horman
On Thu, Mar 14, 2024 at 12:00:27PM -0400, Steven Rostedt wrote: > On Thu, 14 Mar 2024 15:39:28 +0100 > Paolo Abeni wrote: > > > On Wed, 2024-03-13 at 09:34 -0400, Steven Rostedt wrote: ... > > > Fixes: d8355240cf8fb ("net: hns3: add trace event support for PF/VF > > > mailbox") > > > >

Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2024-03-19 Thread Tobias Huschle
On 2024-03-19 09:29, Michael S. Tsirkin wrote: On Tue, Mar 19, 2024 at 09:21:06AM +0100, Tobias Huschle wrote: On 2024-03-15 11:31, Michael S. Tsirkin wrote: > On Fri, Mar 15, 2024 at 09:33:49AM +0100, Tobias Huschle wrote: > > On Thu, Mar 14, 2024 at 11:09:25AM -0400, Michael S. Tsirkin wrote:

Re: [PATCH 2/2] virtio_balloon: Treat stats requests as wakeup events

2024-03-19 Thread David Hildenbrand
On 18.03.24 10:10, David Stevens wrote: From: David Stevens Treat stats requests as wakeup events to ensure that the driver responds to device requests in a timely manner. Signed-off-by: David Stevens --- drivers/virtio/virtio_balloon.c | 75 - 1 file

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 06:08:27PM +1000, Gavin Shan wrote: > On 3/19/24 17:09, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2024 at 04:49:50PM +1000, Gavin Shan wrote: > > > > > > On 3/19/24 16:43, Michael S. Tsirkin wrote: > > > > On Tue, Mar 19, 2024 at 04:38:49PM +1000, Gavin Shan wrote: > >

Re: [PATCH 1/2] virtio_balloon: Give the balloon its own wakeup source

2024-03-19 Thread David Hildenbrand
On 18.03.24 10:10, David Stevens wrote: From: David Stevens Wakeup sources don't support nesting multiple events, so sharing a single object between multiple drivers can result in one driver overriding the wakeup event processing period specified by another driver. Have the virtio balloon

Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 09:21:06AM +0100, Tobias Huschle wrote: > On 2024-03-15 11:31, Michael S. Tsirkin wrote: > > On Fri, Mar 15, 2024 at 09:33:49AM +0100, Tobias Huschle wrote: > > > On Thu, Mar 14, 2024 at 11:09:25AM -0400, Michael S. Tsirkin wrote: > > > > > > > > Could you remind me pls,

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 04:54:15PM +1000, Gavin Shan wrote: > On 3/19/24 16:10, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2024 at 02:09:34AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: > > > > On 3/19/24 02:59, Will Deacon wrote: > [...] >

Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2024-03-19 Thread Tobias Huschle
On 2024-03-15 11:31, Michael S. Tsirkin wrote: On Fri, Mar 15, 2024 at 09:33:49AM +0100, Tobias Huschle wrote: On Thu, Mar 14, 2024 at 11:09:25AM -0400, Michael S. Tsirkin wrote: > Could you remind me pls, what is the kworker doing specifically that vhost is relying on? The kworker is

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Gavin Shan
On 3/19/24 17:09, Michael S. Tsirkin wrote: On Tue, Mar 19, 2024 at 04:49:50PM +1000, Gavin Shan wrote: On 3/19/24 16:43, Michael S. Tsirkin wrote: On Tue, Mar 19, 2024 at 04:38:49PM +1000, Gavin Shan wrote: On 3/19/24 16:09, Michael S. Tsirkin wrote: diff --git

[GIT PULL] virtio: features, fixes

2024-03-19 Thread Michael S. Tsirkin
The following changes since commit e8f897f4afef0031fe618a8e94127a0934896aba: Linux 6.8 (2024-03-10 13:38:09 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Gavin Shan
On 3/19/24 17:04, Michael S. Tsirkin wrote: On Tue, Mar 19, 2024 at 04:54:15PM +1000, Gavin Shan wrote: On 3/19/24 16:10, Michael S. Tsirkin wrote: On Tue, Mar 19, 2024 at 02:09:34AM -0400, Michael S. Tsirkin wrote: On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: On 3/19/24

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 12:32:26AM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:b3603fcb79b1 Merge tag 'dlm-6.9' of git://git.kernel.org/p.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=10f04c8118 >

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Mon, Mar 18, 2024 at 04:59:24PM +, Will Deacon wrote: > On Thu, Mar 14, 2024 at 05:49:23PM +1000, Gavin Shan wrote: > > The issue is reported by Yihuang Yu who have 'netperf' test on > > NVidia's grace-grace and grace-hopper machines. The 'netperf' > > client is started in the VM hosted by

[syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-19 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b3603fcb79b1 Merge tag 'dlm-6.9' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10f04c8118 kernel config: https://syzkaller.appspot.com/x/.config?x=fcb5bfbee0a42b54

Re: [PATCH v3] vduse: Fix off by one in vduse_dev_mmap()

2024-03-19 Thread Michael S. Tsirkin
On Wed, Feb 28, 2024 at 09:24:07PM +0300, Dan Carpenter wrote: > The dev->vqs[] array has "dev->vq_num" elements. It's allocated in > vduse_dev_init_vqs(). Thus, this > comparison needs to be >= to avoid > reading one element beyond the end of the array. > > Add an array_index_nospec() as well

[bug report] tracing/probes: Support $argN in return probe (kprobe and fprobe)

2024-03-19 Thread Dan Carpenter
Hello Masami Hiramatsu (Google), Commit 25f00e40ce79 ("tracing/probes: Support $argN in return probe (kprobe and fprobe)") from Mar 4, 2024 (linux-next), leads to the following Smatch static checker warning: kernel/trace/trace_probe.c:856 store_trace_entry_data() error:

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 04:49:50PM +1000, Gavin Shan wrote: > > On 3/19/24 16:43, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2024 at 04:38:49PM +1000, Gavin Shan wrote: > > > On 3/19/24 16:09, Michael S. Tsirkin wrote: > > > > > > > > > > diff --git a/drivers/virtio/virtio_ring.c > > > > > >

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 04:54:15PM +1000, Gavin Shan wrote: > On 3/19/24 16:10, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2024 at 02:09:34AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: > > > > On 3/19/24 02:59, Will Deacon wrote: > [...] >

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Gavin Shan
On 3/19/24 16:10, Michael S. Tsirkin wrote: On Tue, Mar 19, 2024 at 02:09:34AM -0400, Michael S. Tsirkin wrote: On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: On 3/19/24 02:59, Will Deacon wrote: [...] diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Gavin Shan
On 3/19/24 16:43, Michael S. Tsirkin wrote: On Tue, Mar 19, 2024 at 04:38:49PM +1000, Gavin Shan wrote: On 3/19/24 16:09, Michael S. Tsirkin wrote: diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 49299b1f9ec7..7d852811c912 100644 ---

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 04:38:49PM +1000, Gavin Shan wrote: > On 3/19/24 16:09, Michael S. Tsirkin wrote: > > > > > > diff --git a/drivers/virtio/virtio_ring.c > > > > > b/drivers/virtio/virtio_ring.c > > > > > index 49299b1f9ec7..7d852811c912 100644 > > > > > --- a/drivers/virtio/virtio_ring.c

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Gavin Shan
On 3/19/24 16:09, Michael S. Tsirkin wrote: diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 49299b1f9ec7..7d852811c912 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -687,9 +687,15 @@ static inline int virtqueue_add_split(struct

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Thu, Mar 14, 2024 at 05:49:23PM +1000, Gavin Shan wrote: > The issue is reported by Yihuang Yu who have 'netperf' test on > NVidia's grace-grace and grace-hopper machines. The 'netperf' > client is started in the VM hosted by grace-hopper machine, > while the 'netperf' server is running on

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 02:09:34AM -0400, Michael S. Tsirkin wrote: > On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: > > On 3/19/24 02:59, Will Deacon wrote: > > > On Thu, Mar 14, 2024 at 05:49:23PM +1000, Gavin Shan wrote: > > > > The issue is reported by Yihuang Yu who have

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: > On 3/19/24 02:59, Will Deacon wrote: > > On Thu, Mar 14, 2024 at 05:49:23PM +1000, Gavin Shan wrote: > > > The issue is reported by Yihuang Yu who have 'netperf' test on > > > NVidia's grace-grace and grace-hopper machines. The