[PATCH] dgrs.c: kmalloc release on failure

2001-01-11 Thread Arnaldo Carvalho de Melo
addresses. * + * Fixes: + * Arnaldo Carvalho de Melo [EMAIL PROTECTED] - 11/01/2001 + * - fix dgrs_found_device wrt checking kmalloc return and + * rollbacking the partial steps of the whole process when + * one of the devices can't be allocated. Fix SET_MODULE_OWNER

[PATCH] dgrs.c: kmalloc release on failure

2001-01-11 Thread Arnaldo Carvalho de Melo
., 675 Mass Ave, Cambridge, MA 02139, USA. ** +** 1.57b - 1.57c - Arnaldo Carvalho de Melo [EMAIL PROTECTED] +** - release resources on failure in init_module ** ** 1.57 - 1.57b - Jean II ** - fix spinlocks, SMP is now working ! @@ -3024,7 +3026,25 @@ MODULE_PARM(hp100_name, "

[PATCH] lance.c: check kmalloc return and get rid of check_region

2001-01-11 Thread Arnaldo Carvalho de Melo
the 2.1 version of the old driver - Alan Cox + +Get rid of check_region, check kmalloc return in lance_probe1 +Arnaldo Carvalho de Melo [EMAIL PROTECTED] - 11/01/2001 */ static const char *version = "lance.c:v1.15ac 1999/11/13 [EMAIL PROTECTED], [EMAIL PROTECTED]\n"; @@ -352,

Re: Linux driver: __get_free_pages()

2001-01-11 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 11, 2001 at 12:39:33PM -0800, Paul Powell escreveu: Our driver is trying to allocate a DMA buffer to flash an adapter's firmware. This can require as much as 512K ( of contiguous DMA memory ). We are using the function __get_free_pages( GFP_KERNEL | GFP_DMA, order) . The call

Re: Linux driver: __get_free_pages()

2001-01-11 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 11, 2001 at 04:01:08PM -0500, Richard B. Johnson escreveu: If all you need is a kernel buffer to store the stuff that will be written to NVRAM, then just use kmalloc(). It is virtual and will s/kmalloc/vmalloc/ seem contiguous to your driver. - Arnaldo - To unsubscribe from this

Re: -ac10 compile error

2001-01-19 Thread Arnaldo Carvalho de Melo
Em Fri, Jan 19, 2001 at 09:53:06PM -0500, Billy Harvey escreveu: /usr/src/linux/drivers/sound cs46xx.c:4238: banner causes a section type conflict probably one __initdata is a const char? get rid of the const keyword and try again. No patch as I've not yet downloaded -ac10 - Arnaldo - To

Re: PROBLEM: 2.4.1-pre9 does not compile on r128.c

2001-01-20 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 21, 2001 at 02:45:16AM +0100, Pierre CORCINOS escreveu: result of the compilation : read a previous post by Linus, it has a patch for that, IIRC - Arnaldo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please

[ANNOUNCE] Kernel Janitor's TODO list

2001-01-27 Thread Arnaldo Carvalho de Melo
Hi, The kernel Janitor's TODO list is updated at http://bazar.conectiva.com.br/~acme/TODO, lots of things to do to get rid of old cruft, make sure that resources are properly used, etc, please take a look and help! Please send additions and corrections to me and I'll try to keep it

Re: [ANNOUNCE] Kernel Janitor's TODO list

2001-01-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 28, 2001 at 03:20:18PM +, David Woodhouse escreveu: [EMAIL PROTECTED] said: Please send additions and corrections to me and I'll try to keep it updated. Anything which uses sleep_on() has a 90% chance of being broken. Fix them all, because we want to remove sleep_on()

Re: [ANNOUNCE] Kernel Janitor's TODO list

2001-01-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jan 29, 2001 at 03:13:19AM +1100, Andrew Morton escreveu: Arnaldo Carvalho de Melo wrote: Please send additions and corrections to me and I'll try to keep it updated. Here - have about 300 bugs: http://www.uwsg.iu.edu/hypermail/linux/kernel/0005.3/0269.html A lot

Re: [ANNOUNCE] Kernel Janitor's TODO list

2001-01-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 28, 2001 at 12:28:50PM -0200, Arnaldo Carvalho de Melo escreveu: Em Mon, Jan 29, 2001 at 03:13:19AM +1100, Andrew Morton escreveu: Arnaldo Carvalho de Melo wrote: Please send additions and corrections to me and I'll try to keep it updated. Here - have about 300 bugs

Re: [ANNOUNCE] Kernel Janitor's TODO list

2001-01-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 28, 2001 at 05:14:37PM +0100, Manfred Spraul escreveu: Anything which uses sleep_on() has a 90% chance of being broken. Fix them all, because we want to remove sleep_on() and friends in 2.5. Then you can add 'calling schedule() with disabled local interrupts()' to your

Re: linux-2.4.1-pre11

2001-01-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 28, 2001 at 06:55:25PM -0500, Louis Garcia escreveu: I am getting messages everytime I use the network from my RH7 + kernel-2.4.1-pre11 system: modprobe: modprobe: Can't locate module net-pf-10 I have checked my .config and can't find that modules. This does not happen

Re: Linux-2.4.1-pre11

2001-01-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 28, 2001 at 08:10:41PM -0500, Michael H. Warfield escreveu: Damn... So much for typing too fast... Screwed it up... t fast 8) Patch was in /pub/linux/kernel/v2.4/test/patch-2.4.1-pre11.gz Patch was in /pub/linux/kernel/test/patch-2.4.1-pre11.gz

Re: cmpci sound chip lockup

2001-05-18 Thread Arnaldo Carvalho de Melo
x11amp cannot play. * + *Fixes: + *Arnaldo Carvalho de Melo [EMAIL PROTECTED] + *18/05/2001 - .bss nitpicks, fix a bug in set_dac_channels where it + *was calling prog_dmabuf with s-lock held, call missing + *unlock_kernel in cm_midi_release

Re: [PATCH] bulkmem.c - null ptr fixes for 2.4.4

2001-05-24 Thread Arnaldo Carvalho de Melo
Em Thu, May 24, 2001 at 03:26:20PM +0100, Alan Cox escreveu: kernel code. This patch fixes numerous unchecked pointers in the PCMCIA bulkmem driver. Since when has two been numerous - also I dont thin the fix is right - you need to undo what has already been done and anyway, 2.4.4-ac15

Re: Problems with buslogic and osst driver

2001-05-20 Thread Arnaldo Carvalho de Melo
Em Sun, May 20, 2001 at 08:46:44PM +0100, Alan Cox escreveu: So I have 2 questions: 1) Does anyone know if Leonard Zubkoff is still around? Leonard was around at OLS last year and working at VA. Its possible he was laid off but I've heard nothing to suggest that so he's probably just busy

Re: Kernel 2.4.x TODO

2001-05-30 Thread Arnaldo Carvalho de Melo
Em Wed, May 30, 2001 at 01:46:50PM -0700, Dunlap, Randy escreveu: From: Sasi Peter [mailto:[EMAIL PROTECTED]] Check out the kernel janitor project at http://bazar.conectiva.com.br/~acme/TODO (original) Is this information up2date? If it is, sad to see we have this many bugs...

[PATCH] fs/proc/generic.c: check proc_register result

2000-08-29 Thread Arnaldo Carvalho de Melo
Linus, proc_register can fail and its result is not being checked, I've also noticed that at one place (the first hunk in the patch below) it returns a kfreed pointer on failure. - Arnaldo --- linux-2.4.0-test8-pre1/fs/proc/generic.cThu Aug 24 07:40:11 2000

[PATCH] drivers/net/sys900.c: bugfix and cleanups

2000-08-31 Thread Arnaldo Carvalho de Melo
. 1.0 Jan. 18, 1998 http://www.sis.com.tw/support/databook.htm + Arnaldo Carvalho de Melo [EMAIL PROTECTED] - 2000/08/31 + - get rid of check_region (possible race in 2.4) + - release the net_dev returned by init_etherdev after unregister_netdevice on +failure + - no need to allocate

Re: [PATCH] cleanup on selection.c

2000-08-29 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 28, 2000 at 11:40:06PM -0700, David S. Miller escreveu: Date: Mon, 28 Aug 2000 17:36:55 -0700 From: Richard Henderson [EMAIL PROTECTED] On Fri, Aug 25, 2000 at 10:07:03AM -0700, Linus Torvalds wrote: The copy_from_user_ret() define is both BUGGY and UGLY: it's

[PATCH] opl3.c: get rid of check_region + some fixes

2000-09-03 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying. - Arnaldo --- linux-2.4.0-test8-pre2/drivers/sound/adlib_card.c Thu Aug 24 07:40:05 2000 +++ linux-2.4.0-test8-pre2.acme/drivers/sound/adlib_card.c Sun Sep 3 12:48:03 +2000 @@ -20,15 +20,10 @@ static void __init attach_adlib_card(struct

Re: test8-pre2 fs corruption?

2000-09-03 Thread Arnaldo Carvalho de Melo
Em Sun, Sep 03, 2000 at 09:07:10PM -0400, Mohammad A. Haque escreveu: When pine crashed on me while trying to read one of my mailboxes I ended up opening the mailbox in vi. vi complained about Incomplete line and sure enough .. at the end of the file was lots of gibberish. This wasn't my

[PATCH] fix to compile nm256_audio.c

2000-09-03 Thread Arnaldo Carvalho de Melo
Linus, Please apply. - Arnaldo --- linux-2.4.0-test8-pre2/drivers/sound/nm256_audio.c Sat Sep 2 20:50:27 2000 +++ linux-2.4.0-test8-pre2.acme/drivers/sound/nm256_audio.c Sun Sep 3 19:57:13 +2000 @@ -1467,7 +1467,7 @@ break;

Re: [RFC] my current kernel todo list

2000-09-04 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 04, 2000 at 04:52:59PM +0100, David Woodhouse escreveu: [EMAIL PROTECTED] said: - convert drivers to new PCI API Don't bother with drivers/char/applicom.c - I've already done it, just waiting to borrow the hardware again to test it. Ok, up to now I've only did this for

Re: 2.4.x driver audit help

2000-09-05 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 05, 2000 at 08:06:21PM +0200, Jes Sorensen escreveu: "Frank" == Frank Davis [EMAIL PROTECTED] writes: Frank Hello all, Anyone wishing to re-audit the drivers/block and Frank drivers/char for locking issues and submit their patches to me Frank directly, feel free. I think if

Re: [PATCH] sr.c 2.4.0-test8-pre5 breakage

2000-09-06 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 06, 2000 at 02:42:02AM -0700, Joshua Uziel escreveu: Heya acme... seems you fixed the sr.c driver a bit too much and killed an #ifdef MODULE that was needed if you build without Nope, I didn't touched this, Jens? - Arnaldo modules (as I do on some of my SPARCs)... this change

Re: [RFC] my current kernel todo list

2000-09-06 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 06, 2000 at 05:37:50PM +0100, Tigran Aivazian escreveu: On Mon, 4 Sep 2000, Tigran Aivazian wrote: On Fri, 25 Aug 2000, Arnaldo Carvalho de Melo wrote: now the driver init sequence is not serialized anymore, so races are possible since when? In 2.4.0-test8-pre2 mod

Re: [RFC] my current kernel todo list

2000-09-06 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 06, 2000 at 06:28:27PM +0100, Tigran Aivazian escreveu: On Wed, 6 Sep 2000, Arnaldo Carvalho de Melo wrote: Em Wed, Sep 06, 2000 at 05:37:50PM +0100, Tigran Aivazian escreveu: On Mon, 4 Sep 2000, Tigran Aivazian wrote: On Fri, 25 Aug 2000, Arnaldo Carvalho de Melo

Re: [PATCH] sd.c Resource allocation fixes + cleanups

2000-09-07 Thread Arnaldo Carvalho de Melo
the archives and found that Arnaldo Carvalho de Melo submitted a similar patch for test7-pre7 that didn't get in. Please let me know if something is missing from this one, or if Analdo is currently working on this. I'm just waiting for it to get in 8) - Arnaldo - To unsubscribe from this list: send

Re: [PATCH] af_netrom.c: do resource release on failure

2000-09-08 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 08, 2000 at 08:33:45PM +0200, Torben Mathiasen escreveu: On Fri, Sep 08 2000, Arnaldo Carvalho de Melo wrote: Hi, Please take a look and consider applying. Some of it are small cleanups, if they're deemed unnecessary, lemme now and I'm back it off. I think

Re: Update Linux 2.4 Status/TODO list

2000-09-13 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 13, 2000 at 01:56:39AM -0400, [EMAIL PROTECTED] escreveu: 9. To Do * Check all devices use resources properly (Everyone now has to use request_region and check the return since we no longer single thread driver inits in all module cases. Also memory regions

Re: [PATCH] arch/i386/kernel/acpi.c: get rid of check_region and other small fixes/cleanups

2000-09-16 Thread Arnaldo Carvalho de Melo
Em Sat, Sep 16, 2000 at 10:49:08PM -0400, Jeff Garzik escreveu: Applied, but... :) In reviewing your patch, I noticed more ugliness. Can you be convinced to take care of these, too? yap, I'm adding it to my todo list. In acpi_init(), it is possible for the function to error exit without

[PATCH] get rid of check_region in uart401.c

2000-09-26 Thread Arnaldo Carvalho de Melo
6 +47,9 @@ * * 12-08-2000 Added Creative SB32 PnP (CTL009F). * Kasatenko Ivan Alex. [EMAIL PROTECTED] + * + * 21-09-2000 Got rid of attach_sbmpu + * Arnaldo Carvalho de Melo [EMAIL PROTECTED] */ #include linux/config.h @@ -683,10 +686,8 @@ if (!isapnp)

[PATCH] aedsp16.c: get rid of check_region

2000-09-26 Thread Arnaldo Carvalho de Melo
aedsp16_delay_10msec(), now using mdelay(10) - All data and funcs moved to .*.init section. + v1.3 + Arnaldo Carvalho de Melo [EMAIL PROTECTED] - 2000/09/27 + - got rid of check_region Known Problems: - Audio Excel DSP 16 III don't work with this driver. @@ -252,7 +255,7 @@ */ -#define

[PATCH] cmpci.c: get rid of check_region

2000-09-26 Thread Arnaldo Carvalho de Melo
Hi, Please apply. - Arnaldo --- linux-2.4.0-test9-7/drivers/sound/cmpci.c Mon Sep 25 23:31:31 2000 +++ linux-2.4.0-test9-7.acme/drivers/sound/cmpci.c Tue Sep 26 21:54:13 2000 @@ -2370,28 +2370,25 @@ continue; s-irq

[PATCH] esssolo1.c: get rid of check_region

2000-09-26 Thread Arnaldo Carvalho de Melo
Hi, Please apply. - Arnaldo --- linux-2.4.0-test9-7/drivers/sound/esssolo1.cMon Sep 25 23:31:33 2000 +++ linux-2.4.0-test9-7.acme/drivers/sound/esssolo1.c Tue Sep 26 22:01:17 2000 @@ -2085,12 +2085,11 @@ return -ERESTARTSYS;

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-11 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 11, 2000 at 08:35:59PM +0400, [EMAIL PROTECTED] escreveu: Hello! we need to set sk-dead to 1 before calling inet_sock_release in inet6_create? It is a remnant of the past. Delete it here and in af_inet.c, when you will send new patch to David. Alexey Here it is.

[PATCH] af_netrom.c: do resource release on failure

2000-09-08 Thread Arnaldo Carvalho de Melo
Hi, Please take a look and consider applying. Some of it are small cleanups, if they're deemed unnecessary, lemme now and I'm back it off. I think that there are some more unchecked calls that need fixing, but I think its better to keep the patches smaller and incremental, what do you

[PATCH][RFC] check fib6_lookup_1 return in fib6_lookup_1

2000-09-11 Thread Arnaldo Carvalho de Melo
Hi, fib6_lookup_1 can return NULL, please consider applying. - Arnaldo --- linux-2.4.0-test8/net/ipv6/ip6_fib.cWed May 3 05:48:04 2000 +++ linux-2.4.0-test8.acme/net/ipv6/ip6_fib.c Mon Sep 11 18:28:48 2000 @@ -638,6 +638,9 @@

Re: [PATCH][RFC] check fib6_lookup_1 return in fib6_lookup_1

2000-09-11 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 11, 2000 at 05:27:56PM -0700, David S. Miller escreveu: Date: Mon, 11 Sep 2000 18:34:22 -0300 From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] fib6_lookup_1 can return NULL, please consider applying. (Note that CONFIG_IPV6_SUBTREES is never turned on :-) heh

[PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread Arnaldo Carvalho de Melo
Hi, Please take a look and consider applying. One question: why we need to set sk-dead to 1 before calling inet_sock_release in inet6_create? sock_orphan does this for us and is called by inet_sock_release. - Arnaldo --- linux-2.4.0-test8/net/ipv6/af_inet6.c

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread Arnaldo Carvalho de Melo
Em Sun, Sep 10, 2000 at 08:03:54PM -0700, David S. Miller escreveu: I'm not going to apply this patch. The goto's and "switch via if statements" are done for better code generation, and your patch undoes this. Ok, I'll look harder in the future at the code generated. But then it'll be

[PATCH] acpi: release on failure

2000-10-04 Thread Arnaldo Carvalho de Melo
+27,8 @@ * - check copy*user return * - get rid of check_region * - get rid of verify_area + * Arnaldo Carvalho de Melo [EMAIL PROTECTED] - 2000/09/28 + * - do proper release on failure in acpi_claim_ioports and acpi_init */ #include linux/config.h @@ -81,6 +83,7

Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups

2000-08-29 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 29, 2000 at 10:31:22PM +0100, Philipp Rumpf escreveu: On Sun, Aug 27, 2000 at 10:28:14PM +0200, Kenneth Johansson wrote: Arnaldo Carvalho de Melo wrote: #include linux/config.h @@ -510,10 +511,7 @@ if (put_user(len, optlen)) return -EFAULT

[PATCH] cpqarray: several fixes/cleanups

2000-10-17 Thread Arnaldo Carvalho de Melo
to make changes, improve or add functionality to this *driver, you'll probably need the Compaq Array Controller Interface *Specificiation (Document number ECG086/1198) + * + *Changes: + *Arnaldo Carvalho de Melo [EMAIL PROTECTED] - 2000/10/17 + *- s/suser/capable/ + *- check

Re: [PATCH] drivers/char/serial.c unchecked ioremap() calls

2001-02-23 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 23, 2001 at 10:53:59AM +0300, Andrey Panin escreveu: Hi all, 16x50 serial driver doesn't check ioremap() return value. Atached patch should fix this it. humm, have not checked, but it seems as if you don't release the previous successful mappings on failure. Wipe out this

Re: [ANOMALIES]: 2.4.2 - __alloc_pages: failed - Patch failed

2001-02-24 Thread Arnaldo Carvalho de Melo
Em Sat, Feb 24, 2001 at 05:31:55PM -0500, Shawn Starr escreveu: Doing so..., Im not sure hot to use ksymoops or where to get that program. I just usually use the sysq and dump but its ugly ;-) http://www.kernel.org/pub/linux/utils/kernel/ksymoops/v2.4/ksymoops-2.4.0.tar.bz2 - Arnaldo - To

Re: Why CONFIG_MPENTIUMIII by default?

2001-02-24 Thread Arnaldo Carvalho de Melo
Em Sat, Feb 24, 2001 at 08:42:53PM -0300, Frdric L. W. Meunier escreveu: Is there any reason to use CONFIG_MPENTIUMIII by default? I think this should be changed to CONFIG_M386, which should work for most, and would avoid people reporting problems because they forgot to set the right

[PATCH] de4x5.c: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added to the Janitor's TODO list at http://bazar.conectiva.com.br/~acme/TODO and I'm doing a quick audit in the net

[PATCH] defxx.c: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
one more. Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added to the Janitor's TODO

[PATCH] eth16i.c: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
yet another one. 8) Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added

[PATCH] ewrk3.c: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
hey, look at this! 8) Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added

[PATCH] hp100.c: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
hey, its a flood! 8) Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added

PATCH] via-rhine.c: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
humm, almost finishing... 8) Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added

[PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
now to pcmcia ones Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added

[PATCH] fmvj18x_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
another pcmcia one Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added

Re: PATCH] via-rhine.c: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 08:52:39PM -0500, Donald Becker escreveu: On Mon, 26 Feb 2001, Arnaldo Carvalho de Melo wrote: Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: I've just read davem's post at netdev about the brokeness of referencing skbs after

Re: [PATCH] fmvj18x_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 08:57:37PM -0500, Jeff Garzik escreveu: Ditto... thanks, as I said to Donald, I was in fast mode, so the driver maintainers should take this into account and use my previous patches as a hint, I'm considering this for the upcoming patches, if there's any more drivers

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 08:56:06PM -0500, Jeff Garzik escreveu: Arnaldo Carvalho de Melo wrote: --- linux-2.4.2/drivers/net/pcmcia/3c589_cs.c Tue Feb 13 19:15:05 2001 +++ linux-2.4.2.acme/drivers/net/pcmcia/3c589_cs.c Mon Feb 26 22:44:00 2001 @@ -992,9 +992,9

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 09:07:49PM -0500, Jeff Garzik escreveu: And here are the rest of the ones in pcmcia. Hey man, thats what I call cooperation 8) I was now on the netwave one, but had to stop to get another beer, when I came back... Jeff, go get a beer please, I'll pay you by March, 31, if

[PATCH] tms380tr: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying. - Arnaldo --- linux-2.4.2/drivers/net/tokenring/tms380tr.cFri Feb 16 22:02:36 2001 +++ linux-2.4.2.acme/drivers/net/tokenring/tms380tr.c Mon Feb 26 23:11:51 2001 @@ -2203,6 +2203,7 @@ skb_trim(skb,Length);

[PATCH] comx: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying. - Arnaldo --- linux-2.4.2/drivers/net/wan/comx.c Thu Nov 16 20:08:25 2000 +++ linux-2.4.2.acme/drivers/net/wan/comx.c Mon Feb 26 23:17:12 2001 @@ -380,6 +380,7 @@ } if (skb) { netif_rx(skb); + dev-last_rx

[PATCH] comx-proto-lapb: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying. - Arnaldo --- linux-2.4.2/drivers/net/wan/comx-proto-lapb.c Sun Nov 12 01:02:39 2000 +++ linux-2.4.2.acme/drivers/net/wan/comx-proto-lapb.c Mon Feb 26 23:23:15 2001 @@ -306,11 +306,12 @@ p = skb_put(skb,1); *p = 0x01;

[PATCH] cosa: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying. - Arnaldo --- linux-2.4.2/drivers/net/wan/cosa.c Tue Feb 13 19:15:05 2001 +++ linux-2.4.2.acme/drivers/net/wan/cosa.c Mon Feb 26 23:28:40 2001 @@ -738,14 +738,14 @@ chan-stats.rx_frame_errors++; return 0; } -

[PATCH] cycx_x25: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 09:58:31PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, Please apply. This one I maintain. 8) - Arnaldo --- linux-2.4.2/drivers/net/wan/cycx_x25.c Tue Feb 13 19:15:05 2001 +++ linux-2.4.2.acme/drivers/net/wan/cycx_x25.c Mon Feb 26 23:38:48 2001 @@ -812,7

[PATCH] dlci: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying. - Arnaldo --- linux-2.4.2/drivers/net/wan/dlci.c Tue Feb 13 19:15:05 2001 +++ linux-2.4.2.acme/drivers/net/wan/dlci.c Mon Feb 26 23:43:25 2001 @@ -205,7 +205,7 @@ case FRAD_P_IP: header =

[PATCH] hostess_sv11: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying. - Arnaldo --- linux-2.4.2/drivers/net/wan/hostess_sv11.c Sun Aug 13 18:57:35 2000 +++ linux-2.4.2.acme/drivers/net/wan/hostess_sv11.c Mon Feb 26 23:48:32 2001 @@ -59,7 +59,7 @@ { /* Drop the CRC - its not a good idea to try and negotiate it

[PATCH] sbni: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying. - Arnaldo --- linux-2.4.2/drivers/net/wan/sbni.c Tue Feb 13 19:15:05 2001 +++ linux-2.4.2.acme/drivers/net/wan/sbni.c Tue Feb 27 00:19:32 2001 @@ -460,7 +460,7 @@ * generate Ethernet address (0x00ff01xx) */ -

Re: [PATCH] dlci: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 09:56:13PM -0500, Jeff Garzik escreveu: Arnaldo Carvalho de Melo wrote: --- linux-2.4.2/drivers/net/wan/dlci.c Tue Feb 13 19:15:05 2001 +++ linux-2.4.2.acme/drivers/net/wan/dlci.c Mon Feb 26 23:43:25 2001 @@ -229,6 +229,7 @@ skb_pull(skb

[PATCH] sealevel: update last_rx after netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying. - Arnaldo --- linux-2.4.2/drivers/net/wan/sealevel.c Sun Aug 13 18:57:35 2000 +++ linux-2.4.2.acme/drivers/net/wan/sealevel.c Tue Feb 27 01:07:31 2001 @@ -59,7 +59,7 @@ { /* Drop the CRC - its not a good idea to try and negotiate it ;) */

Re: PATCH] via-rhine.c: don't reference skb after passing it to netif_rx

2001-02-27 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 27, 2001 at 10:07:07AM +0100, Urban Widmark escreveu: On Mon, 26 Feb 2001, Arnaldo Carvalho de Melo wrote: thanks, I'll take that into account for the remaining ones and this should be checked by the driver authors for the ones I've already sent. The pkt_len variant

Re: mke2fs hangs while running on /dev/loop0 - kernel version 2.4

2001-02-27 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 27, 2001 at 06:25:08PM -0800, Amit D Chaudhary escreveu: I am hoping someone knows more about this case. I have a intel pc running linux 2.4 and the last command below hangs and the statements as they are printed. Even kill -9 does not get it to terminate. #touch img.test #dd

Re: Can't compile 2.4.2-ac6

2001-02-28 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 28, 2001 at 06:13:18AM -0700, [EMAIL PROTECTED] escreveu: I just pulled down the ac6 patch to 2.4.2 kernel and after applying it without problems I did a make menuconfig with the following result: Menuconfig has encountered a possible error in one of the kernel's configuration

Re: APIC error on CPU0 (UP APIC kernel)

2001-03-01 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 01, 2001 at 09:05:00PM -0500, Chaskiel M Grundman escreveu: 2.4 SMP kernels seem to work fine, but using a 2.4.1 or 2.4.2 UP kernel can you try 2.4.2-ac8 and tell us the results? with CONFIG_X86_UP_IOAPIC does not. At some point before the real root filesystem is mounted, the

Re: PROBLEM: block loop device hangs

2001-03-03 Thread Arnaldo Carvalho de Melo
Em Sat, Mar 03, 2001 at 09:06:30AM -0600, Steven Brooks escreveu: When mounting a file using the loopback device, the mount program hangs for ever. Other than that, the system is still usable. Dist: Redhat-7 Kernel: 2.4.2 (compiled with kgcc, i.e. egcs-2.91.66) FAQ, try 2.4.2-ac10,

Re: Linux 2.4.2ac11

2001-03-03 Thread Arnaldo Carvalho de Melo
Em Sat, Mar 03, 2001 at 10:45:17PM -0300, Rogerio Brito escreveu: On Mar 03 2001, Alan Cox wrote: 2.4.2-ac11 o Resync with Linux 2.4.3pre1 What exactly does these resyncs mean? Do they mean that the entire Linus's tree is merged in the -ac patches (unless explicitly

Re: smp or die ??!?!

2001-03-16 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 16, 2001 at 01:52:01PM +, Delfim Machado escreveu: hi, i'm trying to compile my single cpu without the smp and it gives me a long compile errors ... with the smp enable, i can compile all the kernel without any problems make mrproper ? - Arnaldo - To unsubscribe from

Re: Where to find -pre releases?

2001-03-18 Thread Arnaldo Carvalho de Melo
Em Sun, Mar 18, 2001 at 12:30:45PM -0600, George R. Kasica escreveu: Where in the ftp sites should I find the 2.4.3 -pre kernels? The instructions from freshmeat are not correct and I just can't remember the location... http://www.kernel.org/pub/linux/kernel/testing - To unsubscribe from this

Re: [BUG] kernel BUG at printk.c:458! -- 2.4.2-ac20

2001-03-18 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 19, 2001 at 02:14:35AM +0100, BERECZ Szabolcs escreveu: Hi! I was copying some files from ext2fs to reiserfs, and then this bug occured: kernel BUG at printk.c:458! same thing here, two or three times, I was too lazy to write down the oops and decode it, will try next time,

Re: get_user_ret

2000-11-30 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 30, 2000 at 05:58:19PM +0100, Øyvind Jægtnes escreveu: This get_user_ret thing seems to have changed again... what is the correct syntax now? if (get_user(blah, bleh)) return -EFAULT; *_user*_ret is gone for good. - Arnaldo - To unsubscribe from this list: send the line

[PATCH] drivers/net/sbni.c irq release on failure

2000-12-09 Thread Arnaldo Carvalho de Melo
Alan/Yaroslav, Please consider applying, a similar patch is already in 2.4. - Arnaldo --- linux-2.2.18-pre25/drivers/net/sbni.c Sat Dec 9 15:08:17 2000 +++ linux-2.2.18-pre25.acme/drivers/net/sbni.c Sat Dec 9 17:44:53 2000 @@ -456,6 +456,7 @@ if(dev-priv == NULL)

[PATCH] 2.2: drivers/scsi/3c-xxxx.c resource release on failure

2000-12-09 Thread Arnaldo Carvalho de Melo
[EMAIL PROTECTED] Modifications By: Joel Jacobson [EMAIL PROTECTED] +Arnaldo Carvalho de Melo [EMAIL PROTECTED] + Copyright (C) 1999-2000 3ware Inc. @@ -64,6 +66,8 @@ Bug fix so hot spare drives don't show up. 1.02.00.002 - Fix bug

Re: 8139too problem in 2.2.18

2000-12-16 Thread Arnaldo Carvalho de Melo
Em Sat, Dec 16, 2000 at 06:31:28PM -0500, John Covici escreveu: Hi. I have a RealTech 8139 Ethernet card and I am using kernel 2.2.18. I tried to use the new driver 8139too as a module, but when doing an insmod or modprobe on the module I got "symbol forparameter debug not found". There

[PATCH] 2.2 - wanxl unchecked copy_to_user

2000-12-19 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying, there must well be other things to do on this failure, please check. - Arnaldo --- linux-2.2.19-2/drivers/net/wanxl.c Wed Jun 7 18:26:43 2000 +++ linux-2.2.19-2.acme/drivers/net/wanxl.c Tue Dec 19 20:05:53 2000 @@ -1088,7

[PATCH] 2.2 - cs89x0 - unchecked kmalloc

2000-12-19 Thread Arnaldo Carvalho de Melo
Please consider applying - Arnaldo --- linux-2.2.19-2/drivers/net/cs89x0.c Mon Aug 9 16:05:05 1999 +++ linux-2.2.19-2.acme/drivers/net/cs89x0.cTue Dec 19 20:25:12 2000 @@ -27,6 +27,8 @@ : is running from all accounts.

[PATCH] 2.2 - ultrastor: spurious restore_flags

2000-12-19 Thread Arnaldo Carvalho de Melo
Please consider applying - Arnaldo --- linux-2.2.19-2/drivers/scsi/ultrastor.c Sat Apr 11 15:13:25 1998 +++ linux-2.2.19-2.acme/drivers/scsi/ultrastor.cTue Dec 19 20:45:55 2000 @@ -882,9 +882,8 @@ (inb(SYS_DOORBELL_INTR(config.doorbell_address)) 1))

[PATCH] 2.2: cs89x0, fix more kmallocs unchecked

2000-12-23 Thread Arnaldo Carvalho de Melo
Alan, I talked with Russell in private and this patch fixes some issues with the previous one, included in 2.2.19-pre3, and it also checks for another kmalloc result in init_module. Another question, by what I saw the HAVE_DEVLIST thing is not used anymore (dunno if it

Re: USB web cam

2000-12-28 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 28, 2000 at 05:32:15PM -0500, Wakko Warner escreveu: I really hate to ask on the list, but if I was to buy a usb web cam, what would be a good choice? I would have tried linux-usb, but I didn't know where it was, sorry. one based on the ov511 chipset, like the Creative Web Cam

Re: Camera as a USB mass storage / SCSI device

2000-12-31 Thread Arnaldo Carvalho de Melo
Em Sun, Dec 31, 2000 at 03:25:25PM -0500, Alastair Foster escreveu: USB support appears to be coming along nicely. I have just aquired an Agfa ePhoto digital camera. I have heard several success stories of people who have compiled kernels with SCSI and USB mass storage support and been able

[PATCH] isdn_net: release resources on failure

2001-01-03 Thread Arnaldo Carvalho de Melo
License * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. - * + * + * Changes: + * Arnaldo Carvalho de Melo [EMAIL PROTECTED] + * - release resources on failure in isdn_net_new - 2001/01/03 */ #include linux/config.h

[PATCH] bagetlance using freed skb

2001-01-06 Thread Arnaldo Carvalho de Melo
Alan, Paul Gortmaker found a similar one for lance, so I'm looking at some other drivers to see if this happens, bagetlance has it as well, here is the patch. - Arnaldo --- linux-2.4.0-ac2/drivers/net/bagetlance.cTue Dec 19 11:25:40 2000 +++

[PATCH] atarilance using freed skb

2001-01-06 Thread Arnaldo Carvalho de Melo
Em Sat, Jan 06, 2001 at 09:35:08PM -0200, Arnaldo Carvalho de Melo escreveu: Alan, Paul Gortmaker found a similar one for lance, so I'm looking at some other drivers to see if this happens, bagetlance has it as well, here is the patch. Another one: --- linux-2.4.0-ac2/drivers/net

[PATCH] mptctl.c memory leak on failure

2001-01-06 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying this patch. And I got confused by the kmalloc and the comment: the buffer is used for DMA but the kmalloc doesn't has GFP_DMA, maybe I'm missing something here, its about time for me to sleep 8) but if it doesn't needs DMA you should consider using vmalloc

Re: [PATCH] mptctl.c memory leak on failure

2001-01-07 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 07, 2001 at 01:37:15PM +, Alan Cox escreveu: kmalloc and the comment: the buffer is used for DMA but the kmalloc doesn't has GFP_DMA, maybe I'm missing something here, its about time for me to It should be kmalloc (or 2.4 wise pci_alloc_* I guess eventually). Its driven by

[PATCH] bmac.c: restore_flags on failure

2001-01-08 Thread Arnaldo Carvalho de Melo
entry, switched to * dynamic procfs inode. + * Jan 2001, Arnaldo Carvalho de Melo [EMAIL PROTECTED] + * restore_flags on failure in bmac_reset_and_enable */ #include linux/config.h #include linux/module.h @@ -1227,9 +1229,9 @@ bmac_reset_chip(dev); if (enable

[PATCH] de620.c: nitpicking

2001-01-08 Thread Arnaldo Carvalho de Melo
Bjorn/Alan, Yes, I'm a nitpicker ;) --- linux-2.4.0-ac3/drivers/net/de620.c Tue Dec 19 11:24:52 2000 +++ linux-2.4.0-ac3.acme/drivers/net/de620.cMon Jan 8 20:06:28 2001 @@ -563,7 +563,6 @@ printk(KERN_WARNING "%s: No tx-buffer available!\n", dev-name);

Re: [PATCH] de620.c: nitpicking

2001-01-08 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying, no need to restore_flags here, as it is restored in the beginning of this if block. - Arnaldo --- linux-2.4.0-ac3/drivers/scsi/53c7,8xx.c Fri Oct 13 18:40:51 2000 +++ linux-2.4.0-ac3.acme/drivers/scsi/53c7,8xx.cMon Jan 8 20:24:35 2001 @@

[PATCH] tidy 53c7,8xx.c was Re: [PATCH] de620.c: nitpicking

2001-01-08 Thread Arnaldo Carvalho de Melo
ouch, sorry for the misleading subject, cut and paste sometimes doesn't work ;( Em Mon, Jan 08, 2001 at 08:25:33PM -0200, Arnaldo Carvalho de Melo escreveu: Hi, Please consider applying, no need to restore_flags here, as it is restored in the beginning of this if block. - Arnaldo

[PATCH] advansys.c: include missing restore_flags, etc

2001-01-08 Thread Arnaldo Carvalho de Melo
a DEBUG compile bug fixed in 3.2K. + Arnaldo Carvalho de Melo [EMAIL PROTECTED] fix issues + related to save_flags/restore_flags, some restore_flags and + DvcLeaveCritical were missing, use unsigned long flags instead + of int flags, a not needed cli commented out, like the sti

  1   2   3   4   5   6   7   8   9   10   >