On 08/09/2017 11:02 AM, Eduardo Otubo wrote:
On 08/09/2017 06:11 AM, David Miller wrote:
From: Eduardo Otubo <ot...@redhat.com>
Date: Tue, 8 Aug 2017 15:53:45 +0200
This patch fixes the behavior of the hv_set_ifconfig script when setting
the interface ip. Sometimes the interface has a
On 08/09/2017 06:11 AM, David Miller wrote:
From: Eduardo Otubo <ot...@redhat.com>
Date: Tue, 8 Aug 2017 15:53:45 +0200
This patch fixes the behavior of the hv_set_ifconfig script when setting
the interface ip. Sometimes the interface has already been configured by
network
ble
checks the interface before trying anything.
Signed-off-by: Eduardo Otubo <ot...@redhat.com>
---
tools/hv/hv_set_ifconfig.sh | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/tools/hv/hv_set_ifconfig.sh b/tools/hv/hv_set_ifconfig.sh
in
ruct net_device *xennet_create_dev(struct
> xenbus_device *dev)
> netdev->features |= netdev->hw_features;
>
> netdev->ethtool_ops = _ethtool_ops;
> - netdev->min_mtu = 0;
> + netdev->min_mtu = ETH_MIN_MTU;
> netdev->max_mtu =
, in this case hv_set_ifconfig causes "RTNETLINK: file
exists error"; in order to avoid this error this patch makes sure double
checks the interface before trying anything.
Signed-off-by: Eduardo Otubo <ot...@redhat.com>
---
tools/hv/hv_set_
On Mon, Aug 28, 2017 at 03:56:44PM +, Haiyang Zhang wrote:
>
>
> > -Original Message-
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Monday, August 28, 2017 11:16 AM
> > To: Eduardo Otubo <ot...@redhat.com>
>
On Mon, Aug 28, 2017 at 04:48:32PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Haiyang Zhang
> > Sent: Monday, August 28, 2017 8:57 AM
> > To: Stephen Hemminger <step...@networkplumber.org>; Eduardo Otubo
> > <ot...@r
for the module removal, and this is done by
manipulating both device states.
Signed-off-by: Eduardo Otubo <ot...@redhat.com>
---
drivers/net/xen-netfront.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 8b8689
On Mon, Nov 20, 2017 at 12:17:11PM +0100, Juergen Gross wrote:
> On 20/11/17 11:49, Wei Liu wrote:
> > CC netfront maintainers.
> >
> > On Mon, Nov 20, 2017 at 11:41:09AM +0100, Eduardo Otubo wrote:
> >> When unloading module xen_netfront from guest, dmesg would out
On Mon, Nov 20, 2017 at 10:55:55AM +, Paul Durrant wrote:
> > -Original Message-
> > From: Eduardo Otubo [mailto:ot...@redhat.com]
> > Sent: 20 November 2017 10:41
> > To: xen-de...@lists.xenproject.org
> > Cc: net...@vger.kernel.org; Paul Durrant <paul
states.
Signed-off-by: Eduardo Otubo <ot...@redhat.com>
---
drivers/net/xen-netfront.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 8b8689c6d887..b948e2a1ce40 100644
--- a/drivers/net/xen-netfront.c
+++ b/drive
On Fri, Dec 08, 2017 at 12:33:38PM +0100, Olaf Hering wrote:
> On Fri, Dec 08, Eduardo Otubo wrote:
>
> > tools/hv/hv_set_ifconfig.sh | 45
> > +++--
> > 1 file changed, 43 insertions(+), 2 deletions(-)
>
> > +
ble
checks the interface before trying anything.
Signed-off-by: Eduardo Otubo <ot...@redhat.com>
---
v2: wrap the interface configuration inside a safe wAY to avoid
interaction with network script.
tools/hv/hv_set_ifconfig.sh | 45 +++--
1 file change
-by: Eduardo Otubo <ot...@redhat.com>
---
drivers/net/xen-netfront.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index c5a34671abda..9bd7ddeeb6a5 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1326,6 +
ssumed it was true I started to write code based
on that and all the behaviors that followed were correct according to my
assumptions (and discussions).
But if you find something else weird, please let me know and we can fix it.
>
> On 11/23/2017 04:18 PM, Eduardo Otubo wrote:
> >
On Mon, Aug 28, 2017 at 04:48:32PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Haiyang Zhang
> > Sent: Monday, August 28, 2017 8:57 AM
> > To: Stephen Hemminger ; Eduardo Otubo
> > ; KY Srinivasan
> > Cc: linux-kernel@vge
t
> xenbus_device *dev)
> netdev->features |= netdev->hw_features;
>
> netdev->ethtool_ops = _ethtool_ops;
> - netdev->min_mtu = 0;
> + netdev->min_mtu = ETH_MIN_MTU;
> netdev->max_mtu = XEN_NETIF_MAX_TX_SIZE;
> SET_NETDEV_DEV(netdev, >dev);
>
> --
> 1.8.3.1
>
Acked-by: Eduardo Otubo
--
Eduardo Otubo
Senior Software Engineer @ RedHat
-by: Eduardo Otubo
---
drivers/net/xen-netfront.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index c5a34671abda..9bd7ddeeb6a5 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1326,6 +1326,7 @@ static struct
states.
Signed-off-by: Eduardo Otubo
---
drivers/net/xen-netfront.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 8b8689c6d887..b948e2a1ce40 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
On Mon, Nov 20, 2017 at 10:55:55AM +, Paul Durrant wrote:
> > -Original Message-
> > From: Eduardo Otubo [mailto:ot...@redhat.com]
> > Sent: 20 November 2017 10:41
> > To: xen-de...@lists.xenproject.org
> > Cc: net...@vger.kernel.org; Paul Durran
On Mon, Nov 20, 2017 at 12:17:11PM +0100, Juergen Gross wrote:
> On 20/11/17 11:49, Wei Liu wrote:
> > CC netfront maintainers.
> >
> > On Mon, Nov 20, 2017 at 11:41:09AM +0100, Eduardo Otubo wrote:
> >> When unloading module xen_netfront from guest, dmesg would out
, in this case hv_set_ifconfig causes "RTNETLINK: file
exists error"; in order to avoid this error this patch makes sure double
checks the interface before trying anything.
Signed-off-by: Eduardo Otubo
---
tools/hv/hv_set_ifconfig.sh | 44
1 fi
On Mon, Aug 28, 2017 at 03:56:44PM +, Haiyang Zhang wrote:
>
>
> > -Original Message-
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Monday, August 28, 2017 11:16 AM
> > To: Eduardo Otubo
> > Cc: linux-kernel@vger.kern
ble
checks the interface before trying anything.
Signed-off-by: Eduardo Otubo
---
tools/hv/hv_set_ifconfig.sh | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/tools/hv/hv_set_ifconfig.sh b/tools/hv/hv_set_ifconfig.sh
index 735aafd64a3f..ba5e4aa4e
On 08/09/2017 06:11 AM, David Miller wrote:
From: Eduardo Otubo
Date: Tue, 8 Aug 2017 15:53:45 +0200
This patch fixes the behavior of the hv_set_ifconfig script when setting
the interface ip. Sometimes the interface has already been configured by
network daemon, in this case hv_set_ifconfig
On 08/09/2017 11:02 AM, Eduardo Otubo wrote:
On 08/09/2017 06:11 AM, David Miller wrote:
From: Eduardo Otubo
Date: Tue, 8 Aug 2017 15:53:45 +0200
This patch fixes the behavior of the hv_set_ifconfig script when setting
the interface ip. Sometimes the interface has already been configured
ssumed it was true I started to write code based
on that and all the behaviors that followed were correct according to my
assumptions (and discussions).
But if you find something else weird, please let me know and we can fix it.
>
> On 11/23/2017 04:18 PM, Eduardo Otubo wrote:
> >
for the module removal, and this is done by
manipulating both device states.
Signed-off-by: Eduardo Otubo
---
drivers/net/xen-netfront.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 8b8689c6d887..391432e2725d
ble
checks the interface before trying anything.
Signed-off-by: Eduardo Otubo
---
v2: wrap the interface configuration inside a safe wAY to avoid
interaction with network script.
tools/hv/hv_set_ifconfig.sh | 45 +++--
1 file changed, 43 insertions(+), 2
On Fri, Dec 08, 2017 at 12:33:38PM +0100, Olaf Hering wrote:
> On Fri, Dec 08, Eduardo Otubo wrote:
>
> > tools/hv/hv_set_ifconfig.sh | 45
> > +++--
> > 1 file changed, 43 insertions(+), 2 deletions(-)
>
> > +
30 matches
Mail list logo
