Re: [PATCH V3] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

2015-08-05 Thread gre...@linuxfoundation.org
On Mon, Aug 03, 2015 at 08:26:40AM +, Wang, Biao wrote: > Consider the following case: > Task A trigger lmk with a lock held, while task B try to get this lock, but > unfortunately B is the very culprit task lmk select to kill. Then B will > never be killed, and A will forever select B to

Re: [PATCH V3] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

2015-08-05 Thread gre...@linuxfoundation.org
On Mon, Aug 03, 2015 at 08:26:40AM +, Wang, Biao wrote: Consider the following case: Task A trigger lmk with a lock held, while task B try to get this lock, but unfortunately B is the very culprit task lmk select to kill. Then B will never be killed, and A will forever select B to kill.

Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node.

2015-08-05 Thread gre...@linuxfoundation.org
On Wed, Aug 05, 2015 at 08:22:35PM +, Philip Moltmann wrote: Hi, MODULE_AUTHOR(VMware, Inc.); MODULE_DESCRIPTION(VMware Memory Control (Balloon) Driver); -MODULE_VERSION(1.3.2.0-k); +MODULE_VERSION(1.3.3.0-k); This constant change of module version is annoying, is it

Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node.

2015-08-05 Thread gre...@linuxfoundation.org
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Aug 05, 2015 at 08:42:25PM +, John Savanyo wrote: I agree that version number tracking is not perfect. But it is valuable for us to use as a rough indication that we have attempted to

Re: [PATCH v4 3/9] VMware balloon: add batching to the vmw_balloon.

2015-08-05 Thread gre...@linuxfoundation.org
On Wed, Aug 05, 2015 at 10:47:37PM +, Philip Moltmann wrote: Hi, what changed? I added the include: #include linux/vmalloc.h Nothing else changes. How was I supposed to know this? Please add this type of thing to the patch, in the proper place, as is required. None of v3 step

Re: [PATCH 1/2] serial: 8250: Fix autoconfig_irq() to avoid race conditions

2015-07-23 Thread gre...@linuxfoundation.org
On Fri, Jun 05, 2015 at 09:57:40AM +, Taichi Kageyama wrote: > The following race conditions can happen if a serial is used as console. > Case1. CPU_B handles an interrupt from a serial > autoconfig_irq() fails whether the interrupt is raised or not > if CPU_B is disabled to handle

Re: [PATCH 1/2] serial: 8250: Fix autoconfig_irq() to avoid race conditions

2015-07-23 Thread gre...@linuxfoundation.org
On Fri, Jun 05, 2015 at 09:57:40AM +, Taichi Kageyama wrote: The following race conditions can happen if a serial is used as console. Case1. CPU_B handles an interrupt from a serial autoconfig_irq() fails whether the interrupt is raised or not if CPU_B is disabled to handle

Re: [PATCH 0/2] serial: 8250: Workaround to avoid irq=0 for console

2015-07-07 Thread gre...@linuxfoundation.org
On Tue, Jul 07, 2015 at 08:13:59AM +, Taichi Kageyama wrote: > On 2015/06/05 18:55, Taichi Kageyama wrote: > > This patch set provides a workaround to avoid the following problem. > > It's based on Linux 4.1-rc3 mainstream kernel. > > I've tested this patch set on x86-64 machine and KVM. > > >

Re: [PATCH 0/2] serial: 8250: Workaround to avoid irq=0 for console

2015-07-07 Thread gre...@linuxfoundation.org
On Tue, Jul 07, 2015 at 08:13:59AM +, Taichi Kageyama wrote: On 2015/06/05 18:55, Taichi Kageyama wrote: This patch set provides a workaround to avoid the following problem. It's based on Linux 4.1-rc3 mainstream kernel. I've tested this patch set on x86-64 machine and KVM. Problem

Re: [PATCH 1/3][v2] drivers:usb:fsl: Replace macros with enumerated type

2015-06-26 Thread gre...@linuxfoundation.org
On Fri, Jun 26, 2015 at 05:12:04PM +, Badola Nikhil wrote: > > -Original Message- > > From: Nikhil Badola [mailto:nikhil.bad...@freescale.com] > > Sent: Monday, June 15, 2015 3:47 PM > Could you please provide comments for this patch and the subsequent > patches in this patch set,

Re: [PATCH 1/3][v2] drivers:usb:fsl: Replace macros with enumerated type

2015-06-26 Thread gre...@linuxfoundation.org
On Fri, Jun 26, 2015 at 05:12:04PM +, Badola Nikhil wrote: -Original Message- From: Nikhil Badola [mailto:nikhil.bad...@freescale.com] Sent: Monday, June 15, 2015 3:47 PM snip Could you please provide comments for this patch and the subsequent patches in this patch set, if

Re: [HPDD-discuss] [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

2015-06-22 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Mon, Jun 22, 2015 at 05:27:03PM +, Simmons, James A. wrote: > > Is this change a hard requirement? Currently the lustre code standard in our > development tree is the opposite policy. Please follow the kernel coding style rules. -- To unsubscribe from this list: send the line

Re: [HPDD-discuss] [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

2015-06-22 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Mon, Jun 22, 2015 at 05:27:03PM +, Simmons, James A. wrote: Is this change a hard requirement? Currently the lustre code standard in our development tree is the opposite policy. Please follow the kernel coding style rules. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence

2015-06-19 Thread gre...@linuxfoundation.org
On Fri, Jun 19, 2015 at 06:08:04AM +, Abdul, Hussain (H.) wrote: > On Friday 19 June 2015 04:30 AM, gre...@linuxfoundation.org wrote: > > On Tue, Jun 16, 2015 at 02:03:44PM +, Abdul, Hussain (H.) wrote: > >> From: Abdul Hussain > >> > >> This patch s

Re: [PATCH 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence

2015-06-19 Thread gre...@linuxfoundation.org
On Fri, Jun 19, 2015 at 06:08:04AM +, Abdul, Hussain (H.) wrote: On Friday 19 June 2015 04:30 AM, gre...@linuxfoundation.org wrote: On Tue, Jun 16, 2015 at 02:03:44PM +, Abdul, Hussain (H.) wrote: From: Abdul Hussain hab...@visteon.com This patch simplify a trivial if-return

Re: [PATCH 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence

2015-06-18 Thread gre...@linuxfoundation.org
On Tue, Jun 16, 2015 at 02:03:44PM +, Abdul, Hussain (H.) wrote: > From: Abdul Hussain > > This patch simplify a trivial if-return sequence. Possibly combine with > a preceding function call. > > Signed-off-by: Abdul Hussain Always use scripts/get_maintainer.pl to properly cc the

Re: [PATCH 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence

2015-06-18 Thread gre...@linuxfoundation.org
On Tue, Jun 16, 2015 at 02:03:44PM +, Abdul, Hussain (H.) wrote: From: Abdul Hussain hab...@visteon.com This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Signed-off-by: Abdul Hussain hab...@visteon.com Always use

Re: [PATCH v3 1/6] hv: Modify vmbus to search for all MMIO ranges available

2015-06-17 Thread gre...@linuxfoundation.org
On Wed, Jun 17, 2015 at 05:41:58PM +, Jake Oshins wrote: > > -Original Message- > > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > Sent: Wednesday, June 17, 2015 10:28 AM > > To: Jake Oshins > > Cc: gre...@linuxfoundation.org; KY Srinivasan; lin

Re: [PATCH v3 1/6] hv: Modify vmbus to search for all MMIO ranges available

2015-06-17 Thread gre...@linuxfoundation.org
On Wed, Jun 17, 2015 at 05:41:58PM +, Jake Oshins wrote: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, June 17, 2015 10:28 AM To: Jake Oshins Cc: gre...@linuxfoundation.org; KY Srinivasan; linux- ker...@vger.kernel.org; de

Re: [PATCH] Staging: wilc1000: Remove casting the values returned by kmalloc()

2015-06-16 Thread gre...@linuxfoundation.org
On Tue, Jun 16, 2015 at 07:10:28AM +, Abdul, Hussain (H.) wrote: > From: Abdul Hussain > > This patch removes casting the values returned by memory allocation functions. > > Signed-off-by: Abdul Hussain > --- > drivers/staging/wilc1000/linux_wlan.c | 6 +++--- > 1 file changed, 3

Re: [PATCH] Staging: wilc1000: Remove casting the values returned by kmalloc()

2015-06-16 Thread gre...@linuxfoundation.org
On Tue, Jun 16, 2015 at 07:09:56AM +, Abdul, Hussain (H.) wrote: > From: Abdul Hussain > > This patch removes casting the values returned by memory allocation functions. > > Signed-off-by: Abdul Hussain > --- > drivers/staging/wilc1000/linux_mon.c | 4 ++-- > 1 file changed, 2

Re: [PATCH] Staging: wilc1000: Remove casting the values returned by kmalloc()

2015-06-16 Thread gre...@linuxfoundation.org
On Tue, Jun 16, 2015 at 07:09:56AM +, Abdul, Hussain (H.) wrote: From: Abdul Hussain hab...@visteon.com This patch removes casting the values returned by memory allocation functions. Signed-off-by: Abdul Hussain hab...@visteon.com --- drivers/staging/wilc1000/linux_mon.c | 4 ++-- 1

Re: [PATCH] Staging: wilc1000: Remove casting the values returned by kmalloc()

2015-06-16 Thread gre...@linuxfoundation.org
On Tue, Jun 16, 2015 at 07:10:28AM +, Abdul, Hussain (H.) wrote: From: Abdul Hussain hab...@visteon.com This patch removes casting the values returned by memory allocation functions. Signed-off-by: Abdul Hussain hab...@visteon.com --- drivers/staging/wilc1000/linux_wlan.c | 6 +++---

Re: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

2015-06-12 Thread gre...@linuxfoundation.org
On Fri, Jun 12, 2015 at 03:11:14PM +, Jake Oshins wrote: > This driver is intended to support both full PCI Express device pass through > and also be the basis for SR-IOV networking on top of Hyper-V. These > functions would allow somebody trying to make their NIC driver work on top of >

Re: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag

2015-06-12 Thread gre...@linuxfoundation.org
On Fri, Jun 12, 2015 at 06:47:25AM +, Abdul, Hussain (H.) wrote: > On Thursday 11 June 2015 08:06 PM, gre...@linuxfoundation.org wrote: > > On Thu, Jun 11, 2015 at 10:14:49AM +, Abdul, Hussain (H.) wrote: > >> This patch add IRQF_ONESHOT flag in threaded IR

Re: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

2015-06-12 Thread gre...@linuxfoundation.org
On Fri, Jun 12, 2015 at 03:11:14PM +, Jake Oshins wrote: This driver is intended to support both full PCI Express device pass through and also be the basis for SR-IOV networking on top of Hyper-V. These functions would allow somebody trying to make their NIC driver work on top of

Re: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag

2015-06-12 Thread gre...@linuxfoundation.org
On Fri, Jun 12, 2015 at 06:47:25AM +, Abdul, Hussain (H.) wrote: On Thursday 11 June 2015 08:06 PM, gre...@linuxfoundation.org wrote: On Thu, Jun 11, 2015 at 10:14:49AM +, Abdul, Hussain (H.) wrote: This patch add IRQF_ONESHOT flag in threaded IRQs request without a primary handler

Re: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag

2015-06-11 Thread gre...@linuxfoundation.org
On Thu, Jun 11, 2015 at 10:14:49AM +, Abdul, Hussain (H.) wrote: > This patch add IRQF_ONESHOT flag in threaded IRQs request without a primary > handler. > > Signed-off-by: Abdul Hussain > --- > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag

2015-06-11 Thread gre...@linuxfoundation.org
On Thu, Jun 11, 2015 at 10:14:49AM +, Abdul, Hussain (H.) wrote: This patch add IRQF_ONESHOT flag in threaded IRQs request without a primary handler. Signed-off-by: Abdul Hussain hab...@visteon.com --- drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 +- 1 file changed, 1

Re: A race condition between debugfs and seq_file operation

2015-06-10 Thread gre...@linuxfoundation.org
On Wed, Jun 10, 2015 at 04:00:37PM +0200, Matthias Schiffer wrote: > On 06/10/2015 07:20 AM, gre...@linuxfoundation.org wrote: > > On Wed, Jun 10, 2015 at 05:00:03AM +, Lisa Du wrote: > >>> -Original Message- > >>> From: gre...@linuxfoundation.org [

Re: A race condition between debugfs and seq_file operation

2015-06-10 Thread gre...@linuxfoundation.org
On Wed, Jun 10, 2015 at 04:00:37PM +0200, Matthias Schiffer wrote: On 06/10/2015 07:20 AM, gre...@linuxfoundation.org wrote: On Wed, Jun 10, 2015 at 05:00:03AM +, Lisa Du wrote: -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: 2015年

Re: A race condition between debugfs and seq_file operation

2015-06-09 Thread gre...@linuxfoundation.org
On Wed, Jun 10, 2015 at 05:00:03AM +, Lisa Du wrote: > > -Original Message- > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: 2015年6月10日 5:12 > > To: Lisa Du > > Cc: linux-kernel@vger.kernel.org > > Subject:

Re: A race condition between debugfs and seq_file operation

2015-06-09 Thread gre...@linuxfoundation.org
On Mon, Jun 08, 2015 at 04:28:10AM +, Lisa Du wrote: > Hi, All > Recently I met one race condition related to debugfs. > > Take an example from ion.c in kernel3.14: > static int ion_debug_client_open(struct inode *inode, struct file *file) > { > return single_open(file,

Re: A race condition between debugfs and seq_file operation

2015-06-09 Thread gre...@linuxfoundation.org
On Mon, Jun 08, 2015 at 04:28:10AM +, Lisa Du wrote: Hi, All Recently I met one race condition related to debugfs. Take an example from ion.c in kernel3.14: static int ion_debug_client_open(struct inode *inode, struct file *file) { return single_open(file, ion_debug_client_show,

Re: A race condition between debugfs and seq_file operation

2015-06-09 Thread gre...@linuxfoundation.org
On Wed, Jun 10, 2015 at 05:00:03AM +, Lisa Du wrote: -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: 2015年6月10日 5:12 To: Lisa Du Cc: linux-kernel@vger.kernel.org Subject: Re: A race condition between debugfs and seq_file

Re: [PATCH v3] Staging: rtl8192e: Casting correct Endianness

2015-06-08 Thread gre...@linuxfoundation.org
On Tue, Jun 02, 2015 at 03:59:32PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > From: Gnanachandran Dhanapal > > Casting correct Endianness for __le16 variable used in assignment and > condition check > > Signed-off-by: Gnanachandran Dhanapal > --- > v3: Greg review comments addressed > > ---

Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c

2015-06-08 Thread gre...@linuxfoundation.org
On Mon, Jun 01, 2015 at 04:16:50AM +, Harisangam, Sharvari (S.) wrote: > From: Sharvari Harisangam > > Modified the if-else statements to remove unnecessary comparisons in rxtx.c. > This change was detected with the help of coccinelle tool > > Signed-off-by: Sharvari Harisangam > --- >

Re: [PATCH v3] Staging: rtl8192e: Casting correct Endianness

2015-06-08 Thread gre...@linuxfoundation.org
On Tue, Jun 02, 2015 at 03:59:32PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: From: Gnanachandran Dhanapal gdhan...@visteon.com Casting correct Endianness for __le16 variable used in assignment and condition check Signed-off-by: Gnanachandran Dhanapal gdhan...@visteon.com --- v3: Greg

Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c

2015-06-08 Thread gre...@linuxfoundation.org
On Mon, Jun 01, 2015 at 04:16:50AM +, Harisangam, Sharvari (S.) wrote: From: Sharvari Harisangam shari...@visteon.com Modified the if-else statements to remove unnecessary comparisons in rxtx.c. This change was detected with the help of coccinelle tool Signed-off-by: Sharvari

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

2015-05-31 Thread gre...@linuxfoundation.org
On Sun, May 31, 2015 at 06:13:00AM -0700, Joe Perches wrote: > On Sun, 2015-05-31 at 11:35 +0900, gre...@linuxfoundation.org wrote: > > On Wed, May 20, 2015 at 07:04:27AM +, Dumbre, Nitesh Dilip (N.) wrote: > > > This patch was generated by coccicheck and replace

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

2015-05-31 Thread gre...@linuxfoundation.org
On Sun, May 31, 2015 at 06:13:00AM -0700, Joe Perches wrote: On Sun, 2015-05-31 at 11:35 +0900, gre...@linuxfoundation.org wrote: On Wed, May 20, 2015 at 07:04:27AM +, Dumbre, Nitesh Dilip (N.) wrote: This patch was generated by coccicheck and replaces kzalloc followed by memcpy

Re: [PATCH 1/3] Drivers: hv: vmbus: Use the vp_index map even for channels bound to CPU 0

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 29, 2015 at 05:41:34PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Friday, May 29, 2015 10:00 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org;

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

2015-05-30 Thread gre...@linuxfoundation.org
On Wed, May 20, 2015 at 07:04:27AM +, Dumbre, Nitesh Dilip (N.) wrote: > This patch was generated by coccicheck and replaces kzalloc followed > by memcpy with kmemdup > > Signed-off-by: Nitesh Dumbre Name doesn't match the From: line, please fix your broken email client. WHat is up with

Re: [PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread gre...@linuxfoundation.org
On Sat, May 30, 2015 at 10:22:17AM +, Dighe, Niranjan (N.) wrote: > Replace kzalloc followed by memcpy by kmemdup. This patch was generated > by 'make coccicheck' > > Signed-off-by: Niranjan Dighe Your name here doesn't match the name in the From: line of your email. Please fix up your

Re: FW: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 29, 2015 at 03:54:27PM +, Harisangam, Sharvari (S.) wrote: > Modified the if-else statements to remove unnecessary comparisons in rxtx.c. > This change was detected with the help of coccinelle tool > > Signed-off-by: Harisangam Sharvari > --- > drivers/staging/vt6655/rxtx.c |

Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 19, 2015 at 04:55:57PM +, Dhere, Chaitanya (C.) wrote: > In this patch: > 1. the if condition is modified to remove > the unnecessary equality check. > 2. The else if condition is replaced by an else condition > since the variable checked in the if statement is a bool > making the

Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable

2015-05-30 Thread gre...@linuxfoundation.org
On Thu, May 28, 2015 at 06:10:26AM +, Harisangam, Sharvari (S.) wrote: > Modified the if-else statements to remove unnecessary comparisons. > This change was detected with the help of coccinelle tool > > Signed-off-by: Harisangam Sharvari Name doesn't match... -- To unsubscribe from this

Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

2015-05-30 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 10:12:42PM +0530, Sudip Mukherjee wrote: > On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote: > > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote: > > > On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) > > > wrote: > > > >

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

2015-05-30 Thread gre...@linuxfoundation.org
On Wed, May 20, 2015 at 07:04:27AM +, Dumbre, Nitesh Dilip (N.) wrote: This patch was generated by coccicheck and replaces kzalloc followed by memcpy with kmemdup Signed-off-by: Nitesh Dumbre ndum...@visteon.com Name doesn't match the From: line, please fix your broken email client.

Re: [PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread gre...@linuxfoundation.org
On Sat, May 30, 2015 at 10:22:17AM +, Dighe, Niranjan (N.) wrote: Replace kzalloc followed by memcpy by kmemdup. This patch was generated by 'make coccicheck' Signed-off-by: Niranjan Dighe ndi...@visteon.com Your name here doesn't match the name in the From: line of your email. Please

Re: [PATCH 1/3] Drivers: hv: vmbus: Use the vp_index map even for channels bound to CPU 0

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 29, 2015 at 05:41:34PM +, KY Srinivasan wrote: -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Friday, May 29, 2015 10:00 AM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; de

Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

2015-05-30 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 10:12:42PM +0530, Sudip Mukherjee wrote: On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote: On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote: On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: setup_timer is used

Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable

2015-05-30 Thread gre...@linuxfoundation.org
On Thu, May 28, 2015 at 06:10:26AM +, Harisangam, Sharvari (S.) wrote: Modified the if-else statements to remove unnecessary comparisons. This change was detected with the help of coccinelle tool Signed-off-by: Harisangam Sharvari shari...@visteon.com Name doesn't match... -- To

Re: FW: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 29, 2015 at 03:54:27PM +, Harisangam, Sharvari (S.) wrote: Modified the if-else statements to remove unnecessary comparisons in rxtx.c. This change was detected with the help of coccinelle tool Signed-off-by: Harisangam Sharvari shari...@visteon.com ---

Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 19, 2015 at 04:55:57PM +, Dhere, Chaitanya (C.) wrote: In this patch: 1. the if condition is modified to remove the unnecessary equality check. 2. The else if condition is replaced by an else condition since the variable checked in the if statement is a bool making the else

Re: [RFD] linux-firmware key arrangement for firmware signing

2015-05-21 Thread gre...@linuxfoundation.org
On Thu, May 21, 2015 at 04:03:02PM +, Woodhouse, David wrote: > On Thu, 2015-05-21 at 08:45 -0700, Greg Kroah-Hartman wrote: > > On Thu, May 21, 2015 at 09:05:21AM -0400, Mimi Zohar wrote: > > > Signatures don't provide any guarantees as to code quality or > > > correctness. They do provide

Re: [RFD] linux-firmware key arrangement for firmware signing

2015-05-21 Thread gre...@linuxfoundation.org
On Thu, May 21, 2015 at 04:03:02PM +, Woodhouse, David wrote: On Thu, 2015-05-21 at 08:45 -0700, Greg Kroah-Hartman wrote: On Thu, May 21, 2015 at 09:05:21AM -0400, Mimi Zohar wrote: Signatures don't provide any guarantees as to code quality or correctness. They do provide file

Re: [PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary equality checks. This change was detected with the help of coccinelle tool.

2015-05-18 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 04:00:00PM +, Dhere, Chaitanya (C.) wrote: > Signed-off-by: Chaitanya Dhere Your subject line is too long :( Put some information in the change log area here please, above the signed-off-by line. > Reply-To: Why is this here? Please fix up and resend. thanks,

Re: [PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary equality checks. This change was detected with the help of coccinelle tool.

2015-05-18 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 04:00:00PM +, Dhere, Chaitanya (C.) wrote: Signed-off-by: Chaitanya Dhere cvija...@visteon.com Your subject line is too long :( Put some information in the change log area here please, above the signed-off-by line. Reply-To: Why is this here? Please fix up and

Re: [PATCH v3] w1: introduce an ability to specify microseconds bus scanning intervals

2015-05-13 Thread gre...@linuxfoundation.org
On Wed, May 13, 2015 at 06:00:55PM +0300, Evgeniy Polyakov wrote: > Hi > > 12.05.2015, 22:30, "Dmitry Khromov" : > > Some of 1-Wire devices commonly associated with physical access control > > systems are attached/generate presence for as short as 100 ms - hence > > the tens-to-hundreds

Re: [PATCH v3] w1: introduce an ability to specify microseconds bus scanning intervals

2015-05-13 Thread gre...@linuxfoundation.org
On Wed, May 13, 2015 at 06:00:55PM +0300, Evgeniy Polyakov wrote: Hi 12.05.2015, 22:30, Dmitry Khromov d...@icelogic.net: Some of 1-Wire devices commonly associated with physical access control systems are attached/generate presence for as short as 100 ms - hence the tens-to-hundreds

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread gre...@linuxfoundation.org
On Fri, May 01, 2015 at 10:28:00AM +0100, Alan Cox wrote: > On Fri, 2015-05-01 at 09:41 +0200, gre...@linuxfoundation.org wrote: > > On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote: > > > On Thu, 30 Apr 2015 16:14:06 +0200 > > > "gr

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread gre...@linuxfoundation.org
On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote: > On Thu, 30 Apr 2015 16:14:06 +0200 > "gre...@linuxfoundation.org" wrote: > > > On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote: > > > On Thu, 2015-04-23 at 13:43 +, Gujulan Ela

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread gre...@linuxfoundation.org
On Fri, May 01, 2015 at 10:28:00AM +0100, Alan Cox wrote: On Fri, 2015-05-01 at 09:41 +0200, gre...@linuxfoundation.org wrote: On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote: On Thu, 30 Apr 2015 16:14:06 +0200 gre...@linuxfoundation.org gre...@linuxfoundation.org

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread gre...@linuxfoundation.org
On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote: On Thu, 30 Apr 2015 16:14:06 +0200 gre...@linuxfoundation.org gre...@linuxfoundation.org wrote: On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote: On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H

Re: [PATCH v4] usb: gadget: composite: enable BESL support

2015-04-30 Thread gre...@linuxfoundation.org
On Thu, Apr 30, 2015 at 05:32:57AM +, Du, Changbin wrote: > >From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 > From: Felipe Balbi > Date: Tue, 30 Sep 2014 16:08:03 -0500 > Subject: [PATCH] usb: gadget: composite: enable BESL support > > commit

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-04-30 Thread gre...@linuxfoundation.org
On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote: > On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.) > wrote: > > This patch removes unwanted semicolon around close braces of code blocks > > > The i2o driver moved into staging ready to be deleted unless someone >

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-04-30 Thread gre...@linuxfoundation.org
On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote: On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.) wrote: This patch removes unwanted semicolon around close braces of code blocks The i2o driver moved into staging ready to be deleted unless someone steps up

Re: [PATCH v4] usb: gadget: composite: enable BESL support

2015-04-30 Thread gre...@linuxfoundation.org
On Thu, Apr 30, 2015 at 05:32:57AM +, Du, Changbin wrote: From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 From: Felipe Balbi ba...@ti.com Date: Tue, 30 Sep 2014 16:08:03 -0500 Subject: [PATCH] usb: gadget: composite: enable BESL support commit

Re: [PATCH] Staging: rtl8712: Removed unused variable

2015-04-23 Thread gre...@linuxfoundation.org
On Thu, Apr 23, 2015 at 02:12:44PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > This patch removes unused variable in this file. > > Signed-off-by: Gnanachandran Dhanapal > > Change-Id: I59cc869773d145239d62c3185018b275239fe812 The only thing I can do with a patch that has this line in it is

Re: [PATCH] Staging: rtl8712: Removed unused variable

2015-04-23 Thread gre...@linuxfoundation.org
On Thu, Apr 23, 2015 at 02:12:44PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: This patch removes unused variable in this file. Signed-off-by: Gnanachandran Dhanapal gdhan...@visteon.com Change-Id: I59cc869773d145239d62c3185018b275239fe812 The only thing I can do with a patch that has this

Re: [PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup

2015-04-03 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 03:11:25PM +, Dhere, Chaitanya (C.) wrote: > This change was detected with the help of coccinelle tool. > It performs the same function as kzalloc amd memcpy. > > Signed-off-by: Chaitanya Dhere Your From: line and this line don't match :( > --- >

Re: [PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup

2015-04-03 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 03:11:25PM +, Dhere, Chaitanya (C.) wrote: This change was detected with the help of coccinelle tool. It performs the same function as kzalloc amd memcpy. Signed-off-by: Chaitanya Dhere cvija...@visteon.com Your From: line and this line don't match :( ---

Re: [PATCH] staging: lustre: replace kzalloc with copy_from_user with memdup_user

2015-03-31 Thread gre...@linuxfoundation.org
On Tue, Mar 31, 2015 at 05:15:23PM +0200, Julia Lawall wrote: > On Tue, 31 Mar 2015, Dhere, Chaitanya (C.) wrote: > > > This patch replaces kzalloc and copy_from_user with memdup_user call > > This change was detected with coccinelle tool > > > > Signed-off-by: Chaitanya Dhere > > --- > >

Re: [PATCH] staging: lustre: replace kzalloc with copy_from_user with memdup_user

2015-03-31 Thread gre...@linuxfoundation.org
On Tue, Mar 31, 2015 at 05:15:23PM +0200, Julia Lawall wrote: On Tue, 31 Mar 2015, Dhere, Chaitanya (C.) wrote: This patch replaces kzalloc and copy_from_user with memdup_user call This change was detected with coccinelle tool Signed-off-by: Chaitanya Dhere cvija...@visteon.com ---

Re: Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 02:02:27PM +, EunTaik Lee wrote: > > The problem was on 3.10.49. > > I carefully looked up the patches again and found out that there was > a patch on 3.18 that will solve the problem > > commite4a60d139060975eb956717e4f63ae348d4d8cc5 > sysfs: driver core:

Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 11:54:54AM +, EunTaik Lee wrote: > > > > >The bus that the device is on should prevent this, why isn't that > >working for you? What type of device/bus do you see this problem on? > > The device is a firmware class device on a virtual bus. What kernel code is

Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 09:06:43AM +, EunTaik Lee wrote: > There is a possible race condition when a device > is added while another device with the same parent > , with ref count of one, is deleted. > > CPU0CPU1 > device_add() device_del() > get_device_parent()

Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 09:06:43AM +, EunTaik Lee wrote: There is a possible race condition when a device is added while another device with the same parent , with ref count of one, is deleted. CPU0CPU1 device_add() device_del() get_device_parent() put_device(parent);

Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 11:54:54AM +, EunTaik Lee wrote: The bus that the device is on should prevent this, why isn't that working for you? What type of device/bus do you see this problem on? The device is a firmware class device on a virtual bus. What kernel code is causing this?

Re: Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 02:02:27PM +, EunTaik Lee wrote: The problem was on 3.10.49. I carefully looked up the patches again and found out that there was a patch on 3.18 that will solve the problem commite4a60d139060975eb956717e4f63ae348d4d8cc5 sysfs: driver core: Fix glue

Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit

2015-03-18 Thread gre...@linuxfoundation.org
On Wed, Mar 18, 2015 at 07:53:35PM +, Dilger, Andreas wrote: > On 2015/03/18, 1:07 PM, "Maxime Lorrillere" > wrote: > > >From: Laure Millet > > > >This patch fixes lines over 80 characters > > I think the newer rule is that strings shouldn't be split across lines. > That makes > the first

Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit

2015-03-18 Thread gre...@linuxfoundation.org
On Wed, Mar 18, 2015 at 07:53:35PM +, Dilger, Andreas wrote: On 2015/03/18, 1:07 PM, Maxime Lorrillere maxime.lorrill...@lip6.fr wrote: From: Laure Millet laure.mil...@lip6.fr This patch fixes lines over 80 characters I think the newer rule is that strings shouldn't be split across

Re: Possible no longer required cast in the function,usbhs_parse_dt in common.c

2015-03-17 Thread gre...@linuxfoundation.org
On Tue, Mar 17, 2015 at 03:37:42AM +, Peter Chen wrote: > > > > > Greetings All, > > I have been getting the below build warnings: > > drivers/usb/renesas_usbhs/common.c: In function ‘usbhs_parse_dt’: > > drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to > > integer

Re: Possible no longer required cast in the function,usbhs_parse_dt in common.c

2015-03-17 Thread gre...@linuxfoundation.org
On Tue, Mar 17, 2015 at 03:37:42AM +, Peter Chen wrote: Greetings All, I have been getting the below build warnings: drivers/usb/renesas_usbhs/common.c: In function ‘usbhs_parse_dt’: drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to integer of different

Re: LZ4 : fix the data abort issue.

2015-03-13 Thread gre...@linuxfoundation.org
On Thu, Mar 12, 2015 at 08:28:55AM +, Yeon, JeHyeon (Tom) wrote: > If the part of the compression data are corrupted, or the compression > data is totally fake, the memory access over the limit is possible. > > This is the log from my system usning lz4 decompression. >[6502]data abort,

Re: LZ4 : fix the data abort issue.

2015-03-13 Thread gre...@linuxfoundation.org
On Thu, Mar 12, 2015 at 08:28:55AM +, Yeon, JeHyeon (Tom) wrote: If the part of the compression data are corrupted, or the compression data is totally fake, the memory access over the limit is possible. This is the log from my system usning lz4 decompression. [6502]data abort, halting

Re: [PATCH 0/6] Drivers: hv: Miscellaneous fixes

2015-03-10 Thread gre...@linuxfoundation.org
On Tue, Mar 10, 2015 at 02:54:16PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, March 10, 2015 12:41 AM > > To: KY Srinivasan > >

Re: [PATCH 0/6] Drivers: hv: Miscellaneous fixes

2015-03-10 Thread gre...@linuxfoundation.org
On Tue, Mar 10, 2015 at 03:31:44AM +, KY Srinivasan wrote: > > > > -Original Message- > > From: KY Srinivasan > > Sent: Friday, March 6, 2015 9:20 PM > > To: KY Srinivasan; gre...@linuxfoundation.org; linux- > > ker...@vger.kernel.org; de...@li

Re: [PATCH 0/6] Drivers: hv: Miscellaneous fixes

2015-03-10 Thread gre...@linuxfoundation.org
On Tue, Mar 10, 2015 at 02:54:16PM +, KY Srinivasan wrote: -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Tuesday, March 10, 2015 12:41 AM To: KY Srinivasan Cc: linux-kernel@vger.kernel.org; de...@linuxdriverproject.org; o

Re: [PATCH 0/6] Drivers: hv: Miscellaneous fixes

2015-03-10 Thread gre...@linuxfoundation.org
On Tue, Mar 10, 2015 at 03:31:44AM +, KY Srinivasan wrote: -Original Message- From: KY Srinivasan Sent: Friday, March 6, 2015 9:20 PM To: KY Srinivasan; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de

Re: [alsa-devel] [PATCH v2 0/3] Switch to ioremap_wc in the SRAM allocator code

2015-03-01 Thread gre...@linuxfoundation.org
On Sun, Mar 01, 2015 at 10:00:37PM +0530, Abhilash Kesavan wrote: > Hi Greg, > > On Fri, Feb 6, 2015 at 9:14 PM, Catalin Marinas > wrote: > > On Fri, Feb 06, 2015 at 01:45:25PM +, Abhilash Kesavan wrote: > >> Fix alignment faults seen during play-back of files with specific > >> sampling

Re: [alsa-devel] [PATCH v2 0/3] Switch to ioremap_wc in the SRAM allocator code

2015-03-01 Thread gre...@linuxfoundation.org
On Sun, Mar 01, 2015 at 10:00:37PM +0530, Abhilash Kesavan wrote: Hi Greg, On Fri, Feb 6, 2015 at 9:14 PM, Catalin Marinas catalin.mari...@arm.com wrote: On Fri, Feb 06, 2015 at 01:45:25PM +, Abhilash Kesavan wrote: Fix alignment faults seen during play-back of files with specific

Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread gre...@linuxfoundation.org
On Tue, Feb 10, 2015 at 12:34:07AM +, Drokin, Oleg wrote: On Feb 9, 2015, at 4:34 PM, gre...@linuxfoundation.org wrote: There's a third coding style error in this file which I've chosen to not fix for clarity's sake. It is: initializing min_watchdog_ratelimit (static int) to 0

Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread gre...@linuxfoundation.org
On Mon, Feb 09, 2015 at 07:20:30PM +0200, Tal Shorer wrote: Fix the following coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c: 1. initializing lnet_table_header (static pointer) to NULL 2. missing spaces around '=' Those are two different things, and should be 2

Re: [RFC] ion:change ion_cma_allocate return error value

2015-01-28 Thread 'gre...@linuxfoundation.org'
On Tue, Jan 27, 2015 at 02:04:21PM +0800, Wang, Yalin wrote: > This patch change the error return value from -1 to -ENOMEM, > so that userspace can get the correct errno, otherwise, > -1 will be -EPERM, userspace will print permission deny for allocation > failure. > > Signed-off-by: Yalin Wang

Re: [RFC] ion:change ion_cma_allocate return error value

2015-01-28 Thread 'gre...@linuxfoundation.org'
On Tue, Jan 27, 2015 at 02:04:21PM +0800, Wang, Yalin wrote: This patch change the error return value from -1 to -ENOMEM, so that userspace can get the correct errno, otherwise, -1 will be -EPERM, userspace will print permission deny for allocation failure. Signed-off-by: Yalin Wang

Re: New maintainer for dwc2

2015-01-12 Thread gre...@linuxfoundation.org
On Mon, Jan 12, 2015 at 11:14:54PM +, Paul Zimmerman wrote: > Hi everyone, > > I will be leaving Synopsys on Friday, Jan 16th, so the dwc2 driver > will need a new maintainer. > > I am recommending John Youn as the new > maintainer. > > On the plus side, John has quite a bit of experience

Re: [PATCH 1/2] lib: devres: add a helper function for ioremap_wc

2015-01-12 Thread gre...@linuxfoundation.org
On Sat, Jan 10, 2015 at 09:00:54AM +0530, Abhilash Kesavan wrote: > Hi Greg, > > On Thu, Dec 11, 2014 at 8:28 AM, Abhilash Kesavan > wrote: > > Implement a resource managed writecombine ioremap function. > > > > Signed-off-by: Abhilash Kesavan > > --- > > Documentation/driver-model/devres.txt

Re: [PATCH 1/2] lib: devres: add a helper function for ioremap_wc

2015-01-12 Thread gre...@linuxfoundation.org
On Sat, Jan 10, 2015 at 09:00:54AM +0530, Abhilash Kesavan wrote: Hi Greg, On Thu, Dec 11, 2014 at 8:28 AM, Abhilash Kesavan a.kesa...@samsung.com wrote: Implement a resource managed writecombine ioremap function. Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com ---

<    1   2   3   4   5   6   7   8   >