[PATCH 8/9] staging: octeon: support enabling multiple rx groups

2016-08-30 Thread Aaro Koskinen
Support enabling multiple RX groups. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/staging/octeon/ethernet-rx.c | 126 ++- drivers/staging/octeon/ethernet.c| 6 +- drivers/staging/octeon/octeon-ethernet.h | 2 +- 3 files chang

[PATCH 6/9] staging: octeon: move irq into rx group specific data

2016-08-30 Thread Aaro Koskinen
Move IRQ number into RX group specific data. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/staging/octeon/ethernet-rx.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/et

[PATCH 7/9] staging: octeon: move group number into rx group data

2016-08-30 Thread Aaro Koskinen
Move group number into RX group data. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/staging/octeon/ethernet-rx.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/et

[PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-30 Thread Aaro Koskinen
forwarding test using two flows and 16 RX groups distributed between two cores - the routing throughput is roughly doubled. A. Aaro Koskinen (9): staging: octeon: disable rx interrupts in oct_rx_shutdown staging: octeon: use passed interrupt number in the handler staging: octeon: pass the NAPI

[PATCH 3/9] staging: octeon: pass the NAPI instance reference to irq handler

2016-08-30 Thread Aaro Koskinen
Pass the NAPI instance reference to the interrupt handler. This is preparation for having multiple NAPI instances. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/staging/octeon/ethernet-rx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/d

[PATCH 4/9] staging: octeon: move common poll code into a separate function

2016-08-30 Thread Aaro Koskinen
Move common poll code into a separate function. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/staging/octeon/ethernet-rx.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/s

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Aaro Koskinen
Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: > On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen <aaro.koski...@iki.fi> wrote: > > This series implements multiple RX group support that should improve > > the networking performance on multi-core OCTEONs.

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Aaro Koskinen
Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: > On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen <aaro.koski...@iki.fi> wrote: > > This series implements multiple RX group support that should improve > > the networking performance on multi-core OCTEONs.

Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON

2016-09-11 Thread Aaro Koskinen
Hi, On Sun, Sep 11, 2016 at 02:41:39PM +0200, Thorsten Leemhuis wrote: > Hi! On 25.08.2016 20:24, Aaro Koskinen wrote: > > On Wed, Aug 24, 2016 at 11:42:00AM -0500, Steven J. Hill wrote: > >> It is actually two patches that cause the breakage. The other

Re: [PATCH] MIPS: Octeon: Use defines instead of magic numbers

2016-09-13 Thread Aaro Koskinen
Hi, On Tue, Sep 13, 2016 at 07:04:54PM +, Asbjørn Sloth Tønnesen wrote: > On Tue, 13 Sep 2016 00:03:14 +0300, Aaro Koskinen <aaro.koski...@iki.fi> > wrote: > > On Mon, Sep 12, 2016 at 08:33:43PM +, Asbjoern Sloth Toennesen wrote: > > > The patch will be

[PATCH v2 0/3] MIPS: OCTEON: Add support for D-Link DSR-500N router

2016-09-12 Thread Aaro Koskinen
Hi, D-Link DSR-500N is close to 1000N and with small changes we can support both. v2: Delete redudant led labels from dlink_dsr-500n.dts. A. Aaro Koskinen (3): MIPS: OCTEON: split dlink_dsr-1000n.dts MIPS: OCTEON: add DTS for D-Link DSR-500N MIPS: OCTEON: fix PCI interrupt

[PATCH v2 2/3] MIPS: OCTEON: add DTS for D-Link DSR-500N

2016-09-12 Thread Aaro Koskinen
Add DTS for D-Link DSR-500N. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- .../mips/boot/dts/cavium-octeon/dlink_dsr-500n.dts | 40 ++ 1 file changed, 40 insertions(+) create mode 100644 arch/mips/boot/dts/cavium-octeon/dlink_dsr-500n.dts diff --git a/arc

[PATCH v2 3/3] MIPS: OCTEON: fix PCI interrupt routing on D-Link DSR-500N

2016-09-12 Thread Aaro Koskinen
Fix PCI interrupt routing on D-Link DSR-500N. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- arch/mips/pci/pci-octeon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c index c258cd4..308d051 100644 --- a/arch/mips/p

[PATCH v2 1/3] MIPS: OCTEON: split dlink_dsr-1000n.dts

2016-09-12 Thread Aaro Koskinen
Split dlink_dsr-1000n.dts to allow reuse with D-Link DSR-500N. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- .../boot/dts/cavium-octeon/dlink_dsr-1000n.dts | 45 + .../dts/cavium-octeon/dlink_dsr-500n-1000n.dtsi| 58 ++ 2 files chang

Re: [PATCH] MIPS: Octeon: Use defines instead of magic numbers

2016-09-12 Thread Aaro Koskinen
On Mon, Sep 12, 2016 at 08:33:43PM +, Asbjoern Sloth Toennesen wrote: > The patch will be followed by a similar patch to > drivers/staging/octeon/ethernet.c I think you should: 1. Move this function to staging/octeon 2. Do required cleanups there 3. Finally delete

v4.8 cpufreq regression?

2016-10-07 Thread Aaro Koskinen
Hi, I'm upgrading from v4.7 to v4.8 on MIPS/loongson2_cpufreq with cpufreq/ondemand and I noticed that /proc/cpuinfo is always reporting (regardless of system load): BogoMIPS: 697150.20 and sysfs: /sys/devices/system/cpu/cpufreq/policy0/affected_cpus:0

Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON

2016-08-25 Thread Aaro Koskinen
Hi, On Wed, Aug 24, 2016 at 11:42:00AM -0500, Steven J. Hill wrote: > It is actually two patches that cause the breakage. The other is: > >commit e55aeb6ba4e8cc3549bff1e75ea1d029324bce21 >of/irq: Mark interrupt controllers as populated before initialisation > > I needed to revert both

Re: [BISECTED REGRESSION] v4.8-rc: DT/OCTEON driver probing broken

2016-08-28 Thread Aaro Koskinen
atform/olpc/olpc_dt.c A. > On 16.08.2016 17:00, Aaro Koskinen wrote: > > Hi, > > > > Commit 44a7185c2ae6 ("of/platform: Add common method to populate default > > bus") added new arch_initcall of_platform_default_populate_init() that > > wil

[BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON

2016-08-23 Thread Aaro Koskinen
Hi, gpio-leds fails to probe on OCTEON with v4.8-rc3 and when using arch/mips/boot/dts/cavium-octeon/dlink_dsr-1000n.dts. Leds still worked with v4.7. I bisected this to: commit 15cc2ed6dcf91a8658e084be4e140147161819d7 Author: Jon Hunter Date:

[PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12"

2016-08-24 Thread Aaro Koskinen
Enable sound on PowerBook G4 12". Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- sound/aoa/fabrics/layout.c | 8 sound/aoa/soundbus/i2sbus/core.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabri

Re: [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12"

2016-08-24 Thread Aaro Koskinen
Hi, On Wed, Aug 24, 2016 at 09:43:23PM +0200, Johannes Berg wrote: > On Wed, 2016-08-24 at 20:57 +0300, Aaro Koskinen wrote: > > Enable sound on PowerBook G4 12". > > Looks good to me, I assume you tested it and it works :) Yes, I have this laptop in use. A.

[PATCH] cpufreq: skip invalid entries when searching the frequency

2016-10-10 Thread Aaro Koskinen
Skip invalid entries when searching the frequency. This fixes cpufreq at least on loongson2 MIPS board. Fixes: da0c6dc00c69 ("cpufreq: Handle sorted frequency tables more efficiently") Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- include/linux/cpufreq.h | 18 ++

Re: [PATCH V2] cpufreq: skip invalid entries when searching the frequency

2016-10-12 Thread Aaro Koskinen
Hi, On Wed, Oct 12, 2016 at 08:45:05AM +0530, Viresh Kumar wrote: > From: Aaro Koskinen <aaro.koski...@iki.fi> > > Skip invalid entries when searching the frequency. This fixes cpufreq > at least on loongson2 MIPS board. > > Fixes: da0c6dc00c69 ("cpufreq: Handle

Re: wl1251 & mac address & calibration data

2016-11-24 Thread Aaro Koskinen
Hi, On Thu, Nov 24, 2016 at 04:20:45PM +0100, Pali Rohár wrote: > Proprietary, signed and closed bootloader NOLO does not support DT. So > for booting you need to append DTS file to kernel image. > > U-Boot is optional and can be used as intermediate bootloader between > NOLO and kernel. But

Re: [PATCH] ARM: OMAP1: DMA: Correct the number of logical channels

2017-01-05 Thread Aaro Koskinen
nyways. > > Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Acked-by: Aaro Koskinen <aaro.koski...@iki.fi> A. > --- > arch/arm/mach-omap1/dma.c | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/arch/arm

Re: [PATCH] MAINTAINERS: Add Aaro Koskinen as TI omap1 SoC co-maintainer

2017-01-05 Thread Aaro Koskinen
Hi, On Thu, Jan 05, 2017 at 01:41:01PM -0800, Tony Lindgren wrote: > Aaro has been doing a great job making sure mach-omap1 stays working > with the mainline kernel. So let's add Aaro as omap1 co-maintainer to > the MAINTAINERS file. > > Cc: Aaro Koskinen <aaro.koski...@ik

Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

2017-01-03 Thread Aaro Koskinen
Hi, On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote: > > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs > > to be loaded to get the PHY going and ohci-omap should

Re: Nokia N900 sound driver and ECI GPIOs

2017-01-04 Thread Aaro Koskinen
Hi, On Mon, Jan 02, 2017 at 10:05:39PM +0100, joerg Reisenweber wrote: > On Mon 02 January 2017 21:01:01 Pali Rohár wrote: > > On Monday 02 January 2017 19:49:45 Aaro Koskinen wrote: > > > The schematic shows ECI(5:0), but only 3 are connected/used. There > > >

[PATCH] USB: ohci-omap: defer probe if PHY is missing

2017-01-02 Thread Aaro Koskinen
Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs to be loaded to get the PHY going and ohci-omap should wait for those. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/usb/host/ohci-omap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: Nokia N900 sound driver and ECI GPIOs

2017-01-02 Thread Aaro Koskinen
Hi, On Mon, Jan 02, 2017 at 09:44:32AM +0100, Pali Rohár wrote: > On Monday 02 January 2017 10:23:23 Peter Ujfalusi wrote: > > GPIO_182 is to select where to route the MIC line from the jack for the > > ECI core to handle (when the TVOUT is disabled). > > Yes, already figured out from schematic.

Re: [PATCH] dmaengine: omap-dma: Fix dynamic lch_map alocation

2017-01-02 Thread Aaro Koskinen
xes: 2d1a9a946fae ("dmaengine: omap-dma: Dynamically allocate memory for > lch_map") > Reported-by: Aaro Koskinen <aaro.koski...@iki.fi> > Cc: sta...@vger.kernel.org # v4.9 > Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Aaro Koskinen <aaro.koski...@iki.fi> Thanks, A.

Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

2017-01-03 Thread Aaro Koskinen
Hi, On Tue, Jan 03, 2017 at 08:05:04PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote: > > On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote: &

Re: [PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it

2017-04-04 Thread Aaro Koskinen
Hi, On Tue, Apr 04, 2017 at 11:30:28AM -0400, Javier Martinez Canillas wrote: > This series add OF device ID tables to mfd I2C drivers whose devices are > either used in Device Tree source files or are listed in binding docs as > a compatible string. For patches 1-5 you can add: Acked

Re: [PATCH] mfd: menelaus: remove obsolete local_irq_disable() and local_irq_enable()

2017-04-12 Thread Aaro Koskinen
; Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> > Cc: Henri Roosen <henri.roo...@ginzinger.com> I think the patch looks OK, so: Acked-by: Aaro Koskinen <aaro.koski...@iki.fi> But when trying to test it on N810/N800, I noticed I was missing RTC altogethe

Re: [PATCH v13 0/6] Cavium MMC driver

2017-04-12 Thread Aaro Koskinen
Hi, On Thu, Mar 30, 2017 at 05:31:22PM +0200, Jan Glauber wrote: > Hi Ulf, > > we have a bug on some Octeon plattforms so I removed the Octeon driver for now > (but kept the DT bindings for it). We'll submit the Octeon driver later when > we've fixed the issue. Please rather post a new version

Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

2017-04-03 Thread Aaro Koskinen
Hi, On Mon, Apr 03, 2017 at 06:24:39PM -0400, Javier Martinez Canillas wrote: > On 04/03/2017 06:20 PM, Rob Herring wrote: > > On Mon, Apr 03, 2017 at 11:45:14AM -0400, Javier Martinez Canillas wrote: > >> Hello Lee, > >> > >> On 04/03/2017 07:15 AM, Lee Jones wrote: > >> > >> [snip] > >> >

[PATCH] fbdev: omapfb: delete check_required_callbacks()

2017-04-07 Thread Aaro Koskinen
omap/lcd: Make callbacks optional") Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/video/fbdev/omap/omapfb_main.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c ind

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-06-29 Thread Aaro Koskinen
Hi, On Thu, Jun 29, 2017 at 09:50:13PM +0300, Aaro Koskinen wrote: > On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: > > On 15/06/17 01:11, Aaro Koskinen wrote: > > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > > is no dis

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-06-29 Thread Aaro Koskinen
Hi, On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: > On 15/06/17 01:11, Aaro Koskinen wrote: > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > is no display. > > Are you sure it doesn't probe? It fails the omapdss_sta

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-06-30 Thread Aaro Koskinen
Hi, On Fri, Jun 30, 2017 at 11:47:55AM +0300, Tomi Valkeinen wrote: > > So, I don't know... I guess I need to try to invent some horrible hacks > > around the driver to somehow manage the omap3 problems. Perhaps > > disabling/enabling the outputs when sync lost happens... > > Well, I tried that

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-06-30 Thread Aaro Koskinen
Hi, On Fri, Jun 30, 2017 at 09:41:35AM +0300, Tomi Valkeinen wrote: > On 29/06/17 21:50, Aaro Koskinen wrote: > > On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: > >> On 15/06/17 01:11, Aaro Koskinen wrote: > >>> When booting v4.12-rc5 on Noki

[BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-06-14 Thread Aaro Koskinen
Hi, When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there is no display. Bisected to: a09d2bc1503508c17ef3a71c6b1905e3660f3029 is the first bad commit commit a09d2bc1503508c17ef3a71c6b1905e3660f3029 Author: Peter Ujfalusi Date: Tue May 3 22:08:01 2016

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-06-18 Thread Aaro Koskinen
Hi, On Thu, Jun 15, 2017 at 10:28:31AM +0300, Peter Ujfalusi wrote: > On 2017-06-15 01:11, Aaro Koskinen wrote: > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > is no display. > > > > Bisected to: > > > > a09d2bc1503508c17e

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-06-18 Thread Aaro Koskinen
Hi, On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: > On 15/06/17 01:11, Aaro Koskinen wrote: > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > is no display. > > Are you sure it doesn't probe? It fails the omapdss_stack_is_ready

Re: 4.13 (and probably all recent) kernels refuse to boot on one Nokia N950, work or another

2017-10-25 Thread Aaro Koskinen
Hi, On Wed, Oct 25, 2017 at 02:28:07PM -0700, Tony Lindgren wrote: > Also try booting with mem=512M@0x8000 or 256M or 768M. Maybe the > memory is different size or partially broken? Yeah, some early N950s may have only 512 MB. A.

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-27 Thread Aaro Koskinen
Hi, On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > The RFBI driver has not worked nor compiled for many years. There are What is the build failure you are seeing? When removing the

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-27 Thread Aaro Koskinen
Hi, On Fri, Apr 27, 2018 at 07:58:28PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Friday, April 27, 2018 08:47:14 PM Aaro Koskinen wrote: > > On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > omapfb equivalent of drm's commit aa61321d4c08 (&quo

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-27 Thread Aaro Koskinen
Hi, On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > The RFBI driver has not worked nor compiled for many years. There are > very few boards out there that use RFBI, and no one has stepped

[PATCH] MAINTAINERS: update OMAP MMC entry

2018-04-27 Thread Aaro Koskinen
Jarkko's e-mail address hasn't worked for a long time. We still want to keep this driver working as it is critical for some of the OMAP boards. I use and test this driver frequently, so add myself as a maintainer with "Odd Fixes" status. Signed-off-by: Aaro Koskinen <aaro.ko

Re: v4.17-rc1: regressions on N900, N950

2018-05-23 Thread Aaro Koskinen
On Wed, May 23, 2018 at 12:56:38AM +0300, Aaro Koskinen wrote: > On Tue, May 22, 2018 at 10:58:26PM +0200, Pavel Machek wrote: > > On Tue 2018-05-22 22:41:39, Aaro Koskinen wrote: > > > My device worked with v4.17-rc1 (haven't found time to test newer > > > ker

Re: v4.17-rc1: regressions on N900, N950

2018-05-22 Thread Aaro Koskinen
Hi, On Tue, May 22, 2018 at 10:02:50AM +0200, Pali Rohár wrote: > Hi! I remember that in time of migration from platform board code to > device tree structures there appeared some bug which caused that > sometimes display were not initialized. And somebody figured out that > display

Re: v4.17-rc1: regressions on N900, N950

2018-05-22 Thread Aaro Koskinen
Hi, On Tue, May 22, 2018 at 10:58:26PM +0200, Pavel Machek wrote: > On Tue 2018-05-22 22:41:39, Aaro Koskinen wrote: > > My device worked with v4.17-rc1 (haven't found time to test newer kernels), > > but if you say the probe order is random then we must find some proper way

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-30 Thread Aaro Koskinen
Hi, On Mon, Apr 30, 2018 at 05:34:59PM +0200, Bartlomiej Zolnierkiewicz wrote: > BROKEN is not an user selectable config option so without modifying > drivers/video/fbdev/omap2/omapfb/dss/Kconfig the RFBI driver is not > even included in the kernel build.. Yes, I know. It's still incorrect to

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-30 Thread Aaro Koskinen
Hi, On Mon, Apr 30, 2018 at 10:06:11AM +0300, Tomi Valkeinen wrote: > On 27/04/18 21:12, Aaro Koskinen wrote: > >> You should be targeting omapdrm driver instead, fbdev subsystem is closed > >> for the new hardware support. > > > > AFAIK, based on N950 display su

[BISECTED] v4.15-rc: Boot regression on x86_64/AMD

2018-01-05 Thread Aaro Koskinen
Hi, After v4.14, I've been unable to boot my AMD compilation box with the v4.15-rc mainline Linux. It just ends up in a silent reboot loop. I bisected this to: commit fa564ad9636651fd11ec2c79c48dee844066f73a Author: Christian König Date: Tue Oct 24 14:40:29 2017

Re: [BISECTED] v4.15-rc: Boot regression on x86_64/AMD

2018-01-05 Thread Aaro Koskinen
Hi, On Fri, Jan 05, 2018 at 04:00:25PM -0800, Linus Torvalds wrote: > On Fri, Jan 5, 2018 at 2:04 PM, Aaro Koskinen <aaro.koski...@iki.fi> wrote: > > After v4.14, I've been unable to boot my AMD compilation box with the > > v4.15-rc mainline Linux. It just ends up in

Re: [BISECTED] v4.15-rc: Boot regression on x86_64/AMD

2018-01-06 Thread Aaro Koskinen
Hi, On Sat, Jan 06, 2018 at 04:10:38AM +0200, Aaro Koskinen wrote: > On Fri, Jan 05, 2018 at 04:00:25PM -0800, Linus Torvalds wrote: > > On Fri, Jan 5, 2018 at 2:04 PM, Aaro Koskinen <aaro.koski...@iki.fi> wrote: > > > After v4.14, I've been unable to boo

Re: [BISECTED] v4.15-rc: Boot regression on x86_64/AMD

2018-01-06 Thread Aaro Koskinen
Hi, On Sat, Jan 06, 2018 at 05:47:10PM +0100, Christian König wrote: > Am 06.01.2018 um 13:02 schrieb Aaro Koskinen: > > On Sat, Jan 06, 2018 at 04:10:38AM +0200, Aaro Koskinen wrote: > > > On Fri, Jan 05, 2018 at 04:00:25PM -0800, Linus Torvalds wrote: > > > >

Re: [PATCH 08/11 v2] ARM: OMAP1: constify gpio_led

2018-01-09 Thread Aaro Koskinen
...@gmail.com> Acked-by: Aaro Koskinen <aaro.koski...@iki.fi> A. > --- > changes in v2: > The GPIO LED driver can be built as a module, it can > be loaded after the init sections have gone away. > So removed '__initconst'. &g

Re: [PATCH v3 2/2] Staging: octeon-usb: Changes macro CVMX_WAIT_FOR_FIELD32 to function call.

2018-07-29 Thread Aaro Koskinen
Hi, On Sun, Jul 29, 2018 at 02:40:35PM +0300, Georgios Tsotsos wrote: > +/** > + * Loop through register until txfflsh or rxfflsh become zero. > + * > + * @usb: USB block > + * @address: 64bit address to read > + * @timeout_usec: Timeout > + * @fflsh_type:Indicates fflsh

Re: [PATCH v4 1/1] Staging: octeon-usb: Using defined error codes and applying coding style

2018-07-29 Thread Aaro Koskinen
Hi, On Sun, Jul 29, 2018 at 05:33:38PM +0300, Georgios Tsotsos wrote: > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c > b/drivers/staging/octeon-usb/octeon-hcd.c > index 3f44ac260eff..edf87d1b3609 100644 > --- a/drivers/staging/octeon-usb/octeon-hcd.c > +++

4.17-rc1: early boot crash on x86_64 & pti

2018-04-17 Thread Aaro Koskinen
Hi, I'm getting early crash on x86_64 box with 4.17-rc1 and PTI enabled. Bisected to: commit 39114b7a743e6759bab4d96b7d9651d44d17e3f9 Author: Dave Hansen Date: Fri Apr 6 13:55:17 2018 -0700 x86/pti: Never implicitly clear _PAGE_GLOBAL for kernel image I can

Re: 4.17-rc1: early boot crash on x86_64 & pti

2018-04-17 Thread Aaro Koskinen
Hi, On Tue, Apr 17, 2018 at 06:01:30PM +0300, Aaro Koskinen wrote: > I'm getting early crash on x86_64 box with 4.17-rc1 and PTI > enabled. Bisected to: > > commit 39114b7a743e6759bab4d96b7d9651d44d17e3f9 > Author: Dave Hansen <dave.han...@linux.intel.com> > Date: Fri A

Re: 4.17-rc1: early boot crash on x86_64 & pti

2018-04-17 Thread Aaro Koskinen
Hi, On Tue, Apr 17, 2018 at 08:38:18AM -0700, Dave Hansen wrote: > On 04/17/2018 08:28 AM, Aaro Koskinen wrote: > > > >> [0.00] Kernel/User page tables isolation: enabled > >> [0.00] [ cut here ] > >> [0.000

Re: [PATCH 1/5] x86, pti: fix boot problems from Global-bit setting

2018-04-23 Thread Aaro Koskinen
flush_range() to the other two sites and check for early boot. > > Signed-off-by: Dave Hansen <dave.han...@linux.intel.com> > Fixes: 39114b7a7 (x86/pti: Never implicitly clear _PAGE_GLOBAL for kernel > image) > Reported-by: Mariusz Ceier <mce...@gmail.com> > Reported-

Re: [PATCH 2/5] x86, pti: fix boot warning from Global-bit setting

2018-04-23 Thread Aaro Koskinen
ng when holes in the kernel image are encountered. > > Signed-off-by: Dave Hansen <dave.han...@linux.intel.com> > Fixes: 39114b7a7 (x86/pti: Never implicitly clear _PAGE_GLOBAL for kernel > image) > Reported-by: Mariusz Ceier <mce...@gmail.com> > Reported-by: Aaro

Re: v4.17-rc1: regressions on N900, N950

2018-04-23 Thread Aaro Koskinen
Hi, On Sun, Apr 22, 2018 at 09:42:13AM +0200, Pavel Machek wrote: > v4.17-rc1 broke display for me on Nokia N900. (I don't know if system > boots, but I can see on red flash LED that at least that driver > succeeded. So it should not be early boot crash). > > v4.17-rc1 also broke boot on N950. >

[PATCH] documentation: add my name to kernel driver statement

2018-03-04 Thread Aaro Koskinen
Add my name to kernel driver statement. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- Documentation/process/kernel-driver-statement.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/process/kernel-driver-statement.rst b/Documentation/process/kernel-

Re: [PATCH] init/ramdisk: use pr_cont() at the end of ramdisk loading

2018-03-04 Thread Aaro Koskinen
Hi, On Sat, Mar 03, 2018 at 06:14:33PM +0200, Andy Shevchenko wrote: > On Fri, Mar 2, 2018 at 10:55 PM, Aaro Koskinen <aaro.koski...@iki.fi> wrote: > > Use pr_cont() at the end of ramdisk loading. This will avoid the rotator > > and an extra newline a

[PATCH] init/ramdisk: use pr_cont() at the end of ramdisk loading

2018-03-02 Thread Aaro Koskinen
. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- init/do_mounts_rd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/init/do_mounts_rd.c b/init/do_mounts_rd.c index 99e0b64..e3cba12 100644 --- a/init/do_mounts_rd.c +++ b/init/do_mounts_rd.c @@ -255,7 +255,7

Bug report: MIPS CI20/jz4740-mmc DMA and PREEMPT_NONE

2018-10-14 Thread Aaro Koskinen
Hi, There is something wrong with jz4740-mmc in current mainline kernel (tested v4.18 and 4.19-rc, the MMC support for CI20 does not exist prior those), as the DMA support does not work properly if I disable kernel pre-emption. The console gets flooded with: [ 16.461094] jz4740-mmc

Re: Bug report: MIPS CI20/jz4740-mmc DMA and PREEMPT_NONE

2018-10-17 Thread Aaro Koskinen
Hi, On Wed, Oct 17, 2018 at 03:38:07PM +0200, Mathieu Malaterre wrote: > Since CONFIG_PREEMPT has been 'y' since at least commit 0752f92934292 > could you confirm that the original mmc driver (kernel from imgtech > people) did work ok with PREEMPT_NONE (sorry I did not do my homework) > ? Sorry,

[REGRESSION] OCTEON MMC driver failure with v4.19

2018-10-26 Thread Aaro Koskinen
Hi, OCTEON (MIPS64) MMC driver probe fails with v4.19, because with commit 6c2fb2ea76361da9b420a8e23a2a19e7842cbdda Author: Robin Murphy Date: Mon Jul 23 23:16:09 2018 +0100 of/device: Set bus DMA mask as appropriate we now get a default 32-bit bus DMA mask, and the device itself has

[PATCH] MIPS: OCTEON: fix out of bounds array access on CN68XX

2018-10-26 Thread Aaro Koskinen
faces on CN68XX") Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c b/arch/mips/cavium-octeon/executive/cvmx-helper.c index 75108ec669eb..6c79e8a16

Re: [REGRESSION] OCTEON MMC driver failure with v4.19

2018-11-05 Thread Aaro Koskinen
Hi, On Fri, Oct 26, 2018 at 11:54:23PM +0300, Aaro Koskinen wrote: > OCTEON (MIPS64) MMC driver probe fails with v4.19, because with > > commit 6c2fb2ea76361da9b420a8e23a2a19e7842cbdda > Author: Robin Murphy > Date: Mon Jul 23 23:16:09 2018 +0100 > > of/dev

[PATCH] MIPS: OCTEON: cavium_octeon_defconfig: re-enable OCTEON USB driver

2018-11-10 Thread Aaro Koskinen
Re-enable OCTEON USB driver which is needed on older hardware (e.g. EdgeRouter Lite) for mass storage etc. This got accidentally deleted when config options were changed for OCTEON2/3 USB. Fixes: f922bc0ad08b ("MIPS: Octeon: cavium_octeon_defconfig: Enable more drivers") Signed-of

Re: [REGRESSION] OCTEON MMC driver failure with v4.19

2018-11-06 Thread Aaro Koskinen
Hi, On Tue, Nov 06, 2018 at 11:05:11AM +0200, Aaro Koskinen wrote: > On Tue, Nov 06, 2018 at 07:27:24AM +0100, Christoph Hellwig wrote: > > On Tue, Nov 06, 2018 at 12:06:32AM +0200, Aaro Koskinen wrote: > > > With the below change, the MMC card probe seems to with v4.19. But it

[PATCH v2] MAINTAINERS: update OMAP MMC entry

2018-11-06 Thread Aaro Koskinen
Jarkko's e-mail address hasn't worked for a long time. We still want to keep this driver working as it is critical for some of the OMAP boards. I use and test this driver frequently, so change myself as a maintainer with "Odd Fixes" status. Signed-off-by: Aaro Koskinen Acked-by: Ton

Re: [REGRESSION] OCTEON MMC driver failure with v4.19

2018-11-06 Thread Aaro Koskinen
Hi, On Tue, Nov 06, 2018 at 07:27:24AM +0100, Christoph Hellwig wrote: > On Tue, Nov 06, 2018 at 12:06:32AM +0200, Aaro Koskinen wrote: > > With the below change, the MMC card probe seems to with v4.19. But it > > feels a bit hackish, don't you think... Is there some obvious

Re: [PATCH] ARM: OMAP1: ams-delta: Fix impossible .irq < 0

2018-10-02 Thread Aaro Koskinen
o, drop the valueless check > and let the modem device be registered regardless of .irq value, and > the value handled by "serial8250" driver. > > Fixes: 0812db943748 ("ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO > descriptor") > Reported-by: Dan Carpenter > Signed-off-by: Janusz Krzysztofik Acked-by: Aaro Koskinen A.

Re: Fwd: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Aaro Koskinen
On Fri, Nov 30, 2018 at 11:48:24AM -0800, Kees Cook wrote: > Better yet, since it's only 17 files, how about doing context-specific > changes? "This API is terrible" I think we should only use "good" with selected operators like !, ++, -- E.g. "This API is !good++" Suggested-by: George Orwell

[PATCH] ARM: OMAP1: fix USB configuration for device-only setups

2018-12-04 Thread Aaro Koskinen
Currently we do USB configuration only if the host mode (CONFIG_USB) is enabled. But it should be done also in the case of device-only setups, so change the condition to CONFIG_USB_SUPPORT. This allows to use omap_udc on Palm Tungsten E. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1

[PATCH] ARM: OMAP1: add MMC configuration for Palm Tungsten E

2018-12-04 Thread Aaro Koskinen
Add initial MMC configuration for Palm Tungsten E to allow using a proper rootfs on the device. This still assumes the bootloader enabling the MMC, and that the card is always present and writeable. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1/board-palmte.c | 29

[PATCH] staging: octeon-ethernet: delete redundant include

2018-12-05 Thread Aaro Koskinen
cvmx-smix-defs.h is not needed by this driver. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 1 - drivers/staging/octeon/ethernet.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet

[PATCH] staging: octeon-usb: use a helper function to set the DMA mask

2018-12-04 Thread Aaro Koskinen
Use a helper function to set the DMA mask. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 9c766f5b812f

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Aaro Koskinen
Hi, On Fri, Nov 23, 2018 at 01:45:46PM +0200, Peter Ujfalusi wrote: > On 23/11/2018 0.01, Aaro Koskinen wrote: > > With that reverted, the DMA works OK (and I can also now confirm that > > OMAP_DMA_LCH_2D works). I haven't yet checked if we actually need that > &

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Aaro Koskinen
Hi, On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > On 22/11/2018 17.12, Russell King - ARM Linux wrote: > > I'm also not sure about this: > > > > if (cpu_is_omap15xx()) > > end++; > > > > in dma_dest_len() - is that missing from the omap-dma driver?

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Aaro Koskinen
Hello, On Sat, Nov 24, 2018 at 05:48:23PM +, Russell King - ARM Linux wrote: > Hmm, there's more questionable stuff in this driver, and the gadget > layer. [...] > So, whatever way I look at this, the code in the removal path both > in omap_udc and the gadget removal code higher up looks

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Aaro Koskinen
Hi, On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > I think we're better off leaving omap-udc well alone, and if it's > now broken with DMA, then that's unfortunate - it would require > someone with the hardware to diagnose the problem and fix it. I > think trying to

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-20 Thread Aaro Koskinen
Hi, On Tue, Nov 20, 2018 at 09:28:37AM +0200, Peter Ujfalusi wrote: > On 19/11/2018 20.46, Aaro Koskinen wrote: > > On Mon, Nov 19, 2018 at 12:40:40PM +0200, Peter Ujfalusi wrote: > >> When the channel is configured for slave operation the LCH_TYPE needs to be > >&g

[PATCH v2] MMC: OMAP: fix broken MMC on OMAP15XX/OMAP5910/OMAP310

2018-11-19 Thread Aaro Koskinen
d OMAP2420 (Nokia N810). [1] https://marc.info/?t=12317519703=1=2 Fixes: 46a6730e3ff9 ("mmc-omap: Fix omap to use MMC_POWER_ON") Reported-by: Ladislav Michl Reported-by: Andrzej Zaborowski Tested-by: Ladislav Michl Acked-by: Tony Lindgren Signed-off-by: Aaro Koskinen ---

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Aaro Koskinen
Hi, On Thu, Nov 22, 2018 at 10:31:31AM +0200, Peter Ujfalusi wrote: > On 20/11/2018 23.04, Aaro Koskinen wrote: > > On Tue, Nov 20, 2018 at 09:28:37AM +0200, Peter Ujfalusi wrote: > >> On 19/11/2018 20.46, Aaro Koskinen wrote: > >>> On Mon, Nov 19, 2018 at 12:40:40

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Aaro Koskinen
Hi, On Thu, Nov 22, 2018 at 03:12:36PM +, Russell King - ARM Linux wrote: > On Thu, Nov 22, 2018 at 10:29:48AM +, Russell King - ARM Linux wrote: > > On Tue, Nov 20, 2018 at 11:04:06PM +0200, Aaro Koskinen wrote: > > > I had switched to PIO mode in 2015 since the WARN

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Aaro Koskinen
Hi, On Fri, Nov 23, 2018 at 12:25:49AM +, Russell King - ARM Linux wrote: > The patch was more for Peter to take a peek at OK, I'll hack with other platforms meanwhile. A.

[PATCH] ARM: OMAP1/2: fix SoC name printing

2018-11-19 Thread Aaro Koskinen
Currently we get extra newlines on OMAP1/2 when the SoC name is printed: [0.00] OMAP1510 [0.00] revision 2 handled as 15xx id: bc058c9b93111a16 [0.00] OMAP2420 [0.00] Fix by using pr_cont. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1/id.c | 6

[PATCH] ARM: OMAP1: devices: configure omap1_spi100k only on OMAP7xx

2018-11-19 Thread Aaro Koskinen
Configure omap1_spi100k only on OMAP7xx. This allows running multiboard kernels on non-OMAP7xx HW with CONFIG_SPI_OMAP_100K enabled. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1/devices.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm

Re: [PATCH] MMC: OMAP: fix broken MMC on OMAP15XX/OMAP5912/OMAP310

2018-11-19 Thread Aaro Koskinen
Hi, On Mon, Nov 19, 2018 at 11:58:32AM +0200, Peter Ujfalusi wrote: > On 2018-11-18 22:19, Aaro Koskinen wrote: > > Tested on OMAP15XX/OMAP310 (Palm TE), OMAP1710 (Nokia 770) > > and OMAP2420 (Nokia N810). > > Do you know if the DMA is enabled for the MMC? It might not work

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-19 Thread Aaro Koskinen
n, but based on what omap_udc driver (still using the legacy OMAP DMA API) does this seems to be correct. I tested the patch on Nokia 770 with MMC and couldn't see any negative impact. Tested-by: Aaro Koskinen A. > --- > drivers/dma/ti/omap-dma.c | 11 +++ > 1 file c

[PATCH] MMC: OMAP: fix broken MMC on OMAP15XX/OMAP5912/OMAP310

2018-11-18 Thread Aaro Koskinen
d OMAP2420 (Nokia N810). [1] https://marc.info/?t=12317519703=1=2 Fixes: 46a6730e3ff9 ("mmc-omap: Fix omap to use MMC_POWER_ON") Reported-by: Ladislav Michl Reported-by: Andrzej Zaborowski Signed-off-by: Aaro Koskinen --- drivers/mmc/host/omap.c | 11 +-- 1 file changed

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-04-01 Thread Aaro Koskinen
Hi, On Sun, Mar 31, 2013 at 03:05:42PM +0300, Ивайло Димитров wrote: > Yep, the code looks almost identical, I guess with some tweaks all SMC > code from that patch could be removed and instead used the one from SMC > PPA API. > > What I don't get, is why one needs to disable/enable fiqs/irqs:

<    1   2   3   4   5   6   7   8   9   10   >