Re: [PATCH] mtd: rawnand: ams-delta: Drop board specific partition info

2019-03-19 Thread Aaro Koskinen
On Tue, Mar 19, 2019 at 11:37:18PM +0100, Janusz Krzysztofik wrote: > After recent modifications, only a hardcoded partition info makes > the driver device specific. Other than that, the driver uses GPIO > exclusively and can be used on any hardware. > > Drop the partition info and use MTD

[PATCH] staging: octeon-ethernet: fix incorrect PHY mode

2019-03-25 Thread Aaro Koskinen
rrect mode. Tested on EdgeRouter Lite (RGMII_RXID, at803x PHY) and D-Link DSR-500N (RGMII, broadcom PHY). Fixes: 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 2 +- drivers/stagi

Re: [PATCH] staging: octeon-ethernet: fix incorrect PHY mode

2019-03-26 Thread Aaro Koskinen
Hi, On Tue, Mar 26, 2019 at 10:01:50AM +0100, Andrew Lunn wrote: > Humm, that is unique, as far as i know. Every other MAC driver uses > of_get_phy_mode() to get the value out of device tree. The proprietary > delay values can then be used to fine tune the basic delay setting > read from DT.

[PATCH] drivers: firmware: psci: add support for warm reset

2019-04-01 Thread Aaro Koskinen
From: Aaro Koskinen Add support for warm reset using SYSTEM_RESET2 introduced in PSCI 1.1 specification. Signed-off-by: Aaro Koskinen --- drivers/firmware/psci.c | 25 + include/uapi/linux/psci.h | 3 +++ 2 files changed, 28 insertions(+) diff --git a/drivers

Re: [PATCH] drivers: firmware: psci: add support for warm reset

2019-04-03 Thread Aaro Koskinen
Hi, On Wed, Apr 03, 2019 at 04:33:15AM +0100, Mark Rutland wrote: > On Mon, Apr 01, 2019 at 09:14:43PM +0300, Aaro Koskinen wrote: > > From: Aaro Koskinen > > > > Add support for warm reset using SYSTEM_RESET2 introduced in PSCI > > 1.1 specification. > >

[PATCH v2] drivers: firmware: psci: add support for warm reset

2019-04-03 Thread Aaro Koskinen
From: Aaro Koskinen Add support for warm reset using SYSTEM_RESET2 introduced in PSCI 1.1 specification. Signed-off-by: Aaro Koskinen --- v2: Added #define PSCI_1_1_SYSTEM_RESET_WARM. Refactored psci_probe. v1: https://marc.info/?l=linux-arm-kernel

Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

2019-04-11 Thread Aaro Koskinen
Hi, On Thu, Apr 11, 2019 at 05:49:36PM +0100, Sudeep Holla wrote: > On Thu, Apr 11, 2019 at 11:42:28AM +, Koskinen, Aaro (Nokia - FI/Espoo) > wrote: > > From: Sudeep Holla [sudeep.ho...@arm.com]: > > > static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > > > { > > >

Re: [PATCH v2] drivers: firmware: psci: add support for warm reset

2019-04-05 Thread Aaro Koskinen
Hi, On Fri, Apr 05, 2019 at 08:58:30AM +0530, saiprakash.ran...@codeaurora.org wrote: > On 2019-04-04 00:21, Aaro Koskinen wrote: > >From: Aaro Koskinen > > > >Add support for warm reset using SYSTEM_RESET2 introduced in PSCI > >1.1 specification. > > &

Re: [RESEND PATCH] mips: ralink: allow zboot

2019-03-21 Thread Aaro Koskinen
Hi, On Thu, Mar 21, 2019 at 11:03:34AM -0600, George Hilliard wrote: > Architecturally, there's nothing preventing compressed images from > working. Bootloaders built with support for the various compression > methods can decompress and run the kernel. In practice, many > bootloaders do not

[PATCH v4] panic/reboot: allow specifying reboot_mode for panic only

2019-03-21 Thread Aaro Koskinen
From: Aaro Koskinen Allow specifying reboot_mode for panic only. This is needed on systems where ramoops is used to store panic logs, and user wants to use warm reset to preserve those, while still having cold reset on normal reboots. Signed-off-by: Aaro Koskinen Reviewed-by: Kees Cook

Re: [PATCH] mtd: rawnand: ams-delta: Drop board specific partition info

2019-03-24 Thread Aaro Koskinen
Hi, On Sun, Mar 24, 2019 at 05:48:22PM +0100, Janusz Krzysztofik wrote: > Hi Aaro, > > Thanks for your review. > > On Wednesday, March 20, 2019 2:16:30 AM CET Aaro Koskinen wrote: > > On Tue, Mar 19, 2019 at 11:37:18PM +0100, Janusz Krzysztofik wrote: > > > Af

[RESEND PATCH v2] panic/reboot: allow specifying reboot_mode for panic only

2019-02-21 Thread Aaro Koskinen
From: Aaro Koskinen Allow specifying reboot_mode for panic only. This is needed on systems where ramoops is used to store panic logs, and user wants to use warm reset to preserve those, while still having cold reset on normal reboots. Signed-off-by: Aaro Koskinen --- v2: Use

[PATCH v3] panic/reboot: allow specifying reboot_mode for panic only

2019-02-21 Thread Aaro Koskinen
From: Aaro Koskinen Allow specifying reboot_mode for panic only. This is needed on systems where ramoops is used to store panic logs, and user wants to use warm reset to preserve those, while still having cold reset on normal reboots. Signed-off-by: Aaro Koskinen --- v3: Move

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-02-11 Thread Aaro Koskinen
Hi, On Mon, Feb 11, 2019 at 08:38:00PM -0200, Alexandre Oliva wrote: > On Feb 11, 2019, Tom Li wrote: > >> and, more recently, a very slow system overall, that's been present since > >> 4.20. > > > The mainline framebuffer driver doesn't have any hardware drawing, printing > > even a single

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-02-17 Thread Aaro Koskinen
On Sun, Feb 17, 2019 at 01:59:26AM -0300, Alexandre Oliva wrote: > On Feb 11, 2019, Aaro Koskinen wrote: > > > ATA (libata) CS5536 driver is having issues with spurious IRQs and often > > disables IRQs completely during the boot. You should see a warning > > in dm

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-03-07 Thread Aaro Koskinen
Hi, On Thu, Mar 07, 2019 at 03:41:01AM -0300, Alexandre Oliva wrote: > On Feb 17, 2019, "Maciej W. Rozycki" wrote: > > > Is there an MMIO completion barrier missing there somewhere by any chance > > causing an IRQ that has been handled already to be redelivered because an > > MMIO write

[PATCH] MMC: OMAP: fix the maximum timeout setting

2019-02-02 Thread Aaro Koskinen
, OMAP310), and also checked on real hardware using Palm TE (OMAP310), Nokia 770 (OMAP1710) and Nokia N810 (OMAP2420) that MMC works as before. [1] http://www.ti.com/lit/ug/spru680/spru680.pdf Fixes: 730c9b7e6630f ("[MMC] Add OMAP MMC host driver") Signed-off-by: Aaro Koskinen --- dri

Re: [PATCH 1/5] mips: cavium: no need to check return value of debugfs_create functions

2019-01-22 Thread Aaro Koskinen
Hi, On Tue, Jan 22, 2019 at 03:57:38PM +0100, Greg Kroah-Hartman wrote: > -static int init_debufs(void) > +static void init_debugfs(void) > { > - struct dentry *show_dentry; > dir = debugfs_create_dir("oct_ilm", 0); > - if (!dir) { > - pr_err("oct_ilm: failed to create

Re: [RFC v5 1/4] pstore/blk: new support logger for block devices

2019-01-23 Thread Aaro Koskinen
Hi, On Sat, Jan 19, 2019 at 04:53:48PM +0800, liaoweixiong wrote: > On 2019-01-18 08:12, Kees Cook wrote: > >> MTD (drivers/mtd/mtdoops.c). > > > > Would mtdoops get dropped in favor of pstore/blk, or do they not share > > features? > > We can show them what pstore/blk do. I think they will be

Re: [RFC v7 0/5] pstore/block: new support logger for block devices

2019-01-23 Thread Aaro Koskinen
Hi, On Wed, Jan 23, 2019 at 08:05:11PM +0800, liaoweixiong wrote: > Why should we need pstore_block? > 1. Most embedded intelligent equipment have no persistent ram, which > increases costs. We perfer to cheaper solutions, like block devices. > In fast, there is already a sample for block device

Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

2019-01-21 Thread Aaro Koskinen
Hi, On Mon, Jan 21, 2019 at 09:11:01AM -0800, Tony Lindgren wrote: > * Arthur Demchenkov [190121 03:22]: > > Wrong polarity of card detect GPIO pin leads to the system not > > booting from external mmc, if the back cover of N900 is closed. > > When the cover is open the system boots fine. > > >

Re: Bug report: unaligned access with ext4 encryption

2019-01-10 Thread Aaro Koskinen
Hi, On Fri, Jan 04, 2019 at 05:28:02PM +, David Howells wrote: > Eric Biggers wrote: > > Hi Aaro, thanks for the bug report! I think you're on the right track; it > > makes > > much more sense to have the keyrings subsystem store the payload with better > > alignment, than to work around

Re: Bug report: unaligned access with ext4 encryption

2019-01-10 Thread Aaro Koskinen
Hi, On Thu, Jan 10, 2019 at 03:01:14PM -0800, Eric Biggers wrote: > On Fri, Jan 11, 2019 at 12:29:28AM +0200, Aaro Koskinen wrote: > > Hi, > > > > On Fri, Jan 04, 2019 at 05:28:02PM +, David Howells wrote: > > > Eric Biggers wrote: > > > > Hi Aaro,

Re: Fwd: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Aaro Koskinen
On Fri, Nov 30, 2018 at 11:48:24AM -0800, Kees Cook wrote: > Better yet, since it's only 17 files, how about doing context-specific > changes? "This API is terrible" I think we should only use "good" with selected operators like !, ++, -- E.g. "This API is !good++" Suggested-by: George Orwell

[PATCH] ARM: OMAP: DTS: N950/N9: fix onenand timings

2018-12-23 Thread Aaro Koskinen
ng on both Nokia N950 and N9. Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT") Signed-off-by: Aaro Koskinen --- arch/arm/boot/dts/omap3-n950-n9.dtsi | 42 ++-- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/arch/arm/boot/dts/o

Bug report: unaligned access with ext4 encryption

2018-12-30 Thread Aaro Koskinen
Hi, When using ext4 encryption on SPARC, there's plenty of dmesg noise about unaligned access: [ 167.269526] Kernel unaligned access at TPC[5497a0] find_and_lock_process_key+0x80/0x120 [ 167.270152] Kernel unaligned access at TPC[5497a0] find_and_lock_process_key+0x80/0x120 [ 181.087451]

[PATCH] MMC: OMAP: fix broken MMC on OMAP15XX/OMAP5912/OMAP310

2018-11-18 Thread Aaro Koskinen
d OMAP2420 (Nokia N810). [1] https://marc.info/?t=12317519703=1=2 Fixes: 46a6730e3ff9 ("mmc-omap: Fix omap to use MMC_POWER_ON") Reported-by: Ladislav Michl Reported-by: Andrzej Zaborowski Signed-off-by: Aaro Koskinen --- drivers/mmc/host/omap.c | 11 +-- 1 file changed

[PATCH] MIPS: OCTEON: cavium_octeon_defconfig: re-enable OCTEON USB driver

2018-11-10 Thread Aaro Koskinen
Re-enable OCTEON USB driver which is needed on older hardware (e.g. EdgeRouter Lite) for mass storage etc. This got accidentally deleted when config options were changed for OCTEON2/3 USB. Fixes: f922bc0ad08b ("MIPS: Octeon: cavium_octeon_defconfig: Enable more drivers") Signed-of

Re: [REGRESSION] OCTEON MMC driver failure with v4.19

2018-11-05 Thread Aaro Koskinen
Hi, On Fri, Oct 26, 2018 at 11:54:23PM +0300, Aaro Koskinen wrote: > OCTEON (MIPS64) MMC driver probe fails with v4.19, because with > > commit 6c2fb2ea76361da9b420a8e23a2a19e7842cbdda > Author: Robin Murphy > Date: Mon Jul 23 23:16:09 2018 +0100 > > of/dev

Re: [REGRESSION] OCTEON MMC driver failure with v4.19

2018-11-06 Thread Aaro Koskinen
Hi, On Tue, Nov 06, 2018 at 07:27:24AM +0100, Christoph Hellwig wrote: > On Tue, Nov 06, 2018 at 12:06:32AM +0200, Aaro Koskinen wrote: > > With the below change, the MMC card probe seems to with v4.19. But it > > feels a bit hackish, don't you think... Is there some obvious

Re: [REGRESSION] OCTEON MMC driver failure with v4.19

2018-11-06 Thread Aaro Koskinen
Hi, On Tue, Nov 06, 2018 at 11:05:11AM +0200, Aaro Koskinen wrote: > On Tue, Nov 06, 2018 at 07:27:24AM +0100, Christoph Hellwig wrote: > > On Tue, Nov 06, 2018 at 12:06:32AM +0200, Aaro Koskinen wrote: > > > With the below change, the MMC card probe seems to with v4.19. But it

[PATCH v2] MAINTAINERS: update OMAP MMC entry

2018-11-06 Thread Aaro Koskinen
Jarkko's e-mail address hasn't worked for a long time. We still want to keep this driver working as it is critical for some of the OMAP boards. I use and test this driver frequently, so change myself as a maintainer with "Odd Fixes" status. Signed-off-by: Aaro Koskinen Acked-by: Ton

Re: [tpmdd-devel] [PATCH v8 0/8] TPM 2.0 support

2014-12-02 Thread Aaro Koskinen
Hi, On Wed, Dec 03, 2014 at 12:21:07AM +0100, Peter Hüwe wrote: > --- a/drivers/char/tpm/tpm_i2c_nuvoton.c > +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c > @@ -605,10 +605,8 @@ static int i2c_nuvoton_probe(struct i2c_client *client, > return -ENODEV; > > rc =

Re: [PATCH] Staging: octeon: Added several blank lines after declarations

2014-12-03 Thread Aaro Koskinen
Hi, On Wed, Dec 03, 2014 at 09:43:51PM +, Jamie Lawler wrote: > --- a/drivers/staging/octeon/ethernet-rx.c > +++ b/drivers/staging/octeon/ethernet-rx.c > @@ -84,6 +84,7 @@ static int cvm_irq_cpu; > static void cvm_oct_enable_napi(void *_) > { > int cpu = smp_processor_id(); > + >

Re: [PATCH] i2c: omap: fix NACK and Arbitration Lost irq handling

2014-11-20 Thread Aaro Koskinen
-by: Alexander Kochetkov > Fixes: 1d7afc9 i2c: omap: ack IRQ in parts > Cc: # v3.7+ I could not see any breakage or anything wrong on OMAP2 & OMAP3. On OMAP1 I don't have anything on the OMAP I2C bus, so cannot really test anything there. Tested-by: Aaro Koskinen > --- > d

Re: [PATCH] irqchip: omap-intc: fix legacy DMA regression

2015-01-06 Thread Aaro Koskinen
ople know to delete that > code once that legacy DMA driver is fixed up. > > Fixes: 55601c9f2467 (arm: omap: intc: switch over to linear irq domain) > Signed-off-by: Felipe Balbi I tested this on N950 with 3.19-rc3, and /proc/interrupts looks sane and also the "In-band Error"

Re: [PATCH] irqchip: omap-intc: fix legacy DMA regression

2015-01-06 Thread Aaro Koskinen
Hi, On Tue, Jan 06, 2015 at 06:05:32PM +, Russell King - ARM Linux wrote: > On Tue, Jan 06, 2015 at 10:51:33AM -0600, Felipe Balbi wrote: > > +* FIXME legacy OMAP DMA driver sitting under arch/arm/plat-omap/dma.c > > +* depends is still not ready for linear IRQ domains; because of

Re: 3.19 on Nokia n900: audio quality awful

2015-01-06 Thread Aaro Koskinen
Hi, On Tue, Jan 06, 2015 at 06:51:15PM +0100, Pavel Machek wrote: > On Tue 2015-01-06 11:25:45, Felipe Balbi wrote: > > On Tue, Jan 06, 2015 at 06:04:33PM +0100, Pavel Machek wrote: > > > In 3.18, sound is nice and clear. > > > > > > In 3.19, sound is unusable. It produces nasty tone when it

Re: 3.19 on Nokia n900: audio quality awful

2015-01-06 Thread Aaro Koskinen
Hi, On Tue, Jan 06, 2015 at 09:50:00PM +0100, Pavel Machek wrote: > PS: Unfortunately, N900 will not boot using nfsroot in 3.16+ at least, > and boot from MMC card is broken and has been for quite some time. USB networking works fine with 3.19-rc3 and also MMC card rootfs. What issues are you

Re: 3.19 on Nokia n900: audio quality awful

2015-01-06 Thread Aaro Koskinen
On Tue, Jan 06, 2015 at 11:08:05PM +0100, Pavel Machek wrote: > On Tue 2015-01-06 22:57:30, Aaro Koskinen wrote: > > Hi, > > > > On Tue, Jan 06, 2015 at 09:50:00PM +0100, Pavel Machek wrote: > > > PS: Unfortunately, N900 will not boot using nfsroot in 3.16+ at least

Re: 3.19 on Nokia n900: audio quality awful

2015-01-07 Thread Aaro Koskinen
Hi, On Tue, Jan 06, 2015 at 11:58:56PM +0100, Pavel Machek wrote: > On Wed 2015-01-07 00:27:17, Aaro Koskinen wrote: > > On Tue, Jan 06, 2015 at 11:08:05PM +0100, Pavel Machek wrote: > > > On Tue 2015-01-06 22:57:30, Aaro Koskinen wrote: > > > > Hi, > > > &

Re: [PATCH] tty: serial: serial-omap: depend on !8250_omap

2014-12-01 Thread Aaro Koskinen
Hi, On Mon, Dec 01, 2014 at 02:09:14PM +, One Thousand Gnomes wrote: > > Well the nightmare userspace switch from ttyS to ttyO few years ago is > > something we want to avoid.. I think the best solution would be to make > > serial-omap.c transparently provide support for ttyO using the new

Re: [PATCH 15/15] perf: replace _BSD_SOURCE macro by _DEFAULT_SOURCE

2014-09-28 Thread Aaro Koskinen
o keep _BSD_SOURCE still there for a while for backwards compatibility? (Not sure if it has relevance for those using older glibcs...). Anyway to fix the perf + glibc-2.20 build failure: Tested-by: Aaro Koskinen (BTW, your patch was missing Signed-off-by.) A. > --- > tools/perf/util/util.h

Re: [PATCH v10 5/9] arm: omap1: Migrate debug_ll macros to use 8250.S

2014-09-16 Thread Aaro Koskinen
Hi, On Tue, Sep 16, 2014 at 11:46:24PM +0100, Daniel Thompson wrote: > + config DEBUG_OMAP1UART1 > + bool "Kernel low-level debugging via OMAP1 UART1" > + depends on ARCH_OMAP1 > + select DEBUG_UART_8250 > + help > + Say Y here if

[PATCH] MIPS/loongson2_cpufreq: Fix CPU clock rate setting mismerge

2014-09-21 Thread Aaro Koskinen
-by: Aaro Koskinen Cc: sta...@vger.kernel.org # 3.16 --- arch/mips/loongson/lemote-2f/clock.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/mips/loongson/lemote-2f/clock.c b/arch/mips/loongson/lemote-2f/clock.c index a217061..462e34d 100644 --- a/arch/mips/loongson/lemote

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-09-22 Thread Aaro Koskinen
Hi, On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: > powerpc/perf: Adjust callchain based on DWARF debug info > > When saving the callchain on Power, the kernel conservatively saves excess > entries in the callchain. A few of these entries are needed in some cases > but not

Re: [PATCH] kernel: add support for gcc 5

2014-09-04 Thread Aaro Koskinen
On Thu, Sep 04, 2014 at 11:37:19AM -0400, Sasha Levin wrote: > We're missing include/linux/compiler-gcc5.h which is required now > because gcc branched off to v5 in trunk. > > Just copy the relevant bits out of include/linux/compiler-gcc4.h, > no new code is added as of now. > > This fixes a

Re: sparc64 WARNING: at mm/mmap.c:2757 exit_mmap+0x13c/0x160()

2014-08-30 Thread Aaro Koskinen
Hi, On Mon, Aug 18, 2014 at 10:38:50AM -0700, David Miller wrote: > All patches are in 3,17-rc1 FYI, the warning/bug still triggers with 3.17-rc2 during GCC bootstrap: [94075.963753] [ cut here ] [94076.018105] WARNING: CPU: 0 PID: 17192 at

Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void functions

2014-09-08 Thread Aaro Koskinen
On Mon, Sep 08, 2014 at 07:13:15PM +0200, Nitin Kuppelur wrote: > This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning by > removing return statement from void functions. Please format line length to <= 76 characters in the commit log. Maybe you could fix

Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void functions

2014-09-08 Thread Aaro Koskinen
Hi, On Mon, Sep 08, 2014 at 12:33:47PM -0700, Greg KH wrote: > On Mon, Sep 08, 2014 at 09:59:23PM +0300, Aaro Koskinen wrote: > > On Mon, Sep 08, 2014 at 07:13:15PM +0200, Nitin Kuppelur wrote: > > > This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning

Re: [PATCH] [next-20140808] [staging] [lustre] Fix coding style in llite/remote_perm.c

2014-08-09 Thread Aaro Koskinen
On Sat, Aug 09, 2014 at 08:22:48PM +, Junien Fridrick wrote: > Sorry for the noise, this is part of task 10 of the Eudyptula Challenge. Nothing wrong with the patch itself, but maybe in the future you could put such comments after the "---" line so that they won't be included in the git

Re: [PATCH 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations

2015-03-22 Thread Aaro Koskinen
ack before this gets merged. > > > > I found one build error, other than that, for the whole series > > please feel free to add: > > > > Tested-by: Tony Lindgren > > Thanks Tony. > Yep. I'll wait for news from Aaro then will re-send if ok. Works fine o

Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket

2015-03-24 Thread Aaro Koskinen
Hi, On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote: > On March 24, 2015 3:08:09 AM EDT, Dan Carpenter > wrote: > >On Mon, Mar 23, 2015 at 05:08:52PM -0400, Nicholas Krause wrote: > >> On March 23, 2015 9:06:26 AM EDT, Dan Carpenter > > wrote: > >> >On Mon, Mar 23, 2015 at

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread Aaro Koskinen
Hi, On Thu, Mar 12, 2015 at 02:04:41PM -0400, James Bottomley wrote: > On Thu, 2015-03-12 at 11:14 -0500, Scott Wood wrote: > > On Thu, 2015-03-12 at 08:11 -0400, James Bottomley wrote: > > > On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: > > > > Use %pS for actual addresses, otherwise

Re: [PATCH octeon-usb] fix 'line over 80 characters'

2015-03-18 Thread Aaro Koskinen
Hi, On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote: > This file contained a warning of a line being over 80 characters and > so the file has been edited to remove that warning. > > Signed-off-by: Amitoj Kaur Chawla > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1

Re: [PATCH] octeon-usb: fix 'too many leading tabs'

2015-03-18 Thread Aaro Koskinen
Hi, On Wed, Mar 18, 2015 at 10:18:29PM +0530, Amitoj Kaur Chawla wrote: > This file contained a lot of warnings of line of over 80 characters > and that the code needs to be refactored due to nested if else > conditions. > > The file was accordingly edited to remove some of the warnings. > >

[PATCH 1/3] mfd: menelaus: delete omap_has_menelaus

2015-03-28 Thread Aaro Koskinen
Delete unused macro. Signed-off-by: Aaro Koskinen --- include/linux/mfd/menelaus.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/linux/mfd/menelaus.h b/include/linux/mfd/menelaus.h index f097e89..a1e12bf3 100644 --- a/include/linux/mfd/menelaus.h +++ b/include/linux/mfd

[PATCH 3/3] mfd: menelaus: use macro for magic number

2015-03-28 Thread Aaro Koskinen
Use macro to check a register bit. Signed-off-by: Aaro Koskinen --- drivers/mfd/menelaus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index 917fa86..c2ca665 100644 --- a/drivers/mfd/menelaus.c +++ b/drivers/mfd/menelaus.c

[PATCH 2/3] mfd: menelaus: drop support for SW controller VCORE

2015-03-28 Thread Aaro Koskinen
Drop support for SW controlled VCORE, nobody uses it. Signed-off-by: Aaro Koskinen --- drivers/mfd/menelaus.c | 23 --- include/linux/mfd/menelaus.h | 1 - 2 files changed, 24 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index 9f01aef

[PATCH 0/3] mfd: menelaus: couple simple cleanups

2015-03-28 Thread Aaro Koskinen
Hi, I came across these while trying to start DT conversion for menelaus (http://marc.info/?t=14197028735=1=2). While the DT work failed and is still pending, I think it's still worth to apply these as they are independent and they remove some cruft from the tree. A. Aaro Koskinen (3

[PATCH 1/3] rtc: initialize rtc name early

2015-03-28 Thread Aaro Koskinen
Fix by initializing the name early. Signed-off-by: Aaro Koskinen --- drivers/rtc/class.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c index 472a5ad..014ecbc 100644 --- a/drivers/rtc/class.c +++ b/drivers/rtc/class.c @@ -225,15

[PATCH 2/3] rtc: __rtc_read_time: reduce log level

2015-03-28 Thread Aaro Koskinen
hwclock: RTC_RD_TIME: Invalid argument If there's a real error, it's likely that lower level or higher level code will tell it anyway. Make these logs debug logs, and also print the error code for the read failure. Signed-off-by: Aaro Koskinen --- drivers/rtc/interface.c | 5 +++-- 1 file changed, 3

[PATCH 3/3] rtc: hctosys: use function name in the error log

2015-03-28 Thread Aaro Koskinen
Use function name in the error log instead of __FILE__. Signed-off-by: Aaro Koskinen --- drivers/rtc/hctosys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/hctosys.c b/drivers/rtc/hctosys.c index 6c719f2..7748a61 100644 --- a/drivers/rtc/hctosys.c +++ b

Re: [PATCH] README: Update references to version 4

2015-03-29 Thread Aaro Koskinen
Hi, On Sat, Mar 28, 2015 at 11:46:30PM -0400, Pranith Kumar wrote: > Since we bumped the version to 4.0, let us update the references > to match that in the README file. Documentation/HOWTO seems to have plenty of references to 3.x as well... A. -- To unsubscribe from this list: send the line

Re: [PATCHv3 1/2] HSI: cmt_speech: Add cmt-speech driver

2015-03-29 Thread Aaro Koskinen
e/speech data between > the Nokia N900/N950/N9's modem and its cpu. > > Signed-off-by: Kai Vehmanen > Signed-off-by: Carlos Chinea > Signed-off-by: Joni Lapilainen Acked-by: Aaro Koskinen A. -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCHv3 2/2] HSI: nokia-modem: Add cmt-speech support

2015-03-29 Thread Aaro Koskinen
Hi, On Sat, Mar 21, 2015 at 08:09:17PM +0100, Sebastian Reichel wrote: > Register cmt-speech driver in nokia-modem driver and forward > hsi channel information. > > Signed-off-by: Sebastian Reichel Acked-by: Aaro Koskinen A. -- To unsubscribe from this list: send the line "

Re: OT: Open letter to the Linux World

2015-04-10 Thread Aaro Koskinen
Hi, On Wed, Apr 08, 2015 at 07:37:15PM -0500, Rob Landley wrote: > Heck, the FSF's entire "It's GNU Linux, Dammit! Call it by its proper > name: GNU/Linux/dammit" campaign is seriously irritating, and part of > what I was doing with busybox was trying to create a linux development > system

Re: [PATCH 00/10] omap3 crypto fixes

2015-02-26 Thread Aaro Koskinen
ac-sha1 alg: hash: Chunking test 1 failed for omap-hmac-md5 But that's probably unrelated to this series. For patches 1-8, feel free to add: Tested-by: Aaro Koskinen A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

Re: 3.20-rc0 breaks nfsroot over usb

2015-02-26 Thread Aaro Koskinen
Hi, On Thu, Feb 26, 2015 at 11:19:50PM +0100, Pavel Machek wrote: > Ok, it seems that new config dependencies broke my kconfig. These will > not be enabled if you just to make oldconfig; you want to make sure > they are on. > > OMAP2430 and onwards (USB_MUSB_OMAP2PLUS) [N/m/y] (NEW) > TWL4030

Re: [PATCH, RESEND] usb: musb: fix Kconfig regression

2015-02-27 Thread Aaro Koskinen
> Fixes: ca784be36cc725 ("usb: start using the control module driver") > Acked-by: Acked-by: Pavel Machek > Cc: # v3.9+ This patch allows me to disable redundant CONFIG_OMAP_CONTROL_PHY from 4.0-rc1 .config and still get a working USB on Nokia N9. So: Tested-by: Aaro Koskinen T

Re: [PATCH 1/9] HSI: cmt_speech: Add cmt-speech driver

2015-03-02 Thread Aaro Koskinen
Hi, On Mon, Mar 02, 2015 at 05:38:51AM +0100, Sebastian Reichel wrote: > From: Kai Vehmanen > > Introduces the cmt-speech driver, which implements > a character device interface for transferring speech > data frames over HSI/SSI. > > The driver is used to exchange voice/speech data between >

Re: [PATCH v2 3/3] MIPS: OCTEON: Use device tree to probe for flash chips.

2015-03-15 Thread Aaro Koskinen
Hi, On Thu, Mar 05, 2015 at 05:31:31PM +0300, Aleksey Makarov wrote: > From: David Daney > > Don't assume they are there, the device tree will tell us. > > Signed-off-by: David Daney > Signed-off-by: Aleksey Makarov Tested-by: Aaro Koskinen A. -- To unsubscribe fr

Re: [PATCH v3] mmc: OCTEON: Add host driver for OCTEON MMC controller

2015-03-15 Thread Aaro Koskinen
aney > Signed-off-by: Leonid Rosenboim > Signed-off-by: Aaron Williams > Signed-off-by: Chandrakala Chavva > Signed-off-by: Peter Swain > [aleksey.maka...@auriga.com: preparation for submission] > Signed-off-by: Aleksey Makarov Seems to work fine on EdgeRouter Pro (cn61xx).

Re: mips build failures due to commit 8dd928915a73 (mips: fix up obsolete cpu function usage)

2015-04-20 Thread Aaro Koskinen
Hi, On Mon, Apr 20, 2015 at 12:40:28PM -0700, Guenter Roeck wrote: > the upstream kernel fails to build mips:nlm_xlp_defconfig, > mips:nlm_xlp_defconfig, mips:cavium_octeon_defconfig, and possibly > other targets, with errors such as > > arch/mips/kernel/smp.c:211:2: error: > passing

[PATCH] pata_octeon_cf: fix broken build

2015-06-08 Thread Aaro Koskinen
MODULE_DEVICE_TABLE is referring to wrong driver's table and breaks the build. Fix that. Cc: sta...@vger.kernel.org Signed-off-by: Aaro Koskinen --- drivers/ata/pata_octeon_cf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata

Re: [PATCH v4] mmc: OCTEON: Add host driver for OCTEON MMC controller

2015-05-18 Thread Aaro Koskinen
Hi, On Mon, Mar 16, 2015 at 06:06:00PM +0300, Aleksey Makarov wrote: > The OCTEON MMC controller is currently found on cn61XX and cnf71XX > devices. Device parameters are configured from device tree data. > > eMMC, MMC and SD devices are supported. > > Tested-by: Aaro Kosk

Re: [PATCH] Revert "perf tools: Allow to specify custom linker command"

2015-07-13 Thread Aaro Koskinen
Hi, On Mon, Jul 13, 2015 at 02:10:53PM +0300, Alexey Brodkin wrote: > This reverts commit 5ef7bbb09f7b > ("perf tools: Allow to specify custom linker command"). > > LD is a pre-defined variable in GNU Make. I.e. it is always defined. > Which means there's no point to check "LD ?= ..." because it

Re: Getting new udev to run with 2.6.28

2015-01-10 Thread Aaro Koskinen
Hi, On Sat, Jan 10, 2015 at 06:39:20PM +0100, Pavel Machek wrote: > N900 has real problems on 3.19, and 2.6.28 should be very well > debugged version. Getting it to compile on recent distribution was > fun, but I succeeded. Unfortunately, Debian 7's udev does not work > with 2.6.28... I guess

Re: Getting new udev to run with 2.6.28

2015-01-10 Thread Aaro Koskinen
Hi, On Sat, Jan 10, 2015 at 09:18:05PM +, Al Viro wrote: > On Sat, Jan 10, 2015 at 09:13:35PM +0200, Aaro Koskinen wrote: > > On Sat, Jan 10, 2015 at 06:39:20PM +0100, Pavel Machek wrote: > > > N900 has real problems on 3.19, and 2.6.28 should be very well > > >

Re: N900 v3.19-rc5 errors

2015-01-25 Thread Aaro Koskinen
Hi, On Fri, Jan 23, 2015 at 02:15:56PM +0100, Pali Rohár wrote: > I'm getting these two errors when booting DT linux v3.19-rc5 in n900 qemu: > > [0.309234] device-tree: Duplicate name in onenand@0,0, renamed to "#1" > [0.309417] device-tree: Duplicate name in onenand@0,0, renamed to "#2"

Re: mmc does not work in qemu n900

2015-01-26 Thread Aaro Koskinen
Hi, On Mon, Jan 26, 2015 at 10:04:59PM +0100, Pali Rohár wrote: > problem? Why any of these two patches fix problem when mmc is not > detected by kernel in qemu (machine n900)? Detection of mmc fails > because function mmc_send_op_cond() without one of above patches > fails. Has it ever

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-27 Thread Aaro Koskinen
On Tue, Jan 27, 2015 at 01:50:22PM -0500, Nicolas Pitre wrote: > Hence the ATAG-to-DT compat code in the decompressor. This > was meant to smooth things around the transition to DT, etc. After all, > those devices with non-replaceable bootloaders where shim layers are not > possible should

[PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
<00020336> dc82 10400037 010f 010f [ 94.267183] ---[ end trace c9e3815ee655bdaa ]--- [ 94.271804] Fatal exception: panic in 5 seconds Reported-by: Hemmo Nieminen Signed-off-by: Aaro Koskinen Cc: sta...@vger.kernel.org --- arch/mips/cavium-octeon/smp.c | 5 +++--

[PATCH 2/2] MIPS: fix kernel lockup or crash after CPU offline/online

2015-01-15 Thread Aaro Koskinen
cpu_report() in start_secondary() only after the exception handlers have been initialized to fix this. Without the patch the kernel will randomly either lockup or crash after a CPU is onlined and the console driver is a module. Signed-off-by: Hemmo Nieminen Signed-off-by: Aaro Koskinen Cc: sta

Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
Hi, On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote: > On 01/15/2015 10:49 AM, Aaro Koskinen wrote: > >octeon_cpu_disable() will unconditionally enable interrupts when called > >with interrupts disabled. Fix that. > > interrupts are always disabled here, so.

Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
Hi, On Thu, Jan 15, 2015 at 12:10:08PM -0800, David Daney wrote: > On 01/15/2015 11:53 AM, Aaro Koskinen wrote: > >Hi, > > > >On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote: > >>On 01/15/2015 10:49 AM, Aaro Koskinen wrote: > >>>octeon

[PATCH v2 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
ed-off-by: Aaro Koskinen Acked-by: David Daney Cc: sta...@vger.kernel.org # v3.18+ --- v2: Remove local_irq_disable/local_irq_enable altogether, instead of saving and restoring the old context. v1: http://marc.info/?l=linux-mips=142134781818170=2 arch/mips/cavium-octeon

[PATCH v2 2/2] MIPS: fix kernel lockup or crash after CPU offline/online

2015-01-15 Thread Aaro Koskinen
cpu_report() in start_secondary() only after the exception handlers have been initialized to fix this. Without the patch the kernel will randomly either lockup or crash after a CPU is onlined and the console driver is a module. Signed-off-by: Hemmo Nieminen Signed-off-by: Aaro Koskinen Cc: sta

Re: [PATCH] SATA: OCTEON: support SATA on OCTEON platform

2015-01-22 Thread Aaro Koskinen
Hi, On Wed, Jan 21, 2015 at 09:17:31AM -0800, David Daney wrote: > On 01/21/2015 08:54 AM, Mark Rutland wrote: > >While the DTB may already exist, the string "cavium,octeon-7130-ahci" > >isn't in mainline, and as far as I can see has never been supported. > > There seems to be a disconnect here.

Re: v3.19: Nokia N900 - boot errors

2015-01-31 Thread Aaro Koskinen
Hi, On Sat, Jan 31, 2015 at 10:28:46AM +0100, Pali Rohár wrote: > when I boot 3.19 kernel on real n900 device it show these errors in dmesg: > > [0.256103] hw-breakpoint: debug architecture 0x4 unsupported. > [0.257659] In-band Error seen by MPU at address 0 > [0.257720]

Re: v3.19: Nokia N900 - boot errors

2015-01-31 Thread Aaro Koskinen
Hi, On Sat, Jan 31, 2015 at 12:08:31PM +0100, Pali Rohár wrote: > On Saturday 31 January 2015 12:05:09 Aaro Koskinen wrote: > > Hi, > > > > On Sat, Jan 31, 2015 at 10:28:46AM +0100, Pali Rohár wrote: > > > when I boot 3.19 kernel on real n900 device it sh

Re: [PATCH 09/14] MIPS: OCTEON: Add ability to used an initrd from a named memory block.

2014-12-15 Thread Aaro Koskinen
On Mon, Dec 15, 2014 at 09:03:15PM +0300, Aleksey Makarov wrote: > From: David Daney > > If 'rd_name=xxx' is passed to the kernel, the named block with name > 'xxx' is used for the initrd. Maybe use "initrd_name" for consistency or even just "initrd" (if the xxx is not in form of "address,size"

Re: [PATCH 12/14] MIPS: OCTEON: Update octeon-model.h code for new SoCs.

2014-12-15 Thread Aaro Koskinen
Hi, On Mon, Dec 15, 2014 at 09:03:18PM +0300, Aleksey Makarov wrote: > From: David Daney > > Add coverage for OCTEON III models. [...] > +#define OCTEON_IS_OCTEON1() OCTEON_IS_MODEL(OCTEON_CN3XXX) > +#define OCTEON_IS_OCTEONPLUS() OCTEON_IS_MODEL(OCTEON_CN5XXX) > +#define

Re: [PATCH 13/14] MIPS: OCTEON: Add register definitions for OCTEON III reset unit.

2014-12-15 Thread Aaro Koskinen
Hi, On Mon, Dec 15, 2014 at 09:03:19PM +0300, Aleksey Makarov wrote: > From: David Daney > > Needed by follow-on patches. Looks like only one of the unions was needed (cvmx_rst_boot)...? A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 14/14] MIPS: OCTEON: Handle OCTEON III in csrc-octeon.

2014-12-15 Thread Aaro Koskinen
Hi, On Mon, Dec 15, 2014 at 09:03:20PM +0300, Aleksey Makarov wrote: > if (current_cpu_type() == CPU_CAVIUM_OCTEON2) { > union cvmx_mio_rst_boot rst_boot; > + > rst_boot.u64 = cvmx_read_csr(CVMX_MIO_RST_BOOT); > rdiv = rst_boot.s.c_mul;/*

Re: [PATCH 14/14] MIPS: OCTEON: Handle OCTEON III in csrc-octeon.

2014-12-15 Thread Aaro Koskinen
Hi, On Mon, Dec 15, 2014 at 01:29:28PM -0800, David Daney wrote: > On 12/15/2014 01:24 PM, Aaro Koskinen wrote: > >On Mon, Dec 15, 2014 at 09:03:20PM +0300, Aleksey Makarov wrote: > >>if (current_cpu_type() == CPU_CAVIUM_OCTEON2) { > >>union

Re: [PATCH 13/14] MIPS: OCTEON: Add register definitions for OCTEON III reset unit.

2014-12-15 Thread Aaro Koskinen
Hi, On Mon, Dec 15, 2014 at 01:31:28PM -0800, David Daney wrote: > On 12/15/2014 01:09 PM, Aaro Koskinen wrote: > >Hi, > > > >On Mon, Dec 15, 2014 at 09:03:19PM +0300, Aleksey Makarov wrote: > >>From: David Daney > >> > >>Needed by follow-on p

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-16 Thread Aaro Koskinen
Hi, On Wed, Oct 15, 2014 at 03:23:32PM +0800, Kelvin Cheung wrote: > This patch adds cpufreq driver for Loongson1B which > is capable of changing the CPU frequency dynamically. > > Signed-off-by: Kelvin Cheung [...] > obj-$(CONFIG_LOONGSON2_CPUFREQ) += loongson2_cpufreq.o >

Re: [PATCH] kernel: use the gnu89 standard explicitly

2014-10-19 Thread Aaro Koskinen
Hi, On Sun, Oct 19, 2014 at 01:05:22PM -0700, Linus Torvalds wrote: > On Sun, Oct 19, 2014 at 9:07 AM, Sasha Levin wrote: > > gcc5 changes the default standard to c11, rather than gnu89, which > > makes kernel build unhappy. (I guess the default will be gnu11 instead of c11.) > Hmm. Just how

Re: USB Ethernet gadget on Nokia n900

2014-10-20 Thread Aaro Koskinen
Hi, On Sun, Oct 19, 2014 at 09:19:37PM +0200, Pavel Machek wrote: > I am trying to use nfsroot, so I can't use modules. Why not? > (I am attaching full config, in case I missed something important). I'm using the below config with 3.17 and g_ether works OK. (My initramfs modprobes g_ether,

<    4   5   6   7   8   9   10   11   >