[PATCH v5 1/4] block: Add iocontext priority to request

2016-10-13 Thread Adam Manzanares
to see if the ioprio of the bio is valid and if so then the request prio comes from the bio. Signed-off-by: Adam Manzananares <adam.manzana...@wdc.com> --- block/blk-core.c | 4 +++- include/linux/blkdev.h | 14 ++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a

[PATCH v5 2/4] fusion: remove iopriority handling

2016-10-13 Thread Adam Manzanares
The request priority is now by default coming from the ioc. It was not clear what this code was trying to do based upon the iopriority class or data. The driver should check that a device supports priorities and use them according to the specificiations of ioprio. Signed-off-by: Adam Manzanares

[PATCH v5 4/4] ata: ATA Command Priority Disabled By Default

2016-10-13 Thread Adam Manzanares
Add a sysfs entry to turn on priority information being passed to a ATA device. By default this feature is turned off. This patch depends on ata: Enabling ATA Command Priorities Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- drivers/ata/libahci.c | 1 + drivers/ata/

ping howto (was Re: [PATCH resend] vfs: allow FILE_EXTENT_SAME (dedupe_file_range) on a file opened ro)

2016-10-12 Thread Adam Borowski
On Wed, Oct 05, 2016 at 04:38:54PM +0200, Adam Borowski wrote: > [fix for dedupe-vs-exec ETXTBSY] > Reviewed-by: Mark Fasheh <mfas...@suse.de> Hi guys! May I ask if I'm doing something wrong, or barking up the wrong tree? I've sent this patch thrice (May 20, Jul 18, Oct 5), pinged

Re: [PATCH v4 1/4] block: Add iocontext priority to request

2016-10-14 Thread Adam Manzananares
The 10/14/2016 07:54, Hannes Reinecke wrote: > On 10/13/2016 09:53 PM, Adam Manzanares wrote: > > Patch adds an association between iocontext ioprio and the ioprio of a > > request. This value is set in blk_rq_set_prio which takes the request and > > the ioc as arguments

Re: [PATCH v5 2/4] fusion: remove iopriority handling

2016-10-14 Thread Adam Manzanares
from the patchset. I must have missed the patch you are referencing. Take care, Adam

[PATCH v6 2/3] ata: Enabling ATA Command Priorities

2016-10-17 Thread Adam Manzanares
to the device. Signed-off-by: Adam Manzanares <adam.manzana...@hgst.com> --- drivers/ata/libata-core.c | 35 ++- drivers/ata/libata-scsi.c | 6 +- drivers/ata/libata.h | 2 +- include/linux/ata.h | 6 ++ include/linux/libata.h

Re: Linux 4.8.11

2016-11-26 Thread Adam Borowski
On Sat, Nov 26, 2016 at 05:12:35PM +0100, Greg KH wrote: > I'm announcing the release of the 4.8.11 kernel. ... which splats during early boot where 4.8.10 worked fine. [0.00] Linux version 4.8.11+ (kilobyte@umbar) (gcc version 6.2.1 20161124 (Debian 6.2.1-5) ) #1 SMP Sat Nov 26

[PATCH] mpt3sas: Recognize and act on iopriority info

2016-11-29 Thread Adam Manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This patch adds support for request iopriority handling in the mpt3sas layer. This works only when a ATA device is behind the SATL. The ATA device also has to indicate that it supports command priorities in the identify information that is

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-29 Thread Adam Borowski
On Tue, Nov 29, 2016 at 10:01:15AM +, Andrey Utkin wrote: > Regarding logout scrollback clearing not working for me. ncurses-6.0-rc1 > which I tested it with is the latest available in Gentoo portage, please > confirm whether I need any newer version, or should I tune something > else. I'd

[PATCH v3 1/1] x86/kbuild: enable modversions for symbols exported from asm

2016-12-10 Thread Adam Borowski
ns for x86, and an architecture-independent file that can be used for common symbols. With f27c2f6 reverting 8ab2ae6 ("default exported asm symbols to zero") we produce a scary warning on x86, this commit fixes that. Signed-off-by: Adam Borowski <kilob...@angband.pl> Tested-by: Kalle Valo &l

[PATCH v3 0/1] asm prototypes for modversions on x86

2016-12-10 Thread Adam Borowski
Hi! After Linus' revert of Arnd's modversions patch, it looks like we're back to wanting asm-prototypes.h at least in the short term. Things are much better than before -- instead of failing to load modules there's just a scary warning, but I still believe that no scary warning is better :)

[PATCH v2] mpt3sas: Recognize and act on iopriority info

2016-12-12 Thread Adam Manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This patch adds support for request iopriority handling in the mpt3sas layer. This works only when a ATA device is behind the SATL. The ATA device also has to indicate that it supports command priorities in the identify information that is

[PATCH v7 0/4] Enabling ATA Command Priorities

2016-12-06 Thread Adam Manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This patch builds ATA commands with high priority if the iocontext of a process is set to real time. The goal of the patch is to improve tail latencies of workloads that use higher queue depths. This requires setting the iocontext

[PATCH v7 1/4] block: Add iocontext priority to request

2016-12-06 Thread Adam Manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Patch adds an association between iocontext ioprio and the ioprio of a request. This is done to enable request based drivers the ability to act on priority information stored in the request. An example being ATA devices that support c

[PATCH v7 2/4] ata: Enabling ATA Command Priorities

2016-12-06 Thread Adam Manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This patch checks to see if an ATA device supports NCQ command priorities. If so and the user has specified an iocontext that indicates IO_PRIO_CLASS_RT then we build a tf with a high priority command. This is done to improve the tail l

[PATCH v7 4/4] ata: set ncq_prio_enabled iff device has support

2016-12-06 Thread Adam Manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> We previously had a check to see if the device has support for prioritized ncq commands and a check to see if a device flag is set, through a sysfs variable, in order to send a prioritized command. This patch only allows the sysfs va

[PATCH v7 3/4] ata: ATA Command Priority Disabled By Default

2016-12-06 Thread Adam Manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Add a sysfs entry to turn on priority information being passed to a ATA device. By default this feature is turned off. This patch depends on ata: Enabling ATA Command Priorities tj: Renamed ncq_prio_on to ncq_prio_enable and removed t

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-12-17 Thread Adam Borowski
On Sat, Dec 17, 2016 at 09:57:47AM +0100, Jiri Slaby wrote: > On 12/16/2016, 08:57 PM, Linus Torvalds wrote: > > On Fri, Dec 16, 2016 at 11:55 AM, Jiri Slaby wrote: > >> > >> what happened to this? I had to apply this to fix 4.9-pae kernel here. > > > > Did you actually have to

Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter

2017-01-10 Thread Adam Borowski
On Tue, Jan 10, 2017 at 10:28:38PM +0100, Manuel Schölling wrote: > The impact of the persistent scrollback feature on the code size is > rather small, so the config option is removed. The feature stays > disabled by default and can be enabled by using the boot command line > parameter

Re: [RFC3 nowrap: PATCH v7 00/18] ILP32 for ARM64

2016-11-29 Thread Adam Borowski
On Wed, Nov 30, 2016 at 10:32:09AM +0530, Yury Norov wrote: > On Fri, Oct 21, 2016 at 11:32:59PM +0300, Yury Norov wrote: > > This series enables aarch64 with ilp32 mode, and as supporting work, > > introduces ARCH_32BIT_OFF_T configuration option that is enabled for > > existing 32-bit

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Adam Borowski
On Mon, Nov 28, 2016 at 08:08:57PM -0800, Linus Torvalds wrote: > On Mon, Nov 28, 2016 at 5:15 PM, Ben Hutchings wrote: > >> > >> The modversions stuff may just be too painful to bother with. Very few > >> people probably use it, and the ones that do likely don't have any >

[PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Adam Borowski
ns for x86, and an architecture-independent file that can be used for common symbols. User impact: kernels may fail to load modules at all when CONFIG_MODVERSIONS=y. Signed-off-by: Adam Borowski <kilob...@angband.pl> Tested-by: Kalle Valo <kv...@codeaurora.org> Acked-by: Nicholas Piggin <

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Adam Borowski
On Tue, Nov 29, 2016 at 02:29:54PM +0100, Ingo Molnar wrote: > * Adam Borowski <kilob...@angband.pl> wrote: > > > Here's some history: > > The day of -rc1, multiple people immediately reported the breakage; it was > > quickly found out that reverting 784d5699ed

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Adam Borowski
On Tue, Nov 29, 2016 at 07:27:12AM -0800, Linus Torvalds wrote: > On Nov 29, 2016 5:51 AM, "Adam Borowski" <kilob...@angband.pl> wrote: > > > > > > (a) tested > > > > By many people. > > No. > > I've tested the build *without* this,

Re: Linux 4.9: Reported regressions as of Sunday, 2016-12-04

2016-12-05 Thread Adam Borowski
ml > Note: Nothing happened when Adam pinged Michael in > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1276268.html The fix has been accepted and is sitting in kbuild/rc-fixes; I guess Michal wanted to wait for something else to pop up to not bother Linus with excessive one-patch

Re: [RFC, PATCH, v3.9] default exported asm symbols to zero

2016-12-02 Thread Adam Borowski
On Fri, Dec 02, 2016 at 01:40:27PM +0100, Arnd Bergmann wrote: > With binutils-2.16 and before, a weak missing symbol was kept during the > final link, and a missing CRC for an export would lead to that CRC > being treated as zero implicitly. With binutils-2.17, the crc > symbol gets dropped, and

Re: unable to load modules with CONFIG_MODVERSIONS=y after commit 8ab2ae655b

2016-12-06 Thread Adam Borowski
On Tue, Dec 06, 2016 at 08:31:01AM -0500, Jan Stancek wrote: > Starting with 4.9-rc8 / commit 8ab2ae655b ("default exported asm symbols to > zero") > I'm running into issue with kernel built with CONFIG_MODVERSIONS=y > and (older) binutils (binutils-2.25.1-20.base.el7.ppc64le). > > Modules fail

RE: [PATCH v2] watchdog: constify watchdog_info structures

2017-01-03 Thread Adam Thomson
5_wdt_set_timeout(wdt_dev, 0); > } > > -static struct watchdog_info da9055_wdt_info = { > +static const struct watchdog_info da9055_wdt_info = { > .options= WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > .identity = "DA9055 Watchdog", > }; For DA9052 and DA9055: Acked-by: Adam Thomson <adam.thomson.opensou...@diasemi.com>

RE: [PATCH] backlight: da9052: Fix module autoload

2017-01-03 Thread Adam Thomson
ter this patch: > > $ modinfo drivers/video/backlight/da9052_bl.ko | grep alias > alias: platform:da9052-wled3 > alias: platform:da9052-wled2 > alias: platform:da9052-wled1 > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> > --- Acked-by: Adam Thomson <adam.thomson.opensou...@diasemi.com>

[PATCH] ASoC: da7218: Set DAI output pin high impedance when not in use

2016-12-16 Thread Adam Thomson
. This patch updates the AIF_OUT widget to set the DAI output pin of the device as high impedance when not in use. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- sound/soc/codecs/da7218.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/

[PATCH 2/2] vt: make mouse selection of non-ASCII consistent

2017-03-27 Thread Adam Borowski
ot special-case any non-ASCII anymore. Attempts to set these via ioctl will be silently ignored. As an extra bonus, we debloat the kernel by 128 bytes. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- drivers/tty/vt/selection.c | 16 ++-- 1 file changed, 6 insertions(

[PATCH 1/2] vt: set mouse selection word-chars to gpm's default

2017-03-27 Thread Adam Borowski
Since forever, gpm was this code's only user, and it overrides the table on start so the default was never seen -- until Bill Allombert's "consolation" came in. The in-kernel set is "A-Za-z0-9_" which fails to catch typical file names, etc. Let's change this to gpm's conservative default, ie

[PATCH v2 1/2] vt: set mouse selection word-chars to gpm's default

2017-03-27 Thread Adam Borowski
Since forever, gpm was this code's only user, and it overrides the table on start so the default was never seen -- until Bill Allombert's "consolation" came in. The in-kernel set is "A-Za-z0-9_" which fails to catch typical file names, etc. Let's change this to gpm's conservative default, ie

[PATCH v2 2/2] vt: make mouse selection of non-ASCII consistent

2017-03-27 Thread Adam Borowski
ot special-case any non-ASCII anymore. Attempts to set these via ioctl will be silently ignored. As an extra bonus, we debloat the kernel by 128 bytes. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- v2: Got rid of hard-coded array sizes. drivers/tty/vt/selection.c | 16 ++--

[PATCH 0/2] vt: mouse selection word boundaries

2017-03-27 Thread Adam Borowski
Hi! Here's a couple of really low priority fixes to how "word chars" for mouse selection are determined. Patch 1 (adds "-./") is an epitome of "apply if bored": for two decades, only gpm used this, and it always ignored the defaults. Bill Allombert made a second implementation, "consolation",

Re: [PATCH linux-next] tty: Disable default console blanking interval

2017-03-22 Thread Adam Borowski
On Wed, Mar 22, 2017 at 07:50:32AM -0600, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/869017 > > I'm not particularly knowledgable about console issues. Is a blaknking > interval > relevant in a post CRT world ? The argument in the bug description seems > compelling. I have no

Re: sun50i-a64-pinctrl WARN_ON drivers/base/dd.c:349

2017-03-17 Thread Adam Borowski
On Fri, Mar 17, 2017 at 10:44:22AM -0400, Tejun Heo wrote: > On Fri, Mar 17, 2017 at 10:28:34PM +0800, Icenowy Zheng wrote: > > > It's warning that the device has resources associated with it on > > > probe. There gotta be something fishy going on with the probing > > > sequence. How reproducible

Re: linux-next: x86: Unalbe to run x32 processes on the x86_64 kernel

2017-03-20 Thread Adam Borowski
On Mon, Mar 20, 2017 at 04:57:39PM -0700, Andrei Vagin wrote: > We run CRIU tests on linux-next. And today we found that when we start > x32 processes, a kernel bug is triggered: > > [root@fc24 ~]# uname -a > Linux fc24 4.11.0-rc2-next-20170320 #159 SMP Mon Mar 20 16:53:58 PDT > 2017 x86_64

Re: linux-next: x86: Unalbe to run x32 processes on the x86_64 kernel

2017-03-21 Thread Adam Borowski
On Tue, Mar 21, 2017 at 07:45:39AM +0100, Ingo Molnar wrote: > * Andrei Vagin wrote: > > > # first bad commit: [45fc8757d1d2128e342b4e7ef39adedf7752faac] x86: > > Make the GDT remapping read-only on 64-bit > > Just wondering, does the following commit fix it: > >

Re: [PATCHv3] x86/mm: set x32 syscall bit in SET_PERSONALITY()

2017-03-21 Thread Adam Borowski
On Tue, Mar 21, 2017 at 08:47:11PM +0300, Dmitry Safonov wrote: > After my changes to mmap(), its code now relies on the bitness of > performing syscall. According to that, it chooses the base of allocation: > mmap_base for 64-bit mmap() and mmap_compat_base for 32-bit syscall. > It was done by: >

Re: [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems

2017-04-03 Thread Adam Borowski
On Mon, Apr 03, 2017 at 04:09:38PM -0400, Nicolas Pitre wrote: > On Mon, 3 Apr 2017, Adam Borowski wrote: > > > On Mon, Apr 03, 2017 at 08:31:03AM -0700, Andi Kleen wrote: > > > Except for that (and possibly VT) it is unlikely that people really > > > rely on the o

[PATCH 3/4] n_tty: support th, ae and ng runes

2017-04-01 Thread Adam Borowski
relationship to keep alignment, thus you need to write 'þ', 'æ' or 'ŋ' (or uppercase). Unless you're Icelandic, it's easiest to use the Compose key. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- drivers/tty/n_tty.c | 35 +-- 1 file changed, 33 insertions

[PATCH 1/4] n_tty: don't mangle tty codes in OLCUC mode

2017-04-01 Thread Adam Borowski
as of Linux 0.11 and I see it in 0.01 sources (whose images fail to boot for me, I didn't try very hard). It was less of a failure then as the shell didn't produce tty codes for normal operation. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- drivers/tty/n_tty.

[PATCH 2/4] n_tty: use runes rather than uppercase in IUTF8 OLCUC mode

2017-04-01 Thread Adam Borowski
is shared with 'k', I sacrificed period accuracy for usability. 'q' 'v' 'x' are from Medieval runes (12th to 15th centuries). 'x' could use Anglo-Saxon eolhx but that's same glyph (and Unicode codepoint) as Elder Futhark algiz 'z'. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- dri

[PATCH 4/4] n_tty: wrap all OLCUC code in a config option

2017-04-01 Thread Adam Borowski
Setting it to N, beside dropping runes, also disables old-style support for all-caps OLCUC. To get those 40 years old terminals to work, set CONFIG_TTY_RUNES=y which will DTRT when stty iutf8 is off. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- drivers/tty/Kconfi

[GIT PULL] runes

2017-04-01 Thread Adam Borowski
. Meow! -- sorry, ᛗᛖᛟᚹ! Commits up to 14f34ba1d8748f252f941b5bb87efd7b1ed55868 on top of c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201. Adam Borowski (4): n_tty: don't mangle tty codes in OLCUC mode n_tty: use runes rather than

Re: [RFC PATCH 0/3] arm64: queued spinlocks and rw-locks

2017-04-12 Thread Adam Wallis
les changed, 54 insertions(+), 11 deletions(-) > create mode 100644 arch/arm64/include/asm/qrwlock.h > create mode 100644 arch/arm64/include/asm/qspinlock.h > Thanks -- Adam Wallis Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH] btrfs: scrub: use do_div() for 64-by-32 division

2017-04-09 Thread Adam Borowski
On Sun, Apr 09, 2017 at 05:58:54AM +0200, Adam Borowski wrote: > On Sat, Apr 08, 2017 at 11:07:37PM +0200, Adam Borowski wrote: > > Unbreaks ARM and possibly other 32-bit architectures. > > Turns out those "other 32-bit architectures" happen to include i386. >

[PATCH] btrfs: scrub: use do_div() for 64-by-32 division

2017-04-08 Thread Adam Borowski
Unbreaks ARM and possibly other 32-bit architectures. Fixes: 7d0ef8b4d: Btrfs: update scrub_parity to use u64 stripe_len Reported-by: Icenowy Zheng <icen...@aosc.io> Signed-off-by: Adam Borowski <kilob...@angband.pl> --- You'd probably want to squash this with Liu's commit, to be ni

Re: Linux next-20170407 failed to build on ARM due to usage of mod in btrfs code

2017-04-08 Thread Adam Borowski
On Sat, Apr 08, 2017 at 02:45:34PM -0300, Fabio Estevam wrote: > On Sat, Apr 8, 2017 at 1:02 PM, Icenowy Zheng wrote: > > Hello everyone, > > Today I tried to build a kernel with btrfs enabled on ARM, then when linking > > I met such an error: > > > > ``` > > fs/built-in.o: In

Re: [PATCH] btrfs: scrub: use do_div() for 64-by-32 division

2017-04-08 Thread Adam Borowski
On Sat, Apr 08, 2017 at 11:07:37PM +0200, Adam Borowski wrote: > Unbreaks ARM and possibly other 32-bit architectures. Turns out those "other 32-bit architectures" happen to include i386. A modular build: ERROR: "__udivdi3" [fs/btrfs/btrfs.ko] undefined! With the

Re: [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems

2017-04-03 Thread Adam Borowski
On Mon, Apr 03, 2017 at 08:31:03AM -0700, Andi Kleen wrote: > Except for that (and possibly VT) it is unlikely that people really > rely on the obsolete terminal features from the 70ies. So it's a kind > of cleanup. But... but... but what shall we do without OLCUC?!? I guess sending these

Re: [RFC 0/9] ARMv8.3 pointer authentication userspace support

2017-04-07 Thread Adam Wallis
> include/uapi/linux/elf.h | 1 + > 21 files changed, 454 insertions(+), 7 deletions(-) > create mode 100644 Documentation/arm64/pointer-authentication.txt > create mode 100644 arch/arm64/include/asm/pointer_auth.h > Tested on Qualcomm platf

MikeeUSA warning (Re: Yes you have standing to sue GRSecurity.)

2017-07-29 Thread Adam Borowski
Note that this is quite clearly yet another of MikeeUSA's sockpuppets. And you guys really don't want to be caught in another of his troll threads. Yeah, GRsecurity is a problem, but don't let our dear Mikee milk it. -- ⢀⣴⠾⠻⢶⣦⠀ What Would Jesus Do, MUD/MMORPG edition: ⣾⠁⢰⠒⠀⣿⡁ • multiplay with

Re: Problematic culture around Signed-off-by

2017-07-31 Thread Adam Borowski
On Sun, Jul 30, 2017 at 08:52:36PM +0200, Pavel Machek wrote: > > I've been away from kernel development for a bit, but I've returned and > > I'm troubled by what seems to be an entrenched and widespread (IMO) > > misuse of the "Signed-off-by:" in commits. > > > > I've now either been asked to

Re: [virtio-dev] [PATCH v13 0/5] Virtio-balloon Enhancement

2017-08-15 Thread Adam Tao
we need to add one command queue for the common purpose(including different type of requests except the in/deflate ones)? Thanks Adam > The second feature can be used to accelerate live migration of VMs. Here > are some details: > > Live migration needs to transfer the VM's

Re: [PATCH v5 3/5] btrfs: Add zstd support

2017-08-10 Thread Adam Borowski
On Wed, Aug 09, 2017 at 07:39:02PM -0700, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. Re-tested on arm64, amd64 and i386, this time everything seems fine so far. As I'm too lazy to have a separate test setup for the zlib level patch, I'm using a dummy

Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-07-11 Thread Adam Borowski
On Tue, Jul 11, 2017 at 06:01:38AM +, Nick Terrell wrote: > On 7/10/17, 9:57 PM, "Nick Terrell" wrote: > > The problem is caused by a gcc-7 bug [1]. It miscompiles > > ZSTD_wildcopy(void *dst, void const *src, ptrdiff_t len) when len is 0. > > Sorry, my patch still triggered

Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-07-07 Thread Adam Borowski
On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: > On 7/6/17, 9:32 AM, "Adam Borowski" <kilob...@angband.pl> wrote: > > Got a reproducible crash on amd64: > > > > [98235.266511] BUG: unable to handle kernel paging request at &g

Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-07-07 Thread Adam Borowski
On Sat, Jul 08, 2017 at 01:40:18AM +0200, Adam Borowski wrote: > On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: > > On 7/6/17, 9:32 AM, "Adam Borowski" <kilob...@angband.pl> wrote: > > > Got a reproducible crash on amd64: > > >

nbd drops connection on most writes

2017-07-21 Thread Adam Borowski
Hi! I'm afraid that 4.13-rc1 nbd aborts connection on writes for me: [ 251.938384] block nbd0: Send data failed (result -11) [ 251.943484] block nbd0: Request send failed trying another connection [ 251.950034] block nbd0: Receive control failed (result -32) [ 251.955676] block nbd0:

Re: nbd drops connection on most writes

2017-07-21 Thread Adam Borowski
On Fri, Jul 21, 2017 at 12:22:51PM +, Josef Bacik wrote: > Oh shit the default timeout is 0 if you don't set it in the client. Use > the timeout option with nbd client and it should fix it for you. I'll > send something up to make this a sane default. Confirmed, adding a timeout=XXX

Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards

2017-07-24 Thread Adam Borowski
On Tue, Jul 25, 2017 at 11:04:24AM +0800, icen...@aosc.io wrote: > 在 2017-07-24 15:58,Maxime Ripard 写道: > > On Sat, Jul 22, 2017 at 10:28:49AM +0800, Icenowy Zheng wrote: > > > Allwinner A64 SoC has an EMAC which is used to provide Ethernet > > > function on several boards. > > > > > > The EMAC

Re: [PATCH v3 0/4] Add xxhash and zstd modules

2017-07-22 Thread Adam Borowski
On Fri, Jul 21, 2017 at 11:56:21AM -0400, Austin S. Hemmelgarn wrote: > On 2017-07-20 17:27, Nick Terrell wrote: > > This patch set adds xxhash, zstd compression, and zstd decompression > > modules. It also adds zstd support to BtrFS and SquashFS. > > > > Each patch has relevant summaries,

Re: [PATCH] lib/zstd: use div_u64() to let it build on 32-bit

2017-06-28 Thread Adam Borowski
On Tue, Jun 27, 2017 at 05:27:51AM +, Nick Terrell wrote: > Adam, I’ve applied the same patch in my tree. I’ll send out the update [1] > once it's reviewed, since I also reduced the stack usage of functions > using over 1 KB of stack space. > > I have userland tests set up mo

Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-06-29 Thread Adam Borowski
On Thu, Jun 29, 2017 at 12:41:07PM -0700, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. zstd at its > fastest level compresses almost as well as zlib, while offering much > faster compression and decompression, approaching lzo speeds. > +static int

Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-07-06 Thread Adam Borowski
On Thu, Jun 29, 2017 at 12:41:07PM -0700, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. zstd at its > fastest level compresses almost as well as zlib, while offering much > faster compression and decompression, approaching lzo speeds. Got a reproducible crash on

Re: sun50i-a64-pinctrl WARN_ON drivers/base/dd.c:349

2017-04-29 Thread Adam Borowski
On Fri, Apr 28, 2017 at 06:03:14PM -0400, Tejun Heo wrote: > On Tue, Apr 18, 2017 at 10:12:16AM +0100, Andre Przywara wrote: > > Yeah, so I stack-dumped on the zero allocations and indeed they are > > called from cleanup functions: > > drivers/pinctrl/pinmux.c:pinmux_generic_free_functions(): > >

Re: [PATCH] fbcon: Use background color for margins

2017-07-31 Thread Adam Borowski
On Mon, Jul 31, 2017 at 12:25:28PM -0500, David Lechner wrote: > On 07/30/2017 04:51 PM, Pavel Machek wrote: > > > > > Screens that don't have a black border around the active area will > > > > > have > > > > > ugly black bars for the margin when the text background color is not > > > > > black.

kvm splat in mmu_spte_clear_track_bits

2017-08-20 Thread Adam Borowski
Hi! I'm afraid I keep getting a quite reliable, but random, splat when running KVM: [ cut here ] WARNING: CPU: 5 PID: 5826 at arch/x86/kvm/mmu.c:717 mmu_spte_clear_track_bits+0x123/0x170 Modules linked in: tun nbd arc4 rtl8xxxu mac80211 cfg80211 rfkill nouveau video ttm

[PATCH] ASoC: da7213: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Adam Thomson
ncy. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- sound/soc/codecs/da7213.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c index 12da558..d114f33 100644 --- a/sound/soc/codecs/da7213.c +++

[PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Adam Thomson
ncy. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- sound/soc/codecs/da7218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index d256ebf..6e1940e 100644 --- a/sound/soc/codecs/da7218.c +++

RE: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Adam Thomson
On 03 May 2017 15:10, Takashi Sakamoto wrote: > On May 3 2017 22:54, Adam Thomson wrote: > > In the SRM lock check section of code the '&' bitwise operator is > > used as part of checking lock status. Functionally the code works > > as intended, but the condition

[PATCH] Fixed a pathing issue with objdump and grep

2017-05-03 Thread Adam Stylinski
The path fed to the argument for objdump used in the perf-annotate feature didn't escape spaces. The subsequent argument to grep for the name of the DSO containing symbols also assumed no spaces existed in the pathname, so grep also parsed these as extra positional arguments. Signed-off-by: Adam

Re: [git pull] uaccess-related bits of vfs.git

2017-05-13 Thread Adam Borowski
On Sat, May 13, 2017 at 07:57:45AM +0100, Al Viro wrote: > On Fri, May 12, 2017 at 06:00:44PM -0700, Linus Torvalds wrote: > > But the *first* thing I'd like to do would be to just get rid of > > __get_user/__put_user as a thing. It really does generate nasty code, > > and we might as well just

[PATCH] lib/zstd: use div_u64() to let it build on 32-bit

2017-06-26 Thread Adam Borowski
ted to 2³²-1 elsewhere despite being declared as size_t, so it's ok to use 64/32 -- it's much faster on eg. x86-32 than 64/64. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- lib/zstd/fse_compress.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/zst

Re: [PATCH 3/4] btrfs: Add zstd support

2017-06-25 Thread Adam Borowski
On Mon, Jun 26, 2017 at 03:03:17AM +0800, kbuild test robot wrote: > Hi Nick, > > url: > https://github.com/0day-ci/linux/commits/Nick-Terrell/lib-Add-xxhash-module/20170625-214344 > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce:

Re: [RFC PATCH] fs: block dev aio request priority support

2017-05-23 Thread Adam Manzanares
The 05/23/2017 10:46, Jan Kara wrote: > On Mon 22-05-17 10:19:33, adam.manzana...@wdc.com wrote: > > From: Adam Manzanares <adam.manzana...@wdc.com> > > > > Map the aio_reqprio to the bio priority field at > > the point the bio is created from the aio iocb. >

[PATCH] ASoC: da7213: Update driver to use device_property* FW functions

2017-05-19 Thread Adam Thomson
to use device_property* calls instead so that both ACPI and DT are handled as expected. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- sound/soc/codecs/da7213.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a

[RESEND PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-23 Thread Adam Thomson
ncy. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Reviewed-by: Takashi Sakamoto <o-taka...@sakamocchi.jp> --- sound/soc/codecs/da7218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index

Re: [PATCH 0/2] blackfin: Remove dead DSA code

2017-05-29 Thread Adam Borowski
On Sun, May 28, 2017 at 04:59:47PM -0700, Florian Fainelli wrote: > Hello? anyone still maintaining blackfin here? Looks like people edit arch/blackfin/ a lot whenever it interferes with some other work, but the only blackfin-specific fixes seem to be a couple of drive-by ones by Al Viro, then

[PATCH 0/5] vt: get rid of worst cases of __put_user/__get_user

2017-06-03 Thread Adam Borowski
a few patches applying the lessons from that discussion to vt. None of the uses is performance-critical, but at least we get a nice bit of code simplification. And, it's a start of manual review + conversion that Al Viro wants. Adam Borowski (5): vt: use copy_from/to_user instead of __get

[PATCH] vt: fix \e[2m using the wrong placeholder color on graphical consoles

2017-06-03 Thread Adam Borowski
Only vgacon and sisusbcon did it right, the rest (via generic code) tried underline (usually cyan). Signed-off-by: Adam Borowski <kilob...@angband.pl> --- Compare this if clause with the two above it. Nice copypaste. :) drivers/tty/vt/vt.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 5/5] vt: drop access_ok() calls in unimap ioctls

2017-06-03 Thread Adam Borowski
Done by copy_{from,to}_user(). Signed-off-by: Adam Borowski <kilob...@angband.pl> --- drivers/tty/vt/vt_ioctl.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c index 0cbfe1ff6f6c..96d389cb506c 100644 --- a/drivers/tty/vt/vt_i

[PATCH 2/5] vt: fix unchecked __put_user() in tioclinux ioctls

2017-06-03 Thread Adam Borowski
in the future. If anyone cares about 3.7 and earlier, this is a security hole (untested) on real 80386 CPUs. Signed-off-by: Adam Borowski <kilob...@angband.pl> CC: sta...@vger.kernel.org # v3.7- --- drivers/tty/vt/vt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

[PATCH 3/5] vt: use copy_to_user instead of __put_user in GIO_UNIMAP ioctl

2017-06-03 Thread Adam Borowski
A nice big linear transfer, no need to flip stac/PAN/etc every half-entry. Also, yay __put_user() after checking only read. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- drivers/tty/vt/consolemap.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff

[PATCH 1/5] vt: use copy_from/to_user instead of __get/put_user for scrnmap ioctls

2017-06-03 Thread Adam Borowski
Linus wants to get rid of these functions, and these uses are especially egregious: they copy a big linear array element by element. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- drivers/tty/vt/consolemap.c | 31 +++ 1 file changed, 7 insertions(

[PATCH 4/5] vt: use memdup_user in PIO_UNIMAP ioctl

2017-06-03 Thread Adam Borowski
Again, a nice linear transfer that simplifies the code. Signed-off-by: Adam Borowski <kilob...@angband.pl> --- drivers/tty/vt/consolemap.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c index c6a692

Re: [PATCH] checkpatch: Change format of --color argument to --color[=WHEN]

2017-06-05 Thread Adam Borowski
On Mon, Jun 05, 2017 at 04:10:30PM -0700, Joe Perches wrote: > On Mon, 2017-06-05 at 18:27 -0400, John Brooks wrote: > > The boolean --color argument did not offer the ability to force colourized > > output even if stdout is not a terminal. > > OK, but why is colorizing output not to terminals

[PATCH 2/2] ASoC: Intel: bxt: Move codec sysclk config to codec_init function

2017-06-19 Thread Adam Thomson
does not have the correct MCLK rates programmed and so the HP detection feature does not operate as expected. This patch rectifies this issue by moving the sysclk call to codec_init function so it's only called once at initialisation. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.

[PATCH 0/2] ASoC: da7219: Resolve HP detect issues relating to MCLK

2017-06-19 Thread Adam Thomson
The patch set resolves issues in the HP detect feature, relating to MCLK, where the feature can misdetect headphones as lineout. Adam Thomson (2): ASoC: da7219: Fix HP detection procedure for all MCLK frequencies ASoC: Intel: bxt: Move codec sysclk config to codec_init function sound/soc

[PATCH 1/2] ASoC: da7219: Fix HP detection procedure for all MCLK frequencies

2017-06-19 Thread Adam Thomson
consistent timings for the procedure, regardless of MCLK frequency. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by: Sathyanarayana Nujella <sathyanarayana.nuje...@intel.com> --- sound/soc/codecs/da7219-aad.c | 31 +++-- sound/soc/cod

[PATCH] Fixed issue in perf annotate with unescaped spaces

2017-05-05 Thread Adam Stylinski
Perf annotate was calling both objdump and grep with arguments that didn't escape spaces, causing perf annotate to fail on DSOs which had spaces in their paths. This wraps those arguments in quotes. ---  tools/perf/util/annotate.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: Linux 4.14: Reported regressions as of Sunday, 2017-10-08

2017-10-08 Thread Adam Borowski
On Sun, Oct 08, 2017 at 02:37:41PM +0200, Thorsten Leemhuis wrote: > Hi! Find below my second regression report for Linux 4.14. It lists 8 > regressions I'm currently aware of. One regression was fixed since last > weeks report. One was in there that shouldn't have been there. > > == Current

[PATCH] vfs: hard-ban creating files with control characters in the name

2017-10-02 Thread Adam Borowski
st write * many filesystems already disallow certain characters (like invalid Unicode), thus returning an error is consistent An example of a write-up of this issue can be found at: https://www.dwheeler.com/essays/fixing-unix-linux-filenames.html Signed-off-by: Adam Borowski <kilob...@angband.pl&

Re: [PATCH] vfs: hard-ban creating files with control characters in the name

2017-10-02 Thread Adam Borowski
On Tue, Oct 03, 2017 at 03:07:24AM +0100, Al Viro wrote: > On Tue, Oct 03, 2017 at 02:50:42AM +0200, Adam Borowski wrote: > > Anything with bytes 1-31,127 will get -EACCES. > > > > Especially \n is bad: instead of natural file-per-line, you need an > > user-unfriend

Re: [PATCH v2 0/5] Switch arm64 over to qrwlock

2017-10-10 Thread Adam Wallis
ns of readers:writers . These patches help prevent writer starvation in every combination that I tested. Without these patches, when the reader:writer ratio is 2:1, it's trivial for me to see acquisitions of 250:1 (@ 2R:1W). After applying the qrwlock patches, I see the acquisition ratios level out to aro

Re: [PATCH v3 0/5] Switch arm64 over to qrwlock

2017-10-12 Thread Adam Wallis
| 86 +++-- > 9 files changed, 61 insertions(+), 272 deletions(-) > Will, I see the same performance improvements that I was getting in v2 of the patch. I will continue to run these patches on multiple systems over the next few weeks, months for stability/functionality testing

Re: [PATCH 2/2] zram: remove zlib from the list of recommended algorithms

2017-09-13 Thread Adam Borowski
On Wed, Sep 13, 2017 at 04:12:46PM +0900, Minchan Kim wrote: > On Tue, Sep 12, 2017 at 02:00:05PM +0900, Sergey Senozhatsky wrote: > > ZSTD tends to outperform deflate/inflate, thus we remove > > zlib from the list of recommended algorithms and recommend > > zstd instead. > > I did test with my

<    4   5   6   7   8   9   10   11   12   13   >