Re: unknown NMI on AMD Rome

2021-03-16 Thread Adam Borowski
On Tue, Mar 16, 2021 at 04:45:02PM +0100, Jiri Olsa wrote: > hi, > when running 'perf top' on AMD Rome (/proc/cpuinfo below) > with fedora 33 kernel 5.10.22-200.fc33.x86_64 > > we got unknown NMI messages: > > [ 226.700160] Uhhuh. NMI received for unknown reason 3d on CPU 90. > [ 226.700162] Do

Re: [PATCH v2 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax

2021-03-13 Thread Adam Borowski
On Sat, Mar 13, 2021 at 11:24:00AM -0500, Neal Gompa wrote: > On Sat, Mar 13, 2021 at 8:09 AM Adam Borowski wrote: > > > > On Wed, Mar 10, 2021 at 02:26:43PM +, Matthew Wilcox wrote: > > > On Wed, Mar 10, 2021 at 08:21:59AM -0600, Goldwyn Rodrigues wrote: >

Re: [PATCH v2 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax

2021-03-13 Thread Adam Borowski
On Wed, Mar 10, 2021 at 02:26:43PM +, Matthew Wilcox wrote: > On Wed, Mar 10, 2021 at 08:21:59AM -0600, Goldwyn Rodrigues wrote: > > DAX on btrfs has been attempted[1]. Of course, we could not > > But why? A completeness fetish? I don't understand why you decided > to do this work. * xfs ca

MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

2021-03-09 Thread Adam Borowski
On Tue, Mar 09, 2021 at 08:39:10PM +0100, Pavel Machek wrote: > > I'd like people from Intel to contact me. There's more to fix there, > > and AFAICT original author went away. > > The following message to was > undeliverable. > : Recipient > +address rejected: User unknown in virtual mailbox ta

Re: TLS for 5.10

2021-02-08 Thread Adam Borowski
On Mon, Feb 08, 2021 at 07:08:05AM +, Wadepohl, Wolfram wrote: > I'm sad to hear that 5.10 has still an EOL of Dec, 2022. We are in > development of our 1st GNU/Linux based System, 50k devices for IoT. [...] > In general a 2 year support for embedded systems in automation is not a > reasonable

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-01-26 Thread Adam Borowski
On Mon, Jan 25, 2021 at 11:55:11AM -0800, Scott Branden wrote: > The 5.10 LTS kernel being officially LTS supported for 2 years presents a > problem: > why would anyone select a 5.10 kernel with 2 year LTS when 5.4 kernel has a 6 > year LTS. > > Yet, various unofficial reports indicate it will b

Re: Linux 5.11-rc1

2021-01-03 Thread Adam Borowski
On Sun, Jan 03, 2021 at 05:45:16PM +, David Laight wrote: > From: Ilkka Prusi > > Note that /sbin is now just a symlink to /usr/sbin on Debian since 10 > > (Buster) as per FHS[1][2]. > > > > [1] https://wiki.linuxfoundation.org/lsb/fhs > > [2] > > https://arstechnica.com/information-technolo

Re: [PATCH] tty: Remove dead termiox code

2020-12-07 Thread Adam Borowski
On Fri, Dec 04, 2020 at 10:10:16AM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 04, 2020 at 09:51:07AM +0100, Jiri Slaby wrote: > > > > > On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: > > > > > > On 03. 12. 20, 3:03, Jann Horn wrote: > > > > > > > Delete this dead code; but leave th

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-25 Thread Adam Borowski
On Fri, Sep 25, 2020 at 11:27:54AM +0200, Greg KH wrote: > On Thu, Sep 24, 2020 at 08:21:07PM +0200, Thomas Gleixner wrote: > > On Thu, Sep 24 2020 at 08:33, Greg KH wrote: > > > On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote: > > >> +config CONSOLE_FLUSH_ON_HOTPLUG > > >> +

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2020-09-18 Thread Adam Borowski
On Wed, Sep 16, 2020 at 10:54:34PM +0200, Pavel Machek wrote: > On Mon 2020-09-14 18:28:34, Linus Torvalds wrote: > > Note that scrollback hasn't actually gone away entirely - the original > > scrollback supported by _hardware_ still exists. > > > > Of course, that's really just the old-fashioned

build failure: aicasm: renamed yaccage

2020-08-22 Thread Adam Borowski
Hi! My randconfig builds notoriously fail on this: [~/linux/drivers/scsi/aic7xxx/aicasm](vanilla)$ make -j1 bison -d -b aicasm_gram aicasm_gram.y mv aicasm_gram.tab.c .//aicasm_gram.c mv aicasm_gram.tab.h .//aicasm_gram.h bison -d -b aicasm_macro_gram -p mm aicasm_macro_gram.y mv aicasm_macro_gram

Re: [PATCH] x86/pci: don't set acpi stuff if !CONFIG_ACPI

2020-08-21 Thread Adam Borowski
On Fri, Aug 21, 2020 at 10:13:25PM +0200, Thomas Gleixner wrote: > On Thu, Aug 20 2020 at 14:53, Adam Borowski wrote: > > Found by randconfig builds. > > > > arch/x86/pci/intel_mid_pci.c | 2 ++ > > arch/x86/pci/xen.c | 2 ++ > > --- a/arch/x86/pci/intel

Re: [PATCH v10 4/8] usr: add support for zstd compressed initramfs

2020-08-04 Thread Adam Borowski
On Tue, Aug 04, 2020 at 09:25:23AM +0200, Sedat Dilek wrote: > On Tue, Aug 4, 2020 at 8:52 AM Geert Uytterhoeven > wrote: > > On Thu, Jul 30, 2020 at 9:13 PM Nick Terrell wrote: > > > From: Nick Terrell > > > * Add support for a zstd compressed initramfs. > > > * Add compression for compressing

Re: [PATCH v8 6/7] x86: Add support for ZSTD compressed kernel

2020-07-24 Thread Adam Borowski
On Fri, Jul 24, 2020 at 02:26:40PM +0200, Ingo Molnar wrote: > > -#ifdef CONFIG_KERNEL_BZIP2 > > +#if defined(CONFIG_KERNEL_BZIP2) > > # define BOOT_HEAP_SIZE0x40 > > -#else /* !CONFIG_KERNEL_BZIP2 */ > > +#elif defined(CONFIG_KERNEL_ZSTD) > > +# define BOOT_HEAP_SIZE 0

Re: [PATCH] kbuild: fix broken builds because of GZIP,BZIP2,LZOP variables

2020-06-08 Thread Adam Borowski
On Mon, Jun 08, 2020 at 12:59:44PM +0300, Denis Efremov wrote: > Redefine GZIP, BZIP2, LZOP variables as KGZIP, KBZIP2, KLZOP resp. > GZIP, BZIP2, LZOP env variables are reserved by the tools. The original > attempt to redefine them internally doesn't work in makefiles/scripts > intercall scenarios

Re: boot failure: stack-protector: Kernel stack is corrupted in: start_secondary

2020-04-28 Thread Adam Borowski
On Tue, Apr 28, 2020 at 09:45:27AM +0200, Borislav Petkov wrote: > On Tue, Apr 21, 2020 at 03:32:34AM +0200, Adam Borowski wrote: > > Hi! > > With kernels compiled with gcc-10, on two different machines (AMD Phenom2, > > AMD 2990WX) I get the following panic during boot: >

Re: Stop breaking the CSRNG

2019-10-03 Thread Adam Borowski
On Thu, Oct 03, 2019 at 10:13:39AM +, David Laight wrote: > From: Kurt Roeckx > > Sent: 02 October 2019 17:56 > > As OpenSSL, we want cryptograhic secure random numbers. Before > > getrandom(), Linux never provided a good API for that, both > > /dev/random and /dev/urandom have problems. getran

[PATCH] Documentation: sysrq: don't recommend 'S' 'U' before 'B'

2019-09-03 Thread Adam Borowski
shutdown meant widespread breakage, but it's no longer a reasonable filesystem for any non-special use. Signed-off-by: Adam Borowski --- Documentation/admin-guide/sysrq.rst | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/Documentation/admin-guide/sysr

Re: [PATCH v3 0/8] AMD64 EDAC fixes

2019-08-22 Thread Adam Borowski
On Thu, Aug 22, 2019 at 10:35:48AM +0200, Borislav Petkov wrote: > On Thu, Aug 22, 2019 at 02:50:20AM +0200, Adam Borowski wrote: > > While you're editing that code, could you please also cut the spam if ECC is > > actually disabled? For example, a 2990WX with non-ECC

Re: [PATCH v3 0/8] AMD64 EDAC fixes

2019-08-21 Thread Adam Borowski
On Wed, Aug 21, 2019 at 11:59:53PM +, Ghannam, Yazen wrote: > I've also added RFC patches to avoid the "ECC disabled" message for > nodes without memory. I haven't fully tested these, but I wanted to get > your thoughts. Here's an earlier discussion: > https://lkml.kernel.org/r/20180321191335.7

Re: Device to write to all (serial) consoles

2019-08-03 Thread Adam Borowski
On Sat, Aug 03, 2019 at 03:55:37PM +0200, Greg Kroah-Hartman wrote: > On Sat, Aug 03, 2019 at 03:23:23PM +0200, Adam Borowski wrote: > > On Fri, Aug 02, 2019 at 09:59:06PM +0200, Paul Menzel wrote: > > > Because the cable is always connected to the port on the back side, and &

Re: Device to write to all (serial) consoles

2019-08-03 Thread Adam Borowski
On Fri, Aug 02, 2019 at 09:59:06PM +0200, Paul Menzel wrote: > On 02.08.19 18:02, Greg Kroah-Hartman wrote: > > On Fri, Aug 02, 2019 at 03:23:08PM +0200, Paul Menzel wrote: > > > On a lot of devices, like servers, you have more than one serial console, > > > and you do not always know, how they are

Re: [RFC] remove arch/sh?

2019-06-25 Thread Adam Borowski
On Tue, Jun 25, 2019 at 11:02:36AM +0200, John Paul Adrian Glaubitz wrote: > On 6/25/19 10:56 AM, Christoph Hellwig wrote: > > arch/sh seems pretty much unmaintained these days. The last time I got > > any reply to sh patches from the list maintainers, and the last maintainer > > pull request was

Re: [RESEND PATCH v2 0/2] Add support for ZSTD-compressed kernel

2019-06-07 Thread Adam Borowski
On Fri, Jun 07, 2019 at 07:20:46PM +, Nick Terrell wrote: > We'd love to get this mainlined as well! > > We're using these patches internally as well. We're seeing an improvement on > an > Intel Atom N3710, where boot time is reduced by one second over using an xz > compressed kernel. It look

Re: [PATCH RFC 0/5] mm: process_vm_mmap() -- syscall for duplication a process mapping

2019-05-16 Thread Adam Borowski
On Thu, May 16, 2019 at 04:10:07PM +0300, Kirill Tkhai wrote: > On 15.05.2019 22:38, Adam Borowski wrote: > > On Wed, May 15, 2019 at 06:11:15PM +0300, Kirill Tkhai wrote: > >> This patchset adds a new syscall, which makes possible > >> to clone a mapping from a

Re: [PATCH RFC 0/5] mm: process_vm_mmap() -- syscall for duplication a process mapping

2019-05-15 Thread Adam Borowski
On Wed, May 15, 2019 at 06:11:15PM +0300, Kirill Tkhai wrote: > This patchset adds a new syscall, which makes possible > to clone a mapping from a process to another process. > The syscall supplements the functionality provided > by process_vm_writev() and process_vm_readv() syscalls, > and it may

Re: [PATCH RESEND v5 0/5] namei: vfs flags to restrict path resolution

2019-04-25 Thread Adam Borowski
On Thu, Apr 25, 2019 at 01:38:06AM +1000, Aleksa Sarai wrote: > * openat(2) ignores unknown flags, meaning that old kernels will ignore >new programs trying to use O_THISROOT and might end up causing >security issues. Yes, it'd be trivial to check whether the new O_* >flags are support

Re: How to turn off IPv4 without disabling IPv6

2019-04-25 Thread Adam Borowski
On Thu, Apr 25, 2019 at 11:32:38AM +0200, Nico Schottelius wrote: > running some IPv6 only > networks. The systems in the IPv6 only networks do not need any IPv4 > support anymore and thus for switches/routers we turned the support off. > Today we tried to turn off IPv4 in the Linux kernel at comp

Re: Staging status of speakup

2019-03-19 Thread Adam Borowski
On Tue, Mar 19, 2019 at 04:31:21PM +, Alan Cox wrote: > On Sat, 16 Mar 2019 10:35:43 +0100 > Samuel Thibault wrote: > > Chris Brannon, le ven. 15 mars 2019 18:19:39 -0700, a ecrit: > > > What kind of reproducer do you need here? It's straightforward to > > > reproduce in casual use, at least

Re: [PATCH] selftests/ftrace: Make the coloring POSIX compliant

2019-02-20 Thread Adam Borowski
On Wed, Feb 20, 2019 at 09:20:20PM +0100, Juerg Haefliger wrote: > On Wed, 20 Feb 2019 14:49:34 -0500 > Steven Rostedt wrote: > > > On Wed, 20 Feb 2019 17:13:33 +0100 > > Juerg Haefliger wrote: > > > > > echo -e and \e are not POSIX. Depending on what /bin/sh is, we can get > > > incorrect outp

Re: GRSec is vital to Linux security

2019-01-24 Thread Adam Borowski
On Thu, Jan 24, 2019 at 04:31:10PM +0100, Enrico Weigelt, metux IT consult wrote: > On 23.01.19 21:46, Ivan Ivanov wrote: > > > Linux really needs to stop adding new features and > > refactor itself to a smaller and more secure codebase before going > > forward. Maybe 1 year break would be nice.

[PATCH] doc: process: GPL -> GPL-compatible

2019-01-22 Thread Adam Borowski
Drivers under MIT, BSD-17-clause, or uncle-Bob's-newest-take-on-PD are all fine, not just GPL. Signed-off-by: Adam Borowski --- Not reformatting to fill lines, it'll semi-conflict with another patch that's been acked but not yet pushed. Documentation/process/stable-api-nonsense

Re: [PATCH] mm/mmu_notifier: mm/rmap.c: Fix a mmu_notifier range bug in try_to_unmap_one

2019-01-10 Thread Adam Borowski
r patch, no badness happened so far. Thanks! > Reported-by: Adam Borowski > Fixes: ac46d4f3c432 ("mm/mmu_notifier: use structure for > invalidate_range_start/end calls v2") > --- a/mm/rmap.c > +++ b/mm/rmap.c > - mmu_notifier_range_init(&range, vma->vm_mm,

Re: 5.0-rc1 KVM inspired "BUG: Bad page state in process" spew

2019-01-09 Thread Adam Borowski
On Wed, Jan 09, 2019 at 06:38:58AM +0100, Mike Galbraith wrote: > KVM seems to be busted in master ATM. All I have to do to have host > start screaming and maybe exploding (if the guest doesn't do so first) > is to try to install a (obese in this case) kernel over nfs mount of > the host in a gues

Re: Can we drop upstream Linux x32 support?

2018-12-13 Thread Adam Borowski
On Thu, Dec 13, 2018 at 10:37:31AM +0100, Sven Hartrumpf wrote: > Will the proposed patch ("only") remove the possibility to build x32 kernels > or will it make impossible to compile and run any x32 binaries? There's no such thing as x32 kernels. It's an ABI atop amd64 kernels; the kernel is alwa

Re: Official Linux system wrapper library?

2018-11-14 Thread Adam Borowski
On Sun, Nov 11, 2018 at 12:46:35PM +0100, Florian Weimer wrote: > A lot of multi-threaded applications assume that most high-level > functionality remains usable even after fork in a multi-threaded > process. How would this be even possible? Currently fork kills all threads (save for the caller).

[PATCH 01/17] lib: Add support for ZSTD-compressed kernel

2018-11-09 Thread Adam Borowski
From: Nick Terrell Add support for extracting ZSTD-compressed kernel images, as well as ZSTD-compressed ramdisk images in the kernel boot process. When neither `fill' nor `flush' are used, the decompression function requires a constant amount of memory (192 KB is sufficient). When either is used

[PATCH 16/17] Kconfig: Update the prose for selection of compression algorithm

2018-11-09 Thread Adam Borowski
It was really obsolete, and some entries contradicted each other. Let's not recommend ZSTD for kernel compression yet as it's available only on x86, and some distros might not have the tool installed. Proposing ZSTD for initrd is safer but let's test it first. Signed-off-by

drivers by default (was Re: Another HID problem this merge window..)

2018-10-28 Thread Adam Borowski
On Sat, Oct 27, 2018 at 11:13:17AM -0700, Linus Torvalds wrote: > Ok, so this is a much smaller issue than the i2c one that cause boot > problems, but it's annoying. > > We do *not* enable new random drivers by default. And we most > *definitely* don't do it when they are odd-ball ones that most p

[tip:x86/build] x86/defconfig: Enable CONFIG_USB_XHCI_HCD=y

2018-10-09 Thread tip-bot for Adam Borowski
Commit-ID: 72a9c673636b779e370983fea08e40f97039b981 Gitweb: https://git.kernel.org/tip/72a9c673636b779e370983fea08e40f97039b981 Author: Adam Borowski AuthorDate: Tue, 9 Oct 2018 08:28:03 +0200 Committer: Ingo Molnar CommitDate: Wed, 10 Oct 2018 08:29:51 +0200 x86/defconfig: Enable

Re: Contributors can not just rescind the license (Legal Opinion)

2018-09-28 Thread Adam Borowski
On Fri, Sep 28, 2018 at 11:31:32AM +0200, www.Advocati.org wrote: > CONTRIBUTORS CAN NOT JUST RESCIND THE LICENSE > THEY GRANTED UNDER GPLv2. IT IS *COPYLEFTED* > A letter from 17.09.2018 by @observerofaffairs > titled 'GPL version 2 is a bare license. Recind. (Regarding (future) > Code of Conduct

Re: POSIX violation by writeback error

2018-09-25 Thread Adam Borowski
On Tue, Sep 25, 2018 at 11:46:27AM -0400, Theodore Y. Ts'o wrote: > P.S. One thought: it might be cool if there was some way for > userspace applications to mark files with "nuke if not closed" flag, > such that if the system crashes, the file systems would automatically > unlink the file after a

Re: [...] an apology, and a maintainership note

2018-09-16 Thread Adam Borowski
On Sun, Sep 16, 2018 at 12:22:43PM -0700, Linus Torvalds wrote: > This is my reality. I am not an emotionally empathetic kind of person > and that probably doesn't come as a big surprise to anybody. Least of > all me. The fact that I then misread people and don't realize (for > years) how badly

Re: Kernel-only deployments?

2018-08-23 Thread Adam Borowski
On Thu, Aug 23, 2018 at 10:43:59AM -0700, Paul E. McKenney wrote: > The mkinitramfs approach results in about 40MB of initrd, and dracut > about 10MB. Most of this is completely useless for rcutorture, which > isn't interested in mounting filesystems, opening devices, and almost > all of the other

Re: linux-next: build warnings from Linus' tree

2018-08-19 Thread Adam Borowski
On Sun, Aug 19, 2018 at 04:21:57PM -0700, Linus Torvalds wrote: > On Sun, Aug 19, 2018 at 3:13 PM Stephen Rothwell > wrote: > > > > Today's linux-next build (powerpc ppc64_defconfig) produced these > > warnings: > > > > fs/cifs/cifssmb.c:605:3: warning: 'strncpy' writing 16 bytes into a region >

Re: [RESEND PATCH v2 0/2] Add support for ZSTD-compressed kernel

2018-08-17 Thread Adam Borowski
On Fri, Aug 17, 2018 at 12:22:44PM -0700, Andi Kleen wrote: > On Fri, Aug 17, 2018 at 07:57:46PM +0200, Adam Borowski wrote: > > > The "favourite compressor" seems to roughly change every year, so if > > > we keep adding new ones things will get more and more

Re: [RESEND PATCH v2 0/2] Add support for ZSTD-compressed kernel

2018-08-17 Thread Adam Borowski
On Fri, Aug 17, 2018 at 09:54:03AM -0700, Andi Kleen wrote: > On Fri, Aug 17, 2018 at 06:15:45PM +0200, René Rebe wrote: > > Hey, > > > > is there any mainline future for this zstd support? > > Currently my most favourite compressor for this, and for what it’s worth > > zstd/initrd now even tested

Re: Linux 4.18.1

2018-08-16 Thread Adam Borowski
On Thu, Aug 16, 2018 at 05:11:21PM +0200, Greg KH wrote: > On Thu, Aug 16, 2018 at 03:59:58PM +0200, Sven Joachim wrote: > > On 2018-08-16 15:05 +0200, Adam Borowski wrote: > > > I'm afraid that I get a build failure; v4.18 is ok, v4.18.1 fails with: > > > > >

Re: Linux 4.18.1

2018-08-16 Thread Adam Borowski
Hi! On Thu, Aug 16, 2018 at 12:14:29PM +0200, Greg KH wrote: > I'm announcing the release of the 4.18.1 kernel. I'm afraid that I get a build failure; v4.18 is ok, v4.18.1 fails with: ld: arch/x86/kvm/x86.o: in function `kvm_get_arch_capabilities': (.text+0x43b2): undefined reference to `l1tf_vm

Re: get_maintainer.pl and change of email

2018-08-01 Thread Adam Borowski
On Wed, Aug 01, 2018 at 11:36:23AM -0700, Nick Desaulniers wrote: > It seems that get_maintainer.pl will make recommendations based on > commit history to a file, but over time, people change emails that > they commit from, then get_maintainer.pl recommends the possibly now > invalid email address.

Re: [PATCH 0/6] vt: no blinking on console, 256/24-bit color improvements

2018-07-23 Thread Adam Borowski
On Mon, Jul 23, 2018 at 10:53:29AM +0200, Geert Uytterhoeven wrote: > On Sat, Jul 21, 2018 at 11:39 PM Adam Borowski wrote: > > Technically, every console can be made to blink by drawing/clearing affected > > characters a few times per second, but that'd be quite a waste of

Re: [PATCH 0/6] vt: no blinking on console, 256/24-bit color improvements

2018-07-21 Thread Adam Borowski
On Sat, Jul 21, 2018 at 09:43:19AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 18, 2018 at 05:01:52AM +0200, Adam Borowski wrote: > > Here's a patchset with two entangled improvements: > > > > * it'd be good to get rid of blinking where possible. Even CGA (thus

Re: [PATCH 0/6] vt: no blinking on console, 256/24-bit color improvements

2018-07-19 Thread Adam Borowski
On Thu, Jul 19, 2018 at 11:47:49AM +0100, Alan Cox wrote: > On Wed, 18 Jul 2018 05:01:52 +0200 > Adam Borowski wrote: > > > Hi! > > Here's a patchset with two entangled improvements: > > > > * it'd be good to get rid of blinking where possible. Ev

[PATCH 3/6] vt: let \e[100m use bright background if unblinking

2018-07-17 Thread Adam Borowski
Let's keep \e[5m setting this bit, it's a nice way to convey the information, and it preserves old behaviour. Some other terminals that can't or don't want to blink do so as well. Signed-off-by: Adam Borowski --- drivers/tty/vt/vt.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH 1/6] vt: drop unused struct vt_struct

2018-07-17 Thread Adam Borowski
Hasn't been ever used within historic (ie, git) times. Signed-off-by: Adam Borowski --- include/linux/console_struct.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h index 2c8d3239899b..fea64f2692a0 1

[PATCH 2/6] vt: add console flag "unblinking"

2018-07-17 Thread Adam Borowski
other consoles: newport looks like it shows bright bg, sti can't do either, mda appears to blink, etc -- but confirmation would be needed. Signed-off-by: Adam Borowski --- drivers/tty/vt/vt.c | 1 + drivers/video/fbdev/core/fbcon.c | 1 + include/linux/console_struct.h | 1 +

[PATCH 5/6] vt: compensate for brightening the 256-color palette

2018-07-17 Thread Adam Borowski
, thus there are some differences, among others: * values very close to black go to 0 (black) rather than 8 (dark grey) * grayscale ramp is more even A comparison of the old vs new vs FreeBSD's teken is at: https://github.com/kilobyte/colorkernel Signed-off-by: Adam Borowski --- drivers/tty/vt

[PATCH 4/6] vt: change 256-color palette to match all(?) modern terminals

2018-07-17 Thread Adam Borowski
into only 16 values, but recently 24-bit codes turned from an oddity to something widespread, thus it's better to handle 256 vs 24-bit consistently. Signed-off-by: Adam Borowski --- drivers/tty/vt/vt.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/tty/vt

[PATCH 6/6] vt: support bright backgrounds for \e[48m if unblinking

2018-07-17 Thread Adam Borowski
dark and better for bright inputs. Signed-off-by: Adam Borowski --- drivers/tty/vt/vt.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index c777f4c91df0..7fcb0ff2dccf 100644 --- a/drivers/tty

[PATCH 0/6] vt: no blinking on console, 256/24-bit color improvements

2018-07-17 Thread Adam Borowski
Hi! Here's a patchset with two entangled improvements: * it'd be good to get rid of blinking where possible. Even CGA (thus VGA) allows disabling it, rendering such characters with a bright background instead. * due to my error, 256-color mode uses a much darker palette for conversion, resu

[PATCH 3/3] vt: selection: take screen contents from uniscr if available

2018-07-17 Thread Adam Borowski
for most users. Signed-off-by: Adam Borowski --- drivers/tty/vt/selection.c | 11 +++ drivers/tty/vt/vt.c| 10 ++ include/linux/selection.h | 1 + 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c ind

[PATCH 2/3] vt: selection: handle storing of characters above U+FFFF

2018-07-17 Thread Adam Borowski
Those above U+10 get replaced with U+FFFD. Signed-off-by: Adam Borowski --- drivers/tty/vt/selection.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c index 34e7110f310d..69ca337d3220 100644

[PATCH 1/3] vt: don't reinvent min()

2018-07-17 Thread Adam Borowski
All the helper function saved us was a cast. Signed-off-by: Adam Borowski --- drivers/tty/vt/selection.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c index 90ea1cc52b7a..34e7110f310d 100644 --- a

[PATCH 0/3] use unicode for vt mouse paste

2018-07-17 Thread Adam Borowski
Hi! Based on Nicolas' nice work (in tty-next), let's avoid corrupting characters that have been copy+pasted via mouse selection. The uniscr array holds their original identity even if they got mangled by glyph conversion. The glyph conversion lossily turns similar-looking characters into a represe

Re: [PATCH 1/3] vt: avoid a VLA in the unicode screen scroll function

2018-07-17 Thread Adam Borowski
On Tue, Jul 17, 2018 at 09:02:40PM -0400, Nicolas Pitre wrote: > The nr argument is typically small: most often nr == 1. However this > could be abused with a very large explicit scroll in a resized screen. > Make the code scroll lines one at a time in all cases to avoid the VLA. > Anything smarter

[PATCH] .gitignore: add ZSTD-compressed files

2018-07-13 Thread Adam Borowski
For now, that's arch/x86/boot/compressed/vmlinux.bin.zst but probably more will come, thus let's be consistent with all other compressors. Signed-off-by: Adam Borowski --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 97ba6b79834c..0d

Re: [PATCH v3 1/3] vt: preserve unicode values corresponding to screen characters

2018-07-11 Thread Adam Borowski
On Wed, Jul 11, 2018 at 01:39:56PM -0700, Kees Cook wrote: > On Wed, Jul 11, 2018 at 2:18 AM, Greg Kroah-Hartman > wrote: > > On Tue, Jul 10, 2018 at 05:52:01PM -0700, Kees Cook wrote: > >> On Tue, Jun 26, 2018 at 8:56 PM, Nicolas Pitre > >> wrote: > >> > +++ b/drivers/tty/vt/vt.c > >> > [...] >

[PATCH resend] scripts: teach extract-vmlinux about LZ4 and ZSTD

2018-07-06 Thread Adam Borowski
Note that the LZ4 signature is different than that of modern LZ4 as we use the "legacy" format which suffers from some downsides like inability to disable compression. Signed-off-by: Adam Borowski --- The first time this was sent I managed to screw up both the subject and scissors lin

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-24 Thread Adam Borowski
On Wed, Jun 20, 2018 at 10:59:08PM -0400, Nicolas Pitre wrote: > On Thu, 21 Jun 2018, Adam Borowski wrote: > > > On Tue, Jun 19, 2018 at 11:34:34AM -0400, Nicolas Pitre wrote: > > > On Tue, 19 Jun 2018, Adam Borowski wrote: > > > > Thus, it'd be nice to use t

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-21 Thread Adam Borowski
On Wed, Jun 20, 2018 at 10:21:37PM -0400, Dave Mielke wrote: > [quoted lines by Adam Borowski on 2018/06/21 at 03:43 +0200] > > >It's meant for displaying braille to _sighted_ people. And in real world, > >the main [ab]use is a way to show images that won't get corrup

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-20 Thread Adam Borowski
On Tue, Jun 19, 2018 at 11:34:34AM -0400, Nicolas Pitre wrote: > On Tue, 19 Jun 2018, Adam Borowski wrote: > > Thus, it'd be nice to use the structure you add to implement full Unicode > > range for the vast majority of people. This includes even U+2800..FF. :) > >

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-19 Thread Adam Borowski
On Tue, Jun 19, 2018 at 09:52:13AM -0400, Dave Mielke wrote: > [quoted lines by Adam Borowski on 2018/06/19 at 15:09 +0200] > > >You're thinking small. That 256 possible values for Braille are easily > >encodable within the 512-glyph space (256 char + stolen fg brightn

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-19 Thread Adam Borowski
On Sun, Jun 17, 2018 at 03:07:02PM -0400, Nicolas Pitre wrote: > The vt code translates UTF-8 strings into glyph index values and stores > those glyph values directly in the screen buffer. Because there can only > be at most 512 glyphs, it is impossible to represent most unicode > characters, in wh

On Tue, Apr 24, 2018 at 11:08:34AM +0200, Paul Menzel wrote:

2018-04-24 Thread Adam Borowski
>From 30886e965e7aeae8d3729c4bacf614a19e103cea Mon Sep 17 00:00:00 2001 From: Adam Borowski Date: Wed, 25 Apr 2018 02:29:18 +0200 Subject: [PATCH] scripts: teach extract-vmlinux about LZ4 and ZSTD Note that the LZ4 signature is different than that of modern LZ4 as we use the "legacy"

Re: How to disable Linux kernel self-extraction (KERNEL_GZIP, KERNEL_BZIP2, …)?

2018-04-24 Thread Adam Borowski
On Tue, Apr 24, 2018 at 11:08:34AM +0200, Paul Menzel wrote: > On 04/24/18 04:08, Adam Borowski wrote: > > On Mon, Apr 23, 2018 at 07:02:30PM +0200, Pavel Machek wrote: > > > > > > > I try to decrease boot time, and my system has an SSD and enough > > > >

Re: How to disable Linux kernel self-extraction (KERNEL_GZIP, KERNEL_BZIP2, …)?

2018-04-23 Thread Adam Borowski
On Mon, Apr 23, 2018 at 07:02:30PM +0200, Pavel Machek wrote: > > > >>I try to decrease boot time, and my system has an SSD and enough space, > > > >>so > > > >>loading 18 instead of 12 MB doesn’t make a difference, but the > > > >>self-extraction is noticeable. So, I like to disable it. > > > > >

Re: [PATCH 1/2] lib: vsprintf: Implement %pCOW

2018-04-01 Thread Adam Borowski
On Sun, Apr 01, 2018 at 10:56:21AM +0200, Richard Weinberger wrote: > + .cow_lines = { > + "\\ ^__^", > + " \\ (oo)\\___", > + "(__)\\ )\\/\\", > + "||w |", > +

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-30 Thread Adam Borowski
On Fri, Mar 30, 2018 at 12:58:02PM +0200, Ingo Molnar wrote: > * John Paul Adrian Glaubitz wrote: > > > On 03/27/2018 12:40 PM, Linus Torvalds wrote: > > > On Mon, Mar 26, 2018 at 4:37 PM, John Paul Adrian Glaubitz > > > wrote: > > >> > > >> What about a tarball with a minimal Debian x32 chroot?

Re: [RESEND PATCH v2 0/2] Add support for ZSTD-compressed kernel

2018-03-22 Thread Adam Borowski
On Thu, Mar 22, 2018 at 12:09:45PM +0100, René Rebe wrote: > Should this currently just work without any arch change on e.g. > ppc64, sparc64 et al.? I could do a test build and boot if that is > of any value, ... Initrd: no reason it wouldn't work, although for anything related to the boot proces

Re: [RESEND PATCH v2 0/2] Add support for ZSTD-compressed kernel

2018-03-21 Thread Adam Borowski
On Wed, Mar 21, 2018 at 06:29:41PM -0700, Nick Terrell wrote: > This patch set adds support for a ZSTD-compressed kernel and ramdisk > images in the kernel boot process. It only integrates the support with > x86, though the first patch is generic to all architectures. I'm running this patch set si

[PATCH] [NOT FOR MERGING] lib: Be noisy about used decompression method.

2018-03-21 Thread Adam Borowski
It's too easy to build the initrd with wrong options during testing, after which it may silently work anyway. Signed-off-by: Adam Borowski --- lib/decompress.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/decompress.c b/lib/decompress.c index ab3fc90

Re: [PATCH 1/2] vsprintf: distinguish between (null), (err) and (invalid) pointer derefs

2018-03-07 Thread Adam Borowski
On Wed, Mar 07, 2018 at 03:17:19PM +0200, Andy Shevchenko wrote: > On Tue, 2018-03-06 at 19:11 +0100, Adam Borowski wrote: > > Thanks for the patch, my comments below. (Review snipped.) It looks pretty obvious that it'd take a lot less of your time to roll new patch[es] from scrat

Re: [PATCH 1/2] vsprintf: distinguish between (null), (err) and (invalid) pointer derefs

2018-03-06 Thread Adam Borowski
On Tue, Mar 06, 2018 at 09:22:17PM +0300, Alexey Dobriyan wrote: > > +#define BAD_PTR_STRING(x) (!(x) ? "(null)" : IS_ERR(x) ? "(err)" : > > "(invalid)") > > This is getting ridiculous. > > Instead of simply printing a pointer as %08lx or %016llx, not only glibc > (null) stupidity is propagated

[PATCH 1/2] vsprintf: distinguish between (null), (err) and (invalid) pointer derefs

2018-03-06 Thread Adam Borowski
Attempting to print an object pointed to by a bad (usually ERR_PTR) pointer is a not so surprising error. Our code handles them inconsistently: * two places print (null) if ptr --- lib/vsprintf.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/vsprintf.c b/

[PATCH 2/2] vsprintf: don't dereference pointers to the first or last page

2018-03-06 Thread Adam Borowski
As old code to avoid so is inconsistent, let's unify it within a single macro. Signed-off-by: Adam Borowski --- lib/vsprintf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 1c2c3cc5a321..4914dac03f0a 100644 ---

Re: Removing architectures without upstream gcc support

2018-02-23 Thread Adam Borowski
On Fri, Feb 23, 2018 at 02:32:08PM -0500, James Bottomley wrote: > On Fri, 2018-02-23 at 18:19 +, Al Viro wrote: > [...] > > IIRC, parisc/qemu stuff had been announced a while ago; > > I have, but it didn't work sufficiently for me to either boot a kernel > using system emulation or start an a

Re: [PATCH 00/31 v2] PTI support for x86_32

2018-02-11 Thread Adam Borowski
On Sat, Feb 10, 2018 at 12:22:59PM -0800, Linus Torvalds wrote: > On Sat, Feb 10, 2018 at 1:15 AM, Adam Borowski wrote: > > > > Alas, we got some data: > > https://popcon.debian.org/ says 20% of x86 users have i386 as their main ABI > > (current; people with popcon

Re: [PATCH 00/31 v2] PTI support for x86_32

2018-02-10 Thread Adam Borowski
On Fri, Feb 09, 2018 at 08:11:12PM +0100, Joerg Roedel wrote: > On Fri, Feb 09, 2018 at 05:47:43PM +, Andy Lutomirski wrote: > > One thing worth noting is that performance of this whole series is > > going to be abysmal due to the complete lack of 32-bit PCID. Maybe > > any kernel built with t

Re: [PATCH v2 0/4] ARM/arm64: exynos: Fix missing missing reg warning for syscon restart nodes

2018-02-09 Thread Adam Borowski
On Thu, Feb 08, 2018 at 02:46:32PM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2018-01-30 22:18, Krzysztof Kozlowski wrote: > > Hi, > > > > Changes since v1: > > 1. New patch (1/4) calling devm_of_platform_populate() in PMU driver, > > following Rob's advice. > > 2. The DTS patches

Re: [PATCH] vsprintf: avoid misleading "(null)" for %px

2018-02-05 Thread Adam Borowski
On Tue, Feb 06, 2018 at 07:32:32AM +1100, Kees Cook wrote: > On Tue, Feb 6, 2018 at 7:15 AM, Tobin C. Harding wrote: > > On Tue, Feb 06, 2018 at 05:57:17AM +1100, Kees Cook wrote: > >> On Mon, Feb 5, 2018 at 8:44 PM, Petr Mladek wrote: > >> > On Sun 2018-02-04

Re: [PATCH] vsprintf: avoid misleading "(null)" for %px

2018-02-05 Thread Adam Borowski
On Mon, Feb 05, 2018 at 09:03:05PM +1100, Tobin C. Harding wrote: > On Mon, Feb 05, 2018 at 10:44:38AM +0100, Petr Mladek wrote: > > On Sun 2018-02-04 18:45:21, Adam Borowski wrote: > > > Like %pK already does, print "" instead. > > > > > >

[PATCH] vsprintf: avoid misleading "(null)" for %px

2018-02-04 Thread Adam Borowski
Like %pK already does, print "" instead. This confused people -- the convention is that "(null)" means you tried to dereference a null pointer as opposed to printing the address. Signed-off-by: Adam Borowski --- lib/vsprintf.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v3] drm/nouveau: Move irq setup/teardown to pci ctor/dtor

2018-01-25 Thread Adam Borowski
On Thu, Jan 25, 2018 at 06:29:53PM -0500, Lyude Paul wrote: > This was made apparent by what appeared to be a regression in the > mainline kernel that started introducing suspend/resume issues for > nouveau: > > a0c9259dc4e1 (irq/matrix: Spread interrupts on allocation) I'm just a dumb us

Re: [RESEND PATCH] blackfin: defconfig: Cleanup from old Kconfig options

2017-12-27 Thread Adam Borowski
On Wed, Dec 27, 2017 at 12:29:33PM +0100, Linus Walleij wrote: > On Tue, Dec 26, 2017 at 2:30 PM, Krzysztof Kozlowski wrote: > > > Remove old, dead Kconfig options (in order appearing in this commit): > > > > Signed-off-by: Krzysztof Kozlowski > > Acked-by: Linus Walleij > > This architecture

[PATCH] MAINTAINERS: mark arch/blackfin/ and its gubbins as orphaned

2017-12-25 Thread Adam Borowski
ueries either. Signed-off-by: Adam Borowski --- Obviously, plankton like me with no relation to the architecture in question shouldn't be orphaning it, but consider this mail telling Linus that in the state of Denmark there is an odor of decay. I also did not pester Scott Jiang (BLACKFIN MEDI

Re: [PATCH] drm/nouveau/imem/nv50: fix incorrect use of refcount API

2017-12-08 Thread Adam Borowski
On Fri, Dec 08, 2017 at 06:30:34PM +, Ard Biesheuvel wrote: > Commit be55287aa5b ("drm/nouveau/imem/nv50: embed nvkm_instobj directly > into nv04_instobj") introduced some new calls to the refcount api to > the nv50 mapping code. In one particular instance, it does the > following: > > if

Re: [PATCH 0/2] Add support for ZSTD-compressed kernel

2017-10-10 Thread Adam Borowski
On Wed, Oct 11, 2017 at 02:01:41AM +, Nick Terrell wrote: > On 10/10/17, 5:08 PM, "Adam Borowski" wrote: > > On Tue, Oct 10, 2017 at 10:40:13PM +, Nick Terrell wrote: > > > On 10/10/17, 2:56 PM, "h...@zytor.com" wrote: > > > >On Oc

Re: [PATCH 0/2] Add support for ZSTD-compressed kernel

2017-10-10 Thread Adam Borowski
On Tue, Oct 10, 2017 at 10:40:13PM +, Nick Terrell wrote: > On 10/10/17, 2:56 PM, "h...@zytor.com" wrote: > >On October 10, 2017 2:22:42 PM PDT, Nick Terrell wrote: > >>This patch set adds support for a ZSTD-compressed kernel and ramdisk > >>images in the kernel boot process. It only integrat

Re: Linux 4.14: Reported regressions as of Sunday, 2017-10-08

2017-10-08 Thread Adam Borowski
On Sun, Oct 08, 2017 at 02:37:41PM +0200, Thorsten Leemhuis wrote: > Hi! Find below my second regression report for Linux 4.14. It lists 8 > regressions I'm currently aware of. One regression was fixed since last > weeks report. One was in there that shouldn't have been there. > > == Current regre

Re: [PATCH] vfs: hard-ban creating files with control characters in the name

2017-10-03 Thread Adam Borowski
On Tue, Oct 03, 2017 at 12:40:12PM -0400, Theodore Ts'o wrote: > On Tue, Oct 03, 2017 at 03:07:24AM +0100, Al Viro wrote: > > That essay is full of shit, and you've even mentioned parts of that just > > above... > > NAK; you'd _still_ need proper quoting (or a shell with something > > resembling

  1   2   3   >