[PATCH] kconfig: fix the failure of `make rpm-pkg` after localversion file changed

2012-11-04 Thread Adam Lee
is not necessary, I made it a empty target, so its last-modification time will be checked by Make only when it exists. Signed-off-by: Adam Lee adam8...@gmail.com --- scripts/package/Makefile |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/package/Makefile b

Re: [PATCH v3] kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old name as an alias

2012-09-06 Thread Adam Lee
On Sat, Sep 01, 2012 at 01:05:17AM +0800, Adam Lee wrote: As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't set new symbols to 'n', but instead sets it to their default values. So, this patch replaces 'oldnoconfig' with 'olddefconfig', stop making people confused

[PATCH v2] kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old name as an alias

2012-08-31 Thread Adam Lee
already are dependent on its behavior with the counter-intuitive name. Signed-off-by: Adam Lee adam8...@gmail.com --- scripts/kconfig/Makefile | 12 +--- scripts/kconfig/conf.c | 12 ++-- tools/testing/ktest/ktest.pl | 15 +++ 3 files changed, 26 insertions(+), 13

[PATCH v3] kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old name as an alias

2012-08-31 Thread Adam Lee
already are dependent on its behavior with the counter-intuitive name. v3: use a better way an add comments about alias in conf.c Signed-off-by: Adam Lee adam8...@gmail.com --- scripts/kconfig/Makefile | 12 +--- scripts/kconfig/conf.c | 25 - tools/testing

Re: [PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c

2012-08-22 Thread Adam Lee
On Fri, Aug 17, 2012 at 02:57:28PM +0800, Adam Lee wrote: As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but instead sets it to their default values. This patch fixes the document in conf.c, and will submit

Re: [PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig', what it really does

2012-08-23 Thread Adam Lee
On Thu, Aug 23, 2012 at 04:10:01PM -0400, Steven Rostedt wrote: Sorry for the late reply. On Fri, 2012-08-17 at 15:16 +0800, Adam Lee wrote: As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't set new symbols to 'n', but instead sets it to their default values. So

[PATCH] kconfig: document oldnoconfig to what it really does in conf.c

2012-08-17 Thread Adam Lee
As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but instead sets it to their default values. This patch fixes the document in conf.c, and will submit another patch to replace 'oldnoconfig' to 'olddefconfig' ---

[PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c

2012-08-17 Thread Adam Lee
-off-by: Adam Lee adam8...@gmail.com --- scripts/kconfig/conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 0dc4a2c..6875680 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -467,7 +467,7 @@ static void

[PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig', what it really does

2012-08-17 Thread Adam Lee
-off] kconfig: document oldnoconfig to what it really does in conf.c Signed-off-by: Adam Lee adam8...@gmail.com --- scripts/kconfig/Makefile | 6 +++--- scripts/kconfig/conf.c | 18 +- tools/testing/ktest/ktest.pl | 15 +++ 3 files changed, 19 insertions(+), 20

[PATCH] kconfig: allow ARCH set to 'the machine hardware name', like 's390x' but not 's390'

2012-08-17 Thread Adam Lee
of make when ARCH set to s390x, ppc64 or some machine hardware name else. Lots of scripts will have no need to hack(like what we did in Red Hat), just use `uname -m`. Signed-off-by: Adam Lee adam8...@gmail.com --- Makefile | 37 - 1 file changed, 8 insertions

Re: [PATCH 4/5] ktest: Fix breakage from change of oldnoconfig to olddefconfig

2012-12-12 Thread Adam Lee
oldnoconfig as a backup. The make oldnoconfig works much better than its backup of: yes '' | make oldconfig But due to this change, and the fact that ktest is used to build lots of older kernels (and for bisects), it forgoes the oldnoconfig completely. Cc: Adam Lee adam8...@gmail.com Cc: Michal

[PATCH v3] btusb: fix wrong use of PTR_ERR()

2013-07-09 Thread Adam Lee
] Signed-off-by: Adam Lee adam@canonical.com --- drivers/bluetooth/btusb.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 7a7e5f8..23df968 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth

Re: [PATCH v2] mmc:sdhci-pci: Add Support of O2Mirco/BayHubTech SD Host

2013-10-16 Thread Adam Lee
@bayhubtech.com --- drivers/mmc/host/sdhci-pci.c | 208 ++ 1 file changed, 208 insertions(+) I'm enabling O2 Micro, Inc. Device [1217:8520] on some laptops, it works after this patch applied. Chris, please take a look? Thanks. Tested-by: Adam Lee

[PATCH] pci: check PCI_EXP_FLAGS_SLOT before setting hotplug bridge

2013-11-18 Thread Adam Lee
This patch adds the PCI_EXP_FLAGS_SLOT check back before setting hotplug bridge, which is omitted by an API switching commit, 59875ae489609b2267548dc85160c5f0f0c6f9d4 PCI/core: Use PCI Express Capability accessors. Some Lenovo laptops hang in booting without this fix. Signed-off-by: Adam Lee

Re: [PATCH] pci: check PCI_EXP_FLAGS_SLOT before setting hotplug bridge

2013-11-18 Thread Adam Lee
On Mon, Nov 18, 2013 at 10:38:17AM -0700, Bjorn Helgaas wrote: [+cc Myron, Amos, Thomas, Ben] On Mon, Nov 18, 2013 at 2:40 AM, Adam Lee adam@canonical.com wrote: This patch adds the PCI_EXP_FLAGS_SLOT check back before setting hotplug bridge, which is omitted by an API switching commit

Re: [PATCH] pci: check PCI_EXP_FLAGS_SLOT before setting hotplug bridge

2013-11-19 Thread Adam Lee
On Tue, Nov 19, 2013 at 11:08:06AM -0700, Myron Stowe wrote: On Mon, Nov 18, 2013 at 10:57 PM, Adam Lee adam@canonical.com wrote: On Mon, Nov 18, 2013 at 10:38:17AM -0700, Bjorn Helgaas wrote: [+cc Myron, Amos, Thomas, Ben] On Mon, Nov 18, 2013 at 2:40 AM, Adam Lee adam

Re: [PATCH v2 0/3] PCIe Capability accessor fixes [stable backports]

2013-11-19 Thread Adam Lee
insertions(+), 9 deletions(-) Fixed a booting hang on some Lenovo laptops. Tested-by: Adam Lee adam@canonical.com -- Adam Lee -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-07 Thread Adam Lee
On Fri, Jun 07, 2013 at 01:22:39PM +, Matthew Garrett wrote: On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote: Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. This patch adds their quirks. Can you detect this case? If this is a new way of doing things then you're

[PATCH 1/3 v3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-08 Thread Adam Lee
Not all 0-15 LEDs are available for all models, sometimes it's even not safe. This patch return -NODEV while operating uninitialized LEDs. Signed-off-by: Adam Lee adam@canonical.com --- drivers/platform/x86/thinkpad_acpi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions

Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-08 Thread Adam Lee
. -- Regards, Adam Lee Hardware Enablement -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Revert V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo

2013-06-13 Thread Adam Lee
On Thu, Apr 25, 2013 at 02:33:06PM +0800, Adam Lee wrote: On Wed, Apr 24, 2013 at 11:17:52AM +0200, Laurent Pinchart wrote: Hi Adam, Thanks for the patch. On Wednesday 24 April 2013 15:57:19 adam@canonical.com wrote: From: Adam Lee adam@canonical.com This reverts

[PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-07 Thread Adam Lee
Not all 0-15 LEDs are available for all models, sometimes it's even not safe. This patch return -NODEV while operating uninitialized LEDs. Signed-off-by: Adam Lee adam@canonical.com --- drivers/platform/x86/thinkpad_acpi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-07 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. This patch adds their quirks. Signed-off-by: Adam Lee adam@canonical.com --- drivers/platform/x86/thinkpad_acpi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers

[PATCH 2/3] thinkpad_acpi: add the ability setting TPACPI_LED_NONE by quirk

2013-06-07 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs, their LED quirks are 0. This patch set led_supported=TPACPI_LED_NONE when quirk equals 0. Signed-off-by: Adam Lee adam@canonical.com --- drivers/platform/x86/thinkpad_acpi.c | 13 ++--- 1 file changed, 10

[PATCH 0/3] thinkpad_acpi: avoid ACPI Warning while operating non-exist LEDs

2013-06-07 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs, they control LEDs by BIOS functions, and return ACPI Warning while operating LEDs by EC. These patches set some quirks, optimize led_init() and led_write() to avoid that warning. Adam Lee (3): thinkpad_acpi: return -NODEV

Re: [PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-07 Thread Adam Lee
On Fri, Jun 07, 2013 at 10:53:50AM +0200, Bjørn Mork wrote: Adam Lee adam@canonical.com writes: --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -5401,9 +5401,12 @@ static int led_write(char *buf) return -ENODEV; while

[PATCH v2] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-07 Thread Adam Lee
Not all 0-15 LEDs are available for all models, sometimes it's even not safe. This patch return -NODEV while operating uninitialized LEDs. Signed-off-by: Adam Lee adam@canonical.com --- drivers/platform/x86/thinkpad_acpi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH] Revert V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo

2013-04-24 Thread adam . lee
From: Adam Lee adam@canonical.com This reverts commit 3dae8b41dc5651f8eb22cf310e8b116480ba25b7. 1, I do have a Chicony webcam, implements autosuspend in a broken way, make `poweroff` performs rebooting when its autosuspend enabled. 2, There are other webcams which don't support autosuspend

Re: [PATCH] Revert V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo

2013-04-25 Thread Adam Lee
On Wed, Apr 24, 2013 at 11:17:52AM +0200, Laurent Pinchart wrote: Hi Adam, Thanks for the patch. On Wednesday 24 April 2013 15:57:19 adam@canonical.com wrote: From: Adam Lee adam@canonical.com This reverts commit 3dae8b41dc5651f8eb22cf310e8b116480ba25b7. 1, I do have

[PATCH] mmc: core: Add a capability for disabling mmc cards

2013-05-14 Thread Adam Lee
On some systems we need a way to disable MMC card support in a MMC/SD card slot due to the legal concern. Add support in the core SD/MMC code to support this. Signed-off-by: Doug Anderson diand...@chromium.org Signed-off-by: Alim Akhtar alim.akh...@samsung.com Signed-off-by: Adam Lee adam

Re: [PATCH] mmc: core: Add a capability for disabling mmc cards

2013-05-14 Thread Adam Lee
On Tue, May 14, 2013 at 03:38:17PM +0800, Adam Lee wrote: On some systems we need a way to disable MMC card support in a MMC/SD card slot due to the legal concern. Add support in the core SD/MMC code to support this. CC more addresses. Yes, this capability seems odd, but linux computer

[PATCH] btusb: fix overflow return values

2013-07-04 Thread Adam Lee
values but not extend btusb_setup_intel() and btusb_setup_intel_patching()'s return types. This is harmless, because the return values were only used to comparing number 0. Signed-off-by: Adam Lee adam@canonical.com --- drivers/bluetooth/btusb.c | 14 +++--- 1 file changed, 7 insertions

Re: [PATCH] btusb: fix overflow return values

2013-07-04 Thread Adam Lee
without this fix. On Thu, Jul 4, 2013 at 8:43 PM, Adam Lee adam@canonical.com wrote: PTR_ERR() returns a long type value, but btusb_setup_intel() and btusb_setup_intel_patching() should return an int type value. This bug makes the judgement if (ret 0) not working on x86_64

Re: [PATCH] btusb: fix overflow return values

2013-07-04 Thread Adam Lee
On Fri, Jul 05, 2013 at 10:59:47AM +0800, Adam Lee wrote: On Fri, Jul 05, 2013 at 10:37:07AM +0800, Yang Bai wrote: The return value of btusb_setup_intel is compared with 0. Code as: drivers/bluetooth/btusb.c: static int btusb_probe(struct usb_interface *intf, const struct

Re: [PATCH] btusb: fix overflow return values

2013-07-08 Thread Adam Lee
thread. Great thanks. -- Regards, Adam Lee Hardware Enablement #include stdio.h static inline long PTR_ERR(const void *ptr) { return (long) ptr; } int main(int argc, const char *argv[]) { printf(sizeof(char) = %lu, sizeof(int) = %lu, sizeof(long) = %lu\n\n, sizeof(char), sizeof(int

Re: [PATCH] btusb: fix overflow return values

2013-07-09 Thread Adam Lee
On Tue, Jul 09, 2013 at 10:55:01AM +0800, Adam Lee wrote: On Mon, Jul 08, 2013 at 11:50:54AM -0700, Marcel Holtmann wrote: Hi Adam, PTR_ERR() returns a long type value, but btusb_setup_intel() and btusb_setup_intel_patching() should return an int type value. This bug makes

[PATCH v2] btusb: fix wrong use of PTR_ERR()

2013-07-09 Thread Adam Lee
7fff53ff6920 error 4 in bluetoothd[7f8b2eaff000+cb000] Signed-off-by: Adam Lee adam@canonical.com --- drivers/bluetooth/btusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 7a7e5f8..05a38a2 100644 --- a/drivers

Re: [PATCH] cdc-acm: prevent infinite loop when parsing CDC headers.

2015-04-13 Thread Adam Lee
1 then goto next_desc? (I'm not a maintainer, pleas also consider others' opinion) -- Adam Lee http://adam8157.info -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2] mmc:sdhci-pci: Add Support of O2Mirco/BayHubTech SD Host

2013-10-16 Thread Adam Lee
f-by: peter.guo > --- > drivers/mmc/host/sdhci-pci.c | 208 > ++ > 1 file changed, 208 insertions(+) I'm enabling "O2 Micro, Inc. Device [1217:8520]" on some laptops, it works after this patch applied. Chris, please take a look? Th

[PATCH] pci: check PCI_EXP_FLAGS_SLOT before setting hotplug bridge

2013-11-18 Thread Adam Lee
This patch adds the PCI_EXP_FLAGS_SLOT check back before setting hotplug bridge, which is omitted by an API switching commit, 59875ae489609b2267548dc85160c5f0f0c6f9d4 "PCI/core: Use PCI Express Capability accessors". Some Lenovo laptops hang in booting without this fix. Signed-off-by

Re: [PATCH] pci: check PCI_EXP_FLAGS_SLOT before setting hotplug bridge

2013-11-18 Thread Adam Lee
On Mon, Nov 18, 2013 at 10:38:17AM -0700, Bjorn Helgaas wrote: > [+cc Myron, Amos, Thomas, Ben] > > On Mon, Nov 18, 2013 at 2:40 AM, Adam Lee wrote: > > This patch adds the PCI_EXP_FLAGS_SLOT check back before setting > > hotplug bridge, which is omitted by an

Re: [PATCH] pci: check PCI_EXP_FLAGS_SLOT before setting hotplug bridge

2013-11-19 Thread Adam Lee
On Tue, Nov 19, 2013 at 11:08:06AM -0700, Myron Stowe wrote: > On Mon, Nov 18, 2013 at 10:57 PM, Adam Lee wrote: > > On Mon, Nov 18, 2013 at 10:38:17AM -0700, Bjorn Helgaas wrote: > >> [+cc Myron, Amos, Thomas, Ben] > >> > >> On Mon, Nov 18, 2013 at 2:40 AM

Re: [PATCH v2 0/3] PCIe Capability accessor fixes [stable backports]

2013-11-19 Thread Adam Lee
++- > 1 file changed, 10 insertions(+), 9 deletions(-) Fixed a booting hang on some Lenovo laptops. Tested-by: Adam Lee -- Adam Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

[PATCH] mmc: core: Add a capability for disabling mmc cards

2013-05-14 Thread Adam Lee
On some systems we need a way to disable MMC card support in a MMC/SD card slot due to the legal concern. Add support in the core SD/MMC code to support this. Signed-off-by: Doug Anderson Signed-off-by: Alim Akhtar Signed-off-by: Adam Lee --- drivers/mmc/core/core.c |2 +- include/linux

Re: [PATCH] mmc: core: Add a capability for disabling mmc cards

2013-05-14 Thread Adam Lee
On Tue, May 14, 2013 at 03:38:17PM +0800, Adam Lee wrote: > On some systems we need a way to disable MMC card support in a MMC/SD > card slot due to the legal concern. > > Add support in the core SD/MMC code to support this. CC more addresses. Yes, this capability seems odd, but li

[PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-07 Thread Adam Lee
Not all 0-15 LEDs are available for all models, sometimes it's even not safe. This patch return -NODEV while operating uninitialized LEDs. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform

[PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-07 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. This patch adds their quirks. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86

[PATCH 2/3] thinkpad_acpi: add the ability setting TPACPI_LED_NONE by quirk

2013-06-07 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs, their LED quirks are 0. This patch set led_supported=TPACPI_LED_NONE when quirk equals 0. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions

[PATCH 0/3] thinkpad_acpi: avoid ACPI Warning while operating non-exist LEDs

2013-06-07 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs, they control LEDs by BIOS functions, and return ACPI Warning while operating LEDs by EC. These patches set some quirks, optimize led_init() and led_write() to avoid that warning. Adam Lee (3): thinkpad_acpi: return -NODEV

Re: [PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-07 Thread Adam Lee
On Fri, Jun 07, 2013 at 10:53:50AM +0200, Bjørn Mork wrote: > Adam Lee writes: > > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > @@ -5401,9 +5401,12 @@ static int led_write(char *buf) > > return -ENO

[PATCH v2] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-07 Thread Adam Lee
Not all 0-15 LEDs are available for all models, sometimes it's even not safe. This patch return -NODEV while operating uninitialized LEDs. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform

Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-07 Thread Adam Lee
On Fri, Jun 07, 2013 at 01:22:39PM +, Matthew Garrett wrote: > On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote: > > Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. > > This patch adds their quirks. > > Can you detect this case? If this is a ne

[PATCH 1/3 v3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-08 Thread Adam Lee
Not all 0-15 LEDs are available for all models, sometimes it's even not safe. This patch return -NODEV while operating uninitialized LEDs. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-08 Thread Adam Lee
;, I will drop [PATCH 3/3] to discussion again when I got the documentation. -- Regards, Adam Lee Hardware Enablement -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] Revert "V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo"

2013-04-24 Thread adam . lee
From: Adam Lee This reverts commit 3dae8b41dc5651f8eb22cf310e8b116480ba25b7. 1, I do have a Chicony webcam, implements autosuspend in a broken way, make `poweroff` performs rebooting when its autosuspend enabled. 2, There are other webcams which don't support autosuspend too, like https

Re: [PATCH] Revert "V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo"

2013-04-25 Thread Adam Lee
On Wed, Apr 24, 2013 at 11:17:52AM +0200, Laurent Pinchart wrote: > Hi Adam, > > Thanks for the patch. > > On Wednesday 24 April 2013 15:57:19 adam@canonical.com wrote: > > From: Adam Lee > > > > This reverts commit 3dae8b41dc5651f8eb22cf310e8b116480ba25b7

[PATCH] btusb: fix overflow return values

2013-07-04 Thread Adam Lee
ose to modify the return values but not extend btusb_setup_intel() and btusb_setup_intel_patching()'s return types. This is harmless, because the return values were only used to comparing number 0. Signed-off-by: Adam Lee --- drivers/bluetooth/btusb.c | 14 +++--- 1 file changed, 7 insertions(+)

Re: [PATCH] btusb: fix overflow return values

2013-07-04 Thread Adam Lee
compared with number "0", doesn't break the judgement. But it still overflows stack without this fix. > On Thu, Jul 4, 2013 at 8:43 PM, Adam Lee wrote: > > PTR_ERR() returns a long type value, but btusb_setup_intel() and > btusb_setup_intel_patching() should return a

Re: [PATCH] btusb: fix overflow return values

2013-07-04 Thread Adam Lee
On Fri, Jul 05, 2013 at 10:59:47AM +0800, Adam Lee wrote: > On Fri, Jul 05, 2013 at 10:37:07AM +0800, Yang Bai wrote: > > The return value of btusb_setup_intel is compared with 0. Code as: > > > > drivers/bluetooth/btusb.c: > > static int btusb_probe(struct usb_interf

[PATCH] kconfig: fix the failure of `make rpm-pkg` after localversion file changed

2012-11-04 Thread Adam Lee
is not necessary, I made it a empty target, so its last-modification time will be checked by Make only when it exists. Signed-off-by: Adam Lee --- scripts/package/Makefile |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/package/Makefile b/scripts/package

Re: [PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c

2012-08-22 Thread Adam Lee
On Fri, Aug 17, 2012 at 02:57:28PM +0800, Adam Lee wrote: > As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target > 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but > instead sets it to their default values. > > This patch fixes the doc

Re: [PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig', what it really does

2012-08-23 Thread Adam Lee
On Thu, Aug 23, 2012 at 04:10:01PM -0400, Steven Rostedt wrote: > Sorry for the late reply. > > On Fri, 2012-08-17 at 15:16 +0800, Adam Lee wrote: > > As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't > > set new symbols to 'n', but instead sets it to

Re: [PATCH v3] kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old name as an alias

2012-09-06 Thread Adam Lee
On Sat, Sep 01, 2012 at 01:05:17AM +0800, Adam Lee wrote: > As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't > set new symbols to 'n', but instead sets it to their default values. > > So, this patch replaces 'oldnoconfig' with 'olddefconfig', stop making >

[PATCH v2] kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old name as an alias

2012-08-31 Thread Adam Lee
already are dependent on its behavior with the counter-intuitive name. Signed-off-by: Adam Lee --- scripts/kconfig/Makefile | 12 +--- scripts/kconfig/conf.c | 12 ++-- tools/testing/ktest/ktest.pl | 15 +++ 3 files changed, 26 insertions(+), 13 deletions

[PATCH v3] kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old name as an alias

2012-08-31 Thread Adam Lee
already are dependent on its behavior with the counter-intuitive name. v3: use a better way an add comments about alias in conf.c Signed-off-by: Adam Lee --- scripts/kconfig/Makefile | 12 +--- scripts/kconfig/conf.c | 25 - tools/testing/ktest/ktest.pl | 15

Re: [PATCH 4/5] ktest: Fix breakage from change of oldnoconfig to olddefconfig

2012-12-12 Thread Adam Lee
ithout adding oldnoconfig as a backup. > The make oldnoconfig works much better than its backup of: >yes '' | make oldconfig > > But due to this change, and the fact that ktest is used to build lots of > older kernels (and for bisects), it forgoes the oldnoconfig completely. > >

[PATCH] kconfig: document oldnoconfig to what it really does in conf.c

2012-08-17 Thread Adam Lee
As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but instead sets it to their default values. This patch fixes the document in conf.c, and will submit another patch to replace 'oldnoconfig' to 'olddefconfig' ---

[PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c

2012-08-17 Thread Adam Lee
-off-by: Adam Lee --- scripts/kconfig/conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 0dc4a2c..6875680 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -467,7 +467,7 @@ static void conf_usage(const

[PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig', what it really does

2012-08-17 Thread Adam Lee
igned-off] kconfig: document oldnoconfig to what it really does in conf.c" Signed-off-by: Adam Lee --- scripts/kconfig/Makefile | 6 +++--- scripts/kconfig/conf.c | 18 +- tools/testing/ktest/ktest.pl | 15 +++ 3 files changed, 19 insertions(+), 20

[PATCH] kconfig: allow ARCH set to 'the machine hardware name', like 's390x' but not 's390'

2012-08-17 Thread Adam Lee
invocation of make when ARCH set to s390x, ppc64 or some machine hardware name else. Lots of scripts will have no need to hack(like what we did in Red Hat), just use `uname -m`. Signed-off-by: Adam Lee --- Makefile | 37 - 1 file changed, 8 insertions(+), 29

Re: [PATCH] cdc-acm: prevent infinite loop when parsing CDC headers.

2015-04-13 Thread Adam Lee
t know in what case the buffer[0] could be zero, if it happens, better to set elength 1 then goto next_desc? (I'm not a maintainer, pleas also consider others' opinion) -- Adam Lee http://adam8157.info -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: [PATCH] Revert "V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo"

2013-06-13 Thread Adam Lee
On Thu, Apr 25, 2013 at 02:33:06PM +0800, Adam Lee wrote: > On Wed, Apr 24, 2013 at 11:17:52AM +0200, Laurent Pinchart wrote: > > Hi Adam, > > > > Thanks for the patch. > > > > On Wednesday 24 April 2013 15:57:19 adam@canonical.com wrote: > > >

Re: [PATCH] btusb: fix overflow return values

2013-07-08 Thread Adam Lee
u will see the bug. PS, about other subsystems, I also think returning PTR_ERR() from a function calls returning int considered harmful sometimes, will talk about that in other thread. Great thanks. -- Regards, Adam Lee Hardware Enablement #include static inline long PTR_ERR(const void *ptr)

Re: [PATCH] btusb: fix overflow return values

2013-07-09 Thread Adam Lee
On Tue, Jul 09, 2013 at 10:55:01AM +0800, Adam Lee wrote: > On Mon, Jul 08, 2013 at 11:50:54AM -0700, Marcel Holtmann wrote: > > Hi Adam, > > > > > PTR_ERR() returns a long type value, but btusb_setup_intel() and > > > btusb_setup_intel_patching(

[PATCH v2] btusb: fix wrong use of PTR_ERR()

2013-07-09 Thread Adam Lee
8b2eb55236 sp 7fff53ff6920 error 4 in bluetoothd[7f8b2eaff000+cb000] Signed-off-by: Adam Lee --- drivers/bluetooth/btusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 7a7e5f8..05a38a2 100644 --- a/drivers/blue

[PATCH v3] btusb: fix wrong use of PTR_ERR()

2013-07-09 Thread Adam Lee
eaff000+cb000] Signed-off-by: Adam Lee --- drivers/bluetooth/btusb.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 7a7e5f8..23df968 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb