arch/microblaze/kernel/head.S: redundant code?

2014-10-31 Thread Adrian McMenamin
Looking at this code at line 78 (in 3.17 kernel) it has: mfs r1, rmsr msrclr r8, 0 cmpu r8, r8, r1 But as far as I can see the result of that comparison is never used - the comments state it is to test if the msrclr instruction is enabled. Haven't posted a patch because I am using

arch/microblaze/kernel/head.S: redundant code?

2014-10-31 Thread Adrian McMenamin
Looking at this code at line 78 (in 3.17 kernel) it has: mfs r1, rmsr msrclr r8, 0 cmpu r8, r8, r1 But as far as I can see the result of that comparison is never used - the comments state it is to test if the msrclr instruction is enabled. Haven't posted a patch because I am using

Re: [PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
On Mon, 2008-02-25 at 14:33 +0900, Paul Mundt wrote: > On Sun, Feb 24, 2008 at 10:32:53PM +0000, Adrian McMenamin wrote: > > On Sun, 2008-02-24 at 21:50 +0000, Adrian McMenamin wrote: > > > On Sun, 2008-02-24 at 14:30 +, Adrian McMenamin wrote: > > > >

Re: [PATCH] input: support maple controller on SEGA Dreamcast

2008-02-24 Thread Adrian McMenamin
Add support for the Dreamcast maple controller (as a joystick). Earlier patches caused subdevice detection headaches. Please use this one. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN ./a/drivers/input/joystick/Kconfig ./b/drivers/input/joystick/Kconfig --- ./a/d

Re: [PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
On Sun, 2008-02-24 at 21:50 +, Adrian McMenamin wrote: > On Sun, 2008-02-24 at 14:30 +0000, Adrian McMenamin wrote: > > The maple bus driver that went into the kernel mainline in September 2007 > > contained some bugs which were revealed by the update of the kobj code for

Re: [PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
On Sun, 2008-02-24 at 14:30 +, Adrian McMenamin wrote: > The maple bus driver that went into the kernel mainline in September 2007 > contained some bugs which were revealed by the update of the kobj code for > the current release series. Unfortunately those bugs also helped ens

lkml.org

2008-02-24 Thread Adrian McMenamin
At the risk of pointing out the obvious (though I cannot find anyone else who has commented), this appears to be broken at the moment...(ie not picking up new messages) ...which is a pity as it is a great site Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

[PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
) now ensures that devices are properly detected again. (A previous attempt to fix this by delaying initialisation only partially fixed this - as became apparent when the bus was fully loaded) Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN ./a/drivers/sh/maple/maple

[PATCH] input: support maple controller on SEGA Dreamcast

2008-02-24 Thread Adrian McMenamin
This is a port of the old (never in mainline) 2.4 driver. (It also fixes some issues with earlier patches which should be discarded for this) Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN ./a/drivers/input/joystick/Kconfig ./b/drivers/input/joystick/Kconfig --- ./a/d

[PATCH 3/3] input: support maple mouse on Dreamcast

2008-02-24 Thread Adrian McMenamin
input: add support for maple mouse on Dreamcast Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff --git a/drivers/input/mouse/maplemouse.c b/drivers/input/mouse/maplemouse.c new file mode 100644 index 000..08cfb6f --- /dev/null +++ b/drivers/input/mouse/maplemouse.c @@ -0,0

[PATCH 2/3] input: support maple mouse on Dreamcast

2008-02-24 Thread Adrian McMenamin
input: update Makefile to support maple mouse on Dreamcast Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff --git a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile index 9e6e363..5d35939 100644 --- a/drivers/input/mouse/Makefile +++ b/drivers/input/mouse/Ma

[PATCH 1/3] input: support maple mouse on Dreamcast

2008-02-24 Thread Adrian McMenamin
input: support maple mouse on Dreamcast Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig index 7bbea09..d171336 100644 --- a/drivers/input/mouse/Kconfig +++ b/drivers/input/mouse/Kconfig @@ -232,4 +232,16 @@

[PATCH 1/3] input: support maple mouse on Dreamcast

2008-02-24 Thread Adrian McMenamin
input: support maple mouse on Dreamcast Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] --- diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig index 7bbea09..d171336 100644 --- a/drivers/input/mouse/Kconfig +++ b/drivers/input/mouse/Kconfig @@ -232,4 +232,16 @@ config

[PATCH 2/3] input: support maple mouse on Dreamcast

2008-02-24 Thread Adrian McMenamin
input: update Makefile to support maple mouse on Dreamcast Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] --- diff --git a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile index 9e6e363..5d35939 100644 --- a/drivers/input/mouse/Makefile +++ b/drivers/input/mouse/Makefile @@ -16,6

[PATCH 3/3] input: support maple mouse on Dreamcast

2008-02-24 Thread Adrian McMenamin
input: add support for maple mouse on Dreamcast Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] --- diff --git a/drivers/input/mouse/maplemouse.c b/drivers/input/mouse/maplemouse.c new file mode 100644 index 000..08cfb6f --- /dev/null +++ b/drivers/input/mouse/maplemouse.c @@ -0,0 +1,148

[PATCH] input: support maple controller on SEGA Dreamcast

2008-02-24 Thread Adrian McMenamin
This is a port of the old (never in mainline) 2.4 driver. (It also fixes some issues with earlier patches which should be discarded for this) Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] --- diff -ruN ./a/drivers/input/joystick/Kconfig ./b/drivers/input/joystick/Kconfig --- ./a/drivers

[PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
) now ensures that devices are properly detected again. (A previous attempt to fix this by delaying initialisation only partially fixed this - as became apparent when the bus was fully loaded) Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] --- diff -ruN ./a/drivers/sh/maple/maple.c ./b

lkml.org

2008-02-24 Thread Adrian McMenamin
At the risk of pointing out the obvious (though I cannot find anyone else who has commented), this appears to be broken at the moment...(ie not picking up new messages) ...which is a pity as it is a great site Adrian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
On Sun, 2008-02-24 at 14:30 +, Adrian McMenamin wrote: The maple bus driver that went into the kernel mainline in September 2007 contained some bugs which were revealed by the update of the kobj code for the current release series. Unfortunately those bugs also helped ensure maple

Re: [PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
On Sun, 2008-02-24 at 21:50 +, Adrian McMenamin wrote: On Sun, 2008-02-24 at 14:30 +, Adrian McMenamin wrote: The maple bus driver that went into the kernel mainline in September 2007 contained some bugs which were revealed by the update of the kobj code for the current release

Re: [PATCH] input: support maple controller on SEGA Dreamcast

2008-02-24 Thread Adrian McMenamin
Add support for the Dreamcast maple controller (as a joystick). Earlier patches caused subdevice detection headaches. Please use this one. Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] --- diff -ruN ./a/drivers/input/joystick/Kconfig ./b/drivers/input/joystick/Kconfig --- ./a/drivers/input

Re: [PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
On Mon, 2008-02-25 at 14:33 +0900, Paul Mundt wrote: On Sun, Feb 24, 2008 at 10:32:53PM +, Adrian McMenamin wrote: On Sun, 2008-02-24 at 21:50 +, Adrian McMenamin wrote: On Sun, 2008-02-24 at 14:30 +, Adrian McMenamin wrote: The maple bus driver that went into the kernel

Re: Current git very broken on the Dreamcast

2008-02-18 Thread Adrian McMenamin
On Mon, 2008-02-18 at 17:57 +0900, Magnus Damm wrote: > Hi Adrian, > > [fixed up Matsubara-sans address] > > On Feb 17, 2008 4:48 AM, Adrian McMenamin > <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-16 at 18:38 +, Adrian McMenamin wrote: > > > Wi

Re: Current git very broken on the Dreamcast

2008-02-18 Thread Adrian McMenamin
On Mon, 2008-02-18 at 17:57 +0900, Magnus Damm wrote: Hi Adrian, [fixed up Matsubara-sans address] On Feb 17, 2008 4:48 AM, Adrian McMenamin [EMAIL PROTECTED] wrote: On Sat, 2008-02-16 at 18:38 +, Adrian McMenamin wrote: Will seek to bisect this, but I have just updated my

[PATCH] maple: add driver for Sega Dreamcast controller

2008-02-16 Thread Adrian McMenamin
Add support for the SEGA Dreamcast controller as a joystick device. Based on Yaegashi Takeshi's old 2.4 driver (never in mainline) with the addition of functioning removal (and reinsertion) code. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN a/drivers/input/jo

[PATCH] maple: allow removal and reinsertion of keyboard driver module

2008-02-16 Thread Adrian McMenamin
Allow the removal (and subsequent reinsertion) of the maple_keyb (maple keyboard) driver by adding a working removal function. Also tidy long lines. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN a/drivers/input/keyboard/maple_keyb.c b/drivers/input/keyboard/maple_

[PATCH] maple: remove unused variable

2008-02-16 Thread Adrian McMenamin
Remove an unused variable from the definition of struct maple_device Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN a/include/linux/maple.h b/include/linux/maple.h --- a/include/linux/maple.h 2008-02-16 20:52:09.0 + +++ b/include/linux/maple.h 2008-02

Re: Current git very broken on the Dreamcast

2008-02-16 Thread Adrian McMenamin
On Sat, 2008-02-16 at 19:48 +, Adrian McMenamin wrote: > On Sat, 2008-02-16 at 18:38 +0000, Adrian McMenamin wrote: > > Will seek to bisect this, but I have just updated my sources to the > > latest git and it is not booting at all on the Dreamcast. > > > [EMAIL PRO

Re: Current git very broken on the Dreamcast

2008-02-16 Thread Adrian McMenamin
On Sat, 2008-02-16 at 18:38 +, Adrian McMenamin wrote: > Will seek to bisect this, but I have just updated my sources to the > latest git and it is not booting at all on the Dreamcast. > > With early printk on, I get nothing more than this before an instant > reboot: >

Current git very broken on the Dreamcast

2008-02-16 Thread Adrian McMenamin
Will seek to bisect this, but I have just updated my sources to the latest git and it is not booting at all on the Dreamcast. With early printk on, I get nothing more than this before an instant reboot: [0.00] Linux version 2.6.25-rc2-10953-g52065cd ([EMAIL PROTECTED]) (gcc version

Current git very broken on the Dreamcast

2008-02-16 Thread Adrian McMenamin
Will seek to bisect this, but I have just updated my sources to the latest git and it is not booting at all on the Dreamcast. With early printk on, I get nothing more than this before an instant reboot: [0.00] Linux version 2.6.25-rc2-10953-g52065cd ([EMAIL PROTECTED]) (gcc version

Re: Current git very broken on the Dreamcast

2008-02-16 Thread Adrian McMenamin
On Sat, 2008-02-16 at 18:38 +, Adrian McMenamin wrote: Will seek to bisect this, but I have just updated my sources to the latest git and it is not booting at all on the Dreamcast. With early printk on, I get nothing more than this before an instant reboot: [0.00] Linux

Re: Current git very broken on the Dreamcast

2008-02-16 Thread Adrian McMenamin
On Sat, 2008-02-16 at 19:48 +, Adrian McMenamin wrote: On Sat, 2008-02-16 at 18:38 +, Adrian McMenamin wrote: Will seek to bisect this, but I have just updated my sources to the latest git and it is not booting at all on the Dreamcast. [EMAIL PROTECTED]:~/gdrom-dev$ git bisect

[PATCH] maple: remove unused variable

2008-02-16 Thread Adrian McMenamin
Remove an unused variable from the definition of struct maple_device Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] --- diff -ruN a/include/linux/maple.h b/include/linux/maple.h --- a/include/linux/maple.h 2008-02-16 20:52:09.0 + +++ b/include/linux/maple.h 2008-02-16 21

[PATCH] maple: allow removal and reinsertion of keyboard driver module

2008-02-16 Thread Adrian McMenamin
Allow the removal (and subsequent reinsertion) of the maple_keyb (maple keyboard) driver by adding a working removal function. Also tidy long lines. Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] --- diff -ruN a/drivers/input/keyboard/maple_keyb.c b/drivers/input/keyboard/maple_keyb.c

[PATCH] maple: add driver for Sega Dreamcast controller

2008-02-16 Thread Adrian McMenamin
Add support for the SEGA Dreamcast controller as a joystick device. Based on Yaegashi Takeshi's old 2.4 driver (never in mainline) with the addition of functioning removal (and reinsertion) code. Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] --- diff -ruN a/drivers/input/joystick

Re: [PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-11 Thread Adrian McMenamin
On Mon, February 11, 2008 4:25 pm, Dmitry Torokhov wrote: > On Mon, Feb 11, 2008 at 11:19:22AM -0500, Mike Frysinger wrote: >> On Monday 11 February 2008, Adrian McMenamin wrote: >> > On Mon, February 11, 2008 12:22 am, Mike Frysinger wrote: >> > > no remove fu

Re: [PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-11 Thread Adrian McMenamin
On Mon, February 11, 2008 12:22 am, Mike Frysinger wrote: > > no remove function ? looks like the probe() forces a connect, but there's > no > remove() to force a disconnect ... Removing these devices (or any other plugged directly into the maple ports) is a quick way to destroy your Dreamcast:

Re: [PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-11 Thread Adrian McMenamin
On Mon, February 11, 2008 4:25 pm, Dmitry Torokhov wrote: On Mon, Feb 11, 2008 at 11:19:22AM -0500, Mike Frysinger wrote: On Monday 11 February 2008, Adrian McMenamin wrote: On Mon, February 11, 2008 12:22 am, Mike Frysinger wrote: no remove function ? looks like the probe() forces

Re: [PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-11 Thread Adrian McMenamin
On Mon, February 11, 2008 12:22 am, Mike Frysinger wrote: no remove function ? looks like the probe() forces a connect, but there's no remove() to force a disconnect ... Removing these devices (or any other plugged directly into the maple ports) is a quick way to destroy your Dreamcast:

[PATCH 2/2] SH/Dreamcast - joystick (controlpad)

2008-02-10 Thread Adrian McMenamin
Changes to the Kconfig and Makefile needed to build the Maple controlpad code. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> == diff --combined drivers/input/joystick/Kconfig index 7c662ee,7c662ee..3566fa2 --- a/drivers/input/joystick/Kconfig +++ b/drivers/input/joystick/K

[PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-10 Thread Adrian McMenamin
Adds support for the Dreamcast control pad. This is a port of the 2.4 driver (never in mainline) by Yaegashi Takeshi. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> == --- /dev/null 2007-10-16 19:02:41.0 +0100 +++ drivers/input/joystick/maplecontrol.c 2008-02-10

[PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-10 Thread Adrian McMenamin
Adds support for the Dreamcast control pad. This is a port of the 2.4 driver (never in mainline) by Yaegashi Takeshi. Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] == --- /dev/null 2007-10-16 19:02:41.0 +0100 +++ drivers/input/joystick/maplecontrol.c 2008-02-10 22:50

[PATCH 2/2] SH/Dreamcast - joystick (controlpad)

2008-02-10 Thread Adrian McMenamin
Changes to the Kconfig and Makefile needed to build the Maple controlpad code. Signed-off-by: Adrian McMenamin [EMAIL PROTECTED] == diff --combined drivers/input/joystick/Kconfig index 7c662ee,7c662ee..3566fa2 --- a/drivers/input/joystick/Kconfig +++ b/drivers/input/joystick/Kconfig

[PATCH] 8139too fix for Dreamcast

2008-02-08 Thread Adrian McMenamin
Updates the 8139too driver to work with recently added (a724605cb7a66d423a494a395f9a8ba871b8a1eb) declared coherent memory patch for the Dreamcast. Jeff - I am assuming you are still the maintainer and I guess Paul should also ack this as it is SH related. Signed-off-by: Adrian McMenamin <[EM

[PATCH] 8139too fix for Dreamcast

2008-02-08 Thread Adrian McMenamin
Updates the 8139too driver to work with recently added (a724605cb7a66d423a494a395f9a8ba871b8a1eb) declared coherent memory patch for the Dreamcast. Jeff - I am assuming you are still the maintainer and I guess Paul should also ack this as it is SH related. Signed-off-by: Adrian McMenamin [EMAIL

[PATCH] - SH/Dreamcast - additional patch to maple.h

2008-02-06 Thread Adrian McMenamin
This patch removes the now unneeded registration check variable from struct maple_device. (This patch assumes the include/linux/maple.h file has already been patched for whitespace errors by http://lkml.org/lkml/2008/2/6/327) Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff

Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
function in any way). Also now removes redundant registration checking. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c index 3f341dc..fbca7f8 100644 --- a/drivers/sh/maple/maple.c +++ b/drivers/sh/maple/maple.c @@

Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
On Wed, 2008-02-06 at 15:01 -0800, Greg KH wrote: > On Wed, Feb 06, 2008 at 10:53:51PM +0000, Adrian McMenamin wrote: > > - dev->function = function; > > - dev->dev.bus = _bus_type; > > - dev->dev.parent = _bus; > > - dev->dev.release = _release_d

[PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c index 3f341dc..60eeb92 100644 --- a/drivers/sh/maple/maple.c +++ b/drivers/sh/maple/maple.c @@ -30,6 +30,7 @@ #include #include #include +#include MODULE_AUTHOR("Yaegshi Ta

[PATCH 1/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
This patch is fundamentally about fixing up the whitespace problems introduced by my previous patch (that brought the code into mainline). A second patch will follow that will fix memory leaks. The two need to be applied sequentially. Signed-off by: Adrian McMenamin <[EMAIL PROTEC

[PATCH 1/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
This patch is fundamentally about fixing up the whitespace problems introduced by my previous patch (that brought the code into mainline). A second patch will follow that will fix memory leaks. The two need to be applied sequentially. Signed-off by: Adrian McMenamin [EMAIL PROTECTED] --- diff

[PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
by: Adrian McMenamin [EMAIL PROTECTED] diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c index 3f341dc..60eeb92 100644 --- a/drivers/sh/maple/maple.c +++ b/drivers/sh/maple/maple.c @@ -30,6 +30,7 @@ #include asm/mach/dma.h #include asm/mach/sysasic.h #include asm/mach/maple.h

Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
On Wed, 2008-02-06 at 15:01 -0800, Greg KH wrote: On Wed, Feb 06, 2008 at 10:53:51PM +, Adrian McMenamin wrote: - dev-function = function; - dev-dev.bus = maple_bus_type; - dev-dev.parent = maple_bus; - dev-dev.release = maple_release_device; - retval = device_register

[PATCH] - SH/Dreamcast - additional patch to maple.h

2008-02-06 Thread Adrian McMenamin
This patch removes the now unneeded registration check variable from struct maple_device. (This patch assumes the include/linux/maple.h file has already been patched for whitespace errors by http://lkml.org/lkml/2008/2/6/327) Signed-off by: Adrian McMenamin [EMAIL PROTECTED] diff --git

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 22:37 +, Adrian McMenamin wrote: > > The hardware is very flaky. If I add in delays to the bus start, it will > detect the devices, but it's not brilliant. Registering an empty device > got round that problem, at the price of testing for the earlier &g

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 08:14 -0800, Greg KH wrote: > On Mon, Feb 04, 2008 at 08:27:55AM +0000, Adrian McMenamin wrote: > > > > On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: > > > On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: > &

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:59 am, Paul Mundt wrote: > On Mon, Feb 04, 2008 at 09:35:11AM -0000, Adrian McMenamin wrote: >> On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: >> > My previous commit was directly from _your_ patch, given that your >> > patches have a h

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: > My previous commit was directly from _your_ patch, given that your > patches have a history of whitespace damage, this doesn't seem like much > of a stretch. It's true I neglected to run it through checkpatch, I'll be > more careful with that

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: > On Sun, Feb 03, 2008 at 08:00:47PM +0000, Adrian McMenamin wrote: > > From: Adrian McMenamin > > > > This patch fixes the regression noted here: > > http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 10:10 +0900, Paul Mundt wrote: > On Sun, Feb 03, 2008 at 08:00:47PM +0000, Adrian McMenamin wrote: > > From: Adrian McMenamin > > > This is useless if you are submitting the patch, especially if you're > missing a mail address. > >From Docu

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This patch fixes the regression noted here: http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the previous commit of this driver

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 10:10 +0900, Paul Mundt wrote: On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This is useless if you are submitting the patch, especially if you're missing a mail address. From Documentation/SubmittingPatches

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: My previous commit was directly from _your_ patch, given that your patches have a history of whitespace damage, this doesn't seem like much of a stretch. It's true I neglected to run it through checkpatch, I'll be more careful with that in

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:59 am, Paul Mundt wrote: On Mon, Feb 04, 2008 at 09:35:11AM -, Adrian McMenamin wrote: On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: My previous commit was directly from _your_ patch, given that your patches have a history of whitespace damage

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 22:37 +, Adrian McMenamin wrote: The hardware is very flaky. If I add in delays to the bus start, it will detect the devices, but it's not brilliant. Registering an empty device got round that problem, at the price of testing for the earlier registration. I

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 08:14 -0800, Greg KH wrote: On Mon, Feb 04, 2008 at 08:27:55AM +, Adrian McMenamin wrote: On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This patch fixes

[PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-03 Thread Adrian McMenamin
From: Adrian McMenamin This patch fixes the regression noted here: http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the previous commit of this driver and the memory leaks noted here: http://lkml.org/lkml/2008/2/2/143 (as well as one or two other minor cleanups). Signed off

[PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-03 Thread Adrian McMenamin
From: Adrian McMenamin This patch fixes the regression noted here: http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the previous commit of this driver and the memory leaks noted here: http://lkml.org/lkml/2008/2/2/143 (as well as one or two other minor cleanups). Signed off

slab cache question

2008-02-02 Thread Adrian McMenamin
I have been having problems with the slab cache (using slub) in my maple bus driver (eg see http://lkml.org/lkml/2008/1/28/74). I have now switched to using SLAB_POISON in kmem_cache_create and instead of fatal oops, I get what follows - could someone tell me the likely causes I should be

slab cache question

2008-02-02 Thread Adrian McMenamin
I have been having problems with the slab cache (using slub) in my maple bus driver (eg see http://lkml.org/lkml/2008/1/28/74). I have now switched to using SLAB_POISON in kmem_cache_create and instead of fatal oops, I get what follows - could someone tell me the likely causes I should be

Re: kobject oops with maple bus

2008-01-28 Thread Adrian McMenamin
On Sat, January 26, 2008 8:44 pm, Greg KH wrote: > On Sat, Jan 26, 2008 at 07:53:20PM +0000, Adrian McMenamin wrote: >> Greg, >> >> Just updated my git to the latest sources and get these (seemingly >> non-fatal) oops with the Dreamcast maple bus. I'll investigate fu

Re: kobject oops with maple bus

2008-01-28 Thread Adrian McMenamin
On Sat, January 26, 2008 8:44 pm, Greg KH wrote: On Sat, Jan 26, 2008 at 07:53:20PM +, Adrian McMenamin wrote: Greg, Just updated my git to the latest sources and get these (seemingly non-fatal) oops with the Dreamcast maple bus. I'll investigate further, but they may mean something

Re: kobject oops with maple bus

2008-01-26 Thread Adrian McMenamin
On Sat, 2008-01-26 at 12:44 -0800, Greg KH wrote: > On Sat, Jan 26, 2008 at 07:53:20PM +0000, Adrian McMenamin wrote: > > Greg, > > > > Just updated my git to the latest sources and get these (seemingly > > non-fatal) oops with the Dreamcast maple bu

Re: kobject oops with maple bus

2008-01-26 Thread Adrian McMenamin
On 26/01/2008, Adrian McMenamin <[EMAIL PROTECTED]> wrote: > Greg, > > Just updated my git to the latest sources and get these (seemingly non-fatal) > oops with the Dreamcast maple bus. I'll investigate further, but they may > mean something to out out of the box. > &

kobject oops with maple bus

2008-01-26 Thread Adrian McMenamin
Greg, Just updated my git to the latest sources and get these (seemingly non-fatal) oops with the Dreamcast maple bus. I'll investigate further, but they may mean something to out out of the box. Adrian dreamy:~# [0.00] Linux version 2.6.24-gf0ea9c3d-dirty ([EMAIL PROTECTED]) (gcc

kobject oops with maple bus

2008-01-26 Thread Adrian McMenamin
Greg, Just updated my git to the latest sources and get these (seemingly non-fatal) oops with the Dreamcast maple bus. I'll investigate further, but they may mean something to out out of the box. Adrian dreamy:~# [0.00] Linux version 2.6.24-gf0ea9c3d-dirty ([EMAIL PROTECTED]) (gcc

Re: kobject oops with maple bus

2008-01-26 Thread Adrian McMenamin
On 26/01/2008, Adrian McMenamin [EMAIL PROTECTED] wrote: Greg, Just updated my git to the latest sources and get these (seemingly non-fatal) oops with the Dreamcast maple bus. I'll investigate further, but they may mean something to out out of the box. Adrian dreamy:~# [0.00

Re: kobject oops with maple bus

2008-01-26 Thread Adrian McMenamin
On Sat, 2008-01-26 at 12:44 -0800, Greg KH wrote: On Sat, Jan 26, 2008 at 07:53:20PM +, Adrian McMenamin wrote: Greg, Just updated my git to the latest sources and get these (seemingly non-fatal) oops with the Dreamcast maple bus. I'll investigate further, but they may mean

Re: [PATCH] SG - fix SH Kconfig

2008-01-20 Thread Adrian McMenamin
On Sun, 2008-01-20 at 11:54 -0800, Randy Dunlap wrote: > On Sun, 20 Jan 2008 18:18:29 +0000 Adrian McMenamin wrote: > > > From: Adrian McMenamin <[EMAIL PROTECTED]> > > > > > > Remove reference to board deleted in commit > > 758e06ded4c480248

[PATCH] SG - fix SH Kconfig

2008-01-20 Thread Adrian McMenamin
From: Adrian McMenamin <[EMAIL PROTECTED]> Remove reference to board deleted in commit 758e06ded4c48024835ef0a14627afcde2e25929 Submitted-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 85bd9ac..e94430b 100644 --- a/arch/sh/Kconfi

[PATCH] SG - fix SH Kconfig

2008-01-20 Thread Adrian McMenamin
From: Adrian McMenamin [EMAIL PROTECTED] Remove reference to board deleted in commit 758e06ded4c48024835ef0a14627afcde2e25929 Submitted-by: Adrian McMenamin [EMAIL PROTECTED] --- diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 85bd9ac..e94430b 100644 --- a/arch/sh/Kconfig +++ b/arch/sh

Re: [PATCH] SG - fix SH Kconfig

2008-01-20 Thread Adrian McMenamin
On Sun, 2008-01-20 at 11:54 -0800, Randy Dunlap wrote: On Sun, 20 Jan 2008 18:18:29 + Adrian McMenamin wrote: From: Adrian McMenamin [EMAIL PROTECTED] Remove reference to board deleted in commit 758e06ded4c48024835ef0a14627afcde2e25929 Submitted-by: Adrian McMenamin

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-17 Thread Adrian McMenamin
From: Adrian McMenamin <[EMAIL PROTECTED]> This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's propreitary GD

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-17 Thread Adrian McMenamin
From: Adrian McMenamin [EMAIL PROTECTED] This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's propreitary GD format

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-16 Thread Adrian McMenamin
On Mon, 2008-01-14 at 23:17 +, Adrian McMenamin wrote: > On Mon, 2008-01-14 at 23:00 +0000, Adrian McMenamin wrote: > > From: Adrian McMenamin <[EMAIL PROTECTED]> > > > > This patch adds support for the GD-Rom drive, SEGA's proprietary > > implementat

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-15 Thread Adrian McMenamin
On 15/01/2008, Paul Mundt <[EMAIL PROTECTED]> wrote: > On Mon, Jan 14, 2008 at 11:17:15PM +0000, Adrian McMenamin wrote: > > > +static bool gdrom_data_request(void) > > +{ > > + return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8; > > +} > > + >

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-15 Thread Adrian McMenamin
On 15/01/2008, Paul Mundt [EMAIL PROTECTED] wrote: On Mon, Jan 14, 2008 at 11:17:15PM +, Adrian McMenamin wrote: +static bool gdrom_data_request(void) +{ + return (ctrl_inb(GDROM_ALTSTATUS_REG) 0x88) == 8; +} + Andrew first pointed this out, and this is still broken. Eh

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-14 Thread Adrian McMenamin
On Mon, 2008-01-14 at 23:00 +, Adrian McMenamin wrote: > From: Adrian McMenamin <[EMAIL PROTECTED]> > > This patch adds support for the GD-Rom drive, SEGA's proprietary > implementation of an IDE CD Rom for the SEGA Dreamcast. This driver > implements Sega's

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-14 Thread Adrian McMenamin
From: Adrian McMenamin <[EMAIL PROTECTED]> This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's propreitary GD

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-14 Thread Adrian McMenamin
On Mon, 2008-01-14 at 23:00 +, Adrian McMenamin wrote: From: Adrian McMenamin [EMAIL PROTECTED] This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-14 Thread Adrian McMenamin
From: Adrian McMenamin [EMAIL PROTECTED] This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's propreitary GD format

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-13 Thread Adrian McMenamin
On 12/01/2008, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sat, 12 Jan 2008 14:14:01 +0000 Adrian McMenamin <[EMAIL PROTECTED]> wrote: > > > > > > > + spin_command->cmd[0] = 0x70; > > > > + spin_command->cmd[2] = 0x1f; > &

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-13 Thread Adrian McMenamin
On 12/01/2008, Andrew Morton [EMAIL PROTECTED] wrote: On Sat, 12 Jan 2008 14:14:01 + Adrian McMenamin [EMAIL PROTECTED] wrote: + spin_command-cmd[0] = 0x70; + spin_command-cmd[2] = 0x1f; + spin_command-buflen = 0; + gd.pending = 1; + gdrom_packetcommand(gd.cd_info

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-12 Thread Adrian McMenamin
On Sat, 2008-01-12 at 05:36 -0800, Andrew Morton wrote: > On Fri, 11 Jan 2008 21:56:49 +0000 Adrian McMenamin <[EMAIL PROTECTED]> wrote: > > > > > On Thu, 2008-01-10 at 23:25 +, Adrian McMenamin wrote: > > > From: Adrian McMenamin <[EMAIL PROTECTED]&g

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-12 Thread Adrian McMenamin
On Sat, 2008-01-12 at 05:36 -0800, Andrew Morton wrote: On Fri, 11 Jan 2008 21:56:49 + Adrian McMenamin [EMAIL PROTECTED] wrote: On Thu, 2008-01-10 at 23:25 +, Adrian McMenamin wrote: From: Adrian McMenamin [EMAIL PROTECTED] This patch adds support for the GD-Rom drive

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-11 Thread Adrian McMenamin
On Thu, 2008-01-10 at 23:25 +, Adrian McMenamin wrote: > From: Adrian McMenamin <[EMAIL PROTECTED]> > > This patch adds support for the GD-Rom drive, SEGA's proprietary > implementation of an IDE CD Rom for the SEGA Dreamcast. This driver > implements Sega's

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-11 Thread Adrian McMenamin
On Thu, 2008-01-10 at 23:25 +, Adrian McMenamin wrote: From: Adrian McMenamin [EMAIL PROTECTED] This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least

[PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-10 Thread Adrian McMenamin
From: Adrian McMenamin <[EMAIL PROTECTED]> This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's propreitary GD

[PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-10 Thread Adrian McMenamin
From: Adrian McMenamin [EMAIL PROTECTED] This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's propreitary GD format

  1   2   3   4   >