__find_symbl() error checks remain unchanged.
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
Cc: Christoph Lameter [EMAIL PROTECTED]
---
kernel/module.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Index: 2.6.24-mm1/kernel/module.c
The use of get_zeroed_page() with __GFP_HIGHMEM is invalid.
Use alloc_page() with __GFP_ZERO instead of invalid get_zeroed_page().
(This patch is only compile tested)
Cc: Carsten Otte <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
mm/filemap_xip.c |9
The use of get_zeroed_page() with __GFP_HIGHMEM is invalid.
Use alloc_page() with __GFP_ZERO instead of invalid get_zeroed_page().
(This patch is only compile tested)
Cc: Carsten Otte [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
mm/filemap_xip.c |9 +
1 file
Use list_for_each_entry_reverse for super_blocks list and remove
unused sb_entry macro.
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
fs/fs-writeback.c |7 ++-
include/linux/fs.h |1 -
2 files changed, 2 insertions(+), 6 deletions(-)
Index: 2.6-mm/fs/fs-write
Use kasprintf instead of kmalloc()-strcpy()-strcat().
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
fs/partitions/check.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
Index: 2.6-mm/fs/partitions/c
Use kasprintf instead of kmalloc()-strcpy()-strcat().
Cc: Anton Vorontsov <[EMAIL PROTECTED]>
Cc: David Woodhouse <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
drivers/power/power_supply_leds.c | 25 +++--
1 file changed, 7
Use kasprintf instead of kmalloc()-strcpy()-strcat().
Cc: Anton Vorontsov [EMAIL PROTECTED]
Cc: David Woodhouse [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
drivers/power/power_supply_leds.c | 25 +++--
1 file changed, 7 insertions(+), 18 deletions
Use kasprintf instead of kmalloc()-strcpy()-strcat().
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
fs/partitions/check.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
Index: 2.6-mm/fs/partitions/check.c
Use list_for_each_entry_reverse for super_blocks list and remove
unused sb_entry macro.
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
fs/fs-writeback.c |7 ++-
include/linux/fs.h |1 -
2 files changed, 2 insertions(+), 6 deletions(-)
Index: 2.6-mm/fs/fs-writeback.c
Use hlist_unhashed() instead of opencoded equivalent.
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
fs/dcache.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 2.6-mm/fs/dcache.c
===
--- 2.6-mm.o
Use hlist_unhashed() instead of opencoded equivalent.
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
fs/dcache.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 2.6-mm/fs/dcache.c
===
--- 2.6-mm.orig/fs/dcache.c
This patch fixes wrong array index in allocation failure handling.
Cc: Pekka Enberg <[EMAIL PROTECTED]>
Cc: Christoph Lameter <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
mm/slab.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index:
]: make CPU_ONLINE callback always return NOTIFY_OK]
[EMAIL PROTECTED]: avoid mce_remove_device() for not initialized device]
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/mcheck/mce_64.c | 18 +++---
1 file changed, 11 insertions(+), 7
This patch fixes wrong array index in allocation failure handling.
Cc: Pekka Enberg [EMAIL PROTECTED]
Cc: Christoph Lameter [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
mm/slab.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 2.6-git/mm/slab.c
mce_remove_device() for not initialized device]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
arch/x86/kernel/cpu/mcheck/mce_64.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
Index: 2.6-git/arch/x86/kernel/cpu/mcheck/mce_64.c
2007/10/12, Christoph Lameter <[EMAIL PROTECTED]>:
> On Thu, 11 Oct 2007, Akinobu Mita wrote:
>
> > > Why would get_cpu_slab not work?
> >
> >
> > case CPU_DEAD:
> > case CPU_DEAD_FROZEN:
> > down_read(_lock);
>
On Wed, Oct 10, 2007 at 10:39:32AM -0700, Christoph Lameter wrote:
> On Wed, 10 Oct 2007, Akinobu Mita wrote:
>
> > I couldn't use get_cpu_slab() for that check. But I reviced the patch to do
> > what you said.
>
> Why would get_cpu_slab not work?
cas
On Wed, Oct 10, 2007 at 10:39:32AM -0700, Christoph Lameter wrote:
On Wed, 10 Oct 2007, Akinobu Mita wrote:
I couldn't use get_cpu_slab() for that check. But I reviced the patch to do
what you said.
Why would get_cpu_slab not work?
case CPU_DEAD:
case CPU_DEAD_FROZEN
2007/10/12, Christoph Lameter [EMAIL PROTECTED]:
On Thu, 11 Oct 2007, Akinobu Mita wrote:
Why would get_cpu_slab not work?
case CPU_DEAD:
case CPU_DEAD_FROZEN:
down_read(slub_lock);
list_for_each_entry(s, slab_caches, list
ne trying to remount read/write while freezing.
Cc: David Chinner <[EMAIL PROTECTED]>
Cc: Tim Shimmin <[EMAIL PROTECTED]>
Cc: Christoph Hellwig <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
fs/buffer.c | 25 -
1 file chang
On Tue, Oct 09, 2007 at 11:46:14AM -0700, Christoph Lameter wrote:
> On Wed, 10 Oct 2007, Akinobu Mita wrote:
>
> > This patch removes init_alloc_cpu_cpu() from cpu hotplug notifier. But
> > call it for each possible CPUs not only online CPUs at initialization time.
>
>
On Tue, Oct 09, 2007 at 11:46:14AM -0700, Christoph Lameter wrote:
On Wed, 10 Oct 2007, Akinobu Mita wrote:
This patch removes init_alloc_cpu_cpu() from cpu hotplug notifier. But
call it for each possible CPUs not only online CPUs at initialization time.
Could you check if a per cpu
to remount read/write while freezing.
Cc: David Chinner [EMAIL PROTECTED]
Cc: Tim Shimmin [EMAIL PROTECTED]
Cc: Christoph Hellwig [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
fs/buffer.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
Index
breaks kmem_cache_cpu_free list for
the CPU.
This patch removes init_alloc_cpu_cpu() from cpu hotplug notifier. But
call it for each possible CPUs not only online CPUs at initialization time.
Cc: Christoph Lameter <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
mm/slub.c |
/proc/cpuinfo
processor : 0
processor : 0
Because early_identify_cpu() overwrites c->cpu_index for every cpuinfo.
This patch removes that unnecessary initialization for c->cpu_index.
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
Index: 2.6-mm/arch/x86_64/ke
/proc/cpuinfo
processor : 0
processor : 0
Because early_identify_cpu() overwrites c-cpu_index for every cpuinfo.
This patch removes that unnecessary initialization for c-cpu_index.
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
Index: 2.6-mm/arch/x86_64/kernel/setup.c
kmem_cache_cpu_free list for
the CPU.
This patch removes init_alloc_cpu_cpu() from cpu hotplug notifier. But
call it for each possible CPUs not only online CPUs at initialization time.
Cc: Christoph Lameter [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
mm/slub.c |5 ++---
1 file
2007/10/5, Christoph Hellwig <[EMAIL PROTECTED]>:
> On Sat, Sep 29, 2007 at 07:09:12PM +0900, Akinobu Mita wrote:
> > freeze_bdev() with the device which is mounted as read only
> > does not change sb->s_frozen from SB_UNFROZEN to SB_FREEZE_TRANS.
> >
> > Beca
2007/10/5, Christoph Hellwig [EMAIL PROTECTED]:
On Sat, Sep 29, 2007 at 07:09:12PM +0900, Akinobu Mita wrote:
freeze_bdev() with the device which is mounted as read only
does not change sb-s_frozen from SB_UNFROZEN to SB_FREEZE_TRANS.
Because of this behavior, xfs_freeze can break read
2007/10/2, Grant Likely <[EMAIL PROTECTED]>:
> static int __init
> xilinxfb_init(void)
> {
> - /*
> -* No kernel boot options used,
> -* so we just need to register the driver
> -*/
> + int rc;
> + rc = xilinxfb_of_register();
> + if (rc)
> +
2007/10/2, Grant Likely [EMAIL PROTECTED]:
static int __init
xilinxfb_init(void)
{
- /*
-* No kernel boot options used,
-* so we just need to register the driver
-*/
+ int rc;
+ rc = xilinxfb_of_register();
+ if (rc)
+
2007/9/29, Greg KH <[EMAIL PROTECTED]>:
> > Index: 2.6-git/kernel/module.c
> > ===
> > --- 2.6-git.orig/kernel/module.c
> > +++ 2.6-git/kernel/module.c
> > @@ -1782,7 +1782,8 @@ static struct module *load_module(void _
> >
PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
fs/buffer.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
Index: 2.6-git/fs/buffer.c
===
--- 2.6-git.orig/fs/buffer.c
+++ 2.6-git/fs/
load_module() returns zero when mod_sysfs_init() fails,
then the module loading will succeed accidentally.
This patch makes load_module() return error correctly in that case.
Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Cc: Rusty Russell <[EMAIL PROTECTED]>
Signed-off-by: Akinobu
load_module() returns zero when mod_sysfs_init() fails,
then the module loading will succeed accidentally.
This patch makes load_module() return error correctly in that case.
Cc: Greg Kroah-Hartman [EMAIL PROTECTED]
Cc: Rusty Russell [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED
-by: Akinobu Mita [EMAIL PROTECTED]
---
fs/buffer.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
Index: 2.6-git/fs/buffer.c
===
--- 2.6-git.orig/fs/buffer.c
+++ 2.6-git/fs/buffer.c
@@ -190,19 +190,22 @@ struct
2007/9/29, Greg KH [EMAIL PROTECTED]:
Index: 2.6-git/kernel/module.c
===
--- 2.6-git.orig/kernel/module.c
+++ 2.6-git/kernel/module.c
@@ -1782,7 +1782,8 @@ static struct module *load_module(void _
Cleanup by using pgd_list_add() and pgd_list_del() in the right place.
Cc: Andi Kleen <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
include/asm-x86_64/pgalloc.h | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
Index: 2.6-git/includ
2007/9/23, Thomas Gleixner <[EMAIL PROTECTED]>:
> On Sat, 2007-09-22 at 00:32 +0200, Andi Kleen wrote:
> > From: Akinobu Mita <[EMAIL PROTECTED]>
> >
> > Do cpuid_device_create() in CPU_UP_PREPARE instead of CPU_ONLINE.
> >
> > Cc: "H. Peter Anv
2007/9/23, Thomas Gleixner [EMAIL PROTECTED]:
On Sat, 2007-09-22 at 00:32 +0200, Andi Kleen wrote:
From: Akinobu Mita [EMAIL PROTECTED]
Do cpuid_device_create() in CPU_UP_PREPARE instead of CPU_ONLINE.
Cc: H. Peter Anvin [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED
Cleanup by using pgd_list_add() and pgd_list_del() in the right place.
Cc: Andi Kleen [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
include/asm-x86_64/pgalloc.h | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
Index: 2.6-git/include/asm-x86_64/pgalloc.h
2007/8/28, Rafael J. Wysocki <[EMAIL PROTECTED]>:
> On Monday, 27 August 2007 23:58, Pavel Machek wrote:
> > On Mon 2007-08-27 23:59:31, Rafael J. Wysocki wrote:
> > > On Monday, 27 August 2007 23:32, Pavel Machek wrote:
> > > > On Mon 2007-08-27 22:36:57, Jeff Chua wrote:
> > > > > On 8/27/07,
2007/8/28, Rafael J. Wysocki [EMAIL PROTECTED]:
On Monday, 27 August 2007 23:58, Pavel Machek wrote:
On Mon 2007-08-27 23:59:31, Rafael J. Wysocki wrote:
On Monday, 27 August 2007 23:32, Pavel Machek wrote:
On Mon 2007-08-27 22:36:57, Jeff Chua wrote:
On 8/27/07, Pavel Machek [EMAIL
On Mon, Aug 13, 2007 at 09:43:31AM +0200, Cornelia Huck wrote:
> On Sun, 12 Aug 2007 13:44:07 +0900,
> Akinobu Mita <[EMAIL PROTECTED]> wrote:
>
> > No one uses sysdev_drivers. Because no one calls sysdev_driver_register
> > with NULL class.
> >
> > And
On Mon, Aug 13, 2007 at 09:43:31AM +0200, Cornelia Huck wrote:
On Sun, 12 Aug 2007 13:44:07 +0900,
Akinobu Mita [EMAIL PROTECTED] wrote:
No one uses sysdev_drivers. Because no one calls sysdev_driver_register
with NULL class.
And it is difficult to imagine that someone want
: Tejun Heo <[EMAIL PROTECTED]>
Cc: Cornelia Huck <[EMAIL PROTECTED]>
Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
drivers/base/sys.c | 66 +
1 file changed, 12 insertions(+)
: Tejun Heo [EMAIL PROTECTED]
Cc: Cornelia Huck [EMAIL PROTECTED]
Cc: Greg Kroah-Hartman [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
drivers/base/sys.c | 66 +
1 file changed, 12 insertions(+), 54 deletions(-)
Index: 2.6
2007/8/6, Alan Stern <[EMAIL PROTECTED]>:
> On Sat, 4 Aug 2007, Miles Lane wrote:
>
> > Initializing USB Mass Storage driver...
> > usb-storage 4-3:1.0: usb_probe_interface
> > usb-storage 4-3:1.0: usb_probe_interface - got id
> > scsi2 : SCSI emulation for USB Mass Storage devices
> > usbcore:
2007/8/6, Alan Stern [EMAIL PROTECTED]:
On Sat, 4 Aug 2007, Miles Lane wrote:
Initializing USB Mass Storage driver...
usb-storage 4-3:1.0: usb_probe_interface
usb-storage 4-3:1.0: usb_probe_interface - got id
scsi2 : SCSI emulation for USB Mass Storage devices
usbcore: registered new
> > "Failed to setup dm-crypt key mapping.
> > Check kernel for support for the aes-cbc-essiv:sha256 cipher spec and
> > verify that /dev/hda4 contains at least 133 sectors.
> > Failed to read from key storage"
>
> Looks like a "cryptsetup" error message, not kernel's.
I can't find
Failed to setup dm-crypt key mapping.
Check kernel for support for the aes-cbc-essiv:sha256 cipher spec and
verify that /dev/hda4 contains at least 133 sectors.
Failed to read from key storage
Looks like a cryptsetup error message, not kernel's.
I can't find CONFIG_DM_CRYPT in the
cache_add_dev() needs
to do cpuid and store the results with its CPU online.)
Cc: Ashok Raj <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
arch/i386/kernel/cpu/intel_cacheinfo.c | 64 +++--
1 file changed, 45 insertions(+), 19 deletions(-)
Do msr_device_create() in CPU_UP_PREPARE instead of CPU_ONLINE.
Cc: "H. Peter Anvin" <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
arch/i386/kernel/msr.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-
Do cpuid_device_create() in CPU_UP_PREPARE instead of CPU_ONLINE.
Cc: "H. Peter Anvin" <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
arch/i386/kernel/cpuid.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-
should not do sysdev_remove_file() with not yet added
attributes.
- Don't register hotcpu notifier when mce_create_device() returns error
- Do mce_create_device() in CPU_UP_PREPARE instead of CPU_ONLINE
Cc: Andi Kleen <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
From: Akinobu Mita <[EMAIL PROTECTED]>
The functions in a CPU notifier chain is called with CPU_UP_PREPARE event
before making the CPU online. If one of the callback returns NOTIFY_BAD,
it stops to deliver CPU_UP_PREPARE event, and CPU online operation is canceled.
Then CPU_UP_CANCELED
By previous cpu hotplug notifier change, we don't need to track
topology_dev existence for each cpu by topology_dev_map.
Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
drivers/base/topology.c | 11 +--
1 file changed, 1 inse
Do thermal_throttle_add_dev() in CPU_UP_PREPARE instead of CPU_ONLINE.
Cc: Dmitriy Zavin <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
arch/i386/kernel/cpu/mcheck/therm_throt.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
Index: 2.6-g
ED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
mm/slab.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
Index: 2.6-git/mm/slab.c
===
--- 2.6-git.orig/mm/slab.c
+++ 2.6-git/mm/slab.c
@@ -1282,1
This series of patches fixes the error handling for cpu hotplug.
The problem is revealed by CPU hotplug/unplug test with fault-injection.
The changes from previous patchset:
- Removed the patch titled sysfs: avoid kmem_cache_free(NULL)
Because it was merged into mainline.
- Removed the patch
cpuup_callback() is too long.
This patch factors out CPU_UP_CANCELLED and CPU_UP_PREPARE handlings
from cpuup_callback().
Cc: Christoph Lameter <[EMAIL PROTECTED]>
Cc: Gautham R Shenoy <[EMAIL PROTECTED]>
Cc: Pekka Enberg <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita
This series of patches fixes the error handling for cpu hotplug.
The problem is revealed by CPU hotplug/unplug test with fault-injection.
The changes from previous patchset:
- Removed the patch titled sysfs: avoid kmem_cache_free(NULL)
Because it was merged into mainline.
- Removed the patch
cpuup_callback() is too long.
This patch factors out CPU_UP_CANCELLED and CPU_UP_PREPARE handlings
from cpuup_callback().
Cc: Christoph Lameter [EMAIL PROTECTED]
Cc: Gautham R Shenoy [EMAIL PROTECTED]
Cc: Pekka Enberg [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
mm/slab.c
-by: Akinobu Mita [EMAIL PROTECTED]
---
mm/slab.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
Index: 2.6-git/mm/slab.c
===
--- 2.6-git.orig/mm/slab.c
+++ 2.6-git/mm/slab.c
@@ -1282,13 +1282,18 @@ static int __cpuinit
From: Akinobu Mita [EMAIL PROTECTED]
The functions in a CPU notifier chain is called with CPU_UP_PREPARE event
before making the CPU online. If one of the callback returns NOTIFY_BAD,
it stops to deliver CPU_UP_PREPARE event, and CPU online operation is canceled.
Then CPU_UP_CANCELED event
By previous cpu hotplug notifier change, we don't need to track
topology_dev existence for each cpu by topology_dev_map.
Cc: Greg Kroah-Hartman [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
drivers/base/topology.c | 11 +--
1 file changed, 1 insertion(+), 10
Do thermal_throttle_add_dev() in CPU_UP_PREPARE instead of CPU_ONLINE.
Cc: Dmitriy Zavin [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
arch/i386/kernel/cpu/mcheck/therm_throt.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
Index: 2.6-git/arch/i386
Do msr_device_create() in CPU_UP_PREPARE instead of CPU_ONLINE.
Cc: H. Peter Anvin [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
arch/i386/kernel/msr.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
Index: 2.6-git/arch/i386
Do cpuid_device_create() in CPU_UP_PREPARE instead of CPU_ONLINE.
Cc: H. Peter Anvin [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
arch/i386/kernel/cpuid.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
Index: 2.6-git/arch/i386
should not do sysdev_remove_file() with not yet added
attributes.
- Don't register hotcpu notifier when mce_create_device() returns error
- Do mce_create_device() in CPU_UP_PREPARE instead of CPU_ONLINE
Cc: Andi Kleen [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
arch
cache_add_dev() needs
to do cpuid and store the results with its CPU online.)
Cc: Ashok Raj [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
arch/i386/kernel/cpu/intel_cacheinfo.c | 64 +++--
1 file changed, 45 insertions(+), 19 deletions(-)
Index: 2.6-git
> >[...] However, it might break slab.
> >If I am not mistaken, slab code initializes multiple objects in
> >CPU_UP_PREPARE and relies on the CPU_UP_CANCELLED to destroy the
> >objects which successfully got initialized before the some object's
> >initialization went bad.
>
> My testing machine
[...] However, it might break slab.
If I am not mistaken, slab code initializes multiple objects in
CPU_UP_PREPARE and relies on the CPU_UP_CANCELLED to destroy the
objects which successfully got initialized before the some object's
initialization went bad.
My testing machine is ordinary
> So it is natural to deliver CPU_UP_CANCELED event only to the functions
> that have returned NOTIFY_OK with CPU_UP_PREPARE event and not to call
> the function that have returned NOTIFY_BAD. This is what this patch is doing.
Yes, this makes sense.
Thank you for making sure of it.
[...]
2007/7/17, Greg KH <[EMAIL PROTECTED]>:
On Mon, Jul 16, 2007 at 05:29:45PM +0200, Cornelia Huck wrote:
> On Mon, 16 Jul 2007 22:52:30 +0900,
> Akinobu Mita <[EMAIL PROTECTED]> wrote:
>
> > Current error handling in create_files() attempts to remove
> >
2007/7/17, Greg KH [EMAIL PROTECTED]:
On Mon, Jul 16, 2007 at 05:29:45PM +0200, Cornelia Huck wrote:
On Mon, 16 Jul 2007 22:52:30 +0900,
Akinobu Mita [EMAIL PROTECTED] wrote:
Current error handling in create_files() attempts to remove
all attributes passed by argument by remove_files
So it is natural to deliver CPU_UP_CANCELED event only to the functions
that have returned NOTIFY_OK with CPU_UP_PREPARE event and not to call
the function that have returned NOTIFY_BAD. This is what this patch is doing.
Yes, this makes sense.
Thank you for making sure of it.
[...]
2007/7/17, Greg KH <[EMAIL PROTECTED]>:
On Mon, Jul 16, 2007 at 10:50:28PM +0900, Akinobu Mita wrote:
> This patch fixes out of memory error handling in sysfs_new_dirent().
> kmem_cache_free() with NULL is not allowed.
Why not just allow kmem_cache_free() to allow NULL like oth
2007/7/17, Cornelia Huck <[EMAIL PROTECTED]>:
On Mon, 16 Jul 2007 22:52:30 +0900,
Akinobu Mita <[EMAIL PROTECTED]> wrote:
> Current error handling in create_files() attempts to remove
> all attributes passed by argument by remove_files(). But it should
> only remove the
2007/7/17, Cornelia Huck <[EMAIL PROTECTED]>:
On Mon, 16 Jul 2007 22:51:38 +0900,
Akinobu Mita <[EMAIL PROTECTED]> wrote:
> This patch enables to catch the errors returned by add() procedure of
> sysdev driver in sysdev_register.
> @@ -253,23 +254,50 @@ int sysdev_regis
.)
Cc: Ashok Raj <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
arch/i386/kernel/cpu/intel_cacheinfo.c | 57 +++--
1 file changed, 40 insertions(+), 17 deletions(-)
Index: 2.6-mm/arch/i386/kernel/cpu/intel
- Fix error handling in mce_create_device()
Error handling should not do sysdev_remove_file() with not yet added
attributes.
- Change mce_create_device() from CPU_ONLINE event handler
to CPU_UP_PREPARE event handler.
Cc: Andi Kleen <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita &
Make cpuid_device_create() CPU_UP_PREPARE event handler
instead of CPU_ONLINE event handler.
Cc: "H. Peter Anvin" <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
arch/i386/kernel/cpuid.c | 32 +++-
1 file changed
Make thermal_throttle_add_dev() CPU_UP_PREPARE event handler
instead of CPU_ONLINE event handler.
Cc: Dmitriy Zavin <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
arch/i386/kernel/cpu/mcheck/therm_throt.c | 11 ++-
1 file changed, 6 insertions(+),
Make msr_device_create() CPU_UP_PREPARE event handler
instead of CPU_ONLINE handler.
Cc: "H. Peter Anvin" <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
arch/i386/kernel/msr.c | 32 +++-
1 file changed, 19 inser
By previous cpu hotplug notifier change, we don't need to track
topology_dev existence for each cpu by topology_dev_map.
Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
drivers/base/topology.c | 11 +--
1 file changed, 1 inse
whether
notifiler event is failed or not for each cpu.
(drivers/base/topology.c is doing this with topology_dev_map)
Similary this patch makes same thing with CPU_DOWN_PREPARE and
CPU_DOWN_FAILED evnets.
Cc: Rusty Russell <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
Current error handling in create_files() attempts to remove
all attributes passed by argument by remove_files(). But it should
only remove the attributes that have been successfully added.
Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
-
This patch enables to catch the errors returned by add() procedure of
sysdev driver in sysdev_register.
Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
drivers/base/sys.c | 48 ++--
1 file
This patch fixes out of memory error handling in sysfs_new_dirent().
kmem_cache_free() with NULL is not allowed.
Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c | 13 +++--
1 file changed, 7 insertions(+),
This series of patches fixes the error handling for cpu hotplug.
The problem is revealed by CPU hotplug/unplug test with fault-injection.
The patch 1-3 are sysfs or driver core related error handling fixes.
These are not directly related to cpu hotplug. But these are needed to
pass the stress
This series of patches fixes the error handling for cpu hotplug.
The problem is revealed by CPU hotplug/unplug test with fault-injection.
The patch 1-3 are sysfs or driver core related error handling fixes.
These are not directly related to cpu hotplug. But these are needed to
pass the stress
This patch fixes out of memory error handling in sysfs_new_dirent().
kmem_cache_free() with NULL is not allowed.
Cc: Greg Kroah-Hartman [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
fs/sysfs/dir.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
Index
This patch enables to catch the errors returned by add() procedure of
sysdev driver in sysdev_register.
Cc: Greg Kroah-Hartman [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
drivers/base/sys.c | 48 ++--
1 file changed, 38
Current error handling in create_files() attempts to remove
all attributes passed by argument by remove_files(). But it should
only remove the attributes that have been successfully added.
Cc: Greg Kroah-Hartman [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
fs/sysfs
whether
notifiler event is failed or not for each cpu.
(drivers/base/topology.c is doing this with topology_dev_map)
Similary this patch makes same thing with CPU_DOWN_PREPARE and
CPU_DOWN_FAILED evnets.
Cc: Rusty Russell [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
kernel
By previous cpu hotplug notifier change, we don't need to track
topology_dev existence for each cpu by topology_dev_map.
Cc: Greg Kroah-Hartman [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
drivers/base/topology.c | 11 +--
1 file changed, 1 insertion(+), 10
Make thermal_throttle_add_dev() CPU_UP_PREPARE event handler
instead of CPU_ONLINE event handler.
Cc: Dmitriy Zavin [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
arch/i386/kernel/cpu/mcheck/therm_throt.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions
Make msr_device_create() CPU_UP_PREPARE event handler
instead of CPU_ONLINE handler.
Cc: H. Peter Anvin [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
arch/i386/kernel/msr.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
Index
Make cpuid_device_create() CPU_UP_PREPARE event handler
instead of CPU_ONLINE event handler.
Cc: H. Peter Anvin [EMAIL PROTECTED]
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
---
arch/i386/kernel/cpuid.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions
901 - 1000 of 1201 matches
Mail list logo
