Re: [RFC] With 8250 Designware UART, if writes to the LCR failed the kernel will hung up

2015-03-09 Thread Alan Cox
On Mon, 2015-03-09 at 07:36 -0700, Tim Kryger wrote: On Mon, Mar 9, 2015 at 6:32 AM, Alan Cox a...@linux.intel.com wrote: Maybe the next release of the board we will upgrade the serial block to the new version. but the issue is that how we circumvent this problem in kernel? What

Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform

2015-03-05 Thread Alan Cox
> Besides, the "ACPI reduced hardware" case is kind of a red herring here, > because it most likely is not the only case when we'll want has_8259_pic() > to return 0 (quite likely, we'll want that on all BayTrail-based systems, > for example). No. Only those with ACPI reduced firmware. For others

Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform

2015-03-05 Thread Alan Cox
> I'll do more investigation above items but I want to leave at least > these two as the quirk today unless I am convinced I can do that because > from my understanding, UEFI runtime services should not be supported in > reduced hw mode. What actually matters in this space is what Microsoft does.

Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform

2015-03-05 Thread Alan Cox
Besides, the ACPI reduced hardware case is kind of a red herring here, because it most likely is not the only case when we'll want has_8259_pic() to return 0 (quite likely, we'll want that on all BayTrail-based systems, for example). No. Only those with ACPI reduced firmware. For others you

Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform

2015-03-05 Thread Alan Cox
I'll do more investigation above items but I want to leave at least these two as the quirk today unless I am convinced I can do that because from my understanding, UEFI runtime services should not be supported in reduced hw mode. What actually matters in this space is what Microsoft does. The

Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform

2015-03-04 Thread Alan Cox
On Wed, 2015-03-04 at 15:05 +0100, Borislav Petkov wrote: > On Wed, Mar 04, 2015 at 03:16:07PM +0100, Rafael J. Wysocki wrote: > > Sort of. What we need is a "do not touch PIC/PIT" bit for the code that > > tries to fall back to them in some cases (which may appear to work if > > the hardware is

Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform

2015-03-04 Thread Alan Cox
On Wed, 2015-03-04 at 10:50 +0100, Borislav Petkov wrote: > On Wed, Mar 04, 2015 at 12:43:08AM -0800, Arjan van de Ven wrote: > > > > > >Using 'acpi_gbl_reduced_hardware' flag outside the ACPI code > > >is a mistake. > > > > ideally, the presence of that flag in the firmware table will clear/set

Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform

2015-03-04 Thread Alan Cox
On Wed, 2015-03-04 at 15:05 +0100, Borislav Petkov wrote: On Wed, Mar 04, 2015 at 03:16:07PM +0100, Rafael J. Wysocki wrote: Sort of. What we need is a do not touch PIC/PIT bit for the code that tries to fall back to them in some cases (which may appear to work if the hardware is

Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform

2015-03-04 Thread Alan Cox
On Wed, 2015-03-04 at 10:50 +0100, Borislav Petkov wrote: On Wed, Mar 04, 2015 at 12:43:08AM -0800, Arjan van de Ven wrote: Using 'acpi_gbl_reduced_hardware' flag outside the ACPI code is a mistake. ideally, the presence of that flag in the firmware table will clear/set more global

Re: [PATCH 0/8] introduce dynamic device creation/removal

2015-03-02 Thread Alan Cox
> > This is a long term plan, of course, but I'd like to see sysfs functions go > > away > > in a year or so. What do you think? > > hoo boy. Creating a /dev node and doing ioctls on it is really old > school. So old school that I've forgotten why we don't do it any more. > > Hopefully Alan

Re: [PATCH 0/8] introduce dynamic device creation/removal

2015-03-02 Thread Alan Cox
This is a long term plan, of course, but I'd like to see sysfs functions go away in a year or so. What do you think? hoo boy. Creating a /dev node and doing ioctls on it is really old school. So old school that I've forgotten why we don't do it any more. Hopefully Alan can recall

Re: make mandocs build failure with next-20150210

2015-02-16 Thread Alan Cox
On Mon, 2015-02-16 at 11:29 +0900, Masanari Iida wrote: > On Thu, Feb 12, 2015 at 12:48 AM, Greg Kroah-Hartman > wrote: > > On Wed, Feb 11, 2015 at 02:19:00PM +0000, Alan Cox wrote: > >> On Wed, 2015-02-11 at 07:27 +1100, Stephen Rothwell wrote: > >> > Hi Jim, >

Re: make mandocs build failure with next-20150210

2015-02-16 Thread Alan Cox
On Mon, 2015-02-16 at 11:29 +0900, Masanari Iida wrote: On Thu, Feb 12, 2015 at 12:48 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Feb 11, 2015 at 02:19:00PM +, Alan Cox wrote: On Wed, 2015-02-11 at 07:27 +1100, Stephen Rothwell wrote: Hi Jim, On Tue, 10 Feb

Re: make mandocs build failure with next-20150210

2015-02-11 Thread Alan Cox
On Wed, 2015-02-11 at 07:27 +1100, Stephen Rothwell wrote: > Hi Jim, > > On Tue, 10 Feb 2015 11:40:23 -0700 Jim Davis wrote: > > > > DOCPROC Documentation/DocBook/device-drivers.xml > > docproc: .//include/linux/i2o.h: No such file or directory > > make[1]: ***

Re: make mandocs build failure with next-20150210

2015-02-11 Thread Alan Cox
On Wed, 2015-02-11 at 07:27 +1100, Stephen Rothwell wrote: Hi Jim, On Tue, 10 Feb 2015 11:40:23 -0700 Jim Davis jim.ep...@gmail.com wrote: DOCPROC Documentation/DocBook/device-drivers.xml docproc: .//include/linux/i2o.h: No such file or directory make[1]: ***

[RESEND PATCH] pnpbios: bail out on strange errors

2015-01-20 Thread Alan Cox
A small number of systems respond to PnP dock queries with bogus values. This causes us to keep logging an error every 2 seconds. Instead of trying again just assume the BIOS is crapware and doesn't actually have dock functionality. Signed-off-by: Alan Cox --- drivers/pnp/pnpbios/core.c |3

[RESEND PATCH] pnpbios: bail out on strange errors

2015-01-20 Thread Alan Cox
A small number of systems respond to PnP dock queries with bogus values. This causes us to keep logging an error every 2 seconds. Instead of trying again just assume the BIOS is crapware and doesn't actually have dock functionality. Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/pnp

Re: [PATCH] pcmcia: add missing include for new pci resource handler

2015-01-13 Thread Alan Cox
'find_io_region': > drivers/pcmcia/rsrc_pci.c:40:2: error: implicit declaration of function > 'pci_bus_alloc_resource' [-Werror=implicit-function-declaration] > > This adds the missing include statement. > > Signed-off-by: Arnd Bergmann > Cc: Alan Cox > Cc: Greg Kroah-Hartman >

Re: [PATCH] pcmcia: add missing include for new pci resource handler

2015-01-13 Thread Alan Cox
/pcmcia/rsrc_pci.c:40:2: error: implicit declaration of function 'pci_bus_alloc_resource' [-Werror=implicit-function-declaration] This adds the missing include statement. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Alan Cox a...@linux.intel.com Cc: Greg Kroah-Hartman gre

Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c

2015-01-12 Thread Alan Cox
On Mon, 2015-01-12 at 17:12 +0100, Thierry Reding wrote: > On Mon, Jan 12, 2015 at 01:29:27PM +0000, Alan Cox wrote: > > On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote: > > > Changes various calls in the functions,send_pkg_prepare and send_pkg_done > >

Re: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option

2015-01-12 Thread Alan Cox
On Mon, 2015-01-12 at 16:35 +0100, Arnd Bergmann wrote: > On Monday 12 January 2015 21:08:21 Eddie Huang wrote: > > Add earlycon support not only baudrate option, but also add noinit option. > > If use noinit option, 8250 earlycon will not init serial hardware and use > > loader setting. > > > >

Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c

2015-01-12 Thread Alan Cox
On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote: > Changes various calls in the functions,send_pkg_prepare and send_pkg_done > for mdelay to msleep. These changes are needed due to use working with > various sleep modes supported by this hardware and thus needing to sleep > for a small

Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c

2015-01-12 Thread Alan Cox
On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote: Changes various calls in the functions,send_pkg_prepare and send_pkg_done for mdelay to msleep. These changes are needed due to use working with various sleep modes supported by this hardware and thus needing to sleep for a small

Re: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option

2015-01-12 Thread Alan Cox
On Mon, 2015-01-12 at 16:35 +0100, Arnd Bergmann wrote: On Monday 12 January 2015 21:08:21 Eddie Huang wrote: Add earlycon support not only baudrate option, but also add noinit option. If use noinit option, 8250 earlycon will not init serial hardware and use loader setting.

Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c

2015-01-12 Thread Alan Cox
On Mon, 2015-01-12 at 17:12 +0100, Thierry Reding wrote: On Mon, Jan 12, 2015 at 01:29:27PM +, Alan Cox wrote: On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote: Changes various calls in the functions,send_pkg_prepare and send_pkg_done for mdelay to msleep. These changes

[PATCH] doubletalk: probe failure causes OOPS

2014-12-15 Thread Alan Cox
The code bothers to probe for the device, but on failing to find it proceeds to try and release a NULL resource, thereby ruining it's prior good behaviour Resolves-Bug: https://bugzilla.kernel.org/show_bug.cgi?id=88581 Signed-off-by: Alan Cox --- drivers/staging/speakup/speakup_dtlk.c |7

[PATCH] doubletalk: probe failure causes OOPS

2014-12-15 Thread Alan Cox
The code bothers to probe for the device, but on failing to find it proceeds to try and release a NULL resource, thereby ruining it's prior good behaviour Resolves-Bug: https://bugzilla.kernel.org/show_bug.cgi?id=88581 Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/staging/speakup

[PATCH] staging, addi_apci_1500: fix IRQ spew

2014-12-10 Thread Alan Cox
The driver very carefully checks if the card is the IRQ source, and if it isn't thoughtfully spews crap at_dev_warn() level. Remove the spewage so it can be used on a shared interrupt line. Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=88651 Signed-off-by: Alan Cox --- .../comedi

[PATCH] staging, addi_apci_1500: fix IRQ spew

2014-12-10 Thread Alan Cox
The driver very carefully checks if the card is the IRQ source, and if it isn't thoughtfully spews crap at_dev_warn() level. Remove the spewage so it can be used on a shared interrupt line. Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=88651 Signed-off-by: Alan Cox

[PATCH 5/5] pcmcia: add a new resource manager for non ISA systems

2014-12-04 Thread Alan Cox
On a pure PCI platform we don't actually need all the complexity of the rsrc_nonstatic manager, in fact we can just work directly with the pci allocators and avoid all the complexity (and code bloat). Signed-off-by: Alan Cox --- drivers/pcmcia/Kconfig| 12 ++- drivers/pcmcia/Makefile

[PATCH 4/5] pcmcia: handle anonymous cards by generating a fake CIS

2014-12-04 Thread Alan Cox
it to the wrong thing we only fix up apparently anonymous cards if the driver for them has been enabled. Signed-off-by: Alan Cox --- drivers/pcmcia/cistpl.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia

[PATCH 3/5] pcmcia: Fix requery

2014-12-04 Thread Alan Cox
The requery logic goes off and attempts to read the CIS of empty slots. In most cases this happens not to do any harm - but not all! Add the missing check and also a WARN() to catch any other offenders. Signed-off-by: Alan Cox --- drivers/pcmcia/cistpl.c |2 +- drivers/pcmcia/ds.c

[PATCH 2/5] pcmcia cis: on an out of range CIS read return 0xff, don't just warn

2014-12-04 Thread Alan Cox
The current code displays warnings but then proceeds to try and reference the data through the PCMCIA window. Instead return 0xff. This prevents bogus CIS data sending us off into hyperspace. Signed-off-by: Alan Cox --- drivers/pcmcia/cistpl.c |5 - 1 file changed, 4 insertions(+), 1

[PATCH 0/5] pcmcia: 64bit fixes, anonymous cards, other bugs

2014-12-04 Thread Alan Cox
less hideously convoluted resource manager that gets used when the only PCMCIA present is via PCI bridges. In that situation the core pci layer can do the job perfectly well for us and just needs a bit of wrapping. Alan --- Alan Cox (5): pcmcia: correct types pcmcia cis: on an out

[PATCH 1/5] pcmcia: correct types

2014-12-04 Thread Alan Cox
We should be using resource_size_t and unsigned types correctly, otherwise we sign extend the flags on a 64bit box, which is not what we want. Signed-off-by: Alan Cox --- drivers/pcmcia/cs_internal.h |6 +++--- drivers/pcmcia/rsrc_mgr.c|5 +++-- 2 files changed, 6 insertions(+), 5

[PATCH 1/5] pcmcia: correct types

2014-12-04 Thread Alan Cox
We should be using resource_size_t and unsigned types correctly, otherwise we sign extend the flags on a 64bit box, which is not what we want. Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/pcmcia/cs_internal.h |6 +++--- drivers/pcmcia/rsrc_mgr.c|5 +++-- 2 files changed

[PATCH 0/5] pcmcia: 64bit fixes, anonymous cards, other bugs

2014-12-04 Thread Alan Cox
less hideously convoluted resource manager that gets used when the only PCMCIA present is via PCI bridges. In that situation the core pci layer can do the job perfectly well for us and just needs a bit of wrapping. Alan --- Alan Cox (5): pcmcia: correct types pcmcia cis: on an out

[PATCH 2/5] pcmcia cis: on an out of range CIS read return 0xff, don't just warn

2014-12-04 Thread Alan Cox
The current code displays warnings but then proceeds to try and reference the data through the PCMCIA window. Instead return 0xff. This prevents bogus CIS data sending us off into hyperspace. Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/pcmcia/cistpl.c |5 - 1 file changed, 4

[PATCH 3/5] pcmcia: Fix requery

2014-12-04 Thread Alan Cox
The requery logic goes off and attempts to read the CIS of empty slots. In most cases this happens not to do any harm - but not all! Add the missing check and also a WARN() to catch any other offenders. Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/pcmcia/cistpl.c |2 +- drivers

[PATCH 4/5] pcmcia: handle anonymous cards by generating a fake CIS

2014-12-04 Thread Alan Cox
it to the wrong thing we only fix up apparently anonymous cards if the driver for them has been enabled. Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/pcmcia/cistpl.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/cistpl.c b

[PATCH 5/5] pcmcia: add a new resource manager for non ISA systems

2014-12-04 Thread Alan Cox
On a pure PCI platform we don't actually need all the complexity of the rsrc_nonstatic manager, in fact we can just work directly with the pci allocators and avoid all the complexity (and code bloat). Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/pcmcia/Kconfig| 12 ++- drivers

[PATCH] pcmcia: don't bale on invalid card headers

2014-10-14 Thread Alan Cox
There is no requirement a PCMCIA card has valid CIS data or even a CIS. The MTD layer correctly handles this but the core PCMCIA code erroneously refuses to accept the card and prevents the MTD driver from working in this case. Tested with an Apple Newton 1MB SRAM card. Signed-off-by: Alan Cox

[PATCH] pcmcia: don't bale on invalid card headers

2014-10-14 Thread Alan Cox
There is no requirement a PCMCIA card has valid CIS data or even a CIS. The MTD layer correctly handles this but the core PCMCIA code erroneously refuses to accept the card and prevents the MTD driver from working in this case. Tested with an Apple Newton 1MB SRAM card. Signed-off-by: Alan Cox

Re: [PATCH 03/12] serial_core: Handle TIOC[GS]RS485 ioctls.

2014-10-09 Thread Alan Cox
On Thu, 2014-10-09 at 10:07 +0200, Ricardo Ribalda Delgado wrote: > Hello Alan > > > > > What is the locking between setting/getting/driver use of the config ? > > This really needs a lock (termios sem I think is perhaps appropriate > > given when the values are normally referenced). > > I tried

Re: [PATCH 03/12] serial_core: Handle TIOC[GS]RS485 ioctls.

2014-10-09 Thread Alan Cox
On Thu, 2014-10-09 at 10:07 +0200, Ricardo Ribalda Delgado wrote: Hello Alan What is the locking between setting/getting/driver use of the config ? This really needs a lock (termios sem I think is perhaps appropriate given when the values are normally referenced). I tried

Re: [PATCH 03/12] serial_core: Handle TIOC[GS]RS485 ioctls.

2014-10-08 Thread Alan Cox
On Wed, 2014-10-08 at 22:43 +0200, Ricardo Ribalda Delgado wrote: > Hello Alan > > This patchset adds no extra locking features, if the drivers did not > implement a locking mechanism (and none did) there is chance of > conflict. > > I can add a call to lock/unlock around

Re: [PATCH 03/12] serial_core: Handle TIOC[GS]RS485 ioctls.

2014-10-08 Thread Alan Cox
On Wed, 2014-10-08 at 21:57 +0200, Ricardo Ribalda Delgado wrote: > The following drivers: 8250_core, atmel_serial, max310x, mcf, omap-serial > and sci16is7xx implement code to handle RS485 ioctls. > > +static int uart_get_rs485_config(struct uart_port *port, > + struct

Re: [PATCH 03/12] serial_core: Handle TIOC[GS]RS485 ioctls.

2014-10-08 Thread Alan Cox
On Wed, 2014-10-08 at 21:57 +0200, Ricardo Ribalda Delgado wrote: The following drivers: 8250_core, atmel_serial, max310x, mcf, omap-serial and sci16is7xx implement code to handle RS485 ioctls. +static int uart_get_rs485_config(struct uart_port *port, + struct

Re: [PATCH 03/12] serial_core: Handle TIOC[GS]RS485 ioctls.

2014-10-08 Thread Alan Cox
On Wed, 2014-10-08 at 22:43 +0200, Ricardo Ribalda Delgado wrote: Hello Alan This patchset adds no extra locking features, if the drivers did not implement a locking mechanism (and none did) there is chance of conflict. I can add a call to lock/unlock around uart_[gs]et_rs485_config. And

Re: vga and 64-bit memcpy's

2014-09-12 Thread Alan Cox
On Fri, 12 Sep 2014 13:57:20 +1000 Dave Airlie wrote: > Got an bug report from someone using a silicon motion video card in > VGA mode about corruption that they tracked down to 64-bit memory > operations not being supported by the video card, it appears that we > probably shouldn't be using >

Re: vga and 64-bit memcpy's

2014-09-12 Thread Alan Cox
On Fri, 12 Sep 2014 13:57:20 +1000 Dave Airlie airl...@gmail.com wrote: Got an bug report from someone using a silicon motion video card in VGA mode about corruption that they tracked down to 64-bit memory operations not being supported by the video card, it appears that we probably shouldn't

Re: [PATCH v5 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-09-09 Thread Alan Cox
accordingly. > > Signed-off-by: Matthias Brugger Reviewed-by: Alan Cox I'm happy with this version -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/maj

Re: [PATCH v5 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-09-09 Thread Alan Cox
. Signed-off-by: Matthias Brugger matthias@gmail.com Reviewed-by: Alan Cox a...@linux.intel.com I'm happy with this version -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-09-01 Thread Alan Cox
On Sun, 2014-08-31 at 13:02 -0700, Greg Kroah-Hartman wrote: > Adding Alan Cox, as he pushed this driver upstream... It's sort of a false positive. The existing code will work fine. Arguably all of this should be using the dma_ APIs. Alan -- To unsubscribe from this list: send the l

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-09-01 Thread Alan Cox
On Sun, 2014-08-31 at 13:02 -0700, Greg Kroah-Hartman wrote: Adding Alan Cox, as he pushed this driver upstream... It's sort of a false positive. The existing code will work fine. Arguably all of this should be using the dma_ APIs. Alan -- To unsubscribe from this list: send the line

Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-07 Thread Alan Cox
> + * Some baudrates are not supported by the chip, so we use the next > + * lower rate supported and update termios c_flag. I don't see the termios updating being done now ? > + data->clk = of_clk_get(np, 0); > + if (IS_ERR(data->clk)) { > + pr_warn("Can't get

Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-07 Thread Alan Cox
+ * Some baudrates are not supported by the chip, so we use the next + * lower rate supported and update termios c_flag. I don't see the termios updating being done now ? + data-clk = of_clk_get(np, 0); + if (IS_ERR(data-clk)) { + pr_warn(Can't get timer

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Alan Cox
On Tue, 2014-08-05 at 17:34 +0530, Varka Bhadram wrote: > On 08/05/2014 05:32 PM, Alan Cox wrote: > > On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: > >> On 08/05/2014 04:24 PM, Matthias Brugger wrote: > >> > >> (...) > >> > >>> +#i

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Alan Cox
On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: > On 08/05/2014 04:24 PM, Matthias Brugger wrote: > > (...) > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include "8250.h" > > + > > Better if we have

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Alan Cox
On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include linux/io.h +#include linux/module.h +#include linux/serial_8250.h +#include linux/of_irq.h +#include linux/of_platform.h +#include linux/platform_device.h

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Alan Cox
On Tue, 2014-08-05 at 17:34 +0530, Varka Bhadram wrote: On 08/05/2014 05:32 PM, Alan Cox wrote: On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include linux/io.h +#include linux/module.h +#include linux/serial_8250.h

Re: [PATCH] staging: goldfish: fix direct copy_to_user() from __iomem

2014-06-23 Thread Alan Cox
On Sun, 2014-06-22 at 03:29 -0400, James A Shackleford wrote: > This patch allocates a few pages and performs an ioread8_rep() from the bus > address, which are then copied to userspace. This fixes the sparse warning: > > drivers/staging/goldfish/goldfish_audio.c:136:43: warning: incorrect type

Re: [PATCH] staging: goldfish: fix direct copy_to_user() from __iomem

2014-06-23 Thread Alan Cox
On Sun, 2014-06-22 at 03:29 -0400, James A Shackleford wrote: This patch allocates a few pages and performs an ioread8_rep() from the bus address, which are then copied to userspace. This fixes the sparse warning: drivers/staging/goldfish/goldfish_audio.c:136:43: warning: incorrect type in

Re: Cannot partition 32GB disk on a 32bit machine (correct version of the patch this time)

2014-06-19 Thread Alan Cox
> Wow that's junk issued by an Exchange server ... Alan, really ... Blame evolution. It apparently thinks that if you follow up to your own email from one address it should randomly switch to another. > Do you have CONFIG_LBD turned on? That's supposed to let us go up to > about 16TB before we

Cannot partition 32GB disk on a 32bit machine

2014-06-19 Thread Alan Cox
The block code has 32bit cleanness problems with the iterator. This prevents things like partitioning a 32GB volume on a 32bit system. I hit this with a volume of exactly 32GB in size (easy to duplicate with virtual machines). Tracing at step by step through the kernel I found the problem lines

Cannot partition 32GB disk on a 32bit machine

2014-06-19 Thread Alan Cox
The block code has 32bit cleanness problems with the iterator. This prevents things like partitioning a 32GB volume on a 32bit system. I hit this with a volume of exactly 32GB in size (easy to duplicate with virtual machines). Tracing at step by step through the kernel I found the problem lines

Re: Cannot partition 32GB disk on a 32bit machine (correct version of the patch this time)

2014-06-19 Thread Alan Cox
Wow that's junk issued by an Exchange server ... Alan, really ... Blame evolution. It apparently thinks that if you follow up to your own email from one address it should randomly switch to another. Do you have CONFIG_LBD turned on? That's supposed to let us go up to about 16TB before we

Re: [PATCH] i2o/memory.c : Use kstrdup

2014-06-10 Thread Alan Cox
On Tue, 2014-06-10 at 21:41 +0530, Himangi Saraogi wrote: > Use kstrdup when the goal of an allocation is copy a string into the > allocated region. > > The Coccinelle semantic patch that makes this change is as follows: > > // > @@ > expression from,to; > expression flag,E1,E2; > statement S;

Re: [PATCH] i2o/memory.c : Use kstrdup

2014-06-10 Thread Alan Cox
On Tue, 2014-06-10 at 21:41 +0530, Himangi Saraogi wrote: Use kstrdup when the goal of an allocation is copy a string into the allocated region. The Coccinelle semantic patch that makes this change is as follows: // smpl @@ expression from,to; expression flag,E1,E2; statement S; @@

Re: [PATCH] x86/efi: Only pass mapped RAM regions to free_bootmem_late()

2014-06-05 Thread Alan Cox
On Thu, 5 Jun 2014 14:27:34 +0100 Matt Fleming wrote: > From: Matt Fleming > > free_bootmem_late() expects to only be passed RAM regions that the > kernel can access, and that have a corresponding 'struct page'. It's > possible for regions in the EFI memory map to reside in address ranges >

Re: [PATCH] x86/efi: Only pass mapped RAM regions to free_bootmem_late()

2014-06-05 Thread Alan Cox
On Thu, 5 Jun 2014 14:27:34 +0100 Matt Fleming m...@console-pimps.org wrote: From: Matt Fleming matt.flem...@intel.com free_bootmem_late() expects to only be passed RAM regions that the kernel can access, and that have a corresponding 'struct page'. It's possible for regions in the EFI

Re: [Fwd: Re: [goldfish] genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)]

2014-05-19 Thread Alan Cox
> > > 0day kernel testing robot got the below dmesg and the first bad commit is > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > > staging-next > > > commit 9b17aeec232a5f0a61ce3952c2e728a0eeddda8b I don't believe this one is actually a bug. Or rather it's an

Re: [Fwd: Re: [goldfish] genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)]

2014-05-19 Thread Alan Cox
0day kernel testing robot got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next commit 9b17aeec232a5f0a61ce3952c2e728a0eeddda8b I don't believe this one is actually a bug. Or rather it's an annoyance that was

Re: [PATCH staging-next] goldfish: pipe: fix warnings for 32bit builds

2014-05-16 Thread Alan Cox
-Wpointer-to-int-cast] >writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL); > > Reported-by: Fengguang Wu > Cc: Jun Tian > Cc: Alan Cox > Signed-off-by: Octavian Purdila Thanks... Both Acked-by: Alan Cox -- To unsubscribe from this list: send the line "unsub

Re: [PATCH staging-next] goldfish: pipe: fix warnings for 32bit builds

2014-05-16 Thread Alan Cox
+ PIPE_REG_CHANNEL); Reported-by: Fengguang Wu fengguang...@intel.com Cc: Jun Tian jun.j.t...@intel.com Cc: Alan Cox a...@linux.intel.com Signed-off-by: Octavian Purdila octavian.purd...@intel.com Thanks... Both Acked-by: Alan Cox a...@linux.intel.com -- To unsubscribe from this list: send

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-07 Thread Alan Cox
On Wed, 7 May 2014 14:42:48 -0700 Andrew Morton wrote: > On Wed, 7 May 2014 00:33:56 +0530 Raghavendra Ganiga > wrote: > > > This is a patch to add support for > > maxim dallas rtc ds1343 and ds1344 > > > > ... > > > > +static int ds1343_ioctl(struct device *dev, unsigned int cmd, unsigned

Re: [PATCH] libata-sff: remove dead code

2014-05-07 Thread Alan Cox
> > It was needed for some of the FRV devices I belive. Please check with > > David Howells if it's still relevant > > This code has been behind (effectively) an "#if 0" check for seven > years. So either there was no problem to begin with, the problem is > fixed somewhere else, or no one is

Re: [PATCH] [linux-next] pwm: lpss: fix const qualifier discard warning

2014-05-07 Thread Alan Cox
On Wed, 2014-05-07 at 10:41 +0200, Thierry Reding wrote: > On Fri, May 02, 2014 at 05:22:59PM +0200, Jan Moskyto Matejka wrote: > > Fixing this warning: > > drivers/pwm/pwm-lpss.c: In function ‘pwm_lpss_probe_pci’: > > drivers/pwm/pwm-lpss.c:192:2: warning: passing argument 3 of > >

Re: [PATCH] [linux-next] pwm: lpss: fix const qualifier discard warning

2014-05-07 Thread Alan Cox
On Wed, 2014-05-07 at 10:41 +0200, Thierry Reding wrote: On Fri, May 02, 2014 at 05:22:59PM +0200, Jan Moskyto Matejka wrote: Fixing this warning: drivers/pwm/pwm-lpss.c: In function ‘pwm_lpss_probe_pci’: drivers/pwm/pwm-lpss.c:192:2: warning: passing argument 3 of ‘pwm_lpss_probe’

Re: [PATCH] libata-sff: remove dead code

2014-05-07 Thread Alan Cox
It was needed for some of the FRV devices I belive. Please check with David Howells if it's still relevant This code has been behind (effectively) an #if 0 check for seven years. So either there was no problem to begin with, the problem is fixed somewhere else, or no one is actually using

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-07 Thread Alan Cox
On Wed, 7 May 2014 14:42:48 -0700 Andrew Morton a...@linux-foundation.org wrote: On Wed, 7 May 2014 00:33:56 +0530 Raghavendra Ganiga ravi23gan...@gmail.com wrote: This is a patch to add support for maxim dallas rtc ds1343 and ds1344 ... +static int ds1343_ioctl(struct device

Re: [PATCH] libata-sff: remove dead code

2014-05-06 Thread Alan Cox
On Sun, 2014-05-04 at 13:50 +0200, Paul Bolle wrote: > Ever since v2.6.19 the code contains a check for CONFIG_NO_ATA_LEGACY. > But that macro has never been defined. Apparently no one ran into > problems on platforms that do not support compatibility mode. It was needed for some of the FRV

Re: [PATCH] libata-sff: remove dead code

2014-05-06 Thread Alan Cox
On Sun, 2014-05-04 at 13:50 +0200, Paul Bolle wrote: Ever since v2.6.19 the code contains a check for CONFIG_NO_ATA_LEGACY. But that macro has never been defined. Apparently no one ran into problems on platforms that do not support compatibility mode. It was needed for some of the FRV devices

[PATCH] goldfish bus: don't call request_mem_region

2014-04-28 Thread Alan Cox
This is a bug fix that has been lurking in the Google tree but not pushed upstream. From: Octavian Purdila The memory region is already reserved in goldfish_init() during platform init. Signed-off-by: Octavian Purdila Signed-off-by: Jun Tian Signed-off-by: Alan Cox --- drivers/platform

[PATCH] goldfish bus: don't call request_mem_region

2014-04-28 Thread Alan Cox
jun.j.t...@intel.com Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/platform/goldfish/pdev_bus.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/platform/goldfish/pdev_bus.c b/drivers/platform/goldfish/pdev_bus.c index 92cc4cf..4eb2bb3 100644 --- a/drivers/platform

Re: [PATCH 4/8] tty/serial: add generic serial earlycon

2014-04-17 Thread Alan Cox
> At some point it was believed to be needed on the 8250 driver. Perhaps > Alan can comment since the commit message tells us nothing: Don't remember sorry - I guess at the time someone had ioremap on their plaform acting as cached. It was a long time ago 8) -- To unsubscribe from this list: send

Re: [PATCH 4/8] tty/serial: add generic serial earlycon

2014-04-17 Thread Alan Cox
At some point it was believed to be needed on the 8250 driver. Perhaps Alan can comment since the commit message tells us nothing: Don't remember sorry - I guess at the time someone had ioremap on their plaform acting as cached. It was a long time ago 8) -- To unsubscribe from this list: send

Re: hci_ldsic nested locking problem

2014-03-20 Thread Alan Cox
On Thu, 2014-03-20 at 11:34 -0500, Felipe Balbi wrote: > Hi, > > when 8250 driver calls uart_write_wakeup(), the tty port lock is already > taken. hci_ldisc.c's implementation of ->write_wakeup() calls > tty->ops->write() to actually send the characters, but that call will > try to acquire the

Re: hci_ldsic nested locking problem

2014-03-20 Thread Alan Cox
On Thu, 2014-03-20 at 11:34 -0500, Felipe Balbi wrote: Hi, when 8250 driver calls uart_write_wakeup(), the tty port lock is already taken. hci_ldisc.c's implementation of -write_wakeup() calls tty-ops-write() to actually send the characters, but that call will try to acquire the same port

Re: [PATCH] drivers/tty/serial: deal with 8250_core.c uninitialized warning for good

2014-02-19 Thread Alan Cox
t get as far as > the maintainers or the mailing lists. Are people still using gcc variants that get this wrong ? Fine by me. Acked-by: Alan Cox -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] drivers/tty/serial: deal with 8250_core.c uninitialized warning for good

2014-02-19 Thread Alan Cox
or the mailing lists. Are people still using gcc variants that get this wrong ? Fine by me. Acked-by: Alan Cox a...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 34/52] devices.txt: add video4linux device for Software Defined Radio

2014-02-04 Thread Alan Cox
namically > nowadays, but there is still configuration option for old fixed style. > Add note to mention that configuration option too. > > Cc: Hans Verkuil > Signed-off-by: Antti Palosaari > Acked-by: Hans Verkuil Acked-by: Alan Cox -- To unsubscribe from this list: send t

Re: [PATCH 34/52] devices.txt: add video4linux device for Software Defined Radio

2014-02-04 Thread Alan Cox
configuration option for old fixed style. Add note to mention that configuration option too. Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi Acked-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Alan Cox a...@linux.intel.com -- To unsubscribe from this list

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-27 Thread Alan Cox
> Either everything is dynamic, or everything follows proper minor > assignment process. Ultimately everything should probably be dynamic, but trying to get there in one step will simply mean we never get there at all. Alan -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-27 Thread Alan Cox
Either everything is dynamic, or everything follows proper minor assignment process. Ultimately everything should probably be dynamic, but trying to get there in one step will simply mean we never get there at all. Alan -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-26 Thread Alan Cox
On Sun, 26 Jan 2014 22:09:07 +0100 Pavel Machek wrote: > On Thu 2014-01-23 19:36:33, Mark Brown wrote: > > On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote: > > > On 23.01.2014 19:40, Mark Brown wrote: > > > > > >We'd need to leave it user selectable rather than enabling it for ARM,

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-26 Thread Alan Cox
On Sun, 26 Jan 2014 22:09:07 +0100 Pavel Machek pa...@ucw.cz wrote: On Thu 2014-01-23 19:36:33, Mark Brown wrote: On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote: On 23.01.2014 19:40, Mark Brown wrote: We'd need to leave it user selectable rather than enabling it for ARM,

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-24 Thread Alan Cox
On Fri, 24 Jan 2014 12:03:09 + Mark Brown wrote: > On Thu, Jan 23, 2014 at 09:33:21PM +0000, Alan Cox wrote: > > Mark Brown wrote: > > > > I don't see how we can meaningfully test this on a platform - the kernel > > > would have to be pretty demented to c

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-24 Thread Alan Cox
On Fri, 24 Jan 2014 12:03:09 + Mark Brown broo...@kernel.org wrote: On Thu, Jan 23, 2014 at 09:33:21PM +, Alan Cox wrote: Mark Brown broo...@kernel.org wrote: I don't see how we can meaningfully test this on a platform - the kernel would have to be pretty demented to care, it's

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-23 Thread Alan Cox
On Thu, 23 Jan 2014 20:05:09 + Mark Brown wrote: > On Thu, Jan 23, 2014 at 07:51:44PM +0000, Alan Cox wrote: > > > That strikes me as rather more risky. We can propogate it through the > > drivers as we are sure it is safe to do so on that platform and encourage

<    4   5   6   7   8   9   10   11   12   13   >