On Thu, Jan 10, 2008 at 12:43:19AM +0100, [EMAIL PROTECTED] wrote:
oh, nice to see that this is still alive.
at least i got no crashes and was able to mount and acess more than 300
iso-images with that.
were there fixes/chances since then?
Little has changed for some time - mostly code
On Wed, Jan 09, 2008 at 03:31:00PM -0800, Vadim Lobanov wrote:
From 2.6.23's fs/ioctl.c - do_ioctl():
Ah - you're talking about struct file_operations of course;
I was talking about struct block_device_operations.
Alasdair
--
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line
From: Neil Brown <[EMAIL PROTECTED]>
Make sure dm honours max_hw_sectors of underlying devices
We still have no firm testing evidence in support of this patch but
believe it may help to resolve some bug reports. - agk
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
Signed-off-by
ns too) instead of constructing own biovec.
All versions of dm-crypt are affected by this bug.
Cc: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-crypt.c | 24 +++
From: Milan Broz <[EMAIL PROTECTED]>
Fix BIO_UPTODATE test for write io.
Cc: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-crypt.c |7 ---
1 files changed,
From: Alasdair G Kergon <[EMAIL PROTECTED]>
Insert a missing KOBJ_CHANGE notification when a device is renamed.
Cc: Scott James Remnant <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-ioctl.c |2 ++
drivers/md/dm.c |7 +
AP} bs=${SIZE} count=1 &
echo "Wait til dd push some I/O"
sleep 5
dmsetup resume ${MAP}
--
Cc: [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[
Mundt <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/Kconfig |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.24-rc5/drivers/md/Kconfig
===
--- linux-2.6.2
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git
to get the following device-mapper fixes for 2.6.24:
Alasdair G Kergon (1):
dm: trigger change uevent on rename
Jun'ichi Nomura (1):
dm: table detect io beyond device
Milan Broz (2):
dm
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git
to get the following device-mapper fixes for 2.6.24:
Alasdair G Kergon (1):
dm: trigger change uevent on rename
Jun'ichi Nomura (1):
dm: table detect io beyond device
Milan Broz (2):
dm
dd push some I/O
sleep 5
dmsetup resume ${MAP}
--
Cc: [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-ioctl.c | 10 +++---
drivers
PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/Kconfig |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.24-rc5/drivers/md/Kconfig
===
--- linux-2.6.24-rc5.orig/drivers/md
From: Milan Broz [EMAIL PROTECTED]
Fix BIO_UPTODATE test for write io.
Cc: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Signed-off-by: Milan Broz [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-crypt.c |7 ---
1 files changed, 4 insertions(+), 3
From: Alasdair G Kergon [EMAIL PROTECTED]
Insert a missing KOBJ_CHANGE notification when a device is renamed.
Cc: Scott James Remnant [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-ioctl.c |2 ++
drivers/md/dm.c |7 ++-
drivers/md/dm.h
From: Neil Brown [EMAIL PROTECTED]
Make sure dm honours max_hw_sectors of underlying devices
We still have no firm testing evidence in support of this patch but
believe it may help to resolve some bug reports. - agk
Signed-off-by: Neil Brown [EMAIL PROTECTED]
Signed-off-by: Alasdair G
) instead of constructing own biovec.
All versions of dm-crypt are affected by this bug.
Cc: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Signed-off-by: Milan Broz [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-crypt.c | 24 +++-
1 files
On Thu, Dec 06, 2007 at 11:04:12PM +0100, Kay Sievers wrote:
> A fix for LVM to handle symlinks instead of directories is in the LVM
> CVS tree, but there wasn't a release since August.
I released it yesterday:-)
Alasdair
--
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line
On Thu, Dec 06, 2007 at 11:04:12PM +0100, Kay Sievers wrote:
A fix for LVM to handle symlinks instead of directories is in the LVM
CVS tree, but there wasn't a release since August.
I released it yesterday:-)
Alasdair
--
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line
On Sat, Nov 24, 2007 at 01:18:35PM +0100, Torsten Kaiser wrote:
> I will reapply agk-dm-dm-crypt-move-bio-submission-to-thread.patch and
> this patch and boot several times
OK for a test system, but until the write loop problem is addressed I believe
there's a risk of data corruption under low
On Sat, Nov 24, 2007 at 01:18:35PM +0100, Torsten Kaiser wrote:
I will reapply agk-dm-dm-crypt-move-bio-submission-to-thread.patch and
this patch and boot several times
OK for a test system, but until the write loop problem is addressed I believe
there's a risk of data corruption under low
On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote:
> Before the cleanup *all* calls to crypt_dec_pending() was via crypt_endio().
> Now there is an additional call to crypt_dec_pending() to balance the
> additional ref placed into crypt_write_io_process(). And that one is
> not called
Also io->pending may need better protection - atomic, but missing memory
barriers? (May be getting away without sometimes due to side-effects of
other function calls, but needs doing properly.)
[BTW Other device-mapper atomic_t usage also needs reviewing.]
Alasdair
--
[EMAIL PROTECTED]
-
To
On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote:
> ... or I just don't see the bug.
See my earlier post in this thread: there's a race in the write loop
where a work struct could be used twice on the same queue.
(Needs data structure change to fix that, which nobody has attempted
Also io-pending may need better protection - atomic, but missing memory
barriers? (May be getting away without sometimes due to side-effects of
other function calls, but needs doing properly.)
[BTW Other device-mapper atomic_t usage also needs reviewing.]
Alasdair
--
[EMAIL PROTECTED]
-
To
On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote:
... or I just don't see the bug.
See my earlier post in this thread: there's a race in the write loop
where a work struct could be used twice on the same queue.
(Needs data structure change to fix that, which nobody has attempted
On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote:
Before the cleanup *all* calls to crypt_dec_pending() was via crypt_endio().
Now there is an additional call to crypt_dec_pending() to balance the
additional ref placed into crypt_write_io_process(). And that one is
not called
On Tue, Nov 20, 2007 at 03:40:30PM +0100, Milan Broz wrote:
> (Note comment in code "It is permissible to free the struct
> work_struct from inside the function that is called from it".)
I don't understand yet how lockdep behaves if the work struct gets
reused and the reused one finishes first.
On Tue, Nov 20, 2007 at 03:40:30PM +0100, Milan Broz wrote:
(Note comment in code It is permissible to free the struct
work_struct from inside the function that is called from it.)
I don't understand yet how lockdep behaves if the work struct gets
reused and the reused one finishes first.
I
On Mon, Nov 12, 2007 at 01:33:21PM +0100, Toralf Förster wrote:
> the build with the attached .config failed, make ends with:
> drivers/built-in.o: In function `hp_sw_end_io':
> dm-mpath-hp-sw.c:(.text+0xb0596): undefined reference to `__scsi_print_sense'
> make: *** [.tmp_vmlinux1] Error 1
Does
On Mon, Nov 12, 2007 at 01:33:21PM +0100, Toralf Förster wrote:
the build with the attached .config failed, make ends with:
drivers/built-in.o: In function `hp_sw_end_io':
dm-mpath-hp-sw.c:(.text+0xb0596): undefined reference to `__scsi_print_sense'
make: *** [.tmp_vmlinux1] Error 1
Does
On Wed, Oct 31, 2007 at 05:00:16PM -0500, Kiyoshi Ueda wrote:
> How about the case that other dm device is stacked on the dm device?
> (e.g. dm-linear over dm-multipath over i2o with bounce_pfn=64GB, and
> the multipath table is changed to i2o with bounce_pfn=1GB.)
Let's not broaden the
On Wed, Oct 31, 2007 at 05:00:16PM -0500, Kiyoshi Ueda wrote:
How about the case that other dm device is stacked on the dm device?
(e.g. dm-linear over dm-multipath over i2o with bounce_pfn=64GB, and
the multipath table is changed to i2o with bounce_pfn=1GB.)
Let's not broaden the
On Wed, Oct 31, 2007 at 02:01:33AM +, Alasdair G Kergon wrote:
> What if you swap in alternative dm targets, e.g. if it's linear,
> try multipath (round-robin, one path)?
And try using md instead of dm - does that also show the problem?
(md takes a similar stance to dm on this I b
On Tue, Oct 30, 2007 at 11:26:17PM +, Alasdair G Kergon wrote:
> ) DM doesn't need to bounce bio's on its own, but the block layer defaults
> ) to that in blk_queue_make_request(). The lower level drivers should
> ) bounce ios themselves, that is what they need to do if not laye
On Tue, Oct 30, 2007 at 01:11:38PM -0700, Andrew Morton wrote:
> On Mon, 29 Oct 2007 09:31:39 +0300
> Vasily Averin <[EMAIL PROTECTED]> wrote:
> > Device mapper uses its own bounce_pfn that may differ from one on underlying
> > device. In that way dm can build incorrect requests that contain sg
On Tue, Oct 30, 2007 at 01:11:38PM -0700, Andrew Morton wrote:
On Mon, 29 Oct 2007 09:31:39 +0300
Vasily Averin [EMAIL PROTECTED] wrote:
Device mapper uses its own bounce_pfn that may differ from one on underlying
device. In that way dm can build incorrect requests that contain sg elements
On Tue, Oct 30, 2007 at 11:26:17PM +, Alasdair G Kergon wrote:
) DM doesn't need to bounce bio's on its own, but the block layer defaults
) to that in blk_queue_make_request(). The lower level drivers should
) bounce ios themselves, that is what they need to do if not layered below
) dm
On Wed, Oct 31, 2007 at 02:01:33AM +, Alasdair G Kergon wrote:
What if you swap in alternative dm targets, e.g. if it's linear,
try multipath (round-robin, one path)?
And try using md instead of dm - does that also show the problem?
(md takes a similar stance to dm on this I believe
On Thu, Oct 25, 2007 at 02:46:17PM -0400, Jun'ichi Nomura wrote:
> So as far as I understand, the point is:
> 1. it's preferable to resize inode after the resume, if possible
Not quite - I'm not expressing a preference yet.
I'm saying the patches you presented were one option to resolve the
On Thu, Oct 25, 2007 at 10:18:02AM -0400, Jun'ichi Nomura wrote:
> There is no guarantee that the I/O flowing through the device again.
> The table might need be replaced again, but to do that, the resume
> should have been completed to let the userspace know it.
Then the first attempt to set the
On Thu, Oct 25, 2007 at 10:18:02AM -0400, Jun'ichi Nomura wrote:
There is no guarantee that the I/O flowing through the device again.
The table might need be replaced again, but to do that, the resume
should have been completed to let the userspace know it.
Then the first attempt to set the
On Thu, Oct 25, 2007 at 02:46:17PM -0400, Jun'ichi Nomura wrote:
So as far as I understand, the point is:
1. it's preferable to resize inode after the resume, if possible
Not quite - I'm not expressing a preference yet.
I'm saying the patches you presented were one option to resolve the
On Wed, Oct 24, 2007 at 05:25:17PM -0400, Jun'ichi Nomura wrote:
> - For some device-mapper targets (multipath and mirror),
> the mapping table sometimes has to be replaced to cope with device
> failure.
> OTOH, device-mapper flushes all pending I/Os upon table replacement
> and
On Wed, Oct 24, 2007 at 05:25:17PM -0400, Jun'ichi Nomura wrote:
- For some device-mapper targets (multipath and mirror),
the mapping table sometimes has to be replaced to cope with device
failure.
OTOH, device-mapper flushes all pending I/Os upon table replacement
and may
From: Mike Anderson <[EMAIL PROTECTED]>
This patch adds a function to obtain a copy of a mapped device's name and uuid.
Signed-off-by: Mike Anderson <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-ioct
From: Mike Anderson <[EMAIL PROTECTED]>
This patch adds calls to dm_path_event for a failed path and a reinstated
path.
Signed-off-by: Mike Anderson <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-mpath.c |7 +++
1 files cha
From: Mike Anderson <[EMAIL PROTECTED]>
This patch adds support for the dm_path_event dm_send_event functions which
create and send udev events.
Signed-off-by: Mike Anderson <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
Documentation/device-ma
From: Mike Anderson <[EMAIL PROTECTED]>
This patch adds a uevent skeleton to device-mapper.
Signed-off-by: Mike Anderson <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/Kconfig |6
drivers/md/Makefile|4 ++
driv
From: Mike Anderson [EMAIL PROTECTED]
This patch adds a uevent skeleton to device-mapper.
Signed-off-by: Mike Anderson [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/Kconfig |6
drivers/md/Makefile|4 ++
drivers/md/dm-uevent.c | 72
From: Mike Anderson [EMAIL PROTECTED]
This patch adds a function to obtain a copy of a mapped device's name and uuid.
Signed-off-by: Mike Anderson [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-ioctl.c | 32
From: Mike Anderson [EMAIL PROTECTED]
This patch adds calls to dm_path_event for a failed path and a reinstated
path.
Signed-off-by: Mike Anderson [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-mpath.c |7 +++
1 files changed, 7 insertions
From: Mike Anderson [EMAIL PROTECTED]
This patch adds support for the dm_path_event dm_send_event functions which
create and send udev events.
Signed-off-by: Mike Anderson [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
Documentation/device-mapper/dm-uevent.txt | 97
On Sat, Oct 13, 2007 at 12:16:29AM +0200, Arnd Bergmann wrote:
> This change seems rather bogus, you're changing the ABI just to work
> around a bug in the compat_ioctl layer. Why not just do the compat
> code the right way, like the patch below?
The underlying ABI is not changing, I hope - the
On Sat, Oct 13, 2007 at 12:16:29AM +0200, Arnd Bergmann wrote:
This change seems rather bogus, you're changing the ABI just to work
around a bug in the compat_ioctl layer. Why not just do the compat
code the right way, like the patch below?
The underlying ABI is not changing, I hope - the
From: Jonathan Brassow <[EMAIL PROTECTED]>
Store a pointer to the owning mirror_set structure within each mirror
structure for a subsequent patch to use.
Signed-off-by: Jonathan Brassow <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md
mapper.
A subsequent patch will make use of 'presuspend'.
Signed-off-by: Jonathan Brassow <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-log.c |2 +-
drivers/md/dm-log.h |3 ++-
drivers/md/dm-raid1.c |2 +-
3 files changed,
ochanski <[EMAIL PROTECTED]>
Acked-by: Chandra Seetharaman <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-mpath-hp-sw.c | 64
1 files changed, 53 insertions(+), 11 deletions(-)
Index: linux-
er of PG retries attempted is reported in the 'dmsetup status' output.
Signed-off-by: Dave Wysochanski <[EMAIL PROTECTED]>
Acked-by: Mike Christie <[EMAIL PROTECTED]>
Acked-by: Chandra Seetharaman <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
-
IL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/Kconfig |6 +
drivers/md/Makefile |2
drivers/md/dm-mpath-hp-sw.c | 206
3 files changed, 214 insertions(+)
Index: l
From: Milan Broz <[EMAIL PROTECTED]>
Replace numbers with names in labels in error paths, to avoid confusion
when new one get added between existing ones.
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md
From: Milan Broz <[EMAIL PROTECTED]>
Clean up, convert some spaces to tabs.
No functional change here.
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-crypt.c | 36 ++--
1
From: Milan Broz <[EMAIL PROTECTED]>
Add crypt prefix to dec_pending to avoid confusing it in backtraces with
the dm core function of the same name.
No functional change here.
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
ration
is queued after these requests (in the same queue).
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-crypt.c | 67 ++-
From: Milan Broz <[EMAIL PROTECTED]>
Use a separate single-threaded workqueue for each crypt device
instead of one global workqueue.
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md
From: Alasdair G Kergon <[EMAIL PROTECTED]>
Correct an error message, reported by Michael Wood <[EMAIL PROTECTED]>.
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-emc.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.23/d
From: Alasdair G Kergon <[EMAIL PROTECTED]>
Remove BIO_LIST and DEFINE_BIO_LIST macros that gain us nothing
since contents are initialised to NULL.
Cc: Jan Engelhardt <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-bio-list.h |5
From: Jesper Juhl <[EMAIL PROTECTED]>
In drivers/md/dm-ioctl.c::copy_params() there's a call to vmalloc()
where we currently cast the return value, but that's pretty pointless
given that vmalloc() returns "void *".
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Signed-off
From: Milan Broz <[EMAIL PROTECTED]>
Use bio_io_error() in only two places and tidy the code,
preparing for later patches.
There is no functional change in this patch.
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
driv
From: Milan Broz <[EMAIL PROTECTED]>
Use bio_io_error() in only two places and tidy the code,
preparing for later patches.
There is no functional change in this patch.
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
driv
From: Matthias Kaehlcke <[EMAIL PROTECTED]>
Kcopyd uses a semaphore as mutex. Use the mutex API instead of the (binary)
semaphore,
Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]>
Cc: Neil Brown <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]&g
From: vignesh babu <[EMAIL PROTECTED]>
Replacing n & (n - 1) for power of 2 check by is_power_of_2(n)
Signed-off-by: vignesh babu <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-raid1.c |3 ++-
drivers/md/dm-snap.c |
From: Dmitry Monakhov <[EMAIL PROTECTED]>
Convert kmalloc() + memset() to kzalloc().
Signed-off-by: Dmitry Monakhov <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-emc.c |6 ++
drivers/md/dm-hw-handler.c|6
From: Milan Broz <[EMAIL PROTECTED]>
Fix missing space in dm-delay target status output
if separate read and write delay are configured.
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-delay.c |2 +-
a <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
---
drivers/md/dm.c |4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
Index: linux-2.6.23/drivers/md/dm.c
===
---
From: Dmitry Monakhov <[EMAIL PROTECTED]>
Add missing 'dm_put_device' to dm-delay target constructor.
Signed-off-by: Dmitry Monakhov <[EMAIL PROTECTED]>
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
driv
From: Dmitry Monakhov <[EMAIL PROTECTED]>
Add missing 'dm_io_client_destroy' to alloc_context error path.
Reorganize mirror constructor error path in order to prevent
workqueue leakage.
Signed-off-by: Dmitry Monakhov <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[
From: Dmitry Monakhov <[EMAIL PROTECTED]>
Insert missing kfree() in crypt_iv_essiv_ctr() error path.
Signed-off-by: Dmitry Monakhov <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
---
drivers/md/dm-crypt.c |1 +
1 files changed, 1 insertion(+)
I
From: Dmitry Monakhov <[EMAIL PROTECTED]>
Add a missing 'dm_put_device' in an error path in crypt target constructor.
Signed-off-by: Dmitry Monakhov <[EMAIL PROTECTED]>
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
--
remove it.)
Signed-off-by: Milan Broz <[EMAIL PROTECTED]>
Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
Cc: Guido Guenther <[EMAIL PROTECTED]>
Cc: Kevin Corry <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
---
drivers/md/dm-ioctl.c|6 +++---
include/linux/dm-ioctl.h |
From: Bryn M. Reeves <[EMAIL PROTECTED]>
Re-order the initialisation of dm-rdac to avoid registering the hw
handler before the workqueue has been initialised. Closes a race
that would potentially give an oops.
Signed-off-by: Bryn M. Reeves <[EMAIL PROTECTED]>
Signed-off-by: Alasd
From: Dmitry Monakhov [EMAIL PROTECTED]
Add missing 'dm_io_client_destroy' to alloc_context error path.
Reorganize mirror constructor error path in order to prevent
workqueue leakage.
Signed-off-by: Dmitry Monakhov [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers
From: Bryn M. Reeves [EMAIL PROTECTED]
Re-order the initialisation of dm-rdac to avoid registering the hw
handler before the workqueue has been initialised. Closes a race
that would potentially give an oops.
Signed-off-by: Bryn M. Reeves [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL
.
A subsequent patch will make use of 'presuspend'.
Signed-off-by: Jonathan Brassow [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-log.c |2 +-
drivers/md/dm-log.h |3 ++-
drivers/md/dm-raid1.c |2 +-
3 files changed, 4 insertions(+), 3 deletions
is reported in the 'dmsetup status' output.
Signed-off-by: Dave Wysochanski [EMAIL PROTECTED]
Acked-by: Mike Christie [EMAIL PROTECTED]
Acked-by: Chandra Seetharaman [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
[AGK TODO: Perform a fresh review of the state machine changes
-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/Kconfig |6 +
drivers/md/Makefile |2
drivers/md/dm-mpath-hp-sw.c | 206
3 files changed, 214 insertions(+)
Index: linux-2.6.23/drivers/md/Kconfig
From: Milan Broz [EMAIL PROTECTED]
Replace numbers with names in labels in error paths, to avoid confusion
when new one get added between existing ones.
Signed-off-by: Milan Broz [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-crypt.c | 38
From: Milan Broz [EMAIL PROTECTED]
Clean up, convert some spaces to tabs.
No functional change here.
Signed-off-by: Milan Broz [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-crypt.c | 36 ++--
1 files changed, 18
From: Milan Broz [EMAIL PROTECTED]
Use a separate single-threaded workqueue for each crypt device
instead of one global workqueue.
Signed-off-by: Milan Broz [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-crypt.c | 32 ++--
1
From: Milan Broz [EMAIL PROTECTED]
Use bio_io_error() in only two places and tidy the code,
preparing for later patches.
There is no functional change in this patch.
Signed-off-by: Milan Broz [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm.c | 37
From: Matthias Kaehlcke [EMAIL PROTECTED]
Kcopyd uses a semaphore as mutex. Use the mutex API instead of the (binary)
semaphore,
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
Cc: Neil Brown [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
Signed-off-by: Andrew Morton
From: vignesh babu [EMAIL PROTECTED]
Replacing n (n - 1) for power of 2 check by is_power_of_2(n)
Signed-off-by: vignesh babu [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-raid1.c |3 ++-
drivers/md/dm-snap.c |3 ++-
drivers/md/dm-stripe.c
From: Milan Broz [EMAIL PROTECTED]
Fix missing space in dm-delay target status output
if separate read and write delay are configured.
Signed-off-by: Milan Broz [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-delay.c |2 +-
1 files changed, 1
From: Dmitry Monakhov [EMAIL PROTECTED]
Add missing 'dm_put_device' to dm-delay target constructor.
Signed-off-by: Dmitry Monakhov [EMAIL PROTECTED]
Signed-off-by: Milan Broz [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-delay.c | 19
From: Jonathan Brassow [EMAIL PROTECTED]
Store a pointer to the owning mirror_set structure within each mirror
structure for a subsequent patch to use.
Signed-off-by: Jonathan Brassow [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-raid1.c |2 ++
1
From: Alasdair G Kergon [EMAIL PROTECTED]
Correct an error message, reported by Michael Wood [EMAIL PROTECTED].
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-emc.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.23/drivers/md/dm-emc.c
From: Alasdair G Kergon [EMAIL PROTECTED]
Remove BIO_LIST and DEFINE_BIO_LIST macros that gain us nothing
since contents are initialised to NULL.
Cc: Jan Engelhardt [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-bio-list.h |5 -
drivers/md/dm
From: Jesper Juhl [EMAIL PROTECTED]
In drivers/md/dm-ioctl.c::copy_params() there's a call to vmalloc()
where we currently cast the return value, but that's pretty pointless
given that vmalloc() returns void *.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL
-by: Alasdair G Kergon [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
drivers/md/dm.c |4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
Index: linux-2.6.23/drivers/md/dm.c
===
--- linux-2.6.23.orig/drivers/md/dm.c 2007-10
From: Dmitry Monakhov [EMAIL PROTECTED]
Insert missing kfree() in crypt_iv_essiv_ctr() error path.
Signed-off-by: Dmitry Monakhov [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-crypt.c |1 +
1 files changed, 1 insertion(+)
Index: linux-2.6.23/drivers
From: Dmitry Monakhov [EMAIL PROTECTED]
Add a missing 'dm_put_device' in an error path in crypt target constructor.
Signed-off-by: Dmitry Monakhov [EMAIL PROTECTED]
Signed-off-by: Milan Broz [EMAIL PROTECTED]
Signed-off-by: Alasdair G Kergon [EMAIL PROTECTED]
---
drivers/md/dm-crypt.c |4
201 - 300 of 518 matches
Mail list logo
