Re: [PATCH 76/85] drivers: gpu: Move prototype declaration to header file radeon_drv.h from radeon_drv.c

2014-01-07 Thread Alex Deucher
On Mon, Jan 6, 2014 at 11:41 AM, Rashika Kheria rashika.khe...@gmail.com wrote: Move prototype declaration of function radeon_kms_compat_ioctl() to header file drm/radeon/radeon_drv.h because it is used by more than one file. This eliminates the following warning in

Re: [PATCH 22/85] drivers: gpu: Mark functions as static in radeon_device.c

2014-01-08 Thread Alex Deucher
On Mon, Jan 6, 2014 at 10:21 AM, Rashika Kheria rashika.khe...@gmail.com wrote: Mark functions radeon_doorbell_init() and radeon_doorbell_fini() as static in drm/radeon/radeon_device.c because they are not used outside this file. This eliminates the following warning in

Re: [PATCH 22/85] drivers: gpu: Mark functions as static in radeon_device.c

2014-01-09 Thread Alex Deucher
On Wed, Jan 8, 2014 at 7:07 PM, Josh Triplett j...@joshtriplett.org wrote: On Wed, Jan 08, 2014 at 11:40:28AM -0500, Alex Deucher wrote: On Mon, Jan 6, 2014 at 10:21 AM, Rashika Kheria rashika.khe...@gmail.com wrote: Mark functions radeon_doorbell_init() and radeon_doorbell_fini() as static

Re: [RESEND PATCH] drm: Add 800x600 (SVGA) screen resolution to the built-in EDIDs

2014-04-28 Thread Alex Deucher
checksum checks. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- Documentation/EDID/1024x768.S | 2 +- Documentation/EDID/1280x1024.S | 2 +- Documentation/EDID/1600x1200.S | 2 +- Documentation/EDID/1680x1050.S | 2

Re: Lenovo x120e resume regression in 3.15-rc1 bisected to 'drm/crtc-helpers: fix dpms on logic'

2014-05-02 Thread Alex Deucher
haven't had a chance to unwind all the logic in the crtc helper code. Alex From dc318b2c8583d3726c64177024d777c9408d3538 Mon Sep 17 00:00:00 2001 From: Alex Deucher alexander.deuc...@amd.com Date: Fri, 2 May 2014 13:18:23 -0400 Subject: [PATCH] drm/radeon: force connector dpm state to ON on modeset We

Re: [git pull] drm fixes

2014-04-19 Thread Alex Deucher
On Sat, Apr 19, 2014 at 3:03 PM, Markus Trippelsdorf mar...@trippelsdorf.de wrote: On 2014.04.19 at 08:19 +0100, Dave Airlie wrote: Unfortunately this contains no easter eggs, its a bit larger than I'd like, but I included a patch that just moves code from one file to another and I'd like to

Re: 3.15.0-rc2 radeon HD 7480D [Aruba] blank display

2014-04-21 Thread Alex Deucher
On Mon, Apr 21, 2014 at 4:32 PM, Ken Moffat zarniwh...@ntlworld.com wrote: I've just built 3.15.0-rc2 on this box, and discovered that I get a blank screen. The boot appears to complete (it sends me information from SMART which is from my last bootscript), and it responds to MagicSysRQ to

Re: 3.15.0-rc2 radeon HD 7480D [Aruba] blank display

2014-04-21 Thread Alex Deucher
Tomlinson wrote: Ken, You might want to try reverting: commit 379dfc25e257ffe10eb53b86d2375f7c0f4f33ef Author: Alex Deucher alexdeuc...@gmail.com Date: Mon Apr 7 10:33:46 2014 -0400 drm/radeon/dp: switch to the common i2c over aux code Provides a nice

Re: 15-rc1: radeon modesetting fails

2014-04-15 Thread Alex Deucher
On Tue, Apr 15, 2014 at 8:07 AM, Borislav Petkov b...@alien8.de wrote: Hi Christian, On Tue, Apr 15, 2014 at 11:28:55AM +0200, Christian König wrote: Hi Borislav, that's a known issue and should be fixed in the next rc, see this bugreport: https://bugs.freedesktop.org/show_bug.cgi?id=77009

Re: [PATCH v2 09/17] drm/radeon: use common fence implementation for fences

2014-07-10 Thread Alex Deucher
On Wed, Jul 9, 2014 at 9:23 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 09-07-14 14:57, Deucher, Alexander schreef: snip +static const char *radeon_fence_get_timeline_name(struct fence *f) +{ +struct radeon_fence *fence = to_radeon_fence(f); +switch (fence-ring) {

Re: [PATCH 02/83] drm/radeon: reduce number of free VMIDs and pipes in KV

2014-07-11 Thread Alex Deucher
On Fri, Jul 11, 2014 at 12:18 PM, Christian König christian.koe...@amd.com wrote: Am 11.07.2014 18:05, schrieb Jerome Glisse: On Fri, Jul 11, 2014 at 12:50:02AM +0300, Oded Gabbay wrote: To support HSA on KV, we need to limit the number of vmids and pipes that are available for radeon's use

Re: [PATCH 09/17] drm/radeon: use common fence implementation for fences

2014-07-22 Thread Alex Deucher
On Tue, Jul 22, 2014 at 11:19 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Jul 22, 2014 at 4:39 PM, Christian König christian.koe...@amd.com wrote: Am 22.07.2014 16:27, schrieb Maarten Lankhorst: op 22-07-14 16:24, Christian König schreef: No, you really shouldn't be doing much in the

Re: [PANIC] at drivers/drm/drm_irq.c:976 with 3.16-rc2+git

2014-06-27 Thread Alex Deucher
On Fri, Jun 27, 2014 at 11:32 AM, Ed Tomlinson e...@aei.ca wrote: Hi It seems the follow on message with the panic's as an attachment did not make it. Here is a link with the jpg: Preliminary fixes and discussion here: http://lists.freedesktop.org/archives/dri-devel/2014-June/062411.html

Re: [PATCH 1/1] drm/radeon: remove null test before kfree

2014-07-07 Thread Alex Deucher
On Fri, Jul 4, 2014 at 3:37 PM, Fabian Frederick f...@skynet.be wrote: Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: Alex Deucher alexander.deuc...@amd.com Cc: David Airlie airl...@linux.ie Cc: dri-de...@lists.freedesktop.org Signed-off

Re: [PATCH v2 00/25] AMDKFD kernel driver

2014-07-23 Thread Alex Deucher
On Wed, Jul 23, 2014 at 10:56 AM, Jerome Glisse j.gli...@gmail.com wrote: On Wed, Jul 23, 2014 at 09:04:24AM +0200, Christian König wrote: Am 23.07.2014 08:50, schrieb Oded Gabbay: On 22/07/14 14:15, Daniel Vetter wrote: On Tue, Jul 22, 2014 at 12:52:43PM +0300, Oded Gabbay wrote: On 22/07/14

Re: [PATCH v2 00/25] AMDKFD kernel driver

2014-07-24 Thread Alex Deucher
On Thu, Jul 24, 2014 at 11:44 AM, Jerome Glisse j.gli...@gmail.com wrote: On Thu, Jul 24, 2014 at 01:01:41AM +0300, Oded Gabbay wrote: On 24/07/14 00:46, Bridgman, John wrote: -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Jesse

Re: [Bulk] Re: [3.16-rcX][pciehp][radeon] PCIe HotPlug conflicts with radeon GPU

2014-10-26 Thread Alex Deucher
On Mon, Oct 13, 2014 at 12:11 PM, Bjorn Helgaas bhelg...@google.com wrote: [+cc Alex, Christian, dri-devel] On Sat, Oct 11, 2014 at 1:37 PM, Shawn Starr shawn.st...@rogers.com wrote: On September 11, 2014 04:26:21 PM Bjorn Helgaas wrote: [+cc linux-pci] On Sat, Aug 2, 2014 at 10:02 AM,

Re: [RESEND] [PATCH] radeon: clean up coding style differences in radeon_get_bios()

2014-10-20 Thread Alex Deucher
On Thu, Oct 16, 2014 at 5:37 AM, Wilfried Klaebe w-l...@lebenslange-mailadresse.de wrote: radeon: clean up coding style differences in radeon_get_bios() Signed-off-by: Wilfried Klaebe w-l...@lebenslange-mailadresse.de Applied. thanks! Alex diff --git a/drivers/gpu/drm/radeon/radeon_bios.c

Re: [PATCH] drm: Test for PCI root bus to avoid NULL pointer dereference

2014-08-27 Thread Alex Deucher
...@redhat.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- drivers/gpu/drm/drm_pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c index 020cfd9..411e806 100644 --- a/drivers/gpu/drm/drm_pci.c +++ b

Re: [PATCH] radeon: Test for PCI root bus before assuming bus-self

2014-08-27 Thread Alex Deucher
On Wed, Aug 27, 2014 at 3:01 PM, Alex Williamson alex.william...@redhat.com wrote: If we assign a Radeon device to a virtual machine, we can no longer assume a fixed hardware topology, like the GPU having a parent device. This patch simply adds a few pci_is_root_bus() tests to avoid passing a

Re: [PATCH] radeon: Test for PCI root bus before assuming bus-self

2014-08-27 Thread Alex Deucher
On Wed, Aug 27, 2014 at 9:32 PM, Dave Airlie airl...@gmail.com wrote: On Wed, Aug 27, 2014 at 3:01 PM, Alex Williamson alex.william...@redhat.com wrote: If we assign a Radeon device to a virtual machine, we can no longer assume a fixed hardware topology, like the GPU having a parent device.

Re: [PATCH 0/2] PCI: Ignore hotplug events for dual GPU systems

2014-09-12 Thread Alex Deucher
these into v3.17 if they seem reasonable. Looks good to me. Acked-by: Alex Deucher alexander.deuc...@amd.com --- Bjorn Helgaas (2): PCI: Add pci_ignore_hotplug() to ignore hotplug events for a device ACPIPHP / radeon / nouveau: Remove acpi_bus_no_hotplug() drivers/acpi/bus.c

Re: [PATCH 02/11 V2] radeon: evergreen: Fix probable mask then right shift defect

2014-10-28 Thread Alex Deucher
On Mon, Oct 27, 2014 at 10:14 AM, Joe Perches j...@perches.com wrote: Precedence of and is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Use the already #defined values instead of hardcoding.

Re: [Bulk] Re: [3.16-rcX][pciehp][radeon] PCIe HotPlug conflicts with radeon GPU

2014-10-28 Thread Alex Deucher
On Mon, Oct 27, 2014 at 12:44 PM, Bjorn Helgaas bhelg...@google.com wrote: On Sun, Oct 26, 2014 at 11:31 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Mon, Oct 13, 2014 at 12:11 PM, Bjorn Helgaas bhelg...@google.com wrote: [+cc Alex, Christian, dri-devel] On Sat, Oct 11, 2014 at 1:37 PM

Re: Stupid NVIDIA 3D vgaarb.c patch

2014-09-22 Thread Alex Deucher
On Mon, Sep 22, 2014 at 5:54 PM, Alex Williamson alex.william...@redhat.com wrote: On Tue, 2014-09-23 at 04:20 +0700, C Bergström wrote: For clarity - My testing and the patch is required when the Intel driver isn't being used at all. After I finish some other testing I can see if bumblebee

Re: [PATCH] amdkfd: Remove DRM_AMDGPU dependency from Kconfig

2014-11-21 Thread Alex Deucher
On Fri, Nov 21, 2014 at 3:40 PM, Oded Gabbay oded.gab...@amd.com wrote: Signed-off-by: Oded Gabbay oded.gab...@amd.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

Re: [PATCH] amdkfd: explicitely include io.h in kfd_doorbell.c

2014-11-21 Thread Alex Deucher
On Fri, Nov 21, 2014 at 3:07 PM, Oded Gabbay oded.gab...@amd.com wrote: This patch fixes a compilation error when using certain configuration by including the file io.h in kfd_doorbell.c Signed-off-by: Oded Gabbay oded.gab...@amd.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com

Re: [PATCH] drm/radeon: delete unused PTE_* defines

2014-09-16 Thread Alex Deucher
On Tue, Sep 16, 2014 at 3:03 PM, Kyle McMartin k...@redhat.com wrote: They don't appear to be used anywhere... elsewhere uses R*_PTE_*. master@linux:U:.% git grep PTE_ -- drivers/gpu/drm/radeon | grep -v _PTE_ master@linux:U:.% (kyle@redacted:~/linux)

Re: [PATCH v5 00/24] AMDKFD Kernel Driver

2014-11-10 Thread Alex Deucher
On Mon, Nov 10, 2014 at 4:16 PM, Dave Airlie airl...@gmail.com wrote: How does amdkfd interfact with runtime pm on the radeon driver? I'd expect some calls to the runtime get/put functions in some places. Dave. Hi Dave, Per Jerome's request from the first time he saw the driver, we removed

Re: Stupid NVIDIA 3D vgaarb.c patch

2014-09-23 Thread Alex Deucher
On Mon, Sep 22, 2014 at 5:20 PM, C Bergström cbergst...@pathscale.com wrote: For clarity - My testing and the patch is required when the Intel driver isn't being used at all. After I finish some other testing I can see if bumblebee and intel driver + this patch will play nicely. How is a

Re: [PATCH 07/27] vga_switcheroo: use pm_runtime_last_busy_and_autosuspend helper

2014-09-24 Thread Alex Deucher
On Wed, Sep 24, 2014 at 12:14 PM, Vinod Koul vinod.k...@intel.com wrote: Use the new pm_runtime_last_busy_and_autosuspend helper instead of open coding the same code Signed-off-by: Vinod Koul vinod.k...@intel.com Acked-by: Alex Deucher alexander.deuc...@amd.com --- drivers/gpu/vga

Re: [PATCH 06/27] drm/radeon: use pm_runtime_last_busy_and_autosuspend helper

2014-09-24 Thread Alex Deucher
On Wed, Sep 24, 2014 at 12:14 PM, Vinod Koul vinod.k...@intel.com wrote: Use the new pm_runtime_last_busy_and_autosuspend helper instead of open coding the same code Signed-off-by: Vinod Koul vinod.k...@intel.com Acked-by: Alex Deucher alexander.deuc...@amd.com I don't care which tree

Re: page allocator bug in 3.16?

2014-09-25 Thread Alex Deucher
On Thu, Sep 25, 2014 at 2:55 PM, Peter Hurley pe...@hurleysoftware.com wrote: After several days uptime with a 3.16 kernel (generally running Thunderbird, emacs, kernel builds, several Chrome tabs on multiple desktop workspaces) I've been seeing some really extreme slowdowns. Mostly the

Re: [PATCH] radeon: acquire BIOS via firmware subsystem if everything else failed

2014-11-25 Thread Alex Deucher
On Sat, Nov 22, 2014 at 2:30 PM, Wilfried Klaebe w-l...@lebenslange-mailadresse.de wrote: At least Apple's MacBook Pro 8,2 booting EFI - GRUB2 - Linux (without BIOS emulation) seems to have no Radeon BIOS accessible via conventional means. Loading one via firmware system previously dumped (with

Re: [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Alex Deucher
...@amd.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- drivers/gpu/drm/radeon/radeon_kfd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c index 242fd8b..cb77e5c 100644 --- a/drivers/gpu/drm

Re: [PATCH v4 01/23] drm/radeon: reduce number of free VMIDs and pipes in KV

2014-10-14 Thread Alex Deucher
that KV has only a single MEC with a single pipe in it v3: Use define for static vmid allocation in radeon Signed-off-by: Oded Gabbay oded.gab...@amd.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- drivers/gpu/drm/radeon/cik.c | 48

Re: [PATCH v4 02/23] drm/radeon/cik: Don't touch int of pipes 1-7

2014-10-14 Thread Alex Deucher
On Wed, Sep 24, 2014 at 4:45 PM, Oded Gabbay oded.gab...@amd.com wrote: amdkfd should set interrupts for pipes 1-7. Signed-off-by: Oded Gabbay oded.gab...@amd.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- drivers/gpu/drm/radeon/cik.c | 71

Re: [PATCH v4 03/23] drm/radeon: Report doorbell configuration to amdkfd

2014-10-14 Thread Alex Deucher
. Signed-off-by: Oded Gabbay oded.gab...@amd.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- drivers/gpu/drm/radeon/radeon.h| 4 drivers/gpu/drm/radeon/radeon_device.c | 31 +++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm

Re: [PATCH v4 04/23] drm/radeon: adding synchronization for GRBM GFX

2014-10-14 Thread Alex Deucher
-off-by: Oded Gabbay oded.gab...@amd.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- drivers/gpu/drm/radeon/cik.c | 26 ++ drivers/gpu/drm/radeon/radeon.h| 2 ++ drivers/gpu/drm/radeon/radeon_device.c | 1 + 3 files changed, 29 insertions

Re: [PATCH] drm/radeon: kernel panic in drm_calc_vbltimestamp_from_scanoutpos with 3.18.0-rc6

2014-11-30 Thread Alex Deucher
On Thu, Nov 27, 2014 at 10:57 AM, Petr Mladek pmla...@suse.cz wrote: I was unable too boot 3.18.0-rc6 because of the following kernel panic in drm_calc_vbltimestamp_from_scanoutpos(): [drm] Initialized drm 1.1.0 20060810 [drm] radeon kernel modesetting enabled. [drm] initializing

Re: [PATCH 20/20] drm/radeon: fix misspelling of current function in string

2014-12-08 Thread Alex Deucher
On Sun, Dec 7, 2014 at 2:21 PM, Julia Lawall julia.law...@lip6.fr wrote: Replace a misspelled function name by %s and then __func__. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall julia.law...@lip6.fr

Re: [PATCH] drm/radeon/rv515: Remove unused function

2015-01-15 Thread Alex Deucher
for a while apparently. Alex On Wed, Jan 14, 2015 at 4:44 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Tue, Jan 13, 2015 at 1:55 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function rv515_ring_start() that is not used anywhere. This was partially found

Re: [PATCH] gpu: drm: radeon: radeon_object: Remove unused function

2015-01-14 Thread Alex Deucher
On Sun, Jan 11, 2015 at 8:17 AM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function radeon_bo_fbdev_mmap() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [PATCH] drm/radeon/radeon_i2c: Remove unused function

2015-01-14 Thread Alex Deucher
On Tue, Jan 13, 2015 at 2:09 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function radeon_best_encoder() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [PATCH] drm/radeon/rv515: Remove unused function

2015-01-14 Thread Alex Deucher
On Tue, Jan 13, 2015 at 1:55 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function rv515_ring_start() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [PATCH] drm/radeon/radeon_fb: Remove unused function

2015-01-14 Thread Alex Deucher
On Tue, Jan 13, 2015 at 2:02 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function radeon_fbdev_total_size() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [PATCH v2] pci: Fix infinite loop with ROM image of size 0

2015-01-19 Thread Alex Deucher
...@vger.kernel.org Signed-off-by: Michel Dänzer michel.daen...@amd.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- v2: * Use unsigned instead of u16 for the local length variable (not sure if the multiplication by 512 could overflow otherwise) * Integrate length condition into while

Re: Video option for a big endian machine?

2015-02-11 Thread Alex Deucher
On Wed, Feb 11, 2015 at 3:53 AM, lausg...@gmail.com wrote: Hello. I'm looking for a PCI or AGP video card that would work on a Linux port for a big endian architecture (HP PA-RISC). Unfortunately the stock video options (ATI FireGL X1 and X3) give an incredibly slow unaccelerated 2D due to

Re: [PATCH v2] drm/radeon: Fix kernel panic with HDMI w/o SAD

2015-01-05 Thread Alex Deucher
On Sat, Jan 3, 2015 at 5:09 AM, Takashi Iwai ti...@suse.de wrote: A BUG_ON() call in dce3_2_afmt_write_sad_regs() is triggered when a HDMI monitor without audio is plugged: I have a slightly different fix already queued up:

Re: Radeon R9 290 problem

2015-01-04 Thread Alex Deucher
On Fri, Jan 2, 2015 at 11:23 AM, Alex Kuznetsoff dri-de...@yandex.ru wrote: I have an AMD Radeon R9 290 video card, and since commit https://github.com/torvalds/linux/commit/96212fe8c27b I cannot boot into the system any more with CONFIG_DRM_RADEON turned on ([m]). These are the symptoms:

Re: [PATCH v2] drm/radeon: Fix kernel panic with HDMI w/o SAD

2015-01-05 Thread Alex Deucher
On Mon, Jan 5, 2015 at 12:23 PM, Takashi Iwai ti...@suse.de wrote: At Mon, 5 Jan 2015 12:07:52 -0500, Alex Deucher wrote: On Sat, Jan 3, 2015 at 5:09 AM, Takashi Iwai ti...@suse.de wrote: A BUG_ON() call in dce3_2_afmt_write_sad_regs() is triggered when a HDMI monitor without audio

Re: [PATCH v2] drm/radeon: Fix kernel panic with HDMI w/o SAD

2015-01-05 Thread Alex Deucher
On Mon, Jan 5, 2015 at 1:16 PM, Takashi Iwai ti...@suse.de wrote: At Mon, 5 Jan 2015 12:48:05 -0500, Alex Deucher wrote: On Mon, Jan 5, 2015 at 12:23 PM, Takashi Iwai ti...@suse.de wrote: At Mon, 5 Jan 2015 12:07:52 -0500, Alex Deucher wrote: On Sat, Jan 3, 2015 at 5:09 AM, Takashi

Re: [PATCH] radeon: Update Kaveri MEC firmware to #396

2015-03-16 Thread Alex Deucher
On Fri, Mar 13, 2015 at 6:51 PM, Oded Gabbay oded.gab...@amd.com wrote: This patch updates the Kaveri MEC firmware to #396 (from #391). The MEC firmware is mainly used for amdkfd - AMD's HSA Linux kernel driver. Signed-off-by: Oded Gabbay oded.gab...@amd.com Acked-by: Alex Deucher

Re: [PATCH] radeon: Do not directly dereference pointers to BIOS area.

2015-03-20 Thread Alex Deucher
On Fri, Mar 20, 2015 at 5:38 AM, Christian König christian.koe...@amd.com wrote: On 19.03.2015 17:29, David Miller wrote: From: Christian König christian.koe...@amd.com Date: Thu, 19 Mar 2015 09:50:58 +0100 In general I would say yes, but for this particular hardware it's a bit questionable

Re: [PATCH 0/2] PCI: pci_unignore_hotplug()

2015-03-06 Thread Alex Deucher
On Fri, Mar 6, 2015 at 1:49 PM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Feb 24, 2015 at 03:23:27PM -0500, Alex Deucher wrote: On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson alex.william...@redhat.com wrote: I'd kinda like to use pci_ignore_hotplug() for devices in use by a user

Re: [PATCH] drm/radeon: fix DRM_IOCTL_RADEON_CS oops

2015-03-03 Thread Alex Deucher
On Tue, Mar 3, 2015 at 4:10 AM, Christian König deathsim...@vodafone.de wrote: Good catch. Patch is Reviewed-by: Christian König christian.koe...@amd.com Regards, Christian. Applied to my -fixes tree. Thanks! Alex On 02.03.2015 20:36, Tommi Rantala wrote: Passing zeroed

Re: [PATCH 0/2] PCI: pci_unignore_hotplug()

2015-02-24 Thread Alex Deucher
On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson alex.william...@redhat.com wrote: I'd kinda like to use pci_ignore_hotplug() for devices in use by a user via vfio-pci, but the interface seems only partially implemented since we can only set ignore_hotplug and not clear it. This adds the

Re: git pull] drm for v4.1-rc1

2015-04-23 Thread Alex Deucher
On Thu, Apr 23, 2015 at 5:30 PM, Bjorn Helgaas bhelg...@google.com wrote: [+cc Matthew] On Tue, Apr 21, 2015 at 09:07:45AM -0700, Linus Torvalds wrote: Hmm. The odd Intel PCI resource mess is back. Or maybe it never went away. I get these when suspending. Things *work*, but it's really

Re: [PATCH v2 2/4] drm_vblank_get: don't WARN_ON in case vblanks are not initialized

2015-04-02 Thread Alex Deucher
On Wed, Apr 1, 2015 at 9:15 AM, Gerd Hoffmann kra...@redhat.com wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- drivers/gpu/drm/drm_irq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers

Re: [PATCH 04/12] drm/radeon: Use DECLARE_BITMAP

2015-05-20 Thread Alex Deucher
On Tue, May 19, 2015 at 9:37 PM, Joe Perches j...@perches.com wrote: Use the generic mechanism to declare a bitmap instead of unsigned long. Signed-off-by: Joe Perches j...@perches.com Applied to my -next tree. thanks! Alex --- drivers/gpu/drm/radeon/radeon.h | 2 +- 1 file changed, 1

Re: 4.1-rc4 display-port on radeon not working

2015-05-20 Thread Alex Deucher
On Tue, May 19, 2015 at 6:03 PM, Malte Schröder ma...@tnxip.de wrote: Hi, with 4.1-rc display-port on my Tahiti XT stopped working. I used the firmware from http://people.freedesktop.org/~agd5f/radeon_ucode/ as of today. Note: the display is an Asus PB278, it used to have problems with

Re: 4.1-rc4 display-port on radeon not working

2015-05-20 Thread Alex Deucher
On Wed, May 20, 2015 at 12:57 PM, Malte Schröder ma...@tnxip.de wrote: On 05/20/15 17:37, Alex Deucher wrote: On Tue, May 19, 2015 at 6:03 PM, Malte Schröder ma...@tnxip.de wrote: Hi, with 4.1-rc display-port on my Tahiti XT stopped working. I used the firmware from http

Re: drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Alex Deucher
On Thu, Jun 4, 2015 at 9:48 AM, Oded Gabbay oded.gab...@gmail.com wrote: Hi Valentin, Thanks for catching that. I would be grateful if you could fix this yourself. Please try and keep CONFIG in the name since this range of registers are called CONFIG registers. Alex Oded On Thu, Jun 4,

Re: drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Alex Deucher
On Thu, Jun 4, 2015 at 10:04 AM, Valentin Rothberg valentinrothb...@gmail.com wrote: Hi Alex, On Thu, Jun 4, 2015 at 4:01 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Thu, Jun 4, 2015 at 9:48 AM, Oded Gabbay oded.gab...@gmail.com wrote: Hi Valentin, Thanks for catching that. I would

Re: [PATCH v2] drm/amdgpu: use kzalloc for allocating one thing

2015-06-26 Thread Alex Deucher
On Fri, Jun 26, 2015 at 3:58 AM, Maninder Singh maninder...@samsung.com wrote: Use kzalloc rather than kcalloc(1.. for allocating one thing. Signed-off-by: Maninder Singh maninder...@samsung.com Reviewed-by: Vaneet Narang v.nar...@samsung.com Reviewed-by: Christian Konig

Re: [PATCH v2] drm/amdgpu: remove unnecessary check before kfree

2015-06-26 Thread Alex Deucher
On Fri, Jun 26, 2015 at 3:56 AM, Maninder Singh maninder...@samsung.com wrote: kfree(NULL) is safe and this check is probably not required Signed-off-by: Maninder Singh maninder...@samsung.com Reviewed-by: Vaneet Narang v.nar...@samsung.com Reviewed-by: Christian Konig

Re: [PATCH 1/1] drm/radeon: use kzalloc for allocating one thing

2015-06-24 Thread Alex Deucher
On Fri, Jun 19, 2015 at 3:26 AM, Christian König christian.koe...@amd.com wrote: On 19.06.2015 06:05, Maninder Singh wrote: Use kzalloc for allocating one thing rather than kcalloc(1... The semantic patch that makes this change is as follows: // smpl @@ @@ - kcalloc(1, + kzalloc(

Re: [PATCH] drm/amdgpu: Delete an unnecessary check before the function call kfree

2015-06-29 Thread Alex Deucher
On Sun, Jun 28, 2015 at 4:45 AM, SF Markus Elfring elfr...@users.sourceforge.net wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 28 Jun 2015 10:27:35 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call

Re: [PATCH] DRM - radeon: Don't link train DisplayPort on HPD until we get the dpcd

2015-08-21 Thread Alex Deucher
On Fri, Aug 21, 2015 at 2:16 PM, cp...@redhat.com wrote: From: Stephen Chandler Paul cp...@redhat.com Most of the time this isn't an issue since hotplugging an adaptor will trigger a crtc mode change which in turn, causes the driver to probe every DisplayPort for a dpcd. However, in cases

Re: [Bugfix] x86, irq: Fix a regression caused by commit b5dc8e6c21e7

2015-08-17 Thread Alex Deucher
On Sun, Aug 9, 2015 at 4:15 AM, Jiang Liu jiang@linux.intel.com wrote: Alex Deucher, Mark Rustad and Alexander Holler reported a regression with the latest v4.2-rc4 kernel, which breaks some SATA controllers. With multi-MSI capable SATA controllers, only the first port works, all other

Re: ATA failure regression in kernel 4.2

2015-07-28 Thread Alex Deucher
On Mon, Jul 27, 2015 at 12:30 PM, Jiang Liu jiang@linux.intel.com wrote: On 2015/7/27 23:21, Alex Deucher wrote: On Sun, Jul 26, 2015 at 11:01 PM, Jiang Liu jiang@linux.intel.com wrote: On 2015/7/25 1:38, Alex Deucher wrote: On Thu, Jul 23, 2015 at 2:44 PM, Alex Deucher alexdeuc

Re: [PATCH] drm/amdgpu: increment queue when iterating on this variable.

2015-08-03 Thread Alex Deucher
On Sat, Aug 1, 2015 at 9:55 AM, Nicolas Iooss nicolas.iooss_li...@m4x.org wrote: gfx_v7_0_print_status contains a for loop on variable queue which does not update this variable between each iteration. This is bug is reported by clang while building allmodconfig LLVMLinux on x86_64:

Re: [Bugfix]

2015-07-30 Thread Alex Deucher
On Thu, Jul 30, 2015 at 12:44 PM, Jiang Liu jiang@linux.intel.com wrote: Hi Alexander, Mark, Alex, Could you please help to apply the debug patch and send me back the dmesg? Please also help to turn kernel paramemter apic=debug. See attached. Thanks, Alex Hi Mark, It

Re: [Bugfix] x86, irq: Fix a regression caused by commit b5dc8e6c21e7

2015-08-13 Thread Alex Deucher
On Thu, Aug 13, 2015 at 4:15 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Thu, Aug 13, 2015 at 3:46 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Mon, Aug 10, 2015 at 9:06 PM, Jiang Liu jiang@linux.intel.com wrote: On 2015/8/10 23:00, Alex Deucher wrote: On Sun, Aug 9, 2015 at 4:15

Re: [Bugfix] x86, irq: Fix a regression caused by commit b5dc8e6c21e7

2015-08-13 Thread Alex Deucher
On Mon, Aug 10, 2015 at 9:06 PM, Jiang Liu jiang@linux.intel.com wrote: On 2015/8/10 23:00, Alex Deucher wrote: On Sun, Aug 9, 2015 at 4:15 AM, Jiang Liu jiang@linux.intel.com wrote: Alex Deucher, Mark Rustad and Alexander Holler reported a regression with the latest v4.2-rc4 kernel

Re: [Bugfix] x86, irq: Fix a regression caused by commit b5dc8e6c21e7

2015-08-13 Thread Alex Deucher
On Thu, Aug 13, 2015 at 3:46 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Mon, Aug 10, 2015 at 9:06 PM, Jiang Liu jiang@linux.intel.com wrote: On 2015/8/10 23:00, Alex Deucher wrote: On Sun, Aug 9, 2015 at 4:15 AM, Jiang Liu jiang@linux.intel.com wrote: Alex Deucher, Mark Rustad

Re: [Bugfix] x86, irq: Fix a regression caused by commit b5dc8e6c21e7

2015-08-10 Thread Alex Deucher
On Sun, Aug 9, 2015 at 4:15 AM, Jiang Liu jiang@linux.intel.com wrote: Alex Deucher, Mark Rustad and Alexander Holler reported a regression with the latest v4.2-rc4 kernel, which breaks some SATA controllers. With multi-MSI capable SATA controllers, only the first port works, all other

Re: ATA failure regression in kernel 4.2

2015-07-24 Thread Alex Deucher
On Thu, Jul 23, 2015 at 2:44 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Thu, Jul 23, 2015 at 2:35 PM, Tejun Heo t...@kernel.org wrote: Hello, On Thu, Jul 23, 2015 at 01:48:24PM -0400, Alex Deucher wrote: Something new in kernel 4.2 seems to have broken one of my hard drives (ssd

Re: ATA failure regression in kernel 4.2

2015-07-23 Thread Alex Deucher
On Thu, Jul 23, 2015 at 2:35 PM, Tejun Heo t...@kernel.org wrote: Hello, On Thu, Jul 23, 2015 at 01:48:24PM -0400, Alex Deucher wrote: Something new in kernel 4.2 seems to have broken one of my hard drives (ssd) in kernel 4.2. 4.1 and older kernels work fine. Here are the relevant logs

ATA failure regression in kernel 4.2

2015-07-23 Thread Alex Deucher
Something new in kernel 4.2 seems to have broken one of my hard drives (ssd) in kernel 4.2. 4.1 and older kernels work fine. Here are the relevant logs. Kernel 4.1: [1.435809] ata2: SATA link up 6.0 Gbps (SStatus 133 SControl 300) [1.435837] ata1: SATA link up 3.0 Gbps (SStatus 123

Re: [PATCH] gpu/drm/amdgpu: Include linux/debugfs.h only if CONFIG_DEBUG_FS is set

2015-07-13 Thread Alex Deucher
On Mon, Jul 13, 2015 at 7:03 AM, Alexander Kuleshov kuleshovm...@gmail.com wrote: We have no need to include linux/debugfs.h if the CONFIG_DEBUG_FS option is not set. This patch breaks the build with debugfs enabled. Alex Signed-off-by: Alexander Kuleshov kuleshovm...@gmail.com ---

Re: [PATCH] gpu/drm/amdgpu: Include linux/debugfs.h only if CONFIG_DEBUG_FS is set

2015-07-14 Thread Alex Deucher
On Tue, Jul 14, 2015 at 4:18 AM, Alexander Kuleshov kuleshovm...@gmail.com wrote: Hello Alex, 2015-07-14 11:11 GMT+06:00 Alex Deucher alexdeuc...@gmail.com: This patch breaks the build with debugfs enabled. I've tried to built with CONFIG_DEBUG_FS={y/n} and it builds successfully. Did I

Re: [PATCH v4 04/79] drm_mode.h: use __u32 and __u64 from linux/types.h

2015-10-21 Thread Alex Deucher
On Wed, Oct 21, 2015 at 11:09 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Alex, > > On 15 October 2015 at 14:48, Mikko Rapeli <mikko.rap...@iki.fi> wrote: >> On Thu, Oct 15, 2015 at 09:32:10AM -0400, Alex Deucher wrote: >>> On Thu, Oct 15, 2015

Re: [PATCH v4 04/79] drm_mode.h: use __u32 and __u64 from linux/types.h

2015-10-21 Thread Alex Deucher
On Wed, Oct 21, 2015 at 12:21 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 21 October 2015 at 16:18, Alex Deucher <alexdeuc...@gmail.com> wrote: >> On Wed, Oct 21, 2015 at 11:09 AM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>> Hi

Re: [PATCH] drm/amdgpu: fix seq_printf format string

2015-11-10 Thread Alex Deucher
On Tue, Nov 10, 2015 at 7:17 AM, Arnd Bergmann wrote: > The amdgpu driver has a debugfs interface that shows the amount of > VRAM in use, but the newly added code causes a build error on > all 32-bit architectures: > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1076:17: warning:

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Alex Deucher
On Tue, Nov 17, 2015 at 11:29 AM, Daniel Vetter wrote: > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: >> On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: >> >> > On Tue, Nov 17, 2015 at 03:05:34PM +, John Keeping wrote: >> > > The request's hot_x and

Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080

2015-11-02 Thread Alex Deucher
On Sat, Oct 31, 2015 at 5:22 PM, Pavel Machek wrote: > Hi! > >> >4.3-rc7 kernel, graphics works reasonably well in 1600x1200 mode. But >> >my monitor is native 1920x1080, so that mode looks pretty ugly on >> >screen. If I go to 1920x1080, I see colored horizontal lines (often >>

Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080

2015-11-04 Thread Alex Deucher
On Wed, Nov 4, 2015 at 5:10 PM, Pavel Machek wrote: > Hi! > >> index dac78ad..b86f06a 100644 >> --- a/drivers/gpu/drm/radeon/atombios_crtc.c >> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c >> @@ -569,6 +569,8 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,

Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080

2015-11-03 Thread Alex Deucher
On Tue, Nov 3, 2015 at 5:09 PM, Pavel Machek wrote: > Hi! > >> >> >4.3-rc7 kernel, graphics works reasonably well in 1600x1200 mode. But >> >> >my monitor is native 1920x1080, so that mode looks pretty ugly on >> >> >screen. If I go to 1920x1080, I see colored horizontal lines

Re: [PATCH 1/9] drm: fix trivial typos

2015-10-19 Thread Alex Deucher
On Sun, Oct 18, 2015 at 11:29 AM, Geliang Tang wrote: > s/regsiter/register/ > > Signed-off-by: Geliang Tang Applied. thanks! Alex > --- > drivers/gpu/drm/amd/include/atombios.h | 2 +- > drivers/gpu/drm/radeon/cayman_blit_shaders.c| 2

Re: [PATCH v4 04/79] drm_mode.h: use __u32 and __u64 from linux/types.h

2015-10-15 Thread Alex Deucher
On Thu, Oct 15, 2015 at 1:55 AM, Mikko Rapeli wrote: > Fixes userspace compilation error: > > drm/drm_mode.h:472:2: error: unknown type name ‘uint32_t’ > > Signed-off-by: Mikko Rapeli NACK on all these type conversions. This has not been a problem for

Re: [PATCH RESEND 3/3] drm/amdgpu: fix memory leak

2015-10-08 Thread Alex Deucher
t; > Cc: Chunming Zhou <david1.z...@amd.com> > Cc: Alex Deucher <alexander.deuc...@amd.com> > Cc: "monk.liu" <monk@amd.com> > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> > --- > > Sent on 18/09/2015 I somehow missed this before.

Re: [PATCH] drm/amdgpu: fix 32-bit compiler warning

2015-10-07 Thread Alex Deucher
On Wed, Oct 7, 2015 at 5:18 AM, Arnd Bergmann wrote: > On Wednesday 07 October 2015 10:57:11 Christian König wrote: >> On 07.10.2015 09:41, Arnd Bergmann wrote: >> > The new amdgpu driver passes a user space pointer in a 64-bit structure >> > member, which is the correct way to do

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Alex Deucher
On Tue, Nov 17, 2015 at 1:40 PM, Daniel Vetter wrote: > On Tue, Nov 17, 2015 at 04:58:06PM +, John Keeping wrote: >> On Tue, 17 Nov 2015 17:29:35 +0100, Daniel Vetter wrote: >> >> > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: >> > > On Tue, 17 Nov 2015

Re: [Bugfix] x86, irq: Fix a regression caused by commit b5dc8e6c21e7

2015-08-24 Thread Alex Deucher
On Thu, Aug 13, 2015 at 6:13 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Thu, Aug 13, 2015 at 4:15 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Thu, Aug 13, 2015 at 3:46 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Mon, Aug 10, 2015 at 9:06 PM, Jiang Liu jiang@linux.intel.com

Re: AGP cards in PCI mode (fake slots like AGPro, AGP Express, AGI, AGX, XGP)

2015-09-13 Thread Alex Deucher
On Sun, Sep 13, 2015 at 2:57 PM, Ondrej Zary wrote: > Hello, > I have a PC Chips A31G board with AGPro slot and found that nouveau does not > work properly with it. Console works but reverts to software mode, X11 hangs > with mouse cursor only. > > The slot is

Re: No more new fbdev drivers, please

2015-09-26 Thread Alex Deucher
On Sat, Sep 26, 2015 at 4:28 AM, Geert Uytterhoeven wrote: > Hi Daniel, > > On Thu, Sep 24, 2015 at 5:23 PM, Daniel Vetter wrote: >> On Thu, Sep 24, 2015 at 02:46:21PM +0200, Thomas Petazzoni wrote: >>> Or are there some plans to make the writing of DRM

Re: 4.3-rc2 on radeon: new backtraces during resume

2015-09-23 Thread Alex Deucher
On Wed, Sep 23, 2015 at 7:51 AM, Pavel Machek wrote: > HI! > > > I suspended T40p by mistake, and I got some lovely backtraces as a > result: > > Any ideas? Please see this thread: https://lkml.org/lkml/2015/9/23/361 Alex > >

Re: No more new fbdev drivers, please

2015-09-24 Thread Alex Deucher
On Thu, Sep 24, 2015 at 11:21 AM, Austin S Hemmelgarn wrote: > On 2015-09-24 08:46, Thomas Petazzoni wrote: >> >> Hello, >> >> On Thu, 24 Sep 2015 15:27:01 +0300, Tomi Valkeinen wrote: >> >>> fbdev is (more or less) maintained, but it's a deprecated framework. All >>> new

Re: WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90()

2015-09-22 Thread Alex Deucher
On Mon, Sep 21, 2015 at 9:31 AM, Borislav Petkov wrote: > Hi guys, > > this assert_drm_connector_list_read_locked() thing fires here when > suspending to disk with Linus' master from around a week ago and > tip/master merged ontop. > > After I resume, box comes up but wedges

<    1   2   3   4   5   6   7   8   9   10   >