Re: [PATCH] rbd: revalidate_disk upon rbd resize

2013-04-10 Thread Alex Elder
. Thanks a lot. Reviewed-by: Alex Elder el...@inktank.com Signed-off-by: Laurent Barbe laur...@ksperis.com --- drivers/block/rbd.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index f556f8a..1963025 100644 --- a/drivers/block/rbd.c +++ b

Re: [PATCH] rbd: revalidate_disk upon rbd resize

2013-04-10 Thread Alex Elder
On 04/10/2013 02:30 PM, Alex Elder wrote: On 04/10/2013 11:06 AM, Laurent Barbe wrote: If rbd disk is open and rbd resize is done, new size is not visible by filesystem. Like is done in virtio-blk and dm driver, revalidate_disk() permits to update the bd_inode size. Looks good to me. I'll

Re: [PATCH] rbd: revalidate_disk upon rbd resize

2013-04-11 Thread Alex Elder
yet. -Alex 2013/4/11 Alex Elder el...@inktank.com On 04/10/2013 02:30 PM, Alex Elder wrote: On 04/10/2013 11:06 AM, Laurent Barbe wrote: If rbd disk is open and rbd resize is done, new size is not visible by filesystem. Like is done in virtio-blk

[PATCH] nbd: fix sparse warning

2013-02-26 Thread Alex Elder
. Signed-off-by: Alex Elder el...@inktank.com --- drivers/block/nbd.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/block/nbd.c === --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -551,6 +551,7 @@ static int

Re: [PATCH] net/ceph/osdmap.c: fix undefined behavior when using snprintf()

2013-01-23 Thread Alex Elder
this change and will commit this for you. OK? Signed-off-by: Cong Ding ding...@gmail.com Reviewed-by: Alex Elder el...@inktank.com --- net/ceph/osdmap.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c

Re: [PATCH] net/ceph/osdmap.c: fix undefined behavior when using snprintf()

2013-01-23 Thread Alex Elder
On 01/23/2013 11:41 AM, Cong Ding wrote: On Wed, Jan 23, 2013 at 10:48:07AM -0600, Alex Elder wrote: On 01/22/2013 01:20 PM, Cong Ding wrote: The variable str is used as both the source and destination in function snprintf(), which is undefined behavior based on C11. The original description

[PATCH] lib/parser.c: avoid overflow in match_number()

2012-08-09 Thread Alex Elder
harm. Signed-off-by: Alex Elder el...@inktank.com --- lib/parser.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) Index: b/lib/parser.c === --- a/lib/parser.c +++ b/lib/parser.c @@ -122,13 +122,14 @@ int

Re: [PATCH 3/3] ceph: fix dentry reference leak in ceph_encode_fh().

2012-11-20 Thread Alex Elder
On 11/11/2012 02:49 PM, Cyril Roelandt wrote: dput() was not called in the error path. Signed-off-by: Cyril Roelandt tipec...@gmail.com This looks good, thanks a lot. I'll apply it. Reviewed-by: Alex Elder el...@inktank.com --- fs/ceph/export.c |4 +++- 1 file changed, 3 insertions

Re: [TRIVIAL PATCH] bdi_register: Add __printf verification, fix arg mismatch

2012-11-26 Thread Alex Elder
On 11/22/2012 01:49 PM, Joe Perches wrote: __printf is useful to verify format and arguments. Signed-off-by: Joe Perches j...@perches.com Looks good. I can take this into the ceph tree. Thanks. Reviewed-by: Alex Elder el...@inktank.com --- fs/ceph/super.c |2

Re: [PATCH 02/15] rbd: convert bus code to use bus_groups

2013-08-27 Thread Alex Elder
On 08/23/2013 04:24 PM, Greg Kroah-Hartman wrote: The bus_attrs field of struct bus_type is going away soon, dev_groups should be used instead. This converts the RBD bus code to use the correct field. Cc: Yehuda Sadeh yeh...@inktank.com Cc: Sage Weil s...@inktank.com Cc: Alex Elder el

Re: [ 00/19] 3.10.1-stable review

2013-07-16 Thread Alex Elder
On 07/15/2013 02:07 PM, Linus Torvalds wrote: But when people who know better send me crap, I'll curse at them. I suspect you'll notice me cursing *way* more at top developers than random people on the list. I expect more from them, and conversely I'll be a lot more upset when they do

[PATCH] clk: clean up everything on debugfs error

2013-09-09 Thread Alex Elder
pointer. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/clk.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 54a191c..727ae7b 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -272,7 +272,8 @@ static int

[PATCH RESEND AGAIN] clk: clean up everything on debugfs error

2013-11-27 Thread Alex Elder
afterward, to ensure it can't be mistaken as a valid pointer. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/clk.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 2cf2ea6..77fcd06 100644 --- a/drivers/clk/clk.c +++ b

Re: [PATCH] update xfs maintainers

2013-11-14 Thread Alex Elder
knows I'm cool with this... Reviewed-by: Alex Elder el...@kernel.org (Or use Signed-off-by: if you think that's more appropriate.) -Alex --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/MAINTAINERS

[PATCH 0/3] clk: bcm281xx: define Broadcom kona clocks

2013-12-03 Thread Alex Elder
in the review/bcm-kona-clocks branch of this git repository: git://git.linaro.org/people/elder/linux.git -Alex Alex Elder (3): clk: bcm281xx: define kona clock binding clk: bcm281xx: add initial clock framework support ARM: dts: bcm281xx: define real clocks

[PATCH 1/3] clk: bcm281xx: define kona clock binding

2013-12-03 Thread Alex Elder
are defined the names of the clocks provided by the CCU. The BCM281xx family of SoCs use Kona CCUs and clocks. Signed-off-by: Alex Elder el...@linaro.org Reviewed-by: Matt Porter matt.por...@linaro.org Reviewed-by: Tim Kryger tim.kry...@linaro.org --- .../devicetree/bindings/clock/bcm-kona

[PATCH 3/3] ARM: dts: bcm281xx: define real clocks

2013-12-03 Thread Alex Elder
Replace the fake clocks defined in the bcm11351.dtsi device tree file with real definitions backed by the new BCM281xx clock driver.. Signed-off-by: Alex Elder el...@linaro.org Reviewed-by: Matt Porter matt.por...@linaro.org Reviewed-by: Tim Kryger tim.kry...@linaro.org --- arch/arm/boot/dts

Re: [PATCH 1/3] clk: bcm281xx: define kona clock binding

2013-12-04 Thread Alex Elder
On 12/04/2013 03:39 AM, Mark Rutland wrote: On Wed, Dec 04, 2013 at 03:56:58AM +, Alex Elder wrote: Document the device tree binding for Broadcom Kona architecture clock control units and clocks. Kona device nodes are represented with compatible strings having bcm11351 in their name

Re: [PATCH 2/3] clk: bcm281xx: add initial clock framework support

2013-12-04 Thread Alex Elder
On 12/04/2013 05:14 AM, Mark Rutland wrote: On Wed, Dec 04, 2013 at 03:57:03AM +, Alex Elder wrote: Add code for device tree support of clocks in the BCM281xx family of SoCs. Machines in this family use peripheral clocks implemented by Kona clock control units (CCUs). (Other Broadcom SoC

Re: [PATCH 3/3] ARM: dts: bcm281xx: define real clocks

2013-12-04 Thread Alex Elder
On 12/04/2013 05:19 AM, Mark Rutland wrote: On Wed, Dec 04, 2013 at 03:57:07AM +, Alex Elder wrote: Replace the fake clocks defined in the bcm11351.dtsi device tree file with real definitions backed by the new BCM281xx clock driver.. Signed-off-by: Alex Elder el...@linaro.org Reviewed

Re: [PATCH 2/3] clk: bcm281xx: add initial clock framework support

2013-12-04 Thread Alex Elder
On 12/04/2013 07:06 AM, Alex Elder wrote: + name_size = strlen(node-name) + 1; + ccu = kzalloc(sizeof(*ccu) + name_size, GFP_KERNEL); + if (!ccu) { + pr_err(%s: unable to map allocate CCU struct for %s\n, + __func__, node-name

[PATCH v2 0/3] clk: bcm281xx: define Broadcom kona clocks

2013-12-04 Thread Alex Elder
in the review/bcm-kona-clocks-v2 branch of this git repository: git://git.linaro.org/people/elder/linux.git Updates: v2: - Address all issues raised by Mark Rutland. -Alex Alex Elder (3): clk: bcm281xx: define kona clock binding clk: bcm281xx: add initial

[PATCH v2 1/3] clk: bcm281xx: define kona clock binding

2013-12-04 Thread Alex Elder
are defined the names of the clocks provided by the CCU. The BCM281xx family of SoCs use Kona CCUs and clocks. Signed-off-by: Alex Elder el...@linaro.org Reviewed-by: Matt Porter matt.por...@linaro.org Reviewed-by: Tim Kryger tim.kry...@linaro.org --- v2: - list all CCU compatible strings

[PATCH v2 3/3] ARM: dts: bcm281xx: define real clocks

2013-12-04 Thread Alex Elder
Replace the fake clocks defined in the bcm11351.dtsi device tree file with real definitions backed by the new BCM281xx clock driver.. Signed-off-by: Alex Elder el...@linaro.org Reviewed-by: Matt Porter matt.por...@linaro.org Reviewed-by: Tim Kryger tim.kry...@linaro.org --- v2: - got rid

Re: [PATCH 1/3] clk: bcm281xx: define kona clock binding

2013-12-04 Thread Alex Elder
On 12/04/2013 06:45 AM, Alex Elder wrote: +Device tree example: + +clocks { +slave_ccu: slave_ccu { +compatible = brcm,bcm11351-slave-ccu; +reg = 0x3e011000 0x0f00; +#clock-cells = 1

[PATCH] watchdog: fix ARCH_BCM_MOBILE dependency

2014-03-12 Thread Alex Elder
symbol (currently ARCH_BCM_MOBILE, ARCH_BCM2835, or ARCH_BCM_5301X). The BCM_KONA_WDT config option indicates a dependency on ARCH_BCM, but it should be ARCH_BCM_MOBILE instead. Fix that. Signed-off-by: Alex Elder el...@linaro.org --- drivers/watchdog/Kconfig |2 +- 1 file changed, 1 insertion

Re: [PATCH] watchdog: fix ARCH_BCM_MOBILE dependency

2014-03-12 Thread Alex Elder
On 03/12/2014 07:00 PM, Guenter Roeck wrote: On 03/12/2014 03:12 PM, Alex Elder wrote: Starting with this commit: 047ef2fa rename ARCH_BCM to ARCH_BCM_MOBILE (clocksource) the meaning of the ARCH_BCM config option is changed to represent all Broadcom chips with code in the mach-bcm

[PATCH] mach-bcm: bcm281xx: symbol cleanup

2014-02-25 Thread Alex Elder
This patch renames a few symbols that needlessly used 11351 rather than 281xx in their names. Support for the bcm11351 board is being removed from the kernel, and the family of boards is more properly referred to as bcm281xx. Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/mach-bcm

[PATCH v2 02/12] clk: bcm281xx: use init_data.name for clock name

2014-02-25 Thread Alex Elder
Use the init_data.name field to hold the name of a Kona clock rather than duplicating it. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c |6 +++--- drivers/clk/bcm/clk-kona.c | 17 ++--- drivers/clk/bcm/clk-kona.h |3 +-- 3 files

[PATCH v2 08/12] clk: bcm281xx: add an initialized flag

2014-02-25 Thread Alex Elder
Add a flag that tracks whether a clock has already been initialized. This will be used by the next patch to avoid initializing a clock more than once when it's listed as a prerequisite. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona.c | 16 ++-- drivers/clk

[PATCH v2 07/12] clk: bcm281xx: add clock hysteresis support

2014-02-25 Thread Alex Elder
Add support for clock gate hysteresis control. For now, if it's defined for a clock, it's enabled. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c | 30 ++ drivers/clk/bcm/clk-kona.c | 33

[PATCH v2 12/12] ARM: dts: add bus clock bsc3_apb for bcm281xx

2014-02-25 Thread Alex Elder
Add the bus clock named bsc3_apb to the list of those provided by the slave CCU. Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/boot/dts/bcm11351.dtsi |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH v2 10/12] clk: bcm281xx: add bus clock support

2014-02-25 Thread Alex Elder
Add bus clock support. A bus clock has a subset of the components present in a peripheral clock (again, all optional): a gate; CCU policy management bits; and if needed, bits to control hysteresis. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c | 96

[PATCH v2 09/12] clk: bcm281xx: implement prerequisite clocks

2014-02-25 Thread Alex Elder
. There exist clocks that could specify more than one prequisite, but almost all clocks only ever use one. We can add support for more than one if we find we need it at some point. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c | 16 ++ drivers/clk

[PATCH v2 11/12] clk: bcm281xx: define a bus clock

2014-02-25 Thread Alex Elder
serves to show how that's done). Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-bcm281xx.c | 13 - include/dt-bindings/clock/bcm281xx.h |3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm281xx.c b/drivers/clk/bcm

[PATCH v2 04/12] clk: bcm281xx: initialize CCU structures statically

2014-02-25 Thread Alex Elder
motivation behind all of this is that we'll be doing some static initialization of some additional CCU-specific data soon.) Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-bcm281xx.c | 144 +++--- drivers/clk/bcm/clk-kona-setup.c | 47

[PATCH v2 05/12] clk: bcm281xx: define CCU clock data statically

2014-02-25 Thread Alex Elder
in clk-kona.h to avoid a forward dependency. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-bcm281xx.c | 132 ++ drivers/clk/bcm/clk-kona-setup.c | 60 - drivers/clk/bcm/clk-kona.h | 86

[PATCH v2 03/12] clk: bcm281xx: change some symbol names

2014-02-25 Thread Alex Elder
that the confusing 11351 string is used. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-bcm281xx.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm281xx.c b/drivers/clk/bcm/clk-bcm281xx.c index 3c66de6..bb947af

[PATCH v2 00/12] clk: bcm281xx: updates for 3.15

2014-02-25 Thread Alex Elder
removed in this version (that patch affected mach-bcm, not clk). I also split the final patch into two, with the second one isolating the change to a device tree file. -Alex Alex Elder (12): clk: bcm281xx: warn if ccu_wait_bit() fails clk

[PATCH v2 06/12] clk: bcm281xx: add clock policy support

2014-02-25 Thread Alex Elder
Add support for CCU policy engine control, and also for setting the mask bits for bus clocks that require a policy change to get activated. This includes adding validity checking framework for CCUs, to validate the policy fields if defined. Signed-off-by: Alex Elder el...@linaro.org --- drivers

[PATCH v2 01/12] clk: bcm281xx: warn if ccu_wait_bit() fails

2014-02-25 Thread Alex Elder
Don't let a failure of ccu_wait_bit() go unnoticed. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index e3d339e..c01d810 100644 --- a/drivers/clk/bcm/clk

[PATCH 1/5] clk: bcm281xx: move compatible string definitions

2014-02-28 Thread Alex Elder
-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-bcm281xx.c | 12 include/dt-bindings/clock/bcm281xx.h | 12 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm281xx.c b/drivers/clk/bcm/clk-bcm281xx.c index d0d3dde

[PATCH 5/5] ARM: dts: use real clocks for bcm21664

2014-02-28 Thread Alex Elder
Replace the fake fixed-rate clocks used previously for the bcm21664 family with real ones. Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/boot/dts/bcm21664.dtsi | 190 --- 1 file changed, 118 insertions(+), 72 deletions(-) diff --git a/arch/arm/boot

[PATCH 2/5] ARM: dts: revise kona clock binding document

2014-02-28 Thread Alex Elder
family - Add a list of the specific BCM281XX family compatible strings. - Reword the description of the table slightly. Signed-off-by: Alex Elder el...@linaro.org --- .../devicetree/bindings/clock/bcm-kona-clock.txt | 87 +++- 1 file changed, 47 insertions(+), 40

[PATCH 3/5] ARM: dts: define clock binding for bcm21664

2014-02-28 Thread Alex Elder
Document the device tree binding for Broadcom BCM28164 clock control units and clocks. This SoC uses Kona CCUs, similar to the BCM281XX SoC family. Signed-off-by: Alex Elder el...@linaro.org --- .../devicetree/bindings/clock/bcm-kona-clock.txt | 39 1 file changed, 39

[PATCH 0/5] clk: bcm21664: add common clock support

2014-02-28 Thread Alex Elder
of the git repository here: http://git.linaro.org/git/landing-teams/working/broadcom/kernel.git -Alex Alex Elder (5): clk: bcm281xx: move compatible string definitions ARM: dts: revise kona clock binding document Cleanup and prepare existing code

[PATCH 4/5] clk: bcm21664: use common clock framework

2014-02-28 Thread Alex Elder
will need to be added as required by the addition of additional drivers. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/Kconfig |2 +- drivers/clk/bcm/Makefile |1 + drivers/clk/bcm/clk-bcm21664.c | 290 ++ include

Re: [PATCH] ARM: dts: bcm28155-ap: leave camldo1 on to fix reboot

2014-03-12 Thread Alex Elder
upon entry. Add regulator-always-on to the camldo1 constraint to fix reboot. Reported-by: Alex Elder el...@linaro.org Signed-off-by: Matt Porter mpor...@linaro.org Tested-by: Alex Elder el...@linaro.org --- [Depends on BCM59056 regulator series dts support: http://www.gossamer-threads.com

[PATCH v2 RESEND] clk: support hardware-specific debugfs entries

2014-01-11 Thread Alex Elder
Add a new clk_ops-debug_init method to allow a clock hardware driver to populate the clock's debugfs directory with entries beyond those common for every clock. Signed-off-by: Alex Elder el...@linaro.org --- v2: - Define debug_init unconditionally (suggested by Gerhard Sittig). drivers/clk

[PATCH v2 2/3] clk: bcm281xx: don't disable unused peripheral clocks

2014-02-14 Thread Alex Elder
Add the CLK_IGNORE_UNUSED flag when setting up a peripheral clock. This prevents unused clocks from getting disabled, and by doing this we can use the common clock code even before we've resolved all the spots that need to get a reference to their clock. Signed-off-by: Alex Elder el...@linaro.org

[PATCH v2 3/3] ARM: dts: bcm281xx: define real clocks

2014-02-14 Thread Alex Elder
From: Alex Elder alex.el...@linaro.org Replace the fake clocks defined in the bcm11351.dtsi device tree file with real definitions backed by the new BCM281xx clock driver. Signed-off-by: Alex Elder el...@linaro.org Reviewed-by: Matt Porter matt.por...@linaro.org Reviewed-by: Tim Kryger tim.kry

Re: [PATCH] ARM: dts: remove bcm11351-brt.dts

2014-02-19 Thread Alex Elder
, it looks good to me. Reviewed-by: Alex Elder el...@linaro.org --- arch/arm/boot/dts/bcm11351-brt.dts | 54 -- 1 file changed, 54 deletions(-) delete mode 100644 arch/arm/boot/dts/bcm11351-brt.dts diff --git a/arch/arm/boot/dts/bcm11351-brt.dts b/arch

[PATCH 11/12] clk: bcm281xx: add bus clock support

2014-02-19 Thread Alex Elder
Add bus clock support. A bus clock has a subset of the components present in a peripheral clock (again, all optional): a gate; CCU policy management bits; and if needed, bits to control hysteresis. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c | 96

[PATCH 09/12] clk: bcm281xx: add an initialized flag

2014-02-19 Thread Alex Elder
Add a flag that tracks whether a clock has already been initialized. This will be used by the next patch to avoid initializing a clock more than once when it's listed as a prerequisite. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona.c | 16 ++-- drivers/clk

[PATCH 12/12] clk: bcm281xx: define a bus clock

2014-02-19 Thread Alex Elder
serves to show how that's done). Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/boot/dts/bcm11351.dtsi |3 ++- drivers/clk/bcm/clk-bcm281xx.c | 13 - include/dt-bindings/clock/bcm281xx.h |3 ++- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git

[PATCH 05/12] clk: bcm281xx: initialize CCU structures statically

2014-02-19 Thread Alex Elder
motivation behind all of this is that we'll be doing some static initialization of some additional CCU-specific data soon.) Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-bcm281xx.c | 144 +++--- drivers/clk/bcm/clk-kona-setup.c | 47

[PATCH 10/12] clk: bcm281xx: implement prerequisite clocks

2014-02-19 Thread Alex Elder
. There exist clocks that could specify more than one prequisite, but almost all clocks only ever use one. We can add support for more than one if we find we need it at some point. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c | 16 ++ drivers/clk

[PATCH 08/12] clk: bcm281xx: add clock hysteresis support

2014-02-19 Thread Alex Elder
Add support for clock gate hysteresis control. For now, if it's defined for a clock, it's enabled. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c | 30 ++ drivers/clk/bcm/clk-kona.c | 33

[PATCH 07/12] clk: bcm281xx: add clock policy support

2014-02-19 Thread Alex Elder
Add support for CCU policy engine control, and also for setting the mask bits for bus clocks that require a policy change to get activated. This includes adding validity checking framework for CCUs, to validate the policy fields if defined. Signed-off-by: Alex Elder el...@linaro.org --- drivers

[PATCH 04/12] mach-bcm: bcm281xx: more symbol cleanup

2014-02-19 Thread Alex Elder
As with the previous commit, this renames a few symbols that needlessly used 11351 rather than 281xx in their names. Support for the bcm11351 board is being removed from the kernel, and the family of boards is more properly referred to as bcm281xx. Signed-off-by: Alex Elder el...@linaro.org

[PATCH 06/12] clk: bcm281xx: define CCU clock data statically

2014-02-19 Thread Alex Elder
in clk-kona.h to avoid a forward dependency. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-bcm281xx.c | 132 ++ drivers/clk/bcm/clk-kona-setup.c | 60 - drivers/clk/bcm/clk-kona.h | 84

[PATCH 01/12] clk: bcm281xx: warn if ccu_wait_bit() fails

2014-02-19 Thread Alex Elder
Don't let a failure of ccu_wait_bit() go unnoticed. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index e3d339e..c01d810 100644 --- a/drivers/clk/bcm/clk

[PATCH 03/12] clk: bcm281xx: change some symbol names

2014-02-19 Thread Alex Elder
of places that the confusing 11351 string is used. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-bcm281xx.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm281xx.c b/drivers/clk/bcm/clk-bcm281xx.c index

[PATCH 02/12] clk: bcm281xx: use init_data.name for clock name

2014-02-19 Thread Alex Elder
Use the init_data.name field to hold the name of a Kona clock rather than duplicating it. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c |6 +++--- drivers/clk/bcm/clk-kona.c | 17 ++--- drivers/clk/bcm/clk-kona.h |3 +-- 3 files

[PATCH 00/12] clk: bcm281xx: updates for 3.14

2014-02-19 Thread Alex Elder
https://lkml.org/lkml/2014/2/14/456 https://lkml.org/lkml/2014/2/14/451 I've grouped them, and offer a little explanation of each of the groups below. -Alex Alex Elder (12): clk: bcm281xx: warn if ccu_wait_bit() fails clk: bcm281xx: use

[PATCH RESEND AGAIN] clk: support hardware-specific debugfs entries

2014-02-20 Thread Alex Elder
Add a new clk_ops-debug_init method to allow a clock hardware driver to populate the clock's debugfs directory with entries beyond those common for every clock. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/clk.c|4 include/linux/clk-provider.h |8

[PATCH] clk: bcm281xx: don't disable unused peripheral clocks

2014-02-12 Thread Alex Elder
Add the CLK_IGNORE_UNUSED flag when setting up a peripheral clock. This prevents unused clocks from getting disabled, and by doing this we can use the common clock code even before we've resolved all the spots that need to get a reference to their clock. Signed-off-by: Alex Elder el...@linaro.org

[PATCH RESEND] clk: support hardware-specific debugfs entries

2014-03-21 Thread Alex Elder
Add a new clk_ops-debug_init method to allow a clock hardware driver to populate the clock's debugfs directory with entries beyond those common for every clock. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/clk.c|4 include/linux/clk-provider.h |8

Re: [PATCH v2 00/12] clk: bcm281xx: updates for 3.15

2014-03-21 Thread Alex Elder
: bcm281xx: define real clocks 14a091d clk: bcm281xx: don't disable unused peripheral clocks 44bc5c4 clk: bcm281xx: add initial clock framework support dcb99fd Linux 3.14-rc7 On 02/25/2014 06:15 PM, Alex Elder wrote: This series includes updates for the bcm281xx clock code for 3.15. I had held off

Re: [PATCH] rbd: Use min_t() to fix comparison of distinct pointer types warning

2013-05-08 Thread Alex Elder
that to begin with. I'll pull this into the ceph tree. Thanks a lot. Reviewed-by: Alex Elder el...@inktank.com Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/block/rbd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/rbd.c b

Re: [patch] ceph: tidy ceph_mdsmap_decode() a little

2013-05-29 Thread Alex Elder
On 05/29/2013 01:22 AM, Dan Carpenter wrote: I introduced a new temporary variable info instead of m-m_info[mds]. Also I reversed the if condition and pulled everything in one indent level. Looks good. I will apply this for you. Reviewed-by: Alex Elder el...@inktank.com Signed-off

[PATCH RESEND] clk: clean up everything on debugfs error

2013-10-09 Thread Alex Elder
pointer. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/clk.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 2cf2ea6..77fcd06 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -272,7 +272,8 @@ static int

Re: [PATCH] libceph: ceph_pagelist_append might sleep while atomic

2013-05-14 Thread Alex Elder
. Reviewed-by: Alex Elder el...@inktank.com [13439.295457] ceph: mds0 reconnect start [13439.300572] BUG: sleeping function called from invalid context at include/linux/highmem.h:58 [13439.309243] in_atomic(): 1, irqs_disabled(): 0, pid: 12059, name: kworker/1:1 [13439.316464] 5 locks held

Re: [PATCH v2 1/3] ceph: fix up comment for ceph_count_locks() as to which lock to hold

2013-05-15 Thread Alex Elder
On 05/15/2013 11:38 AM, Jim Schutt wrote: Signed-off-by: Jim Schutt jasc...@sandia.gov Looks good. Reviewed-by: Alex Elder el...@inktank.com --- fs/ceph/locks.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ceph/locks.c b/fs/ceph/locks.c index 202dd3d

Re: [PATCH v2 2/3] ceph: add missing cpu_to_le32() calls when encoding a reconnect capability

2013-05-15 Thread Alex Elder
On 05/15/2013 11:38 AM, Jim Schutt wrote: In his review, Alex Elder mentioned that he hadn't checked that num_fcntl_locks and num_flock_locks were properly decoded on the server side, from a le32 over-the-wire type to a cpu type. I checked, and AFAICS it is done; those interested can

Re: [PATCH v2 3/3] ceph: ceph_pagelist_append might sleep while atomic

2013-05-15 Thread Alex Elder
as close a look at it this time. I appreciate your updating the series to include the things I mentioned. I'll commit these for you, and I'll get confirmation on the byte order thing as well. Reviewed-by: Alex Elder el...@inktank.com [13439.295457] ceph: mds0 reconnect start [13439.300572] BUG

[PATCH] clk: only call get_parent if there is one

2013-09-05 Thread Alex Elder
-off-by: Alex Elder el...@linaro.org --- drivers/clk/clk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 54a191c..ea8ff15 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1628,7 +1628,7 @@ int __clk_init(struct device *dev

[PATCH v3 3/5] ARM: configs: enable SMP in bcm_defconfig

2014-05-06 Thread Alex Elder
Also explicitly set CONFIG_NR_CPUS to 2, limiting it to the most we currently need. Signed-off-by: Ray Jui r...@broadcom.com Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/configs/bcm_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm

[PATCH v3 4/5] ARM: dts: enable SMP support for bcm28155

2014-05-06 Thread Alex Elder
Define nodes representing the two Cortex A9 CPUs in a bcm28155 SoC. Signed-off-by: Ray Jui r...@broadcom.com Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/boot/dts/bcm11351.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b

[PATCH v3 0/5] ARM: SMP: support Broadcom mobile SoCs

2014-05-06 Thread Alex Elder
v3.15-rc1 This series is available here: http://git.linaro.org/landing-teams/working/broadcom/kernel.git Branch review/bcm-smp-v3 Alex Elder (5): devicetree: bindings: document Broadcom CPU enable method ARM: add SMP support for Broadcom mobile SoCs ARM: configs: enable SMP

[PATCH v3 2/5] ARM: add SMP support for Broadcom mobile SoCs

2014-05-06 Thread Alex Elder
specified. The location of the special register is defined in the device tree using a secondary-boot-reg property in a node whose enable-method matches. Derived from code originally provided by Ray Jui r...@broadcom.com Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/mach-bcm/Kconfig | 18

[PATCH] devicetree: bindings: separate CPU enable method descriptions

2014-05-07 Thread Alex Elder
) are associated with the method. The existing enable method documentation is expanded and moved from .../arm/cpus.txt into new files accordingly. Signed-off-by: Alex Elder el...@linaro.org --- This series is available here: http://git.linaro.org/landing-teams/working/broadcom/kernel.git

Re: [PATCH] devicetree: bindings: separate CPU enable method descriptions

2014-05-08 Thread Alex Elder
On 05/08/2014 10:13 AM, Rob Herring wrote: On Wed, May 7, 2014 at 6:23 PM, Alex Elder el...@linaro.org wrote: The bindings for CPU enable methods are defined in .../arm/cpus.txt. As additional 32-bit ARM CPUS are converted to use the enable-method CPU property to imply a particular set of SMP

[PATCH v2] devicetree: bindings: separate CPU enable method descriptions

2014-05-08 Thread Alex Elder
) are associated with the method. The existing enable method documentation is expanded and moved from .../arm/cpus.txt into new files accordingly. Signed-off-by: Alex Elder el...@linaro.org --- v2: Rename arm,psci.txt to be psci.txt and fix its content .../bindings/arm/cpu-enable-method/README

Re: [PATCH v2] devicetree: bindings: separate CPU enable method descriptions

2014-05-08 Thread Alex Elder
On 05/08/2014 01:48 PM, Alex Elder wrote: The bindings for CPU enable methods are defined in .../arm/cpus.txt. As additional 32-bit ARM CPUS are converted to use the enable-method CPU property to imply a particular set of SMP operations to use, the list of these methods is likely to become

[PATCH v2 4/5] clk: bcm281xx: define a bus clock

2014-05-20 Thread Alex Elder
serves to show how that's done). Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-bcm281xx.c | 13 - include/dt-bindings/clock/bcm281xx.h | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm281xx.c b/drivers/clk/bcm/clk

[PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-20 Thread Alex Elder
. There exist clocks that could specify more than one prequisite, but almost all clocks only ever use one. We can add support for more than one if we find we need it at some point. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c | 16 ++ drivers/clk

[PATCH v2 3/5] clk: bcm281xx: add bus clock support

2014-05-20 Thread Alex Elder
Add bus clock support. A bus clock has a subset of the components present in a peripheral clock (again, all optional): a gate; CCU policy management bits; and if needed, bits to control hysteresis. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona-setup.c | 96

[PATCH v2 0/5] clk: bcm: prerequisite and bus clock support

2014-05-20 Thread Alex Elder
/working/broadcom/kernel.git Branch review/bcm-bus-clk -Alex Version history: v2: Added field p to the previously unnamed prereq union. Alex Elder (5): clk: bcm281xx: add an initialized flag clk: bcm281xx: implement prerequisite clocks clk: bcm281xx

[PATCH v2 1/5] clk: bcm281xx: add an initialized flag

2014-05-20 Thread Alex Elder
Add a flag that tracks whether a clock has already been initialized. This will be used by the next patch to avoid initializing a clock more than once when it's listed as a prerequisite. Signed-off-by: Alex Elder el...@linaro.org --- drivers/clk/bcm/clk-kona.c | 17 +++-- drivers/clk

[PATCH] clk: bcm/kona: implement determine_rate()

2014-05-20 Thread Alex Elder
by the new one. The parent clock that allows the peripheral clock to produce a rate closest to the one requested is the one selected, though the current parent is used by default. Signed-off-by: Alex Elder el...@linaro.org --- This patch is based on Mike Turquette's current clk-next branch

[PATCH v4 2/5] ARM: add SMP support for Broadcom mobile SoCs

2014-05-20 Thread Alex Elder
specified. The location of the special register is defined in the device tree using a secondary-boot-reg property in a node whose enable-method matches. Derived from code originally provided by Ray Jui r...@broadcom.com Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/mach-bcm/Kconfig| 18

[PATCH v4 3/5] ARM: configs: enable SMP in bcm_defconfig

2014-05-20 Thread Alex Elder
Also explicitly set CONFIG_NR_CPUS to 2, limiting it to the most we currently need. Signed-off-by: Ray Jui r...@broadcom.com Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/configs/bcm_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm

[PATCH v4 4/5] ARM: dts: enable SMP support for bcm28155

2014-05-20 Thread Alex Elder
Define nodes representing the two Cortex A9 CPUs in a bcm28155 SoC. Signed-off-by: Ray Jui r...@broadcom.com Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/boot/dts/bcm11351.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b

[PATCH v4 1/5] devicetree: bindings: document Broadcom CPU enable method

2014-05-20 Thread Alex Elder
. The use of an enable method also allows the SMP operation vector to be assigned as a result of device tree content for these SoCs. Signed-off-by: Alex Elder el...@linaro.org --- Documentation/devicetree/bindings/arm/cpus.txt | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v4 4/5] ARM: dts: enable SMP support for bcm28155

2014-05-20 Thread Alex Elder
Define nodes representing the two Cortex A9 CPUs in a bcm28155 SoC. Signed-off-by: Ray Jui r...@broadcom.com Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/boot/dts/bcm11351.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b

[PATCH v4 5/5] ARM: dts: enable SMP support for bcm21664

2014-05-20 Thread Alex Elder
Define nodes representing the two Cortex A9 CPUs in a bcm21644 SoC. Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/boot/dts/bcm21664.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/bcm21664.dtsi b/arch/arm/boot/dts/bcm21664.dtsi index

[PATCH v4 0/5] ARM: SMP: support Broadcom mobile SoCs

2014-05-20 Thread Alex Elder
onto v3.15-rc4 v2: - Fixed a Makefile error (:= should have been +=) - No longer set CONFIG_NR_CPUS in bcm_defconfig - Rebased onto v3.15-rc1 This series is available here: http://git.linaro.org/landing-teams/working/broadcom/kernel.git Branch review/bcm-smp-v4 Alex Elder (5

[PATCH v4 3/5] ARM: configs: enable SMP in bcm_defconfig

2014-05-20 Thread Alex Elder
Also explicitly set CONFIG_NR_CPUS to 2, limiting it to the most we currently need. Signed-off-by: Ray Jui r...@broadcom.com Signed-off-by: Alex Elder el...@linaro.org --- arch/arm/configs/bcm_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm

[PATCH v4 1/5] devicetree: bindings: document Broadcom CPU enable method

2014-05-20 Thread Alex Elder
. The use of an enable method also allows the SMP operation vector to be assigned as a result of device tree content for these SoCs. Signed-off-by: Alex Elder el...@linaro.org --- Documentation/devicetree/bindings/arm/cpus.txt | 12 1 file changed, 12 insertions(+) diff --git

  1   2   3   4   5   6   7   8   9   10   >