Re: [PATCH v4 1/2] vfio/mdev: Check globally for duplicate devices

2018-05-22 Thread Alex Williamson
[Cc +GVT-g maintainers/lists] On Tue, 22 May 2018 10:13:46 +0200 Cornelia Huck <coh...@redhat.com> wrote: > On Fri, 18 May 2018 13:10:25 -0600 > Alex Williamson <alex.william...@redhat.com> wrote: > > > When we create an mdev device, we check for duplicates ag

Re: [PATCH v4 1/2] vfio/mdev: Check globally for duplicate devices

2018-05-22 Thread Alex Williamson
[Cc +GVT-g maintainers/lists] On Tue, 22 May 2018 10:13:46 +0200 Cornelia Huck wrote: > On Fri, 18 May 2018 13:10:25 -0600 > Alex Williamson wrote: > > > When we create an mdev device, we check for duplicates against the > > parent device and return -EEXIST if found

[PATCH v4 2/2] vfio/mdev: Re-order sysfs attribute creation

2018-05-18 Thread Alex Williamson
by adding this attribute as a final step of our sysfs setup. Signed-off-by: Alex Williamson <alex.william...@redhat.com> --- drivers/vfio/mdev/mdev_sysfs.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfi

[PATCH v4 1/2] vfio/mdev: Check globally for duplicate devices

2018-05-18 Thread Alex Williamson
see -EAGAIN while the device is in this transitory state. Signed-off-by: Alex Williamson <alex.william...@redhat.com> --- Documentation/vfio-mediated-device.txt |5 ++ drivers/vfio/mdev/mdev_core.c | 102 +++- drivers/vfio/mdev/mdev_private.h

[PATCH v4 2/2] vfio/mdev: Re-order sysfs attribute creation

2018-05-18 Thread Alex Williamson
by adding this attribute as a final step of our sysfs setup. Signed-off-by: Alex Williamson --- drivers/vfio/mdev/mdev_sysfs.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c index 802df210929b

[PATCH v4 1/2] vfio/mdev: Check globally for duplicate devices

2018-05-18 Thread Alex Williamson
see -EAGAIN while the device is in this transitory state. Signed-off-by: Alex Williamson --- Documentation/vfio-mediated-device.txt |5 ++ drivers/vfio/mdev/mdev_core.c | 102 +++- drivers/vfio/mdev/mdev_private.h |2 - 3 files changed, 42

[PATCH v4 0/2] vfio/mdev: Device namespace protection

2018-05-18 Thread Alex Williamson
condition is about 50% easier to hit than it exists in this series with patch 1 alone. Thanks, Alex --- Alex Williamson (2): vfio/mdev: Check globally for duplicate devices vfio/mdev: Re-order sysfs attribute creation Documentation/vfio-mediated-device.txt |5 ++ drivers/vfio

[PATCH v4 0/2] vfio/mdev: Device namespace protection

2018-05-18 Thread Alex Williamson
condition is about 50% easier to hit than it exists in this series with patch 1 alone. Thanks, Alex --- Alex Williamson (2): vfio/mdev: Check globally for duplicate devices vfio/mdev: Re-order sysfs attribute creation Documentation/vfio-mediated-device.txt |5 ++ drivers/vfio

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-18 Thread Alex Williamson
On Fri, 18 May 2018 12:34:03 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 5/18/2018 3:07 AM, Alex Williamson wrote: > > On Fri, 18 May 2018 01:56:50 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > >> On 5/17/2018 9:50 PM, Ale

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-18 Thread Alex Williamson
On Fri, 18 May 2018 12:34:03 +0530 Kirti Wankhede wrote: > On 5/18/2018 3:07 AM, Alex Williamson wrote: > > On Fri, 18 May 2018 01:56:50 +0530 > > Kirti Wankhede wrote: > > > >> On 5/17/2018 9:50 PM, Alex Williamson wrote: > >>> On Thu, 17 Ma

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-17 Thread Alex Williamson
On Thu, 17 May 2018 15:37:37 -0600 Alex Williamson <alex.william...@redhat.com> wrote: > On Fri, 18 May 2018 01:56:50 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > On 5/17/2018 9:50 PM, Alex Williamson wrote: > > > On Thu, 17 May 2018 21:25:2

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-17 Thread Alex Williamson
On Thu, 17 May 2018 15:37:37 -0600 Alex Williamson wrote: > On Fri, 18 May 2018 01:56:50 +0530 > Kirti Wankhede wrote: > > > On 5/17/2018 9:50 PM, Alex Williamson wrote: > > > On Thu, 17 May 2018 21:25:22 +0530 > > > Kirti Wankhede wrote: > > >

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-17 Thread Alex Williamson
On Fri, 18 May 2018 01:56:50 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 5/17/2018 9:50 PM, Alex Williamson wrote: > > On Thu, 17 May 2018 21:25:22 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > >> On 5/17/2018 1:39 PM, Cornel

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-17 Thread Alex Williamson
On Fri, 18 May 2018 01:56:50 +0530 Kirti Wankhede wrote: > On 5/17/2018 9:50 PM, Alex Williamson wrote: > > On Thu, 17 May 2018 21:25:22 +0530 > > Kirti Wankhede wrote: > > > >> On 5/17/2018 1:39 PM, Cornelia Huck wrote: > >>> On Wed, 16 May 2018 2

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-17 Thread Alex Williamson
On Thu, 17 May 2018 21:25:22 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 5/17/2018 1:39 PM, Cornelia Huck wrote: > > On Wed, 16 May 2018 21:30:19 -0600 > > Alex Williamson <alex.william...@redhat.com> wrote: > > > >> When we create an md

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-17 Thread Alex Williamson
On Thu, 17 May 2018 21:25:22 +0530 Kirti Wankhede wrote: > On 5/17/2018 1:39 PM, Cornelia Huck wrote: > > On Wed, 16 May 2018 21:30:19 -0600 > > Alex Williamson wrote: > > > >> When we create an mdev device, we check for duplicates against the > >> pa

Re: [PATCH v2] vfio/mdev: Check globally for duplicate devices

2018-05-16 Thread Alex Williamson
On Thu, 17 May 2018 01:01:40 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 5/16/2018 8:53 PM, Alex Williamson wrote: > > When we create an mdev device, we check for duplicates against the > > parent device and return -EEXIST if found, but the mdev device > >

Re: [PATCH v2] vfio/mdev: Check globally for duplicate devices

2018-05-16 Thread Alex Williamson
On Thu, 17 May 2018 01:01:40 +0530 Kirti Wankhede wrote: > On 5/16/2018 8:53 PM, Alex Williamson wrote: > > When we create an mdev device, we check for duplicates against the > > parent device and return -EEXIST if found, but the mdev device > > namespace is global since w

[PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-16 Thread Alex Williamson
guarantee provided by the mdev core with respect to creation and removal of mdev devices, mdev_parent.lock provided this only as a side-effect of the implementation for locking the namespace per parent. That serialization is now removed. Signed-off-by: Alex Williamson <alex.william...@redhat.com> -

[PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-16 Thread Alex Williamson
guarantee provided by the mdev core with respect to creation and removal of mdev devices, mdev_parent.lock provided this only as a side-effect of the implementation for locking the namespace per parent. That serialization is now removed. Signed-off-by: Alex Williamson --- v3: Rework locking and add

[PATCH v2] vfio/mdev: Check globally for duplicate devices

2018-05-16 Thread Alex Williamson
paths, so mdev_parent.lock is removed. If we can show that vendor drivers handle the create/remove paths themselves, perhaps we can refine the locking granularity. Reviewed-by: Cornelia Huck <coh...@redhat.com> Signed-off-by: Alex Williamson <alex.william...@redhat.com> --- v2: Remove unn

[PATCH v2] vfio/mdev: Check globally for duplicate devices

2018-05-16 Thread Alex Williamson
paths, so mdev_parent.lock is removed. If we can show that vendor drivers handle the create/remove paths themselves, perhaps we can refine the locking granularity. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- v2: Remove unnecessary ret init per Cornelia's review drivers/vfio/mdev

Re: [PATCH] vfio/mdev: Check globally for duplicate devices

2018-05-16 Thread Alex Williamson
On Wed, 16 May 2018 11:05:06 +0200 Cornelia Huck <coh...@redhat.com> wrote: > On Tue, 15 May 2018 14:17:04 -0600 > Alex Williamson <alex.william...@redhat.com> wrote: > > > When we create an mdev device, we check for duplicates against the > > parent d

Re: [PATCH] vfio/mdev: Check globally for duplicate devices

2018-05-16 Thread Alex Williamson
On Wed, 16 May 2018 11:05:06 +0200 Cornelia Huck wrote: > On Tue, 15 May 2018 14:17:04 -0600 > Alex Williamson wrote: > > > When we create an mdev device, we check for duplicates against the > > parent device and return -EEXIST if found, but the mdev device > > name

[PATCH] vfio/mdev: Check globally for duplicate devices

2018-05-15 Thread Alex Williamson
paths, so mdev_parent.lock is removed. If we can show that vendor drivers handle the create/remove paths themselves, perhaps we can refine the locking granularity. Signed-off-by: Alex Williamson <alex.william...@redhat.com> --- drivers/vfio/mdev/mdev_core.c

[PATCH] vfio/mdev: Check globally for duplicate devices

2018-05-15 Thread Alex Williamson
paths, so mdev_parent.lock is removed. If we can show that vendor drivers handle the create/remove paths themselves, perhaps we can refine the locking granularity. Signed-off-by: Alex Williamson --- drivers/vfio/mdev/mdev_core.c| 79 ++ drivers/vfio/mdev

Re: [PATCH v2] vfio: platform: Make printed error messages more consistent

2018-05-11 Thread Alex Williamson
On Tue, 10 Apr 2018 16:54:11 +0200 Geert Uytterhoeven wrote: > - Capitalize the first word of error messages, > - Unwrap statements that fit on a single line, > - Use "VFIO" instead of "vfio" as the error message prefix. > > Signed-off-by: Geert Uytterhoeven

Re: [PATCH v2] vfio: platform: Make printed error messages more consistent

2018-05-11 Thread Alex Williamson
On Tue, 10 Apr 2018 16:54:11 +0200 Geert Uytterhoeven wrote: > - Capitalize the first word of error messages, > - Unwrap statements that fit on a single line, > - Use "VFIO" instead of "vfio" as the error message prefix. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Eric Auger >

Re: [PATCH v3 1/2] vfio: platform: Fix reset module leak in error path

2018-05-11 Thread Alex Williamson
On Wed, 11 Apr 2018 11:15:48 +0200 Geert Uytterhoeven wrote: > If the IOMMU group setup fails, the reset module is not released. > > Fixes: b5add544d677d363 ("vfio, platform: make reset driver a requirement by > default") > Signed-off-by: Geert Uytterhoeven

Re: [PATCH v3 1/2] vfio: platform: Fix reset module leak in error path

2018-05-11 Thread Alex Williamson
On Wed, 11 Apr 2018 11:15:48 +0200 Geert Uytterhoeven wrote: > If the IOMMU group setup fails, the reset module is not released. > > Fixes: b5add544d677d363 ("vfio, platform: make reset driver a requirement by > default") > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Eric Auger >

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-10 Thread Alex Williamson
On Thu, 10 May 2018 18:41:09 + "Stephen Bates" wrote: > >Reasons is that GPU are giving up on PCIe (see all specialize link like > >NVlink that are popping up in GPU space). So for fast GPU inter-connect > >we have this new links. > > I look forward

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-10 Thread Alex Williamson
On Thu, 10 May 2018 18:41:09 + "Stephen Bates" wrote: > >Reasons is that GPU are giving up on PCIe (see all specialize link like > >NVlink that are popping up in GPU space). So for fast GPU inter-connect > >we have this new links. > > I look forward to Nvidia

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-09 Thread Alex Williamson
On Wed, 9 May 2018 12:35:56 + "Stephen Bates" wrote: > Hi Alex and Don > > >Correct, the VM has no concept of the host's IOMMU groups, only > > the hypervisor knows about the groups, > > But as I understand it these groups are usually passed through to VMs > on

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-09 Thread Alex Williamson
On Wed, 9 May 2018 12:35:56 + "Stephen Bates" wrote: > Hi Alex and Don > > >Correct, the VM has no concept of the host's IOMMU groups, only > > the hypervisor knows about the groups, > > But as I understand it these groups are usually passed through to VMs > on a pre-group basis by

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 17:31:48 -0600 Logan Gunthorpe <log...@deltatee.com> wrote: > On 08/05/18 05:11 PM, Alex Williamson wrote: > > A runtime, sysfs approach has some benefits here, > > especially in identifying the device assuming we're ok with leaving > > the persistence

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 17:31:48 -0600 Logan Gunthorpe wrote: > On 08/05/18 05:11 PM, Alex Williamson wrote: > > A runtime, sysfs approach has some benefits here, > > especially in identifying the device assuming we're ok with leaving > > the persistence problem to userspace tools

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 19:06:17 -0400 Don Dutile wrote: > On 05/08/2018 05:27 PM, Stephen Bates wrote: > > As I understand it VMs need to know because VFIO passes IOMMU > > grouping up into the VMs. So if a IOMMU grouping changes the VM's > > view of its PCIe topology changes. I

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 19:06:17 -0400 Don Dutile wrote: > On 05/08/2018 05:27 PM, Stephen Bates wrote: > > As I understand it VMs need to know because VFIO passes IOMMU > > grouping up into the VMs. So if a IOMMU grouping changes the VM's > > view of its PCIe topology changes. I think we even have

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 22:25:06 + "Stephen Bates" wrote: > >Yeah, so based on the discussion I'm leaning toward just having a > >command line option that takes a list of BDFs and disables ACS > > for them. (Essentially as Dan has suggested.) This avoids the > >

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 22:25:06 + "Stephen Bates" wrote: > >Yeah, so based on the discussion I'm leaning toward just having a > >command line option that takes a list of BDFs and disables ACS > > for them. (Essentially as Dan has suggested.) This avoids the > > shotgun. > > I concur

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 16:10:19 -0600 Logan Gunthorpe <log...@deltatee.com> wrote: > On 08/05/18 04:03 PM, Alex Williamson wrote: > > If IOMMU grouping implies device assignment (because nobody else uses > > it to the same extent as device assignment) then the build-time optio

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 16:10:19 -0600 Logan Gunthorpe wrote: > On 08/05/18 04:03 PM, Alex Williamson wrote: > > If IOMMU grouping implies device assignment (because nobody else uses > > it to the same extent as device assignment) then the build-time option > > falls to pie

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 21:42:27 + "Stephen Bates" wrote: > Hi Alex > > >But it would be a much easier proposal to disable ACS when the > > IOMMU is not enabled, ACS has no real purpose in that case. > > I guess one issue I have with this is that it disables IOMMU

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 21:42:27 + "Stephen Bates" wrote: > Hi Alex > > >But it would be a much easier proposal to disable ACS when the > > IOMMU is not enabled, ACS has no real purpose in that case. > > I guess one issue I have with this is that it disables IOMMU groups > for all Root

Re: [PATCH v4 00/14] Copy Offload in NVMe Fabrics with P2P PCI Memory

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 17:25:24 -0400 Don Dutile <ddut...@redhat.com> wrote: > On 05/08/2018 12:57 PM, Alex Williamson wrote: > > On Mon, 7 May 2018 18:23:46 -0500 > > Bjorn Helgaas <helg...@kernel.org> wrote: > > > >> On Mon, Apr 23, 2018 at 05:30:32P

Re: [PATCH v4 00/14] Copy Offload in NVMe Fabrics with P2P PCI Memory

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 17:25:24 -0400 Don Dutile wrote: > On 05/08/2018 12:57 PM, Alex Williamson wrote: > > On Mon, 7 May 2018 18:23:46 -0500 > > Bjorn Helgaas wrote: > > > >> On Mon, Apr 23, 2018 at 05:30:32PM -0600, Logan Gunthorpe wrote: > >>>

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 14:49:23 -0600 Logan Gunthorpe <log...@deltatee.com> wrote: > On 08/05/18 02:43 PM, Alex Williamson wrote: > > Yes, GPUs seem to be leading the pack in implementing ATS. So now the > > dumb question, why not simply turn off the IOMMU and thus ACS? The

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 14:49:23 -0600 Logan Gunthorpe wrote: > On 08/05/18 02:43 PM, Alex Williamson wrote: > > Yes, GPUs seem to be leading the pack in implementing ATS. So now the > > dumb question, why not simply turn off the IOMMU and thus ACS? The > > argument of using t

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 14:19:05 -0600 Logan Gunthorpe <log...@deltatee.com> wrote: > On 08/05/18 02:13 PM, Alex Williamson wrote: > > Well, I'm a bit confused, this patch series is specifically disabling > > ACS on switches, but per the spec downstream switch ports implementing &

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 14:19:05 -0600 Logan Gunthorpe wrote: > On 08/05/18 02:13 PM, Alex Williamson wrote: > > Well, I'm a bit confused, this patch series is specifically disabling > > ACS on switches, but per the spec downstream switch ports implementing > > ACS MUST implem

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 13:45:50 -0600 Logan Gunthorpe <log...@deltatee.com> wrote: > On 08/05/18 01:34 PM, Alex Williamson wrote: > > They are not so unrelated, see the ACS Direct Translated P2P > > capability, which in fact must be implemented by switch downstream >

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 13:45:50 -0600 Logan Gunthorpe wrote: > On 08/05/18 01:34 PM, Alex Williamson wrote: > > They are not so unrelated, see the ACS Direct Translated P2P > > capability, which in fact must be implemented by switch downstream > > ports implementing ACS a

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 13:13:40 -0600 Logan Gunthorpe wrote: > On 08/05/18 10:50 AM, Christian König wrote: > > E.g. transactions are initially send to the root complex for > > translation, that's for sure. But at least for AMD GPUs the root complex > > answers with the

Re: [PATCH v4 04/14] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

2018-05-08 Thread Alex Williamson
On Tue, 8 May 2018 13:13:40 -0600 Logan Gunthorpe wrote: > On 08/05/18 10:50 AM, Christian König wrote: > > E.g. transactions are initially send to the root complex for > > translation, that's for sure. But at least for AMD GPUs the root complex > > answers with the translated address which is

Re: [PATCH v4 00/14] Copy Offload in NVMe Fabrics with P2P PCI Memory

2018-05-08 Thread Alex Williamson
On Mon, 7 May 2018 18:23:46 -0500 Bjorn Helgaas wrote: > On Mon, Apr 23, 2018 at 05:30:32PM -0600, Logan Gunthorpe wrote: > > Hi Everyone, > > > > Here's v4 of our series to introduce P2P based copy offload to NVMe > > fabrics. This version has been rebased onto v4.17-rc2. A

Re: [PATCH v4 00/14] Copy Offload in NVMe Fabrics with P2P PCI Memory

2018-05-08 Thread Alex Williamson
On Mon, 7 May 2018 18:23:46 -0500 Bjorn Helgaas wrote: > On Mon, Apr 23, 2018 at 05:30:32PM -0600, Logan Gunthorpe wrote: > > Hi Everyone, > > > > Here's v4 of our series to introduce P2P based copy offload to NVMe > > fabrics. This version has been rebased onto v4.17-rc2. A git repo > > is

Re: [PATCH] VFIO: Fix Documentation

2018-04-30 Thread Alex Williamson
On Fri, 20 Apr 2018 18:07:27 +0800 "dongbo (E)" wrote: > From: Dong Bo > > Signed-off-by: Dong Bo > --- Hi Dong Bo, The patch is corrupted, please resend and also include a commit log, something as simple as "Update

Re: [PATCH] VFIO: Fix Documentation

2018-04-30 Thread Alex Williamson
On Fri, 20 Apr 2018 18:07:27 +0800 "dongbo (E)" wrote: > From: Dong Bo > > Signed-off-by: Dong Bo > --- Hi Dong Bo, The patch is corrupted, please resend and also include a commit log, something as simple as "Update vfio_add_group_dev description to match the current API" would be fine.

Re: [PATCH v6 4/7] iommu/dma: Move PCI window region reservation back into dma specific path.

2018-04-30 Thread Alex Williamson
On Tue, 24 Apr 2018 13:16:19 + Shameerali Kolothum Thodi wrote: > Hi Joerg, > > Could you please take a look at this patch and let me know. > > I have rebased this to 4.17-rc1 and added Robin's R-by. > > This series[1] is now pending on this patch as

Re: [PATCH v6 4/7] iommu/dma: Move PCI window region reservation back into dma specific path.

2018-04-30 Thread Alex Williamson
On Tue, 24 Apr 2018 13:16:19 + Shameerali Kolothum Thodi wrote: > Hi Joerg, > > Could you please take a look at this patch and let me know. > > I have rebased this to 4.17-rc1 and added Robin's R-by. > > This series[1] is now pending on this patch as without this it will break few > ARM

Re: [PATCH] PCI: Add Intel 7th & 8th Gen mobile to ACS quirks

2018-04-27 Thread Alex Williamson
On Fri, 27 Apr 2018 13:09:56 -0500 Bjorn Helgaas <helg...@kernel.org> wrote: > On Wed, Apr 25, 2018 at 02:27:37PM -0600, Alex Williamson wrote: > > The specification update indicates these have the same errate for > > implementing non-standard ACS capabilities. > &g

Re: [PATCH] PCI: Add Intel 7th & 8th Gen mobile to ACS quirks

2018-04-27 Thread Alex Williamson
On Fri, 27 Apr 2018 13:09:56 -0500 Bjorn Helgaas wrote: > On Wed, Apr 25, 2018 at 02:27:37PM -0600, Alex Williamson wrote: > > The specification update indicates these have the same errate for > > implementing non-standard ACS capabilities. > > > > Signed-off-by: Alex

[PATCH] PCI: Add Intel 7th & 8th Gen mobile to ACS quirks

2018-04-25 Thread Alex Williamson
The specification update indicates these have the same errate for implementing non-standard ACS capabilities. Signed-off-by: Alex Williamson <alex.william...@redhat.com> --- drivers/pci/quirks.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/quirks.c b/d

[PATCH] PCI: Add Intel 7th & 8th Gen mobile to ACS quirks

2018-04-25 Thread Alex Williamson
The specification update indicates these have the same errate for implementing non-standard ACS capabilities. Signed-off-by: Alex Williamson --- drivers/pci/quirks.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index

Re: [PATCH 3/3] sample: vfio bochs vbe display (host device for bochs-drm)

2018-04-23 Thread Alex Williamson
On Mon, 9 Apr 2018 12:35:13 +0200 Gerd Hoffmann wrote: > Display device, demo-ing the vfio dmabuf display interface > (VFIO_GFX_PLANE_TYPE_DMABUF). Compatible enough to qemu stdvga > that bochs-drm.ko can be used as guest driver. > > Signed-off-by: Gerd Hoffmann

Re: [PATCH 3/3] sample: vfio bochs vbe display (host device for bochs-drm)

2018-04-23 Thread Alex Williamson
On Mon, 9 Apr 2018 12:35:13 +0200 Gerd Hoffmann wrote: > Display device, demo-ing the vfio dmabuf display interface > (VFIO_GFX_PLANE_TYPE_DMABUF). Compatible enough to qemu stdvga > that bochs-drm.ko can be used as guest driver. > > Signed-off-by: Gerd Hoffmann > --- >

Re: [PATCH 2/3] sample: vfio mdev display - guest driver

2018-04-23 Thread Alex Williamson
On Mon, 9 Apr 2018 12:35:12 +0200 Gerd Hoffmann wrote: > Guest fbdev driver for CONFIG_SAMPLE_VFIO_MDEV_MDPY. > > Signed-off-by: Gerd Hoffmann > --- > samples/vfio-mdev/mdpy-fb.c | 232 > > samples/Kconfig

Re: [PATCH 2/3] sample: vfio mdev display - guest driver

2018-04-23 Thread Alex Williamson
On Mon, 9 Apr 2018 12:35:12 +0200 Gerd Hoffmann wrote: > Guest fbdev driver for CONFIG_SAMPLE_VFIO_MDEV_MDPY. > > Signed-off-by: Gerd Hoffmann > --- > samples/vfio-mdev/mdpy-fb.c | 232 > > samples/Kconfig | 9 ++ >

Re: [PATCH 1/3] sample: vfio mdev display - host device

2018-04-23 Thread Alex Williamson
On Mon, 9 Apr 2018 12:35:11 +0200 Gerd Hoffmann wrote: > Simple framebuffer display, demo-ing the vfio region display interface > (VFIO_GFX_PLANE_TYPE_REGION). > > Signed-off-by: Gerd Hoffmann > --- > samples/vfio-mdev/mdpy-defs.h | 19 + >

Re: [PATCH 1/3] sample: vfio mdev display - host device

2018-04-23 Thread Alex Williamson
On Mon, 9 Apr 2018 12:35:11 +0200 Gerd Hoffmann wrote: > Simple framebuffer display, demo-ing the vfio region display interface > (VFIO_GFX_PLANE_TYPE_REGION). > > Signed-off-by: Gerd Hoffmann > --- > samples/vfio-mdev/mdpy-defs.h | 19 + > samples/vfio-mdev/mdpy.c | 791 >

[PATCH] vfio/type1: Fix task tracking for QEMU vCPU hotplug

2018-04-23 Thread Alex Williamson
efficiency as this is now recorded once per MAP_DMA ioctl. Reported-by: Xu Yandong <xuyando...@huawei.com> Signed-off-by: Alex Williamson <alex.william...@redhat.com> --- drivers/vfio/vfio_iommu_type1.c | 73 +-- 1 file changed, 47 insertions(+), 26 deleti

[PATCH] vfio/type1: Fix task tracking for QEMU vCPU hotplug

2018-04-23 Thread Alex Williamson
efficiency as this is now recorded once per MAP_DMA ioctl. Reported-by: Xu Yandong Signed-off-by: Alex Williamson --- drivers/vfio/vfio_iommu_type1.c | 73 +-- 1 file changed, 47 insertions(+), 26 deletions(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

2018-04-23 Thread Alex Williamson
On Mon, 23 Apr 2018 15:23:11 -0500 Bjorn Helgaas <helg...@kernel.org> wrote: > On Mon, Apr 23, 2018 at 01:10:44PM -0600, Alex Williamson wrote: > > On Mon, 23 Apr 2018 13:28:22 -0400 > > Sinan Kaya <ok...@codeaurora.org> wrote: > > > > > On

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

2018-04-23 Thread Alex Williamson
On Mon, 23 Apr 2018 15:23:11 -0500 Bjorn Helgaas wrote: > On Mon, Apr 23, 2018 at 01:10:44PM -0600, Alex Williamson wrote: > > On Mon, 23 Apr 2018 13:28:22 -0400 > > Sinan Kaya wrote: > > > > > On 4/20/2018 11:04 AM, Alex Williamson wrote: > > >

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

2018-04-23 Thread Alex Williamson
On Mon, 23 Apr 2018 13:28:22 -0400 Sinan Kaya <ok...@codeaurora.org> wrote: > On 4/20/2018 11:04 AM, Alex Williamson wrote: > > Is there a concern here about whether the endpoint device driver or the > > PCI core really knows better about link retraining? This makes me >

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

2018-04-23 Thread Alex Williamson
On Mon, 23 Apr 2018 13:28:22 -0400 Sinan Kaya wrote: > On 4/20/2018 11:04 AM, Alex Williamson wrote: > > Is there a concern here about whether the endpoint device driver or the > > PCI core really knows better about link retraining? This makes me > > remember my unfinished

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

2018-04-20 Thread Alex Williamson
On Fri, 20 Apr 2018 09:00:49 -0500 Bjorn Helgaas wrote: > [+cc Rajat, Alex because of their interest in the reset/hotplug issue] > > For context, Sinan's patch is this: > > > diff --git a/drivers/infiniband/hw/hfi1/pcie.c > > b/drivers/infiniband/hw/hfi1/pcie.c > > index

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

2018-04-20 Thread Alex Williamson
On Fri, 20 Apr 2018 09:00:49 -0500 Bjorn Helgaas wrote: > [+cc Rajat, Alex because of their interest in the reset/hotplug issue] > > For context, Sinan's patch is this: > > > diff --git a/drivers/infiniband/hw/hfi1/pcie.c > > b/drivers/infiniband/hw/hfi1/pcie.c > > index 83d66e8..75f49e3

Re: [PATCH] vfio iommu type1: no need to check task->mm if task has been destroyed

2018-04-19 Thread Alex Williamson
On Thu, 19 Apr 2018 10:19:26 -0600 Alex Williamson <alex.william...@redhat.com> wrote: > [cc +Kirti] > > On Wed, 18 Apr 2018 18:55:45 +0800 > Xu Yandong <xuyando...@huawei.com> wrote: > > > The task structure in vfio_dma struct used to identify the same >

Re: [PATCH] vfio iommu type1: no need to check task->mm if task has been destroyed

2018-04-19 Thread Alex Williamson
On Thu, 19 Apr 2018 10:19:26 -0600 Alex Williamson wrote: > [cc +Kirti] > > On Wed, 18 Apr 2018 18:55:45 +0800 > Xu Yandong wrote: > > > The task structure in vfio_dma struct used to identify the same > > task who map it or other task who shares same adress sp

Re: [PATCH] vfio iommu type1: no need to check task->mm if task has been destroyed

2018-04-19 Thread Alex Williamson
[cc +Kirti] On Wed, 18 Apr 2018 18:55:45 +0800 Xu Yandong wrote: > The task structure in vfio_dma struct used to identify the same > task who map it or other task who shares same adress space is > allowed to unmap. But if the task who map it has exited, mm of > the task

Re: [PATCH] vfio iommu type1: no need to check task->mm if task has been destroyed

2018-04-19 Thread Alex Williamson
[cc +Kirti] On Wed, 18 Apr 2018 18:55:45 +0800 Xu Yandong wrote: > The task structure in vfio_dma struct used to identify the same > task who map it or other task who shares same adress space is > allowed to unmap. But if the task who map it has exited, mm of > the task has been set to null, we

Re: [PATCH v4 04/22] iommu/vt-d: add bind_pasid_table function

2018-04-17 Thread Alex Williamson
On Mon, 16 Apr 2018 14:48:53 -0700 Jacob Pan wrote: > Add Intel VT-d ops to the generic iommu_bind_pasid_table API > functions. > > The primary use case is for direct assignment of SVM capable > device. Originated from emulated IOMMU in the guest, the request

Re: [PATCH v4 04/22] iommu/vt-d: add bind_pasid_table function

2018-04-17 Thread Alex Williamson
On Mon, 16 Apr 2018 14:48:53 -0700 Jacob Pan wrote: > Add Intel VT-d ops to the generic iommu_bind_pasid_table API > functions. > > The primary use case is for direct assignment of SVM capable > device. Originated from emulated IOMMU in the guest, the request goes > through many layers (e.g.

Re: [PATCH v4 09/22] iommu/vt-d: add svm/sva invalidate function

2018-04-17 Thread Alex Williamson
On Mon, 16 Apr 2018 14:48:58 -0700 Jacob Pan wrote: > When Shared Virtual Address (SVA) is enabled for a guest OS via > vIOMMU, we need to provide invalidation support at IOMMU API and driver > level. This patch adds Intel VT-d specific function to implement >

Re: [PATCH v4 09/22] iommu/vt-d: add svm/sva invalidate function

2018-04-17 Thread Alex Williamson
On Mon, 16 Apr 2018 14:48:58 -0700 Jacob Pan wrote: > When Shared Virtual Address (SVA) is enabled for a guest OS via > vIOMMU, we need to provide invalidation support at IOMMU API and driver > level. This patch adds Intel VT-d specific function to implement > iommu passdown invalidate API for

Re: [RFC PATCH] vfio: Implement new Ioctl VFIO_IOMMU_GET_DIRTY_BITMAP

2018-04-10 Thread Alex Williamson
On Tue, 10 Apr 2018 09:19:26 -0600 Alex Williamson <alex.william...@redhat.com> wrote: > On Tue, 10 Apr 2018 16:18:59 +0800 > Yulei Zhang <yulei.zh...@intel.com> wrote: > > > Corresponding to the V4 migration patch set for vfio pci device, > > this pa

Re: [RFC PATCH] vfio: Implement new Ioctl VFIO_IOMMU_GET_DIRTY_BITMAP

2018-04-10 Thread Alex Williamson
On Tue, 10 Apr 2018 09:19:26 -0600 Alex Williamson wrote: > On Tue, 10 Apr 2018 16:18:59 +0800 > Yulei Zhang wrote: > > > Corresponding to the V4 migration patch set for vfio pci device, > > this patch is to implement the new ioctl VFIO_IOMMU_GET_DIRTY_BITMAP > >

Re: [RFC PATCH] vfio: Implement new Ioctl VFIO_IOMMU_GET_DIRTY_BITMAP

2018-04-10 Thread Alex Williamson
pe1.c > @@ -41,6 +41,7 @@ > #include > #include > #include > +#include > > #define DRIVER_VERSION "0.2" > #define DRIVER_AUTHOR "Alex Williamson <alex.william...@redhat.com>" > @@ -1658,6 +1659,23 @@ static int vfio_domains_have_iomm

Re: [RFC PATCH] vfio: Implement new Ioctl VFIO_IOMMU_GET_DIRTY_BITMAP

2018-04-10 Thread Alex Williamson
ude > #include > +#include > > #define DRIVER_VERSION "0.2" > #define DRIVER_AUTHOR "Alex Williamson " > @@ -1658,6 +1659,23 @@ static int vfio_domains_have_iommu_cache(struct > vfio_iommu *iommu) > return ret; > } > > +static void

[GIT PULL] VFIO updates for v4.17

2018-04-06 Thread Alex Williamson
(Shunyong Yang) - More efficient PFN mapping handling in type1 backend (Jason Cai) - VFIO device ioeventfd interface (Alex Williamson) - Tag new vfio-platform sub-maintainer (Alex Williamson) Alex Williamson (4): vfio

[GIT PULL] VFIO updates for v4.17

2018-04-06 Thread Alex Williamson
(Shunyong Yang) - More efficient PFN mapping handling in type1 backend (Jason Cai) - VFIO device ioeventfd interface (Alex Williamson) - Tag new vfio-platform sub-maintainer (Alex Williamson) Alex Williamson (4): vfio

Re: [PATCH] MAINTAINERS: vfio/platform: Update sub-maintainer

2018-04-02 Thread Alex Williamson
ted in adding entries only as tokens of company lineage, we have attributes in source files and commit logs for that. I do appreciate you making us aware of Baptiste's departure though so that we can keep these entries current. Thanks, Alex > On Mon, Apr 2, 2018 at 5:19 PM, Alex Williamson > <

Re: [PATCH] MAINTAINERS: vfio/platform: Update sub-maintainer

2018-04-02 Thread Alex Williamson
source files and commit logs for that. I do appreciate you making us aware of Baptiste's departure though so that we can keep these entries current. Thanks, Alex > On Mon, Apr 2, 2018 at 5:19 PM, Alex Williamson > wrote: > > On Mon, 26 Mar 2018 13:42:02 -0600 > > Alex Williams

Re: [PATCH] MAINTAINERS: vfio/platform: Update sub-maintainer

2018-04-02 Thread Alex Williamson
On Mon, 26 Mar 2018 13:42:02 -0600 Alex Williamson <alex.william...@redhat.com> wrote: > Baptiste has changed positions and has not been active with > vfio-platform, replace with the current, de-facto sub-maintainer > Eric Auger. Also add Alvise Rigo as a designated reviewer. >

Re: [PATCH] MAINTAINERS: vfio/platform: Update sub-maintainer

2018-04-02 Thread Alex Williamson
On Mon, 26 Mar 2018 13:42:02 -0600 Alex Williamson wrote: > Baptiste has changed positions and has not been active with > vfio-platform, replace with the current, de-facto sub-maintainer > Eric Auger. Also add Alvise Rigo as a designated reviewer. > > Cc: Eric Auger &g

[PATCH] MAINTAINERS: vfio/platform: Update sub-maintainer

2018-03-26 Thread Alex Williamson
Baptiste has changed positions and has not been active with vfio-platform, replace with the current, de-facto sub-maintainer Eric Auger. Also add Alvise Rigo as a designated reviewer. Cc: Eric Auger <eric.au...@redhat.com> Cc: Alvise Rigo <a.r...@virtualopensystems.com> Signed-

[PATCH] MAINTAINERS: vfio/platform: Update sub-maintainer

2018-03-26 Thread Alex Williamson
Baptiste has changed positions and has not been active with vfio-platform, replace with the current, de-facto sub-maintainer Eric Auger. Also add Alvise Rigo as a designated reviewer. Cc: Eric Auger Cc: Alvise Rigo Signed-off-by: Alex Williamson --- MAINTAINERS |3 ++- 1 file changed, 2

Re: [PATCH] MAINTAINERS: vfio-platform: Update sub-maintainers

2018-03-23 Thread Alex Williamson
On Fri, 23 Mar 2018 18:59:29 +0100 Alvise Rigo wrote: > Update the sub-maintainer entry as Baptiste has moved. > > Add me and Eric Auger as sub-maintainers of the VFIO plaform driver. > > Signed-off-by: Alvise Rigo > --- >

Re: [PATCH] MAINTAINERS: vfio-platform: Update sub-maintainers

2018-03-23 Thread Alex Williamson
On Fri, 23 Mar 2018 18:59:29 +0100 Alvise Rigo wrote: > Update the sub-maintainer entry as Baptiste has moved. > > Add me and Eric Auger as sub-maintainers of the VFIO plaform driver. > > Signed-off-by: Alvise Rigo > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

<    4   5   6   7   8   9   10   11   12   13   >