Re: [PATCH v4 38/52] docs: block: typec_bus.rst: get rid of :c:type

2020-09-30 Thread André Almeida
t;blk-mq.rst". > > Signed-off-by: Mauro Carvalho Chehab After solving the issue above: Reviewed-by: André Almeida > --- > Documentation/block/blk-mq.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/block/bl

Re: [PATCH v4 22/52] docs: get rid of :c:type explicit declarations for structs

2020-09-30 Thread André Almeida
o, that automatically > convert: > struct foo > > into cross-references, let's get rid of that, solving > several warnings when building docs with Sphinx 3.x. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/block/blk-mq.rst| 8 ++

Re: [PATCH] media: vimc: Implement debayer control for mean window size

2019-09-03 Thread André Almeida
Hello Arthur and Laís, Thanks for your patch! On 9/1/19 4:40 PM, Arthur Moraes do Lago wrote: > Add mean window size parameter for debayer filter as a control in > vimc-debayer. > > vimc-debayer was patched to allow changing mean windows parameter > of the filter without needing to reload the

Re: [PATCH 0/7] media: vimc: Add a V4L2 output device

2019-07-30 Thread André Almeida
On 7/13/19 7:03 AM, Hans Verkuil wrote: > On 7/12/19 5:38 PM, André Almeida wrote: >> Hello, >> >> On 7/10/19 4:33 AM, Hans Verkuil wrote: >>> On 7/10/19 12:19 AM, Helen Koike wrote: >>>> Hi André, >>>> >>>> Thanks for the patch

Re: [PATCH 2/2] Revert "media: vimc: propagate pixel format in the stream"

2019-07-09 Thread André Almeida
evert...", not sure if this is relevant. I've applied this changes at media-master and `test-media vimc` (from v4l-utils) got 0 errors and 0 warnings. I've also tested with qv4l2, and the streaming went as expected for all capture devices. Tested-by:  André Almeida > --- >

Re: [PATCH 4/4] media: docs: create vimc documentation

2019-06-14 Thread André Almeida
Hello Hans, On 6/14/19 4:30 AM, Hans Verkuil wrote: > Hi André, > > Thanks for working one this, very nice to have this documentation. > > Some comments below: > > [...] > > Regards, > > Hans Thanks for the feedback! I saw that 1/4 and 2/4 already are at your [GIT PULL v5.3], so my v2

Re: [PATCH] block: blk-mq.c: fix @at_head kernel-doc warning

2020-08-16 Thread André Almeida
Hi Randy, On 8/16/20 7:25 PM, Randy Dunlap wrote: > Fix a new kernel-doc warning in block/blk-mq.c: > > ../block/blk-mq.c:1844: warning: Function parameter or member 'at_head' not > described in 'blk_mq_request_bypass_insert' > > Fixes: 105663f73e71 ("blk-mq: Document functions for sending

[PATCH 1/2] docs: Make syscalls' helpers naming consistent

2021-01-29 Thread André Almeida
to reflect this. Cc: Dominik Brodowski Fixes: 819671ff849b ("syscalls: define and explain goal to not call syscalls in the kernel") Signed-off-by: André Almeida --- Documentation/process/adding-syscalls.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentati

[PATCH 2/2] Documentation: admin-guide: Update kvm/xen config option

2021-01-29 Thread André Almeida
Since commit 9bba03d4473d ("kconfig: remove 'kvmconfig' and 'xenconfig' shorthands") kvm/xen config shortcuts are not available anymore. Update the file to reflect how they should be used, with the full filename. Signed-off-by: André Almeida --- Documentation/admin-guide/READ

[PATCH 0/4] futex: Minor code improvements

2020-05-27 Thread André Almeida
Hello, This series aims to make some small code improvements that I found in futex.c, removing some lines and trying to make the code easier to read and understand. All commits tested with futex tests from kselftest. André Almeida (4): futex: Remove put_futex_key() futex: Remove needless

[PATCH 1/4] futex: Remove put_futex_key()

2020-05-27 Thread André Almeida
Since 4b39f99c ("futex: Remove {get,drop}_futex_key_refs()"), function put_futex_key() is empty. Remove all references for this function and redundant labels. Signed-off-by: André Almeida --- kernel/futex.c | 61 ++ 1 file changed, 12

[PATCH 3/4] futex: Remove unused or redundant includes

2020-05-27 Thread André Almeida
s. Signed-off-by: André Almeida --- To test this code, I compiled with different configurations (x86_64, i386, with x32 ABI supported enabled/disabled), and ran futex selftests. --- kernel/futex.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/kernel/futex.c b/kernel/fut

[PATCH 4/4] futex: Consistently use fshared as boolean

2020-05-27 Thread André Almeida
Since fshared is meant to true/false values, declare it as bool. If the code ever reaches the code beneath again label, we are sure that the futex is shared, so we can use the true value instead of the variable. Signed-off-by: André Almeida --- kernel/futex.c | 9 + 1 file changed, 5

[PATCH 2/4] futex: Remove needless goto's

2020-05-27 Thread André Almeida
the result of the operation when is logically possible to determine it by the control flow. [1] https://www.kernel.org/doc/html/latest/process/coding-style.html#centralized-exiting-of-functions Signed-off-by: André Almeida --- kernel/futex.c | 40 1 file c

[PATCH] docs: block: Create blk-mq documentation

2020-05-27 Thread André Almeida
y Axboe et al. Signed-off-by: André Almeida --- Hello, This commit was tested using "make htmldocs" and the HTML output has been verified. Thanks, André --- Documentation/block/blk-mq.rst | 154 + Documentation/block/index.rst | 1 +

Re: [PATCH] docs: block: Create blk-mq documentation

2020-06-05 Thread André Almeida
Hello Randy, On 5/27/20 6:58 PM, Randy Dunlap wrote: > On 5/27/20 1:09 PM, André Almeida wrote: >> Create a documentation providing a background and explanation around the >> operation of the Multi-Queue Block IO Queueing Mechanism (blk-mq). >> +Har

[PATCH v2] docs: block: Create blk-mq documentation

2020-06-05 Thread André Almeida
y Axboe et al. Signed-off-by: André Almeida --- Changes from v1: - Fixed typos - Reworked blk_mq_hw_ctx Hello, This commit was tested using "make htmldocs" and the HTML output has been verified. Thanks, André --- Documentation/bl

Re: [PATCH 0/7] media: vimc: Add a V4L2 output device

2019-07-12 Thread André Almeida
Hello, On 7/10/19 4:33 AM, Hans Verkuil wrote: > On 7/10/19 12:19 AM, Helen Koike wrote: >> Hi André, >> >> Thanks for the patches. >> >> On 7/2/19 12:47 PM, André Almeida wrote: >>> Hello, >>> >>> This patch adds a V4L2 output de

Re: [PATCH 1/1] blk-mq: fill header with kernel-doc

2019-09-30 Thread André Almeida
On 9/30/19 6:54 PM, Minwoo Im wrote: > Hi André, > >> -/* >> +/** >> + * blk_mq_rq_from_pdu - cast a PDU to a request >> + * @pdu: the PDU (protocol unit request) to be casted > > It makes sense, but it looks like PDU stands for protocol unit request. > Could we have it "PDU(Protocol Data Unit)"

Re: [PATCH 1/1] blk-mq: fill header with kernel-doc

2019-09-30 Thread André Almeida
On 9/30/19 7:01 PM, Bart Van Assche wrote: > On 9/30/19 12:48 PM, André Almeida wrote: >> Insert documentation for structs, enums and functions at header file. >> Format existing and new comments at struct blk_mq_ops as >> kernel-doc comments. > > Hi André, > &g

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread André Almeida
Hello Shuah, Thanks for the patch, I did some comments below. On 8/9/19 6:45 PM, Shuah Khan wrote: > vimc uses Component API to split the driver into functional components. > The real hardware resembles a monolith structure than component and > component structure added a level of complexity

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread André Almeida
On 8/9/19 9:17 PM, Shuah Khan wrote: > Hi Andre, > > On 8/9/19 5:52 PM, André Almeida wrote: >> Hello Shuah, >> >> Thanks for the patch, I did some comments below. >> >> On 8/9/19 6:45 PM, Shuah Khan wrote: >>> vimc uses Component API to split the

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-12 Thread André Almeida
Hi Shuah, On 8/12/19 11:08 AM, Shuah Khan wrote: > On 8/9/19 9:51 PM, Helen Koike wrote: >> Hi Andre, >> >> Thanks for testing this. >> >> On 8/9/19 9:24 PM, André Almeida wrote: >>> On 8/9/19 9:17 PM, Shuah Khan wrote: >>>> Hi Andre, >>

Re: [Lkcamp] [RFC PATCH] media: vimc: vimc_pix_map_fmt_info() can be static

2019-10-07 Thread André Almeida
Hi Helen, On 10/5/19 10:36 PM, Helen Koike wrote: > Hi Carlos, > > On 10/5/19 9:28 PM, kbuild test robot wrote: >> Fixes: 4d124d159dff ("media: vimc: get pixformat info from v4l2_format_info >> to avoid code repetition") > Usually, the Fixes flag is used for something that is already accepted in

[PATCH v3 1/1] blk-mq: fill header with kernel-doc

2019-10-21 Thread André Almeida
Insert documentation for structs, enums and functions at header file. Format existing and new comments at struct blk_mq_ops as kernel-doc comments. Signed-off-by: André Almeida --- Hello, This patch is an effort to enhance the documentation of the multiqueue API. To check if the comments

Re: [RFC 0/4] futex2: Add new futex interface

2020-06-25 Thread André Almeida
Hello Arnd, On 6/25/20 3:48 AM, Arnd Bergmann wrote: > On Fri, Jun 12, 2020 at 8:51 PM André Almeida > wrote: > >> - The proposed interface uses ktime_t type for absolute timeout, and I >> assumed that it should use values in a nsec resolution. If this is true, >&

[PATCH 5.7 1/1] fuse: fix weird page warning

2020-07-21 Thread André Almeida
Signed-off-by: Miklos Szeredi Signed-off-by: André Almeida --- fs/fuse/dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 5c155437a455..ec02c3240176 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -771,7 +771,8 @@ static int fuse_

[PATCH] futex: MAINTAINERS: Re-add selftests directory

2020-07-15 Thread André Almeida
Commit 95ca6d73a8a97 ("docs: move locking-specific documents to locking/") accidentally replaced the selftests line for a duplicated documentation one. Revert this change. Signed-off-by: André Almeida --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [RESEND PATCH 3/4] futex: Remove unused or redundant includes

2020-07-17 Thread André Almeida
On 7/17/20 6:46 PM, Thomas Gleixner wrote: > André Almeida writes: > >> Since 82af7aca ("Removal of FUTEX_FD"), some includes related to file >> operations aren't needed anymore. More investigation around the includes >> showed that a lot of includes aren't

[PATCH] fuse: Update project homepage

2020-07-23 Thread André Almeida
As stated in https://sourceforge.net/projects/fuse/, "the FUSE project has moved to https://github.com/libfuse/; in 22-Dec-2015. Update URLs to reflect this. Signed-off-by: André Almeida --- Documentation/filesystems/fuse.rst | 2 +- MAINTAINERS| 2 +- fs/fuse/Kc

Re: [PATCH 1/1] staging: media: fix style problem

2019-06-20 Thread André Almeida
Hello Alisgar, On 6/20/19 2:31 AM, Aliasgar Surti wrote: > From: Aliasgar Surti > > checkpatch reported "WARNING: line over 80 characters". > This patch fixes the warning for file davinci_vpfe/dm365_isif.c > > Signed-off-by: Aliasgar Surti > --- >

Re: [PATCH v3 1/2] media: vimc: stream: add missing function documentation

2019-06-22 Thread André Almeida
Hello Mauro, On 6/21/19 6:17 PM, Mauro Carvalho Chehab wrote: > Em Mon, 17 Jun 2019 10:32:20 -0300 > André Almeida escreveu: > >> Add comments at vimc_streamer_s_stream and vimc_streamer_thread, making >> the vimc-stream totally documented. > I'm applying it right now. &

[PATCH 4/5] media: vimc.rst: Add a proper alt attribute to vimc.dot

2019-06-23 Thread André Almeida
Signed-off-by: André Almeida --- Documentation/media/v4l-drivers/vimc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/v4l-drivers/vimc.rst b/Documentation/media/v4l-drivers/vimc.rst index 4628b12d417f..bece85867424 100644 --- a/Documentation/media/v4l-driver

[PATCH 1/5] media: vimc: stream: remove obsolete function doc

2019-06-23 Thread André Almeida
As a more complete version of vimc_streamer_s_streamer comment was added at "media: vimc: stream: add missing function documentation" commit in .c file, remove the old documentation from .h file. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.h | 8 --

[PATCH 5/5] media: vimc.rst: add vimc-streamer source documentation

2019-06-23 Thread André Almeida
Since vimc-streamer.{c, h} are fully documented and conforming with the kernel-doc syntax, add those files to vimc.rst Signed-off-by: André Almeida Suggested-by: Mauro Carvalho Chehab --- Documentation/media/v4l-drivers/vimc.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH 3/5] media: vimc: stream: format comments as kernel-doc

2019-06-23 Thread André Almeida
Format the current existing comments as kernel-doc comments, to be reused at kernel documention. Add opening marks (/**) and return values. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.c | 38 + 1 file changed, 24 insertions(+), 14 deletions

[PATCH 2/5] media: vimc: stream: fix style of argument description

2019-06-23 Thread André Almeida
As in "Function parameters" at doc-guide/kernel-doc.rst, "the continuation of the description should start at the same column as the previous line". Make the @producer_pixfmt comply with that. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.h | 1

Re: [PATCH 3/5] media: vimc: stream: format comments as kernel-doc

2019-06-23 Thread André Almeida
On 6/23/19 1:40 PM, André Almeida wrote: > Format the current existing comments as kernel-doc comments, to be > reused at kernel documention. Add opening marks (/**) and return values. > > Signed-off-by: André Almeida > --- > drivers/media/platform/vimc/vi

Re: [PATCH 3/5] media: vimc: stream: format comments as kernel-doc

2019-06-24 Thread André Almeida
On 6/24/19 6:40 AM, Mauro Carvalho Chehab wrote: > Em Sun, 23 Jun 2019 18:27:22 -0300 > André Almeida escreveu: > >> On 6/23/19 1:40 PM, André Almeida wrote: >>> - * Calls s_stream to enable stream in all entities of the pipeline. >>> + * Calls ``vimc_streamer_s

[PATCH v2 1/5] media: vimc: stream: remove obsolete function doc

2019-06-24 Thread André Almeida
As a more complete version of vimc_streamer_s_streamer comment was added at "media: vimc: stream: add missing function documentation" commit in .c file, remove the old documentation from .h file. Signed-off-by: André Almeida --- Changes in v2: none drivers/media/platform/vimc/vimc-

[PATCH v2 2/5] media: vimc: stream: fix style of argument description

2019-06-24 Thread André Almeida
As in "Function parameters" at doc-guide/kernel-doc.rst, "the continuation of the description should start at the same column as the previous line". Make the @producer_pixfmt comply with that. Signed-off-by: André Almeida --- Changes in v2: none drivers/media/platform/

[PATCH v2 5/5] media: vimc.rst: add vimc-streamer source documentation

2019-06-24 Thread André Almeida
Since vimc-streamer.{c, h} are fully documented and conforming with the kernel-doc syntax, add those files to vimc.rst Signed-off-by: André Almeida Suggested-by: Mauro Carvalho Chehab --- Changes in v2: none Documentation/media/v4l-drivers/vimc.rst | 11 +++ 1 file changed, 11

[PATCH v2 4/5] media: vimc.rst: Add a proper alt attribute to vimc.dot

2019-06-24 Thread André Almeida
Signed-off-by: André Almeida --- Changes in v2: none Documentation/media/v4l-drivers/vimc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/v4l-drivers/vimc.rst b/Documentation/media/v4l-drivers/vimc.rst index 4628b12d417f..bece85867424 100644 --- a/Documenta

[PATCH v2 3/5] media: vimc: stream: format comments as kernel-doc

2019-06-24 Thread André Almeida
Format the current existing comments as kernel-doc comments, to be reused at kernel documention. Add opening marks (/**) and return values. Signed-off-by: André Almeida --- Changes in v2: replace ``vimc_streamer_s_stream`` for vimc_streamer_s_stream(). drivers/media/platform/vimc/vimc

[PATCH v2 1/2] media: vimc: stream: add missing function documentation

2019-06-15 Thread André Almeida
Add comments at vimc_streamer_s_stream and vimc_streamer_thread, making the vimc-stream totally documented. Signed-off-by: André Almeida --- Commit extracted from [PATCH 0/4] media: vimc: Minor code cleanup and documentation Changes in v2: fix typos drivers/media/platform/vimc/vimc-streamer.c

[PATCH v2 2/2] media: docs: create vimc documentation

2019-06-15 Thread André Almeida
Create vimc documentation file to explain it basics features, it's topology, how to configure it and to document vimc's subdevices. Signed-off-by: André Almeida Suggested-by: Helen Koike --- Commit extracted from [PATCH 0/4] media: vimc: Minor code cleanup and documentation Changes in v2

[PATCH v3 1/2] media: vimc: stream: add missing function documentation

2019-06-17 Thread André Almeida
Add comments at vimc_streamer_s_stream and vimc_streamer_thread, making the vimc-stream totally documented. Signed-off-by: André Almeida --- Changes in v3: replace "streaming" by "stream" at vimc_streamer_thread(). Changes in v2: fix typos drivers/media/platform/vimc/

[PATCH v3 2/2] media: docs: create vimc documentation

2019-06-17 Thread André Almeida
Create vimc documentation file to explain it basics features, it's topology, how to configure it and to document vimc's subdevices. Signed-off-by: André Almeida Suggested-by: Helen Koike --- Changes in v3: none Changes in v2: - Fix typos - Make clear what does means scale factor

[PATCH] media: vimc: cap: check v4l2_fill_pixfmt return value

2019-06-17 Thread André Almeida
an error value if vimc_cap_try_fmt_vid_cap() has failed. Signed-off-by: André Almeida Suggested-by: Helen Koike --- Hello, This commit was suggest by Helen at "[v3,05/14] media: vimc: cap: refactor singleplanar as a subset of multiplanar" drivers/media/platform/vimc/vimc-capture.c | 5 +++

[PATCH 0/7] media: vimc: Add a V4L2 output device

2019-07-02 Thread André Almeida
uires v4l-utils): Open the output device: $ qv4l2 -d2 Open the capture device: $ qv4l2 -d3 Start the streaming at both, at any order. You can change the frame content at "Test Pattern Generator" -> "Test Pattern" on the output. Thanks, André André Almeida (7):

[PATCH 1/7] media: vimc: Create video module

2019-07-02 Thread André Almeida
of a video output device in vimc, as it will make easier for code reuse and simplicity. Signed-off-by: André Almeida --- drivers/media/platform/vimc/Makefile | 2 +- drivers/media/platform/vimc/vimc-capture.c | 341 ++--- drivers/media/platform/vimc/vimc-video.c | 264

[PATCH 2/7] media: vimc: video: Add write file operation

2019-07-02 Thread André Almeida
Add write on the list of vb2 file operations. This is required to create a V4L2 output device. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-video.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/vimc/vimc-video.h b/drivers/media/platform/vimc

[PATCH 3/7] media: vimc: Create a V4L2 output device

2019-07-02 Thread André Almeida
in the pipeline. Add a vb2 buffer validate function. This is required to create a V4L2 output device. Signed-off-by: André Almeida --- drivers/media/platform/vimc/Makefile| 4 +- drivers/media/platform/vimc/vimc-common.h | 5 +- drivers/media/platform/vimc/vimc-debayer.c | 11 +- drivers/media

[PATCH 4/7] media: vimc: Send null buffer through the pipeline

2019-07-02 Thread André Almeida
Send a NULL buffer through the video pipeline. If the Capture device gets a NULL buffer, it uses it default fallback frame. Make the capture device behave more like real devices when there's no frame to show. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-capture.c | 15

[PATCH 7/7] media: vimc.rst: Add output device

2019-07-02 Thread André Almeida
Add information about the output device. Remove wrong information about what the capture exposes. Signed-off-by: André Almeida --- Documentation/media/v4l-drivers/vimc.rst | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/media/v4l-drivers/vimc.rst

[PATCH 6/7] media: vimc.dot: Update default topology diagram

2019-07-02 Thread André Almeida
Update the default topology diagram to reflect the current state of the driver. Signed-off-by: André Almeida --- Documentation/media/v4l-drivers/vimc.dot | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/media/v4l-drivers/vimc.dot b/Documentation/media/v4l

[PATCH 5/7] media: vimc: core: Add output device on the pipeline

2019-07-02 Thread André Almeida
Add the output video device on the hardcoded pipeline. Change the link to it be enabled by default. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-core.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/vimc/vimc-core.c b

Re: [PATCH v7 02/14] media: doc: add document for rkisp1 meta buffer format

2019-07-04 Thread André Almeida
Hello Helen, On 7/3/19 4:08 PM, Helen Koike wrote: > From: Jacob Chen > > This commit add document for rkisp1 meta buffer format > > Signed-off-by: Jacob Chen > Acked-by: Hans Verkuil > [update for upstream] > Signed-off-by: Helen Koike > > --- > > Changes in v7: > -

Re: [PATCH v7 10/14] dt-bindings: Document the Rockchip ISP1 bindings

2019-07-04 Thread André Almeida
Hello Helen, On 7/3/19 4:09 PM, Helen Koike wrote: > From: Jacob Chen > > Add DT bindings documentation for Rockchip ISP1 > > Signed-off-by: Jacob Chen > Reviewed-by: Rob Herring > [update for upstream] > Signed-off-by: Helen Koike > > --- > > Changes in v7: > - update document with new

Re: [PATCH v7 11/14] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings

2019-07-04 Thread André Almeida
Hello Helen, On 7/3/19 4:09 PM, Helen Koike wrote: > From: Jacob Chen > > Add DT bindings documentation for Rockchip MIPI D-PHY RX > > Signed-off-by: Jacob Chen > Reviewed-by: Rob Herring > [update for upstream] > Signed-off-by: Helen Koike > > --- > > Changes in v7: > - updated doc with new

Re: [PATCH v7 08/14] media: rkisp1: add capture device driver

2019-07-04 Thread André Almeida
Hello Helen, On 7/3/19 4:09 PM, Helen Koike wrote: > From: Jacob Chen > > This is the capture device interface driver that provides the v4l2 > user interface. Frames can be received from ISP1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong Zhong >

[PATCH v2 2/2] docs: kmemleak: add more documentation details

2019-06-12 Thread André Almeida
Wikipedia now has a main article to "tracing garbage collector" topic. Change the URL and use the reStructuredText syntax for hyperlinks and add more details about the use of the tool. Add a section about how to use the kmemleak-test module to test the memory leak scanning. Signed-off

[PATCH v2 1/2] mm: kmemleak: change error at _write when kmemleak is disabled

2019-06-12 Thread André Almeida
According to POSIX, EBUSY means that the "device or resource is busy", and this can lead to people thinking that the file `/sys/kernel/debug/kmemleak/` is somehow locked or being used by other process. Change this error code to a more appropriate one. Signed-off-by: André Almeida

[PATCH 0/4] media: vimc: Minor code cleanup and documentation

2019-06-13 Thread André Almeida
Hello, This patch series does some cleanup on the code and add a file for Vimc at the kernel documentation. Thanks, André André Almeida (4): media: vimc: debayer: Fix typos media: vimc: Makefile: file cleanup media: vimc: stream: add missing function documentation media: docs

[PATCH 2/4] media: vimc: Makefile: file cleanup

2019-06-13 Thread André Almeida
programs, change to `-y`, more straightforward for device drivers. Signed-off-by: André Almeida Suggested-by: Helen Koike --- drivers/media/platform/vimc/Makefile| 12 +++- drivers/media/platform/vimc/vimc-common.c | 4 drivers/media/platform/vimc/vimc-streamer.c | 4

[PATCH 1/4] media: vimc: debayer: Fix typos

2019-06-13 Thread André Almeida
Fix typo on "tranforming". Add a line break so it keeps under 80 columns. Fix typo on "[it] need". Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-debayer.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/vi

[PATCH 4/4] media: docs: create vimc documentation

2019-06-13 Thread André Almeida
Create vimc documentation file to explain it basics features, it's topology, how to configure it and to document vimc's subdevices. Signed-off-by: André Almeida Suggested-by: Helen Koike --- Documentation/media/v4l-drivers/index.rst | 1 + Documentation/media/v4l-drivers/vimc.dot | 22

[PATCH 3/4] media: vimc: stream: add missing function documentation

2019-06-13 Thread André Almeida
Add comments at vimc_streamer_s_stream and vimc_streamer_thread, making the vimc-stream totally documented. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.c | 22 + 1 file changed, 22 insertions(+) diff --git a/drivers/media/platform/vimc/vimc

[RESEND PATCH 0/4] futex: Minor code improvements

2020-07-02 Thread André Almeida
Hello, This series aims to make some small code improvements that I found in futex.c, removing some lines and trying to make the code easier to read and understand. All commits tested with futex tests from kselftest. Thanks, André André Almeida (4): futex: Remove put_futex_key

[RESEND PATCH 1/4] futex: Remove put_futex_key()

2020-07-02 Thread André Almeida
Since 4b39f99c ("futex: Remove {get,drop}_futex_key_refs()"), function put_futex_key() is empty. Remove all references for this function and redundant labels. Signed-off-by: André Almeida --- kernel/futex.c | 61 ++ 1 file changed, 12

[RESEND PATCH 2/4] futex: Remove needless goto's

2020-07-02 Thread André Almeida
the result of the operation when is logically possible to determine it by the control flow. [1] https://www.kernel.org/doc/html/latest/process/coding-style.html#centralized-exiting-of-functions Signed-off-by: André Almeida --- kernel/futex.c | 40 1 file c

[RESEND PATCH 4/4] futex: Consistently use fshared as boolean

2020-07-02 Thread André Almeida
Since fshared is meant to true/false values, declare it as bool. If the code ever reaches the code beneath again label, we are sure that the futex is shared, so we can use the true value instead of the variable. Signed-off-by: André Almeida --- kernel/futex.c | 9 + 1 file changed, 5

[RESEND PATCH 3/4] futex: Remove unused or redundant includes

2020-07-02 Thread André Almeida
s. Signed-off-by: André Almeida --- To test this code, I compiled with different configurations (x86_64, i386, with x32 ABI supported enabled/disabled), and ran futex selftests. --- kernel/futex.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/kernel/futex.c b/kernel/fut

[RFC v2 2/4] selftests: futex: Add futex2 wake/wait test

2020-07-09 Thread André Almeida
, since futex2 doesn't supports 32 bit sized time. Signed-off-by: André Almeida --- tools/include/uapi/asm-generic/unistd.h | 7 +- .../selftests/futex/functional/.gitignore | 1 + .../selftests/futex/functional/Makefile | 4 +- .../selftests/futex/functional/futex2_wait.c

[RFC v2 0/4] futex2: Add new futex interface

2020-07-09 Thread André Almeida
interface was removed v1: https://lore.kernel.org/patchwork/cover/1255437/ [1] https://lore.kernel.org/patchwork/patch/1194339/ André Almeida (4): futex2: Add new futex interface selftests: futex: Add futex2 wake/wait test selftests: futex: Add futex2 timeout test selftests: futex: Add futex2

[RFC v2 1/4] futex2: Add new futex interface

2020-07-09 Thread André Almeida
ace, those failures were expected. All kernel selftests were successful. [1] https://gitlab.collabora.com/tonyk/linux/-/commits/futex2 [2] https://lore.kernel.org/patchwork/patch/1194339/ [3] https://gitlab.collabora.com/tonyk/glibc/-/commits/futex2 Signed-off-by: André Almeida --- M

[RFC v2 3/4] selftests: futex: Add futex2 timeout test

2020-07-09 Thread André Almeida
Adapt existing futex wait timeout file to test the same mechanism for futex2. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_timeout.c | 38 ++- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/futex/functional

[RFC v2 4/4] selftests: futex: Add futex2 wouldblock test

2020-07-09 Thread André Almeida
Adapt existing futex wait wouldblock file to test the same mechanism for futex2. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_wouldblock.c | 33 --- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/futex/functional

Re: [RFC v2 1/4] futex2: Add new futex interface

2020-07-09 Thread André Almeida
Hello, On 7/9/20 9:09 PM, Randy Dunlap wrote: > Hi, > > On 7/9/20 10:59 AM, André Almeida wrote: >> >> >> diff --git a/kernel/futex2.c b/kernel/futex2.c >> new file mode 100644 >> index ..b87a10ba7c01 >> --- /dev/null >> +++ b/kern

Re: [RFC v2 0/4] futex2: Add new futex interface

2020-07-10 Thread André Almeida
Hi On 7/10/20 10:23 AM, Oleksandr Natalenko wrote: > Hello. > > On 09.07.2020 19:59, André Almeida wrote: >> This RFC is a followup to the previous discussion initiated from my last >> patch "futex: Implement mechanism to wait on any of several futexes"

[PATCH v3] docs: block: Create blk-mq documentation

2020-06-19 Thread André Almeida
y Axboe et al. Signed-off-by: André Almeida --- Changes from v2: - More fixed typos - Once again, reworked the definition of `blk_mq_hw_ctx` in "Hardware dispatch queues" section Changes from v1: - Fixed typos - Reworked blk_mq_hw_ctx Hello, This commit was tested using "ma

Re: [PATCH v2] docs: block: Create blk-mq documentation

2020-06-19 Thread André Almeida
On 6/19/20 5:49 PM, Jens Axboe wrote: > On 6/19/20 1:47 PM, Randy Dunlap wrote: >> On 6/19/20 12:45 PM, Jonathan Corbet wrote: >>> On Fri, 5 Jun 2020 14:55:36 -0300 >>> André Almeida wrote: >>> >>>> Create a documentation providing a back

Re: [PATCH v3] docs: block: Create blk-mq documentation

2020-06-19 Thread André Almeida
On 6/19/20 5:56 PM, Jens Axboe wrote: > On 6/19/20 2:01 PM, André Almeida wrote: >> Create a documentation providing a background and explanation around the >> operation of the Multi-Queue Block IO Queueing Mechanism (blk-mq). >> >> The reference for writing this docume

[PATCH v4] docs: block: Create blk-mq documentation

2020-06-19 Thread André Almeida
y Axboe et al. Acked-by: Randy Dunlap Signed-off-by: André Almeida --- Change from v4: - blk_mq_ctx represents software stating queues, not requests - Reworded collection of BIOs to one or more BIOs - Replace NOOP scheduler with NONE scheduler. Changes from v2: - More fixed typos - Once again

[RFC 3/4] selftests: futex: Add futex2 timeout test

2020-06-12 Thread André Almeida
Adapt existing futex wait timeout file to test the same mechanism for futex2. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_timeout.c | 27 --- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/futex/functional

[RFC 2/4] selftests: futex: Add futex2 wake/wait test

2020-06-12 Thread André Almeida
Add a simple test to test wake/wait mechanism using futex2 interface. Create helper files so more tests can evaluate futex2. Signed-off-by: André Almeida --- tools/include/uapi/asm-generic/unistd.h | 7 +- .../selftests/futex/functional/.gitignore | 1 + .../selftests/futex

[RFC 1/4] futex2: Add new futex interface

2020-06-12 Thread André Almeida
/futex2 [2] https://lore.kernel.org/patchwork/patch/1194339/ [3] https://gitlab.collabora.com/tonyk/glibc/-/commits/futex2 Signed-off-by: André Almeida --- MAINTAINERS| 2 +- arch/x86/entry/syscalls/syscall_32.tbl | 2 + arch/x86/entry/syscalls/syscall_64.tbl | 2 + inc

[RFC 4/4] selftests: futex: Add futex2 wouldblock test

2020-06-12 Thread André Almeida
Adapt existing futex wait wouldblock file to test the same mechanism for futex2. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_wouldblock.c | 34 --- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/futex/functional

[RFC 0/4] futex2: Add new futex interface

2020-06-12 Thread André Almeida
u64 hint; }; Thanks, André André Almeida (4): futex2: Add new futex interface selftests: futex: Add futex2 wake/wait test selftests: futex: Add futex2 timeout test selftests: futex: Add futex2 wouldblock test MAINTAINERS | 2 +- arch/x86/entr

Re: [PATCH v2] docs: block: Create blk-mq documentation

2020-06-16 Thread André Almeida
On 6/5/20 8:45 PM, Dongli Zhang wrote: > Hi André, > > On 6/5/20 10:55 AM, André Almeida wrote: >> Create a documentation providing a background and explanation around the >> operation of the Multi-Queue Block IO Queueing Mechanism (blk-mq). >> >> The referen

Re: [PATCH v2] docs: block: Create blk-mq documentation

2020-06-16 Thread André Almeida
On 6/15/20 9:15 PM, Randy Dunlap wrote: > Hi, > I have a few more editing comments for you (below): > > On 6/5/20 10:55 AM, André Almeida wrote: >> Create a documentation providing a background and explanation around the >> operation of the Multi-Queue Block IO Qu

Re: [RFC 0/4] futex2: Add new futex interface

2020-06-13 Thread André Almeida
Hello H.J., On 6/12/20 4:35 PM, H.J. Lu wrote: > On Fri, Jun 12, 2020 at 11:53 AM André Almeida via Libc-alpha > wrote: >> - Is expected to have a x32 ABI implementation as well? In the case of >> wait and wake, we could use the same as x86_64 ABI. However, for the &g

Re: [PATCH 00/16] media: vimc: Add support for multiplanar formats

2019-03-15 Thread André Almeida
On 3/15/19 1:43 PM, André Almeida wrote: Hello, This series implements support for multiplane pixel formats at vimc. A lot of changes were required since vimc support for singleplane was "hardcoded". The code has been adapted in order to support both formats. When was possible, the

Re: [PATCH 5/8] media: vimc: stream: cleanup frame field from struct vimc_stream

2019-03-07 Thread André Almeida
and with v4l2-compliance --streaming=5 -d /dev/videoX and no regressions where found. On 3/6/19 7:42 PM, Helen Koike wrote: There is no need to have the frame field in the vimc_stream struct. Signed-off-by: Helen Koike Tested-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.c

Re: [PATCH 7/8] media: vimc: stream: init/terminate the first entity

2019-03-07 Thread André Almeida
/dev/videoX and no regressions where found. Tested-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.c | 25 - 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/vimc/vimc-streamer.c b/drivers/media/platform/vimc/vimc

Re: [PATCH 8/8] media: vimc: propagate pixel format in the stream

2019-03-07 Thread André Almeida
and no regressions where found. Tested-by: André Almeida --- drivers/media/platform/vimc/vimc-capture.c | 76 +++-- drivers/media/platform/vimc/vimc-common.c | 307 drivers/media/platform/vimc/vimc-common.h | 13 + drivers/media/platform/vimc/vimc-debayer.c

Re: [RFC PATCH 4/4] docs: tmpfs: Add casefold options

2021-03-24 Thread André Almeida
Hi Gabriel, Às 19:19 de 23/03/21, Gabriel Krisman Bertazi escreveu: André Almeida writes: Document mounting options to enable casefold support in tmpfs. Signed-off-by: André Almeida --- Documentation/filesystems/tmpfs.rst | 26 ++ 1 file changed, 26 insertions

Re: [RFC PATCH 2/4] mm: shmem: Support case-insensitive file name lookups

2021-03-24 Thread André Almeida
Às 17:18 de 23/03/21, Gabriel Krisman Bertazi escreveu: André Almeida writes: opt = fs_parse(fc, shmem_fs_parameters, param, ); if (opt < 0) @@ -3468,6 +3519,23 @@ static int shmem_parse_one(struct fs_context *fc, struct fs_parameter *param) ctx->full

Re: [RFC PATCH 2/4] mm: shmem: Support case-insensitive file name lookups

2021-03-24 Thread André Almeida
Hi Al Viro, Às 20:19 de 23/03/21, Al Viro escreveu: On Tue, Mar 23, 2021 at 04:59:39PM -0300, André Almeida wrote: * dcache handling: For now, negative lookups are not inserted in the dcache, since they would need to be invalidated anyway, because we can't trust missing file dentries

Re: [RFC PATCH 1/4] Revert "libfs: unexport generic_ci_d_compare() and generic_ci_d_hash()"

2021-03-24 Thread André Almeida
Hi Matthew, Às 17:15 de 23/03/21, Matthew Wilcox escreveu: On Tue, Mar 23, 2021 at 04:59:38PM -0300, André Almeida wrote: This reverts commit 794c43f716845e2d48ce195ed5c4179a4e05ce5f. For implementing casefolding support at tmpfs, it needs to set dentry operations at superblock level, given

  1   2   >