Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

nd the patch > 732374a0b440d9a79c8412f318a25cd37ba6f4e2 added the enable/disable > callback functions, so the gemgxlpll PLL, I have no idea why power > management disable it, I would keep trace it. Does that mean that CONFIG_PM also affects the FU740? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG K

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

too late. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS

That doesn't look correct. It reverses the condition without reversing the result, which means the result is probably the opposite than intended. The same expression occurs two more times in this file. Do those need to be changed as well? Andreas. -- Andreas Schwab, sch...@linux-m68k.o

Re: [PATCH 2/4] exec: remove compat_do_execve

On Mär 26 2021, Christoph Hellwig wrote: > Just call compat_do_execve instead. ITYM compat_do_execveat here. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE

OMMAND_LINE_SIZE); > + cmdline_build(boot_command_line, NULL, COMMAND_LINE_SIZE); > pr_info("Forcing kernel command line to: %s\n", boot_command_line); Shouldn't that message become conditional in some way? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerp

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

at's exactly the issue. The process is stuck in D. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

iscv64.raw.xz Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

Were you able to reproduce the problem? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: macb broken on HiFive Unleashed

On Mär 19 2021, Yixun Lan wrote: > what's the exact root cause? and any solution? Try reverting the five commits starting with 732374a0b440d9a79c8412f318a25cd37ba6f4e2. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA A

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

On Mär 19 2021, Zong Li wrote: > Could you please point me out how to test the ethernet from your side? Please use <https://github.com/openSUSE/kernel-source/blob/stable/config/riscv64/default>. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5

Re: macb broken on HiFive Unleashed

It turned out to be a broken clock driver. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

40. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: macb broken on HiFive Unleashed

On Mär 13 2021, Emil Renner Berthing wrote: > As you can see I haven't updated OpenSBI or u-boot in a while Does it also work if you use the u-boot SPL instead of FSBL? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA A

Re: macb broken on HiFive Unleashed

g zero to 'PTR_ERR' > 0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config method > e4e143e26ce8 net: macb: add support for high speed interface Unfortunately, that didn't help. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 255

macb broken on HiFive Unleashed

] macb 1009.ethernet: GEM doesn't support hardware ptp. [ 12.760178] libphy: MACB_mii_bus: probed [ 12.881792] MACsec IEEE 802.1AE [ 12.944426] macb 1009.ethernet eth0: Cadence GEM rev 0x10070109 at 0x1009 irq 16 (70:b3:d5:92:f1:07) Andreas. -- Andreas Schwab, sch...@linux

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

acro 'pr_err' >>233 | pr_err("Invalid free of 0x%p (in kfence-#%zd):\n", (void >> *)address, >>| ^~ >> >> Christophe > > No this is not expected. Is 'signed size_t' != 'long int' on ppc32? If you want to format a ptrdiff_t you should use %td. Andreas. --

Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"

; This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65. > > Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy > reset") > Cc: sta...@vger.kernel.org > Signed-off-by: Palmer Dabbelt This fixes ethernet on the HiFive Unleashed with 5.10.12. Andreas.

Re: [PATCH] arch: m68k: include: asm: Reconstruct the sentence in file sun3ints.h

On Feb 05 2021, Bhaskar Chowdhury wrote: > -/* master list of VME vectors -- don't fuck with this */ > +/* master list of VME vectors -- don't do anything with this */ don't mess with this Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510

Re: [PATCH v2 0/3] fix macb phy probe failure if phy-reset is not handled

.ethernet: Registered clk switch 'sifive-gemgxl-mgmt' [ 12.784559] macb 1009.ethernet: GEM doesn't support hardware ptp. [ 12.791629] libphy: MACB_mii_bus: probed [ 12.919728] MACsec IEEE 802.1AE [ 12.984676] macb 1009.ethernet eth0: Cadence GEM rev 0x10070109 at 0x1009 irq 16 (70:b3:d5:92:f1:07) [ 14.030319] Microsemi VSC8541 SyncE 1009.ethernet-:00: phy_poll_reset failed: -110 [ 14.038986] macb 1009.ethernet eth0: Could not attach PHY (-110) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

[PATCH] powerpc/vdso: fix clock_gettime_fallback for vdso32

the 32-bit vdso. Signed-off-by: Andreas Schwab --- arch/powerpc/include/asm/vdso/gettimeofday.h | 8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/include/asm/vdso/gettimeofday.h b/arch/powerpc/include/asm/vdso/gettimeofday.h index 81671aa365b3..a26c12df2c9a 100644

Re: [PATCH] sh: boards: Fix the cacography in irq.c

On Nov 19 2020, Tang Bin wrote: > The world 'swtich' is wrong, so fix it. s/world/word/ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 2/2] m68k: let clk_enable() return immediately if clk is NULL

le(struct clk *clk) > { > unsigned long flags; > + if (!clk) > + return; That fails to return a value. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: riscv+KASAN does not boot

uot; Do you get more output with earlycon=sbi? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

[PATCH] riscv: return -ENOSYS for syscall -1

Properly return -ENOSYS for syscall -1 instead of leaving the return value uninitialized. This fixes the strace teststuite. Fixes: 5340627e3fe0 ("riscv: add support for SECCOMP and SECCOMP_FILTER") Signed-off-by: Andreas Schwab --- arch/riscv/kernel/entry.S | 9 + 1 file

Re: [PATCH] riscv: Fixed kernel test robot warning

This patch should fixed it. Or rename it to main, like most other asm-offsets files. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] riscv: Fixed kernel test robot warning

On Dez 09 2020, Souptick Joarder wrote: > On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab wrote: >> >> On Dez 09 2020, Souptick Joarder wrote: >> >> > Kernel test robot throws below warning - >> > >> >arch/riscv/kernel/asm-offsets.c:14:6: warn

Re: [Y2038][time namespaces] Question regarding CLOCK_REALTIME support plans in Linux time namespaces

ld test what we ship. seccomp and ptrace does not work with qemu linux-user. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] compiler.h: Fix barrier_data() on clang

On Nov 16 2020, Nick Desaulniers wrote: > A lot of VDSO's reset KBUILD_CFLAGS or use a new variable for their > compiler flags. As such, they're missing `-include` command line flag > that injects include/linux/compiler_types.h, It's not missing here. Andreas. -- Andreas Schwab, sch

Re: [PATCH] compiler.h: Fix barrier_data() on clang

On Nov 16 2020, Randy Dunlap wrote: > What kernel version are you building? 5.10-rc4 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] compiler.h: Fix barrier_data() on clang

hernet/emulex/benet] Error 2 make[3]: *** [scripts/Makefile.build:500: drivers/net/ethernet/emulex] Error 2 make[2]: *** [scripts/Makefile.build:500: drivers/net/ethernet] Error 2 make[1]: *** [scripts/Makefile.build:500: drivers/net] Error 2 make: *** [Makefile:1799: drivers] Error 2 Andreas.

Re: [PATCH] powerpc/32s: Use relocation offset when setting early hash table

write into Hash in early_hash_table(). >> >> Reported-by: Erhard Furtner >> Reported-by: Andreas Schwab >> Fixes: 69a1593abdbc ("powerpc/32s: Setup the early hash table at all time.") >> Signed-off-by: Christophe Leroy > > Tested-by: Serge Belyshev Works

Re: [PATCH 1/4] clk: sifive: Extract prci core to common base

On Nov 05 2020, Zong Li wrote: > I tried to add -M and -C option to find renames and copies, but it > doesn't detect anything here. -C40 finds a copy drivers/clk/sifive/{fu540-prci.c => sifive-prci.c}. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

On Nov 03 2020, Christophe Leroy wrote: > Would you mind checking that with that patch reverted, you are able to > boot a kernel built with CONFIG_KASAN ? That doesn't exist. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E78

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

On Nov 03 2020, Christophe Leroy wrote: > I tried again on QEMU with both pmac32_defconfig and your config, and it > boots. Isn't it quite naïve to think that qemu provides an adequate test environment for such lowlevel stuff? Andreas. -- Andreas Schwab, sch...@linux-m68k.org G

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

# # Automatically generated file; DO NOT EDIT. # Linux/powerpc 5.10.0-rc1 Kernel Configuration # CONFIG_CC_VERSION_TEXT="gcc-4.9 (SUSE Linux) 4.9.3" CONFIG_CC_IS_GCC=y CONFIG_GCC_VERSION=40903 CONFIG_LD_VERSION=23501 CONFIG_CLANG_VERSION=0 CONFIG_CC_CAN_LINK=y CONFIG_CC_CAN_LINK_STATIC=y

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

On Okt 30 2020, Michael Ellerman wrote: > Andreas Schwab writes: >> On Okt 01 2020, Christophe Leroy wrote: >> >>> At the time being, an early hash table is set up when >>> CONFIG_KASAN is selected. >>> >>> There is nothing wrong with sett

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

ce to early_hash[]. This > reference is removed by MMU_init_hw_patch() before init memory is > freed. This breaks booting on the iBook G4. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 1/3] powerpc/uaccess: Switch __put_user_size_allowed() to __put_user_asm_goto()

# # Automatically generated file; DO NOT EDIT. # Linux/powerpc 5.10.0-rc1 Kernel Configuration # CONFIG_CC_VERSION_TEXT="gcc-4.9 (SUSE Linux) 4.9.3" CONFIG_CC_IS_GCC=y CONFIG_GCC_VERSION=40903 CONFIG_LD_VERSION=23501 CONFIG_CLANG_VERSION=0 CONFIG_CC_CAN_LINK=y CONFIG_CC_CAN_LINK_STATIC=y

Re: [PATCH 1/3] powerpc/uaccess: Switch __put_user_size_allowed() to __put_user_asm_goto()

On Okt 28 2020, Michael Ellerman wrote: > What config and compiler are you using? gcc 4.9. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 1/3] powerpc/uaccess: Switch __put_user_size_allowed() to __put_user_asm_goto()

On Okt 28 2020, Andreas Schwab wrote: > On Sep 04 2020, Christophe Leroy wrote: > >> __put_user_asm_goto() provides more flexibility to GCC and avoids using >> a local variable to tell if the write succeeded or not. >> GCC can then avoid implementing a cmp in the fa

Re: [PATCH 1/3] powerpc/uaccess: Switch __put_user_size_allowed() to __put_user_asm_goto()

n failure in __libc_fork (THREAD_GETMEM (self, tid) != ppid). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2 1/1] i2c: ocores: fix polling mode workaround on FU540-C000 SoC

2c_probe(struct platform_device > *pdev) > > init_waitqueue_head(>wait); > > + /* > + * Set OCORES_FLAG_BROKEN_IRQ to enable workaround for > + * FU540-C000 SoC in polling mode. > + * Since the SoC does have interrupt it's dt has the interrup

Re: [PATCH V2 1/3] riscv: Fixup static_obj() fail

t5 : 0001 t6 : ffe00128e062 [ 4561.081832] status: 00020120 badaddr: cause: 0003 [ 4561.089821] ---[ end trace a7c93e7595e9c2cc ]--- [ 4561.095589] BUG: Bad rss-counter state mm:0000c54f4c29 type:MM_ANONPAGES val:1 Andreas. -- Andreas Schwa

Re: [PATCH V2 1/3] riscv: Fixup static_obj() fail

On Sep 14 2020, Aurelien Jarno wrote: > How should we proceed to get that fixed in time for 5.9? For the older > branches where it has been backported (so far 5.7 and 5.8), should we > just get that commit reverted instead? Why is this still broken? Andreas. -- Andreas Schwab, sch

Re: [PATCH V2 1/3] riscv: Fixup static_obj() fail

On Sep 14 2020, Aurelien Jarno wrote: > How should we proceed to get that fixed in time for 5.9? For the older > branches where it has been backported (so far 5.7 and 5.8), should we > just get that commit reverted instead? Can this please be resolved ASAP? Andreas. -- Andreas Sc

Re: [PATCH v2] powerpc: fix EDEADLOCK redefinition error in uapi/asm/errno.h

On Sep 17 2020, Arnd Bergmann wrote: > The errno man page says they are supposed to be synonyms, > and glibc defines it that way, while musl uses the numbers > from the kernel. glibc also uses whatever the kernel defines. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fi

Re: [PATCH] powerpc/32s: Fix module loading failure when VMALLOC_END is over 0xf0000000

; Use (ALIGN(VMALLOC_END, SZ_256M) - 1) which will have > value 0x and will be suitable for the comparison. > > Reported-by: Andreas Schwab > Signed-off-by: Christophe Leroy > Fixes: c49643319715 ("powerpc/32s: Only leave NX unset on segments used for > modules"

Re: [PATCH v2 3/6] powerpc/32s: Only leave NX unset on segments used for modules

<3d20c08b> 3d40c086 9421ffe0 8129106c ---[ end trace 85a98cc836109871 ]--- Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

> > plat->phy_interface = device_get_phy_mode(>dev); > - if (plat->phy_interface < 0) > + if ((int)plat->phy_interface < 0) > return ERR_PTR(plat->phy_interface); I don't think the conversion to long when passed to ERR_PTR will produce a

Re: get rid of the address_space override in setsockopt v2

new sockptr_t type. But in the times of > ftrace, bpftrace and co these kinds of debug printks are pretty anyway, I think there is a word missing after pretty. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And no

Re: [PATCH 2/2] riscv: fix build warning of mm/pageattr

On Jul 16 2020, Zong Li wrote: > Add hearder for missing prototype. Also, static keyword should be at s/hearder/header/ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: printk of non NULL terminated strings ?

On Jul 09 2020, Joakim Tjernlund wrote: > Is there a format (or other function) that lets me > print strings without an \0 terminator using an explicit length arg instead? Use the precision. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510

[PATCH] riscv: use 16KB kernel stack on 64-bit

With the current 8KB stack size there are frequent overflows in a 64-bit configuration. Signed-off-by: Andreas Schwab --- arch/riscv/include/asm/thread_info.h | 4 1 file changed, 4 insertions(+) diff --git a/arch/riscv/include/asm/thread_info.h b/arch/riscv/include/asm/thread_info.h

Re: [PATCH 0/3] Dynamic CPU frequency switching for the HiFive

On Jul 03 2020, Yash Shah wrote: > Yes, you are right. The userspace governor is the only one supported. That doesn't make sense to me. How is the userspace governor different from any other governor? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1

Re: [PATCH 0/3] Dynamic CPU frequency switching for the HiFive

_run_queues+0x48/0x6c [ 101.765254] [] hrtimer_interrupt+0xca/0x1d4 [ 101.770985] [] riscv_timer_interrupt+0x32/0x3a [ 101.776976] [] do_IRQ+0xa4/0xb8 [ 101.781663] [] ret_from_exception+0x0/0xc Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE

Re: [PATCH] riscv: fix build warning of missing prototypes

On Jun 01 2020, Zong Li wrote: > Add the missing header in file, it was losed in original implementation. s/losed/lost/ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 1/4] exec: Change uselib(2) IS_SREG() failure to EACCES

c/libc/libc_5.4.46.orig.tar.gz Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 1/4] exec: Change uselib(2) IS_SREG() failure to EACCES

On Mai 18 2020, Eric W. Biederman wrote: > If it was only libc4 and libc5 that used the uselib system call then it > can probably be removed after enough time. Only libc4 used it, libc5 was already ELF. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB4

Re: [PATCH] ia64: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args

On Mai 14 2020, Christian Brauner wrote: > pid = syscall(189 /* __NR_clone2 */, SIGCHLD, stack, STACK_SIZE, > NULL, NULL); Syscall 189 doesn't exist on ia64, they start with 1024 (and __NR_clone2 is 1213). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint

Re: [PATCH] ia64: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args

ret = -1; >> } else >> ret = in_child ? 0 : child_pid; >> } >> +#elif defined(__ia64__) >> +/* On ia64 the stack and stack size are passed as separate arguments. */ >> +return (pid_t)syscall(__NR_clone,

Re: [GIT PULL] RISC-V Fixes for 5.7-rc5

absolute minimum supported kernel version is increased (this happend the last time in 2017, when x86 and x86_64 moved the mininum from 2.6.32 to 3.2, after all other architectures did that step in 2016), which allows removing the fallback code that becomes obsolete. Andreas. -- Andreas Schwab,

Re: [PATCH v2] selftests/ftrace: Use printf for backslash included command

On Mai 11 2020, Masami Hiramatsu wrote: > -(! echo "$command" >> "$3" ) 2> /dev/null > +(! printf "%s" "$command" >> "$3" ) 2> /dev/null printf %s does not print a newline, you need printf '%s\n' for that. Andr

Re: [PATCH] selftests/ftrace: Use /bin/echo for backslash included command

On Mai 11 2020, Masami Hiramatsu wrote: > To fix this issue, we explicitly use /bin/echo -E (not interpret > backslash escapes) if the command string can include backslash. Please use printf instead. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E

Re: [GIT PULL] RISC-V Fixes for 5.7-rc5

pointless vdso notes to the kernel. I'm not aware of any discussion or bug report on this issue. Any pointer? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

On Mai 01 2020, Masami Hiramatsu wrote: > Since the built-in echo has different behavior in POSIX shell > (dash) and bash, we forcibly use /bin/echo -E (not interpret > backslash escapes) by default. How about using printf instead (at least where it matters)? Andreas. -- Andreas Sc

Re: [PATCH 1/2] riscv: defconfig: enable spi nor on Hifive Unleashed A00 board.

On Mai 06 2020, Anup Patel wrote: > We had build issues in past by selecting major driver subsystems > in Kconfig.socs > > I suggest to select SPI_SIFIVE from Kconfig.socs SPI_SIFIVE can be m, don't override that. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key finger

Re: [PATCH 7/7] sysvipc_find_ipc should increase position index

. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v2] riscv: force __cpu_up_ variables to put in data section

s > are brought-up by Linux kernel in an orderly fashion. This means we don't > this change for OpenSBI v0.7 (or higher version). +need Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] RISC-V: fix virtual address overlapped in FIXADDR_START and VMEMMAP_START

me in Linux kernel that they > can't > be overlapped. s/be existed/exist/ s/be overlapped/overlap/ Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v6 14/14] riscv: Make mmap allocation top-down by default

also happen with any of the openSUSE images? https://download.opensuse.org/ports/riscv/tumbleweed/images/ Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH -next] ASoC: fsl_mqs: fix old-style function declaration

On Okt 11 2019, YueHaibing wrote: > gcc warn about this: > > sound/soc/fsl/fsl_mqs.c:146:1: warning: > static is not at beginning of declaration [-Wold-style-declaration] It's not a function, though. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB

Re: [PATCH] kheaders: substituting --sort in archive creation

On Okt 09 2019, Dmitry Goldin wrote: > Andreas: Could you give this patch a try and see if this works for you? Thanks, works for me. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something co

Re: [PATCH v2] kheaders: making headers archive reproducible

On Okt 07 2019, Greg KH wrote: > On Mon, Oct 07, 2019 at 01:49:47PM +0200, Andreas Schwab wrote: >> GEN kernel/kheaders_data.tar.xz >> tar: unrecognized option '--sort=name' >> Try `tar --help' or `tar --usage' for more information. >> make[2]: *** [kernel/khe

Re: [PATCH v2] kheaders: making headers archive reproducible

Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by John Gilmore and Jay Fenlason. -- Andreas Schwa

Re: [PATCH] riscv: move flush_icache_range/user_range() after flush_icache_all()

https://lore.kernel.org/linux-riscv/mvm7e9spggv@suse.de/ Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

+ stdout-path = >}; > >cpus { > > should fix it. LMK if I've misunderstood something. If that's how it's supposed to work, ok. Other platforms add it in u-boot. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8

Re: [PATCH v3 bpf-next 01/14] samples: bpf: makefile: fix HDR_PROBE "echo"

$(shell echo '\#') Now this latter will resolve to "\#". If you want to write makefiles portable to both versions, assign the number sign to a variable: H := \# foo := $(shell echo '$H') This was claimed to be fixed in 3.81, but wasn't, for some reason. To detect this change s

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

t; in addition. > > Thanks. I've kind of lost track of the thread, but assuming that does the > "automatically pick an earlycon" stuff then that's probably what we should > be using in the distros. Except that it doesn't work. Andreas. -- Andreas Schwab, SUSE Labs, sch...@s

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

On Sep 16 2019, Paul Walmsley wrote: > On Tue, 10 Sep 2019, Andreas Schwab wrote: > >> On Sep 10 2019, Christoph Hellwig wrote: >> >> > On Tue, Sep 10, 2019 at 08:57:37AM +0200, Andreas Schwab wrote: >> >> On Sep 10 2019, Christoph Hellwig wrote:

Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.

On Sep 11 2019, Geert Uytterhoeven wrote: > Hi Andreas, > > On Thu, Aug 15, 2019 at 12:37 AM Andreas Schwab wrote: >> On Aug 14 2019, Palmer Dabbelt wrote: >> > On Wed, 14 Aug 2019 13:32:50 PDT (-0700), Paul Walmsley wrote: >> >> On Wed, 14 Aug 2

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

On Sep 10 2019, Christoph Hellwig wrote: > On Tue, Sep 10, 2019 at 10:18:15AM +0200, Andreas Schwab wrote: >> > How so? Wіth OF and a stdout path you just set earlycon on the >> > command line without any arguments and it will be found. >> >> Doesn't

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

On Sep 10 2019, Christoph Hellwig wrote: > On Tue, Sep 10, 2019 at 08:57:37AM +0200, Andreas Schwab wrote: >> On Sep 10 2019, Christoph Hellwig wrote: >> >> > The sifive serial driver implements earlycon support, >> >> It should probably be documented

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

On Sep 10 2019, Christoph Hellwig wrote: > The sifive serial driver implements earlycon support, It should probably be documented in admin-guide/kernel-parameters.txt. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0

Re: [PATCH v7 18/21] RISC-V: KVM: Add SBI v0.1 support

pt remote tlb flushes. For remote TLB flushes, > we are doing full TLB flush and this will be optimized in future. Note that this conflicts with https://patchwork.kernel.org/patch/11107221/ which removes from . You should probably include that header explicitly in arch/riscv/kvm/vcpu_sbi.c

Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000

rrqkb72fkseqj4p8p5ka-+r...@mail.gmail.com/ >> >> Sure. Will keep that in mind for future reference. >> >> > >> > > Signed-off-by: Yash Shah >> > >> > Acked-by: Nicolas Ferre >> >> Thanks. > > Am assuming you'll pick this up for the -

Re: [v2 PATCH] RISC-V: Optimize tlb flush path.

> > This is much simpler than what I had done in v2. I will address the if > condition around size as well. I still think that this function should be moved out of the header. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [v2 PATCH] RISC-V: Optimize tlb flush path.

t; cpumask_clear(); > + > + if (!cmask) { > + riscv_cpuid_to_hartid_mask(cpu_online_mask, ); > + goto issue_sfence; > + } Wouldn't it make sense to fall through to doing a local flush here? if (!cmask) cmask = cpu_online_mask; Andreas.

Re: [v2 PATCH] RISC-V: Optimize tlb flush path.

And since size is unsigned it cannot be == -1 at the same time. > local_flush_tlb_page(start); > else > local_flush_tlb_all(); > > ? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF

Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.

ster/.gitconfig.in#L23 > > causes git to do the right thing. Actually, the right setting is core.abbrev=auto (or leaving it unset). It lets git chose the appropriate length depending on the repository contents. For the linux repository it will chose 13 right now. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] RISC-V: Issue a local tlb flush if possible.

local_flush_tlb_all(); > + return; > + } > + > + if (!cpumask_empty()) { > + riscv_cpuid_to_hartid_mask(, ); > + sbi_remote_sfence_vma(hmask.bits, start, size); > + } > } I think it's becoming too big to be inline. Andreas. -- Andreas Schwab

Re: [RFC PATCH 00/16] KVM RISC-V Support

On Jul 30 2019, Anup Patel wrote: > On Tue, Jul 30, 2019 at 12:23 PM Andreas Schwab wrote: >> >> ERROR: "riscv_cs_get_mult_shift" [arch/riscv/kvm/kvm.ko] undefined! >> ERROR: "riscv_isa" [arch/riscv/kvm/kvm.ko] undefined! >> ERROR: "sm

Re: [RFC PATCH 00/16] KVM RISC-V Support

ERROR: "riscv_cs_get_mult_shift" [arch/riscv/kvm/kvm.ko] undefined! ERROR: "riscv_isa" [arch/riscv/kvm/kvm.ko] undefined! ERROR: "smp_send_reschedule" [arch/riscv/kvm/kvm.ko] undefined! ERROR: "riscv_timebase" [arch/riscv/kvm/kvm.ko] undefined! Andr

Re: [RFC PATCH 13/16] RISC-V: KVM: Add timer functionality

On Jul 29 2019, Atish Patra wrote: > Strange. We never saw this error. It is part of CONFIG_KERNEL_HEADER_TEST. Everyone developing a driver should enable it. > #include > > Can you try it at your end and confirm please ? Confirmed. Andreas. -- Andreas Schwab, SUSE Labs, sc

Re: [RFC PATCH 13/16] RISC-V: KVM: Add timer functionality

er-riscv.h:12:41: error: unknown type name ‘u32’ 12 | void riscv_cs_get_mult_shift(u32 *mult, u32 *shift); | ^~~ make[1]: *** [scripts/Makefile.build:301: include/clocksource/timer-riscv.h.s] Error 1 Andreas. -- Andreas Schwab, SUSE Labs, sch...@su

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

On Jul 27 2019, Anup Patel wrote: > So, using strncasecmp() in-place of strncmp() and using tolower() for > each character comparison is complex for you ? Apparently too complex for you. + if (tolower(isa[0] != 's')) Andreas. -- Andreas Schwab, SUSE Lab

[PATCH] net: phy: mscc: initialize stats array

The memory allocated for the stats array may contain arbitrary data. Signed-off-by: Andreas Schwab --- drivers/net/phy/mscc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index 28676af97b42..645d354ffb48

Re: [PATCH RESEND 0/2] RISC-V: Handle the siginfo_t offset problem

On Jul 03 2019, Alistair Francis wrote: > On Wed, Jul 3, 2019 at 12:08 AM Andreas Schwab wrote: >> >> On Jul 02 2019, Alistair Francis wrote: >> >> > In the RISC-V 32-bit glibc port [1] the siginfo_t struct in the kernel >> > doesn't line up w

Re: [PATCH RESEND 0/2] RISC-V: Handle the siginfo_t offset problem

On Jul 02 2019, Alistair Francis wrote: > In the RISC-V 32-bit glibc port [1] the siginfo_t struct in the kernel > doesn't line up with the struct in glibc. In glibc world the _sifields > union is 8 byte alligned (although I can't figure out why) Try ptype/o in gdb. Andreas. --

Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64

On Jun 28 2019, Christophe Leroy wrote: > Le 28/06/2019 à 18:36, Andreas Schwab a écrit : >> On Jun 28 2019, Christophe Leroy wrote: >> >>> diff --git a/arch/powerpc/include/uapi/asm/ptrace.h >>> b/arch/powerpc/include/uapi/asm/ptrace.h >>&g

Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64

(not used at present) */ > + union { > + unsigned long softe;/* Soft enabled/disabled */ > + unsigned long mq; /* 601 only (not used at present) */ > /* Used on APUS to hold IPL value. */ > -#endif > + }; A

  1   2   3   4   5   6   7   8   9   10   >