Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andreas Schwab
happy to expand these tests so they are always spaced on both sides >> style if that is the preference. > > That is most definitely the preference: spaces surround operators. ^binary Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED]

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andreas Schwab
: spaces surround operators. ^binary Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now

Re: [PATCH 25/33] kbuild: use POSIX BRE in headers install target

2007-07-21 Thread Andreas Schwab
Jan Engelhardt <[EMAIL PROTECTED]> writes: > Uhm, would not it be easier to just use 's/\b__user\b//g' ? \b is not POSIX. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53

Re: [PATCH 25/33] kbuild: use POSIX BRE in headers install target

2007-07-21 Thread Andreas Schwab
Oleg Verych <[EMAIL PROTECTED]> writes: >> +-e >> "s/[[:space:]]__user[[:space:]]\{1,\} > > substitute one or more ' __user ' Substitute ' __user' followed by one or more ' '. \{\} applies only to the last RE atom. Andreas. -- Andreas Schwab, SuSE

Re: [PATCH 25/33] kbuild: use POSIX BRE in headers install target

2007-07-21 Thread Andreas Schwab
Oleg Verych [EMAIL PROTECTED] writes: +-e s/[[:space:]]__user[[:space:]]\{1,\} substitute one or more ' __user ' Substitute ' __user' followed by one or more ' '. \{\} applies only to the last RE atom. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux

Re: [PATCH 25/33] kbuild: use POSIX BRE in headers install target

2007-07-21 Thread Andreas Schwab
Jan Engelhardt [EMAIL PROTECTED] writes: Uhm, would not it be easier to just use 's/\b__user\b//g' ? \b is not POSIX. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756

Re: build fix for x86_64...

2007-07-20 Thread Andreas Schwab
"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > struct foo { > u32 bar; > compat_u64 baz; > u32 quux; > }; compat_u64 is only for use in CONFIG_COMPAT code. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH,

Re: build fix for x86_64...

2007-07-20 Thread Andreas Schwab
But without CONFIG_COMPAT there is no 32-bit ABI, thus no need for compat_u64 in the first place. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4E

Re: build fix for x86_64...

2007-07-20 Thread Andreas Schwab
there is no 32-bit ABI, thus no need for compat_u64 in the first place. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely

Re: build fix for x86_64...

2007-07-20 Thread Andreas Schwab
H. Peter Anvin [EMAIL PROTECTED] writes: struct foo { u32 bar; compat_u64 baz; u32 quux; }; compat_u64 is only for use in CONFIG_COMPAT code. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP

Re: sysfs root link count broken in 2.6.22-git5

2007-07-18 Thread Andreas Schwab
roc/mounts for something, I can't remember >> what it is right now though, sorry. > > Maybe getmntent(3)? Sure I could use this, but how expensive compared > to a single stat(2). How about comparing the device numbers of /sys and its parent? If they are different then /sys is a mount

Re: sysfs root link count broken in 2.6.22-git5

2007-07-18 Thread Andreas Schwab
remember what it is right now though, sorry. Maybe getmntent(3)? Sure I could use this, but how expensive compared to a single stat(2). How about comparing the device numbers of /sys and its parent? If they are different then /sys is a mount point. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL

[PATCH] Pass nr_wake2 to futex_wake_op

2007-07-17 Thread Andreas Schwab
The fourth argument of sys_futex is ignored when op == FUTEX_WAKE_OP, but futex_wake_op expects it as its nr_wake2 parameter. The only user of this operation in glibc is always passing 1, so this bug had no consequences so far. Signed-off-by: Andreas Schwab <[EMAIL PROTECTED]> ---

[PATCH] Pass nr_wake2 to futex_wake_op

2007-07-17 Thread Andreas Schwab
The fourth argument of sys_futex is ignored when op == FUTEX_WAKE_OP, but futex_wake_op expects it as its nr_wake2 parameter. The only user of this operation in glibc is always passing 1, so this bug had no consequences so far. Signed-off-by: Andreas Schwab [EMAIL PROTECTED] --- kernel/futex.c

Re: [patch] use __attribute__ in asm-powerpc

2007-07-16 Thread Andreas Schwab
Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > If the code is not exported to userspace (and thus not subject to different > compilers), I think the preferred form is plain `attribute'. That does not exist without underscores. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PRO

Re: *at syscalls for xattrs?

2007-07-16 Thread Andreas Schwab
Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > This should work: > >fchdir(fd1); >open("file1", O_RDWR | O_CREAT); >fchdir(fd2); >open("file2", O_RDWR | O_CREAT); This is not thread-safe. Andreas. -- Andreas Schwab, SuSE Labs

Re: *at syscalls for xattrs?

2007-07-16 Thread Andreas Schwab
Jeremy Fitzhardinge [EMAIL PROTECTED] writes: This should work: fchdir(fd1); open(file1, O_RDWR | O_CREAT); fchdir(fd2); open(file2, O_RDWR | O_CREAT); This is not thread-safe. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5

Re: [patch] use __attribute__ in asm-powerpc

2007-07-16 Thread Andreas Schwab
Geert Uytterhoeven [EMAIL PROTECTED] writes: If the code is not exported to userspace (and thus not subject to different compilers), I think the preferred form is plain `attribute'. That does not exist without underscores. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux

Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO

2007-07-11 Thread Andreas Schwab
> AFLAGS is actually passed to $(CC), not $(AS), and -gdwarf works there > (it's an unambiguous prefix of -gdwarf-2). Oh yes, you're right, sorry for the noise. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerp

Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO

2007-07-11 Thread Andreas Schwab
+= -g > +AFLAGS += $(call as-option, -gdwarf) The option is officially called -gdwarf-2, and -gdwarf2 is an alias for backward compatibility. But -gdwarf is ambigous and will error out. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, M

Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO

2007-07-11 Thread Andreas Schwab
+= $(call as-option, -gdwarf) The option is officially called -gdwarf-2, and -gdwarf2 is an alias for backward compatibility. But -gdwarf is ambigous and will error out. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany

Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO

2007-07-11 Thread Andreas Schwab
works there (it's an unambiguous prefix of -gdwarf-2). Oh yes, you're right, sorry for the noise. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5

[PATCH] Pass nr_wake2 to futex_wake_op

2007-07-07 Thread Andreas Schwab
The fourth argument of sys_futex is ignored when op == FUTEX_WAKE_OP, but futex_wake_op expects it as its nr_wake2 parameter. The only user of this operation in glibc is always passing 1, so this bug had no consequences so far. Signed-off-by: Andreas Schwab <[EMAIL PROTECTED]> ---

[PATCH] Pass nr_wake2 to futex_wake_op

2007-07-07 Thread Andreas Schwab
The fourth argument of sys_futex is ignored when op == FUTEX_WAKE_OP, but futex_wake_op expects it as its nr_wake2 parameter. The only user of this operation in glibc is always passing 1, so this bug had no consequences so far. Signed-off-by: Andreas Schwab [EMAIL PROTECTED] --- kernel/futex.c

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Andreas Schwab
Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > Is there anything we can do about this? Define it as IGNORE_IOCTL in fs/compat_ioctl.c? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint =

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Andreas Schwab
Geert Uytterhoeven [EMAIL PROTECTED] writes: Is there anything we can do about this? Define it as IGNORE_IOCTL in fs/compat_ioctl.c? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7

Re: [i386] Questions regarding provisional page tables initialization

2007-07-02 Thread Andreas Schwab
flag bits. Since a page address is always page aligned, the low bits are reused for flags. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "An

Re: [i386] Questions regarding provisional page tables initialization

2007-07-02 Thread Andreas Schwab
is always page aligned, the low bits are reused for flags. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different

Re: [i386] Questions regarding provisional page tables initialization

2007-07-01 Thread Andreas Schwab
y the pde_offset is PAGE_OFFSET >> 20 instead of PAGE_OFFSET >> 22 ? > * 22 to right shift the whole page_shift (12) and pgdir_shift (10) bits. 4 is the element size. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnber

Re: [i386] Questions regarding provisional page tables initialization

2007-07-01 Thread Andreas Schwab
of PAGE_OFFSET 22 ? * 22 to right shift the whole page_shift (12) and pgdir_shift (10) bits. 4 is the element size. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5

Re: how to determine if the noexec stack is defined by an application

2007-06-29 Thread Andreas Schwab
Arjan van de Ven <[EMAIL PROTECTED]> writes: > (all others default to executable stack) Except ia64. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5

Re: how to determine if the noexec stack is defined by an application

2007-06-29 Thread Andreas Schwab
ys "RW" like here, it'll have non-executable stack. If it says > "RWX" or if this line is absent entirely, the stack will be executable. The last part is not true. Some architectures (especially newer ones) default to non-exec stack. The absense of a GNU_STACK header represen

Re: how to determine if the noexec stack is defined by an application

2007-06-29 Thread Andreas Schwab
. If it says RWX or if this line is absent entirely, the stack will be executable. The last part is not true. Some architectures (especially newer ones) default to non-exec stack. The absense of a GNU_STACK header represents the default. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED

Re: how to determine if the noexec stack is defined by an application

2007-06-29 Thread Andreas Schwab
Arjan van de Ven [EMAIL PROTECTED] writes: (all others default to executable stack) Except ia64. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276

Re: [Patch 04/18] include/linux/logfs.h

2007-06-06 Thread Andreas Schwab
instead of 'packed', then there's no need to emit code to > handle unaligned loads. You can add aligned(N) to increase the alignment again. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7

Re: [Patch 04/18] include/linux/logfs.h

2007-06-06 Thread Andreas Schwab
', then there's no need to emit code to handle unaligned loads. You can add aligned(N) to increase the alignment again. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5

Re: Problems (a bug?) with UINT_MAX from kernel.h

2007-06-05 Thread Andreas Schwab
range. It does not know anything about types. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different.&quo

Re: Problems (a bug?) with UINT_MAX from kernel.h

2007-06-05 Thread Andreas Schwab
anything about types. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Andreas Schwab
wn scope. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Andreas Schwab
. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] add a trivial patch style checker

2007-05-27 Thread Andreas Schwab
Andy Whitcroft <[EMAIL PROTECTED]> writes: > @@ -223,7 +236,7 @@ pref("mailnews.display.disable_format_flowed_support", > true); > > > > -7) E-mail size. > +8) E-mail size. > > When sending patches to Linus, always follow step #6. That's step

Re: [PATCH] add a trivial patch style checker

2007-05-27 Thread Andreas Schwab
Andy Whitcroft [EMAIL PROTECTED] writes: @@ -223,7 +236,7 @@ pref(mailnews.display.disable_format_flowed_support, true); -7) E-mail size. +8) E-mail size. When sending patches to Linus, always follow step #6. That's step #7 now. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL

Re: [PATCH] m68k: Enable arbitary speed tty support

2007-05-23 Thread Andreas Schwab
007-04-30 > 10:48:14.0 +0100 > +++ linux-2.6.22-rc1-mm1/include/asm-arm/termbits.h 2007-05-23 > 20:23:25.0 +0100 > @@ -15,6 +15,17 @@ > cc_t c_cc[NCCS];/* control characters */ > }; > > +struct termios_2 { s/_// Andreas. -- A

Re: [PATCH] m68k: Enable arbitary speed tty support

2007-05-23 Thread Andreas Schwab
:14.0 +0100 +++ linux-2.6.22-rc1-mm1/include/asm-arm/termbits.h 2007-05-23 20:23:25.0 +0100 @@ -15,6 +15,17 @@ cc_t c_cc[NCCS];/* control characters */ }; +struct termios_2 { s/_// Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux

Re: bug in 2.6.22-rc2: loop mount limited to one single iso image

2007-05-20 Thread Andreas Schwab
t; loop* nodes in /lib/udev/devices/, which will be >> copied to /dev/ early on every bootup. >> > > Won't these be removed after "losetup -d"? No, only when you unload the loop module (and then only those that were ever used). Andreas. -- Andreas Schwab, SuSE Labs, [EMA

Re: it seems at XFS bug?!

2007-05-20 Thread Andreas Schwab
Jan Engelhardt <[EMAIL PROTECTED]> writes: > On May 20 2007 11:14, Andreas Schwab wrote: >>Jan Engelhardt <[EMAIL PROTECTED]> writes: >>> On May 19 2007 22:24, Willy Tarreau wrote: >>>>On Sat, May 19, 2007 at 09:50:43PM +0200, oliver pinter wrote: >>

Re: it seems at XFS bug?!

2007-05-20 Thread Andreas Schwab
60, aka the NBSP. But __only__ in ISO-8859. It is an invalid > UTF-8 sequence (which is why you may not even "see" the nbsp :-) Actually, in a utf-8 environment you see it much better. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürn

Re: it seems at XFS bug?!

2007-05-20 Thread Andreas Schwab
sequence (which is why you may not even see the nbsp :-) Actually, in a utf-8 environment you see it much better. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5

Re: it seems at XFS bug?!

2007-05-20 Thread Andreas Schwab
Jan Engelhardt [EMAIL PROTECTED] writes: On May 20 2007 11:14, Andreas Schwab wrote: Jan Engelhardt [EMAIL PROTECTED] writes: On May 19 2007 22:24, Willy Tarreau wrote: On Sat, May 19, 2007 at 09:50:43PM +0200, oliver pinter wrote: yeah, but how produziert? I *think* it is the unbreakable

Re: bug in 2.6.22-rc2: loop mount limited to one single iso image

2007-05-20 Thread Andreas Schwab
to /dev/ early on every bootup. Won't these be removed after losetup -d? No, only when you unload the loop module (and then only those that were ever used). Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key

Re: [PATCH 06/14] kbuild: introduce __init_refok/__initdata_refok to supress section mismatch warnings

2007-05-18 Thread Andreas Schwab
Sam Ravnborg <[EMAIL PROTECTED]> writes: > + * The follwoing markers are used for the cases where the reference to s/follwoing/following/ Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint =

Re: [PATCH 06/14] kbuild: introduce __init_refok/__initdata_refok to supress section mismatch warnings

2007-05-18 Thread Andreas Schwab
Sam Ravnborg [EMAIL PROTECTED] writes: + * The follwoing markers are used for the cases where the reference to s/follwoing/following/ Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7

Re: Long file names in VFAT broken with iocharset=utf8

2007-05-07 Thread Andreas Schwab
central repository for this configuration item? A hard- > coded value of 256 somewhere inside the kernel smells like a bug. There is PATH_MAX and there is NAME_MAX, and only the latter (which is 260 for vfat) matters here. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, M

Re: Long file names in VFAT broken with iocharset=utf8

2007-05-07 Thread Andreas Schwab
item? A hard- coded value of 256 somewhere inside the kernel smells like a bug. There is PATH_MAX and there is NAME_MAX, and only the latter (which is 260 for vfat) matters here. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg

[PATCH] Fix error handling in HDIO_GETGEO compat wrapper

2007-04-30 Thread Andreas Schwab
Don't clobber error from sys_ioctl in HDIO_GETGEO compat wrapper. Signed-off-by: Andreas Schwab <[EMAIL PROTECTED]> --- fs/compat_ioctl.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- linux-2.6.21.orig/fs/compat_ioctl.c 2007-04-26 13:40:52.0 +0200 +++ linux-2.6

[PATCH] Fix error handling in HDIO_GETGEO compat wrapper

2007-04-30 Thread Andreas Schwab
Don't clobber error from sys_ioctl in HDIO_GETGEO compat wrapper. Signed-off-by: Andreas Schwab [EMAIL PROTECTED] --- fs/compat_ioctl.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- linux-2.6.21.orig/fs/compat_ioctl.c 2007-04-26 13:40:52.0 +0200 +++ linux-2.6.21/fs

Re: [RFC][PATCH] fix abs() macro to work with types wider than int

2007-04-25 Thread Andreas Schwab
"linux-os (Dick Johnson)" <[EMAIL PROTECTED]> writes: > The original query was for a macro. A macro that does not evaluate its argument more than once. If you want it to match the behaviour as defined by the C standard then it is not allowed to do so. Andreas. -- Andrea

Re: [RFC][PATCH] fix abs() macro to work with types wider than int

2007-04-25 Thread Andreas Schwab
"linux-os (Dick Johnson)" <[EMAIL PROTECTED]> writes: > I think this works, regardless of the length of the integers: > > #define abs(x) (((x)<0)?-(x):(x)) But it evaluates its argument more than once. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECT

Re: [RFC][PATCH] fix abs() macro to work with types wider than int

2007-04-25 Thread Andreas Schwab
linux-os (Dick Johnson) [EMAIL PROTECTED] writes: I think this works, regardless of the length of the integers: #define abs(x) (((x)0)?-(x):(x)) But it evaluates its argument more than once. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5

Re: [RFC][PATCH] fix abs() macro to work with types wider than int

2007-04-25 Thread Andreas Schwab
linux-os (Dick Johnson) [EMAIL PROTECTED] writes: The original query was for a macro. A macro that does not evaluate its argument more than once. If you want it to match the behaviour as defined by the C standard then it is not allowed to do so. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL

Re: Wrong free clusters count on FAT32

2007-04-22 Thread Andreas Schwab
isk. > + > utf8= -- UTF-8 is the filesystem safe version of Unicode that >is used by the console. It can be enabled for the >filesystem with this option. If 'uni_xlate' gets set, Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products Gm

Re: Wrong free clusters count on FAT32

2007-04-22 Thread Andreas Schwab
for the filesystem with this option. If 'uni_xlate' gets set, Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something

Re: Stupid GIT question...

2007-04-18 Thread Andreas Schwab
[EMAIL PROTECTED] writes: > What's the command to get a diff of "what I would merge if I said 'git pull'?" $ git fetch $ git diff master origin Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP ke

Re: Stupid GIT question...

2007-04-18 Thread Andreas Schwab
[EMAIL PROTECTED] writes: What's the command to get a diff of what I would merge if I said 'git pull'? $ git fetch $ git diff master origin Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA

Re: [PATCH] general: convert "kernel" subdirectory to UTF-8

2007-04-17 Thread Andreas Schwab
"John Anthony Kazos Jr." <[EMAIL PROTECTED]> writes: > I can't get my mail client to send in ISO-8859-1 instead of UTF-8, so the Actually your mail is encoded in iso-8859-15. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraß

Re: [PATCH] general: convert kernel subdirectory to UTF-8

2007-04-17 Thread Andreas Schwab
John Anthony Kazos Jr. [EMAIL PROTECTED] writes: I can't get my mail client to send in ISO-8859-1 instead of UTF-8, so the Actually your mail is encoded in iso-8859-15. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg

Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings

2007-04-15 Thread Andreas Schwab
Jan Engelhardt <[EMAIL PROTECTED]> writes: > LOW_PAGES = (0x1ULL - __PAGE_OFFSET) >> PAGE_SHIT_asm The assembler does not now anything about ULL. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg,

Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings

2007-04-15 Thread Andreas Schwab
Jan Engelhardt [EMAIL PROTECTED] writes: LOW_PAGES = (0x1ULL - __PAGE_OFFSET) PAGE_SHIT_asm The assembler does not now anything about ULL. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint

Re: If not readdir() then what?

2007-04-09 Thread Andreas Schwab
at this is a BUG in GNU coreutils that should be fixed... > > I heard it and accepted that claim without checking it. There is not a single call to telldir/seekdir in the coreutils source. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnb

Re: If not readdir() then what?

2007-04-09 Thread Andreas Schwab
... I heard it and accepted that claim without checking it. There is not a single call to telldir/seekdir in the coreutils source. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53

Re: updated list of "dead" Makefile CONFIG_ variables

2007-03-31 Thread Andreas Schwab
ple/Makefile:# loaded at. The optimal setting for > entrypoint-$(CONFIG_MACHINE) is the link > ./arch/ppc/boot/simple/Makefile:# misc-$(CONFIG_MACHINE) variable. That looks like a meta variable. It's only a comment anyway. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products Gm

Re: updated list of dead Makefile CONFIG_ variables

2007-03-31 Thread Andreas Schwab
-$(CONFIG_MACHINE) is the link ./arch/ppc/boot/simple/Makefile:# misc-$(CONFIG_MACHINE) variable. That looks like a meta variable. It's only a comment anyway. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint

Re: sata-vsc broken on SGI Prism

2007-03-26 Thread Andreas Schwab
Andrew Morton <[EMAIL PROTECTED]> writes: > On Sat, 24 Mar 2007 10:17:24 +0100 Andreas Schwab <[EMAIL PROTECTED]> wrote: > >> I'm getting this panic when loading sata-vsc on a SGI Prism: > > With what kernel? It's still the same with 2.6.21-rc5. >> Bisection

Re: sata-vsc broken on SGI Prism

2007-03-26 Thread Andreas Schwab
Andrew Morton [EMAIL PROTECTED] writes: On Sat, 24 Mar 2007 10:17:24 +0100 Andreas Schwab [EMAIL PROTECTED] wrote: I'm getting this panic when loading sata-vsc on a SGI Prism: With what kernel? It's still the same with 2.6.21-rc5. Bisection has identified this patch (together

Re: sata-vsc broken on SGI Prism

2007-03-25 Thread Andreas Schwab
Andrew Morton <[EMAIL PROTECTED]> writes: > On Sat, 24 Mar 2007 10:17:24 +0100 Andreas Schwab <[EMAIL PROTECTED]> wrote: > >> I'm getting this panic when loading sata-vsc on a SGI Prism: > > With what kernel? Linus' latest at this point in time. Andreas. -- And

Re: sata-vsc broken on SGI Prism

2007-03-25 Thread Andreas Schwab
Andrew Morton [EMAIL PROTECTED] writes: On Sat, 24 Mar 2007 10:17:24 +0100 Andreas Schwab [EMAIL PROTECTED] wrote: I'm getting this panic when loading sata-vsc on a SGI Prism: With what kernel? Linus' latest at this point in time. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED

sata-vsc broken on SGI Prism

2007-03-24 Thread Andreas Schwab
7cbaa86b937b0b1fab95c159989f6a3c00bbcf78 Author: Dan Wolstenholme <[EMAIL PROTECTED]> Date: Tue Jan 9 05:59:21 2007 -0500 [libata] sata_vsc: support PCI MSI Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, M

sata-vsc broken on SGI Prism

2007-03-24 Thread Andreas Schwab
7cbaa86b937b0b1fab95c159989f6a3c00bbcf78 Author: Dan Wolstenholme [EMAIL PROTECTED] Date: Tue Jan 9 05:59:21 2007 -0500 [libata] sata_vsc: support PCI MSI Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5

Re: Why is /dev on a different filesystem ? [Kernel 2.6.20.3]

2007-03-21 Thread Andreas Schwab
ts, apparently when /dev was mounted /etc/mtab wasn't updated appropriately. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for some

Re: Why is /dev on a different filesystem ? [Kernel 2.6.20.3]

2007-03-21 Thread Andreas Schwab
. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe linux

Re: x86_64 system lockup from userspace using setitimer()

2007-03-13 Thread Andreas Schwab
> seems affected. I can also reproduce it on ia64 with 2.6.20. 2.6.16.42 is ok. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And

Re: /sys/devices/system/cpu/cpuX/online are missing

2007-03-13 Thread Andreas Schwab
Heiko Carstens <[EMAIL PROTECTED]> writes: > On Tue, Mar 13, 2007 at 01:39:25AM +0100, Andreas Schwab wrote: >> Giuliano Pochini <[EMAIL PROTECTED]> writes: >> >> > I had a look at arch/powerpc/kernel/smp.c but I'm not familiar at all with >> > those

Re: /sys/devices/system/cpu/cpuX/online are missing

2007-03-13 Thread Andreas Schwab
Heiko Carstens [EMAIL PROTECTED] writes: On Tue, Mar 13, 2007 at 01:39:25AM +0100, Andreas Schwab wrote: Giuliano Pochini [EMAIL PROTECTED] writes: I had a look at arch/powerpc/kernel/smp.c but I'm not familiar at all with those parts of the kernel. See arch/powerpc/kernel

Re: x86_64 system lockup from userspace using setitimer()

2007-03-13 Thread Andreas Schwab
reproduce it on ia64 with 2.6.20. 2.6.16.42 is ok. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different

Re: /sys/devices/system/cpu/cpuX/online are missing

2007-03-12 Thread Andreas Schwab
_CPU enabled. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from th

Re: /sys/devices/system/cpu/cpuX/online are missing

2007-03-12 Thread Andreas Schwab
. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] Use more gcc extensions in the Linux headers

2007-03-10 Thread Andreas Schwab
ay. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the l

Re: [PATCH] Use more gcc extensions in the Linux headers

2007-03-10 Thread Andreas Schwab
. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] tty: Turn on arbitary baud rate ioctls for i386 platform

2007-03-08 Thread Andreas Schwab
Arjan van de Ven <[EMAIL PROTECTED]> writes: > should this then really be in include/asm/* ? If everyone needs the same > change I'd think it should go into include/linux/* somewhere. How about asm-generic/ioctls.h? is one of the few ABI headers for glibc. Andreas. -- Andreas

Re: [PATCH] tty: Turn on arbitary baud rate ioctls for i386 platform

2007-03-08 Thread Andreas Schwab
Arjan van de Ven [EMAIL PROTECTED] writes: should this then really be in include/asm/* ? If everyone needs the same change I'd think it should go into include/linux/* somewhere. How about asm-generic/ioctls.h? asm/ioctls.h is one of the few ABI headers for glibc. Andreas. -- Andreas Schwab

Re: return negative number for unsigned long function in kernel

2007-03-06 Thread Andreas Schwab
s directly passed to user space (it's the guts of the mmap syscall). The glibc wrapper transforms it appropriately so that errno is set and -1 is returned if there is an error. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany

Re: return negative number for unsigned long function in kernel

2007-03-06 Thread Andreas Schwab
). The glibc wrapper transforms it appropriately so that errno is set and -1 is returned if there is an error. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B

Re: Nvidiafb broken in 2.6.21-rc1

2007-02-26 Thread Andreas Schwab
Richard Purdie <[EMAIL PROTECTED]> writes: > Thanks, I think I know what the problem is. Could you try this change > please: Thanks, that fixes the problem. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Ger

Re: Nvidiafb broken in 2.6.21-rc1

2007-02-26 Thread Andreas Schwab
Richard Purdie [EMAIL PROTECTED] writes: Thanks, I think I know what the problem is. Could you try this change please: Thanks, that fixes the problem. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key

Nvidiafb broken in 2.6.21-rc1

2007-02-24 Thread Andreas Schwab
ichard Purdie <[EMAIL PROTECTED]> Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsu

Nvidiafb broken in 2.6.21-rc1

2007-02-24 Thread Andreas Schwab
[EMAIL PROTECTED] Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send

Re: Linux 2.6.21-rc1

2007-02-21 Thread Andreas Schwab
I'm getting an undefined symbol with CONFIG_AGP=m: WARNING: "compat_agp_ioctl" [drivers/char/agp/agpgart.ko] undefined! Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53

Re: Linux 2.6.21-rc1

2007-02-21 Thread Andreas Schwab
I'm getting an undefined symbol with CONFIG_AGP=m: WARNING: compat_agp_ioctl [drivers/char/agp/agpgart.ko] undefined! Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3

Re: exporting LANG=C (Re: [PATCH] override build timestamp)

2007-02-17 Thread Andreas Schwab
Olaf Hering <[EMAIL PROTECTED]> writes: > But we better build the whole kernel with LC_ALL=C LANG=C. If you have LC_ALL=C you don't need LANG=C. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fi

Re: exporting LANG=C (Re: [PATCH] override build timestamp)

2007-02-17 Thread Andreas Schwab
Olaf Hering [EMAIL PROTECTED] writes: But we better build the whole kernel with LC_ALL=C LANG=C. If you have LC_ALL=C you don't need LANG=C. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA

<    3   4   5   6   7   8   9   10   >