[PATCH] HID: i2c-hid: support sending HID output reports using the output register

. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/i2c-hid/i2c-hid.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index 2b1799a..a71c9a7 100644 --- a/drivers/hid/i2c-hid/i2c

[PATCH v2] HID: i2c-hid: support sending HID output reports using the output register

. Signed-off-by: Andrew Duggan adug...@synaptics.com --- This is the second version of the patch which includes Benjamin's suggestions. The comment now follows the multi line guidelines and in the i2c_hid_set_report function, hidcmd is now a pointer. drivers/hid/i2c-hid/i2c-hid.c | 20

[PATCH] HID: rmi: fix masks for x and w_x data

The F11 data in the HID report contains four bits of data for w_x and the least significant bits of x. Currently only the first three bits are being used which is resulting in small jumps in the position data on the x axis and in the w_x data. Signed-off-by: Andrew Duggan adug...@synaptics.com

[PATCH] HID: rmi: check for the existence of some optional queries before reading query 12

The rmi4 spec defines some optional query registers in F11 which appear before query 12. This patch checks for the existence of some of the lesser used queries to compute the location of query12 and all subsequent query registers. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers

[PATCH v2] HID: rmi: check for the existence of some optional queries before reading query 12

The rmi4 spec defines some optional query registers in F11 which appear before query 12. This patch checks for the existence of some of the lesser used queries to compute the location of query12 and all subsequent query registers. Signed-off-by: Andrew Duggan adug...@synaptics.com Reviewed

[PATCH] HID: rmi: add additional checks for the existence of optional queries in order to compute the address of Query 12.

the presence of these optional queries. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 578bbe6..3221a95 100644

[PATCH] HID: rmi: change logging level of log messages related to unexpected reports

-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 578bbe6..25f571a 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -377,7 +377,7 @@ static int

[PATCH] HID: i2c-hid: call the hid driver's suspend and resume callbacks

driver. Signed-off-by: Andrew Duggan adug...@synaptics.com Signed-off-by: Vincent Huang vincent.hu...@tw.synaptics.com --- Hi Benjamin, This is the patch which Vincent and I came up with to fix the behavior which we were seeing with touchpads not being operational after resuming. We only use

[PATCH] HID: rmi: check that report ids exist in the report_id_hash before accessing their size

of dereferencing a null pointer. related bug: https://bugzilla.kernel.org/show_bug.cgi?id=80091 Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-rmi.c b

[PATCH v2] HID: rmi: check that report ids exist in the report_id_hash before accessing their size

of dereferencing a null pointer. related bug: https://bugzilla.kernel.org/show_bug.cgi?id=80091 Signed-off-by: Andrew Duggan adug...@synaptics.com --- Added hid_err messages as suggested by Benjamin. This fixes the null pointer dereference from bug 80091 while the next patch addresses

[PATCH] HID: rmi: only bind the hid-rmi driver to the mouse interface of composite USB devices

the USB Vendor ID is Synaptic's, hid-core is currently trying to bind hid-rmi to all\of the HID devices. This patch ensures that hid-rmi only binds to the mouse interface. related bug: https://bugzilla.kernel.org/show_bug.cgi?id=80091 Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers

Re: [PATCH] Input: synaptics-rmi4 - fix compiler warnings in F11

. Andrew - I'll be OOO for a couple of days. Can you do that, and add a Tested-by: or rev the patch, as appropriate? Thanks, Chris It compiles cleanly and works on my test system. Tested-by: Andrew Duggan adug...@synaptics.com --- drivers/input/rmi4

[PATCH] HID: rmi: print an error if F11 is not found instead of stopping the device

. If the probe returns -EIO the hidraw device won't be created. So instead of failing the probe, just print an error message, but leave the device accessible from userspace. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 13 + 1 file changed, 9 insertions

Re: [PATCH] HID: rmi: check sanity of the incoming report

On 09/05/2014 06:57 AM, Benjamin Tissoires wrote: In the Dell XPS 13 9333, it appears that sometimes the bus get confused and corrupts the incoming data. It fills the input report with the sentinel value ff. Synaptics told us that such behavior does not comes from the touchpad itself, so we

Re: [PATCH] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

Hi Benjamin, Thanks for reviewing. On 10/03/2014 02:25 PM, Benjamin Tissoires wrote: Hi Andrew, On Oct 02 2014 or thereabouts, Andrew Duggan wrote: On composite HID devices there may be multiple HID devices on separate interfaces, but hid-rmi should only bind to the touchpad. Commit

[PATCH] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

has the mouse interface protocol set. This patch takes a different approach and scans the report descriptor looking for the Vendor Specific Top Level Collection and the associated usages and report IDs needed by the hid-rmi driver to interface with the device. Signed-off-by: Andrew Duggan adug

Re: [PATCH] Input: synaptics - add support for ForcePads

On 09/09/2014 10:06 AM, Dmitry Torokhov wrote: On Tue, Sep 09, 2014 at 09:44:17AM +0200, Hans de Goede wrote: Hi, On 09/08/2014 06:55 PM, Dmitry Torokhov wrote: ForcePads are found on HP EliteBook 1040 laptops. They lack any kind of physical buttons, instead they generate primary button click

[PATCH v2] HID: rmi: check sanity of the incoming report

=1123584 Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Signed-off-by: Andrew Duggan adug...@synaptics.com --- Here is a v2 based of Benjamin's patch with the feedback from the list. I added size checks to rmi_f11_input_event and rmi_f30_input_event. For F30 I print a message it any

[PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

protocol set. This patch takes a different approach and scans the report descriptor looking for the Generic Desktop Pointer usage and the Vendor Specific Top Level Collection needed by the hid-rmi driver to interface with the device. Signed-off-by: Andrew Duggan adug...@synaptics.com

[PATCH] HID: rmi: Add support for the touchpad in the Razer Blade 14 laptop

instead of through the F30 like it is on ClickPads. Signed-off-by: Andrew Duggan adug...@synaptics.com --- This patch depends on the HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver I submitted earlier today to correctly bind to the touchpad HID

Re: NULL pointer dereference in i2c-hid

On 12/11/2014 10:16 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 16:03:07 Mika Westerberg wrote: On Thu, Dec 11, 2014 at 10:58:01AM +0200, Mika Westerberg wrote: On Wed, Dec 10, 2014 at 06:04:51PM +0100, Gabriele Mazzotta wrote: my laptop uses a touchpad that needs hid-rmi along

Re: NULL pointer dereference in i2c-hid

On 12/11/2014 11:11 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 10:40:05 Andrew Duggan wrote: On 12/11/2014 10:16 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 16:03:07 Mika Westerberg wrote: On Thu, Dec 11, 2014 at 10:58:01AM +0200, Mika Westerberg wrote: On Wed

Re: NULL pointer dereference in i2c-hid

On 12/11/2014 11:40 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 11:21:43 Andrew Duggan wrote: On 12/11/2014 11:11 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 10:40:05 Andrew Duggan wrote: On 12/11/2014 10:16 AM, Gabriele Mazzotta wrote: On Thursday 11 December

Re: NULL pointer dereference in i2c-hid

On 12/11/2014 01:17 PM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 12:46:53 Andrew Duggan wrote: On 12/11/2014 11:40 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 11:21:43 Andrew Duggan wrote: On 12/11/2014 11:11 AM, Gabriele Mazzotta wrote: On Thursday 11 December

Re: NULL pointer dereference in i2c-hid

On 12/11/2014 01:57 PM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 13:34:02 Andrew Duggan wrote: On 12/11/2014 01:17 PM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 12:46:53 Andrew Duggan wrote: On 12/11/2014 11:40 AM, Gabriele Mazzotta wrote: On Thursday 11 December

[PATCH v3] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

protocol set. This patch takes a different approach and scans the report descriptor looking for the Generic Desktop Pointer usage and the Vendor Specific Top Level Collection needed by the hid-rmi driver to interface with the device. Signed-off-by: Andrew Duggan adug...@synaptics.com Reviewed

Re: NULL pointer dereference in i2c-hid

On 12/12/2014 12:12 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 16:26:00 Andrew Duggan wrote: On 12/11/2014 01:57 PM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 13:34:02 Andrew Duggan wrote: On 12/11/2014 01:17 PM, Gabriele Mazzotta wrote: On Thursday 11 December

[PATCH 2/3] HID: rmi: Support touchpads with external buttons

The external buttons on HID touchpads are connected as pass through devices and button events are not reported in the rmi registers. As a result on these devices we need to allow the HID generic desktop button events to be processed by hid-input. Signed-off-by: Andrew Duggan adug...@synaptics.com

[PATCH 3/3] HID: rmi: Add support for the touchpad in the Razer Blade 14 laptop

Have hid-rmi handle all of the Razer Blade HID devices that are part of the composite USB device. This will allow hid-rmi to operate the touchpad in rmi mode while passing events from the other devices to hid-input. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-core.c

[PATCH 1/3] HID: rmi: Support non rmi devices by passing events to hid-input

of the devices. Then hid-rmi's probe can look for the rmi specific HID report IDs and decide if it should handle the device as a rmi device or simply report that the events needs additional processing. Signed-off-by: Andrew Duggan adug...@synaptics.com --- This patch series is my second attempt at getting

[PATCH] HID: rmi: The address of query8 must be calculated based on which query registers are present

If a touchpad does not report relative data then query 6 will not be present and the address of query 8 will be one less. This patches calculates the location of query 8 instead of hardcoding the offset. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 24

[PATCH] HID: rmi: Check for additional ACM registers appended to F11 data report

report button state when this functionality is present. This patch accounts for the additional data in the report. Fixes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1398533 Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 61

Re: [PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

On 11/24/2014 03:37 PM, Andrew Duggan wrote: On composite HID devices there may be multiple HID devices on separate interfaces, but hid-rmi should only bind to the touchpad. The previous version simply checked that the interface protocol was set to mouse. Unfortuately, it is not always

Re: [PATCH] HID: rmi: Add support for the touchpad in the Razer Blade 14 laptop

On 11/24/2014 04:20 PM, Andrew Duggan wrote: The Razer Blade 14 has a Synaptic's TouchPad on one of the interfaces of a composite USB device. This patch allows the hid-rmi driver to bind to that interface. It also adds support for the external click buttons on the Razer's touchpad. External

Re: [PATCH] HID: rmi: Add support for the touchpad in the Razer Blade 14 laptop

Hi Benjamin, Thanks for reviewing my patch. Comments and questions below. On 12/10/2014 12:51 PM, Benjamin Tissoires wrote: On Mon, Dec 8, 2014 at 7:16 PM, Andrew Duggan adug...@synaptics.com wrote: On 11/24/2014 04:20 PM, Andrew Duggan wrote: The Razer Blade 14 has a Synaptic's TouchPad

Re: [PATCH 2/4] Input - synaptics: do not release extra buttons once they are pressed

On 02/04/2015 01:29 PM, Benjamin Tissoires wrote: On Feb 02 2015 or thereabouts, Benjamin Tissoires wrote: On Mon, Feb 2, 2015 at 4:46 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jan 28, 2015 at 03:10:05PM -0500, Benjamin Tissoires wrote: The current code releases the extra

Re: [PATCH 2/4] Input - synaptics: do not release extra buttons once they are pressed

On 02/04/2015 01:29 PM, Benjamin Tissoires wrote: On Feb 02 2015 or thereabouts, Benjamin Tissoires wrote: On Mon, Feb 2, 2015 at 4:46 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jan 28, 2015 at 03:10:05PM -0500, Benjamin Tissoires wrote: The current code releases the extra

Re: [RFC] Input - synaptics: re-route tracksticks buttons on the Lenovo 2015 series

On 02/05/2015 12:38 PM, Benjamin Tissoires wrote: Lenovos 2015 series has the physical tracktick buttons wired through the touchpad. The kernel should re-route them through the pass-through interface. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Hi Dmitry, Well, in one

Re: NULL pointer dereference in i2c-hid

On 01/09/2015 12:04 AM, Gabriele Mazzotta wrote: On Thursday 08 January 2015 15:58:54 Andrew Duggan wrote: On 12/24/2014 03:53 PM, Gabriele Mazzotta wrote: [...snip...] Also, if you can get the firmware id from your touchpad that would also be useful. $ sudo ./rmihidtool -f /dev/hidraw0

Re: NULL pointer dereference in i2c-hid

On 12/24/2014 03:53 PM, Gabriele Mazzotta wrote: [...snip...] Also, if you can get the firmware id from your touchpad that would also be useful. $ sudo ./rmihidtool -f /dev/hidraw0 firmware id: 1522295 Thanks, I will see if I can get any additional information on this. Andrew Hi, I think I

[PATCH v2 2/3] HID: rmi: Support touchpads with external buttons

the touchpad to determine that it has pass through buttons so the RMI_DEVICE_HAS_PHYS_BUTTONS should be set manually when adding the device to rmi_id[]. Signed-off-by: Andrew Duggan adug...@synaptics.com --- Here is the second version of the remaining patches in this patch series from last month. The most

[PATCH v2 3/3] HID: rmi: Add support for the touchpad in the Razer Blade 14 laptop

Have hid-rmi handle all of the Razer Blade HID devices that are part of the composite USB device. This will allow hid-rmi to operate the touchpad in rmi mode while passing events from the other devices to hid-input. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-core.c

[PATCH] HID: rmi: Use hid_report_len to compute the size of reports

Now that hid_report_len is in hid.h we can use this function instead of duplicating the code which computes it. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-rmi.c b/drivers

[PATCH] HID: rmi: Print the firmware id of the touchpad

output included in bug reports. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 99 +++ 1 file changed, 99 insertions(+) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 49d4fe4..28579d7 100644

Re: NULL pointer dereference in i2c-hid

On 02/22/2015 01:37 PM, Gabriele Mazzotta wrote: On Friday 09 January 2015 16:29:04 Andrew Duggan wrote: On 01/09/2015 12:04 AM, Gabriele Mazzotta wrote: On Thursday 08 January 2015 15:58:54 Andrew Duggan wrote: On 12/24/2014 03:53 PM, Gabriele Mazzotta wrote: [...snip...] Also, if you can

[PATCH 2/3] HID: rmi: disable dribble packets on Synaptics touchpads

the servicing of dribble interrupts on Linux unnecessary. This patch simply disables dribble interupts when configuring the touchpad. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/hid/hid-rmi.c b

[PATCH 1/3] HID: rmi: Add functions for writing to registers

Writing to registers is needed for setting configuration parameters. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index

[PATCH 3/3] HID: rmi: disable palm detect gesture when present

. Signed-off-by: Andrew Duggan adug...@synaptics.com --- Hi Gabriele, Can you test this patch on your system to confirm that it fixes your issue? I was able to test the other two patches so I can confirm that the write fuction works. But, I don't have a touchpad with the palm detect gesture enabled

[PATCH] HID: i2c-hid: Do not set the ACPI companion field in the HID device

the device as wake capable. Which results in power/wakeup files in sysfs for the HID device which do not do anything. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/i2c-hid/i2c-hid.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c

[PATCH] HID: rmi: Disable populating F30 when the touchpad has physical buttons

. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 368ffdf..721f7f9 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -1013,6

Re: [PATCH] HID: rmi: Disable populating F30 when the touchpad has physical buttons

On 06/16/2015 02:26 PM, Benjamin Tissoires wrote: Hi Andrew, On Jun 16 2015 or thereabouts, Andrew Duggan wrote: Physical buttons do not use F30 to report their state and in some cases the data reported in F30 is incorrect and inconsistent with what is reported by the HID descriptor. When

Re: [PATCH 07/11] Input: synaptics-rmi4 - f11: fix bitmap irq check

On 06/23/2015 12:17 PM, Benjamin Tissoires wrote: num_irq_regs is the count of registers of 1 bytes that we use to check the irqs. bitmap_and() expects the number of bits. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Reviewed-by: Andrew Duggan adug...@synaptics.com

Re: [PATCH 08/11] Input: synaptics-rmi4 - f11: use the unified input node if available

On 06/23/2015 12:17 PM, Benjamin Tissoires wrote: Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Reviewed-by: Andrew Duggan adug...@synaptics.com drivers/input/rmi4/rmi_f11.c | 60 ++-- 1 file changed, 35 insertions(+), 25

Re: [PATCH 04/11] Input: synaptics-rmi4 - prevent oopses when irq arrives while the device is not bound

On 06/23/2015 12:17 PM, Benjamin Tissoires wrote: If the device has been registered but is not populated, we should not process any incoming interrupt. Make sure the pointers we are following are valid. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Reviewed-by: Andrew

Re: [PATCH 01/11] Input: synaptics-rmi4 - embed the function modules in rmi_core

with just including them in the core until there is a critical mass of function drivers which justifies doing dynamic loading. Reviewed-by: Andrew Duggan adug...@synaptics.com drivers/input/rmi4/Kconfig | 5 + drivers/input/rmi4/Makefile | 2 +- drivers/input/rmi4/rmi_bus.c

Re: [PATCH 03/11] Input: synaptics-rmi4 - explicitly request polling when needed

rmi_process_interrupt_requests() to trigger a process of the alert. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- This will also be needed by hid-rmi when it is eventually converted into a rmi transport driver. Reviewed-by: Andrew Duggan adug...@synaptics.com drivers/input/rmi4/rmi_driver.c

Re: [PATCH 10/11] Input: synaptics-rmi4 - f11: allow the top software button property to be set

-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Reviewed-by: Andrew Duggan adug...@synaptics.com drivers/input/rmi4/rmi_f11.c | 5 + include/linux/rmi.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c

Re: [PATCH 05/11] Input: synaptics-rmi4 - call rmi_driver_process_config_requests in enable_sensor

-by: Andrew Duggan adug...@synaptics.com drivers/input/rmi4/rmi_driver.c | 78 ++--- drivers/input/rmi4/rmi_f11.c| 4 +++ 2 files changed, 45 insertions(+), 37 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index

Re: [PATCH 11/11] Input: synaptics-rmi4 - f11: add support for kernel tracking

--- Reviewed-by: Andrew Duggan adug...@synaptics.com drivers/input/rmi4/rmi_f11.c | 152 +-- include/linux/rmi.h | 14 ++-- 2 files changed, 114 insertions(+), 52 deletions(-) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c

Re: [PATCH 09/11] Input: synaptics-rmi4 - f11: clean up rmi_f11_finger_handler

-by: Andrew Duggan adug...@synaptics.com drivers/input/rmi4/rmi_f11.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c index 061530a..77a18aa 100644 --- a/drivers/input/rmi4

Re: [PATCH 02/11] Input: synaptics-rmi4 - add a common input device in rmi_driver

to differentiate the various models. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Reviewed-by: Andrew Duggan adug...@synaptics.com drivers/input/rmi4/rmi_driver.c | 43 + drivers/input/rmi4/rmi_driver.h | 6 ++ drivers/input/rmi4

[PATCH] HID: rmi: Disable scanning if the device is not a wake source

source and ensures scanning is enabled on resume. Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 56 ++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index

[PATCH] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices

Add devicetree binding for I2C devices and add bindings for optional parameters in the function drivers. Signed-off-by: Andrew Duggan adug...@synaptics.com --- I saw Benjamin Tissoires's email about the lack of a devicetree implementation for rmi_i2c.c. I decided to clean up and add documentation

[PATCH v3] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices

Add devicetree binding for I2C devices and add bindings for optional parameters in the function drivers. Parameters for function drivers are defined in child nodes for each of the functions. Signed-off-by: Andrew Duggan adug...@synaptics.com --- This version fixes the issues in v2 pointed out

[PATCH v2] Input: synaptics-rmi4: Use generic interrupt handling

. This patch removes the GPIO code and instead gets the irq passed up from the underlying transport (ie i2c-core). Signed-off-by: Andrew Duggan adug...@synaptics.com --- After additional testing on a platform which uses board files I realized that the platform data should be able to provide irq flags

[PATCH v2] HID: i2c-hid: Only disable irq wake if it was successfully enabled during suspend

failed during suspend. Signed-off-by: Andrew Duggan adug...@synaptics.com --- This patch is based on Jiri's for-4.3/i2c-hid and needs Gabriele Mazzotta's patch which moves where the HID driver's suspend callback call to apply cleanly. drivers/hid/i2c-hid/i2c-hid.c | 24 1

Re: [PATCH] HID: i2c-hid: Only disable irq wake if it was successfully enabled during suspend

On 07/28/2015 04:33 AM, Mika Westerberg wrote: On Mon, Jul 27, 2015 at 05:08:06PM -0700, Andrew Duggan wrote: On at least one platform the kernel prints a warning on resume saying Unbalanced IRQ 37 wake disable. This is because enable_irq_wake in the suspend function is failing. This patch

Re: [PATCH] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices

Hi Dmitry, On 08/09/2015 12:40 AM, Dmitry Torokhov wrote: Hi Andrew, On Fri, Aug 07, 2015 at 05:37:49PM -0700, Andrew Duggan wrote: +Optional Properties: +- syna,sensor-name: The string containing the name of the sensor. +- syna,attn-gpio: The GPIO number used to assert attention. +- syna

[PATCH] Input: synaptics-rmi4: Use generic interrupt handling

. This patch removes the GPIO code and instead gets the irq passed up from the underlying transport (ie i2c-core). Signed-off-by: Andrew Duggan adug...@synaptics.com --- Hi Dmitry, I went ahead and removed the GPIO handling code. If we end up needing GPIO support in the future it sounds like the right

[PATCH v2] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices

Add devicetree binding for I2C devices and add bindings for optional parameters in the function drivers. Parameters for function drivers are defined in child nodes for each of the functions. Signed-off-by: Andrew Duggan adug...@synaptics.com --- This version depends on the Use generic interrupt

[PATCH] HID: i2c-hid: Only disable irq wake if it was successfully enabled during suspend

On at least one platform the kernel prints a warning on resume saying Unbalanced IRQ 37 wake disable. This is because enable_irq_wake in the suspend function is failing. This patch checks to see if the call to enable_irq_wake succeeded before calling disable_irq_wake. Signed-off-by: Andrew Duggan

[PATCH] HID: rmi: Set F01 interrupt enable register when not set

the correct value based on interrupt mask computed while scanning the PDT. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91102 Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 57 ++- 1 file changed, 52 insertions(+), 5

Re: [PATCH 01/26] Input: synaptics-rmi4 - embed the function modules in rmi_core

On 11/10/2015 01:03 AM, Benjamin Tissoires wrote: On Tue, Nov 10, 2015 at 12:06 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: On Thu, Nov 05, 2015 at 03:36:18PM -0800, Andrew Duggan wrote: From: Benjamin Tissoires <benjamin.tissoi...@redhat.com> the function modules can

Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support

On 11/09/2015 03:25 PM, Dmitry Torokhov wrote: On Mon, Nov 09, 2015 at 02:54:08PM -0800, Andrew Duggan wrote: On 11/09/2015 06:06 AM, Benjamin Tissoires wrote: Hey Linus, first thanks for the reviews. Much appreciated. On Mon, Nov 9, 2015 at 2:32 PM, Linus Walleij <linus.wall...@linaro.

Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support

On 11/09/2015 06:06 AM, Benjamin Tissoires wrote: Hey Linus, first thanks for the reviews. Much appreciated. On Mon, Nov 9, 2015 at 2:32 PM, Linus Walleij <linus.wall...@linaro.org> wrote: On Fri, Nov 6, 2015 at 12:42 AM, Andrew Duggan <adug...@synaptics.com> wrote: From: Benjam

Re: [PATCH 00/26] Consolidate patches and add support for new devices

Hi Linus, Thanks for reviewing! On 11/09/2015 04:49 AM, Linus Walleij wrote: On Fri, Nov 6, 2015 at 12:34 AM, Andrew Duggan <adug...@synaptics.com> wrote: NOTE: This patch set applies to synaptics-rmi4 branch in Dmitry Torokhov's input tree. (...) This patchset applies c

Re: [PATCH 00/11] Input: synaptics-rmi4: various fixes for the existing rmi4 branch

On 11/03/2015 06:01 AM, Linus Walleij wrote: On Mon, Nov 2, 2015 at 11:14 PM, Andrew Duggan <adug...@synaptics.com> wrote: I have been continuing to work on the synaptics-rmi4 driver and was just trying to figure out what the next step should be. I recently uploaded my changes here

Re: [PATCH 00/11] Input: synaptics-rmi4: various fixes for the existing rmi4 branch

On 10/31/2015 01:41 PM, Linus Walleij wrote: On Thu, Jul 23, 2015 at 7:10 PM, Benjamin Tissoires wrote: Dmitry, the Sony guys are currently working on upstreaming their work. Their Xperia are using a Synaptics I2C touchscreen. They are able to boot with an

[PATCH 02/26] Input: synaptics-rmi4 - add a common input device in rmi_driver

PRODUCT_ID" to be able to differentiate the various models. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_driver.c | 43 + drivers/input/rmi4/rmi_driver.

[PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling when needed

n call rmi_process_interrupt_requests() to trigger a process of the alert. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_driver.c | 18 +- drivers/input/rmi4/rmi_driver.h | 3 +++ i

[PATCH 01/26] Input: synaptics-rmi4 - embed the function modules in rmi_core

ctions are there too. There is not much use of having the functions separate anyway Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/Kconfig | 5 + drivers/input/rmi4/Makefile | 2 +-

[PATCH 04/26] Input: synaptics-rmi4 - prevent oopses when irq arrives while the device is not bound

From: Benjamin Tissoires <benjamin.tissoi...@redhat.com> If the device has been registered but is not populated, we should not process any incoming interrupt. Make sure the pointers we are following are valid. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Teste

[PATCH 05/26] Input: synaptics-rmi4 - call rmi_driver_process_config_requests in enable_sensor

m> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_driver.c | 78 ++--- drivers/input/rmi4/rmi_f11.c| 4 +++ 2 files changed, 45 insertions(+), 37 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/

[PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling when needed

n call rmi_process_interrupt_requests() to trigger a process of the alert. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_driver.c | 18 +- drivers/input/rmi4/rmi_driver.h | 3 +++ i

[PATCH 01/26] Input: synaptics-rmi4 - embed the function modules in rmi_core

ctions are there too. There is not much use of having the functions separate anyway Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/Kconfig | 5 + drivers/input/rmi4/Makefile | 2 +-

[PATCH 02/26] Input: synaptics-rmi4 - add a common input device in rmi_driver

PRODUCT_ID" to be able to differentiate the various models. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_driver.c | 43 + drivers/input/rmi4/rmi_driver.

[PATCH 04/26] Input: synaptics-rmi4 - prevent oopses when irq arrives while the device is not bound

From: Benjamin Tissoires <benjamin.tissoi...@redhat.com> If the device has been registered but is not populated, we should not process any incoming interrupt. Make sure the pointers we are following are valid. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Teste

[PATCH 22/26] Input: synaptics-rmi4 - Add F30 support

reated by rmi_driver. Signed-off-by: Andrew Duggan <adug...@synaptics.com> Signed-off-by: Allie Xiong <axi...@synaptics.com> Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/input/rmi4/Kconfig | 12 ++ drivers/input/rmi4/Makefile | 1 + driv

[PATCH 21/26] Input: synaptics-rmi4: Add support for F12

Function 12 implements 2D touch position sensor for newer Synaptics touch devices. It replaces F11 and no device will contain both functions. Signed-off-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/Kconfig | 10 + drivers/input/rmi4/Makefile | 1 + drivers

[PATCH 23/26] Input: synaptics-rmi4: move structures and definitions to rmi.h

Move all of the structures and function definitions needed by hid-rmi into rmi.h so that they can be accessed by hid-rmi. Signed-off-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_bus.h| 119 --- drivers/input/rmi4/rmi_driver.h

[PATCH 24/26] Input: synaptics-rmi4: use device managed memory for the data packet buffer

The data packet should use device managed memory since the buffer is retained until the device goes away. Signed-off-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_f11.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_f

[PATCH 25/26] Input: synaptics-rmi4: remove sensor_name in platform data

. Signed-off-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_bus.c| 3 +-- drivers/input/rmi4/rmi_driver.c | 7 ++- drivers/input/rmi4/rmi_f11.c| 3 +-- drivers/input/rmi4/rmi_i2c.c| 5 + include/linux/rmi.h | 2 -- 5 files changed, 5 inse

[PATCH 26/26] Input: synaptics-rmi4: Change the rmi device's name to be less generic

-by: Andrew Duggan <adug...@synaptics.com> --- Linus Walleij suggested that we use the TM number as the device name. But, we need to set the device name when we add the device before we read the TM number. Changing the name to rmiXX is a compromise since it's not as unique as the TM, but not as g

[PATCH 11/26] Input: synaptics-rmi4 - f11: add support for kernel tracking

edhat.com> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_f11.c | 153 +-- include/linux/rmi.h | 14 ++-- 2 files changed, 115 insertions(+), 52 deletions(-) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/in

[PATCH 12/26] Input: synaptics-rmi4: Use generic interrupt handling

. This patch removes the GPIO code and instead gets the irq passed up from the underlying transport (ie i2c-core). Signed-off-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_bus.h| 3 ++ drivers/input/rmi4/rmi_driver.c | 81 +++-- drivers

[PATCH 09/26] Input: synaptics-rmi4 - f11: clean up rmi_f11_finger_handler

m> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_f11.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c index dbe2681..768c199 100644 --- a/

[PATCH 10/26] Input: synaptics-rmi4 - f11: allow the top software button property to be set

m data. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_f11.c | 5 + include/linux/rmi.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/

[PATCH 07/26] Input: synaptics-rmi4 - f11: fix bitmap irq check

From: Benjamin Tissoires <benjamin.tissoi...@redhat.com> num_irq_regs is the count of registers of 1 bytes that we use to check the irqs. bitmap_and() expects the number of bits. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Tested-by: Andrew Duggan <adug..

[PATCH 08/26] Input: synaptics-rmi4 - f11: use the unified input node if available

From: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Tested-by: Andrew Duggan <adug...@synaptics.com> --- drivers/input/rmi4/rmi_f11.c | 60 ++-- 1 file changed, 35

[PATCH 06/26] Input: synaptics-rmi4 - add a reset callback

From: Benjamin Tissoires <benjamin.tissoi...@redhat.com> When a device is physically reset, the transport layer may need to reset its state too and also do extra work to make the device accessible on the bus. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Teste

  1   2   3   4   5   6   >