Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-08 Thread Andrew Morton
On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs wrote: > audit rule additions containing "-F auid!=4294967295" were failing with > EINVAL. > > UID_INVALID (and GID_INVALID) is actually a valid uid (gid) for setting and > testing against audit rules. Remove the check for invalid uid and g

Re: [PATCH 0/3] posix_timers: A few expiry caching fixes

2013-04-08 Thread Andrew Morton
On Sat, 30 Mar 2013 14:15:28 +0100 Frederic Weisbecker wrote: > This series is on top of latest -mmotm. > > [1/3] fixes some omitting sample capture after a build warning suddenly > became visible > [2/3] fixes a wrong timer_gettime() result on a timer whose target has been > reaped. > [3/3]

Re: [PATCH v2] bitmap: speedup in bitmap_find_free_region when order is 0

2013-04-08 Thread Andrew Morton
On Tue, 9 Apr 2013 11:44:46 +0900 Chanho Min wrote: > If bitmap_find_free_region() is called with order=0, We can reduce > for-loops to find 1 free bit. First, It scans bitmap array by the > increment of long type, then find 1 free bit within 1 long type value. > > In 32 bits system and 1024 bi

Re: [PATCH v2] bitmap: speedup in bitmap_find_free_region when order is 0

2013-04-08 Thread Andrew Morton
On Mon, 08 Apr 2013 20:18:20 -0700 Joe Perches wrote: > On Mon, 2013-04-08 at 20:10 -0700, Andrew Morton wrote: > > > --- a/lib/bitmap.c > [] > > > + for (i = 0 ; i < nlongs_reg ; i++) { > > > > No space before the semicolon, please. checkpatch should

Re: [UPDATE][PATCH v2 2/3] resource: Add release_mem_region_adjustable()

2013-04-09 Thread Andrew Morton
On Tue, 09 Apr 2013 13:02:30 -0600 Toshi Kani wrote: > > > + /* look for the next resource if it does not fit into */ > > > + if (res->start > start || res->end < end) { > > > + p = &res->sibling; > > > + continue; > > > + } > > > > What if

Re: [PATCH] mm: remove compressed copy from zram in-memory

2013-04-09 Thread Andrew Morton
On Tue, 9 Apr 2013 10:02:31 +0900 Minchan Kim wrote: > > Also, what's up with the SWP_BLKDEV test? zram doesn't support > > SWP_FILE? Why on earth not? > > > > Putting swap_slot_free_notify() into block_device_operations seems > > rather wrong. It precludes zram-over-swapfiles for all time an

Re: [patch] fs, proc: truncate /proc/pid/comm writes to first TASK_COMM_LEN bytes

2013-04-09 Thread Andrew Morton
valent to prctl(PR_SET_NAME). The implementation should not need to know the definition of TASK_COMM_LEN. This patch truncates the string to the first TASK_COMM_LEN bytes and returns the bytes written as the length of the string written so the second write() is suppressed. $ cat /proc/$$/c

Re: [PATCH v2] bitmap: speedup in bitmap_find_free_region when order is 0

2013-04-09 Thread Andrew Morton
On Tue, 9 Apr 2013 15:34:44 +0900 "Chanho Min" wrote: > >It seems excessively complicated to me. Why not change > >bitmap_find_free_region() to skip the leading all-ones words and when > >it finds a not-all-ones word, adjust `pos' then fall into the existing > >bit-at-a-time search? > > Do we n

Re: [PATCH] ipc: use list_for_each_entry for list traversing

2013-04-09 Thread Andrew Morton
On Tue, 09 Apr 2013 11:39:07 +0200 Nikola Pajkovsky wrote: > Andrew Morton writes: > > > urgh, that code is sick. What's it doing poking around in the > > list_head internals? > > No idea, it there from beginning of first kernel importation into > git. Where

Re: [PATCH v3] [RESEND] mm: Make snapshotting pages for stable writes a per-bio operation

2013-04-09 Thread Andrew Morton
On Tue, 9 Apr 2013 11:06:17 -0700 "Darrick J. Wong" wrote: > + * Here we write back pagecache data that may be mmaped. Since > + * we cannot afford to clean the page and set PageWriteback > + * here due to lock ordering (page lock ranks above transaction >

Re: [PATCH v8 3/3] mm: reinititalise user and admin reserves if memory is added or removed

2013-04-09 Thread Andrew Morton
On Mon, 8 Apr 2013 17:00:40 -0400 Andrew Shewmaker wrote: > Should I add the memory notifier code to mm/nommu.c too? > I'm guessing that if a system doesn't have an mmu that it also > won't be hotplugging memory. I doubt if we need to worry about memory hotplug on nommu machines, so just do the

Re: [PATCH v3 00/11] mm: fixup changers of per cpu pageset's ->high and ->batch

2013-04-10 Thread Andrew Morton
On Wed, 10 Apr 2013 11:23:28 -0700 Cody P Schafer wrote: > "Problems" with the current code: > 1. there is a lack of synchronization in setting ->high and ->batch in > percpu_pagelist_fraction_sysctl_handler() > 2. stop_machine() in zone_pcp_update() is unnecissary. > 3. zone_pcp_update()

Re: [PATCH v3 2/3] resource: Add release_mem_region_adjustable()

2013-04-10 Thread Andrew Morton
On Wed, 10 Apr 2013 11:17:00 -0600 Toshi Kani wrote: > Added release_mem_region_adjustable(), which releases a requested > region from a currently busy memory resource. This interface > adjusts the matched memory resource accordingly even if the > requested region does not match exactly but stil

Re: [mmotm:master 81/499] WARNING: mm/built-in.o(.text+0x1acc1): Section mismatch in reference from the function reserve_mem_notifier() to the function .meminit.text:init_user_reserve()

2013-04-10 Thread Andrew Morton
On Wed, 10 Apr 2013 16:04:11 -0600 Andrew Shewmaker wrote: > On Wed, Apr 10, 2013 at 12:11 AM, kbuild test robot > wrote: > > tree: git://git.cmpxchg.org/linux-mmotm.git master > > head: 47ca352cea8ba679f803387d208c739131ecb38a > > commit: 992357a07ee0697a1997c2960c3f88d02b2f2753 [81/499] mm

Re: [PATCH v3 2/3] resource: Add release_mem_region_adjustable()

2013-04-10 Thread Andrew Morton
On Wed, 10 Apr 2013 15:08:29 -0700 (PDT) David Rientjes wrote: > On Wed, 10 Apr 2013, Toshi Kani wrote: > > > > I'll switch it to GFP_ATOMIC. Which is horridly lame but the > > > allocation is small and alternatives are unobvious. > > > > Great! Again, thanks for the update! > > release_mem

Re: [PATCH] checkpatch: Warn on comparisons to true and false

2013-04-10 Thread Andrew Morton
On Tue, 09 Apr 2013 20:17:14 -0700 Joe Perches wrote: > Comparisons of A to true and false are better written > as A and !A. > > Bleat a message on use. hm. I'm counting around 1,100 instances of "== true" and "== false". That's a lot of people to shout at. Is it really worthwhile? "foo==tr

Re: [PATCH] Sys V shared memory limited to 8TiB.

2013-04-10 Thread Andrew Morton
On Tue, 9 Apr 2013 21:39:24 -0500 Robin Holt wrote: > Trying to run an application which was trying to put data into half > of memory using shmget(), we found that having a shmall value below > 8EiB-8TiB would prevent us from using anything more than 8TiB. By setting > kernel.shmall greater that

Re: [PATCH] vfs: dcache: cond_resched in shrink_dentry_list

2013-04-10 Thread Andrew Morton
On Tue, 09 Apr 2013 17:37:20 -0700 Greg Thelen wrote: > > Call cond_resched() in shrink_dcache_parent() to maintain > > interactivity. > > > > Before this patch: > > > > void shrink_dcache_parent(struct dentry * parent) > > { > > while ((found = select_parent(parent, &dispose)) != 0) > >

Re: [PATCH] Don't disable hpet emulation on suspend

2013-04-10 Thread Andrew Morton
On Tue, 9 Apr 2013 17:36:13 -0700 Derek Basehore wrote: > There's a bug where rtc alarms are ignored after the rtc cmos suspends but > before the system finishes suspend. Since hpet emulation is disabled and it > still handles the interrupts, a wake event is never registered which is done > fro

Re: [PATCH] memory hotplug: fix warnings

2013-04-30 Thread Andrew Morton
On Tue, 30 Apr 2013 09:17:11 -0700 (PDT) David Rientjes wrote: > On Tue, 30 Apr 2013, Vincent Stehl__ wrote: > > > diff --git a/include/linux/memory.h b/include/linux/memory.h > > index 73817af..85c31a8 100644 > > --- a/include/linux/memory.h > > +++ b/include/linux/memory.h > > @@ -137,7 +137,

Re: [PATCH] memory hotplug: fix warnings

2013-04-30 Thread Andrew Morton
On Tue, 30 Apr 2013 09:54:18 -0700 (PDT) David Rientjes wrote: > On Tue, 30 Apr 2013, Andrew Morton wrote: > > > > > diff --git a/include/linux/memory.h b/include/linux/memory.h > > > > index 73817af..85c31a8 100644 > > > > --- a/include/linux/mem

Re: [PATCH] lib: add weak __clzsi2()/__clzdi2() functions

2013-04-30 Thread Andrew Morton
On Mon, 29 Apr 2013 14:40:05 +0900 Chanho Min wrote: > Some architectures need __clzsi2() or __clzdi2() for __builtin_clz and > It causes build failure. They can be implemented using the fls() and > overridden by linking arch-specific versions may not be implemented yet. > > Reference: https://l

Re: [PATCH v3 -next 3/5] arm: Add support for LZ4-compressed kernel

2013-04-30 Thread Andrew Morton
On Tue, 5 Mar 2013 20:47:34 +0900 Kyungsik Lee wrote: > This patch integrates the LZ4 decompression code to the arm pre-boot code. > And it depends on two patchs below > > lib: Add support for LZ4-compressed kernel > decompressor: Add LZ4 decompressor module > > ... > > - Apply CFLAGS, -Os to

Re: [PATCH] lib: add weak __clzsi2()/__clzdi2() functions

2013-04-30 Thread Andrew Morton
On Mon, 29 Apr 2013 09:20:25 +0200 Geert Uytterhoeven wrote: > On Mon, Apr 29, 2013 at 7:40 AM, Chanho Min wrote: > > Some architectures need __clzsi2() or __clzdi2() for __builtin_clz and > > It causes build failure. They can be implemented using the fls() and > > overridden by linking arch-sp

Re: [PATCH -next] ashmem: Fix ashmem_shrink deadlock.

2013-05-07 Thread Andrew Morton
On Wed, 1 May 2013 09:56:13 -0400 Robert Love wrote: > Don't acquire ashmem_mutex in ashmem_shrink if we've somehow recursed into the > shrinker code from within ashmem. Just bail out, avoiding a deadlock. This is > fine, as ashmem cache pruning is advisory anyhow. > Sorry, but I don't think "

Re: [PATCH v3 00/11] mm: fixup changers of per cpu pageset's ->high and ->batch

2013-05-07 Thread Andrew Morton
On Wed, 01 May 2013 16:53:42 -0700 Cody P Schafer wrote: > >> There hasn't been a ton of review activity for this patchset :( > >> > >> I'm inclined to duck it until after 3.9. Do the patches fix any > >> noticeably bad userspace behavior? > > > > No, all the bugs are theoretical. Waiting shoul

Re: [RESEND] [PATCH 1/1] block: Fix id of xsysace with missing port-number

2013-05-07 Thread Andrew Morton
On Thu, 2 May 2013 22:27:45 +0200 Gernot Vormayr wrote: > If the port number is missing from the device-tree the device gets > named xs` instead of xsa. This fixes the check for missing ids. > > Tested on ml507 board. > > Signed-off-by: Gernot Vormayr > --- > drivers/block/xsysace.c | 3 +--

Re: [PATCH] wait: fix false timeouts when using wait_event_timeout()

2013-05-07 Thread Andrew Morton
On Thu, 2 May 2013 11:36:56 +0200 Daniel Vetter wrote: > On Thu, May 2, 2013 at 10:58 AM, Imre Deak wrote: > > Many callers of the wait_event_timeout() and > > wait_event_interruptible_timeout() expect that the return value will be > > positive if the specified condition becomes true before the

Re: [PATCH] rtc: rtc-tile: add missing platform_device_unregister() when module exit

2013-05-07 Thread Andrew Morton
On Sun, 5 May 2013 13:07:00 +0800 Wei Yongjun wrote: > From: Wei Yongjun > > We have registered platform device when module init, and > need unregister it when module exit. > > ... > > --- a/drivers/rtc/rtc-tile.c > +++ b/drivers/rtc/rtc-tile.c > @@ -146,6 +146,7 @@ exit_driver_unregister: >

Re: [PATCH] idr: Print a stack dump after ida_remove warning

2013-05-07 Thread Andrew Morton
is not allocated.\n", id); > + dump_stack(); > } > EXPORT_SYMBOL(ida_remove); If we're going to do this, we should make that printk a KERN_EMERG or something, otherwise users might see a stack dump with no explanation why it occurred. We can do all that with plain old WARN(). How does

Re: [PATCH RESEND] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-05-08 Thread Andrew Morton
On Mon, 06 May 2013 13:50:18 +0800 Xiao Guangrong wrote: > The commit 751efd8610d3 (mmu_notifier_unregister NULL Pointer deref > and multiple ->release()) breaks the fix: > 3ad3d901bbcfb15a5e4690e55350db0899095a68 > (mm: mmu_notifier: fix freed page still mapped in secondary MMU) > > Si

Re: [PATCH RESEND v3] bitmap: speed up bitmap_find_free_region

2013-05-08 Thread Andrew Morton
} > return -ENOMEM; It could be improved further by returning to the long-at-a-time search if we failed to find a suffificiently large free region at `i'. Oh well, I guess we can do that later if someone cares enough. We now have a definition of four(!) locals on a single line

Re: [PATCH -v8 11/11] Move arch/x86 reboot= handling to generic kernel.

2013-05-08 Thread Andrew Morton
On Tue, 7 May 2013 09:39:55 -0500 Robin Holt wrote: > Merge together the unicore32, arm, and x86 reboot= command line > parameter handling. > > ... > > +static int __init reboot_setup(char *str) > +{ > + for (;;) { > + /* > + * Having anything passed on the command

Re: [PATCH] kmsg: honor dmesg_restrict sysctl on /dev/kmsg

2013-05-08 Thread Andrew Morton
On Tue, 30 Apr 2013 10:25:41 -0700 Kees Cook wrote: > To fix /dev/kmsg, let's compare the existing interfaces and what they allow: > > - /proc/kmsg allows: > - open (SYSLOG_ACTION_OPEN) if CAP_SYSLOG since it uses a destructive >single-reader interface (SYSLOG_ACTION_READ). > - everything,

Re: [PATCH] Fix crash during slab init

2013-05-08 Thread Andrew Morton
Tony Lindgren Tested-by: Tetsuo Handa Cc: Pekka Enberg Tested-by: Andrew Morton Signed-off-by: Andrew Morton --- mm/slab_common.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff -puN mm/slab_common.c~slab-fix-crash-during-slab-init mm/slab_common.c --- a/

Re: [patch] err.h: IS_ERR() can accept __user pointers

2013-05-08 Thread Andrew Morton
On Wed, 8 May 2013 10:42:22 +0300 Dan Carpenter wrote: > Sparse generates a false positive when you pass a __user or __iomem > pointer to the IS_ERR() functions. > > drivers/rtc/rtc-ds1286.c:344:36: sparse: incorrect type in argument 1 > (different address spaces) > drivers/rtc/rtc-ds1286.c:34

Re: [patch 1/2] dump_stack: serialize the output from dump_stack()

2013-05-08 Thread Andrew Morton
On Wed, 08 May 2013 16:01:03 -0500 athorl...@sgi.com wrote: > These patches fix up issues with interspersed output from multiple > simultaneous calls to warn or dump_stack on multi-cpu systems. > References: <20130508210102.898396...@asylum.americas.sgi.com> > Content-Disposition: inline; filename

Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-09 Thread Andrew Morton
On Tue, 7 May 2013 10:00:48 -0400 Jean-Francois Dagenais wrote: > V2: use the new bus_mutex > > extract from http://datasheets.maximintegrated.com/en/ds/DS2408.pdf: > > Power-up timing > The DS2408 is sensitive to the power-on slew rate and can inadvertently > power up with a test mode featur

Re: [PATCH v2] kernel: audit_tree: resource management: need put_tree and goto Err when failure occures

2013-05-09 Thread Andrew Morton
On Thu, 09 May 2013 20:53:06 +0800 Chen Gang wrote: > get_tree() in audit_add_tree_rule() is needed (my original conclusion is > incorrect). OK.. > But we need let 'rule->tree = NULL;' firstly, so can protect rule itself > freed in kill_rules(). I'll believe you ;) I turned this into a prope

Re: [PATCH -v9 04/11] Move shutdown/reboot related functions to kernel/reboot.c

2013-05-09 Thread Andrew Morton
On Thu, 9 May 2013 14:23:18 -0500 Robin Holt wrote: > This patch is preparatory. It moves reboot related syscall, etc > functions from kernel/sys.c to kernel/reboot.c. This doesn't apply. > -static void migrate_to_reboot_cpu(void) > -{ > - /* The boot cpu is always logical cpu 0 */ > -

Re: [PATCH -v8 01/11] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug

2013-05-09 Thread Andrew Morton
On Tue, 7 May 2013 09:39:45 -0500 Robin Holt wrote: > From: "Srivatsa S. Bhat" > > There are instances in the kernel where we would like to disable > CPU hotplug (from sysfs) during some important operation. Today > the freezer code depends on this and the code to do it was kinda > tailor-made

Re: [PATCH -v8 01/11] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug

2013-05-10 Thread Andrew Morton
On Fri, 10 May 2013 13:11:51 +0200 "Rafael J. Wysocki" wrote: > ... > > > cpu_hotplug_disable() doesn't get compiled unless we've defined > > CONFIG_PM_SLEEP_SMP. I cannot begin to imagine what the logic is > > behind that! > > I suppose it was only used by suspend/hibernate code paths when thi

Re: init-mainc-convert-to-pr_foo.patch is IMHO broken

2013-04-23 Thread Andrew Morton
On Tue, 23 Apr 2013 21:18:39 +0200 Uwe Kleine-K__nig wrote: > Hello, > > init-mainc-convert-to-pr_foo.patch breaks the initcall_debug kernel > parameter. Before the patch I could add > > initcall_debug ignore_loglevel > > to the kernel command line and got some additional output about >

Re: [PATCH] relay: fix timer madness

2013-04-23 Thread Andrew Morton
On Sat, 20 Apr 2013 15:37:08 +0800 "zhangwei(Jovi)" wrote: > Hi, > > Ingo, Steven, I get this patch from 3.4 preempt-rt patch set, It seems that > this patch > fix relayfs bug not only for rt kernel, but also for mainline. > > When I'm using below ktap script to tracing all event tracepoints,

Re: [PATCH] fix initconst in lib/decompress.c

2013-04-23 Thread Andrew Morton
On Sat, 20 Apr 2013 20:44:45 -0700 Andi Kleen wrote: > From: Andi Kleen > > > diff --git a/lib/decompress.c b/lib/decompress.c > index 31a8042..f8fdeda 100644 > --- a/lib/decompress.c > +++ b/lib/decompress.c > @@ -38,7 +38,7 @@ struct compress_format { > decompress_fn decompressor; > }

Re: [PATCH 1/2] smp: use '|=' for csd_lock

2013-04-23 Thread Andrew Morton
7;|=' for csd_lock csd_lock() uses assignment to data->flags rather than |=. That is not buggy at present because only one bit (CSD_FLAG_LOCK) is defined in call_single_data.flags. But it will become buggy if we later add another flag, so fix it now. Signed-off-by: liguang Cc: Peter Zi

Re: [PATCH V2 1/3] seccomp: add generic code for jitted seccomp filters.

2013-04-23 Thread Andrew Morton
On Mon, 22 Apr 2013 14:31:20 +0200 Nicolas Schichan wrote: > On 04/17/2013 11:56 PM, Andrew Morton wrote: > > This patch is killing me. > > > >> --- a/include/linux/seccomp.h > >> +++ b/include/linux/seccomp.h > >> @@ -6,6 +6,7 @@ > &g

Re: [PATCH] mm: swap: Mark swap pages writeback before queueing for direct IO

2013-04-24 Thread Andrew Morton
On Wed, 24 Apr 2013 19:57:44 +0100 Mel Gorman wrote: > As pointed out by Andrew Morton, the swap-over-NFS writeback is not setting > PageWriteback before it is queued for direct IO. While swap pages do not > participate in BDI or process dirty accounting and the IO is synchrono

Re: [PATCH] powerpc: Add HWCAP2 aux entry

2013-04-24 Thread Andrew Morton
On Tue, 23 Apr 2013 10:41:42 +1000 Benjamin Herrenschmidt wrote: > On Thu, 2013-04-18 at 13:41 +1000, Michael Neuling wrote: > > akpm, > > > > If you're happy with this, is it something you can take in your tree? > > Andrew ? Or give me an ack ? :-) I'm happy to carry this, we need that > rath

Re: [PATCH] re-order CONFIG_EXPERT options to fix menuconfig display

2013-04-24 Thread Andrew Morton
On Mon, 22 Apr 2013 13:39:38 -0400 Mike Frysinger wrote: > The kconfig language requires that dependent options all follow the > menuconfig symbol in order to be collapsed below it. Recently some > hidden options were added below the EXPERT menuconfig, but did not > depend on EXPERT (because hid

Re: [Resend][Bug fix PATCH v5] Reusing a resource structure allocated by bootmem

2013-04-24 Thread Andrew Morton
On Wed, 24 Apr 2013 08:50:21 +0900 Yasuaki Ishimatsu wrote: > When hot removing memory presented at boot time, following messages are shown: > > [ 296.867031] [ cut here ] > [ 296.922273] kernel BUG at mm/slub.c:3409! > > ... > > The reason why the messages are shown i

Re: [PATCH 3/3] rtc: rtc-hid-sensor-time; add option hctosys to set time at boot

2013-04-24 Thread Andrew Morton
On Tue, 23 Apr 2013 17:47:20 +0200 Alexander Holler wrote: > >>> "time_was_set_once" and have choosen one day just in case something > >>> needs really long to boot (e.g. because of some lengthy fsck or whatever > >>> else). > >>> > >>> A solution to both problems might be to change the logic fo

Re: [PATCH 1/3] rapidio: make enumeration/discovery configurable

2013-04-24 Thread Andrew Morton
On Wed, 24 Apr 2013 10:31:57 -0400 Alexandre Bounine wrote: > Rework to implement RapidIO enumeration/discovery method selection > combined with ability to use enumeration/discovery as a kernel module. > > This patch adds ability to introduce new RapidIO enumeration/discovery methods > using ke

Re: [PATCH -v6 5/5] Move arch/x86 reboot= handling to generic kernel.

2013-04-24 Thread Andrew Morton
On Wed, 24 Apr 2013 06:18:53 -0500 Robin Holt wrote: > Since arch/x86 has the most extensive reboot= handling and it appears to > have no effect on the remaining architectures. This patch moves that > reboot= handling from arch/x86 to the generic kernel. > This seems incomplete. These, in arc

Re: [PATCH -v6 2/5] Migrate shutdown/reboot to boot cpu.

2013-04-24 Thread Andrew Morton
On Wed, 24 Apr 2013 06:18:50 -0500 Robin Holt wrote: > We recently noticed that reboot of a 1024 cpu machine takes approx 16 > minutes of just stopping the cpus. The slowdown was tracked to commit > f96972f. > > The current implementation does all the work of hot removing the cpus > before halt

Re: [PATCH -v6 2/5] Migrate shutdown/reboot to boot cpu.

2013-04-24 Thread Andrew Morton
On Wed, 24 Apr 2013 15:17:49 -0700 Andrew Morton wrote: > > +static void migrate_to_reboot_cpu(void) > > +{ > > + /* The boot cpu is always logical cpu 0 */ > > + int reboot_cpu_id = 0; > > + > > + cpu_hotplug_disable(); > > + > > + /

Re: [PATCH V2 1/3] seccomp: add generic code for jitted seccomp filters.

2013-04-24 Thread Andrew Morton
irq, as it will in turn call vfree() which will > BUG_ON() if in_interrupt() is non zero. So to call module_free(), it is > therefore required to be in a process context, which is provided by the work > struct. Well let's explain this to the next sucker who comes along. From:

Re: mm: BUG in do_huge_pmd_wp_page

2013-04-24 Thread Andrew Morton
On Thu, 11 Apr 2013 11:14:29 -0400 Sasha Levin wrote: > On 04/11/2013 11:13 AM, Kirill A. Shutemov wrote: > > Sasha Levin wrote: > >> On 04/10/2013 04:02 AM, Minchan Kim wrote: > >>> I don't know this issue was already resolved. If so, my reply become a > >>> just > >>> question to Kirill regard

Re: [PATCH -v6 2/5] Migrate shutdown/reboot to boot cpu.

2013-04-25 Thread Andrew Morton
On Thu, 25 Apr 2013 08:57:04 +0200 Ingo Molnar wrote: > > PF_THREAD_BOUND was removed/replaced in linux-next's a9ab775bc > > ("workqueue: directly restore CPU affinity of workers from CPU_ONLINE") > > I don't see PF_THREAD_BOUND being removed by commit a9ab775bc. Did you > mean some other commi

Re: [ PATCH ] Memory leak fix for bug 57101.

2013-04-25 Thread Andrew Morton
On Thu, 25 Apr 2013 13:49:12 + Anurup m wrote: > Resending the patch as Plain text, with no mangled tabs. Please send us a Signed-off-by: for this, as described in Documentation/SubmittingPatches, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: memcpy_fromio in dmi_scan.c

2013-04-25 Thread Andrew Morton
On Thu, 25 Apr 2013 04:52:42 -0500 Robin Holt wrote: > On Wed, Apr 24, 2013 at 09:07:24PM -0500, Robin Holt wrote: > > On Wed, Apr 24, 2013 at 08:16:50PM +, Luck, Tony wrote: > > > > That being said, "my" SN2 machine was previously running kernel 3.0.34 > > > > which has the old dmi_scan code

Re: [PATCH] mm, highmem: remove useless virtual variable in page_address_map

2013-04-25 Thread Andrew Morton
On Mon, 22 Apr 2013 17:26:28 +0900 Joonsoo Kim wrote: > We can get virtual address without virtual field. > So remove it. > > ... > > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -320,7 +320,6 @@ EXPORT_SYMBOL(kunmap_high); > */ > struct page_address_map { > struct page *page; > - v

Re: [PATCH V2] usb: storage: Convert US_DEBUGP to usb_stor_dbg

2013-04-25 Thread Andrew Morton
: error: 'struct rts51x_chip' has no > member named 'us' > > chip->us here is only defined when CONFIG_REALTEK_AUTOPM is enabled. local var `us' doesn't get used by anything and it's unclear why that patch added it? From: Andrew Morton Subject:

Re: [PATCH 1/2] lib: Add lz4 compressor module

2013-04-25 Thread Andrew Morton
On Mon, 22 Apr 2013 18:22:18 +0900 "Chanho Min" wrote: > >> +#define HTYPE const u8* > >> + > >> +#ifdef __BIG_ENDIAN > >> +#define LZ4_NBCOMMONBYTES(val) (__builtin_clz(val) >> 3) > >> +#else > >> +#define LZ4_NBCOMMONBYTES(val) (__builtin_ctz(val) >> 3) > >> +#endif > > > >It seems at least m68

Re: [PATCH v3 -next 4/5] x86: Add support for LZ4-compressed kernel

2013-04-25 Thread Andrew Morton
On Wed, 6 Mar 2013 15:37:38 +0900 Kyungsik Lee wrote: > On Tue, Mar 05, 2013 at 08:13:38AM -0800, H. Peter Anvin wrote: > > Please add the new magic to Documentation/x86/boot.txt as well. > > Ok, I will update it as soon as the patch set is stabilized. It's been six weeks. Please send the upda

Re: Bcache v. whatever

2013-04-25 Thread Andrew Morton
On Mon, 14 Jan 2013 14:32:02 -0800 Kent Overstreet wrote: > Bcache: a block layer SSD cache sparc64 gcc-3.4.5: drivers/md/bcache/btree.c: In function `bch_btree_read': drivers/md/bcache/btree.c:266: error: invalid operands to binary + drivers/md/bcache/btree.c: In function `__btree_write': dri

Re: [PATCH V3 2/3] ARM: net: bpf_jit: make code generation less dependent on struct sk_filter.

2013-04-26 Thread Andrew Morton
On Fri, 26 Apr 2013 16:04:44 +0200 Arnd Bergmann wrote: > On Wednesday 24 April 2013 19:27:08 Nicolas Schichan wrote: > > @@ -858,7 +858,7 @@ b_epilogue: > > } > > > > > > -void bpf_jit_compile(struct sk_filter *fp) > > +static void __bpf_jit_compile(struct jit_ctx *out_ctx) > > { > >

Re: [PATCH 1/2] lib: Add lz4 compressor module

2013-04-26 Thread Andrew Morton
On Fri, 26 Apr 2013 15:51:05 +1000 Stephen Rothwell wrote: > Hi, > > On Fri, 26 Apr 2013 14:02:01 +0900 "Chanho Min" wrote: > > > > > > @@ -0,0 +1,23 @@ > > +#include > > + > > +int __attribute__((weak)) __clzsi2(int val) > > We have __weak in And lib/clz.c needs a few more includes, for

Re: [PATCH V3 2/3] ARM: net: bpf_jit: make code generation less dependent on struct sk_filter.

2013-04-26 Thread Andrew Morton
On Fri, 26 Apr 2013 21:47:46 +0200 Daniel Borkmann wrote: > On 04/26/2013 09:26 PM, Andrew Morton wrote: > > On Fri, 26 Apr 2013 16:04:44 +0200 Arnd Bergmann wrote: > >> On Wednesday 24 April 2013 19:27:08 Nicolas Schichan wrote: > >>>

Re: Bcache v. whatever

2013-04-26 Thread Andrew Morton
On Fri, 26 Apr 2013 12:46:42 -0700 Kent Overstreet wrote: > On Thu, Apr 25, 2013 at 04:17:04PM -0700, Andrew Morton wrote: > > On Mon, 14 Jan 2013 14:32:02 -0800 Kent Overstreet > > wrote: > > > ... > > drivers/md/bcache/btree.c: In function `bch_btree_refill_

Re: [PATCH 1/3] rapidio: make enumeration/discovery configurable

2013-04-26 Thread Andrew Morton
On Wed, 24 Apr 2013 10:31:57 -0400 Alexandre Bounine wrote: > Rework to implement RapidIO enumeration/discovery method selection > combined with ability to use enumeration/discovery as a kernel module. > > This patch adds ability to introduce new RapidIO enumeration/discovery methods > using ke

Re: [PATCH v2] aio: convert the ioctx list to radix tree

2013-04-11 Thread Andrew Morton
On Wed, 3 Apr 2013 16:20:48 +0300 Octavian Purdila wrote: > This patchs converts the ioctx list to a radix tree. This looks rather nice, but unfortunately all the pending aio work in -mm/linux-next totally messes it up. Could you please redo and retest it over the pending work? Perhaps after

Re: [PATCH] Sys V shared memory limited to 8TiB.

2013-04-11 Thread Andrew Morton
On Wed, 10 Apr 2013 21:42:23 -0500 Robin Holt wrote: > On Wed, Apr 10, 2013 at 04:15:07PM -0700, Andrew Morton wrote: > > On Tue, 9 Apr 2013 21:39:24 -0500 Robin Holt wrote: > > > > > Trying to run an application which was trying to put data into half > > > o

Re: [PATCH 1/5] clear_refs: Sanitize accepted commands declaration

2013-04-11 Thread Andrew Morton
On Thu, 11 Apr 2013 15:28:51 +0400 Pavel Emelyanov wrote: > A new clear-refs type will be added in the next patch, so prepare > code for that. > > @@ -730,7 +733,7 @@ static ssize_t clear_refs_write(struct file *file, const > char __user *buf, > char buffer[PROC_NUMBUF]; > struct mm

Re: [PATCH 4/5] pagemap: Introduce the /proc/PID/pagemap2 file

2013-04-11 Thread Andrew Morton
On Thu, 11 Apr 2013 15:29:41 +0400 Pavel Emelyanov wrote: > This file is the same as the pagemap one, but shows entries with bits > 55-60 being zero (reserved for future use). Next patch will occupy one > of them. I'm not understanding the motivation for this. What does the current /proc/pid/pa

Re: [PATCH 5/5] mm: Soft-dirty bits for user memory changes tracking

2013-04-11 Thread Andrew Morton
On Thu, 11 Apr 2013 15:30:00 +0400 Pavel Emelyanov wrote: > The soft-dirty is a bit on a PTE which helps to track which pages a task > writes to. In order to do this tracking one should > > 1. Clear soft-dirty bits from PTEs ("echo 4 > /proc/PID/clear_refs) > 2. Wait some time. > 3. Read s

Re: [PATCH] binfmt_elf: fix return value in case of interpreter load failure

2013-04-11 Thread Andrew Morton
On Thu, 11 Apr 2013 15:53:09 +0200 Matthieu CASTET wrote: > The current code return the address instead of using PTR_ERR. I don't understand what you mean here - please describe this error in much more detail. Help people to identify the section of code which is being discussed. > Also the ch

Re: [PATCH] nbd: increase default and max request sizes

2013-04-11 Thread Andrew Morton
On Tue, 2 Apr 2013 15:41:20 -0400 (EDT) Paul Clements wrote: > This patch raises the default max request size for nbd to 128KB (from 127KB) > to get it 4KB aligned. This patch also allows the max request size to be > increased (via /sys/block/nbd/queue/max_sectors_kb) to 32MB. > > The patch ma

Re: [PATCH] mm/mmap: Check for RLIMIT_AS before unmapping

2013-04-11 Thread Andrew Morton
On Tue, 2 Apr 2013 11:54:03 +0200 Cyril Hrubis wrote: > This patch fixes corner case for MAP_FIXED when requested mapping length > is larger than rlimit for virtual memory. In such case any overlapping > mappings are unmapped before we check for the limit and return ENOMEM. > > The check is move

Re: [PATCH 2/2] audit: remove unnecessary #if CONFIG_AUDIT

2013-04-15 Thread Andrew Morton
On Fri, 12 Apr 2013 17:34:21 +0800 Gao feng wrote: > The files include kernel/audit.h are complied only > when CONFIG_AUDIT is set. > > Just like audit_pid,there is no need to surround > audit_ever_enabled with CONFIG_AUDIT. > > Signed-off-by: Gao feng > --- > kernel/audit.h | 2 -- > 1 file

Re: [PATCH 5/5] mm: Soft-dirty bits for user memory changes tracking

2013-04-15 Thread Andrew Morton
On Fri, 12 Apr 2013 17:14:03 +0400 Pavel Emelyanov wrote: > On 04/12/2013 01:24 AM, Andrew Morton wrote: > > On Thu, 11 Apr 2013 15:30:00 +0400 Pavel Emelyanov > > wrote: > > > >> The soft-dirty is a bit on a PTE which helps to track which pages a task >

Re: [PATCH] binfmt_elf: fix return value in case of interpreter load failure

2013-04-15 Thread Andrew Morton
On Fri, 12 Apr 2013 16:49:50 +0200 Matthieu CASTET wrote: > Hi Andrew, > > thanks for your quick review. > > Andrew Morton a __crit : > > On Thu, 11 Apr 2013 15:53:09 +0200 Matthieu CASTET > > wrote: > > > >> The current code return the address

Re: New AIO API

2013-04-15 Thread Andrew Morton
On Fri, 12 Apr 2013 15:28:56 -0700 Kent Overstreet wrote: > So, awhile back I posted about an extensible AIO attributes mechanism > I'd been cooking up: http://article.gmane.org/gmane.linux.kernel/1367969 > > Since then, more uses for the thing have been popping up, but I ran into > a roadblock

Re: [PATCH v2] backlight: platform_lcd: introduce probe callback

2013-04-15 Thread Andrew Morton
On Thu, 11 Apr 2013 13:24:50 -0700 Andrew Bresticker wrote: > Platform LCD devices may need to do some device-specific > initialization before they can be used (regulator or GPIO setup, > for example), but currently the driver does not support any way of > doing this. This patch adds a probe()

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Andrew Morton
On Mon, 1 Apr 2013 03:47:42 + "Pan, Zhenjie" wrote: > Watchdog use performance monitor of cpu clock cycle to generate NMI to detect > hard lockup. > But when cpu's frequency changes, the event period will also change. > It's not as expected as the configuration. > For example, set the NMI ev

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Andrew Morton
On Tue, 16 Apr 2013 03:45:15 + "Pan, Zhenjie" wrote: > > Overall the patch looks desirable, but it increases the kernel size by > > several > > hundred bytes when CONFIG_CPU_FREQ=n. It should produce no code in > > this case! Take a look at the magic in register_hotcpu_notifier(), the way

Re: [RFC PATCH 0/2] return value from shrinkers

2013-05-16 Thread Andrew Morton
On Thu, 16 May 2013 09:52:05 +0200 Oskar Andero wrote: > > If we want the capability to return more than a binary yes/no message > > to callers then yes, we could/should enumerate the shrinker return > > values. But as that is a different concept from errnos, it should be > > done with a differ

Re: [PATCH -next] ashmem: Fix ashmem_shrink deadlock.

2013-05-16 Thread Andrew Morton
On Thu, 16 May 2013 09:44:49 -0400 Robert Love wrote: > On Thu, May 16, 2013 at 4:15 AM, Raul Xiong wrote: > > The issue happens in such sequence: > > ashmem_mmap acquired ashmem_mutex --> ashmem_mutex:shmem_file_setup > > called kmem_cache_alloc --> shrink due to low memory --> ashmem_shrink >

Re: [PATCH -next] ashmem: Fix ashmem_shrink deadlock.

2013-05-16 Thread Andrew Morton
On Thu, 16 May 2013 13:08:17 -0400 Robert Love wrote: > On Thu, May 16, 2013 at 12:45 PM, Andrew Morton > wrote: > > A better approach would be to add a new __GFP_NOSHRINKERS, but it's all > > variations on a theme. > > I don't like this proposal, eith

Re: [PATCH 3/4] mm: Activate !PageLRU pages on mark_page_accessed if page is on local pagevec

2013-05-20 Thread Andrew Morton
On Thu, 16 May 2013 14:41:04 +0100 Mel Gorman wrote: > On Wed, May 15, 2013 at 03:55:00PM -0700, Andrew Morton wrote: > > > @@ -441,8 +462,17 @@ void activate_page(struct page *page) > > > void mark_page_accessed(struct page *page) > > > { > > > if (!Pa

Re: mmotm 2013-05-09-15-57 uploaded

2013-05-20 Thread Andrew Morton
On Mon, 20 May 2013 11:42:09 +0200 Frederic Weisbecker wrote: > Hi Andrew, > > 2013/5/10 : > [...] > > * posix_cpu_timer-consolidate-expiry-time-type.patch > > * posix_cpu_timers-consolidate-timer-list-cleanups.patch > > * posix_cpu_timers-consolidate-expired-timers-check.patch > > * selftests

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-05-20 Thread Andrew Morton
On Mon, 29 Apr 2013 23:18:30 +0200 Philippe De Muyter wrote: > adding partitions/aix.h and partitions/aix.c > > Partitions (called Logical Volumes in AIX) can be non-contiguous or > even split on more than one disk. Altough we detect such partitions, > we cannot describe them to the Linux parti

Re: [PATCH 3/5] partitions/msdos: enumerate also AIX LVM partitions

2013-05-20 Thread Andrew Morton
On Mon, 29 Apr 2013 23:18:31 +0200 Philippe De Muyter wrote: > Graft AIX partitions enumeration in partitions/msdos.c > > There is already a AIX disks detection logic in msdos.c. When an > AIX disk has been found, and if configured to, call the aix partitions > recognizer. This avoids removal

Re: linux-next: manual merge of the akpm tree with the net-next tree

2013-05-21 Thread Andrew Morton
On Tue, 21 May 2013 14:29:48 +1000 Stephen Rothwell wrote: > Hi Andrew, > > Today's linux-next merge of the akpm tree got a conflict in > arch/arm/net/bpf_jit_32.c between commit aafc787e41fd ("arm: bpf_jit: can > call module_free() from any context") from the net-next tree and commit > "bpf: a

Re: [PATCH v2 1/2] Make the batch size of the percpu_counter configurable

2013-05-21 Thread Andrew Morton
On Fri, 3 May 2013 03:10:52 -0700 Tim Chen wrote: > Currently, there is a single, global, variable (percpu_counter_batch) that > controls the batch sizes for every 'struct percpu_counter' on the system. > > However, there are some applications, e.g. memory accounting where it is > more appropri

Re: [PATCH] cpu: Speedup disable_nonboot_cpus()

2013-05-21 Thread Andrew Morton
On Fri, 3 May 2013 17:35:44 -0500 Russ Anderson wrote: > The routine disable_nonboot_cpus() shuts down cpus sequentially > using for_each_online_cpu(cpu) to call cpu_down() one cpu at > a time. cpu_down() calls __stop_machine() which stops all > the cpus while it disables one. Then it re-enable

Re: [PATCH 3/4] rtc: rtc-hid-sensor-time: add option hctosys to set time at boot

2013-05-21 Thread Andrew Morton
On Sun, 5 May 2013 13:21:26 +0200 Alexander Holler wrote: > drivers/rtc/hctosys (CONFIG_RTC_HCTOSYS) doesn't work for > rtc-hid-sensor-time because it will be called in late_init, and thus before > rtc-hid-sensor-time gets loaded. To set the time through > rtc-hid-sensor-time at startup, the mo

Re: [PATCH]Add kmsg_dump() to kexec path

2013-05-21 Thread Andrew Morton
acks. Signed-off-by: Seiji Aguchi Signed-off-by: Andrew Morton --- fs/pstore/platform.c |4 include/linux/kmsg_dump.h |1 + kernel/kexec.c|2 ++ 3 files changed, 7 insertions(+) diff -puN fs/pstore/platform.c~add-kmsg_dump-to-kexec-path fs/pstore/platform.c --- a

Re: [PATCH]Add kmsg_dump() to kexec path

2013-05-21 Thread Andrew Morton
On Tue, 21 May 2013 15:47:41 -0700 "gre...@linuxfoundation.org" wrote: > On Tue, May 21, 2013 at 03:41:37PM -0700, Andrew Morton wrote: > > Guys, can we please get some review attention to this? > > I thought it was reviewed, and rejected, already. Did you miss those

Re: [PATCH v5 0/7] Per process reclaim

2013-05-21 Thread Andrew Morton
On Thu, 9 May 2013 16:21:22 +0900 Minchan Kim wrote: > These day, there are many platforms avaiable in the embedded market > and they are smarter than kernel which has very limited information > about working set so they want to involve memory management more heavily > like android's lowmemory k

<    9   10   11   12   13   14   15   16   17   18   >