Re: [PATCH v2 1/2] Make the batch size of the percpu_counter configurable

2013-05-21 Thread Andrew Morton
On Tue, 21 May 2013 16:27:29 -0700 Tim Chen wrote: > Will something like the following work if we get rid of the percpu > counter changes and use __percpu_counter_add(..., batch)? In > benchmark with a lot of memory changes via brk, this makes quite > a difference when we go to a bigger batch si

Re: [PATCH v5 6/7] mm: Support address range reclaim

2013-05-21 Thread Andrew Morton
On Thu, 9 May 2013 16:21:28 +0900 Minchan Kim wrote: > This patch adds address range reclaim of a process. > The requirement is following as, > > Like webkit1, it uses a address space for handling multi tabs. > IOW, it uses *one* process model so all tabs shares address space > of the process.

Re: linux-next: manual merge of the akpm tree with the net-next tree

2013-05-22 Thread Andrew Morton
On Wed, 22 May 2013 00:07:48 -0700 (PDT) David Miller wrote: > From: Andrew Morton > Date: Tue, 21 May 2013 13:04:38 -0700 > > > Nicolas, I think the patches need a re-check so I'll drop the versions > > which I presently have. Please refresh, retest and resend w

Re: [PATCH v2 1/2] Make the batch size of the percpu_counter configurable

2013-05-22 Thread Andrew Morton
On Tue, 21 May 2013 17:43:10 -0700 Tim Chen wrote: > > I'll spin off another version of the patch later to add the > memory-hotplug notifier. In the mean time, does the following looks > good to you? > > ... > > --- a/include/linux/mman.h > +++ b/include/linux/mman.h > @@ -10,12 +10,30 @@ > e

Re: [PATCH 01/14] do_mounts: constify name_to_dev_t parameter

2013-05-22 Thread Andrew Morton
On Thu, 9 May 2013 16:42:57 -0400 Joern Engel wrote: > --- a/include/linux/mount.h > +++ b/include/linux/mount.h > @@ -74,6 +74,6 @@ extern struct vfsmount *vfs_kern_mount(struct > file_system_type *type, > extern void mnt_set_expiry(struct vfsmount *mnt, struct list_head > *expiry_list); >

Re: [PATCH] mpt2sas/mpt3sas: prevent double free on error path

2013-05-22 Thread Andrew Morton
On Thu, 9 May 2013 16:42:58 -0400 Joern Engel wrote: > I noticed this one when list_del was called with poisoned list > pointers, but the real problem is a double-free (and a use-after-free > just before that). > > Both _scsih_probe_boot_devices() and _scsih_sas_device_add() put the > sas_devic

Re: [PATCH 06/14] bcon: add a release work struct

2013-05-22 Thread Andrew Morton
On Thu, 9 May 2013 16:43:04 -0400 Joern Engel wrote: > The final bcon_put() can be called from atomic context, by way of > bio_endio(). In that case we would sleep in invalidate_mapping_pages(), > with the usual unhappy results. > > In nearly a year of production use, I have only seen a matchi

Re: [PATCH 07/14] bcon: check for hdparm in bcon_tail

2013-05-22 Thread Andrew Morton
On Thu, 9 May 2013 16:43:05 -0400 Joern Engel wrote: > ... > > --- a/Documentation/block/blockconsole/bcon_tail > +++ b/Documentation/block/blockconsole/bcon_tail > @@ -14,6 +14,11 @@ if [ -z "$(which lsscsi)" ]; then > exit 1 > fi > > +if [ -z "$(which hdparm)" ]; then > + echo "Yo

Re: [PATCH 09/14] bcon: remove version 1.0 support

2013-05-22 Thread Andrew Morton
On Thu, 9 May 2013 16:43:07 -0400 Joern Engel wrote: > Very few machines ever ran with 1.0 format and by now I doubt whether a > single one still does. No need to carry that code along. aw geeze. Can we please clean up the patch series? -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 02/14] add blockconsole version 1.1

2013-05-22 Thread Andrew Morton
On Thu, 9 May 2013 16:43:00 -0400 Joern Engel wrote: > Console driver similar to netconsole, except it writes to a block > device. Can be useful in a setup where netconsole, for whatever > reasons, is impractical. It would be useful to provide a description of how the code works. How it avoid

Re: [PATCH] kernel/auditfilter.c: need process 'tree' when audit_add_watch() failed in audit_add_rule().

2013-05-22 Thread Andrew Morton
On Fri, 10 May 2013 18:12:26 +0800 Chen Gang wrote: > > If both 'tree' and 'watch' are valid, need call audit_put_tree(), just > like the upper area has done within function audit_add_rule(). > > Signed-off-by: Chen Gang > --- > kernel/auditfilter.c |6 ++ > 1 files changed, 6 inserti

Re: [PATCH 09/14] bcon: remove version 1.0 support

2013-05-22 Thread Andrew Morton
On Wed, 22 May 2013 15:51:09 -0400 J__rn Engel wrote: > On Wed, 22 May 2013 13:48:37 -0700, Andrew Morton wrote: > > On Thu, 9 May 2013 16:43:07 -0400 Joern Engel wrote: > > > > > Very few machines ever ran with 1.0 format and by now I doubt whether a > > > s

Re: [PATCH] rtc: add in ability to push out an existing wakealarm using sysfs

2013-05-22 Thread Andrew Morton
On Fri, 10 May 2013 17:53:31 -0700 Bernie Thompson wrote: > This adds in the ability for the rtc sysfs code to handle += characters > at the beginning of a wakealarm setting string. This will allow the user to > attempt to push out an existing wakealarm by a provided amount. > > In the case tha

Re: [PATCH] rtc: add in ability to push out an existing wakealarm using sysfs

2013-05-22 Thread Andrew Morton
On Wed, 22 May 2013 15:05:44 -0700 Bernie Thompson wrote: > On Wed, May 22, 2013 at 2:55 PM, Andrew Morton > wrote: > > > > On Fri, 10 May 2013 17:53:31 -0700 Bernie Thompson > > wrote: > > > > > This adds in the ability for the rtc sysfs code to hand

Re: [PATCH] rtc: tps6586x: device wakeup flags correction

2013-05-22 Thread Andrew Morton
On Sun, 12 May 2013 18:25:06 +0400 Dmitry Osipenko wrote: > Use device_init_wakeup() instead of device_set_wakeup_capable() and move it > before rtc dev registering. This fixes issue with alarmtimer that checks > wakeup > capability with device_may_wakeup() on device add. Well OK, but what is t

Re: [PATCH 02/14] add blockconsole version 1.1

2013-05-22 Thread Andrew Morton
On Wed, 22 May 2013 17:04:16 -0400 J__rn Engel wrote: > > > Documentation/block/blockconsole.txt| 94 > > > Documentation/block/blockconsole/bcon_tail | 62 +++ > > > Documentation/block/blockconsole/mkblockconsole | 29 ++ > > > > We really need somewhere better to p

Re: [PATCH v8 2/9] vmcore: allocate buffer for ELF headers on page-size alignment

2013-05-23 Thread Andrew Morton
On Thu, 23 May 2013 14:25:07 +0900 HATAYAMA Daisuke wrote: > Allocate ELF headers on page-size boundary using __get_free_pages() > instead of kmalloc(). > > Later patch will merge PT_NOTE entries into a single unique one and > decrease the buffer size actually used. Keep original buffer size in

Re: [PATCH v8 3/9] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list

2013-05-23 Thread Andrew Morton
On Thu, 23 May 2013 14:25:13 +0900 HATAYAMA Daisuke wrote: > Treat memory chunks referenced by PT_LOAD program header entries in > page-size boundary in vmcore_list. Formally, for each range [start, > end], we set up the corresponding vmcore object in vmcore_list to > [rounddown(start, PAGE_SIZE

Re: [PATCH v8 5/9] vmalloc: introduce remap_vmalloc_range_partial

2013-05-23 Thread Andrew Morton
uaddr = vma->vm_start; > - unsigned long usize = vma->vm_end - vma->vm_start; > > - if ((PAGE_SIZE-1) & (unsigned long)addr) > + size = PAGE_ALIGN(size); > + > + if (((PAGE_SIZE-1) & (unsigned long)uaddr) || > + ((PAGE_SIZE-1) & (unsigned lon

Re: [PATCH v8 6/9] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory

2013-05-23 Thread Andrew Morton
r.p_type= PT_NOTE; > phdr.p_flags = 0; > note_off = sizeof(Elf64_Ehdr) + > (ehdr_ptr->e_phnum - nr_ptnote +1) * sizeof(Elf64_Phdr); > - phdr.p_offset = note_off; > + phdr.p_offset = roundup(note_off, PAGE_SIZE); > phdr.p_vadd

Re: [PATCH v8 9/9] vmcore: support mmap() on /proc/vmcore

2013-05-23 Thread Andrew Morton
pfn, is of 32-bit length on x86-32: unsigned long. More reviewing and testing, please. From: Andrew Morton Subject: vmcore-support-mmap-on-proc-vmcore-fix use min(), switch to conventional error-unwinding approach Cc: Atsushi Kumagai Cc: HATAYAMA Daisuke Cc: KOSAKI Motohiro Cc: Lisa Mi

Re: [Suggestion] fs/namespace.c: the direct cause of the warning for: "ida_remove called for id=0 which is not allocated" with mnt_release_group_id()

2013-05-23 Thread Andrew Morton
nel warning at ida_remove() spewing a message like: ida_remove called for id=0 which is not allocated. This patch fixes the bug simply checking the group id in the caller. Signed-off-by: Takashi Iwai Reported-by: Cristian Rodríguez Cc: Al Viro Signed-off-by: Andrew Morton --- fs/pnode.c |

Re: [PATCH] msm: iommu: fix leak and invalid access

2013-05-23 Thread Andrew Morton
ssful The code's OK at present - kfree(NULL) is legal. However I suppose the patch cleans things up a little bit, however it missed a couple of things: From: Andrew Morton Subject: drivers-iommu-msm_iommu_devc-fix-leak-and-invalid-access-fix remove now-unneeded initialization of ctx_dr

Re: [PATCH v3] mm/pagewalk.c: walk_page_range should avoid VM_PFNMAP areas

2013-05-23 Thread Andrew Morton
On Wed, 15 May 2013 07:46:36 -0500 Cliff Wickman wrote: > Certain tests in walk_page_range() (specifically split_huge_page_pmd()) > assume that all the mapped PFN's are backed with page structures. And this is > not usually true for VM_PFNMAP areas. This can result in panics on kernel > page faul

Re: [PATCH 5/6] coredump: kill call_count, add core_name_size

2013-05-24 Thread Andrew Morton
On Wed, 15 May 2013 22:12:32 +0200 Oleg Nesterov wrote: > Imho, "atomic_t call_count" is ugly and should die. It buys > nothing and in fact it can grow more than necessary, expand > doesn't check if it was already incremented by another task. > > Kill it, and introduce "static int core_name_size

Re: [PATCH 04/11] ipc: move locking out of ipcctl_pre_down_nolock

2013-05-24 Thread Andrew Morton
On Wed, 15 May 2013 18:08:03 -0700 Davidlohr Bueso wrote: > This function currently acquires both the rw_mutex and the rcu lock on > successful lookups, leaving the callers to explicitly unlock them, creating > another two level locking situation. > > Make the callers (including those that stil

Re: [PATCH 1/2] backlight: add devm_backlight_device_{register,unregister}()

2013-05-24 Thread Andrew Morton
On Thu, 16 May 2013 05:28:26 + (GMT) Jingoo Han wrote: > These functions allow the driver core to automatically clean up any > allocation made by backlight drivers. Thus it simplifies the error > paths. > > ... > > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/bac

Re: [PATCH 04/11] ipc: move locking out of ipcctl_pre_down_nolock

2013-05-24 Thread Andrew Morton
On Fri, 24 May 2013 15:21:36 -0700 Davidlohr Bueso wrote: > > > > Where should readers go to understand the overall locking scheme? A > > description of the overall object hierarchy and the role which the > > various locks play? > > That can be done, how about something like > Documentation/i

Re: [PATCHv12 2/4] zbud: add to mm/

2013-05-28 Thread Andrew Morton
On Mon, 20 May 2013 11:26:06 -0500 Seth Jennings wrote: > zbud is an special purpose allocator for storing compressed pages. It is > designed to store up to two compressed pages per physical page. While this > design limits storage density, it has simple and deterministic reclaim > properties t

Re: [PATCHv12 3/4] zswap: add to mm/

2013-05-28 Thread Andrew Morton
On Mon, 20 May 2013 11:26:07 -0500 Seth Jennings wrote: > zswap is a thin backend for frontswap that takes pages that are in the process > of being swapped out and attempts to compress them and store them in a > RAM-based memory pool. This can result in a significant I/O reduction on the > swap

Re: [PATCH] memcg: don't initialize kmem-cache destroying work for root caches

2013-05-28 Thread Andrew Morton
On Tue, 14 May 2013 16:38:38 +0400 Andrey Vagin wrote: > struct memcg_cache_params has a union. Different parts of this union are > used for root and non-root caches. A part with destroying work is used only > for non-root caches. That union is a bit dangerous. Perhaps it would be better to do

Re: [PATCH] UAPI: Remove empty Kbuild files

2013-03-26 Thread Andrew Morton
On Tue, 26 Mar 2013 20:59:43 + David Howells wrote: > Andrew Morton wrote: > > > > Remove empty Kbuild files as they cause problems with the patch program > > > which removes files that become empty. > > > > > > Should I also remove include/K

Re: linux-next: build warning after merge of the final tree (akpm and block tree related)

2013-03-26 Thread Andrew Morton
On Wed, 27 Mar 2013 08:35:35 +1100 Stephen Rothwell wrote: > Hi Guys, > > On Tue, 26 Mar 2013 13:10:51 -0700 Andrew Morton > wrote: > > > > On Tue, 26 Mar 2013 12:55:23 -0700 Kent Overstreet > > wrote: > > > > > On Tue, Mar 26, 201

Re: [PATCH 2/2] timer_list: convert timer list to be a proper seq_file

2013-03-27 Thread Andrew Morton
On Tue, 26 Mar 2013 19:56:30 -0500 Nathan Zimmer wrote: > When running with 4096 cores attemping to read /proc/timer_list will fail > with an ENOMEM condition. On a sufficantly large systems the total amount > of data is more then 4mb, so it won't fit into a single buffer. The > failure can als

Re: [PATCH v2 0/6] idr: add idr_alloc_cyclic and convert existing cyclic users

2013-03-27 Thread Andrew Morton
On Wed, 27 Mar 2013 12:38:47 -0700 Tejun Heo wrote: > On Wed, Mar 27, 2013 at 03:29:32PM -0400, Jeff Layton wrote: > > (Andrew, I think this is probably best routed via -mm since it touches > > several different places) > > Yeap, I think it'd be best to route these through -mm. > > Please feel

Re: [PATCH v6 1/2] mm: limit growth of 3% hardcoded other user reserve

2013-03-27 Thread Andrew Morton
On Mon, 18 Mar 2013 17:44:42 -0400 Andrew Shewmaker wrote: > Add user_reserve_kbytes knob. > > Limit the growth of the memory reserved for other user > processes to min(3% current process size, user_reserve_pages). > > user_reserve_pages defaults to min(3% free pages, 128MB) That was an epic c

Re: [PATCH v9 RESEND 2/4] misc: Generic on-chip SRAM allocation driver

2013-03-27 Thread Andrew Morton
> + } > + > + platform_set_drvdata(pdev, sram); > + > + dev_dbg(&pdev->dev, "SRAM pool: %ld KiB @ 0x%p\n", size / 1024, > virt_base); > + > + return 0; > +} > > ... > > +int __init sram_init(void) > +{ > + return platform_dr

Re: [PATCH v9 RESEND 4/4] ARM: dts: add sram for imx53 and imx6q

2013-03-27 Thread Andrew Morton
On Wed, 20 Mar 2013 11:52:47 +0100 Philipp Zabel wrote: > Signed-off-by: Philipp Zabel > Reviewed-by: Shawn Guo > Acked-by: Grant Likely > --- > Changes since v8: > - Changed device tree compatible string to "mmio-sram" > --- > arch/arm/boot/dts/imx53.dtsi |5 + > arch/arm/boot/dts/i

Re: [PATCH] sysrq: allow user trigger sysrq by upper-case character key

2013-03-06 Thread Andrew Morton
On Wed, 6 Mar 2013 12:07:34 +0800 "zhangwei(Jovi)" wrote: > See the help text output of /proc/sysrq-trigger: > >SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E) >memory-full-oom-kill(F) kill-all-tasks(I) ... > > Most command is referenced by responding upper-case charac

Re: [PATCH resend] rmap: recompute pgoff for unmapping huge page

2013-03-06 Thread Andrew Morton
On Mon, 4 Mar 2013 20:47:31 +0800 Hillf Danton wrote: > [Resend due to error in delivering to linux-kernel@vger.kernel.org, > caused probably by the rich format provided by the mail agent by default.] > > We have to recompute pgoff if the given page is huge, since result based on > HPAGE_SIZE is

Re: [PATCH resend] rmap: recompute pgoff for unmapping huge page

2013-03-06 Thread Andrew Morton
On Mon, 4 Mar 2013 20:47:31 +0800 Hillf Danton wrote: > [Resend due to error in delivering to linux-kernel@vger.kernel.org, > caused probably by the rich format provided by the mail agent by default.] > > We have to recompute pgoff if the given page is huge, since result based on > HPAGE_SIZE is

Re: [PATCH] epoll: trim epitem by one cache line on x86_64

2013-03-06 Thread Andrew Morton
On Mon, 4 Mar 2013 11:29:41 + Eric Wong wrote: > It is common for epoll users to have thousands of epitems, so saving a > cache line on every allocation leads to large memory savings. > > Since epitem allocations are cache-aligned, reducing sizeof(struct > epitem) from 136 bytes to 128 bytes

Re: linux-next: build failure after merge of the final tree (akpm tree related)

2013-03-06 Thread Andrew Morton
On Mon, 4 Mar 2013 14:10:51 +1100 Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (sparc64 defconfig) > failed like this: > > arch/sparc/built-in.o: In function `setup_arch': > (.init.text+0xc38): undefined reference to `early_console' > arch/sparc/

Re: + memblock-add-assertion-for-zero-allocation-alignment.patch added to -mm tree

2013-03-06 Thread Andrew Morton
On Wed, 6 Mar 2013 16:07:20 -0800 Yinghai Lu wrote: > > --- a/mm/memblock.c~memblock-add-assertion-for-zero-allocation-alignment > > +++ a/mm/memblock.c > > @@ -771,6 +771,9 @@ static phys_addr_t __init memblock_alloc > > { > > phys_addr_t found; > > > > + if (WARN_ON(!align)) > >

Re: [PATCH] Prevent use of unitialized variable

2013-03-06 Thread Andrew Morton
On Mon, 4 Mar 2013 00:42:49 +0100 Fredrik Gustafsson wrote: > Run checkpatch.pl -f kernel/fork.c in commit > ecf02a607bd801e742d7bb35c6e40f7ca15edf03 > and checkpatch.pl will try to use an uninitialized variable. > This patch fixes that. > This isn't a good description of the problem you're se

Re: [PATCH v2] early_printk: consolidate random copies of identical code

2013-03-07 Thread Andrew Morton
On Thu, 7 Mar 2013 14:15:54 -0500 Paul Gortmaker wrote: > [v2: essentially unchanged since v1, so I've left the acked/reviewed > tags. There was a compile fail[1] for a randconfig with EARLY_PRINTK=y > and PRINTK=n, because the early_console struct and early_printk calls > were nested within

Re: [PATCH v2] early_printk: consolidate random copies of identical code

2013-03-07 Thread Andrew Morton
On Thu, 7 Mar 2013 14:50:23 -0500 Paul Gortmaker wrote: > This brings up a recurring question. I was tempted to just go make > CONFIG_EARLY_PRINTK depend on CONFIG_PRINTK, but lately I've faced > pushback when trying to "fix" things like seeing ARM OMAP USB options > for an x86 build[1], and GO

Re: [PATCH v2] early_printk: consolidate random copies of identical code

2013-03-07 Thread Andrew Morton
On Thu, 7 Mar 2013 22:25:48 +0100 (CET) Thomas Gleixner wrote: > > diff --git a/kernel/printk.c b/kernel/printk.c > > index 7664e49..86799bf 100644 > > --- a/kernel/printk.c > > +++ b/kernel/printk.c > > @@ -120,6 +120,7 @@ struct console_cmdline > > static struct console_cmdline console_cmdlin

Re: [PATCH v2] early_printk: consolidate random copies of identical code

2013-03-07 Thread Andrew Morton
On Thu, 7 Mar 2013 19:49:35 -0500 Paul Gortmaker wrote: > > otoh, offering useless stuff to non-kernel-developers has downsides > > with no balancing benefit, and we really should optimise things for > > our users because there are so many more of them than there are of us. > > Glad to hear tha

Re: [PATCH 04/14] x86, ACPI: make acpi override finding work with 32bit flat mode

2013-03-07 Thread Andrew Morton
On Thu, 7 Mar 2013 22:57:21 -0800 Yinghai Lu wrote: > > > >> @@ -552,38 +552,47 @@ u8 __init acpi_table_checksum(u8 *buffer, u32 length) > >> return sum; > >> } > >> > >> -/* All but ACPI_SIG_RSDP and ACPI_SIG_FACS: */ > >> -static const char * const table_sigs[] = { > >> - ACPI_SIG_BE

Re: [PATCH 1/3] coredump: introduce dump_interrupted()

2013-03-08 Thread Andrew Morton
On Fri, 8 Mar 2013 18:59:15 +0100 Oleg Nesterov wrote: > Change dump_write(), dump_seek() and do_coredump() to check > signal_pending() and abort if it is true. hm, why. I think we're missing some context here - this is to support freezing, yes? There's some undescribed interaction between the

Re: [PATCH 2/2] mm: remove_memory: Fix end_pfn setting

2013-03-08 Thread Andrew Morton
On Fri, 8 Mar 2013 08:41:41 -0700 Toshi Kani wrote: > remove_memory() calls walk_memory_range() with [start_pfn, end_pfn), > where end_pfn is exclusive in this range. Therefore, end_pfn needs > to be set to the next page of the end address. > > ... > > --- a/mm/memory_hotplug.c > +++ b/mm/memo

Re: [PATCH v3] early_printk: consolidate random copies of identical code

2013-03-08 Thread Andrew Morton
On Fri, 8 Mar 2013 11:11:20 -0500 Paul Gortmaker wrote: > The early console implementations are the same all over the place. Move > the print function to kernel/printk and get rid of the copies. > > ... > > [v3: drop sparc bits as suggested by tglx, redo build tests on sparc > sparc32, Randy

Re: [PATCH v2] init: Scream bloody murder if interrupts are enabled too early

2013-03-08 Thread Andrew Morton
On Fri, 08 Mar 2013 09:48:12 -0500 Steven Rostedt wrote: > Also, while examining other warnings in init/main.c, I found two other > locations that deserve a bloody murder scream if their conditions are > hit, and updated them accordingly. So the whole effect of this patch is to spew a larger vol

Re: [PATCH v3] fat: editions to support fat_fallocate

2013-03-08 Thread Andrew Morton
On Thu, 7 Mar 2013 22:56:57 +0900 Namjae Jeon wrote: > From: Namjae Jeon > > Implement preallocation via the fallocate syscall on VFAT partitions. > > Change Log: > v3: Release preallocated blocks at file release. > > With FALLOC_FL_KEEP_SIZE, there is no way to distinguish if the mismatch >

Re: [PATCH] epoll: trim epitem by one cache line on x86_64

2013-03-08 Thread Andrew Morton
On Thu, 7 Mar 2013 10:32:40 + Eric Wong wrote: > Andrew Morton wrote: > > It's going to be hard to maintain this - someone will change something > > sometime and break it. I suppose we could add a runtime check if we > > cared enough. Adding a big fat comment t

Re: Suggestion for fixing the variable length array used in the kernel.

2013-03-08 Thread Andrew Morton
On Wed, 6 Mar 2013 20:46:35 -0800 Christopher Li wrote: > Hi, > > I am looking at the current sparse warning on the kernel source. > One category of those warning are produce by the variable length array. > We all know that the kernel stack has a limit so we don't want to allocate > too much sta

Re: [PATCH -mmotm] scsi: fix the wrong position of the comment

2013-03-10 Thread Andrew Morton
On Sun, 10 Mar 2013 08:22:47 + James Bottomley wrote: > [missing SCSI cc added] > On Sun, 2013-03-10 at 17:09 +0900, Akinobu Mita wrote: > > This fixes the wrong position of the comment introduced by > > scsi-rename-random32-to-prandom_u32.patch in the -mm tree. > > > > Signed-off-by: Akino

Re: + signal-always-clear-sa_restorer-on-execve.patch added to -mm tree

2013-03-11 Thread Andrew Morton
On Mon, 11 Mar 2013 13:37:53 -0700 Kees Cook wrote: > ... > (pop toasting undone) > > Subject: signal: always clear sa_restorer on execve > > > > When the new signal handlers are set up, the location of sa_restorer is > > not cleared, leaking a parent process's address space location to > > chi

Re: [PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-11 Thread Andrew Morton
On Mon, 11 Mar 2013 14:02:11 -0700 Greg KH wrote: > On Thu, Mar 07, 2013 at 03:59:09PM +1100, James Morris wrote: > > On Wed, 6 Mar 2013, David Howells wrote: > > > > > Reported-by: Mateusz Guzik > > > Signed-off-by: David Howells > > > > Acked-by: James Morris > > What happened to this pat

Re: + signal-always-clear-sa_restorer-on-execve.patch added to -mm tree

2013-03-11 Thread Andrew Morton
On Mon, 11 Mar 2013 14:03:20 -0700 Kees Cook wrote: > On Mon, Mar 11, 2013 at 2:01 PM, Andrew Morton > wrote: > > On Mon, 11 Mar 2013 13:37:53 -0700 Kees Cook wrote: > > > >> ... > >> > > > > (pop toasting undone) > > >

Re: + signal-always-clear-sa_restorer-on-execve.patch added to -mm tree

2013-03-11 Thread Andrew Morton
On Mon, 11 Mar 2013 14:33:18 -0700 Kees Cook wrote: > > patch #1: use SA_RESTORER, cc stable (please promise me this will work OK) > > I don't have the ability to build all the architectures, but it seems > like the best flag based on code review. SA_RESTORER looks OK back to 3.5 (at least). >

Re: [PATCH 1/1] kernel/pid.c: Improve flow of a loop inside alloc_pidmap.

2013-03-11 Thread Andrew Morton
On Mon, 11 Mar 2013 18:18:56 -0300 "Raphael S. Carvalho" wrote: > From: Raphael S.Carvalho > > Notes: find_next_offset searches for an available "cleaned bit" > in the respective pid bitmap (page), so returns the offset if found, > otherwise it returns a value equals to BITS_PER_PAGE. > > For

Re: [PATCH] backlight: l4f00242t03: check return value of regulator_enable()

2013-03-11 Thread Andrew Morton
On Mon, 11 Mar 2013 12:58:41 +0900 Jingoo Han wrote: > The regulator_enable() was marked as as __must_check, therefore, > the return value of regulator_enable() should be checked. > Also, this patch checks return value of regulator_set_voltage(). > > Signed-off-by: Jingoo Han > --- > drivers/v

Re: [PATCH 4/9] mm: use mm_populate() for blocking remap_file_pages()

2013-03-11 Thread Andrew Morton
pointer dereference > at 0050 > > ... > > > + vm_flags = vma->vm_flags; > > When find_vma() fails, vma is NULL here. Yup, thanks. This, methinks: From: Andrew Morton Subject: mm/fremap.c: fix oops on error path If find_vma() fails, sys_remap_file_

Re: [PATCH] atomic: improve atomic_inc_unless_negative/atomic_dec_unless_positive

2013-03-11 Thread Andrew Morton
On Sat, 9 Mar 2013 23:38:21 +0800 Ming Lei wrote: > Generally, both atomic_inc_unless_negative() and > atomic_dec_unless_positive() need at least two atomic_cmpxchg() > to complete the atomic operation. In fact, the 1st atomic_cmpxchg() > is just used to read current value of the atomic variable

Re: [PATCH 1/2] Moved core dump functionality into its own file

2012-08-01 Thread Andrew Morton
On Tue, 31 Jul 2012 19:23:59 -0700 Alex Kelly wrote: > This was done in preparation for making core dump functionality optional. > > The variable "suid_dumpable" and associated functions are left in fs/exec.c > because they're used elsewhere, such as in ptrace. This patch will need to be redone

Re: An Andre To Remember

2012-08-01 Thread Andrew Morton
On Fri, 27 Jul 2012 13:56:55 -0400 Jeff Garzik wrote: > Rest in peace Andre, He was a nice guy, and sure did like to talk on the phone. He was very active and popular in the local Porsche enthusiast community and is remember for his generosity. People share memories here: http://forums.rennlis

Re: [PATCH 2/5] mempolicy: Remove mempolicy sharing

2012-08-22 Thread Andrew Morton
On Mon, 20 Aug 2012 17:36:31 +0100 Mel Gorman wrote: > From: KOSAKI Motohiro > > Dave Jones' system call fuzz testing tool "trinity" triggered the following > bug error with slab debugging enabled > > ... > > Cc: The patch dosn't apply to 3.5 at all well. I don't see much point in retaining

Re: [PATCH] mm: mmu_notifier: fix inconsistent memory between secondary MMU and host

2012-08-22 Thread Andrew Morton
On Wed, 22 Aug 2012 18:29:55 +0200 Andrea Arcangeli wrote: > On Wed, Aug 22, 2012 at 02:03:41PM +0800, Xiao Guangrong wrote: > > On 08/21/2012 11:06 PM, Andrea Arcangeli wrote: > > > CPU0 CPU1 > > > oldpage[1] == 0 (both guest & host) > > > o

Re: [PATCH] mm: mmu_notifier: fix inconsistent memory between secondary MMU and host

2012-08-22 Thread Andrew Morton
On Wed, 22 Aug 2012 21:50:43 +0200 Andrea Arcangeli wrote: > Hi Andrew, > > On Wed, Aug 22, 2012 at 12:15:35PM -0700, Andrew Morton wrote: > > On Wed, 22 Aug 2012 18:29:55 +0200 > > Andrea Arcangeli wrote: > > > > > On Wed, Aug 22, 2012 at 02:03:41PM +0800,

Re: [PATCH, RFC] Remove fasync() BKL usage, take 3325

2012-08-23 Thread Andrew Morton
On Fri, 23 Jan 2009 05:56:46 +0100 Andi Kleen wrote: > On Thu, Jan 22, 2009 at 03:32:49PM -0500, Christoph Hellwig wrote: > > On Thu, Jan 22, 2009 at 06:51:04AM -0800, Andrew Morton wrote: > > > OK, replacing a lock_kernel() with a spin_lock(&global_lock) is pretty >

Re: [PATCH] rapidio/tsi721: modify mport name assignment

2012-08-24 Thread Andrew Morton
On Tue, 21 Aug 2012 10:23:54 -0400 Alexandre Bounine wrote: > Modify mport device name assignment to provide clear reference to devices > in systems with multiple Tsi721 bridges. > > This patch is applicable to kernel versions starting from v3.2. This seems to imply that you think the patch sho

Re: [PATCH] rapidio: apply RX/TX enable to active switch ports only

2012-08-24 Thread Andrew Morton
On Tue, 21 Aug 2012 10:23:55 -0400 Alexandre Bounine wrote: > Modify RIO enumeration to apply RX/TX enable operations only to active > switch ports. This will leave inactive ports in condition consistent with > their state. It's unclear (to me) what the effects of this are. Does it fix some use

Re: [PATCH 01/14] aoe: for performance support larger packet payloads

2012-08-24 Thread Andrew Morton
On Fri, 17 Aug 2012 21:18:37 -0400 Ed Cashin wrote: > --- a/drivers/block/aoe/aoeblk.c > +++ b/drivers/block/aoe/aoeblk.c > @@ -279,6 +279,9 @@ aoeblk_gdalloc(void *vp) > if (bdi_init(&d->blkq->backing_dev_info)) > goto err_blkq; > spin_lock_irqsave(&d->lock, flags); > +

Re: [PATCH 02/14] aoe: kernel thread handles I/O completions for simple locking

2012-08-24 Thread Andrew Morton
On Fri, 17 Aug 2012 21:24:08 -0400 Ed Cashin wrote: > This patch makes the frames the aoe driver uses to track the > relationship between bios and packets more flexible and detached, so > that they can be passed to an "aoe_ktio" thread for completion of I/O. > > The frames are handled much like

Re: [PATCH 1/2] mm/mmu_notifier: init notifier if necessary

2012-08-24 Thread Andrew Morton
On Fri, 24 Aug 2012 22:37:55 +0800 Wanpeng Li wrote: > From: Gavin Shan > > While registering MMU notifier, new instance of MMU notifier_mm will > be allocated and later free'd if currrent mm_struct's MMU notifier_mm > has been initialized. That cause some overhead. The patch tries to > elemina

Re: [PATCH v2] mm: hugetlb: add arch hook for clearing page flags before entering pool

2012-08-24 Thread Andrew Morton
On Thu, 23 Aug 2012 18:36:02 +0100 Will Deacon wrote: > On Thu, Aug 23, 2012 at 06:11:56PM +0100, Michal Hocko wrote: > > On Thu 23-08-12 17:37:13, Will Deacon wrote: > > > The core page allocator ensures that page flags are zeroed when freeing > > > pages via free_pages_check. A number of archit

Re: [PATCH v2] fork: fix oops after fork failure

2012-08-24 Thread Andrew Morton
On Thu, 23 Aug 2012 19:36:08 +0400 Glauber Costa wrote: > When we want to duplicate a new process, dup_task_struct() will undergo > a series of allocations. If alloc_thread_info_node() fails, we call > free_task_struct() and return. > > This seems right, but it is not. free_task_struct() will no

Re: [PATCH 1/1] backlight: Add Backlight driver for lm3630 chip

2012-08-24 Thread Andrew Morton
On Fri, 24 Aug 2012 14:03:23 +0900 GShark Jeong wrote: > I've reviewed and tested you patch ( lm3630 and lm3639) on my real board > and these are working well . > Thank you. Great, thanks. > ( Do I need to send back this patch to you again? or will the current > status be applied for next bran

Re: [PATCH v10 0/5] make balloon pages movable by compaction

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:15 -0300 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > transparen

Re: [PATCH v10 1/5] mm: introduce a common interface for balloon pages mobility

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:16 -0300 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > transparen

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:18 -0300 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > transparen

Re: blk, mm: lockdep irq lock inversion in linux-next

2012-09-17 Thread Andrew Morton
) just enabled local interrupts while we're holding ->tree_lock, which is supposed to be an irq-save lock. And in a rather obscure way, lockdep caught it. Problem is, I cannot find any recent change which might have triggered this. I don't know how repeatable this is for you (not ve

Re: [PATCH 2/3] mm: thp: Fix the update_mmu_cache() last argument passing in mm/huge_memory.c

2012-09-18 Thread Andrew Morton
On Sat, 15 Sep 2012 15:38:33 +0200 Ralf Baechle wrote: > On Tue, Sep 11, 2012 at 05:47:15PM +0100, Will Deacon wrote: > > > The update_mmu_cache() takes a pointer (to pte_t by default) as the last > > argument but the huge_memory.c passes a pmd_t value. The patch changes > > the argument to the

Re: qemu-kvm loops after kernel udpate

2012-09-18 Thread Andrew Morton
On Tue, 18 Sep 2012 21:40:31 +0200 Jiri Slaby wrote: > On 09/13/2012 11:59 AM, Avi Kivity wrote: > > On 09/12/2012 09:11 PM, Jiri Slaby wrote: > >> On 09/12/2012 10:18 AM, Avi Kivity wrote: > >>> On 09/12/2012 11:13 AM, Jiri Slaby wrote: > > > Please provide the output of vmxcap >

Re: section mismatch for acpi_unmap_lsapic()

2012-09-18 Thread Andrew Morton
On Tue, 18 Sep 2012 09:40:51 +0800 Wen Congyang wrote: > At 09/17/2012 07:07 PM, Ingo Molnar Wrote: > > > > * Jerry Snitselaar wrote: > > > >> Commit 13ad20c1 "x86 cpu_hotplug: unmap cpu2node when the cpu is > >> hotremoved" in linux-next added code to acpi_unmap_lsapic() that > >> causes sect

Re: [patch] mm, numa: reclaim from all nodes within reclaim distance

2012-09-18 Thread Andrew Morton
On Tue, 18 Sep 2012 00:03:57 -0700 (PDT) David Rientjes wrote: > RECLAIM_DISTANCE represents the distance between nodes at which it is > deemed too costly to allocate from; it's preferred to try to reclaim from > a local zone before falling back to allocating on a remote node with such > a distan

Re: [PATCH v10 1/5] mm: introduce a common interface for balloon pages mobility

2012-09-18 Thread Andrew Morton
On Tue, 18 Sep 2012 13:24:21 -0300 Rafael Aquini wrote: > On Mon, Sep 17, 2012 at 03:15:43PM -0700, Andrew Morton wrote: > > > +/* return code to identify when a ballooned page has been migrated */ > > > +#define BALLOON_MIGRATION_RETURN 0xba1100 > > > > I d

Re: qemu-kvm loops after kernel udpate

2012-09-18 Thread Andrew Morton
On Wed, 19 Sep 2012 10:00:34 +1000 Stephen Rothwell wrote: > Hi Andrew, > > On Tue, 18 Sep 2012 12:46:46 -0700 Andrew Morton > wrote: > > > > hm, thanks. This will probably take some time to resolve so I think > > I'll drop > > > > mm-move-

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-19 Thread Andrew Morton
On Wed, 19 Sep 2012 16:19:02 +0300 Maxim Levitsky wrote: > Based partially on MS standard spec quotes from Alex Dubov. > > As any code that works with user data this driver isn't > recommended to use to write cards that contain valuable data. > > It tries its best though to avoid data corruptio

Re: [patch] mm, numa: reclaim from all nodes within reclaim distance

2012-09-19 Thread Andrew Morton
On Tue, 18 Sep 2012 00:03:57 -0700 (PDT) David Rientjes wrote: > RECLAIM_DISTANCE represents the distance between nodes at which it is > deemed too costly to allocate from; it's preferred to try to reclaim from > a local zone before falling back to allocating on a remote node with such > a distan

Re: [PATCH 2/2] security: introduce kernel_module_from_file hook

2012-09-20 Thread Andrew Morton
On Fri, 7 Sep 2012 11:38:13 -0700 Kees Cook wrote: > Instead of (or in addition to) kernel module signing, being able to reason > about the origin of a kernel module would be valuable in situations > where an OS already trusts a specific file system, file, etc, due to > things like security labe

Re: [PATCH v3] memory-hotplug: fix zone stat mismatch

2012-09-20 Thread Andrew Morton
On Thu, 20 Sep 2012 15:43:25 +0900 Minchan Kim wrote: > During memory-hotplug, I found NR_ISOLATED_[ANON|FILE] > are increasing so that kernel are hang out. > > The cause is that when we do memory-hotadd after memory-remove, > __zone_pcp_update clear out zone's ZONE_STAT_ITEMS in setup_pageset >

Re: [PATCH V2] poweroff: fix bug in orderly_poweroff

2012-09-20 Thread Andrew Morton
On Thu, 20 Sep 2012 17:16:35 -0700 Feng Hong wrote: > I am just a graduate and it's my first time to send a patch to > opensource, so thank you very much for reminding me the "changelog > affairs", it seems this patch has been added to -mm tree as attached > mail, and I have no chance to change t

Re: pci-disable-decoding-during-sizing-of-bars.patch no longer needed

2008-02-16 Thread Andrew Morton
On Sat, 16 Feb 2008 21:50:51 + Daniel Drake <[EMAIL PROTECTED]> wrote: > Hi, > > The patch titled pci-disable-decoding-during-sizing-of-bars.patch in -mm > was previously used as a candidate to fix a boot hang with Intel's Q35 > chipset: https://bugs.gentoo.org/show_bug.cgi?id=198810 > > H

Re: [PATCH 3/6] h8300 setup.c initrd support fix

2008-02-16 Thread Andrew Morton
On Sat, 16 Feb 2008 23:39:09 -0500 Yoshinori Sato <[EMAIL PROTECTED]> wrote: > At Fri, 15 Feb 2008 22:29:49 -0800, > Andrew Morton wrote: > > > > On Sat, 16 Feb 2008 01:13:37 -0500 Yoshinori Sato <[EMAIL PROTECTED]> wrote: > > > > > initrd setting

Re: [BUG] 2.6.25-rc2-mm1 - Kernel panic while bootup caused by signal_group_exit()

2008-02-16 Thread Andrew Morton
On Sun, 17 Feb 2008 09:40:33 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > The signals-do_signal_stop-use-signal_group_exit.patch is causing the > kernel panic, while booting in to the 2.6.25-rc2-mm1 kernel on x86. > > There has been discussion on the patch for this panic on

Re: 2.6.25-rc2-mm1

2008-02-16 Thread Andrew Morton
On Sun, 17 Feb 2008 10:38:12 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > The 2.6.25-rc2-mm1 kernel oopses, followed by softlockup several times (have > pasted > only some of them) on the x86_64 machine. The machine has 4 cpu(s). > > BUG: unable to handle kernel NULL pointer dereference a

Re: [PATCH 3/6] h8300 setup.c initrd support fix

2008-02-16 Thread Andrew Morton
On Sun, 17 Feb 2008 00:09:47 -0500 Yoshinori Sato <[EMAIL PROTECTED]> wrote: > > Sorry. I mistake orign. > Signed-off-by: Yoshinori Sato <[EMAIL PROTECTED]> > Please include a full description of your patches! > > diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c > index b1f2

<    10   11   12   13   14   15   16   17   18   19   >