[PATCH v8 4/5] drm/bridge: lvds-codec: simplify error handling

2020-07-10 Thread Andrzej Hajda
Using dev_err_probe code has following advantages: - shorter code, - recorded defer probe reason for debugging, - uniform error code logging. Signed-off-by: Andrzej Hajda Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/lvds-codec.c | 10 +++--- 1 file changed, 3 insertions(+), 7

[PATCH v8 3/5] drm/bridge/sii8620: fix resource acquisition error handling

2020-07-10 Thread Andrzej Hajda
In case of error during resource acquisition driver should print error message only in case it is not deferred probe, using dev_err_probe helper solves the issue. Moreover it records defer probe reason for debugging. Signed-off-by: Andrzej Hajda Reviewed-by: Neil Armstrong --- drivers/gpu/drm

[PATCH v6 4/4] drm/bridge: lvds-codec: simplify error handling

2020-06-26 Thread Andrzej Hajda
Using dev_err_probe code has following advantages: - shorter code, - recorded defer probe reason for debugging, - uniform error code logging. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/bridge/lvds-codec.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

[PATCH v6 0/4] driver core: add probe error check helper

2020-06-26 Thread Andrzej Hajda
and benefits of the helper. My dirty/ad-hoc cocci scripts shows that this helper can be used in at least 2700 places saving about 3500 lines of code. Regards Andrzej Andrzej Hajda (4): driver core: add device probe log helper driver core: add deferring probe reason to devices_deferred property drm

[PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-06-26 Thread Andrzej Hajda
instead of printk the message will be attached to deferred device and printed when user read devices_deferred property. Signed-off-by: Andrzej Hajda Reviewed-by: Mark Brown Reviewed-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko --- drivers/base/base.h | 3 +++ drivers/base/core.c

[PATCH v6 1/4] driver core: add device probe log helper

2020-06-26 Thread Andrzej Hajda
partially. dev_err_probe helps to replace such code sequences with simple call, so code: if (err != -EPROBE_DEFER) dev_err(dev, ...); return err; becomes: return probe_err(dev, err, ...); Signed-off-by: Andrzej Hajda --- drivers/base/core.c| 42

[PATCH v6 3/4] drm/bridge/sii8620: fix resource acquisition error handling

2020-06-26 Thread Andrzej Hajda
In case of error during resource acquisition driver should print error message only in case it is not deferred probe, using dev_err_probe helper solves the issue. Moreover it records defer probe reason for debugging. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/bridge/sil-sii8620.c | 21

Re: [PATCH v3] driver core: Break infinite loop when deferred probe can't be satisfied

2020-06-08 Thread Andrzej Hajda
On 08.06.2020 11:17, Marco Felsch wrote: > On 20-03-26 18:31, Andy Shevchenko wrote: >> On Thu, Mar 26, 2020 at 03:01:22PM +, Grant Likely wrote: >>> On 25/03/2020 12:51, Andy Shevchenko wrote: On Tue, Mar 24, 2020 at 08:29:01PM -0700, Saravana Kannan wrote: > On Tue, Mar 24, 2020

Re: [PATCH v2] drm/bridge: sil_sii8620: make remote control optional.

2019-01-28 Thread Andrzej Hajda
support in the driver optional and > contingent on RC_CORE being defined. And with this the hard dependency > on INPUT also goes away as that is only needed if RC_CORE is defined > (which in turn already depends on INPUT). Thanks for fixing it, this seems to be a best way to deal with it, mo

Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6E63M0 panel

2019-01-28 Thread Andrzej Hajda
6e63m0.c > @@ -0,0 +1,712 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * S6E63M0 AMOLED LCD drm_panel driver. > + * > + * Copyright (C) 2019 Paweł Chmiel > + * Derived from drivers/gpu/drm/panel-samsung-ld9040.c > + * > + * Andrzej Hajda > + * > + *

Re: [PATCH v3 2/2] drm/panel: Add driver for Samsung S6E63M0 panel

2019-02-11 Thread Andrzej Hajda
rs/gpu/drm/panel/panel-samsung-s6e63m0.c > b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c > new file mode 100644 > index ..4312aa3e4386 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c > @@ -0,0 +1,517 @@ > +// SPDX-License-Identifier: GPL-2

Re: [PATCH v4 4/5] drm/bridge: lvds-encoder: add dev helper variable in .probe()

2019-01-17 Thread Andrzej Hajda
On 11.01.2019 16:19, Peter Rosin wrote: > Make the code easier to read and modify. > > Signed-off-by: Peter Rosin Reviewed-by: Andrzej Hajda  -- Regards Andrzej

Re: [PATCH v4 5/5] drm/bridge: lvds-encoder: add powerdown-gpios support

2019-01-17 Thread Andrzej Hajda
On 11.01.2019 16:19, Peter Rosin wrote: > Optionally power down the LVDS-encoder when it is not in use. > > Signed-off-by: Peter Rosin Reviewed-by: Andrzej Hajda  -- Regards Andrzej

Re: [PATCH v4 0/5] drm/bridge: various small lvds-encoder things

2019-01-18 Thread Andrzej Hajda
On 11.01.2019 16:18, Peter Rosin wrote: > Hi! > > I'm not sure if I should have added the texas chips to the lvds_encoder_match > list in the driver, right next to the thine,thc63lvdm83d entry, but ended > up not doing that. That can always be added later, if needed... > > Changes since v3: > -

Re: [PATCH 2/8] drm/meson: add HDMI div40 TMDS mode

2019-01-18 Thread Andrzej Hajda
On 15.01.2019 13:33, Neil Armstrong wrote: > Add support for TMDS Clock > 3.4GHz for HDMI2.0 display modes. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 1/6] include/drm: color_mgmt: Add enum labels

2019-01-18 Thread Andrzej Hajda
+CC: Hans On 17.01.2019 20:47, Ville Syrjälä wrote: > On Fri, Dec 14, 2018 at 01:10:16PM +0100, Christoph Manszewski wrote: >> Range setting makes sense for YCbCr and RGB buffers. Current >> drm_color_range enum labels suggest use with YCbCr buffers. >> Create enum labels without colorspace

Re: [PATCH 2/2] arm64: dts: exynos: Remove unneeded DSI and DECON address/size cells in Exynos5433

2018-06-20 Thread Andrzej Hajda
On 20.06.2018 21:34, Krzysztof Kozlowski wrote: > On Tue, Jun 19, 2018 at 09:59:04AM +0200, Krzysztof Kozlowski wrote: >> On 19 June 2018 at 09:26, Marek Szyprowski wrote: >>> Hi Krzysztof, >>> >>> On 2018-06-18 19:42, Krzysztof Kozlowski wrote: The decon, decon_tv and dsi nodes have only

Re: [PATCH 2/2] arm64: dts: exynos: Remove unneeded DSI and DECON address/size cells in Exynos5433

2018-06-19 Thread Andrzej Hajda
orm with DSI panel/bridge controlled via I2C, it should be reverted., but this is theoretical problem. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Andrzej Hajda  -- Regards Andrzej > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 6 +- > arch/arm6

Re: [PATCH] i2c: exynos5: Describe the hardware variant for readability

2018-07-18 Thread Andrzej Hajda
'exynos_hsi2c_variant' > > No change in functionality. > > Signed-off-by: Krzysztof Kozlowski Maybe changing it to "bool is_exynos7" or sth like that would make it little more readable, matter of taste. Anyway: Reviewed-by: Andrzej Hajda Regards Andrzej > --- > drivers/i2c/bus

Re: [PATCH RFC v2 1/8] drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling support

2018-12-18 Thread Andrzej Hajda
0x10E1 > > #define HDMI_FC_GMD_STAT 0x1100 > #define HDMI_FC_GMD_EN 0x1101 > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h > index 9c56412bb2cf..7a02744ce0bc 100644 > --- a/include/drm/bridge/dw_hdmi.h > +++ b/include/drm/bridge/dw_hdmi.h > @@ -157,6 +157,7 @@ void dw_hdmi_setup_rx_sense(struct dw_hdmi *hdmi, bool > hpd, bool rx_sense); > void dw_hdmi_set_sample_rate(struct dw_hdmi *hdmi, unsigned int rate); > void dw_hdmi_audio_enable(struct dw_hdmi *hdmi); > void dw_hdmi_audio_disable(struct dw_hdmi *hdmi); > +void dw_hdmi_set_high_tmds_clock_ratio(struct dw_hdmi *hdmi); > > /* PHY configuration */ > void dw_hdmi_phy_i2c_set_addr(struct dw_hdmi *hdmi, u8 address); Reviewed-by: Andrzej Hajda  -- Regards Andrzej

Re: [PATCH RFC v2 2/8] drm/meson: add HDMI div40 TMDS mode

2018-12-18 Thread Andrzej Hajda
On 30.11.2018 14:42, Neil Armstrong wrote: > Add support for TMDS Clock > 3.4GHz for HDMI2.0 display modes. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 24 > 1 file changed, 20 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH RFC v2 3/8] drm/meson: add support for HDMI2.0 2160p modes

2018-12-18 Thread Andrzej Hajda
gpu/drm/meson/meson_venc.c > @@ -848,6 +848,8 @@ struct meson_hdmi_venc_vic_mode { > { 93, _hdmi_encp_mode_2160p24 }, > { 94, _hdmi_encp_mode_2160p25 }, > { 95, _hdmi_encp_mode_2160p30 }, > + { 96, _hdmi_encp_mode_2160p25 }, > + { 97, _hdmi_encp_mode_2160p30 }, >

Re: [PATCH RFC v2 4/8] drm/bridge: dw-hdmi: add support for YUV420 output

2018-12-18 Thread Andrzej Hajda
to support theses modes. > > This patch is based on work from Zheng Yang in > the Rockchip Linux 4.4 BSP at [1] > > [1] https://github.com/rockchip-linux/kernel/tree/release-4.4 > > Cc: Zheng Yang > Signed-off-by: Neil Armstrong Reviewed-by: Andrzej Hajda  -- Regards Andrzej

Re: [PATCH RFC v2 5/8] drm/bridge: dw-hdmi: support dynamically get input/out color info

2018-12-18 Thread Andrzej Hajda
On 30.11.2018 14:42, Neil Armstrong wrote: > From: Zheng Yang > > To get input/output bus_format/enc_format dynamically, this patch > introduce following funstion in plat_data: > - get_input_bus_format > - get_output_bus_format > - get_enc_in_encoding > -

Re: [PATCH 2/3] dt-bindings: display: bridge: lvds-transmitter: add pwdn-gpios

2018-12-19 Thread Andrzej Hajda
On 19.12.2018 00:19, Peter Rosin wrote: > Add optional property to specify a power-down GPIO. > The pwdn-gpios name is already in use by the thine,thc63lvdm83d > binding, so go with that. > > Signed-off-by: Peter Rosin > --- > Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt

Re: [PATCH][resend] drm: dw-hdmi-i2s: convert to SPDX identifiers

2018-12-19 Thread Andrzej Hajda
;>>>> bridge drivers all have a fallback maintainer, but none of them are >>>>> cc'ed. It's maintained in drm-misc, so you could just push the patch >>>>> too :-) Especially since you're listed: >>>>> >>>>> DRM DRIVERS FOR BRIDGE CHIPS

[PATCH v4 3/3] driver core: add probe_err_ptr helper

2018-12-20 Thread Andrzej Hajda
probe_err is useful in multiple contexts where error is encoded in pointer. Adding helper performing conversion to error value should simplify code further. Signed-off-by: Andrzej Hajda --- include/linux/device.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/device.h b

[PATCH v4 0/3] driver core: add probe error check helper

2018-12-20 Thread Andrzej Hajda
introducing probe_err* per subsystem. Regards Andrzej Andrzej Hajda (3): driver core: add probe_err log helper driver core: add deferring probe reason to devices_deferred property driver core: add probe_err_ptr helper drivers/base/base.h| 3 +++ drivers/base/core.c| 40

[PATCH v4 2/3] driver core: add deferring probe reason to devices_deferred property

2018-12-20 Thread Andrzej Hajda
instead of printk the message will be attached to deferred device and printed when user read devices_deferred property. Signed-off-by: Andrzej Hajda Reviewed-by: Mark Brown Reviewed-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko --- v4: - removed NULL check before kfree, - coding

[PATCH v4 1/3] driver core: add probe_err log helper

2018-12-20 Thread Andrzej Hajda
. probe_err helps to replace such code sequences with simple call, so code: if (err != -EPROBE_DEFER) dev_err(dev, ...); return err; becomes: return probe_err(dev, err, ...); Signed-off-by: Andrzej Hajda Reviewed-by: Javier Martinez Canillas Reviewed

Re: [PATCH v4 1/3] driver core: add probe_err log helper

2018-12-20 Thread Andrzej Hajda
On 20.12.2018 12:14, Greg Kroah-Hartman wrote: > On Thu, Dec 20, 2018 at 11:22:45AM +0100, Andrzej Hajda wrote: >> During probe every time driver gets resource it should usually check for >> error >> printk some message if it is not -EPROBE_DEFER and return the error. This

Re: [PATCH v4 2/3] driver core: add deferring probe reason to devices_deferred property

2018-12-20 Thread Andrzej Hajda
On 20.12.2018 12:12, Greg Kroah-Hartman wrote: > On Thu, Dec 20, 2018 at 11:22:46AM +0100, Andrzej Hajda wrote: >> /sys/kernel/debug/devices_deferred property contains list of deferred >> devices. >> This list does not contain reason why the driver deferred probe,

[PATCH] component: do not stop components lookup after first fail

2018-12-06 Thread Andrzej Hajda
is missing solves the issue. Signed-off-by: Andrzej Hajda --- drivers/base/component.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index e8d676fad0c9..e9572b37d5cf 100644 --- a/drivers/base/component.c +++ b/drivers/base

[PATCH v2 1/3] driver core: add probe_err log helper

2018-10-17 Thread Andrzej Hajda
. probe_err helps to replace such code sequences with simple call, so code: if (err != -EPROBE_DEFER) dev_err(dev, ...); return err; becomes: return probe_err(dev, err, ...); Signed-off-by: Andrzej Hajda Reviewed-by: Javier Martinez Canillas --- v2

[PATCH v2 2/3] driver core: add deferring probe reason to devices_deferred property

2018-10-17 Thread Andrzej Hajda
instead of printk the message will be attached to deferred device and printed when user read devices_deferred property. Signed-off-by: Andrzej Hajda Reviewed-by: Mark Brown Reviewed-by: Javier Martinez Canillas --- v2: - changed __deferred_probe_set_msg args - like in __dev_printk, fits better

Re: [PATCH 3/3] drivers: use probe_err function in obvious cases

2018-10-17 Thread Andrzej Hajda
On 16.10.2018 15:51, Andy Shevchenko wrote: > On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda wrote: >> The patch replaces obviously matching code with probe_err function. >> There are many more places where probe_err could be used. >> The patch shows how the new function sh

[PATCH v3 1/4] driver core: add probe_err log helper

2018-10-17 Thread Andrzej Hajda
. probe_err helps to replace such code sequences with simple call, so code: if (err != -EPROBE_DEFER) dev_err(dev, ...); return err; becomes: return probe_err(dev, err, ...); Signed-off-by: Andrzej Hajda Reviewed-by: Javier Martinez Canillas Reviewed

[PATCH v3 2/4] driver core: add deferring probe reason to devices_deferred property

2018-10-17 Thread Andrzej Hajda
instead of printk the message will be attached to deferred device and printed when user read devices_deferred property. Signed-off-by: Andrzej Hajda Reviewed-by: Mark Brown Reviewed-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko --- v3: - adjusted deferred_devs_show, to accept

[PATCH v4 2/3] driver core: add deferring probe reason to devices_deferred property

2018-10-18 Thread Andrzej Hajda
instead of printk the message will be attached to deferred device and printed when user read devices_deferred property. Signed-off-by: Andrzej Hajda Reviewed-by: Mark Brown Reviewed-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko --- v4: - removed NULL check before kfree, - coding

[PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Andrzej Hajda
. probe_err helps to replace such code seqences with simple call, so code: if (err != -EPROBE_DEFER) dev_err(dev, ...); return err; becomes: return probe_err(dev, err, ...); Signed-off-by: Andrzej Hajda --- drivers/base/core.c| 37

[PATCH 3/3] drivers: use probe_err function in obvious cases

2018-10-16 Thread Andrzej Hajda
); @@ expression err, dev; expression list l; identifier errlab; @@ - if (err != -EPROBE_DEFER) \({ dev_err(dev, l); }\|dev_err(dev, l);\) + probe_err(dev, err, l); goto errlab; Signed-off-by: Andrzej Hajda --- drivers/ata/libahci_platform.c| 7 +- drivers/base/power/domain.c

[PATCH 2/3] driver core: add deferring probe reason to devices_deferred property

2018-10-16 Thread Andrzej Hajda
instead of printk the message will be attached to deferred device and printed when user read devices_deferred property. Signed-off-by: Andrzej Hajda --- drivers/base/base.h | 3 +++ drivers/base/core.c | 15 +-- drivers/base/dd.c | 34 +- 3 files

[PATCH 0/3] driver core: add probe error check helper

2018-10-16 Thread Andrzej Hajda
subsystems if neccessary. Regards Andrzej Andrzej Hajda (3): driver core: add probe_err log helper driver core: add deferring probe reason to devices_deferred property drivers: use probe_err function in obvious cases drivers/ata/libahci_platform.c| 7 +- drivers/base/base.h

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Andrzej Hajda
On 16.10.2018 13:01, Andy Shevchenko wrote: > On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda wrote: >> During probe every time driver gets resource it should usually check for >> error >> printk some message if it is not -EPROBE_DEFER and return the error. This >> pat

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Andrzej Hajda
On 16.10.2018 13:29, Andrzej Hajda wrote: > On 16.10.2018 13:01, Andy Shevchenko wrote: >> On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda wrote: >>> During probe every time driver gets resource it should usually check for >>> error >>> printk some message i

Re: [PATCH v5 1/2] drm/bridge: sil_sii8620: make remote control optional.

2019-04-15 Thread Andrzej Hajda
On 16.04.2019 01:24, Life is hard, and then you die wrote: > Hi Andrzej, > > On Mon, Apr 15, 2019 at 10:58:09AM +0200, Andrzej Hajda wrote: >> On 15.04.2019 10:12, Ronald Tschalär wrote: >>> commit d6abe6df706c (drm/bridge: sil_sii8620: do not have a dependency >>&g

Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus

2019-04-25 Thread Andrzej Hajda
On 21.04.2019 10:25, Jonas Karlman wrote: > When ddc-i2c-bus property is used, a NULL pointer dereference is reported: > > [ 31.041669] Unable to handle kernel NULL pointer dereference at virtual > address 0008 > [ 31.041671] pgd = 4d3c16f6 > [ 31.041673] [0008] *pgd= > [

Re: [PATCH] drm/bridge/synopsys: dsi: Don't blindly call post_disable

2019-04-25 Thread Andrzej Hajda
On 24.04.2019 16:22, Matt Redfearn wrote: > The DRM documentation states that post_disable is an optional callback. > As such an implementing device may not populate it. To avoid panicing > the kernel by calling a NULL function pointer, we should NULL check it > before blindy calling it. > >

Re: [PATCH] drm/bridge: ti-sn65dsi86: make const array static

2019-02-27 Thread Andrzej Hajda
On 26.02.2019 17:59, Colin King wrote: > From: Colin Ian King > > Don't populate the const array ti_sn_bridge_supply_names on the > stack but instead make it static. > > Signed-off-by: Colin Ian King Reviewed-by: Andrzej Hajda  -- Regards Andrzej > --- > drivers/gpu/d

Re: [PATCH v4 1/2] drm/bridge: sil_sii8620: make remote control optional.

2019-04-10 Thread Andrzej Hajda
support in the driver optional and > contingent on RC_CORE being defined. And with this the hard dependency > on INPUT also goes away as that is only needed if RC_CORE is defined > (which in turn already depends on INPUT). > > CC: Inki Dae > CC: Andrzej Hajda > CC: Laurent

Re: [PATCH v4 1/2] drm/bridge: sil_sii8620: make remote control optional.

2019-04-07 Thread Andrzej Hajda
support in the driver optional and > contingent on RC_CORE being defined. And with this the hard dependency > on INPUT also goes away as that is only needed if RC_CORE is defined > (which in turn already depends on INPUT). > > CC: Inki Dae > CC: Andrzej Hajda > CC: Laurent Pinchart > CC: Dmitry Torokhov > Signed-off-by: Ronald Tschalär Reviewed-by: Andrzej Hajda  -- Regards Andrzej

Re: [PATCH v5 1/2] drm/bridge: sil_sii8620: make remote control optional.

2019-04-15 Thread Andrzej Hajda
support in the driver optional and > contingent on RC_CORE being defined. And with this the hard dependency > on INPUT also goes away as that is only needed if RC_CORE is defined > (which in turn already depends on INPUT). > > CC: Inki Dae > CC: Andrzej Hajda > CC: Laurent Pinchart

Re: [PATCH v2] drm/bridge: sil_sii8620: make remote control optional.

2019-03-03 Thread Andrzej Hajda
d6abe6df706c, namely >> that not all boards use the remote controller functionality and hence >> should not need have to deal with RC_CORE, the second part of this >> change now makes the remote control support in the driver optional and >> contingent on RC_CORE being defined.

Re: [PATCH 1/9] drm/bridge: tc358767: Simplify tc_poll_timeout()

2019-03-04 Thread Andrzej Hajda
: Archit Taneja > Cc: Andrzej Hajda > Cc: Laurent Pinchart > Cc: Chris Healy > Cc: Lucas Stach > Cc: dri-de...@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Andrzej Hajda  -- Regards Andrzej > --- > drivers/gpu/drm/bridge/tc358767.c | 19 +

Re: [PATCH 2/9] drm/bridge: tc358767: Simplify tc_stream_clock_calc()

2019-03-04 Thread Andrzej Hajda
On 26.02.2019 20:36, Andrey Smirnov wrote: > Drop the use of tc_write() as well as "magicly" used "ret" and "err:" > and replace it with a simple call to regmap_write(). No functional > change intended. > > Signed-off-by: Andrey Smirnov > Cc: A

Re: [PATCH v3 2/2] drm/panel: Add driver for Samsung S6E63M0 panel

2019-02-12 Thread Andrzej Hajda
On 11.02.2019 17:07, Paweł Chmiel wrote: > On poniedziałek, 11 lutego 2019 16:35:19 CET Andrzej Hajda wrote: >> On 02.02.2019 15:27, Paweł Chmiel wrote: >>> This patch adds Samsung S6E63M0 AMOLED LCD panel driver, connected over >>> spi. It's based on already rem

Re: [PATCH 0/8] drm/meson: Add support for HDMI2.0 4k60

2019-01-31 Thread Andrzej Hajda
On 31.01.2019 14:25, Neil Armstrong wrote: > Hi Andrzej, Laurent, > > On 15/01/2019 13:33, Neil Armstrong wrote: >> This patchset aims to add support for the following HDMI2.0 4k60 modes: >> - 594Mhz TMDS frequency needing TMDS Scramling and 1/40 rate for RGB/YUV4:4:4 >> - 297MHz TMDS frequency

Re: [PATCH 0/8] drm/meson: Add support for HDMI2.0 4k60

2019-02-01 Thread Andrzej Hajda
On 31.01.2019 16:50, Neil Armstrong wrote: > On 31/01/2019 15:13, Andrzej Hajda wrote: >> On 31.01.2019 14:25, Neil Armstrong wrote: >>> Hi Andrzej, Laurent, >>> >>> On 15/01/2019 13:33, Neil Armstrong wrote: >>>> This patchset aims to

Re: [PATCH v1 0/19] drm/panel: drmP.h removal and DRM_DEV*

2019-02-01 Thread Andrzej Hajda
On 01.02.2019 11:30, Jani Nikula wrote: > On Fri, 01 Feb 2019, Sam Ravnborg wrote: >> Hi Thierry. >> >>> I personally like the DRM_DEV_* variants better because of the >>> additional information that they provide. That can be useful when >>> grepping logs etc. >>> >>> I'm slightly on the fence

Re: [PATCH v2 4/8] drm/bridge: dw-hdmi: add support for YUV420 output

2019-02-01 Thread Andrzej Hajda
to support theses modes. > > This patch is based on work from Zheng Yang in > the Rockchip Linux 4.4 BSP at [1] > > [1] https://github.com/rockchip-linux/kernel/tree/release-4.4 > > Cc: Zheng Yang > Signed-off-by: Neil Armstrong > Tested-by: Heiko Stuebner > Review

Re: [PATCH v4 2/3] driver core: add deferring probe reason to devices_deferred property

2018-12-20 Thread Andrzej Hajda
On 20.12.2018 12:04, Rafael J. Wysocki wrote: > On Thu, Dec 20, 2018 at 11:23 AM Andrzej Hajda wrote: >> /sys/kernel/debug/devices_deferred property contains list of deferred >> devices. >> This list does not contain reason why the driver deferred probe, the patch >>

[PATCH] PCI: pcie-rockchip: use probe_err helpers instead of open coding

2018-12-21 Thread Andrzej Hajda
probe_err helpers makes probe error handling easier and less error prone. Signed-off-by: Andrzej Hajda --- Hi all, This is sample conversion of one of drivers to proposed probe_err* helpers. It was created to convince Greg that these helpers are useful. With this helper we gain: - corect error

Re: [PATCH v4 1/3] driver core: add probe_err log helper

2018-12-24 Thread Andrzej Hajda
On 21.12.2018 23:47, Rob Herring wrote: > On Thu, Dec 20, 2018 at 5:38 AM Andrzej Hajda wrote: >> On 20.12.2018 12:14, Greg Kroah-Hartman wrote: >>> On Thu, Dec 20, 2018 at 11:22:45AM +0100, Andrzej Hajda wrote: >>>> During probe every time driver gets re

Re: [PATCH v2 08/14] drm: remove include of drmP.h from bridge/dw_hdmi.h

2018-12-31 Thread Andrzej Hajda
licit > include statements or forward declarations to these files. > Build tested with arm and x86. > > v2: > - prefer forward declarations when possible (Laurent Pinchart) > - sort include files (Laurent Pinchart) > > Signed-off-by: Sam Ravnborg > Reviewed-by: Laurent Pinchart

Re: [PATCH v3 1/9] drm/exynos: rename "bridge_node" to "mic_bridge_node"

2018-07-25 Thread Andrzej Hajda
On 24.07.2018 09:49, Inki Dae wrote: > Hi, > > 2018년 06월 19일 17:19에 Maciej Purski 이(가) 쓴 글: >> When adding support for peripheral out bridges, the "bridge" name >> becomes imprecise as it refers to a different device than the >> "out_bridge". > Could you give me more details? I'm afriad that I

Re: [PATCH v3 17/25] dt-bindings: panel: Add Bananapi S070WV20-CT16 ICN6211 MIPI-DSI to RGB bridge

2018-11-19 Thread Andrzej Hajda
On 18.11.2018 19:20, Jagan Teki wrote: > On Tue, Nov 13, 2018 at 1:26 PM Andrzej Hajda wrote: >> On 10.11.2018 08:32, Jagan Teki wrote: >>> On Wed, Nov 7, 2018 at 2:41 PM Andrzej Hajda wrote: >>>> On 06.11.2018 19:08, Jagan Teki wrote: >>>>> On Wed,

Re: [RFC PATCH 0/4] kstrdup optimization

2015-01-08 Thread Andrzej Hajda
Hi Andi, Andreas, Thanks for comments. On 12/30/2014 10:29 PM, Andi Kleen wrote: >> This symmetry issue probably could be cleanly avoided only >> by having kfree() itself contain such an identifying check, as you suggest >> (thereby slowing down kfree() performance). > > It actually shouldn't

Re: [PATCH] of/platform: Move platform devices under /sys/devices/platform

2014-11-18 Thread Andrzej Hajda
On 11/04/2014 11:45 AM, Grant Likely wrote: > Currently the devices created by drivers/of/platform.c get created at > the root of /sys/devices. This goes against the typical pattern for > sysfs where the top level /sys/devices structure contains categories of > devices, and the structure of

Re: [BUG] blocked task after exynos_drm_init

2014-11-18 Thread Andrzej Hajda
On 11/06/2014 10:06 AM, Krzysztof Kozlowski wrote: > Hi, > > On last next (next-20141104, next-20141105) booting locks after > initializing Exynos DRM (Trats2 board): > > [2.028283] [drm] Initialized drm 1.1.0 20060810 > [ 240.505795] INFO: task swapper/0:1 blocked for more than 120

Re: [BUG] blocked task after exynos_drm_init

2014-11-18 Thread Andrzej Hajda
On 11/18/2014 11:52 AM, Inki Dae wrote: > On 2014년 11월 18일 19:42, Andrzej Hajda wrote: >> On 11/06/2014 10:06 AM, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> On last next (next-20141104, next-20141105) booting locks after >>> initializing Exynos DR

Re: [PATCH] drm/exynos: remove ifdeferry from initialization code

2014-09-30 Thread Andrzej Hajda
Hi Inki, Gently ping. Andrzej On 09/10/2014 01:53 PM, Andrzej Hajda wrote: > The patch replaces separate calls to driver (de)registration by > loops over the array of drivers. As a result it significantly > decreases number of ifdefs. Additionally it moves device registration > re

Re: [PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-09-30 Thread Andrzej Hajda
Hi Mark, On 09/30/2014 03:03 PM, Mark Yao wrote: > From: Mark yao > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Acked-by: Daniel Vetter > Reviewed-by: Rob Clark > --- > Changes in v2: > - use the

[RFC 00/15] Resource tracking/allocation framework

2014-12-10 Thread Andrzej Hajda
ernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/log/?h=exynos-drm-next Regards Andrzej Andrzej Hajda (15): drivers/base: add track framework drivers/base: add restrack framework drm/panel: add restrack support regulator: add restrack support gpio: move DT parsing code to separate

[RFC 05/15] gpio: move DT parsing code to separate functions

2014-12-10 Thread Andrzej Hajda
The patch moves Device Tree parsing logic to separate function. Signed-off-by: Andrzej Hajda --- drivers/gpio/gpiolib-of.c | 59 +-- drivers/gpio/gpiolib.c| 33 +++--- drivers/gpio/gpiolib.h| 4 ++-- 3 files changed, 53

[RFC 15/15] drm/panel/ld9040: convert to restrack API

2014-12-10 Thread Andrzej Hajda
, - simplified initialization. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/panel/panel-ld9040.c | 41 ++-- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c index 3337f30..619610e

[RFC 12/15] drm/exynos/dpi: use common of_graph functions

2014-12-10 Thread Andrzej Hajda
The patch removes private of_graph functions and uses common ones. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 117 +++- 1 file changed, 24 insertions(+), 93 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers

[RFC 14/15] drm/panel/ld9040: do not power off panel on removal

2014-12-10 Thread Andrzej Hajda
Panel is powered off already by connector during drm_panel_remove call. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/panel/panel-ld9040.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c index 08cf2c5..3337f30

[RFC 11/15] drm/exynos/dsi: convert to restrack API

2014-12-10 Thread Andrzej Hajda
it, - simplified initialization. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 52 + 1 file changed, 21 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index

[RFC 08/15] clk: add restrack support

2014-12-10 Thread Andrzej Hajda
Clocks supports different methods of lookup. The patch adds restrack support only to DT based clocks. Signed-off-by: Andrzej Hajda --- drivers/clk/clk.c| 6 drivers/clk/clkdev.c | 74 include/linux/clk.h | 3 ++ include

[RFC 13/15] drm/exynos/dpi: convert to restrack API

2014-12-10 Thread Andrzej Hajda
to late initcall, unless other components delays it, - it starts/stops tracking panel presence only when necessary. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 80 +++- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 7 +++ 2 files changed

[RFC 10/15] drm/exynos/dsi: simplify hotplug code

2014-12-10 Thread Andrzej Hajda
from unbind code. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 61 - 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 05fe93d..8201d79

[RFC 09/15] phy: add restrack support

2014-12-10 Thread Andrzej Hajda
PHYs supports different methods of lookup. The patch adds restrack support only to DT based PHYs. Signed-off-by: Andrzej Hajda --- drivers/phy/phy-core.c | 90 include/linux/phy/phy.h | 3 ++ include/linux/restrack.h | 1 + 3 files changed

[RFC 01/15] drivers/base: add track framework

2014-12-10 Thread Andrzej Hajda
should be used in process context. Signed-off-by: Andrzej Hajda --- drivers/base/Makefile | 2 +- drivers/base/track.c | 241 ++ include/linux/track.h | 148 +++ 3 files changed, 390 insertions(+), 1 deletion(-) create

[RFC 06/15] gpio: add restrack support

2014-12-10 Thread Andrzej Hajda
GPIO supports different methods of lookup. The patch adds restrack support only to DT based GPIOs. Signed-off-by: Andrzej Hajda --- drivers/gpio/gpiolib.c| 81 +++ include/linux/gpio/consumer.h | 4 +++ include/linux/restrack.h | 1 + 3

[RFC 04/15] regulator: add restrack support

2014-12-10 Thread Andrzej Hajda
Regulators supports various methods of lookup. The patch adds restrack support only to DT based regulators. Signed-off-by: Andrzej Hajda --- drivers/regulator/core.c | 77 ++ include/linux/regulator/consumer.h | 10 + include/linux/restrack.h

[RFC 07/15] clk: add DT parsing function

2014-12-10 Thread Andrzej Hajda
The patch adds function for parsing Device Tree to get clock specifier. The function could be ultimately used by clock core. Signed-off-by: Andrzej Hajda --- drivers/clk/clkdev.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/clk/clkdev.c b/drivers/clk

[RFC 02/15] drivers/base: add restrack framework

2014-12-10 Thread Andrzej Hajda
lowing things should be defined: - structure describing resource with embedded restrack_desc structure, - at least one exported allocator of such structure, - few simple operations according to description of struct restrack_ops, - notifications about adding/removal of the resource. For detai

[RFC 03/15] drm/panel: add restrack support

2014-12-10 Thread Andrzej Hajda
The patch adds Device Tree restrack support to drm/panel framework. As panels supports only Device Tree based lookup all panels can be converted to restrack. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/drm_panel.c | 97 + include/drm/drm_panel.h

Re: [RFC 04/15] regulator: add restrack support

2014-12-11 Thread Andrzej Hajda
Hi Mark, On 12/10/2014 05:07 PM, Mark Brown wrote: > On Wed, Dec 10, 2014 at 04:48:22PM +0100, Andrzej Hajda wrote: >> Regulators supports various methods of lookup. >> The patch adds restrack support only to DT based regulators. > Why, what does this mean and how might

Re: [RFC 04/15] regulator: add restrack support

2014-12-12 Thread Andrzej Hajda
On 12/11/2014 02:43 PM, Russell King - ARM Linux wrote: > On Thu, Dec 11, 2014 at 12:58:37PM +, Mark Brown wrote: >> I'd expect someone reading the change in the regulator API to have at >> least some idea how this fits in with the rest of the API and how to use >> it, and probably more

[PATCH] drm/exynos: switch to universal plane API

2014-09-18 Thread Andrzej Hajda
The patch replaces legacy functions drm_plane_init() / drm_crtc_init() with drm_universal_plane_init() and drm_crtc_init_with_planes(). It allows to replace fake primary plane with the real one. Signed-off-by: Andrzej Hajda --- Hi Inki, I have tested this patch with trats board, it looks OK

Re: [PATCH] drm/exynos: switch to universal plane API

2014-09-19 Thread Andrzej Hajda
On 09/19/2014 03:02 AM, Joonyoung Shim wrote: > Hi Andrzej, > > On 09/18/2014 10:17 PM, Andrzej Hajda wrote: >> The patch replaces legacy functions >> drm_plane_init() / drm_crtc_init() with >> drm_universal_plane_init() and drm_crtc_init_with_planes(). >> It all

Re: [PATCH] drm/exynos: switch to universal plane API

2014-09-19 Thread Andrzej Hajda
On 09/19/2014 01:11 PM, Joonyoung Shim wrote: > Hi, > > On 09/19/2014 07:54 PM, Andrzej Hajda wrote: >> On 09/19/2014 03:02 AM, Joonyoung Shim wrote: >>> Hi Andrzej, >>> >>> On 09/18/2014 10:17 PM, Andrzej Hajda wrote: >>>> The patch replaces

[PATCH] drm/exynos: init vblank with real number of crtcs

2014-09-19 Thread Andrzej Hajda
Initialization of vblank with MAX_CRTC caused attempts to disabling vblanks for non-existing crtcs in case drm used fewer crtcs. The patch fixes it. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions

[PATCH v2] drm/exynos: switch to universal plane API

2014-09-19 Thread Andrzej Hajda
in correct order. Signed-off-by: Andrzej Hajda --- Hi Inki, Joonyoung, This is 2nd version of the patch with addressed comments of Joonyoung. Regards Andrzej --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 62 +++ drivers/gpu/drm/exynos/exynos_drm_drv.c | 5 ++- drivers

[PATCH] drm/exynos: remove explicit encoder/connector de-initialization

2014-09-22 Thread Andrzej Hajda
All KMS objects are destroyed by drm_mode_config_cleanup in proper order so component drivers should not care about it. Signed-off-by: Andrzej Hajda --- Hi Inki, This is another spin-off of exynos_drm tests regarding your component support update. The patch is based as usual on the latest

[PATCH v3 16/17] drm/exynos/ipp: remove file argument from node related functions

2014-09-02 Thread Andrzej Hajda
Since file pointer is preserved in c_node passing it as argument in node functions is redundant. Signed-off-by: Andrzej Hajda --- v3: - file check moved to next patch --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

[PATCH v3 17/17] drm/exynos/ipp: add file checks for ioctls

2014-09-02 Thread Andrzej Hajda
Process should not have access to ipp nodes created by another process. The patch adds necessary checks. It also simplifies lookup for command node. Signed-off-by: Andrzej Hajda --- v3: - added file check from previous commit - simplified c_node lookup --- drivers/gpu/drm/exynos

Re: [PATCH 03/15] drm/exynos/ipp: move file reference from memory to command node

2014-08-26 Thread Andrzej Hajda
Hi Joonyoung, Thanks for review. On 08/26/2014 04:59 AM, Joonyoung Shim wrote: > On 08/26/2014 11:55 AM, Joonyoung Shim wrote: >> Hi Andrzej, >> >> On 08/22/2014 04:52 PM, Andrzej Hajda wrote: >>> Command node should contain file reference to distinguish com

Re: [PATCH 14/15] drm/exynos/fimc: simplify buffer queuing

2014-08-26 Thread Andrzej Hajda
On 08/26/2014 07:53 AM, Joonyoung Shim wrote: > Hi Andrzej, > > On 08/22/2014 04:52 PM, Andrzej Hajda wrote: >> The patch removes redundant checks, redundant HW reads >> and simplifies code. >> >> Signed-off-by: Andrzej Hajda >> --- >>

<    7   8   9   10   11   12   13   14   15   16   >