Re: [PATCH v2] drm/rockchip: Refactor the component match logic.

n <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Below few nitpicks. (...) > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index b360e62..b6bccfc 100644 > --- a/drivers/gpu/drm/rockchip/

Re: [Patch v2 02/11] s5p-mfc: Adding initial support for MFC v10.10

On 03.03.2017 10:07, Smitha T Murthy wrote: > Adding the support for MFC v10.10, with new register file and > necessary hw control, decoder, encoder and structural changes. > > Signed-off-by: Smitha T Murthy <smith...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsu

Re: [Patch v2 04/11] s5p-mfc: Support MFCv10.10 buffer requirements

On 03.03.2017 10:07, Smitha T Murthy wrote: > Aligning the luma_dpb_size, chroma_dpb_size, mv_size and me_buffer_size > for MFCv10.10. > > Signed-off-by: Smitha T Murthy > --- > drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 19 + >

Re: [Patch v2 03/11] s5p-mfc: Use min scratch buffer size as provided by F/W

. > > Signed-off-by: Smitha T Murthy <smith...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [Patch v2 05/11] videodev2.h: Add v4l2 definition for HEVC

On 03.03.2017 10:07, Smitha T Murthy wrote: > Add V4L2 definition for HEVC compressed format > > Signed-off-by: Smitha T Murthy <smith...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > include/uapi/linux/videodev2.h |

Re: [Patch v2 07/11] Documentation: v4l: Documentation for HEVC v4l2 definition

On 03.03.2017 10:07, Smitha T Murthy wrote: > Add V4L2 definition for HEVC compressed format > > Signed-off-by: Smitha T Murthy <smith...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> > --- > Documentation/media/uapi/v4l/pixfmt-013.rst |5

Re: [Patch v2 09/11] v4l2: Add v4l2 control IDs for HEVC encoder

te MVs"; > + case V4L2_CID_MPEG_VIDEO_HEVC_WITHOUT_STARTCODE_ENABLE: return "HEVC > ENC without startcode enable"; > + case V4L2_CID_MPEG_VIDEO_HEVC_REFRESH_PERIOD: return "HEVC > Number of reference picture"; > +

Re: [Patch v2 10/11] s5p-mfc: Add support for HEVC encoder

On 03.03.2017 10:07, Smitha T Murthy wrote: > Add HEVC encoder support and necessary registers, V4L2 CIDs, > and hevc encoder parameters > > Signed-off-by: Smitha T Murthy > --- > drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 28 +- >

Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs

On 03.03.2017 10:07, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder It should be rather "Document controls for HEVC encoder" or sth similar. In general most of comments are in previous patch. Few additional comments: - please be careful about control names - they are exported to

Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ?

Hi David, Inki, Thanks for reporting. On 06.03.2017 11:05, David Binderman wrote: > Hello there, > > linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) > Result of operator '|' is always true if one operand is non-zero. Did you > intend to use '&'? > > Source code is

Re: [PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when unbinding

On 05.04.2017 10:29, Jeffy Chen wrote: > The dp aux is registered when binding analogix dp. > > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Btw, if you are working already in this area you can check also to analog

Re: [PATCH v3 3/9] drm: bridge: analogix: Destroy connector when unbinding

ips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> One comment below > --- > > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/a

Re: [PATCH v2 2/3] drm/panel: s6e3ha2: Add support for s6e3hf2 panel on TM2e board

3ha2 > compatibility and s6e3hf2 type and select the drm_display_mode of > default and edge type. > > Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board

t is not necessary and generates useless interrupts. Beside this: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/b

Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board

On 18.04.2017 09:44, Hoegeun Kwon wrote: > On 04/18/2017 03:00 PM, Andrzej Hajda wrote: >> On 17.04.2017 08:02, Hoegeun Kwon wrote: >>> This patch add the panel device tree node for s6e3hf2 display >>> controller to TM2e dts. >>> >>> Signed-off-by: Hoe

Re: [PATCH v6 2/5] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.

t; However, we can maintain a more exact vrefresh value (not just the > integer approximation), by scaling by the ratio of our clocks. > > v2: Use math suggested by Andrzej Hajda instead. > v3: Simplify math now that adjusted_mode->clock isn't padded. > > Signed-off-by: Eric An

Re: [PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

On 12.07.2017 15:25, Andrzej Hajda wrote: > On 27.06.2017 04:11, Hoegeun Kwon wrote: >> This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver >> which uses mipi_dsi bus to communicate with panel. The panel has >> 320×320 resolution in 1.63" physical

Re: [PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

t; +} > + > +static int s6e63j0x03_prepare(struct drm_panel *panel) > +{ > + struct s6e63j0x03 *ctx = panel_to_s6e63j0x03(panel); > + int ret; > + > + ret = s6e63j0x03_power_on(ctx); > + if (ret < 0) > + return ret; > + > + r

Re: [PATCH 15/18] drm/panel: Add Huarui LHR050H41 panel driver

On 13.07.2017 16:13, Maxime Ripard wrote: > The LHR050H41 panel is the panel shipped with the BananaPi M2-Magic. Add a > driver for it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/panel/Kconfig | 9 +- >

Re: [PATCH] s5k5baf: remove unnecessary static in s5k5baf_get_selection()

and after the code change: > > before: >textdata bss dec hex filename > 277655656 320 3374183cd drivers/media/i2c/s5k5baf.o > > after: >textdata bss dec hex filename > 277335600 256 335898335 drivers/med

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

On 29.06.2017 17:22, Eric Anholt wrote: > Andrzej Hajda <a.ha...@samsung.com> writes: > >> On 29.06.2017 07:03, Archit Taneja wrote: >>> On 06/28/2017 01:28 AM, Eric Anholt wrote: >>>> When a mipi_dsi_host is registered, the DT is walked to find any child >

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

On 29.06.2017 07:03, Archit Taneja wrote: > > On 06/28/2017 01:28 AM, Eric Anholt wrote: >> When a mipi_dsi_host is registered, the DT is walked to find any child >> nodes with compatible strings. Those get registered as DSI devices, >> and most DSI panel drivers are mipi_dsi_drivers that attach

Re: [PATCH 2/8] drm/vc4: Fix misleading name of the continuous flag.

On 27.06.2017 21:58, Eric Anholt wrote: > The logic was all right in the end, the name was just backwards. > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH 1/8] drm/vc4: Fix DSI T_INIT timing.

olt.net> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH 3/8] drm/vc4: Use drm_mode_vrefresh() in DSI fixup, in case vrefresh is 0.

On 27.06.2017 21:58, Eric Anholt wrote: > I'm not sure what changed where I started getting vrefresh=0 from the > mode to be fixed up. It can be a case of low pixel_clock value, maybe it should be investigated further, unless there is execution path with forgotten mode->vrefresh =

Re: [PATCH 4/8] drm/bridge: Add a devm_ allocator for panel bridge.

void *res) > +{ > + struct drm_bridge *bridge = *(struct drm_bridge **)res; > + > + drm_panel_bridge_remove(bridge); I guess more elegant would be: struct drm_bridge **bridge = res; drm_panel_bridge_remove(*bridge); I am still not convinced to the idea of this panel_bridge stu

Re: [PATCH 5/8] drm/vc4: Delay DSI host registration until the panel has probed.

ma_mask; > int ret; > @@ -1599,6 +1577,20 @@ static int vc4_dsi_bind(struct device *dev, struct > device *master, void *data) > return ret; > } > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > +

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

Hi Jose, On 26.04.2017 12:48, Jose Abreu wrote: > Some crtc's may have restrictions in the mode they can display. In > this patch a new callback (crtc->mode_valid()) is introduced that > is called at the same stage of connector->mode_valid() callback. > > This shall be implemented if the crtc has

Re: [PATCH v3 2/6] drm: Add drm_{crtc/encoder/connector}_mode_valid()

com> > Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> > Cc: Andrzej Hajda <a

Re: [PATCH v3 5/6] drm: Use mode_valid() in atomic modeset

el.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> > Cc: Andrzej Hajda <a.ha...@samsung.com> > Cc: Archit Taneja <arch...@codeaurora.org> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

DE_OK. > > Signed-off-by: Jose Abreu <joab...@synopsys.com> > Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave

Re: [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

On 15.05.2017 11:30, Daniel Vetter wrote: > On Mon, May 15, 2017 at 10:39:35AM +0200, Andrzej Hajda wrote: >> On 11.05.2017 11:06, Jose Abreu wrote: >>> This changes the connector probe helper function to use the new >>> encoder->mode_valid(), bridge->mode_valid()

Re: [PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback

t; Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> > Cc: Andrzej Hajda <a.ha..

Re: [PATCH v3 0/6] Introduce new mode validation callbacks

e helper >> drm: Use mode_valid() in atomic modeset >> drm: arc: Use crtc->mode_valid() callback >> >> Cc: Carlos Palminha <palmi...@synopsys.com> >> Cc: Alexey Brodkin <abrod...@synopsys.com> >> Cc: Ville Syrjälä <ville.syrj...@linux

Re: [PATCH 1/3] dt-bindings: Add support for samsung s6e63j0x03 panel binding

voltage supply for analog circuits > + - reset-gpios: a GPIO spec for the reset pin (active high) Usually reset gpios is active low, also driver code suggests it, if it is true please fix example also. With above comments addressed: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>

Re: [PATCH 2/3] drm/panel: Add support for s6e63j0x03 panel driver

Hi Hoegeun, Nice to see patches completing support for mainlined platforms. On 09.06.2017 06:59, Hoegeun Kwon wrote: > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320×320 resolution in 1.63" physical

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 11:23, Boris Brezillon wrote: > On Thu, 22 Jun 2017 13:47:43 +0530 > Archit Taneja wrote: > >> On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: >>> 2017-06-20 19:31 GMT+02:00 Eric Anholt : Archit Taneja writes:

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 14:41, Boris Brezillon wrote: > On Thu, 22 Jun 2017 14:29:07 +0200 > Andrzej Hajda <a.ha...@samsung.com> wrote: > >> On 22.06.2017 11:23, Boris Brezillon wrote: >>> On Thu, 22 Jun 2017 13:47:43 +0530 >>> Archit Taneja <arch...@codeaurora.org

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

Hi Shuah, On 24.06.2017 02:56, Shuah Khan wrote: > Fix to call of_node_put() right after of_drm_find_bridge() instead of > holding on to it until exynos_dsi_remove(). I think the current implementation is OK, node is get in probe and put in remove. There could be many bind/unbind during

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 15:34, Boris Brezillon wrote: > On Thu, 22 Jun 2017 15:16:47 +0200 > Andrzej Hajda <a.ha...@samsung.com> wrote: > >> On 22.06.2017 14:41, Boris Brezillon wrote: >>> On Thu, 22 Jun 2017 14:29:07 +0200 >>> Andrzej Hajda <a.ha...@samsung.com>

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

On 27.06.2017 11:13, Inki Dae wrote: > Hi Andrzej, > > 2017년 06월 26일 16:02에 Andrzej Hajda 이(가) 쓴 글: >> Hi Shuah, >> >> >> On 24.06.2017 02:56, Shuah Khan wrote: >>> Fix to call of_node_put() right after of_drm_find_bridge() instead of >>> hol

Re: [PATCH v2 2/4] drm/panel: Add support for s6e63j0x03 panel driver

On 15.06.2017 12:03, Hoegeun Kwon wrote: > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320×320 resolution in 1.63" physical panel. This panel is used in > Samsung Galaxy Gear 2. > > Signed-off-by: Inki Dae

Re: [PATCH] drm: exynos: hdmi: make of_device_ids const.

drm/exynos/exynos_hdmi.o > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] drm: exynos: constify mixer_match_types and *_mxr_drv_data.

dec hex filename > 11231 176 0 114072c8f > drivers/gpu/drm/exynos/exynos_mixer.o > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/exynos/

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

On 04.05.2017 14:35, Thierry Reding wrote: > On Thu, May 04, 2017 at 07:44:08AM +0200, Daniel Vetter wrote: >> On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: >>> Laurent Pinchart writes: >>> Hi Daniel, On Wednesday 03 May

Re: [PATCH v4 3/3] mfd: arizona: Refactor arizona_poll_reg

Hi Charles, On 15.03.2017 15:58, Charles Keepax wrote: > Currently, we specify the timeout in terms of the number of polls but it > is more clear from a user of the functions perspective to specify the > timeout directly in milliseconds, as such update the function to these new > semantics. > >

Re: [RESEND PATCH v2 4/5] drm/bridge/analogix: Do not use device's drvdata

sting their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa <tf...@chromium.org> > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Thanks for making it a bit saner. Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>  -- Regards Andrzej

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

Hi Rob, Thanks for review. On 06.10.2017 01:12, Rob Herring wrote: > On Thu, Sep 28, 2017 at 03:07:27PM +0200, Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB conne

[RFC PATCH 0/4] dt-bindings: add bindings for USB physical connector

Hi, This patchset introduces USB connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. Regards Andrzej Andrzej Hajda (3): dt-bindings: add bindings for USB physical connector arm64: dts: exynos: add micro-USB connector

[RFC PATCH 4/4] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[RFC PATCH 3/4] extcon: add possibility to get extcon device by of node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/extcon/extcon.c | 44 ++-- i

[RFC PATCH 2/4] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 47 -- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/arch/arm64/bo

[RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- There are few things for discussion (IMO): 1. vendor specific connectors, I have added them here, but maybe better is to place them in separate files. 2. physical connector description - I have split it to

Re: [PATCH v3 1/3] drm/bridge/synopsys: dsi: Constify funcs structures

ic struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > .mode_set = dw_mipi_dsi_bridge_mode_set, > .enable = dw_mipi_dsi_bridge_enable, > .post_disable = dw_mipi_dsi_bridge_post_disable, Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v3 2/3] drm/bridge/synopsys: dsi: Register list clean up

NU <philippe.co...@st.com> > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

Unable to get reset control: %d\n", ret); > - return ERR_PTR(ret); > - } > + dev_err(dev, "Unable to get reset control: %d\n", ret); I think in case of deferred probing it shouldn't be dev_err, but this is rather suggestion. > + return ERR_PTR(ret); return apb_rst; With this fixed: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > } > > if (apb_rst) {

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

On 06.10.2017 19:23, Rob Herring wrote: > On Fri, Oct 6, 2017 at 6:10 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> Hi Rob, >> >> Thanks for review. >> >> On 06.10.2017 01:12, Rob Herring wrote: >>> On Thu, Sep 28, 2017 at 03:07:27PM +0200,

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

Hi Laurent, Thank you for the review. On 18.10.2017 17:11, Laurent Pinchart wrote: > Hi Andrzej, > > Thank you for the patch. > > On Thursday, 28 September 2017 16:07:27 EEST Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >>

Re: [PATCH v5 4/9] drm/bridge: analogix_dp: Fix connector & encoder cleanup

} > > + rockchip_drm_psr_register(>encoder, analogix_dp_psr_set); You are changing here order of calls: psr_reg after bind, it does not seem to be related to patch subject. Anyway psr_register can fail and its result is not checked, but it can be addressed in separate patch. So may

Re: [PATCH] drm/bridge: analogix_dp: Use relaxed MMIO accessors

On 18.12.2017 12:39, Marc Zyngier wrote: > The analogix DP bridge is entierely driven via MMIO accesses, and > does not do any DMA that requires coherency with the CPU. Yet, the > driver uses the non-relaxed accessors, forcing strong barriers to > be emitted on architectures with a relaxed memory

Re: [PATCH 2/2] media: s5p-mfc: fix lock confection - request_firmware() once and keep state

On 06.10.2017 23:30, Shuah Khan wrote: > Driver calls request_firmware() whenever the device is opened for the > first time. As the device gets opened and closed, dev->num_inst == 1 > is true several times. This is not necessary since the firmware is saved > in the fw_buf. s5p_mfc_load_firmware()

Re: [PATCH 1/2] media: s5p-mfc: check for firmware allocation before requesting firmware

Hi Shuah, On 06.10.2017 23:30, Shuah Khan wrote: > Check if firmware is allocated before requesting firmware instead of > requesting firmware only to release it if firmware is not allocated. > > Signed-off-by: Shuah Khan > --- >

Re: drivers/gpu/drm/bridge/sil-sii8620.c:2229: undefined reference to `extcon_find_edev_by_node'

On 06.05.2018 02:46, Randy Dunlap wrote: > On 05/05/2018 04:22 PM, kbuild test robot wrote: >> Hi Maciej, >> >> FYI, the error/warning still remains. > Hi M. Robot, > > I am cc-ing dri-de...@lists.freedesktop.org so that they are aware of the > multiple times that you have posted this kbuild error

Re: [PATCH v2 03/13] drm/kms/mode/exynos-dsi: using helper func drm_display_mode_to_videomode for calculating timing parameters

Hi Satendra Singh Thakur, On 07.05.2018 05:32, Satendra Singh Thakur wrote: > To avoid duplicate logic for the same > > Signed-off-by: Satendra Singh Thakur > Acked-by: Madhur Verma > Cc: Hemanshu Srivastava Whole

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

On 04.05.2018 15:52, Peter Rosin wrote: > If the bridge supplier is unbound, this will bring the bridge consumer > down along with the bridge. Thus, there will no longer linger any > dangling pointers from the bridge consumer (the drm_device) to some > non-existent bridge supplier. I understand

Re: [PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings

On 31.01.2018 16:57, Andrzej Hajda wrote: > extcon device is used to detect host/device connection. Since extcon > OF property is deprecated, alternative method should be added. > This method uses OF graph bindings to locate extcon. > > Signed-off-by: Andrzej Hajda <a.ha...@samsu

[PATCH] PM / core: refactor PM_OPS initializers

these functions with __maybe_unused. Solution was tested successfully with multiple versions of gcc since 4.9.4 up to 7.2.1. No functional changes has been observed and callbacks were compiled out if not used, as before. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- include/linux/pm.

Re: [PATCH] PM / core: refactor PM_OPS initializers

On 14.05.2018 10:21, Andrzej Hajda wrote: > With current implementation of PM_OPS initializers users should annotate > all PM callbacks with __maybe_unused attribute to prevent compiler from > complaining in case respective option is not enabled. Using ternary > operator with IS_EN

Re: [PATCH v2 2/2] drm/bridge: sii902x: add optional power supplies

On 14.05.2018 11:38, Philippe CORNU wrote: > Hi Laurent, Archit, Andrzej & Yannick, > > Do you have any comments on this v2 driver part? > (more details regarding v1/v2 differences in the cover letter > https://www.spinics.net/lists/dri-devel/msg174137.html) > > Thank you, > Philippe :-) > > > On

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

On 07.05.2018 15:53, Daniel Vetter wrote: > On Mon, May 07, 2018 at 02:59:45PM +0200, Andrzej Hajda wrote: >> On 04.05.2018 15:52, Peter Rosin wrote: >>> If the bridge supplier is unbound, this will bring the bridge consumer >>> down along with the bridge. Thus, ther

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

On 07.05.2018 15:43, Peter Rosin wrote: > On 2018-05-07 14:59, Andrzej Hajda wrote: >> On 04.05.2018 15:52, Peter Rosin wrote: >>> If the bridge supplier is unbound, this will bring the bridge consumer >>> down along with the bridge. Thus, there will no longer linger any

Re: [PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device

On 04.05.2018 15:51, Peter Rosin wrote: > Bridge drivers can now (temporarily, in a transition phase) select if > they want to provide a full owner device or keep just providing an > of_node. > > By providing a full owner device, the bridge drivers no longer need > to provide an of_node since that

Re: [PATCH 00/24] device link, bridge supplier <-> drm device

Hi Peter, On 27.04.2018 00:31, Peter Rosin wrote: > Hi! > > It was noted by Russel King [1] that bridges (not using components) > might disappear unexpectedly if the owner of the bridge was unbound. > Jyri Sarha had previously noted the same thing with panels [2]. Jyri > came up with using device

Re: [PATCH 2/2] i2c: exynos5: remove pointless initializers

On 09.05.2018 21:45, Peter Rosin wrote: > The variables are always assigned before use anyway. > > Signed-off-by: Peter Rosin > --- > drivers/i2c/busses/i2c-exynos5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-exynos5.c >

Re: [PATCH 1/2] i2c: exynos5: remove some dead code

uot; label, use break instead, and at the end use "return (i == num) ? num : ret;" or sth similar. With this change you can add: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>  -- Regards Andrzej

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

3a4c 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -261,6 +261,7 @@ struct drm_bridge_timings { > * @list: to keep track of all added bridges > * @timings: the timing specification for the bridge, if any (may > * be NULL) > + * @link: drm consum

Re: [PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device

On 10.05.2018 00:21, Peter Rosin wrote: > On 2018-05-09 17:53, Peter Rosin wrote: >> On 2018-05-09 17:08, Andrzej Hajda wrote: >>> On 04.05.2018 15:51, Peter Rosin wrote: >>>> Bridge drivers can now (temporarily, in a transition phase) select if >>>>

Re: [PATCH v2 25/26] drm/bridge: require the owner .odev to be filled in on drm_bridge_add/attach

On 04.05.2018 15:52, Peter Rosin wrote: > The .odev owner device will be handy to have around. > > Signed-off-by: Peter Rosin <p...@axentia.se> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>  -- Regards Andrzej > --- > drivers/gpu/drm/drm_bridge.c | 6 ++ >

[PATCH v2 0/2] USB: dwc3: get extcon device by OF graph bindings

property is not present, added code allowing to fallback to OTG block also in case of graph is not present [1]: https://marc.info/?i=20180131134435.12216-1-a.hajda%40samsung.com Regards Andrzej Andrzej Hajda (2): USB: dwc3: get extcon device by OF graph bindings arm64: dts: exynos: add OF graph betwee

Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static

On 18.05.2018 09:38, Roger Quadros wrote: > On 18/05/18 08:39, Andrzej Hajda wrote: >> On 17.05.2018 18:06, kbuild test robot wrote: >>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings") >>> Signed-off-by: kbuild test robot <fenggu

Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static

On 17.05.2018 18:06, kbuild test robot wrote: > Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings") > Signed-off-by: kbuild test robot <fengguang...@intel.com> It should be static of course, my bad. Reviewed-by: Andrzej Hajda <a.ha...@samsung.

[PATCH v2 1/2] USB: dwc3: get extcon device by OF graph bindings

extcon device is used to detect host/device connection. Since extcon OF property is deprecated, alternative method should be added. This method uses OF graph bindings to locate extcon. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/usb/dwc3/drd.

[PATCH v2 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../dts/exynos/exynos5433-tm2-common.dtsi

Re: [PATCH] drm/bridge/synopsys: dsi: use adjusted_mode in mode_set

On 25.01.2018 16:55, Philippe Cornu wrote: > The "adjusted_mode" clock value (ie the real pixel clock) is more > accurate than "mode" clock value (ie the panel/bridge requested > clock value). It offers a better preciseness for timing > computations and allows to reduce the extra dsi bandwidth in

Re: [PATCH] drm/bridge/synopsys: dsi: add optional pixel clock

On 26.10.2017 18:09, Philippe Cornu wrote: > The pixel clock is optional. When available, it offers a better > preciseness for timing computations. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 24 ++-- > 1

Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: handle endianness correctly in dw_mipi_dsi_write()

ader, sizeof(packet->header)); > + return dw_mipi_dsi_gen_pkt_hdr_write(dsi, le32_to_cpu(word)); You could create and use appropriate helper, lets say: u32 le_to_cpup(const u8 *p, int count) {     __le32 r = 0;     memcpy(, p, count);     return le32_to_cpu(r); } With or without this change: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>  -- Regards Andrzej > } > > static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host,

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

On 09.01.2018 14:37, Laurent Pinchart wrote: > Hi Philippe, > > On Tuesday, 9 January 2018 15:01:02 EET Philippe CORNU wrote: >> Hi Archit, Andrzej & Laurent, >> >> Regarding this patch from Brian, I think it could be nice to merge it >> (1xAcked-by, 2xReviewed-by). >> >> Could you please have a

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

On 15.01.2018 15:40, Philippe CORNU wrote: > Hi Andrzej, > > On 01/15/2018 02:52 PM, Andrzej Hajda wrote: >> On 12.01.2018 17:25, Philippe Cornu wrote: >>> The pixel clock is optional. When available, it offers a better >>> preciseness for timing computations a

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

Philippe Cornu <philippe.co...@st.com> > --- > Changes in v2: Improve px_clk probing in case of ENOENT dt returned value > (thanks to Philipp Zabel & Andrzej Hajda comments) > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 26 -- > 1 file changed, 20 i

Re: [PATCH] drm/dsi: Fix improper use of mipi_dsi_device_transfer() return value

to PTR_ERR_OR_ZERO, but this is also OK. Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>  -- Regards Andrzej > --- > drivers/gpu/drm/drm_mipi_dsi.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers

Re: [PATCH v1 1/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

On 24.01.2018 19:37, Brian Norris wrote: > Hi Philippe, > > On Wed, Jan 24, 2018 at 01:33:54PM +, Philippe CORNU wrote: >> On 01/23/2018 10:38 PM, Brian Norris wrote: >>> Hi Philippe, >>> >>> On Tue, Jan 23, 2018 at 6:26 AM, Philippe Cornu >>> wrote: The

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

On 24.01.2018 10:51, Philippe CORNU wrote: > Hi Brian, > > On 01/23/2018 10:15 PM, Brian Norris wrote: >> Hi Philippe, >> >> On Thu, Jan 18, 2018 at 11:40:48AM +, Philippe CORNU wrote: >>> On 01/11/2018 12:16 PM, Philippe CORNU wrote: To be honest, I do not really like the memcpy here too

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

On 11.01.2018 14:51, Philippe CORNU wrote: > Hi Brian & All *DSI DRM experts*, > > 1) Re-reading this patch, I realize that the returned value of > dw_mipi_dsi_host_transfer() is not correct: we should return the number > of transfered/received bytes... > > so I think there are two solutions:

[RFC PATCH v2 5/5] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[RFC PATCH v2 3/5] arm64: dts: exynos: add OF graph between MHL and USB connector

OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/arch/arm64/bo

[RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v2: - moved connector type(A,B,C) to compatible string (Rob), - renamed size property to type (Rob), - changed type description to be less confusing (Laurent), - removed vendor specific compatibles (implied by grap

[RFC PATCH v2 2/5] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.d

[RFC PATCH v2 0/5] dt-bindings: add bindings for USB physical connector

Hi, This patchset introduces USB physical connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. In v2 I have addressed comments by Rob and Laurent, thanks Changes are described in patches. Regards Andrzej Andrzej Hajda (4

[RFC PATCH v2 4/5] extcon: add possibility to get extcon device by OF node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v2: changed label to

[PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dts

<    2   3   4   5   6   7   8   9   10   11   >