Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

On 09.11.2016 07:45, Greg Kroah-Hartman wrote: > On Tue, Nov 08, 2016 at 09:58:24PM +0100, Luis R. Rodriguez wrote: Furthermore -- how does this framework compare to Andrzej's resource tracking solution? I confess I have not had a chance yet to review yet but in light of

Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate".

Hi Jani, Forgive me late response. On 12.10.2016 16:28, Jani Nikula wrote: > On Wed, 12 Oct 2016, Emil Velikov wrote: >> On 11 October 2016 at 10:33, Jani Nikula wrote: >>> On Tue, 11 Oct 2016, "Sun, Jing A" wrote:

Re: [PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of odroid-xu3/4

On 22.11.2016 02:24, Jaehoon Chung wrote: > On 11/22/2016 02:06 AM, Krzysztof Kozlowski wrote: >> On Mon, Nov 21, 2016 at 04:10:32PM +0900, Jaehoon Chung wrote: >>> Odroid-xu3/4 didn't need to use the cd-gpios for detecting card. >>> Because Host controller has the CDETECT register through SDx_CDN

Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate".

On 11.10.2016 11:33, Jani Nikula wrote: > On Tue, 11 Oct 2016, "Sun, Jing A" wrote: >> It's needed that DRM Driver module could be removed and reloaded after >> kernel booting on the projects that I have been working on, and I hope >> such module type change could be

Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate".

Hi, This patch misses dsi bus un-registration. However I have reviewed two patches of Takashi which solves the same issue more completely [1]. These patches were not accepted neither. [1]: https://lists.freedesktop.org/archives/dri-devel/2016-August/114870.html Regards Andrzej On 11.10.2016

Re: [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap

Hi, On 17.10.2016 13:09, Arvind Yadav wrote: > Free memory mapping, if hdmi_probe is not successful. > > Signed-off-by: Arvind Yadav Subject prefix is incorrect. > --- > drivers/gpu/drm/exynos/exynos_hdmi.c |2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH 1/2] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

On 14.12.2016 07:04, Hoegeun Kwon wrote: > This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel > driver. This panel has 1440x2560 resolution in 5.7-inch physical > panel in the TM2 device. > > Signed-off-by: Donghwa Lee > Signed-off-by: Hyungwon Hwang

Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

On 11.01.2017 11:23, hoegeun kwon wrote: > > On 01/11/2017 06:39 PM, Andrzej Hajda wrote: >> On 11.01.2017 09:40, Inki Dae wrote: >>> 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: >>>> On 11.01.2017 07:33, Hoegeun Kwon wrote: >>>>&g

Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

On 11.01.2017 09:40, Inki Dae wrote: > > 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: >> On 11.01.2017 07:33, Hoegeun Kwon wrote: >>> From: Hyungwon Hwang <human.hw...@samsung.com> >>> >>> This patch add the panel device tree node for S6E3HA2 display

Re: [PATCH v8 1/3] dt-bindings: Add support for samsung s6e3ha2 panel binding

ned-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> > Tested-by: Chanwoo Choi <cw00.c...@samsung.com> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> > --- > .../bindings/display/panel/samsung,s6e3ha2.txt | 26 > ++ > 1 file changed, 26 insertion

Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

On 11.01.2017 07:33, Hoegeun Kwon wrote: > From: Hyungwon Hwang <human.hw...@samsung.com> > > This patch add the panel device tree node for S6E3HA2 display > controller to TM2 dts. > > Signed-off-by: Hyungwon Hwang <human.hw...@samsung.com> > Signed-off-by: A

Re: [PATCH v5 1/3] drm/exynos: mic: Add mode_set callback function

ruct through > mode_set callback function. > > Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Only one, non-blocking comment below. > --- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 30 +++---

Re: [PATCH v3 0/2] Add support for the S6E3HA2 panel on TM2 board

On 30.12.2016 07:58, Hoegeun Kwon wrote: > Purpose of this patch is add support for S6E3HA2 AMOLED panel on > the TM2 board. The first patch adds support for S6E3HA2 panel > device tree document and driver, the second patch add support for > S6E3HA2 panel device tree. > > Changes for V3: > > - In

Re: [PATCH v6 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

Hyungwon Hwang <human.hw...@samsung.com> > Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> > Tested-by: Chanwoo Choi <cw00.c...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Regards Andrzej

Re: [PATCH v5 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

On 04.01.2017 15:44, Rob Herring wrote: > On Wed, Jan 04, 2017 at 05:15:10PM +0900, Hoegeun Kwon wrote: >> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel >> driver. This panel has 1440x2560 resolution in 5.7-inch physical >> panel in the TM2 device. >> >> Signed-off-by: Donghwa Lee

Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function

t; > Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

On 09.01.2017 10:19, Inki Dae wrote: > > 2017년 01월 09일 16:37에 Andrzej Hajda 이(가) 쓴 글: >> On 06.01.2017 09:36, Inki Dae wrote: >>> 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >>>> Hi Inki, >>>> >>>> Thanks for the reply, but... >&g

Re: [PATCH v5 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

On 04.01.2017 09:15, Hoegeun Kwon wrote: > From: Hyungwon Hwang <human.hw...@samsung.com> > > This patch add the panel device tree node for S6E3HA2 display > controller to TM2 dts. > > Signed-off-by: Hyungwon Hwang <human.hw...@samsung.com> > Signed-off-by: A

Re: [PATCH v5 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

On 04.01.2017 09:15, Hoegeun Kwon wrote: > This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel > driver. This panel has 1440x2560 resolution in 5.7-inch physical > panel in the TM2 device. > > Signed-off-by: Donghwa Lee > Signed-off-by: Hyungwon Hwang

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

On 06.01.2017 09:36, Inki Dae wrote: > > 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >> Hi Inki, >> >> Thanks for the reply, but... >> > +static const struct drm_display_mode default_mode = { > + .clock = 222372, > + .hdisplay = 1440, > + .hsync_start = 1440 + 1, > + .hsync_end =

Re: [PATCH v2 1/2] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

Hi Hoegeun Kwon, Thanks for the patch. On 27.12.2016 10:05, Hoegeun Kwon wrote: > This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel > driver. This panel has 1440x2560 resolution in 5.7-inch physical > panel in the TM2 device. > > Signed-off-by: Donghwa Lee >

Re: [Patch v2 10/11] s5p-mfc: Add support for HEVC encoder

Hi Smitha, Sorry for late reply, it seems I have missed this email. On 14.03.2017 12:41, Smitha T Murthy wrote: > On Tue, 2017-03-07 at 12:33 +0100, Andrzej Hajda wrote: >> On 03.03.2017 10:07, Smitha T Murthy wrote: >>> Add HEVC encoder support and necessary registers, V4L2

Re: [Patch v3 00/11] Add MFC v10.10 support

d definitions > * Update computation of min scratch buffer size requirement for V8 onwards > > Changes since v2: > - Addressed review comments by Andrzej Hajda. > - Rebased on latest krzk/for-next tree. > - This patches are tested on top of Marek's patch v2 [1] > - Applied acked-by

Re: [PATCH 20/41] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy

On 10.03.2017 05:32, Sean Paul wrote: > From: zain wang > > Following the correct power up sequence: > dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00 Please fix the message. > > Cc: Stéphane Marchesin > Signed-off-by: zain wang >

Re: [PATCH] drm: bridge: dw-hdmi: add HDMI vendor specific infoframe config

On 20.03.2017 07:10, Nickey Yang wrote: > Vendor specific infoframe is mandatory for 4K2K resolution. > Without this, the HDMI protocol compliance fails. > > Signed-off-by: Nickey Yang > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 50 >

Re: [PATCH v2 2/3] Input: add support for the STMicroelectronics FingerTip touchscreen

Hi Andi, On 10.02.2017 03:17, Andi Shyti wrote: (...) > + > + err = devm_request_threaded_irq(>dev, client->irq, > + NULL, stmfts_irq_handler, > + IRQF_ONESHOT | IRQF_TRIGGER_LOW, > +

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi Philipp, Todays next branch does not work with exynos5433-tm2 board. I guess this patch causes regression. On MMC without reset controller I get errors: [4.938222] dwmmc_exynos 1554.mshc: platform data not available [4.943268] dwmmc_exynos: probe of 1554.mshc failed with error

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 20.03.2017 11:27, Philipp Zabel wrote: > Hi Andrzej, > > On Mon, 2017-03-20 at 11:03 +0100, Andrzej Hajda wrote: >> Hi Philipp, >> >> On 20.03.2017 10:53, Philipp Zabel wrote: >>> On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: >>>> Hi Phi

Re: [PATCH] reset: fix optional reset_control_get stubs to return NULL

On 20.03.2017 11:42, Philipp Zabel wrote: > When RESET_CONTROLLER is not enabled, the optional reset_control_get > stubs should now also return NULL. > > Fixes: bb475230b8e5 ("reset: make optional functions really optional") > Reported-by: Andrzej Hajda <a.ha...@samsun

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

Hi Philipp, On 20.03.2017 10:53, Philipp Zabel wrote: > On Mon, 2017-03-20 at 10:22 +0100, Andrzej Hajda wrote: >> Hi Philipp, >> >> Todays next branch does not work with exynos5433-tm2 board. >> I guess this patch causes regression. On MMC without reset

Re: [PATCH v2] reset: fix optional reset_control_get stubs to return NULL

nt for optional > resets, the stubs are not allowed to warn anymore. > > Fixes: bb475230b8e5 ("reset: make optional functions really optional") > Reported-by: Andrzej Hajda <a.ha...@samsung.com> > Cc: Ramiro Oliveira <ramiro.olive...@synopsys.com> > Signed-off-

Re: [PATCH] drm/exynos: Print kernel pointers in a restricted form

Hi Tobias, On 14.03.2017 21:41, Tobias Jakobi wrote: > Krzysztof Kozlowski wrote: >> On Tue, Mar 14, 2017 at 08:17:35PM +0100, Tobias Jakobi wrote: >>> Krzysztof Kozlowski wrote: On Tue, Mar 14, 2017 at 08:01:41PM +0100, Tobias Jakobi wrote: > Hello Krzysztof, > > I was wondering

Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder

On 31.03.2017 11:06, Smitha T Murthy wrote: > Add HEVC encoder support and necessary registers, V4L2 CIDs, > and hevc encoder parameters > > Signed-off-by: Smitha T Murthy > --- > drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 28 +- >

Re: [Patch v3 04/11] [media] s5p-mfc: Support MFCv10.10 buffer requirements

On 31.03.2017 11:06, Smitha T Murthy wrote: > Aligning the luma_dpb_size, chroma_dpb_size, mv_size and me_buffer_size > for MFCv10.10. > > Signed-off-by: Smitha T Murthy <smith...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v5 04/12] drm: bridge: analogix: Destroy connector & encoder when unbinding

move if necessary, to allow connector and encoder to live little bit longer, and be destroyed by drm core. This is just suggestion, I am not familiar enough with the driver to make stronger statements :) Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > > Chan

Re: [PATCH v5 03/12] drm: bridge: analogix: Disable clock when unbinding

On 06.04.2017 14:31, Jeffy Chen wrote: > The clock is enabled when binding analogix dp. > > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > > Changes in v5: None > Changes in v4: Non

Re: [PATCH v3 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp

On 05.04.2017 10:29, Jeffy Chen wrote: > The panel is attached when binding analogix dp. > > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > > Changes in v3: None > Changes

Re: [PATCH] MAINTAINERS: Add Laurent and Andrzej as maintainers for bridge drivers

On 05.04.2017 13:23, Archit Taneja wrote: > Add Laurent and Andrzej as maintainers for DRM bridge chip drivers. They > actively review and contribute to bridge drivers and the bridge API. > > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Andrzej Hajda

Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag

ge/parade-ps8622.c > index 1dcec3b..ada2186 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8622.c > +++ b/drivers/gpu/drm/bridge/parade-ps8622.c > @@ -28,10 +28,10 @@ > #include > #include > > -#include "drmP.h" > -#include "drm_crtc.

Re: [PATCH 1/3] dt-bindings: Add support for samsung s6e3ha2 edge panel binding

Hi Hoegeun, On 14.04.2017 07:19, Hoegeun Kwon wrote: > The Samsung s6e3ha2 edge is a 5.65" 1600x2560 AMOLED panel connected > using MIPI-DSI interfaces. As I wrote in discussion about s6e3ha2, there is no edge version of s6e3ha2, it is just different panel: s6e3hf2, or more precisely IC driver.

Re: [PATCH 2/3] drm/panel: s6e3ha2: Add support for S6eHEA2 edge panel on TM2e board

Hi Hoegeun, The patch looks OK, below small nitpicks. On 14.04.2017 07:19, Hoegeun Kwon wrote: > This patch considers edge type of panel on TM2e board and The panel > has 1600x2560 resolution in 5.65" physical panel in the TM2e device. > > This identify panel type with compatibility string, also

Re: [PATCH v2 1/3] dt-bindings: Add support for samsung s6e3hf2 panel

tring and > comments. > > Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ?

On 09.03.2017 08:34, Inki Dae wrote: > Hello David, > > Thanks for report. > > 2017년 03월 06일 19:05에 David Binderman 이(가) 쓴 글: >> Hello there, >> >> linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) >> Result of operator '|' is always true if one operand is non-zero. Did

Re: [PATCH v2] drm/rockchip: Refactor the component match logic.

n <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Below few nitpicks. (...) > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index b360e62..b6bccfc 100644 > --- a/drivers/gpu/drm/rockchip/

Re: [Patch v2 02/11] s5p-mfc: Adding initial support for MFC v10.10

On 03.03.2017 10:07, Smitha T Murthy wrote: > Adding the support for MFC v10.10, with new register file and > necessary hw control, decoder, encoder and structural changes. > > Signed-off-by: Smitha T Murthy <smith...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsu

Re: [Patch v2 04/11] s5p-mfc: Support MFCv10.10 buffer requirements

On 03.03.2017 10:07, Smitha T Murthy wrote: > Aligning the luma_dpb_size, chroma_dpb_size, mv_size and me_buffer_size > for MFCv10.10. > > Signed-off-by: Smitha T Murthy > --- > drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 19 + >

Re: [Patch v2 03/11] s5p-mfc: Use min scratch buffer size as provided by F/W

. > > Signed-off-by: Smitha T Murthy <smith...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [Patch v2 05/11] videodev2.h: Add v4l2 definition for HEVC

On 03.03.2017 10:07, Smitha T Murthy wrote: > Add V4L2 definition for HEVC compressed format > > Signed-off-by: Smitha T Murthy <smith...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > include/uapi/linux/videodev2.h |

Re: [Patch v2 07/11] Documentation: v4l: Documentation for HEVC v4l2 definition

On 03.03.2017 10:07, Smitha T Murthy wrote: > Add V4L2 definition for HEVC compressed format > > Signed-off-by: Smitha T Murthy <smith...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> > --- > Documentation/media/uapi/v4l/pixfmt-013.rst |5

Re: [Patch v2 09/11] v4l2: Add v4l2 control IDs for HEVC encoder

te MVs"; > + case V4L2_CID_MPEG_VIDEO_HEVC_WITHOUT_STARTCODE_ENABLE: return "HEVC > ENC without startcode enable"; > + case V4L2_CID_MPEG_VIDEO_HEVC_REFRESH_PERIOD: return "HEVC > Number of reference picture"; > +

Re: [Patch v2 10/11] s5p-mfc: Add support for HEVC encoder

On 03.03.2017 10:07, Smitha T Murthy wrote: > Add HEVC encoder support and necessary registers, V4L2 CIDs, > and hevc encoder parameters > > Signed-off-by: Smitha T Murthy > --- > drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 28 +- >

Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs

On 03.03.2017 10:07, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder It should be rather "Document controls for HEVC encoder" or sth similar. In general most of comments are in previous patch. Few additional comments: - please be careful about control names - they are exported to

Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ?

Hi David, Inki, Thanks for reporting. On 06.03.2017 11:05, David Binderman wrote: > Hello there, > > linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) > Result of operator '|' is always true if one operand is non-zero. Did you > intend to use '&'? > > Source code is

Re: [PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when unbinding

On 05.04.2017 10:29, Jeffy Chen wrote: > The dp aux is registered when binding analogix dp. > > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Btw, if you are working already in this area you can check also to analog

Re: [PATCH v3 3/9] drm: bridge: analogix: Destroy connector when unbinding

ips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> One comment below > --- > > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/a

Re: [PATCH v2 2/3] drm/panel: s6e3ha2: Add support for s6e3hf2 panel on TM2e board

3ha2 > compatibility and s6e3hf2 type and select the drm_display_mode of > default and edge type. > > Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board

t is not necessary and generates useless interrupts. Beside this: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/b

Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board

On 18.04.2017 09:44, Hoegeun Kwon wrote: > On 04/18/2017 03:00 PM, Andrzej Hajda wrote: >> On 17.04.2017 08:02, Hoegeun Kwon wrote: >>> This patch add the panel device tree node for s6e3hf2 display >>> controller to TM2e dts. >>> >>> Signed-off-by: Hoe

Re: [PATCH v6 2/5] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.

t; However, we can maintain a more exact vrefresh value (not just the > integer approximation), by scaling by the ratio of our clocks. > > v2: Use math suggested by Andrzej Hajda instead. > v3: Simplify math now that adjusted_mode->clock isn't padded. > > Signed-off-by: Eric An

Re: [PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

On 12.07.2017 15:25, Andrzej Hajda wrote: > On 27.06.2017 04:11, Hoegeun Kwon wrote: >> This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver >> which uses mipi_dsi bus to communicate with panel. The panel has >> 320×320 resolution in 1.63" physical

Re: [PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

t; +} > + > +static int s6e63j0x03_prepare(struct drm_panel *panel) > +{ > + struct s6e63j0x03 *ctx = panel_to_s6e63j0x03(panel); > + int ret; > + > + ret = s6e63j0x03_power_on(ctx); > + if (ret < 0) > + return ret; > + > + r

Re: [PATCH 15/18] drm/panel: Add Huarui LHR050H41 panel driver

On 13.07.2017 16:13, Maxime Ripard wrote: > The LHR050H41 panel is the panel shipped with the BananaPi M2-Magic. Add a > driver for it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/panel/Kconfig | 9 +- >

Re: [PATCH] s5k5baf: remove unnecessary static in s5k5baf_get_selection()

and after the code change: > > before: >textdata bss dec hex filename > 277655656 320 3374183cd drivers/media/i2c/s5k5baf.o > > after: >textdata bss dec hex filename > 277335600 256 335898335 drivers/med

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

On 29.06.2017 17:22, Eric Anholt wrote: > Andrzej Hajda <a.ha...@samsung.com> writes: > >> On 29.06.2017 07:03, Archit Taneja wrote: >>> On 06/28/2017 01:28 AM, Eric Anholt wrote: >>>> When a mipi_dsi_host is registered, the DT is walked to find any child >

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

On 29.06.2017 07:03, Archit Taneja wrote: > > On 06/28/2017 01:28 AM, Eric Anholt wrote: >> When a mipi_dsi_host is registered, the DT is walked to find any child >> nodes with compatible strings. Those get registered as DSI devices, >> and most DSI panel drivers are mipi_dsi_drivers that attach

Re: [PATCH 2/8] drm/vc4: Fix misleading name of the continuous flag.

On 27.06.2017 21:58, Eric Anholt wrote: > The logic was all right in the end, the name was just backwards. > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH 1/8] drm/vc4: Fix DSI T_INIT timing.

olt.net> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH 3/8] drm/vc4: Use drm_mode_vrefresh() in DSI fixup, in case vrefresh is 0.

On 27.06.2017 21:58, Eric Anholt wrote: > I'm not sure what changed where I started getting vrefresh=0 from the > mode to be fixed up. It can be a case of low pixel_clock value, maybe it should be investigated further, unless there is execution path with forgotten mode->vrefresh =

Re: [PATCH 4/8] drm/bridge: Add a devm_ allocator for panel bridge.

void *res) > +{ > + struct drm_bridge *bridge = *(struct drm_bridge **)res; > + > + drm_panel_bridge_remove(bridge); I guess more elegant would be: struct drm_bridge **bridge = res; drm_panel_bridge_remove(*bridge); I am still not convinced to the idea of this panel_bridge stu

Re: [PATCH 5/8] drm/vc4: Delay DSI host registration until the panel has probed.

ma_mask; > int ret; > @@ -1599,6 +1577,20 @@ static int vc4_dsi_bind(struct device *dev, struct > device *master, void *data) > return ret; > } > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > +

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

Hi Jose, On 26.04.2017 12:48, Jose Abreu wrote: > Some crtc's may have restrictions in the mode they can display. In > this patch a new callback (crtc->mode_valid()) is introduced that > is called at the same stage of connector->mode_valid() callback. > > This shall be implemented if the crtc has

Re: [PATCH v3 2/6] drm: Add drm_{crtc/encoder/connector}_mode_valid()

com> > Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> > Cc: Andrzej Hajda <a

Re: [PATCH v3 5/6] drm: Use mode_valid() in atomic modeset

el.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> > Cc: Andrzej Hajda <a.ha...@samsung.com> > Cc: Archit Taneja <arch...@codeaurora.org> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

DE_OK. > > Signed-off-by: Jose Abreu <joab...@synopsys.com> > Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave

Re: [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

On 15.05.2017 11:30, Daniel Vetter wrote: > On Mon, May 15, 2017 at 10:39:35AM +0200, Andrzej Hajda wrote: >> On 11.05.2017 11:06, Jose Abreu wrote: >>> This changes the connector probe helper function to use the new >>> encoder->mode_valid(), bridge->mode_valid()

Re: [PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback

t; Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> > Cc: Andrzej Hajda <a.ha..

Re: [PATCH v3 0/6] Introduce new mode validation callbacks

e helper >> drm: Use mode_valid() in atomic modeset >> drm: arc: Use crtc->mode_valid() callback >> >> Cc: Carlos Palminha <palmi...@synopsys.com> >> Cc: Alexey Brodkin <abrod...@synopsys.com> >> Cc: Ville Syrjälä <ville.syrj...@linux

Re: [PATCH 1/3] dt-bindings: Add support for samsung s6e63j0x03 panel binding

voltage supply for analog circuits > + - reset-gpios: a GPIO spec for the reset pin (active high) Usually reset gpios is active low, also driver code suggests it, if it is true please fix example also. With above comments addressed: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>

Re: [PATCH 2/3] drm/panel: Add support for s6e63j0x03 panel driver

Hi Hoegeun, Nice to see patches completing support for mainlined platforms. On 09.06.2017 06:59, Hoegeun Kwon wrote: > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320×320 resolution in 1.63" physical

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 11:23, Boris Brezillon wrote: > On Thu, 22 Jun 2017 13:47:43 +0530 > Archit Taneja wrote: > >> On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: >>> 2017-06-20 19:31 GMT+02:00 Eric Anholt : Archit Taneja writes:

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 14:41, Boris Brezillon wrote: > On Thu, 22 Jun 2017 14:29:07 +0200 > Andrzej Hajda <a.ha...@samsung.com> wrote: > >> On 22.06.2017 11:23, Boris Brezillon wrote: >>> On Thu, 22 Jun 2017 13:47:43 +0530 >>> Archit Taneja <arch...@codeaurora.org

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

Hi Shuah, On 24.06.2017 02:56, Shuah Khan wrote: > Fix to call of_node_put() right after of_drm_find_bridge() instead of > holding on to it until exynos_dsi_remove(). I think the current implementation is OK, node is get in probe and put in remove. There could be many bind/unbind during

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 15:34, Boris Brezillon wrote: > On Thu, 22 Jun 2017 15:16:47 +0200 > Andrzej Hajda <a.ha...@samsung.com> wrote: > >> On 22.06.2017 14:41, Boris Brezillon wrote: >>> On Thu, 22 Jun 2017 14:29:07 +0200 >>> Andrzej Hajda <a.ha...@samsung.com>

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

On 27.06.2017 11:13, Inki Dae wrote: > Hi Andrzej, > > 2017년 06월 26일 16:02에 Andrzej Hajda 이(가) 쓴 글: >> Hi Shuah, >> >> >> On 24.06.2017 02:56, Shuah Khan wrote: >>> Fix to call of_node_put() right after of_drm_find_bridge() instead of >>> hol

Re: [PATCH v2 2/4] drm/panel: Add support for s6e63j0x03 panel driver

On 15.06.2017 12:03, Hoegeun Kwon wrote: > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320×320 resolution in 1.63" physical panel. This panel is used in > Samsung Galaxy Gear 2. > > Signed-off-by: Inki Dae

Re: [PATCH] drm: exynos: hdmi: make of_device_ids const.

drm/exynos/exynos_hdmi.o > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] drm: exynos: constify mixer_match_types and *_mxr_drv_data.

dec hex filename > 11231 176 0 114072c8f > drivers/gpu/drm/exynos/exynos_mixer.o > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/exynos/

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

On 04.05.2017 14:35, Thierry Reding wrote: > On Thu, May 04, 2017 at 07:44:08AM +0200, Daniel Vetter wrote: >> On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: >>> Laurent Pinchart writes: >>> Hi Daniel, On Wednesday 03 May

Re: [PATCH v4 3/3] mfd: arizona: Refactor arizona_poll_reg

Hi Charles, On 15.03.2017 15:58, Charles Keepax wrote: > Currently, we specify the timeout in terms of the number of polls but it > is more clear from a user of the functions perspective to specify the > timeout directly in milliseconds, as such update the function to these new > semantics. > >

Re: [RESEND PATCH v2 4/5] drm/bridge/analogix: Do not use device's drvdata

sting their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa <tf...@chromium.org> > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Thanks for making it a bit saner. Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>  -- Regards Andrzej

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

Hi Rob, Thanks for review. On 06.10.2017 01:12, Rob Herring wrote: > On Thu, Sep 28, 2017 at 03:07:27PM +0200, Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB conne

[RFC PATCH 0/4] dt-bindings: add bindings for USB physical connector

Hi, This patchset introduces USB connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. Regards Andrzej Andrzej Hajda (3): dt-bindings: add bindings for USB physical connector arm64: dts: exynos: add micro-USB connector

[RFC PATCH 4/4] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[RFC PATCH 3/4] extcon: add possibility to get extcon device by of node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/extcon/extcon.c | 44 ++-- i

[RFC PATCH 2/4] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 47 -- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/arch/arm64/bo

[RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- There are few things for discussion (IMO): 1. vendor specific connectors, I have added them here, but maybe better is to place them in separate files. 2. physical connector description - I have split it to

Re: [PATCH v3 1/3] drm/bridge/synopsys: dsi: Constify funcs structures

ic struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > .mode_set = dw_mipi_dsi_bridge_mode_set, > .enable = dw_mipi_dsi_bridge_enable, > .post_disable = dw_mipi_dsi_bridge_post_disable, Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v3 2/3] drm/bridge/synopsys: dsi: Register list clean up

NU <philippe.co...@st.com> > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

Unable to get reset control: %d\n", ret); > - return ERR_PTR(ret); > - } > + dev_err(dev, "Unable to get reset control: %d\n", ret); I think in case of deferred probing it shouldn't be dev_err, but this is rather suggestion. > + return ERR_PTR(ret); return apb_rst; With this fixed: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > } > > if (apb_rst) {

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

On 06.10.2017 19:23, Rob Herring wrote: > On Fri, Oct 6, 2017 at 6:10 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> Hi Rob, >> >> Thanks for review. >> >> On 06.10.2017 01:12, Rob Herring wrote: >>> On Thu, Sep 28, 2017 at 03:07:27PM +0200,

<    4   5   6   7   8   9   10   11   12   13   >