On Fri, Apr 16, 2021 at 09:15:34AM -0700, Dan Williams wrote:
> On Fri, Apr 16, 2021 at 1:58 AM Andy Shevchenko
> wrote:
> > On Fri, Apr 16, 2021 at 8:28 AM Dan Williams
> > wrote:
> > > On Thu, Apr 15, 2021 at 6:59 AM Andy Shevchenko
> > > wrot
+Cc: Greg.
Greg, can you pick up this one?
The subsystem seems orphaned and I see your name in the git history for the
recent submissions against that driver.
Id is 20210409164140.17337-1-andriy.shevche...@linux.intel.com
On Fri, Apr 09, 2021 at 07:41:40PM +0300, Andy Shevchenko wrote:
> Af
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote:
> > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to
> > the GPIO descriptor interface") broke GPIO handling completely
are.
Fixes: b2ebd4be6fa1 ("staging: fbtft: add fb_agm1264k-fl driver")
Signed-off-by: Andy Shevchenko
---
v2: new patch split from the bigger fix (Greg)
drivers/staging/fbtft/fb_agm1264k-fl.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/fbtft/fb_agm
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
v2: no changes
drivers/staging/fbtft/fbtft-core.c | 12
1 file changed, 4 insertions
gpio
descriptor")
Fixes: dbc4f989c878 ("Staging: fbtft: Fix probing of gpio descriptor")
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Jan Sebastian Götte
Cc: Phil Reid
Cc: Nishad Kamdar
Signed-off-by: Andy Shevchenko
---
v2: shrunk
Now, after a few fixes we may consider the conversion to
the GPIO descriptor API is done.
Signed-off-by: Andy Shevchenko
---
v2: new patch split from the bigger fix (Greg)
drivers/staging/fbtft/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/fbtft/TODO b/drivers
On Fri, Apr 16, 2021 at 04:37:48PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote:
> > > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to
&g
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote:
> > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to
> > the GPIO descriptor interface") broke GPIO handling completely
descriptor")
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Jan Sebastian Götte
Cc: Phil Reid
Cc: Nishad Kamdar
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/TODO | 5 -
drivers/staging/fbtft/fb_agm1264k-fl
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 12
1 file changed, 4 insertions(+), 8 deletions
On Fri, Apr 16, 2021 at 01:28:21PM +0530, Aneesh Kumar K.V wrote:
> On 4/15/21 7:16 PM, Andy Shevchenko wrote:
> > Parse to and export from UUID own type, before dereferencing.
> > This also fixes wrong comment (Little Endian UUID is something else)
> > and should fix
On Fri, Apr 16, 2021 at 8:28 AM Dan Williams wrote:
>
> On Thu, Apr 15, 2021 at 6:59 AM Andy Shevchenko
> wrote:
> >
> > Strictly speaking the comparison between guid_t and raw buffer
> > is not correct. Import GUID to variable of guid_t type and then
> > compa
what the coverage of your test is. That's why I have an
additional question below. Is the byte ordering kept the same in BE
(32- and 64-bit) cases? Because I'm worrying that I might have missed
something.
--
With Best Regards,
Andy Shevchenko
Dereferencing something to uuid_t value is not good idea strictly speaking.
Provide a special parameter field for UUID values and drop ugly casting.
Signed-off-by: Andy Shevchenko
---
drivers/tee/optee/call.c | 2 +-
drivers/tee/optee/optee_msg.h | 2 ++
2 files changed, 3 insertions(+), 1
Strictly speaking the comparison between guid_t and raw buffer
is not correct. Return to plain memcmp() since the data structures
haven't changed to use uuid_t / guid_t the current state of affairs
is inconsistent. Either it should be changed altogether or left
as is.
Signed-off-by: Andy
Strictly speaking the comparison between guid_t and raw buffer
is not correct. Import GUID to variable of guid_t type and then
compare.
Signed-off-by: Andy Shevchenko
---
drivers/lightnvm/pblk-recovery.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers
Strictly speaking the comparison between guid_t and raw buffer
is not correct. Import GUID to variable of guid_t type and then
compare.
Signed-off-by: Andy Shevchenko
---
drivers/acpi/nfit/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/nfit/core.c b
9a948c4ba1 ("powerpc/pseries/scm: Use a specific endian format for
storing uuid from the device tree")
Cc: Oliver O'Halloran
Cc: Aneesh Kumar K.V
Signed-off-by: Andy Shevchenko
---
Not tested
arch/powerpc/platforms/pseries/papr_scm.c | 13 -
1 file changed, 8 insert
historical or backward
compatibility reasons. Refactor the code to include the latter as well.
Fixes: f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs file")
Cc: Drew Fustini
Signed-off-by: Andy Shevchenko
---
drivers/pinctrl/core.c | 14 --
1 file changed, 8 insertions(+),
name for pingroups in sysfs")
Cc: Dong Aisheng
Signed-off-by: Andy Shevchenko
---
drivers/pinctrl/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 92955c5e0e0b..3d779fd81e7c 100644
--- a/drivers/pinctrl/core.c
+++ b/drive
On Wed, Apr 14, 2021 at 10:19:16PM +0100, Lee Jones wrote:
> On Wed, 14 Apr 2021, Andy Shevchenko wrote:
> > On Wed, Apr 14, 2021 at 06:13:19PM +0100, Lee Jones wrote:
> > > On Fri, 26 Mar 2021, Lee Jones wrote:
...
> > > Am I still missing patches from you Andy?
sirq_polarity;
> + goto err_clk_disable;
> + }
Why not to use the same pattern as above, i.e.
rc = aspeed_vuart_map_irq_polarity(sirq[1]);
if (rc < 0) {
dev_err(>dev, "invalid sirq polarity in
aspeed,lpc-interrupts property\n");
goto err_clk_disable;
}
sirq_polarity = rc;
?
> + aspeed_vuart_set_sirq_polarity(vuart, sirq_polarity);
> +
> aspeed_vuart_set_enabled(vuart, true);
> aspeed_vuart_set_host_tx_discard(vuart, true);
> platform_set_drvdata(pdev, vuart);
--
With Best Regards,
Andy Shevchenko
ring.
This sounds not correct to me, ns16550a is a national semiconductor product.
Why is it here and not in generic 8250_of?
> + {
> + .compatible = "ns16550a",
> + .data = brcmstb_rate_table_16550a,
> + },
--
With Best Regards,
Andy Shevchenko
2iz72w...@smile.fi.intel.com/
If you think that ACPI dependency is good to have there, go ahead, not my
worries of the consequences. I just consider that as unneeded dependencies.
The proper fix would be to have a split in Kbuild infra for compile
dependencies and run-time dependencies.
+Cc: Masahiro for the discussion, maybe it had already taken place and there is
an impediment to do so.
--
With Best Regards,
Andy Shevchenko
On Thu, Apr 15, 2021 at 3:43 AM Geert Uytterhoeven wrote:
> On Wed, Apr 14, 2021 at 9:14 PM Andy Shevchenko
> wrote:
> > On Wed, Apr 14, 2021 at 08:55:21PM +0200, Geert Uytterhoeven wrote:
> > > On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko
> > > wrote:
> &g
ngle patch from the series and applied the
> rest. Feel free to send this patch as a stand-alone one once you have
> the authorship issues sorted out.
Internally it was proposed by me as well, so authorship is correct.
--
With Best Regards,
Andy Shevchenko
Borishchenko
Signed-off-by: Andy Shevchenko
---
drivers/iio/accel/st_accel_core.c| 89 +-
drivers/iio/imu/Kconfig | 1 +
drivers/iio/imu/Makefile | 1 +
drivers/iio/imu/st_lsm9ds0/Kconfig | 28
drivers/iio/imu/st_lsm9ds0
Enumerate LSM9DS0 (accelerometer and magnetometer parts) via
'st,lsm9ds0-imu' compatible string.
Signed-off-by: Andy Shevchenko
---
Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/st,st
Some IMUs may utilize existing library code for STMicro accelerometer,
gyroscope, magnetometer and pressure. Let's share them via st_sensors.h.
Signed-off-by: Andy Shevchenko
---
drivers/iio/accel/st_accel.h | 4
drivers/iio/gyro/st_gyro.h| 4
drivers/iio
In case we would initialize two IIO devices from one physical device,
we shouldn't have a clash on regulators. That's why move
st_sensors_power_enable() call from core to bus drivers.
Signed-off-by: Andy Shevchenko
---
drivers/iio/accel/st_accel_core.c | 21 +
drivers
Provide default platform data for magnetometer in case it supports DRDY.
One case is LSM9DS0 IMU, on which it is the case. Since accelerometer
is using INT1, default magnetometer to INT2.
While at it, update description of the drdy_int_pin field.
Signed-off-by: Andy Shevchenko
---
drivers/iio
-off-by: Andy Shevchenko
---
drivers/iio/gyro/st_gyro.h | 8
drivers/iio/gyro/st_gyro_core.c | 5 +
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/gyro/st_gyro.h b/drivers/iio/gyro/st_gyro.h
index fd9171cc3aba..b385fe664dcc 100644
--- a/drivers/iio/gyro
.
Signed-off-by: Andy Shevchenko
---
drivers/iio/accel/st_accel.h | 8
drivers/iio/accel/st_accel_core.c | 5 +
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h
index 5d356288e001..181ebe79c4eb 100644
ow and respin the whole
> series.
Below patch looks good to me, thanks!
> From 02340f8c7c17ace028040a35553c33cce8f3bce4 Mon Sep 17 00:00:00 2001
> From: Andy Shevchenko
> Date: Wed, 22 Apr 2020 16:02:20 +0300
> Subject: [PATCH] stm class: Use correct UUID APIs
>
> It appears
On Wed, Apr 14, 2021 at 08:55:21PM +0200, Geert Uytterhoeven wrote:
> On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko
> wrote:
> > On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote:
> > > On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang
> > > wro
On Wed, Apr 14, 2021 at 08:56:50PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 14, 2021 at 08:47:48PM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 14, 2021 at 07:33:38PM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Apr 14, 2021 at 08:12:46PM +0300, Alexander Shishkin wrote:
is a public IP which doesn't specifically depend on ARCH_HISI. I'm
> > not sure all the platform this IP on has ARCH_HISI configured. The driver
> > will not be compiled by default config. This is not correct to have
> > this dependence.
>
> Thanks for your answer!
>
> I guess it's still fine to add a dependency on ACPI?
But why?
--
With Best Regards,
Andy Shevchenko
On Wed, Apr 14, 2021 at 06:13:19PM +0100, Lee Jones wrote:
> On Fri, 26 Mar 2021, Lee Jones wrote:
>
> > On Fri, 26 Mar 2021, Andy Shevchenko wrote:
> >
> > > As Linus rightfully noticed, the driver plays dirty trick with const,
> > > i.e. it assigns a plac
On Wed, Apr 14, 2021 at 07:33:38PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 14, 2021 at 08:12:46PM +0300, Alexander Shishkin wrote:
> > From: Andy Shevchenko
> >
> > It appears that uuid_t use in STM code abuses UUID API.
>
> How is it being abused?
We are
for devres part of the driver core.
Signed-off-by: Andy Shevchenko
---
v3: always assign name and size for the resource
drivers/base/Makefile | 3 +++
drivers/base/devres.c | 47 +++
drivers/base/trace.c | 10
drivers/base/trace.h | 56
If a list of devres nodes is empty, no need to call remove_nodes().
Signed-off-by: Andy Shevchenko
---
v3: new patch
drivers/base/devres.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/base/devres.c b/drivers/base/devres.c
index db1f3137fc81..dee48858663f 100644
--- a/drivers
The remove_nodes() open codes the list_for_each_safe_from().
Replace it by a generic macro.
Signed-off-by: Andy Shevchenko
---
v3: new patch
drivers/base/devres.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/base/devres.c b/drivers/base
It seems for the sake of saving stack memory of couple of pointers,
the locking in release_nodes() callers becomes interesting.
Replace this logic with a straight forward locking and unlocking scheme.
Signed-off-by: Andy Shevchenko
---
v3: new patch
drivers/base/devres.c | 30
On Thu, Mar 25, 2021 at 07:34:07PM +0200, Andy Shevchenko wrote:
> The series provides one fix (patch 1) for GPIO to be able to wait for
> the GPIO driver to appear. This is separated from the conversion to
> the GPIO descriptors (patch 2) in order to have a possibility for
> backport
yuki
> Ohtake 2010-09-21 299 */
> 191cc687740834 drivers/net/pch_gbe/pch_gbe_main.c stephen
> hemminger 2010-10-15 300 static void pch_gbe_wait_clr_bit(void *reg, u32
> bit)
> 77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki
> Ohtake 2010-09-21
Add Intel Alder Lake-M LPSS PCI IDs.
Signed-off-by: Andy Shevchenko
---
drivers/mfd/intel-lpss-pci.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 1522c8afc540..dc0292aa2e6e 100644
--- a/drivers/mfd/intel
We have open coded dev_set_name() implementation, replace that
with a direct call.
Signed-off-by: Andy Shevchenko
---
drivers/base/power/wakeup_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/power/wakeup_stats.c
b/drivers/base/power/wakeup_stats.c
On Tue, Apr 13, 2021 at 11:43:25PM +, Chris Packham wrote:
> On 14/04/21 2:37 am, Andy Shevchenko wrote:
> > Use __maybe_unused for the suspend()/resume() hooks and get rid of
> > the CONFIG_PM_SLEEP ifdeffery to improve the code.
> This has a trivial conflict with my serie
On Mon, Apr 05, 2021 at 09:37:28PM +0100, Daniel Scally wrote:
> On 04/04/2021 19:14, Andy Shevchenko wrote:
> > When we continue, due to device is disabled, loop we have to drop reference
> > count.
> > When we have an array full of devices we have to also drop the reference
On Tue, Mar 23, 2021 at 01:57:04PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 03, 2021 at 06:49:44PM +0200, Andy Shevchenko wrote:
> > The IRQ support for SCH GPIO is not specific to the Intel Quark SoC.
> > Moreover the IRQ routing is quite interesting there, so while it's
>
On Wed, Mar 31, 2021 at 06:48:49PM +0300, Andy Shevchenko wrote:
> Since we have software nodes support in MFD core, we may start converting
> intel_quark_i2c_gpio driver to use it. For the starter it converts I²C part.
> and as a result we get rid of platform data for I²C DesignWa
On Tue, Apr 13, 2021 at 04:44:33PM +0200, Geert Uytterhoeven wrote:
> On Tue, Apr 13, 2021 at 4:41 PM Andy Shevchenko
> wrote:
> > On Tue, Apr 13, 2021 at 02:48:15PM +0200, Geert Uytterhoeven wrote:
> > > On Tue, Apr 13, 2021 at 2:37 PM Andy Shevchenko
> > > wrote
The peripheral clock is optional and we may get an -EPROBE_DEFER error code
which would not be propagated correctly, fix this by using
devm_clk_get_optional().
Signed-off-by: Andy Shevchenko
---
drivers/i2c/busses/i2c-mpc.c | 25 -
1 file changed, 12 insertions(+), 13
On Tue, Apr 13, 2021 at 02:48:15PM +0200, Geert Uytterhoeven wrote:
> On Tue, Apr 13, 2021 at 2:37 PM Andy Shevchenko
> wrote:
> > On Tue, Apr 13, 2021 at 02:26:15PM +0200, Geert Uytterhoeven wrote:
> > > The HiSilicon Kunpeng I2C controller is only present on HiSilic
devm_platform_ioremap_resource() prints a message in case of error.
Drop custom one.
Signed-off-by: Andy Shevchenko
---
drivers/i2c/busses/i2c-mpc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index
Use the device_get_match_data() helper instead of open coding.
Signed-off-by: Andy Shevchenko
---
drivers/i2c/busses/i2c-mpc.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index 2376accd4e8e
Use __maybe_unused for the suspend()/resume() hooks and get rid of
the CONFIG_PM_SLEEP ifdeffery to improve the code.
Signed-off-by: Andy Shevchenko
---
drivers/i2c/busses/i2c-mpc.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b
);
> + mpc_i2c_do_intr(i2c, status);
> + return IRQ_HANDLED;
> }
> + return IRQ_NONE;
> +}
...
> + time_left = wait_event_timeout(i2c->waitq, !i2c->block,
> i2c->adap.timeout);
> +
No need for a blank line here.
> + if (!time_left)
> + i2c->rc = -ETIMEDOUT;
> + else if (time_left < 0)
Redundant 'else'
> + i2c->rc = time_left;
Can't you return an error code from here, rather than injecting it
somewhere where it doesn't belong to?
> }
--
With Best Regards,
Andy Shevchenko
s it? i2c/for-next shows the v2 of this series being applied.
--
With Best Regards,
Andy Shevchenko
On Tue, Apr 13, 2021 at 4:31 PM Andy Shevchenko
wrote:
>
> On Tue, Apr 13, 2021 at 3:21 PM Wolfram Sang wrote:
> >
> >
> > > Yongjun[1] into the original patch. If Wei's patch is applied on top
> > > of whats already in i2c/for-next then this pat
ependency, feel free to add my
Reviewed-by: Andy Shevchenko
> Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller")
> Signed-off-by: Geert Uytterhoeven
> ---
> drivers/i2c/busses/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Tue, Apr 13, 2021 at 03:00:52PM +0300, Heikki Krogerus wrote:
> On Tue, Apr 13, 2021 at 02:38:01PM +0300, Andy Shevchenko wrote:
> > In some cases the printf() mechanism is too heavy and can't be used.
> > For example, when debugging a race condition involving devre
for devres part of the driver core.
Signed-off-by: Andy Shevchenko
---
v2: fixed compilation error (lkp), elaborate commit message (Greg)
drivers/base/Makefile | 3 +++
drivers/base/devres.c | 23 +++---
drivers/base/trace.c | 10
drivers/base/trace.h | 56
home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
On Mon, Apr 12, 2021 at 12:29:05PM -0700, Stephen Boyd wrote:
> Quoting Andy Shevchenko (2021-04-12 04:58:02)
> > On Fri, Apr 09, 2021 at 06:52:52PM -0700, Stephen Boyd wrote:
> > > Let's make kernel stacktraces easier to identify by including the build
> > > ID[1] of
On Tue, Apr 13, 2021 at 2:21 AM Chris Packham
wrote:
> On 13/04/21 10:52 am, Andy Shevchenko wrote:
> > On Mon, Mar 29, 2021 at 4:54 AM Chris Packham
> > wrote:
> >> Use device managed functions an clean up error handling.
> > For the god sake how have you tested
The DSDT and ACPI should be capitalized.
Signed-off-by: Andy Shevchenko
---
v2: split from patch 1 as per Rafael's request
drivers/acpi/utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index 60e46efc1bc8..3b54b8fd7396
() and
advertise acpi_dev_put() instead of put_device() in the whole family
of the helper functions.
Fixes: bf263f64e804 ("media: ACPI / bus: Add acpi_dev_get_next_match_dev() and
helper macro")
Cc: Daniel Scally
Signed-off-by: Andy Shevchenko
---
v2:
fixed grammar (Rafael)
split
"BUG" and "BUG_ON" and wonder if we really
> need to halt the kernel in that case. Maybe WARN is enough?
>
> I'll apply the first five patches now, they look good to me.
And now is the time to revert the fifth one (at least, I don't know
the state of the rest).
It's obviously the series has not been tested (to some extent).
--
With Best Regards,
Andy Shevchenko
On Tue, Apr 13, 2021 at 1:52 AM Andy Shevchenko
wrote:
>
> On Mon, Mar 29, 2021 at 4:54 AM Chris Packham
> wrote:
> >
> > Use device managed functions an clean up error handling.
>
> For the god sake how have you tested this?
> The patch is broken.
Looking into i2
On Mon, Mar 29, 2021 at 4:54 AM Chris Packham
wrote:
>
> Use device managed functions an clean up error handling.
For the god sake how have you tested this?
The patch is broken.
--
With Best Regards,
Andy Shevchenko
Introduce acpi_dev_get() to have a symmetrical API with acpi_dev_put()
and reuse both in ACPI code under drivers/acpi folder.
While at it, use acpi_bus_put_acpi_device() in one place rather than above.
Signed-off-by: Andy Shevchenko
---
v2: made acpi_dev_get() to return pointer as get_device
On Mon, Apr 12, 2021 at 9:05 PM Rafael J. Wysocki wrote:
>
> On Mon, Apr 12, 2021 at 7:47 PM Andy Shevchenko
> wrote:
> >
> > On Mon, Apr 12, 2021 at 8:32 PM Rafael J. Wysocki wrote:
> > > On Sat, Apr 10, 2021 at 3:47 PM Andy Shevchenko
> > > wrot
On Mon, Apr 12, 2021 at 8:27 PM Rafael J. Wysocki wrote:
>
> On Sat, Apr 10, 2021 at 3:29 PM Andy Shevchenko
> wrote:
> >
> > The macro requires to call acpi_dev_put() on each iteration.
> > Due to this it doesn't tolerate sudden disappearence of the devices.
A
On Mon, Apr 12, 2021 at 8:32 PM Rafael J. Wysocki wrote:
> On Sat, Apr 10, 2021 at 3:47 PM Andy Shevchenko
> wrote:
...
> > static void get_acpi_device(void *dev)
> > {
> > - if (dev)
> > - get_device(&((struct acpi_device *)dev)-&
On Mon, Apr 12, 2021 at 07:27:14PM +0200, Henning Schild wrote:
> Am Mon, 12 Apr 2021 19:51:42 +0300
> schrieb Andy Shevchenko :
> > On Mon, Apr 12, 2021 at 06:01:06PM +0200, Henning Schild wrote:
> > > Am Mon, 8 Mar 2021 14:20:19 +0200
> > > schrieb Andy Shevc
On Mon, Apr 12, 2021 at 07:16:53PM +0200, Henning Schild wrote:
> Am Mon, 12 Apr 2021 19:59:05 +0300
> schrieb Andy Shevchenko :
> > On Mon, Apr 12, 2021 at 06:40:01PM +0200, Henning Schild wrote:
> > > Tan or Andy,
> > >
> > > maybe you can point me to a
it is not published anywhere
> and should not yet be on the list, i could just use it for inspiration.
> A driver will likely be GPL anyways.
--
With Best Regards,
Andy Shevchenko
On Mon, Apr 12, 2021 at 06:01:06PM +0200, Henning Schild wrote:
> Am Mon, 8 Mar 2021 14:20:19 +0200
> schrieb Andy Shevchenko :
>
> > From: Tan Jui Nee
> >
> > Add support for non-ACPI systems, such as system that uses
> > Advanced Boot Loader (ABL) whereby a
Better to have a MODE group of settings to keep them together
when ordered alphabetically. Hence, rename PIN_CONFIG_LOW_POWER_MODE
to PIN_CONFIG_MODE_LOW_POWER.
Signed-off-by: Andy Shevchenko
---
drivers/pinctrl/pinconf-generic.c | 6 +++---
drivers/pinctrl/pinctrl-lpc18xx.c | 4
a corresponding item to the pin_config_param
enumerator.
Signed-off-by: Andy Shevchenko
---
include/linux/pinctrl/pinconf-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/pinctrl/pinconf-generic.h
b/include/linux/pinctrl/pinconf-generic.h
index 189e701832ea
It seems the ordering is by name. Keep it that way.
Signed-off-by: Andy Shevchenko
---
include/linux/pinctrl/pinconf-generic.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/pinctrl/pinconf-generic.h
b/include/linux/pinctrl/pinconf-generic.h
index
On Mon, Apr 12, 2021 at 4:30 PM Heiko Stübner wrote:
> Am Montag, 12. April 2021, 14:13:37 CEST schrieb Andy Shevchenko:
> > On Sun, Apr 11, 2021 at 4:35 PM Peter Geis wrote:
> > >
> > > Separate gpio driver from pinctrl driver, and support v2 controller.
> >
Enable ADC on Intel Galileo Gen 1 board.
Signed-off-by: Andy Shevchenko
---
v2: fixed typo in ID
drivers/iio/adc/ad7298.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/iio/adc/ad7298.c b/drivers/iio/adc/ad7298.c
index 689ecd5dd563..e7e866433090 100644
--- a/drivers/iio/adc
On Mon, Apr 12, 2021 at 4:02 PM Andy Shevchenko
wrote:
>
> Enable ADC on Intel Galileo Gen 1 board.
Not my day...
> + { "INT3495", 0 },
Should be INT3494
I'll send v2
--
With Best Regards,
Andy Shevchenko
Enable ADC on Intel Galileo Gen 1 board.
Signed-off-by: Andy Shevchenko
---
drivers/iio/adc/ad7298.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/iio/adc/ad7298.c b/drivers/iio/adc/ad7298.c
index 689ecd5dd563..3a7b75463335 100644
--- a/drivers/iio/adc/ad7298.c
+++ b
hip.c
> create mode 100644 drivers/pinctrl/pinctrl-rockchip.h
>
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
did &&
> buildid)
> + len += sprintf(buffer + len, " %20phN", buildid);
len += sprintf(buffer + len, " %*phN",
BUILD_ID_SIZE_MAX, buildid);
?
--
With Best Regards,
Andy Shevchenko
On Mon, Apr 12, 2021 at 01:19:04PM +0300, Andy Shevchenko wrote:
> The commit 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.")
> missed the point that loop counter should be put after use. Otherwise
> the reference count of it will become unbalanced.
Scratch this, I
On Mon, Apr 12, 2021 at 01:38:38PM +0300, Andy Shevchenko wrote:
> The commit 88b7e9ffe594 ("leds: as3645a: Switch to fwnode property API")
> missed the point that loop counter should be put after use. Otherwise
> the reference count of it will become unbalanced.
Sc
On Mon, Apr 12, 2021 at 2:07 PM linux-kernel-dev
wrote:
> On Mo, 2021-04-12 at 13:54 +0300, Andy Shevchenko wrote:
> > CAUTION: External Email!!
> > On Mon, Apr 12, 2021 at 1:39 PM linux-kernel-dev
> > wrote:
> > > On Mo, 2021-04-12 at 12:43 +0300, Andy Shevchenko
On Mon, Apr 12, 2021 at 1:39 PM linux-kernel-dev
wrote:
> On Mo, 2021-04-12 at 12:43 +0300, Andy Shevchenko wrote:
> > On Mon, Apr 12, 2021 at 12:29 PM Steffen Dirkwinkel
> > wrote:
...
> > I'm afraid it's a bit too much. Is there any guarantee all the boards
> > ba
6e005 ("leds-as3645a: Drop fwnode reference on ignored node")
Signed-off-by: Andy Shevchenko
---
drivers/leds/leds-as3645a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
index e8922fa03379..50454d1c6090 100644
--- a/dri
The commit 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.")
missed the point that loop counter should be put after use. Otherwise
the reference count of it will become unbalanced.
Fixes: 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.")
Cc: Cristian Pop
...only a few..."
> having the clocks turned on is not an issue on those.
"...not an issue."
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Signed-off-by: Steffen Dirkwinkel
I'm afraid it's a bit too much. Is there any guarantee
*reg)
> ret = lidar_write_control(data, LIDAR_REG_CONTROL_ACQUIRE);
> if (ret < 0) {
> dev_err(>dev, "cannot send start measurement
> command");
> + pm_runtime_put_noidle(>dev);
> return ret;
> }
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
On Sun, Apr 11, 2021 at 9:07 PM Andy Shevchenko
wrote:
> On Sun, Apr 11, 2021 at 5:53 PM Jonathan Cameron wrote:
> > On Wed, 7 Apr 2021 23:51:47 +0530
> > Puranjay Mohan wrote:
> Good point, but better is to use clamp_t(s16, ...) rather than explicit
> casting.
Sorry
od point, but better is to use clamp_t(s16, ...) rather than explicit casting.
I always consider explicit casting in C (and esp. in Linux kernel) is
a red flag. Should be really rarely needed.
> > + if (off == data->calibbias)
> > + return 0;
--
With Best Regards,
Andy Shevchenko
We have already an API to match a string in the array of strings.
Utilize it instead of open coded analogues.
Signed-off-by: Andy Shevchenko
---
drivers/acpi/scan.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/acpi/scan.c b/drivers/acpi
101 - 200 of 17509 matches
Mail list logo
