[PATCH 2/6] staging: csr: print MAC addresses via %pM

2012-07-06 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Lauri Hintsala lauri.hints...@bluegiga.com --- drivers/staging/csr/sme_mgt.c | 10 ++ drivers/staging/csr/sme_sys.c | 29 drivers/staging/csr/sme_wext.c

[Patch v2] staging: ccg: print MAC addresses via %pM

2012-07-06 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Andrzej Pietrasiewicz andrze...@samsung.com --- drivers/staging/ccg/ccg.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccg/ccg.c

Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM

2012-07-06 Thread Andy Shevchenko
, no ? Thanks, I noticed this already. Patch v2 was sent recently. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

[PATCH] tools: perf: remove yet another strtoull()

2012-07-10 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net --- tools/perf/util/symbol.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index

[PATCH] dw_dmac: use devm_* functions to simplify code

2012-07-24 Thread Andy Shevchenko
Use devm_kzalloc, devm_clk_get, devm_request_irq, and devm_request_and_ioremap to reduce the code and to simplify the error path. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Viresh Kumar viresh.li...@gmail.com --- drivers/dma/dw_dmac.c | 53

[PATCH 2/2] dw_dmac: check for mapping errors

2012-12-10 Thread Andy Shevchenko
-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index a9e9a07..38eea0c 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma

[PATCH 1/2] dw_dmac: backlink to dw_dma in dw_dma_chan is superfluous

2012-12-10 Thread Andy Shevchenko
The same information could be exctracted from the struct dma_chan. The patch introduces two helpers dwc_get_src_data_width() and dwc_get_dst_data_width() as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 27

[PATCH 2/2] dmatest: check for dma mapping error

2012-12-10 Thread Andy Shevchenko
We get a warning if CONFIG_DMA_API_DEBUG=y [ 28.150631] WARNING: at lib/dma-debug.c:933 check_unmap+0x5d6/0x6ac() [ 28.157058] dw_dmac dw_dmac.0: DMA-API: device driver failed to check map error[device address=0x35698305] [size=14365 bytes] [mapped as single] Signed-off-by: Andy

[PATCH 1/2] dmatest: implement two helpers to unmap dma memory

2012-12-10 Thread Andy Shevchenko
The unmap_src() and unmap_dst() will be used later as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dmatest.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c

[PATCHv2 1/2] dw_dmac: backlink to dw_dma in dw_dma_chan is superfluous

2012-12-10 Thread Andy Shevchenko
The same information could be exctracted from the struct dma_chan. The patch introduces helper function dwc_get_data_width() as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 19 --- drivers/dma/dw_dmac_regs.h |3

[PATCHv2 2/2] dw_dmac: check for mapping errors

2012-12-10 Thread Andy Shevchenko
-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index 427d35b..f8937cb 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma

[PATCHv3] dw_dmac: backlink to dw_dma in dw_dma_chan is superfluous

2012-12-10 Thread Andy Shevchenko
The same information could be exctracted from the struct dma_chan. The patch introduces helper function dwc_get_data_width() as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 27 --- drivers/dma/dw_dmac_regs.h

Re: [PATCHv3] dw_dmac: backlink to dw_dma in dw_dma_chan is superfluous

2012-12-10 Thread Andy Shevchenko
On Mon, Dec 10, 2012 at 5:01 PM, Viresh Kumar viresh.ku...@linaro.org wrote: On 10 December 2012 20:29, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: The same information could be exctracted from the struct dma_chan. The patch introduces helper function dwc_get_data_width() as well

[PATCH 1/2] dw_dmac: store direction in the custom channel structure

2012-11-20 Thread Andy Shevchenko
. The best candidate to provide the storage is a custom channel structure. Until now we still keep and check the direction field of the slave config structure as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 10 -- drivers/dma

[PATCH 2/2] dw_dmac: make usage of dw_dma_slave optional

2012-11-20 Thread Andy Shevchenko
of the dma_slave_config structure. That's why the custom slave configuration could be optional for such cases. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers

Re: [PATCH 1/2] dw_dmac: store direction in the custom channel structure

2012-11-20 Thread Andy Shevchenko
On Tue, 2012-11-20 at 19:38 +0530, Viresh Kumar wrote: On 20 November 2012 19:08, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Currently the direction value is come from the generic slave configuration s/is come/comes structure and explicitly as a preparation function

[PATCHv2 2/2] dw_dmac: make usage of dw_dma_slave optional

2012-11-21 Thread Andy Shevchenko
of the dma_slave_config structure. That's why the custom slave configuration could be optional for such cases. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions

[PATCHv2 1/2] dw_dmac: store direction in the custom channel structure

2012-11-21 Thread Andy Shevchenko
. The best candidate to provide the storage is a custom channel structure. Until now we still keep and check the direction field of the slave config structure as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c

[PATCH] kfifo: initialize fifo accordingly to C99 standard

2012-11-21 Thread Andy Shevchenko
When build a kernel with make W=1 we will get a warning about missing initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't initialize the buf[] field of the fifo structure. So, using C99 style helps in such case. Signed-off-by: Andy Shevchenko andriy.shevche

[PATCH, resend] kfifo: initialize fifo accordingly to C99 standard

2012-11-21 Thread Andy Shevchenko
When build a kernel with make W=1 we will get a warning about missing initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't initialize the buf[] field of the fifo structure. So, using C99 style helps in such case. Signed-off-by: Andy Shevchenko andriy.shevche

[PATCHv2 2/2] dma: dw_dmac: clear suspend bit during termination

2012-12-18 Thread Andy Shevchenko
the DWC_CFGL_CH_SUSP bit during termination. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCHv2 1/2] dma: dw_dmac: add dwc_chan_pause and dwc_chan_resume

2012-12-18 Thread Andy Shevchenko
We will use at least the dwc_chan_resume() later. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git

Re: [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support

2012-12-12 Thread Andy Shevchenko
. Supplying a new patch, getting it reviewed/tested and being pulled by Linus is not so easy :) Two ways: - Keep it as is, and i will fix it separately and quickly - Drop it :( Will we survive if the patch is in mainline? I mean how big the impact of it is? -- Andy Shevchenko andriy.shevche

Re: [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support

2012-12-12 Thread Andy Shevchenko
documentation again. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH 2/2] dmatest: check for dma mapping error

2012-12-13 Thread Andy Shevchenko
On Fri, Dec 14, 2012 at 1:34 AM, Andrew Morton a...@linux-foundation.org wrote: On Mon, 10 Dec 2012 13:37:44 +0200 Andy Shevchenko andriy.shevche...@linux.intel.com wrote: We get a warning if CONFIG_DMA_API_DEBUG=y [ 28.150631] WARNING: at lib/dma-debug.c:933 check_unmap+0x5d6/0x6ac

Re: [PATCH 2/2] dmatest: check for dma mapping error

2012-12-14 Thread Andy Shevchenko
On Fri, 2012-12-14 at 00:33 -0800, Andrew Morton wrote: On Fri, 14 Dec 2012 09:06:03 +0200 Andy Shevchenko andy.shevche...@gmail.com wrote: On Fri, Dec 14, 2012 at 1:34 AM, Andrew Morton a...@linux-foundation.org wrote: On Mon, 10 Dec 2012 13:37:44 +0200 Andy Shevchenko

[PATCH] dw_dmac: remove redundant check

2012-12-14 Thread Andy Shevchenko
There is no need to check the callback_required parameter, due to we check the callback pointer to be a non-NULL. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma

[PATCH] dw_dmac: update tx_node_active in dwc_do_single_block

2012-12-14 Thread Andy Shevchenko
The else keyword in the dw_dma_tasklet is removed as well. All together simplifies the logic of the code and understanding of what is happening there. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 14 ++ 1 file changed, 6 insertions

[PATCH 2/2] dma: dw_dmac: clear suspend during termination

2012-12-17 Thread Andy Shevchenko
From: Heikki Krogerus heikki.kroge...@linux.intel.com Clear DWC_CFGL_CH_SUSP bit during termination if the channel was paused. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c |2 +- 1

[PATCH 1/2] dma: dw_dmac: add dwc_chan_pause and dwc_chan_resume

2012-12-17 Thread Andy Shevchenko
We will use at least the dwc_chan_resume() later. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index

Re: [PATCH 2/2] dma: dw_dmac: clear suspend during termination

2012-12-17 Thread Andy Shevchenko
On Mon, 2012-12-17 at 20:42 +0530, Viresh Kumar wrote: On 17 December 2012 19:37, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com Clear DWC_CFGL_CH_SUSP bit during termination if the channel was paused. Signed-off

[PATCH 2/2] dw_dmac: make usage of dw_dma_slave optional

2012-11-15 Thread Andy Shevchenko
structure. That's why the custom slave configuration could be optional for such cases. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw_dmac.c b

[PATCH 1/2] dw_dmac: check direction properly in dw_dma_cyclic_prep

2012-11-15 Thread Andy Shevchenko
-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index a4a5c80..771aa15 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c

Re: [PATCH 1/2] dw_dmac: check direction properly in dw_dma_cyclic_prep

2012-11-15 Thread Andy Shevchenko
On Thu, 2012-11-15 at 20:28 +0530, viresh kumar wrote: On Thu, Nov 15, 2012 at 8:05 PM, viresh kumar viresh.ku...@linaro.org wrote: On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c

Re: [PATCH 2/2] dw_dmac: make usage of dw_dma_slave optional

2012-11-15 Thread Andy Shevchenko
On Thu, 2012-11-15 at 20:28 +0530, viresh kumar wrote: On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c +static inline bool dwc_is_slave(struct dma_slave_config *sconfig

Re: [PATCH 2/2] dw_dmac: make usage of dw_dma_slave optional

2012-11-15 Thread Andy Shevchenko
On Thu, 2012-11-15 at 20:54 +0530, Viresh Kumar wrote: On 15 November 2012 20:51, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Thu, 2012-11-15 at 20:28 +0530, viresh kumar wrote: On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote

Re: [PATCH 2/2] dw_dmac: make usage of dw_dma_slave optional

2012-11-15 Thread Andy Shevchenko
On Thu, Nov 15, 2012 at 5:38 PM, Viresh Kumar viresh.ku...@linaro.org wrote: On 15 November 2012 20:57, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Well, the prep_* should assign the value due to changes of check in the dwc_descriptor_complete. Otherwise we will potentially skip

Re: [PATCH 1/2] dw_dmac: check direction properly in dw_dma_cyclic_prep

2012-11-16 Thread Andy Shevchenko
On Thu, 2012-11-15 at 20:05 +0530, viresh kumar wrote: On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c +static inline bool is_slave_direction(enum dma_transfer_direction direction

Re: [PATCH 2/2] dw_dmac: make usage of dw_dma_slave optional

2012-11-16 Thread Andy Shevchenko
On Fri, 2012-11-16 at 09:59 +0530, Viresh Kumar wrote: On 15 November 2012 23:28, Andy Shevchenko andy.shevche...@gmail.com wrote: On Thu, Nov 15, 2012 at 5:38 PM, Viresh Kumar viresh.ku...@linaro.org wrote: On 15 November 2012 20:57, Andy Shevchenko andriy.shevche...@linux.intel.com

[PATCH 1/6] dmaengine: introduce is_slave_xfer function

2012-11-16 Thread Andy Shevchenko
This function helps to distinguish the slave type of transfer by checking the direction parameter. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: Mika Westerberg mika.westerb...@linux.intel.com Cc: Guennadi Liakhovetski g.liakhovet

[PATCH 5/6] dma: ipu_idmac: reuse is_slave_xfer helper

2012-11-16 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/dma/ipu/ipu_idmac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c index 6585537..c8d0254

[PATCH 4/6] dma: ep93xx_dma: reuse is_slave_xfer helper

2012-11-16 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/dma/ep93xx_dma.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c index bcfde40..7c26354

[PATCH 3/6] dma: dw_dmac: check direction properly in dw_dma_cyclic_prep

2012-11-16 Thread Andy Shevchenko
dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c |5 +++-- 1 file changed

[PATCH 0/6] dmaengine: introduce is_slave_xfer helper

2012-11-16 Thread Andy Shevchenko
There is a common practice to distinguish slave type transfers by checking direction of the channel. This series introduces the check helper and its usage across the drivers. Andy Shevchenko (6): dmaengine: introduce is_slave_xfer function dma: at_hdmac: check direction properly for cyclic

[PATCH 6/6] dma: ste_dma40: reuse is_slave_xfer helper

2012-11-16 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Linus Walleij linus.wall...@linaro.org --- drivers/dma/ste_dma40.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index 23c5573..9f4fdf4 100644

[PATCH 2/6] dma: at_hdmac: check direction properly for cyclic transfers

2012-11-16 Thread Andy Shevchenko
dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Nicolas Ferre nicolas.fe...@atmel.com --- drivers

Re: [PATCH 1/6] dmaengine: introduce is_slave_xfer function

2012-11-16 Thread Andy Shevchenko
On Fri, Nov 16, 2012 at 4:21 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Fri, Nov 16, 2012 at 03:59:14PM +0200, Andy Shevchenko wrote: This function helps to distinguish the slave type of transfer by checking the direction parameter. Signed-off-by: Andy Shevchenko

Re: [PATCH 1/6] dmaengine: introduce is_slave_xfer function

2012-11-16 Thread Andy Shevchenko
On Fri, Nov 16, 2012 at 4:03 PM, Viresh Kumar viresh.ku...@linaro.org wrote: On 16 November 2012 19:29, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: This function helps to distinguish the slave type of transfer by checking the direction parameter. Signed-off-by: Andy Shevchenko

Re: [PATCH 3/6] dma: dw_dmac: check direction properly in dw_dma_cyclic_prep

2012-11-16 Thread Andy Shevchenko
On Fri, Nov 16, 2012 at 3:56 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 16, 2012 at 03:59:16PM +0200, Andy Shevchenko wrote: dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage

Re: [PATCH 5/6] dma: ipu_idmac: reuse is_slave_xfer helper

2012-11-16 Thread Andy Shevchenko
On Fri, Nov 16, 2012 at 3:56 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 16, 2012 at 03:59:18PM +0200, Andy Shevchenko wrote: -ENOCOMMITLOG ?? I don't see much sense to add anything here, but I will do for the patch v2. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com

[PATCHv2 1/6] dmaengine: introduce is_slave_xfer function

2012-11-16 Thread Andy Shevchenko
This function helps to distinguish the slave type of transfer by checking the direction parameter. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com Cc: Nicolas Ferre

[PATCHv2 6/6] dma: ste_dma40: reuse is_slave_xfer helper

2012-11-16 Thread Andy Shevchenko
The is_slave_xfer helps to check if the transfer type is slave. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org --- drivers/dma/ste_dma40.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCHv2 0/6] dmaengine: introduce is_slave_xfer helper

2012-11-16 Thread Andy Shevchenko
- apply all current Reviewed-by and Acked-by tags Andy Shevchenko (6): dmaengine: introduce is_slave_xfer function dma: at_hdmac: check direction properly for cyclic transfers dma: dw_dmac: check direction properly in dw_dma_cyclic_prep dma: ep93xx_dma: reuse is_slave_xfer helper dma

[PATCHv2 3/6] dma: dw_dmac: check direction properly in dw_dma_cyclic_prep

2012-11-16 Thread Andy Shevchenko
dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter, due to the nature of the following usage of it. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked

[PATCHv2 5/6] dma: ipu_idmac: reuse is_slave_xfer helper

2012-11-16 Thread Andy Shevchenko
The is_slave_xfer helps to check if the transfer type is slave. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/dma/ipu/ipu_idmac.c |2 +- 1 file changed, 1

[PATCHv2 4/6] dma: ep93xx_dma: reuse is_slave_xfer helper

2012-11-16 Thread Andy Shevchenko
The is_slave_xfer helps to check if the transfer type is slave. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/dma/ep93xx_dma.c |3 +-- 1 file changed, 1

[PATCHv2 2/6] dma: at_hdmac: check direction properly for cyclic transfers

2012-11-16 Thread Andy Shevchenko
dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter, due to the nature of the following usage of it. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com

Re: [PATCHv3] dw_dmac: autoconfigure data_width or get it via platform data

2012-10-01 Thread Andy Shevchenko
On Thu, 2012-09-27 at 16:03 +0530, Vinod Koul wrote: On Thu, 2012-09-27 at 15:36 +0530, Vinod Koul wrote: On Tue, 2012-09-25 at 14:39 +0300, Andy Shevchenko wrote: Not all of the controllers support the 64 bit data width. Make it configurable via platform data. The driver will try

[PATCH] dw_dmac: fix a regression in dwc_prep_dma_memcpy

2012-10-01 Thread Andy Shevchenko
Sometimes memory-to-memory test is failed, that's why we need to choose minimum data portion between source and destination limits together. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c |9 + 1 file changed, 5 insertions(+), 4 deletions

Re: [PATCHv3] dw_dmac: autoconfigure data_width or get it via platform data

2012-10-01 Thread Andy Shevchenko
On Mon, 2012-10-01 at 15:15 +0530, Vinod Koul wrote: On Mon, 2012-10-01 at 12:04 +0300, Andy Shevchenko wrote: On Thu, 2012-09-27 at 16:03 +0530, Vinod Koul wrote: On Thu, 2012-09-27 at 15:36 +0530, Vinod Koul wrote: On Tue, 2012-09-25 at 14:39 +0300, Andy Shevchenko wrote

Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-01 Thread Andy Shevchenko
On Thu, 2012-09-27 at 10:40 +0300, Felipe Balbi wrote: On Thu, Sep 27, 2012 at 10:31:55AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com commit log would be great. Will do. static struct platform_driver dw_driver = { + .probe

Re: dmatest to use synopsys dma driver (dw_dmac.c)

2012-10-02 Thread Andy Shevchenko
to use dw_dmac.c. I published all my patches already here in the mailing list. Part of them is under review, but another part has been pushed to the linux-next. I highly encourage you to try most recent version from the linux-next. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland

Re: dmatest to use synopsys dma driver

2012-10-02 Thread Andy Shevchenko
the discussions in the mailing list. Most of the related patches are tagged as dw_dmac. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH 4/4] dmaengine: dw_dmac: amend description and indentation

2012-10-02 Thread Andy Shevchenko
heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index bbb2a82..236ccb5 100644 --- a/drivers/dma/dw_dmac.c

[PATCH 2/4] dmaengine: dw_dmac: add module alias

2012-10-02 Thread Andy Shevchenko
From: Heikki Krogerus heikki.kroge...@linux.intel.com It's good to have a quasistatic name for the platform driver. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Felipe Balbi ba...@ti.com Acked

[PATCH 3/4] dmaengine: dw_dmac: remove CLK dependency

2012-10-02 Thread Andy Shevchenko
From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver could be used on different platforms. Thus, the HAVE_CLK dependency is dropped away. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed

[PATCH 0/4] dw_dmac: few cleanups to the driver

2012-10-02 Thread Andy Shevchenko
There are few cleanups to the driver which already acked and reviewed. I decide to split last series to two parts. This is first part. Heikki Krogerus (4): dmaengine: dw_dmac: use helper macro module_platform_driver() dmaengine: dw_dmac: add module alias dmaengine: dw_dmac: remove CLK

[PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-02 Thread Andy Shevchenko
From: Heikki Krogerus heikki.kroge...@linux.intel.com Since v3.2 we have nice macro to define the platform driver's init and exit calls. This patch simplifies the dw_dmac driver by using that macro. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko

Re: [PATCH 1/3] Fix trailing whitespace in trace.h

2012-10-02 Thread Andy Shevchenko
and reuse. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 2/3] Add parenthesis to macros with complex values in trace.h

2012-10-02 Thread Andy Shevchenko
(chip, ret) return(ret) +#define TRACE_GOTO(chip, label) goto(label) #endif In this specific case I think checkpatch.pl wants more than needed. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH 3/7] staging: rts_pstor: reuse kbasename()

2012-10-02 Thread Andy Shevchenko
The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: YAMANE Toshiaki yamaneto...@gmail.com

[PATCH 6/7] usb: core: reuse kbasename()

2012-10-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org --- drivers/usb/core/file.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/core/file.c b/drivers/usb/core

[PATCH 7/7] trace: reuse kbasename() functionality

2012-10-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Steven Rostedt rost...@goodmis.org (maintainer:TRACING) Cc: Frederic Weisbecker fweis...@gmail.com (maintainer:TRACING) --- kernel/trace/trace_uprobe.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 2/7] lib: dynamic_debug: reuse kbasename()

2012-10-02 Thread Andy Shevchenko
Remove the custom implementation of the functionality similar to kbasename(). Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Jason Baron jba...@redhat.com --- lib/dynamic_debug.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/lib

[PATCH 5/7] procfs: reuse kbasename() functionality

2012-10-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- fs/proc/proc_devtree.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c index df7dd08..3d9fd66 100644 --- a/fs/proc/proc_devtree.c +++ b/fs/proc

[PATCH 4/7] mm: reuse kbasename() functionality

2012-10-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: linux...@kvack.org --- mm/memory.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 0e3a516..6b101a2 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -58,6 +58,7

[PATCH 1/7] string: introduce helper to get base file name from given path

2012-10-02 Thread Andy Shevchenko
There are several places in kernel that use functionality like shell's basename function. Let's do it common helper for them. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: YAMANE Toshiaki yamaneto...@gmail.com --- include/linux/string.h | 11 +++ 1 file changed

Re: [PATCH 1/7] string: introduce helper to get base file name from given path

2012-10-02 Thread Andy Shevchenko
On Tue, Oct 2, 2012 at 8:34 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Oct 02, 2012 at 06:00:54PM +0300, Andy Shevchenko wrote: There are several places in kernel that use functionality like shell's basename function. Let's do it common helper for them. Signed-off-by: Andy

Re: dw_dmac patches

2013-01-11 Thread Andy Shevchenko
On Tue, 2013-01-08 at 07:54 -0800, Vinod Koul wrote: On Mon, Jan 07, 2013 at 02:54:54PM +0200, Andy Shevchenko wrote: Hi, Vinod. I noticed you missed the 3.8 merge window and I can't see any of my recent patches [1] in your next branch. So, what is your plan regarding to them? Yes i

[PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-14 Thread Andy Shevchenko
changes the logic a bit when the master parameter of the dwc_get_data_width() is out of range. Now the function will return a value related to the first AHB master. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c |7 --- 1 file changed, 4 insertions

Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-14 Thread Andy Shevchenko
On Tue, Jan 15, 2013 at 3:54 AM, Viresh Kumar viresh.ku...@linaro.org wrote: On Mon, Jan 14, 2013 at 7:50 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: The driver's default assumes that hardware has two AHB masters which might be not true. In such rare cases we have

Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-15 Thread Andy Shevchenko
On Tue, Jan 15, 2013 at 11:01 AM, Viresh Kumar viresh.ku...@linaro.org wrote: On Tue, Jan 15, 2013 at 12:35 PM, Andy Shevchenko andy.shevche...@gmail.com wrote: The details of the patch are fine, but i didn't get how do you get master 1 selected on a system where you have only 1 master

Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-15 Thread Andy Shevchenko
On Tue, Jan 15, 2013 at 11:09 AM, Viresh Kumar viresh.ku...@linaro.org wrote: On 15 January 2013 14:38, Andy Shevchenko andy.shevche...@gmail.com wrote: You forgot the mem2mem type of transfers where we have no information about masters except default settings. Otherwise there is the case

dw_dmac patches

2013-01-07 Thread Andy Shevchenko
dw_dmac: check for mapping errors pick 281c298 dw_dmac: remove redundant check pick 217f956 dw_dmac: update tx_node_active in dwc_do_single_block pick fd144bd dma: dw_dmac: add dwc_chan_pause and dwc_chan_resume pick 59a6031 dma: dw_dmac: clear suspend bit during termination -- Andy Shevchenko

[resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Andy Shevchenko
This function helps to distinguish the slave type of transfer by checking the direction parameter. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com Reviewed-by: Linus

[resend][PATCH 13/16] dw_dmac: remove redundant check

2013-01-09 Thread Andy Shevchenko
There is no need to check the callback_required parameter, due to we check the callback pointer to be a non-NULL. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c |2 +- 1 file changed, 1 insertion(+), 1

[resend][PATCH 12/16] dw_dmac: check for mapping errors

2013-01-09 Thread Andy Shevchenko
-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index 39a6506..83e0f9e 100644

[resend][PATCH 06/16] dma: ep93xx_dma: reuse is_slave_xfer helper

2013-01-09 Thread Andy Shevchenko
The is_slave_xfer helps to check if the transfer type is slave. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/dma/ep93xx_dma.c |3 +-- 1 file changed, 1

[resend][PATCH 10/16] dw_dmac: make usage of dw_dma_slave optional

2013-01-09 Thread Andy Shevchenko
of the dma_slave_config structure. That's why the custom slave configuration could be optional for such cases. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions

[resend][PATCH 07/16] dma: ipu_idmac: reuse is_slave_xfer helper

2013-01-09 Thread Andy Shevchenko
The is_slave_xfer helps to check if the transfer type is slave. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/dma/ipu/ipu_idmac.c |2 +- 1 file changed, 1

[resend][PATCH 01/16] dw_dmac: call .probe after we have a device in place

2013-01-09 Thread Andy Shevchenko
the platform device is created later. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index

[resend][PATCH 09/16] dw_dmac: store direction in the custom channel structure

2013-01-09 Thread Andy Shevchenko
. The best candidate to provide the storage is a custom channel structure. Until now we still keep and check the direction field of the slave config structure as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c

[resend][PATCH 15/16] dma: dw_dmac: add dwc_chan_pause and dwc_chan_resume

2013-01-09 Thread Andy Shevchenko
We will use at least the dwc_chan_resume() later. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git

[resend][PATCH 14/16] dw_dmac: update tx_node_active in dwc_do_single_block

2013-01-09 Thread Andy Shevchenko
The else keyword in the dw_dma_tasklet is removed as well. All together simplifies the logic of the code and understanding of what is happening there. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c | 14

[resend][PATCH 08/16] dma: ste_dma40: reuse is_slave_xfer helper

2013-01-09 Thread Andy Shevchenko
The is_slave_xfer helps to check if the transfer type is slave. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Linus Walleij linus.wall...@linaro.org --- drivers/dma/ste_dma40.c |2 +- 1 file changed, 1

[resend][PATCH 16/16] dma: dw_dmac: clear suspend bit during termination

2013-01-09 Thread Andy Shevchenko
the DWC_CFGL_CH_SUSP bit during termination. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[resend][PATCH 04/16] dma: at_hdmac: check direction properly for cyclic transfers

2013-01-09 Thread Andy Shevchenko
dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter, due to the nature of the following usage of it. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com

[resend][PATCH 11/16] dw_dmac: backlink to dw_dma in dw_dma_chan is superfluous

2013-01-09 Thread Andy Shevchenko
The same information could be exctracted from the struct dma_chan. The patch introduces helper function dwc_get_data_width() as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/dma/dw_dmac.c | 27

[resend][PATCH 05/16] dma: dw_dmac: check direction properly in dw_dma_cyclic_prep

2013-01-09 Thread Andy Shevchenko
dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter, due to the nature of the following usage of it. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked

[resend][PATCH 00/16] dw_dmac related patchset

2013-01-09 Thread Andy Shevchenko
There is a patchset against dw_dmac driver. It has been resent for Vinod to review after he returned back from vacation and holidays. That's why there is no Cc list. Andy Shevchenko (15): dw_dmac: call .probe after we have a device in place dw_dmac: absence of pdata isn't critical when

<    1   2   3   4   5   6   7   8   9   10   >