Re: [PATCH] net: mv643xx_eth: Add missing phy_addr_set in DT mode

and temporarily workarounded by including a 'ping whatever' call in my u-boot env in order to force it to do the init. Without it, I was unable to properly use the interface. With your fix, after multiple reboots to test it, everything works as expected. So, FWIW: Tested-by: Arnaud Ebalard

Re: [PATCH] net: mv643xx_eth: Add missing phy_addr_set in DT mode

Hi, Sebastian Hesselbarth sebastian.hesselba...@gmail.com writes: On 11/05/2013 11:12 PM, Arnaud Ebalard wrote: Hi Jason, Jason Gunthorpe jguntho...@obsidianresearch.com writes: Commit cc9d4598 'net: mv643xx_eth: use of_phy_connect if phy_node present' made the call to phy_scan optional

[PATCHv0] hwmon: Add support for GMT G751 Temp. Sensor and Thermal Watchdog

This patch adds support for GMT G751 Temperature Sensor and Thermal Watchdog I2C chip. It has been tested via DT on a Netgear ReadyNAS 2120 (Marvell Armada XP based ARM device). Signed-off-by: Arnaud Ebalard a...@natisbad.org --- Documentation/devicetree/bindings/hwmon/g751.txt | 24

Re: [PATCHv0] hwmon: Add support for GMT G751 Temp. Sensor and Thermal Watchdog

Hi, Guenter Roeck li...@roeck-us.net writes: On 11/08/2013 03:31 PM, Arnaud Ebalard wrote: This patch adds support for GMT G751 Temperature Sensor and Thermal Watchdog I2C chip. It has been tested via DT on a Netgear ReadyNAS 2120 (Marvell Armada XP based ARM device). Signed-off

Re: [PATCHv0] hwmon: Add support for GMT G751 Temp. Sensor and Thermal Watchdog

Hi Guenter, Guenter Roeck li...@roeck-us.net writes: Sadly (for me), you are not: I compared the GMT G751 datasheet to an original (1996) National semiconductor LM75 datasheet and they are identical. I mean both the structure and full content (text, diagrams, etc) is the same. Lesson

[PATCH] hwmon: add support for GMT G751 chip in lm75 driver

This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP based board, via DT). Signed-off-by: Arnaud Ebalard a...@natisbad.org --- Hi Guenter, As a side note, I removed the hunk that was present in previous patch to add gmt to the list of DT vendor prefixes because I noticed someone

Re: [PATCH] hwmon: add support for GMT G751 chip in lm75 driver

Hi Guenter, Guenter Roeck li...@roeck-us.net writes: On Sat, Nov 09, 2013 at 06:39:14PM +0100, Arnaud Ebalard wrote: This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP based board, via DT). Signed-off-by: Arnaud Ebalard a...@natisbad.org Looks good. I'll apply

Re: [PATCH v5 12/13] ARM: kirkwood: remove redundant DT board files

Hi Jason and Sebastian, Sebastian Hesselbarth sebastian.hesselba...@gmail.com writes: With DT support for mv643xx_eth board specific init for some boards now is unneccessary. Remove those board files, Kconfig entries, and corresponding entries in kirkwood_defconfig. Signed-off-by: Sebastian

Re: [PATCH v5 12/13] ARM: kirkwood: remove redundant DT board files

-05-30 23:38:53.652311676 +0200 +++ /dev/null 1970-01-01 00:00:00.0 + @@ -1,21 +0,0 @@ -/* - * NETGEAR ReadyNAS Duo v2 Board setup for drivers not already - * converted to DT. - * - * Copyright (C) 2013, Arnaud EBALARD a...@natisbad.org - * - * This program is free software; you can

Re: [PATCH v6 5/7] ARM: kirkwood: remove redundant DT board files

-*.c files in arch/arm/mach_kirkwood/ (i.e. board-dt.c and board-dnskw.c). Cheers, a+ Signed-off-by: Arnaud Ebalard a...@natisbad.org --- arch/arm/mach-kirkwood/common.h | 108 1 file changed, 108 deletions(-) diff --git a/arch/arm/mach-kirkwood/common.h b

Can someone Ack and queue a patch for RTC subsytem?

Hi, I have a very simple driver (support for reading and setting the time) for a RTC chip (Intersil ISL 12057) but cannot find anyone to get it Acked and queued for v3.14. In v3.14, there should be at least three users of the driver (ReadyNAS 102, 104 and 2120) if I meet -rc5 cutoff for

Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Alessandro Zummo a.zu...@towertech.it writes: On Thu, 19 Dec 2013 17:34:09 +0100 a...@natisbad.org (Arnaud Ebalard) wrote: I never heard of *listed* RTC maintainer during all the review process on rtc-linux list (v0 sent in october); I dug the list archives and when this previously

Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Jason Cooper ja...@lakedaemon.net writes: On Thu, Dec 19, 2013 at 05:34:09PM +0100, Arnaud Ebalard wrote: I have a very simple driver (support for reading and setting the time) for a RTC chip (Intersil ISL 12057) but cannot find anyone to get it Acked and queued for v3.14. In v3.14

Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Alessandro Zummo a.zu...@towertech.it writes: Do you want me to send a v7 w/ the .proc helper removed or leave things as they are and Ack the patch as is? Unless absolutely needed, I'd prefer if you can remove them or move to sysfs. Well, my helper provides info on control and status

Re: [rtc-linux] Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Alessandro Zummo a.zu...@towertech.it writes: On Thu, 19 Dec 2013 11:46:24 -0500 Jason Cooper ja...@lakedaemon.net wrote: In the long term, should we seek out a co-maintainer for drivers/rtc? Can anyone get a hold of Alessandro to get his opinion on this? I'd surely appreciate if

Re: [PATCHv7] rtc: Add support for Intersil ISL12057 I2C RTC chip

Hi Andrew, Andrew Morton a...@linux-foundation.org writes: On Thu, 19 Dec 2013 22:53:16 +0100 Arnaud Ebalard a...@natisbad.org wrote: +static int isl12057_i2c_validate_chip(struct regmap *regmap) +{ +u8 regs[ISL12057_MEM_MAP_LEN]; +u8 mask[ISL12057_MEM_MAP_LEN] = { 0x80, 0x80, 0x80

Re: [rtc-linux] Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Mark Brown broo...@kernel.org writes: On Thu, Dec 19, 2013 at 11:17:44PM +0100, Arnaud Ebalard wrote: All NETGEAR ReadyNAS 102, 104 and 2120 have an ISL 12057 RTC chip which is used as main RTC clock but can also provide alarm. But the alarm interrupt line of the chip is *not* connected

Re: [PATCH] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC

-boot and did not take enough attention to that aspect when I updated the .dts to add access to NAND after Ezequiel wrote the NAND driver. I will take a look at RN104 and RN2120 to check if something similar is needed for those two. FWIW, you can add my: Tested-by: Arnaud Ebalard

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

Hi Jason, Jason Cooper ja...@lakedaemon.net writes: It's not about the crypto, it's about trust. imho, one of the most important security advances in the past 20 years is the default use of git (or other SCMs) by open source projects. Now, no one is forced to trust the authors and

Re: [PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested

Hi guys, Florian Fainelli f.faine...@gmail.com writes: Changes in v5: - removed an invalid use of the link_update callback in the SF2 driver was appeared after merging net: phy: fixed_phy: handle link-down case - reworded the commit message for patch 2 to make it clear what it fixes and

[PATCH 0/2] arm: mvebu: disable unused rtc + cosmetic patch for ReadyNAS devices

-xp.dtsi, it just pollutes logs during boot. While writing the patches, I noticed RN2120 .dts file has nodes that are badly ordered under internal-regs. This second patch fixes that. Note that it depends on first patch. Arnaud Ebalard (2): arm: mvebu: disable unused Armada RTC on ReadyNAS 102, 104

[PATCH 1/2] arm: mvebu: disable unused Armada RTC on ReadyNAS 102, 104 and 2120

ed-off-by: Arnaud Ebalard <a...@natisbad.org> --- arch/arm/boot/dts/armada-370-netgear-rn102.dts | 6 ++ arch/arm/boot/dts/armada-370-netgear-rn104.dts | 6 ++ arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 6 ++ 3 files changed, 18 insertions(+) diff --git a/arch/arm/boot/dt

[PATCH 2/2] arm: mvebu: reorder nodes under internal-regs by address in RN2120 .dts file

This cosmetic patch reorder nodes under internal-regs by increasing address order, as epxected. Signed-off-by: Arnaud Ebalard <a...@natisbad.org> --- arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 86 +- 1 file changed, 43 insertions(+), 43 deletions(-) diff

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

Hi, Stas Sergeev s...@list.ru writes: Another problem was reported: https://lkml.org/lkml/2015/7/8/865 So, while the above patch is correct and fixes what it should, the original patch has more problems to deal with. Maybe for stable it would be better to just revert the whole thing? No,

Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device

Hello, Alexandre Belloni writes: > The ISL12057 has a documentation file, remove it from trivial-devices.txt > > Signed-off-by: Alexandre Belloni > --- > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 -

Re: [PATCH 0/3] rtc: remove intersil isl12057

Hi Alexandre, Alexandre Belloni <alexandre.bell...@free-electrons.com> writes: > This is the series I intend to apply once you confirm my previous patch > is working. For previous patch and that series, once the typos are fixed: Acked-by: Arnaud Ebalard <a...@natisbad.org> T

Re: [PATCH] rtc: ds1307: fix century bit support

Hi Alexandre, Alexandre Belloni writes: > Add an option to properly support the century bit of ds1337 and compatibles > and ds1340. > Because the driver had a bug until now, it is not possible to switch users > to the fixed code directly as RTCs in the

Re: [PATCH 2/3] rtc: ds1307: add Intersil ISL12057 support

Alexandre Belloni writes: > Intersil ISL12057 is a drop-in replacement for DS1337. It can be supported > by the ds1307 driver. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/Kconfig | 8 >

Re: [PATCH] net: mv643xx_eth: Add missing phy_addr_set in DT mode

temporarily workarounded by including a 'ping whatever' call in my u-boot env in order to force it to do the init. Without it, I was unable to properly use the interface. With your fix, after multiple reboots to test it, everything works as expected. So, FWIW: Tested-by: Arnaud Ebalard Cheers, a

Re: [PATCH] net: mv643xx_eth: Add missing phy_addr_set in DT mode

Hi, Sebastian Hesselbarth writes: > On 11/05/2013 11:12 PM, Arnaud Ebalard wrote: >> Hi Jason, >> >> Jason Gunthorpe writes: >> >>> Commit cc9d4598 'net: mv643xx_eth: use of_phy_connect if phy_node >>> present' made the call to phy_scan optio

[PATCHv0] hwmon: Add support for GMT G751 Temp. Sensor and Thermal Watchdog

This patch adds support for GMT G751 Temperature Sensor and Thermal Watchdog I2C chip. It has been tested via DT on a Netgear ReadyNAS 2120 (Marvell Armada XP based ARM device). Signed-off-by: Arnaud Ebalard --- Documentation/devicetree/bindings/hwmon/g751.txt | 24 + .../devicetree

Re: [PATCHv0] hwmon: Add support for GMT G751 Temp. Sensor and Thermal Watchdog

Hi, Guenter Roeck writes: > On 11/08/2013 03:31 PM, Arnaud Ebalard wrote: >> >> This patch adds support for GMT G751 Temperature Sensor and Thermal >> Watchdog I2C chip. It has been tested via DT on a Netgear ReadyNAS >> 2120 (Marvell Armada XP based ARM device).

Re: [PATCHv0] hwmon: Add support for GMT G751 Temp. Sensor and Thermal Watchdog

Hi Guenter, Guenter Roeck writes: >> Sadly (for me), you are not: I compared the GMT G751 datasheet to an >> original (1996) National semiconductor LM75 datasheet and they are >> identical. I mean both the structure and full content (text, diagrams, >> etc) is the same. Lesson learned: next

[PATCH] hwmon: add support for GMT G751 chip in lm75 driver

This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP based board, via DT). Signed-off-by: Arnaud Ebalard --- Hi Guenter, As a side note, I removed the hunk that was present in previous patch to add gmt to the list of DT vendor prefixes because I noticed someone had taken care

Re: [PATCH] hwmon: add support for GMT G751 chip in lm75 driver

Hi Guenter, Guenter Roeck writes: > On Sat, Nov 09, 2013 at 06:39:14PM +0100, Arnaud Ebalard wrote: >> >> This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP >> based board, via DT). >> >> Signed-off-by: Arnaud Ebalard > > Looks good.

Re: [PATCH v5 12/13] ARM: kirkwood: remove redundant DT board files

Hi Jason and Sebastian, Sebastian Hesselbarth writes: > With DT support for mv643xx_eth board specific init for some boards now > is unneccessary. Remove those board files, Kconfig entries, and > corresponding entries in kirkwood_defconfig. > > Signed-off-by: Sebastian Hesselbarth > --- >

Re: [PATCH v5 12/13] ARM: kirkwood: remove redundant DT board files

ood/board-readynas.c 2013-05-30 23:38:53.652311676 +0200 +++ /dev/null 1970-01-01 00:00:00.0 + @@ -1,21 +0,0 @@ -/* - * NETGEAR ReadyNAS Duo v2 Board setup for drivers not already - * converted to DT. - * - * Copyright (C) 2013, Arnaud EBALARD - * - * This program is free software;

Can someone Ack and queue a patch for RTC subsytem?

Hi, I have a very simple driver (support for reading and setting the time) for a RTC chip (Intersil ISL 12057) but cannot find anyone to get it Acked and queued for v3.14. In v3.14, there should be at least three users of the driver (ReadyNAS 102, 104 and 2120) if I meet -rc5 cutoff for

Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Alessandro Zummo writes: > On Thu, 19 Dec 2013 17:34:09 +0100 > a...@natisbad.org (Arnaud Ebalard) wrote: > >> I never heard of *listed* RTC maintainer during all the review process >> on rtc-linux list (v0 sent in october); I dug the list archives and when >&g

Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Jason Cooper writes: > On Thu, Dec 19, 2013 at 05:34:09PM +0100, Arnaud Ebalard wrote: >> I have a very simple driver (support for reading and setting the time) >> for a RTC chip (Intersil ISL 12057) but cannot find anyone to get it >> Acked and queued for v3.14. I

Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Alessandro Zummo writes: >> Do you want me to send a v7 w/ the .proc helper removed or leave >> things as they are and Ack the patch as is? > > Unless absolutely needed, I'd prefer if you can remove them > or move to sysfs. Well, my helper provides info on control and status registers

Re: [rtc-linux] Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Alessandro Zummo writes: > On Thu, 19 Dec 2013 11:46:24 -0500 > Jason Cooper wrote: > >> In the long term, should we seek out a co-maintainer for drivers/rtc? >> Can anyone get a hold of Alessandro to get his opinion on this? > > I'd surely appreciate if someone can take some time to give

Re: [PATCHv7] rtc: Add support for Intersil ISL12057 I2C RTC chip

Hi Andrew, Andrew Morton writes: > On Thu, 19 Dec 2013 22:53:16 +0100 Arnaud Ebalard wrote: > >> +static int isl12057_i2c_validate_chip(struct regmap *regmap) >> +{ >> +u8 regs[ISL12057_MEM_MAP_LEN]; >> +u8 mask[ISL12057_MEM_MAP_L

Re: [rtc-linux] Re: Can someone Ack and queue a patch for RTC subsytem?

Hi, Mark Brown writes: > On Thu, Dec 19, 2013 at 11:17:44PM +0100, Arnaud Ebalard wrote: > >> All NETGEAR ReadyNAS 102, 104 and 2120 have an ISL 12057 RTC chip which >> is used as main RTC clock but can also provide alarm. But the alarm >> interrupt line of the

Re: [PATCH v6 5/7] ARM: kirkwood: remove redundant DT board files

arch/arm/mach_kirkwood/ (i.e. board-dt.c and board-dnskw.c). Cheers, a+ Signed-off-by: Arnaud Ebalard --- arch/arm/mach-kirkwood/common.h | 108 1 file changed, 108 deletions(-) diff --git a/arch/arm/mach-kirkwood/common.h b/arch/arm/mach-kirkwood/common.h inde

Re: [PATCH] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC

ks. So, thanks for reporting this, Ben. I must confess I got used to update my kernels from u-boot and did not take enough attention to that aspect when I updated the .dts to add access to NAND after Ezequiel wrote the NAND driver. I will take a look at RN104 and RN2120 to check if something similar is neede

Re: [PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested

Hi guys, Florian Fainelli writes: > Changes in v5: > > - removed an invalid use of the link_update callback in the SF2 driver > was appeared after merging "net: phy: fixed_phy: handle link-down case" > > - reworded the commit message for patch 2 to make it clear what it fixes and > why this

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

Hi, Stas Sergeev writes: >>> Another problem was reported: >>> https://lkml.org/lkml/2015/7/8/865 >>> >>> So, while the above patch is correct and fixes what >>> it should, the original patch has more problems to deal >>> with. Maybe for stable it would be better to just revert >>> the whole

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

Hi Jason, Jason Cooper writes: > It's not about the crypto, it's about trust. imho, one of the most > important security advances in the past 20 years is the default use of > git (or other SCMs) by open source projects. Now, no one is forced to > trust the authors and maintainers tarball

[PATCH 0/2] arm: mvebu: disable unused rtc + cosmetic patch for ReadyNAS devices

-xp.dtsi, it just pollutes logs during boot. While writing the patches, I noticed RN2120 .dts file has nodes that are badly ordered under internal-regs. This second patch fixes that. Note that it depends on first patch. Arnaud Ebalard (2): arm: mvebu: disable unused Armada RTC on ReadyNAS 102, 104

[PATCH 1/2] arm: mvebu: disable unused Armada RTC on ReadyNAS 102, 104 and 2120

d0010300.rtc: internal RTC not ticking [4.505684] i2c /dev entries driver [4.513246] rtc-isl12057 0-0068: rtc core: registered rtc-isl12057 as rtc0 This patch marks Armada internal RTC as disabled in individual .dts files of those devices. Reported-by: TuxOholic Signed-off-by: Arnaud Ebalard

[PATCH 2/2] arm: mvebu: reorder nodes under internal-regs by address in RN2120 .dts file

This cosmetic patch reorder nodes under internal-regs by increasing address order, as epxected. Signed-off-by: Arnaud Ebalard --- arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 86 +- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/arch/arm/boot/dts

Re: [PATCH] rtc: ds1307: fix century bit support

Hi Alexandre, Alexandre Belloni writes: > Add an option to properly support the century bit of ds1337 and compatibles > and ds1340. > Because the driver had a bug until now, it is not possible to switch users > to the fixed code directly as RTCs in the field will wrongly have the > century bit

Re: [PATCH 2/3] rtc: ds1307: add Intersil ISL12057 support

Alexandre Belloni writes: > Intersil ISL12057 is a drop-in replacement for DS1337. It can be supported > by the ds1307 driver. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/Kconfig | 8 > drivers/rtc/rtc-ds1307.c | 6 ++ > 2 files changed, 10 insertions(+), 4

Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device

Hello, Alexandre Belloni writes: > The ISL12057 has a documentation file, remove it from trivial-devices.txt > > Signed-off-by: Alexandre Belloni > --- > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH 0/3] rtc: remove intersil isl12057

Hi Alexandre, Alexandre Belloni writes: > This is the series I intend to apply once you confirm my previous patch > is working. For previous patch and that series, once the typos are fixed: Acked-by: Arnaud Ebalard Thanks for spotting the duplication and your work.