[PATCH] memory: ti-emif-sram: only build for ARMv7

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann The driver can be compile-tested on all ARM machines, but causes a failure when built for ARMv7-M: arm-linux-gnueabi-ld: error: drivers/memory/ti-emif-sram-pm.o: conflicting architecture profiles A/M Limit the target machines to configurations that have ARMv7 enabled

[PATCH] drm/amdgpu: fix debugfs creation/removal, again

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann There is still a warning when CONFIG_DEBUG_FS is disabled: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1145:13: error: 'amdgpu_ras_debugfs_create_ctrl_node' defined but not used [-Werror=unused-function] 1145 | static void amdgpu_ras_debugfs_create_ctrl_n

[PATCH] clk: imx: fix build failure on i.MX SCU clk

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_MXC_CLK_SCU is enabled, but CONFIG_CLK_IMX8QXP is not, the kernel fails to link with: aarch64-linux-ld: no input files make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-scu.o] Error 1 aarch64-linux-ld: no input files make[5]: *** [scripts

[PATCH] media: ti-vpe: cal: avoid FIELD_GET assertion

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann FIELD_GET() must only be used with a mask that is a compile-time constant: drivers/media/platform/ti-vpe/cal.h: In function 'cal_read_field': include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_247' declared with attribute error

[PATCH] firmware: tegra: bpmp: fix T234 build failure

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When only Tegra 234 is enabled, the bpmp driver fails to build: drivers/firmware/tegra/bpmp.c:861:51: error: 'tegra186_soc' undeclared here (not in a function) 861 | { .compatible = "nvidia,tegra186-bpmp", .

[PATCH] soc/tegra: fix T234 build failure

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann In a T234-only configuration, the fuse driver fails to build: drivers/soc/tegra/fuse/fuse-tegra30.c:376:10: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'? Add the missing check in the #ifdef

[PATCH] soundwire: intel: fix another unused-function warning

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann Without CONFIG_PM, there is another warning about an unused function: drivers/soundwire/intel.c:530:12: error: 'intel_link_power_down' defined but not used [-Werror=unused-function] After a previous fix, the driver already uses both an #ifdef and a __ma

[PATCH] cpufreq: scmi: add COMMON_CLK dependency

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann Wtihout CONFIG_COMMON_CLK, the scmi driver fails to link: arm-linux-gnueabi-ld: drivers/cpufreq/scmi-cpufreq.o: in function `scmi_cpufreq_probe': scmi-cpufreq.c:(.text+0x20c): undefined reference to `devm_of_clk_add_hw_provider' arm-linux-gnueabi-ld: scmi-cpufre

[PATCH] ASoC: cros_ec_codec: fix uninitialized memory read

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann gcc points out a memory area that is copied to a device but not initialized: sound/soc/codecs/cros_ec_codec.c: In function 'i2s_rx_event': arch/x86/include/asm/string_32.h:83:20: error: '*((void *)&p+4)' may be used uninitialized in this

[PATCH] phy: mediatek: allow compile-testing the hdmi phy

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann Compile-testing the DRM_MEDIATEK_HDMI driver leads to a harmless warning: WARNING: unmet direct dependencies detected for PHY_MTK_HDMI Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y] Selected by [y]: - DRM_MEDIATEK_HDMI [=y] && HAS_IOMEM [=y] &&

[PATCH] cpufreq: imx: fix NVMEM_IMX_OCOTP dependency

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann A driver should not 'select' drivers from another subsystem. If NVMEM is disabled, this one results in a warning: WARNING: unmet direct dependencies detected for NVMEM_IMX_OCOTP Depends on [n]: NVMEM [=n] && (ARCH_MXC [=y] || COMPILE_TEST [=y])

[PATCH] clk: samsung: mark PM functions as __maybe_unused

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' defined but not used [-Werror=unused-function] 219 | static int exynos_clkout_resume(struct device *dev) |^~~~ drivers/clk/samsung/clk-exynos-clkou

[PATCH] mfd: altera-sysmgr: Fix physical address storing more

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann A recent fix improved the way the resource gets passed to the low-level accessors, but left one warning that appears in configurations with a resource_size_t that is wider than a pointer: In file included from drivers/mfd/altera-sysmgr.c:19: drivers/mfd/altera-sysmgr.c: In

[PATCH] staging: bcm2835: fix vchiq_mmal dependencies

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When the MMAL code is built-in but the vchiq core config is set to =m, the mmal code never gets built, which in turn can lead to link errors: ERROR: modpost: "vchiq_mmal_port_set_format" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefi

[PATCH] selftest/fpu: avoid clang warning

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann With extra warnings enabled, clang complains about the redundant -mhard-float argument: clang: error: argument unused during compilation: '-mhard-float' [-Werror,-Wunused-command-line-argument] Move this into the gcc-only part of the Makefile. Fixes: 41

[PATCH] ASoC: atmel: mchp-spdifrx needs COMMON_CLK

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined! Make this is a strict dependency. Fixes: ef265c55c1ac ("ASoC: mchp-spdifrx: add d

[PATCH] enetc: fix build warning

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_OF is disabled, there is a harmless warning about an unused variable: enetc_pf.c: In function 'enetc_phylink_create': enetc_pf.c:981:17: error: unused variable 'dev' [-Werror=unused-variable] Slightly rearrange the code to pass around the o

[PATCH] watchdog: coh901327: add COMMON_CLK dependency

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann clang produces a build failure in configurations without COMMON_CLK when a timeout calculation goes wrong: arm-linux-gnueabi-ld: drivers/watchdog/coh901327_wdt.o: in function `coh901327_enable': coh901327_wdt.c:(.text+0x50): undefined reference to `__bad_udelay&#x

[PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann If this is not enabled, the interfaces used in this driver do not work: drivers/i2c/busses/i2c-mlxbf.c:1888:3: error: implicit declaration of function 'i2c_slave_event' [-Werror,-Wimplicit-function-declaration] i2c_slave_e

[PATCH] ufshcd: fix Wsometimes-uninitialized warning

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann clang complains about a possible code path in which a variable is used without an initialization: drivers/scsi/ufs/ufshcd.c:7690:3: error: variable 'sdp' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

[PATCH] arm64: cpufeature: fix unused function warning

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann The __system_matches_cap() function is now only used in an #ifdef section: arch/arm64/kernel/cpufeature.c:2649:13: error: unused function '__system_matches_cap' [-Werror,-Wunused-function] Move it into that #ifdef section. Fixes: 7cf283c7bd62 ("arm64:

[PATCH] platform/x86: mlx-platform: remove an unused variable

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann The only reference to the mlxplat_mlxcpld_psu[] array got removed, so there is now a warning from clang: drivers/platform/x86/mlx-platform.c:322:30: error: variable 'mlxplat_mlxcpld_psu' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declarati

[PATCH] media: i2c: fix an uninitialized error code

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann Clang points out that the error handling in ov02a10_s_stream() is broken, and just returns a random error code: drivers/media/i2c/ov02a10.c:537:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]

[PATCH] intel_idle: fix intel_idle_state_needs_timer_stop build failure

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann The newly added function is defined inside of an #ifdef section but used outside, leading to a build failure: drivers/idle/intel_idle.c:1510:7: error: implicit declaration of function 'intel_idle_state_needs_timer_stop' [-Werror,-Wimplicit-function-d

[PATCH] mmc: mediatek: mark PM functions as __maybe_unused

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann The #ifdef check for the suspend/resume functions is wrong: drivers/mmc/host/mtk-sd.c:2765:12: error: unused function 'msdc_suspend' [-Werror,-Wunused-function] static int msdc_suspend(struct device *dev) drivers/mmc/host/mtk-sd.c:2779:12: error: unuse

[PATCH] ASoC: fsl_aud2htx: mark PM functions as __maybe_unused

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_PM is disabled, we get a warning for unused functions: sound/soc/fsl/fsl_aud2htx.c:261:12: error: unused function 'fsl_aud2htx_runtime_suspend' [-Werror,-Wunused-function] static int fsl_aud2htx_runtime_suspend(struct device *dev) sound/soc/fsl/fsl_aud

[PATCH] clk: meson: g12a: select COMMON_CLK_MESON_VID_PLL_DIV

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann Without this, a g12a-only config produces a link error: aarch64-linux-ld: drivers/clk/meson/g12a.o:(.data+0xcb68): undefined reference to `meson_vid_pll_div_ro_ops' Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller") Signed-off-by

[PATCH] arm64: fix HARDLOCKUP_DETECTOR dependency

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_HW_PERF_EVENTS is disabled, the hardware lockup detector fails to link: ld.lld: error: undefined symbol: hw_nmi_get_sample_period >>> referenced by watchdog_hld.c >>> watchdog_hld.o:(hardlockup_detector_event_create) in archive

[PATCH] media: smiapp: avoid printing an uninitialized variable

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann There is no intialization for the 'reg' variable, so printing it produces undefined behavior as well as a compile-time warning: drivers/media/i2c/ccs/ccs-core.c:314:49: error: variable 'reg' is uninitialized when used here [-We

[PATCH] ch_ktls: fix build warning for ipv4-only config

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_IPV6 is disabled, clang complains that a variable is uninitialized for non-IPv4 data: drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c:1046:6: error: variable 'cntrl1' is used uninitialized whenever 'if' condition is false

[PATCH] crypto: aegis128 - fix link error without SIMD

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When the SIMD portion of the driver is disabled, the compiler cannot figure out in advance if it will be called: ERROR: modpost: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined! Add a conditional to let the compiler use dead code elimination as befo

Re: [PATCH] firmware_loader: Align .builtin_fw to 8

2020-12-03 Thread Arnd Bergmann
lign .builtin_fw to fix the linker error. > > Fixes: 5658c76 ("firmware: allow firmware files to be built into kernel > image") > Link: https://github.com/ClangBuiltLinux/linux/issues/1204 > Reported-by: kernel test robot > Signed-off-by: Fangrui Song Acked-by: Arnd B

objtool crashes with some clang produced .o files

2020-12-03 Thread Arnd Bergmann
I see occasional randconfig builds failing on x86 with clang-11 and clang-12 when objtool crashes with a segmentation fault. The simplest test case I managed to create is $ echo "__SCK__tp_func_cdev_update() { __SCT__tp_func_cdev_update(); }" > file.c $ clang-12 -c file.c -O2 -fno-asynchronous-un

[tip: locking/core] seqlock: avoid -Wshadow warnings

2020-12-03 Thread tip-bot2 for Arnd Bergmann
The following commit has been merged into the locking/core branch of tip: Commit-ID: a07c45312f06e288417049208c344ad76074627d Gitweb: https://git.kernel.org/tip/a07c45312f06e288417049208c344ad76074627d Author:Arnd Bergmann AuthorDate:Mon, 26 Oct 2020 17:50:38 +01:00

Re: [PATCH v2 5/7] ubsan: Enable for all*config builds

2020-12-03 Thread Arnd Bergmann
On Thu, Dec 3, 2020 at 1:44 AM Kees Cook wrote: > > With UBSAN_OBJECT_SIZE disabled for GCC, only UBSAN_ALIGNMENT remained > a noisy UBSAN option. Disable it for COMPILE_TEST so the rest of UBSAN > can be used for full all*config builds or other large combinations. > > Link: > https://lore.kernel

Re: [RFC][PATCH] coredump: Document coredump code exclusively used by cell spufs

2020-12-02 Thread Arnd Bergmann
> > Signed-off-by: Eric W. Biederman > > --- > > > > Does this change look good to people? I think it captures this state of > > things and makes things clearer without breaking anything or removing > > functionality for anyone. > > I haven't heard anything except a general ack to the concept of > comments. So I am applying this. > Sorry I missed it when you originally sent it. Looks good ot me, Acked-by: Arnd Bergmann

Re: [PATCH 1/5] ARM: configs: drop unused BACKLIGHT_GENERIC option

2020-12-01 Thread Arnd Bergmann
On Tue, Dec 1, 2020 at 8:48 PM ZHIZHIKIN Andrey wrote: > Hello Arnd, > > > > Or rather, SoC-specific patches, even to defconfig, should go > > > > through the specific SoC maintainers. However, there are occasional > > > > defconfig patches which are more generic or affecting multiple SoCs. > > >

Re: [PATCH RESEND] misc/vmw_vmci: bail out earlier on too big queue allocation

2020-12-01 Thread Arnd Bergmann
On Mon, Nov 23, 2020 at 10:01 PM Norbert Slusarek wrote: > > From: Norbert Slusarek > Date: Mon, 23 Nov 2020 21:53:41 +0100 > Subject: [PATCH RESEND] misc/vmw_vmci: bail out earlier on too big queue > allocation > > For the allocation of a queue pair in qp_host_alloc_queue() an arbitrary value >

Re: [PATCH 1/5] ARM: configs: drop unused BACKLIGHT_GENERIC option

2020-12-01 Thread Arnd Bergmann
On Tue, Dec 1, 2020 at 4:41 PM Alexandre Belloni wrote: > On 01/12/2020 14:40:53+, Catalin Marinas wrote: > > On Mon, Nov 30, 2020 at 07:50:25PM +, ZHIZHIKIN Andrey wrote: > > > From Krzysztof Kozlowski : > > I tried to convince them before, it didn't work. I guess they don't like > > to

Re: [PATCH 9/9] ARM: mstar: SMP support

2020-11-30 Thread Arnd Bergmann
On Mon, Nov 30, 2020 at 3:25 PM Daniel Palmer wrote: > > Hi Arnd, > > On Mon, 30 Nov 2020 at 22:42, Arnd Bergmann wrote: > > > +struct smp_operations __initdata mstarv7_smp_ops = { > > > + .smp_boot_secondary = mstarv7_boot_secondary, > > >

Re: [PATCH 8/9] ARM: mstar: Add smp ctrl registers to infinity2m dtsi

2020-11-30 Thread Arnd Bergmann
On Mon, Nov 30, 2020 at 3:11 PM Daniel Palmer wrote: > > Hi Arnd, > > On Mon, 30 Nov 2020 at 22:44, Arnd Bergmann wrote: > > > > On Mon, Nov 30, 2020 at 2:10 PM Daniel Palmer wrote: > > > > > > +&riu { > > > + smpctrl@204

Re: [PATCH 8/9] ARM: mstar: Add smp ctrl registers to infinity2m dtsi

2020-11-30 Thread Arnd Bergmann
On Mon, Nov 30, 2020 at 2:10 PM Daniel Palmer wrote: > > +&riu { > + smpctrl@204000 { > + compatible = "mstar,smpctrl"; > + reg = <0x204000 0x200>; > + status = "okay"; > + }; You probably want some more specific compatible value, in case ther

Re: [PATCH 9/9] ARM: mstar: SMP support

2020-11-30 Thread Arnd Bergmann
On Mon, Nov 30, 2020 at 2:10 PM Daniel Palmer wrote: > +#ifdef CONFIG_SMP > +static int mstarv7_boot_secondary(unsigned int cpu, struct task_struct *idle) > +{ > + struct device_node *np; > + u32 bootaddr = (u32) __pa_symbol(secondary_startup_arm); > + void __iomem *smpctrl = 0;

[PATCH] drm/kmb: fix array bounds warning

2020-11-29 Thread Arnd Bergmann
From: Arnd Bergmann gcc warns about an out-of-bounds access when the using nonzero values for 'plane_id' on kmb->plane_status: drivers/gpu/drm/kmb/kmb_plane.c: In function 'kmb_plane_atomic_disable': drivers/gpu/drm/kmb/kmb_plane.c:128:20: warning: array subscript 3 is

Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

2020-11-28 Thread Arnd Bergmann
ts #address-cells (1) differs from / (2) > > arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \ > > (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \ > > its #size-cells (1) differs from / (2) > > > > Arnd Bergmann fi

[GIT PULL] asm-generic: add correct MAX_POSSIBLE_PHYSMEM_BITS setting

2020-11-27 Thread Arnd Bergmann
Stefan Agner found on 32-bit Arm, but that exists on several other architectures. Signed-off-by: Arnd Bergmann Arnd Bergmann (1): arch: pgtable: define MAX_POSSIBLE_PHYSMEM_BITS where needed arch/arc/include/asm/pgtable.h

Re: [PATCH v2 02/24] exec: Simplify unshare_files

2020-11-27 Thread Arnd Bergmann
On Wed, Nov 25, 2020 at 2:16 AM Eric W. Biederman wrote: > > On 11/24/20 12:14 PM, Arnd Bergmann wrote: > > > > There are still PS3-Linux users out there. They use 'Homebrew' firmware > > released through 'Hacker' forums that allow them to run L

Re: [PATCH v2] microblaze: Remove noMMU code

2020-11-26 Thread Arnd Bergmann
. > > Cc: Mike Rapoport > Cc: Arnd Bergmann > Signed-off-by: Michal Simek Acked-by: Arnd Bergmann

Re: [PATCH] microblaze: Remove noMMU code

2020-11-25 Thread Arnd Bergmann
On Wed, Nov 25, 2020 at 2:01 PM Michal Simek wrote: > On 25. 11. 20 13:57, Arnd Bergmann wrote: > > On Wed, Nov 25, 2020 at 1:14 PM Michal Simek > > wrote: > >> > >> And second part. I know I removed that Kconfig macros for it but maybe > >> good to

Re: [PATCH] microblaze: Remove noMMU code

2020-11-25 Thread Arnd Bergmann
On Wed, Nov 25, 2020 at 1:14 PM Michal Simek wrote: > > And second part. I know I removed that Kconfig macros for it but maybe > good to talk about what needs to change to support different page size > for systems with MMU. I would recommend just leaving it hardwired to 4K. The benefits of larger

Re: [PATCH v2 02/24] exec: Simplify unshare_files

2020-11-24 Thread Arnd Bergmann
On Tue, Nov 24, 2020 at 8:58 PM Linus Torvalds wrote: > > On Tue, Nov 24, 2020 at 11:55 AM Eric W. Biederman > wrote: > > > > If cell happens to be dead we can remove a fair amount of generic kernel > > code that only exists to support cell. > > Even if some people might still use cell (which sou

[PATCH] Makefile.extrawarn: remove -Wnested-externs warning

2020-11-24 Thread Arnd Bergmann
From: Arnd Bergmann The -Wnested-externs warning has become useless with gcc, since this warns every time that BUILD_BUG_ON() or similar macros are used. With clang, the warning option does nothing to start with, so just remove it entirely. Suggested-by: Nathan Chancellor Signed-off-by: Arnd

Re: [PATCH 1/2] Makefile.extrawarn: move -Wcast-align to W=3

2020-11-24 Thread Arnd Bergmann
On Mon, Nov 23, 2020 at 12:18 PM Masahiro Yamada wrote: > > Applied to linux-kbuild. Thanks. > > But, I think people already tend to ignore W=2 warnings. Yes, this is what I was trying to change with this series and a couple of other patches I sent. When all the warnings from commonly included he

[PATCH net-next v4 0/4] remove compat_alloc_user_space()

2020-11-24 Thread Arnd Bergmann
From: Arnd Bergmann This is the fourth version of my series, now spanning four patches instead of two, with a new approach for handling struct ifreq compatibility after I realized that my earlier approach introduces additional problems. The idea here is to always push down the compat conversion

Re: [PATCH 2/5] riscv: Add QUEUED_SPINLOCKS & QUEUED_RWLOCKS supported

2020-11-24 Thread Arnd Bergmann
On Tue, Nov 24, 2020 at 3:39 PM Peter Zijlstra wrote: > On Tue, Nov 24, 2020 at 01:43:54PM +, guo...@kernel.org wrote: > > diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild > > + if (align) {\ > > + _

Re: [PATCH v2] staging: trivial: hikey9xx: fix be32<->u32 casting warnings

2020-11-24 Thread Arnd Bergmann
On Thu, Nov 19, 2020 at 1:31 PM Juan Antonio Aldea-Armenteros wrote: > > This patch fixes the following warnings reported by sparse, by adding > missing __force annotations. > > drivers/staging/hikey9xx/hisi-spmi-controller.c:164:24: warning: cast to > restricted __be32 > drivers/staging/hikey9xx

Re: [PATCH] firmware: xilinx: Use hash-table for api feature check

2020-11-24 Thread Arnd Bergmann
On Tue, Nov 24, 2020 at 1:54 PM Michal Simek wrote: > On 24. 11. 20 6:52, Rajan Vaja wrote: > > Some lines should be added. > > Cc: stable > Fixes: f3217d6f2f7a ("firmware: xilinx: fix out-of-bounds access") > > Tested-by: Michal Simek Reviewed-by: Arnd Bergm

Re: [PATCH] zlib: define get_unaligned16() only when used

2020-11-24 Thread Arnd Bergmann
On Tue, Nov 24, 2020 at 12:51 PM Christoph Hellwig wrote: > On Tue, Nov 24, 2020 at 12:08:40PM +0100, Jann Horn wrote: > > > Since commit acaab7335bd6 ("lib/zlib: remove outdated and incorrect > > > pre-increment optimization"), get_unaligned16() is only used when > > > !CONFIG_HAVE_EFFICIENT_UNAL

Re: [PATCH 1/4] amba: reorder functions

2020-11-24 Thread Arnd Bergmann
ig Looks good, I checked the whole series and this seems like a useful cleanup. All four patches: Reviewed-by: Arnd Bergmann

Re: [PATCH 3/4] amba: Make the remove callback return void

2020-11-24 Thread Arnd Bergmann
On Tue, Nov 24, 2020 at 11:32 AM Uwe Kleine-König wrote: > > Most amba drivers return 0 in their remove callback. Together with the > driver core ignoring the return value anyhow, it doesn't make sense to > return a value here. > > So add a warning to the only driver that could return an error cod

Re: [arm64] kernel BUG at kernel/seccomp.c:1309!

2020-11-23 Thread Arnd Bergmann
On Mon, Nov 23, 2020 at 12:15 PM Naresh Kamboju wrote: > > While booting arm64 kernel the following kernel BUG noticed on several arm64 > devices running linux next 20201123 tag kernel. > > > $ git log --oneline next-20201120..next-20201123 -- kernel/seccomp.c > 5c5c5fa055ea Merge remote-tracking

Re: [PATCH v3 1/2] epoll: add nsec timeout support with epoll_pwait2

2020-11-21 Thread Arnd Bergmann
On Fri, Nov 20, 2020 at 11:28 PM Willem de Bruijn wrote: > On Fri, Nov 20, 2020 at 2:23 PM Arnd Bergmann wrote: > > On Fri, Nov 20, 2020 at 5:01 PM Willem de Bruijn > > wrote: > > I think it'll be better to split the patchsets: > > epoll: convert internal api to

Re: [PATCH v3 1/2] epoll: add nsec timeout support with epoll_pwait2

2020-11-20 Thread Arnd Bergmann
On Fri, Nov 20, 2020 at 5:01 PM Willem de Bruijn wrote: > > On Fri, Nov 20, 2020 at 3:13 AM Arnd Bergmann wrote: > > > > On Thu, Nov 19, 2020 at 9:13 PM Willem de Bruijn > > wrote: > > > On Thu, Nov 19, 2020 at 10:45 AM Arnd Bergmann wrote: > Thanks

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-20 Thread Arnd Bergmann
On 09. 11. 20 18:31, William Breathitt Gray wrote: > > > > > > > On Mon, Nov 09, 2020 at 07:22:20PM +0200, Andy Shevchenko wrote: > > > > > > >> On Mon, Nov 09, 2020 at 12:11:40PM -0500, William Breathitt Gray > > > > > &

Re: [PATCH v3 1/2] epoll: add nsec timeout support with epoll_pwait2

2020-11-20 Thread Arnd Bergmann
On Thu, Nov 19, 2020 at 9:13 PM Willem de Bruijn wrote: > On Thu, Nov 19, 2020 at 10:45 AM Arnd Bergmann wrote: > > On Thu, Nov 19, 2020 at 3:31 PM Matthew Wilcox wrote: > > The right shift would work indeed, but it's also a bit ugly unless > > __estimate_accuracy() is

Re: [PATCH v3 1/2] epoll: add nsec timeout support with epoll_pwait2

2020-11-19 Thread Arnd Bergmann
On Thu, Nov 19, 2020 at 3:31 PM Matthew Wilcox wrote: > > On Thu, Nov 19, 2020 at 09:19:35AM -0500, Willem de Bruijn wrote: > > But for epoll, this is inefficient: in ep_set_mstimeout it calls > > ktime_get_ts64 to convert timeout to an offset from current time, only > > to pass it to select_estim

Re: [PATCH v3 1/2] epoll: add nsec timeout support with epoll_pwait2

2020-11-18 Thread Arnd Bergmann
On Wed, Nov 18, 2020 at 5:21 PM Willem de Bruijn wrote: > > diff --git a/arch/x86/entry/syscalls/syscall_32.tbl > > b/arch/x86/entry/syscalls/syscall_32.tbl > > index 109e6681b8fa..9a4e8ec207fc 100644 > > --- a/arch/x86/entry/syscalls/syscall_32.tbl > > +++ b/arch/x86/entry/syscalls/syscall_32.tb

Re: [PATCH v3 1/2] epoll: add nsec timeout support with epoll_pwait2

2020-11-18 Thread Arnd Bergmann
On Wed, Nov 18, 2020 at 4:10 PM Willem de Bruijn wrote: > On Wed, Nov 18, 2020 at 10:00 AM Matthew Wilcox wrote: > > > > On Wed, Nov 18, 2020 at 09:46:15AM -0500, Willem de Bruijn wrote: > > > -static inline struct timespec64 ep_set_mstimeout(long ms) > > > +static inline struct timespec64 ep_set

Re: [arm] BUG: KASAN: slab-out-of-bounds in memcmp+0x30/0x5c

2020-11-18 Thread Arnd Bergmann
On Wed, Nov 18, 2020 at 12:24 AM Nishanth Menon wrote: > On 16:25-20201117, Arnd Bergmann wrote: > > Yes, this was indeed a bug that has been around for some time now :( > > I tested with a variant of the above (did'nt like that > oinfo was being assigned an invalid add

Re: [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.

2020-11-17 Thread Arnd Bergmann
On Tue, Nov 17, 2020 at 5:07 PM Lee Jones wrote: > On Tue, 17 Nov 2020, Matthias Brugger wrote: > > On 17/11/2020 13:37, Lee Jones wrote: > > > On Tue, 17 Nov 2020, Matthias Brugger wrote: > > > > If you want to go the route for me rebasing my tree on top of for-mfd-next > > then I'd like to have

Re: [arm] BUG: KASAN: slab-out-of-bounds in memcmp+0x30/0x5c

2020-11-17 Thread Arnd Bergmann
On Tue, Nov 17, 2020 at 3:44 PM Naresh Kamboju wrote: > > While booting arm KASAN config enabled kernel on TI x15 device > Linux version 5.10.0-rc3-next-20201116. > > The reported issue is not a regression since we have recently started testing > arm+kasan builds on LKFT. > > The boot was not succ

Re: [PATCH v2 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2020-11-17 Thread Arnd Bergmann
On Tue, Nov 17, 2020 at 3:53 PM Gustavo Pimentel wrote: > On Tue, Nov 17, 2020 at 14:4:49, Arnd Bergmann wrote: > > On Fri, Nov 13, 2020 at 11:37 PM Gustavo Pimentel > > wrote: > > > > > > This patch series adds a new driver called xData-pcie for the Synopsy

Re: [PATCH v2 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2020-11-17 Thread Arnd Bergmann
On Fri, Nov 13, 2020 at 11:37 PM Gustavo Pimentel wrote: > > This patch series adds a new driver called xData-pcie for the Synopsys > DesignWare PCIe prototype. > > The driver configures and enables the Synopsys DesignWare PCIe traffic > generator IP inside of prototype Endpoint which will generat

Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory

2020-11-17 Thread Arnd Bergmann
On Sat, Nov 14, 2020 at 12:58 AM Alexandre Belloni wrote: > On 11/11/2020 09:51:26+0100, Linus Walleij wrote: > > On Wed, Nov 11, 2020 at 7:18 AM kernel test robot wrote: > > > > >In file included from include/linux/kconfig.h:7, > > > from : > > > >> ./include/generated/au

Re: [PATCH] syscalls: Fix file comments for syscalls implemented in kernel/sys.c

2020-11-16 Thread Arnd Bergmann
On Mon, Nov 16, 2020 at 5:23 PM Christoph Hellwig wrote: > > On Thu, Nov 12, 2020 at 04:56:57PM -0500, Tal Zussman wrote: > > The relevant syscalls were previously moved from kernel/timer.c to > > kernel/sys.c, > > but the comments weren't updated to reflect this change. > > > > Fixing these comm

Re: [PATCH v3 4/7] crypto: sun4i-ss: handle BigEndian for cipher

2020-11-16 Thread Arnd Bergmann
On Mon, Nov 16, 2020 at 2:53 PM Corentin Labbe wrote: > > Ciphers produce invalid results on BE. > Key and IV need to be written in LE. > > Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System > crypto accelerator") > Cc: > Signed-off-by: Corentin Labbe > --- > drivers/crypt

Re: [PATCH v7 15/18] NTB: Add support for EPF PCI-Express Non-Transparent Bridge

2020-11-16 Thread Arnd Bergmann
On Mon, Nov 16, 2020 at 6:19 AM Kishon Vijay Abraham I wrote: > On 12/11/20 6:54 pm, Arnd Bergmann wrote: > > > > This looks very promising indeed, I need to read up on the whole > > discussion there. I also see your slides at [1] that help do explain some > > of

Re: [PATCH] irqdomain: fix -Wshadow warning

2020-11-16 Thread Arnd Bergmann
On Mon, Nov 16, 2020 at 3:03 PM Thomas Gleixner wrote: > On Mon, Oct 26 2020 at 17:20, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When building with W=2, there are tons of warnings about conflicting > > local and global definitions of 'nr_irqs' in

Re: irq-loongson-pch-pic.c:undefined reference to `of_iomap'

2020-11-16 Thread Arnd Bergmann
On Mon, Nov 16, 2020 at 9:37 AM Geert Uytterhoeven wrote: > On Mon, Nov 16, 2020 at 9:33 AM Arnd Bergmann wrote: > > On Mon, Nov 16, 2020 at 5:33 AM Randy Dunlap wrote: > > > On 11/13/20 3:27 PM, kernel test robot wrote: > > (adding s390 folks to cc) > > >

Re: irq-loongson-pch-pic.c:undefined reference to `of_iomap'

2020-11-16 Thread Arnd Bergmann
On Mon, Nov 16, 2020 at 5:33 AM Randy Dunlap wrote: > > On 11/13/20 3:27 PM, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: 9e6a39eae450b81c8b2c8cbbfbdf8218e9b40c81 > > commit: ef8c01eb64ca6719da449dab0aa9424e13c58bd0

Re: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-14 Thread Arnd Bergmann
On Sat, Nov 14, 2020 at 4:14 PM Richard Cochran wrote: > > On Fri, Nov 13, 2020 at 05:21:43PM +0100, Arnd Bergmann wrote: > > I've prototyped a patch that I think makes this more sensible > > again: https://pastebin.com/AQ5nWS9e > > I like the behavior described in

Re: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-13 Thread Arnd Bergmann
On Fri, Nov 13, 2020 at 12:27 AM Richard Cochran wrote: > > On Thu, Nov 12, 2020 at 10:21:21PM +0100, Arnd Bergmann wrote: > > I agree that the 'imply' keyword in Kconfig is what made this a > > lot worse, and it would be best to replace that with normal > >

Re: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-12 Thread Arnd Bergmann
On Thu, Nov 12, 2020 at 7:19 PM Richard Cochran wrote: > > On Thu, Nov 12, 2020 at 09:25:12AM +0100, Arnd Bergmann wrote: > > This is not really getting any better. If Richard is worried about > > Kconfig getting changed here, I would suggest handling the > > case

Re: [PATCH] mthca: work around -Wenum-conversion warning

2020-11-12 Thread Arnd Bergmann
On Thu, Nov 12, 2020 at 4:57 PM Jason Gunthorpe wrote: > > On Mon, Oct 26, 2020 at 10:12:30PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > gcc points out a suspicious mixing of enum types in a function that > > converts from MTHCA_OPCODE_* values to I

Re: [PATCH v7 15/18] NTB: Add support for EPF PCI-Express Non-Transparent Bridge

2020-11-12 Thread Arnd Bergmann
On Tue, Nov 10, 2020 at 4:42 PM Kishon Vijay Abraham I wrote: > On 10/11/20 8:29 pm, Arnd Bergmann wrote: > > On Tue, Nov 10, 2020 at 3:20 PM Kishon Vijay Abraham I > > wrote: > >> On 10/11/20 7:55 am, Sherry Sun wrote: > > > >>> But for VOP, only two b

Re: [PATCH v2] Make iwmmxt.S support Clang's integrated assembler

2020-11-12 Thread Arnd Bergmann
On Thu, Nov 12, 2020 at 9:42 AM Ard Biesheuvel wrote: > Although I must admit I am still on the fence when it comes to the > policy around rewriting perfectly valid code like this to accommodate > a toolchain that nobody is likely to use to build the code in > question. > > Perhaps we should at l

Re: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-12 Thread Arnd Bergmann
On Thu, Nov 12, 2020 at 2:48 AM 王擎 wrote: > >> On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote: > > > >I don't think v1 builds cleanly folks (not 100% sure, cpts is not > >compiled on x86): > > > > ret = cpts->ptp_clock ? cpts->ptp_clock : (-ENODEV); > > > >ptp_cloc

Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS

2020-11-11 Thread Arnd Bergmann
On Wed, Nov 11, 2020 at 2:39 PM Thomas Bogendoerfer wrote: > On Wed, Nov 11, 2020 at 11:57:02AM +0100, Arnd Bergmann wrote: > > On Wed, Nov 11, 2020 at 11:26 AM Mike Rapoport wrote: > > > > > > On Wed, Nov 11, 2020 at 10:33:29AM +0100, Arnd Bergmann wrote: > > &g

Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS

2020-11-11 Thread Arnd Bergmann
On Wed, Nov 11, 2020 at 11:26 AM Mike Rapoport wrote: > > On Wed, Nov 11, 2020 at 10:33:29AM +0100, Arnd Bergmann wrote: > > On Tue, Nov 10, 2020 at 5:21 PM Mike Rapoport wrote: > > > On Tue, Nov 10, 2020 at 12:21:11PM +0100, Arnd Bergmann wrote: > > > > > &g

Re: [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.

2020-11-11 Thread Arnd Bergmann
stead of returning -ENODEV, > the function returns NULL. This makes error checking simpler when the > regmap phandle is optional. > > Suggested-by: Nicolas Boichat > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Matthias Brugger Reviewed-by: Arnd Bergmann

Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS

2020-11-11 Thread Arnd Bergmann
On Tue, Nov 10, 2020 at 5:21 PM Mike Rapoport wrote: > On Tue, Nov 10, 2020 at 12:21:11PM +0100, Arnd Bergmann wrote: > > > > To be on the safe side, we could provoke a compile-time error > > when CONFIG_PHYS_ADDR_T_64BIT is set on a 32-bit > > architecture, but MAX_P

Re: arm: kasan: WARNING: CPU: 0 PID: 0 at arch/arm/kernel/insn.c:47 __arm_gen_branch

2020-11-11 Thread Arnd Bergmann
On Wed, Nov 11, 2020 at 9:15 AM Ard Biesheuvel wrote: > > On Wed, 11 Nov 2020 at 07:13, Naresh Kamboju > wrote: > > > > The following kernel warning noticed on arm KASAN enabled config while > > booting. > > > > [0.00] Linux version 5.10.0-rc3-next-20201110 > > (tuxmake@e15fe3b4fdc6) (a

[tip: perf/urgent] perf/x86/intel/uncore: Fix Add BW copypasta

2020-11-11 Thread tip-bot2 for Arnd Bergmann
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 1a8cfa24e21c2f154791f0cdd85fc28496918722 Gitweb: https://git.kernel.org/tip/1a8cfa24e21c2f154791f0cdd85fc28496918722 Author:Arnd Bergmann AuthorDate:Mon, 26 Oct 2020 22:51:57 +01:00

Re: [PATCH v2] Make iwmmxt.S support Clang's integrated assembler

2020-11-10 Thread Arnd Bergmann
On Tue, Nov 10, 2020 at 9:11 PM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Tue, Nov 10, 2020 at 12:10 PM Jian Cai wrote: > > > > I tried to verify with ixp4xx_defconfig, and I noticed it also used > > CONFIG_CPU_BIG_ENDIAN=y to enable big endianness as follows, > > > > linux$ grep EN

Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS

2020-11-10 Thread Arnd Bergmann
On Tue, Nov 10, 2020 at 1:24 PM Stefan Agner wrote: > On 2020-11-10 12:21, Arnd Bergmann wrote: > > Good idea. I wonder what other architectures need the same though. > > >> That's what x86 does: > >> > >> $ git grep -w MAX_POSSIBLE_PHYSMEM_

Re: [PATCH v7 15/18] NTB: Add support for EPF PCI-Express Non-Transparent Bridge

2020-11-10 Thread Arnd Bergmann
On Tue, Nov 10, 2020 at 3:20 PM Kishon Vijay Abraham I wrote: > On 10/11/20 7:55 am, Sherry Sun wrote: > > But for VOP, only two boards are needed(one board as host and one board as > > card) to realize the > > communication between the two systems, so my question is what are the > > advantages

Re: [PATCH 2/3] arm: introduce IRQ stacks

2020-11-10 Thread Arnd Bergmann
On Tue, Nov 10, 2020 at 1:06 PM Tony Lindgren wrote: > > Are these actually ARMv6? Most ARM11 cores you'd come across > > in practice are ARMv6K (ARM1136r1, ARM1167, ARM11MPCore), > > in particular every SoC that has any mainline support except for > > the ARM1136r0 based OMAP2 and i.MX3. > > I'v

Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS

2020-11-10 Thread Arnd Bergmann
On Tue, Nov 10, 2020 at 10:58 AM Mike Rapoport wrote: > > > > > > asm/sparsemem.h is not available on some architectures. > > > It's better to use linux/mmzone.h instead. Ah, I missed that, too. > > Hm, linux/mmzone.h only includes asm/sparsemem.h when CONFIG_SPARSEMEM > > is enabled. However, o

Re: [PATCH 2/3] arm: introduce IRQ stacks

2020-11-10 Thread Arnd Bergmann
On Tue, Nov 10, 2020 at 10:19 AM Tony Lindgren wrote: > * Arnd Bergmann [201109 19:10]: > > On Mon, Nov 9, 2020 at 3:45 PM Tony Lindgren wrote: > > > > I know it works, my point was that I'm not sure anyone cares > > any more ;-) > > Well for example whate

Re: [PATCH 2/3] arm: introduce IRQ stacks

2020-11-09 Thread Arnd Bergmann
On Mon, Nov 9, 2020 at 3:45 PM Tony Lindgren wrote: > > > > As discussed on IRC, I think it can still be done in one of these > > ways, though admittedly none of them are perfect: > > > > a) add runtime patching for __my_cpu_offset() when > > CONFIG_SMP_ON_UP is set. This adds complexity but avo

<    5   6   7   8   9   10   11   12   13   14   >