Re: [RFC PATCH 00/11] arch_gettimeoffset and ARM timer rework

2012-11-12 Thread Arnd Bergmann
On Thursday 08 November 2012, Stephen Warren wrote: It would probably be easiest to merge this whole series through the arm-soc tree. Anything else would require some co-ordination. Fine with me. The patches all look good to me, so let's give people a little more time to weigh in with Acks and

Re: [RFC PATCH v1 31/31] ARC: [plat-arcfpga] defconfig

2012-11-12 Thread Arnd Bergmann
On Monday 12 November 2012, James Hogan wrote: Please use make defconfig to generate minimal defconfig files, instead of copying the entire file here. I think you mean make savedefconfig? (I think make defconfig loads the default defconfig). Yes, that's right. Sorry for the typo.

Re: [PATCH 00/16 v3] f2fs: introduce flash-friendly file system

2012-11-12 Thread Arnd Bergmann
On Monday 12 November 2012, Martin Steigerwald wrote: Am Samstag, 10. November 2012 schrieb Arnd Bergmann: I would also recommend using flashbench to find out the optimum parameters for your device. You can download it from git://git.linaro.org/people/arnd/flashbench.git In the long run

Re: [PATCH] ARM: integrator: use BUG_ON where possible

2012-11-12 Thread Arnd Bergmann
; @@ - if (e) BUG(); + BUG_ON(e); // /smpl Signed-off-by: Sasha Levin sasha.le...@oracle.com Linus Walleij is doing most of the integrator work these days, maybe he wants to apply the patch. Acked-by: Arnd Bergmann a...@arndb.de arch/arm/mach-integrator/pci_v3.c |9 +++-- 1 file

Re: [PATCH] cpuidle: add Calxeda SOC idle support

2012-11-12 Thread Arnd Bergmann
Cc: Len Brown len.br...@intel.com Cc: Rafael J. Wysocki r...@sisk.pl Acked-by: Arnd Bergmann a...@arndb.de It's not really clear where we want ARM cpuidle drivers. We're moving everything else out of arch/arm, and my understanding is Len doesn't want them in drivers/idle. It seems kind

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-13 Thread Arnd Bergmann
On Tuesday 13 November 2012, Rob Clark wrote: right, that is what I was worried about.. but what about something along the lines of: case 8: { \ if (sizeof(x) 8) \

Re: [RFC PATCH v1 14/31] ARC: syscall support

2012-11-13 Thread Arnd Bergmann
On Tuesday 13 November 2012, Gilad Ben-Yossef wrote: So, I completely agree about not adding more deprecated system call or ABIs (thinking about the ptrace regset issues in another patch in the same patchset), but on the other hand I have to wonder if having a port in the tree that doesn't

Re: [PATCH V2 2/11] time: convert arch_gettimeoffset to a pointer

2012-11-13 Thread Arnd Bergmann
On Tuesday 13 November 2012, Stephen Warren wrote: One last thing to watch out for: If you're trying to build a kernel that mixes clocksource support with get_arch_timeoffset, you'll need to rework the #ifdef in update_wall_time(), since we currently assume with get_arch_timeoffset() that

new architectures, time_t __kernel_long_t

2012-11-14 Thread Arnd Bergmann
Since we are in the review phase for two new architectures that we should be merging into the mainline kernel, I think we need to come up with a solution for making them use a proper 64-bit time_t. Right now, the only 32-bit user space interface we have to use 64-bit time_t is the x32 side of

Re: [RFC PATCH v1 14/31] ARC: syscall support

2012-11-14 Thread Arnd Bergmann
On Tuesday 13 November 2012, James Hogan wrote: Hopefully with several architecture maintainers asking for this it might get somewhere, but indeed we're aware of the feedback problem on that list. The points that I've considered for defaulting to old syscalls: * doesn't change existing

Re: [PATCH] Centralise CONFIG_ARCH_NO_VIRT_TO_BUS

2012-11-14 Thread Arnd Bergmann
, at least for the platforms that are known to not need virt_to_bus. Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 01/16] f2fs: add document

2012-10-14 Thread Arnd Bergmann
On Sunday 14 October 2012, Jaegeuk Kim wrote: 2012-10-13 (토), 18:35 +, Arnd Bergmann: + +DESIGN + + +On-disk Layout

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-14 Thread Arnd Bergmann
On Sunday 14 October 2012, Vyacheslav Dubeyko wrote: On Oct 14, 2012, at 11:09 AM, Jaegeuk Kim wrote: 2012-10-14 (일), 02:21 +0400, Vyacheslav Dubeyko: By the way, how about extended attributes? It is possible to save in extended attribute a hint about file's content nature during

Re: [PATCH REGRESSION FIX] dw_dmac: make driver's endianness configurable

2012-10-14 Thread Arnd Bergmann
to finish other changes to the same module(3). (1) https://patchwork.kernel.org/patch/608211 (2) https://lkml.org/lkml/2012/8/26/148 (3) https://lkml.org/lkml/2012/9/21/173 Signed-off-by: Hein Tibosch hein_tibo...@yahoo.es Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list

Re: [PULL REQ] IXP4xx changes for Linux 3.7

2012-10-14 Thread Arnd Bergmann
On Saturday 13 October 2012, Krzysztof Halasa wrote: Linus, please pull my ARM IXP4xx changes for 3.7: The following changes since commit 4d7127dace8cf4b05eb7c8c8531fc204fbb195f4: Merge branch 'for-linus' of git://git.kernel.org/.../jmorris/linux-security (2012-10-13 11:29:00 +0900)

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-15 Thread Arnd Bergmann
On Monday 15 October 2012, Changman Lee wrote: 2012년 10월 15일 월요일에 Arnd Bergmanna...@arndb.de님이 작성: It is only a performance hint though, so it is not a correctness issue the file system gets it wrong. In order to do efficient garbage collection, a log structured file system should take

Re: [PATCH 2/2] Documentation: Describe Device Tree bindings for GPIO Regulator driver

2012-10-15 Thread Arnd Bergmann
On Monday 15 October 2012, Lee Jones wrote: diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt new file mode 100644 index 000..5f77ee0 --- /dev/null +++

Re: [PATCH 1/2] mmc: core: Support all MMC capabilities when booting from Device Tree

2012-10-15 Thread Arnd Bergmann
On Monday 15 October 2012, Lee Jones wrote: Capabilities are an important part of the MMC subsystem. Much supported functionality would be lost if we didn't provide the same level of support when booting Device Tree as we currently do when the subsystem is passed capabilities via platform

Re: [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers

2012-10-15 Thread Arnd Bergmann
On Monday 15 October 2012, Steven Rostedt wrote: On Mon, 2012-10-15 at 22:23 +0200, Frederic Weisbecker wrote: 2012/10/15 Steven Rostedt rost...@goodmis.org: On Mon, 2012-10-15 at 17:11 +0100, Catalin Marinas wrote: BTW, is there any rational reason that the include path lookup doesn't

Re: [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers

2012-10-16 Thread Arnd Bergmann
On Tuesday 16 October 2012, Mark Brown wrote: On Tue, Oct 16, 2012 at 12:18:05AM +0200, Frederic Weisbecker wrote: I came up with stuff for it, though it needed prettyfying. This seems to do the trick: (It's the diff result of ln -s asm-generic include/asm) Unfortunately, this is not

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-16 Thread Arnd Bergmann
On Tuesday 16 October 2012, Jaegeuk Kim wrote: On Monday 15 October 2012, Dave Chinner wrote: On Sun, Oct 14, 2012 at 03:19:37PM +, Arnd Bergmann wrote: On Sunday 14 October 2012, Vyacheslav Dubeyko wrote: On Oct 14, 2012, at 11:09 AM, Jaegeuk Kim wrote: 2012-10-14 (일), 02:21

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-16 Thread Arnd Bergmann
On Tuesday 16 October 2012, Jaegeuk Kim wrote: Thank you for a lot of points to be addressed. :) Maybe it's time to summarize them. Please let me know what I misunderstood. [In v2] - Extension list : Mkfs supports configuring extensions by user, and that information will be stored

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-17 Thread Arnd Bergmann
On Tuesday 16 October 2012, Jaegeuk Kim wrote: 2012-10-16 (화), 16:14 +, Arnd Bergmann: On Tuesday 16 October 2012, Jaegeuk Kim wrote: For the lower bound, being able to support as little as 2 logs for cheap hardware would be nice, but 4 logs is the important one. 5 logs is probably

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-17 Thread Arnd Bergmann
On Wednesday 17 October 2012, Jaegeuk Kim wrote: As discussed with Dave, I propose the following items. [In v2] - Extension list : Mkfs supports configuring extensions by user, and that information will be stored in the superblock. I'll add a mount option to enable/disable

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-17 Thread Arnd Bergmann
On Tuesday 16 October 2012, Jaegeuk Kim wrote: An xattr on the root inode that holds a list like this is something that could be set at mkfs time, but then also updated easily by new software packages that are installed... Yes, good idea. Likewise many file systems, f2fs

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-17 Thread Arnd Bergmann
On Tuesday 16 October 2012, Jaegeuk Kim wrote: IIRC, fs2fs uses 4k inodes, so IMO per-inode xattr tress with internal storage before spilling to an external block is probably the best approach to take... Yes, indeed this is the best approach to f2fs's xattr. Apart from giving fs hints,

Re: [PATCH v2 v2 v2 8/8] spi/s3c64xx: use correct dma_transfer_direction type

2012-10-17 Thread Arnd Bergmann
00:00:00 2001 From: Arnd Bergmann a...@arndb.de Date: Mon, 30 Apr 2012 16:31:27 + Subject: [PATCH] spi/s3c64xx: use correct dma_transfer_direction type There is a subtle difference between dma_transfer_direction and dma_data_direction: the former is used by the dmaengine framework, while

Re: [PATCH 1/2] mmc: core: Support all MMC capabilities when booting from Device Tree

2012-10-17 Thread Arnd Bergmann
On Monday 15 October 2012, Lee Jones wrote: and so on. What are you actually missing in the properties that are already there? MMC_CAP_ERASE This one seems to be set unconditionally on some controllers but not on others. Why would it need to be configurable? MMC_CAP_UHS_SDR12

Re: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-25 Thread Arnd Bergmann
On Tuesday 25 September 2007, Joachim Fenkes wrote: Extract generic of_device allocation code from of_platform_device_create() and move it into of_device.[ch], called of_device_alloc(). Also, there's now of_device_free() which puts the device node. Signed-off-by: Joachim Fenkes [EMAIL

Re: [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-25 Thread Arnd Bergmann
On Tuesday 25 September 2007, Joachim Fenkes wrote: ibmebus_{,un}register_driver() are replaced by dummy functions because ibmebus is temporarily unusable in this transitional state. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] ---  arch/powerpc/kernel/ibmebus.c |  199

Re: [PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-25 Thread Arnd Bergmann
On Tuesday 25 September 2007, Joachim Fenkes wrote: The devtree root is now searched for devices matching a built-in whitelist during boot, so these devices appear on the bus from the beginning. It is still possible to manually add/remove devices to/from the bus by using the probe/remove sysfs

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-25 Thread Arnd Bergmann
On Tuesday 25 September 2007, Joachim Fenkes wrote: Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] This is missing a description, but the patch looks good. Arnd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

[PATCH] powerpc: fix pci domain detection

2007-09-26 Thread Arnd Bergmann
the return value of pci_proc_domain() ends up being always zero, which makes /proc/bus/pci useless. Change the logic to always return '1' for a nonzero buid value. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c index 291ffbc

Re: [Announce] Linux-tiny project revival

2007-09-27 Thread Arnd Bergmann
On Thursday 20 September 2007, you wrote: So instead of:   printk(KERN_NOTICE Fruit=%d\n, banana); It would now be:   printk(KERN_NOTICE, Fruit=%d\n, banana); Change the header from:   #define KERN_NOTICE 5 to:   #define KERN_NOTICE 5 Then you can change the printk guts to do

Re: [PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-27 Thread Arnd Bergmann
sysfs interface. Also, when a device driver registers itself, the devtree is matched against its matchlist. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-27 Thread Arnd Bergmann
on of_platform (like ibmebus will) can build upon this code instead of reinventing the wheel. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-27 Thread Arnd Bergmann
-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-27 Thread Arnd Bergmann
will still compile and run during the transition and git bisect will be happy. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [Announce] Linux-tiny project revival

2007-09-27 Thread Arnd Bergmann
On Thursday 27 September 2007, you wrote: Then you don't have to change every single printk in the kernel, but only those that don't currently come with a log level. More importantly, you can do the conversion without a flag day, by spreading (an empty) PRINTK_CONTINUED in places that do

Re: [COMPAT] Add compat_merge64 helper

2007-09-28 Thread Arnd Bergmann
On Saturday 29 September 2007, you wrote: +static inline u64 compat_merge64(u32 left, u32 right) +{ +#if defined(__BIG_ENDIAN) +   return ((u64)left 32) | right; +#else /* defined (__LITTLE_ENDIAN) */ +   return ((u64)right 32) | left; +#endif +} Looks good, if we can guarantee

Re: [COMPAT] Add compat_merge64 helper

2007-09-28 Thread Arnd Bergmann
On Saturday 29 September 2007, Kyle McMartin wrote: On Sat, Sep 29, 2007 at 01:38:23AM +0200, Arnd Bergmann wrote: 1. Byte order matches the order in which 64 bit arguments are split    in system call conventions on all platforms. I checked powerpc, sparc, and mips, which are (besides

Re: [PATCH] Fix blktrace setup 32-bit ioctl on 64-bit kernels

2007-10-02 Thread Arnd Bergmann
On Tuesday 02 October 2007, Jens Axboe wrote: The layout of struct blk_user_trace_setup is a bit unfortunate, it gets padded differently on 32-bit and 64-bit archs. So right now it's not possible to trace 64-bit kernels with a 32-bit app. This patch fixes that up by adding a compat ioctl

Re: [PATCH] Fix blktrace setup 32-bit ioctl on 64-bit kernels

2007-10-03 Thread Arnd Bergmann
On Tuesday 02 October 2007, Jens Axboe wrote: Hi Arnd, Updated patch below. I kept the code in compat_ioctl.c, to me it seems like the cleanest approach. I need the BLKTRACESETUP32 define both in compat_ioctl.c and blktrace.c if I move it, and I need to hard-core the struct size or define

Re: [PATCH] Fix blktrace setup 32-bit ioctl on 64-bit kernels

2007-10-03 Thread Arnd Bergmann
file with all the compat handling for block devices moved over from fs/compat_ioctl.c, and done in a nicer way. If you agree, with this approach, I'd volunteer to come up with a patch. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6/block/blktrace.c

Re: [PATCH] Fix blktrace setup 32-bit ioctl on 64-bit kernels

2007-10-03 Thread Arnd Bergmann
On Wednesday 03 October 2007, Arnd Bergmann wrote: Jens, I think the best overall solution would be to have a block/compat_ioctl.c file with all the compat handling for block devices moved over from fs/compat_ioctl.c, and done in a nicer way. If you agree, with this approach, I'd volunteer

Re: [PATCH] Fix blktrace setup 32-bit ioctl on 64-bit kernels

2007-10-04 Thread Arnd Bergmann
On Thursday 04 October 2007, you wrote: This looks a lot better! I don't mind seperating the block bits, when we get the whole bunch in there. Just seemed overly silly and complicated to do it for just one ioctl command. When you are happy with this patch, I'll add it to the pending block

[PATCH] block: move ioctl conversion to compat_blkdev_ioctl

2007-10-05 Thread Arnd Bergmann
. In the process, we remove a few indirections from the call graph for compat block ioctls. This patch is still an entirely untested preview and should be split into smaller chunks. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- block/Makefile |1 block/blktrace.c

Re: [PATCH] block: move ioctl conversion to compat_blkdev_ioctl

2007-10-05 Thread Arnd Bergmann
On Friday 05 October 2007, Jens Axboe wrote: As before, this looks pretty good. I'll toss it in the tester and see if things still work. Ok, thanks a lot. Arnd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

[patch 8/9] compat_ioctl: call disk-fops-compat_ioctl without BKL

2007-10-06 Thread Arnd Bergmann
Normally, all compat_ioctl operations are called without the BKL, the block device operations are an exception to this rule. Make this work the same as the other handlers. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- It would be good to find out whether it has been using the BKL

[patch 2/9] compat_ioctl: add compat_blkdev_driver_ioctl()

2007-10-06 Thread Arnd Bergmann
Handle those blockdev ioctl calls that are compatible directly from the compat_blkdev_ioctl() function, instead of having to go through the compat_ioctl hash lookup. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6/block/compat_ioctl.c

[patch 5/9] compat_ioctl: move BLKPG handling to block/compat_ioctl.c

2007-10-06 Thread Arnd Bergmann
BLKPG is common to all block devices, so it should be handled by common code. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6/block/compat_ioctl.c === --- linux-2.6.orig/block/compat_ioctl.c +++ linux-2.6/block

[patch 0/9] compat_ioctl: introduce block/compat_ioctl.c

2007-10-06 Thread Arnd Bergmann
This is my block ioctl series split up into managable chunks. I'm not really sure about the last two of these, I'd prefer to get a second opinion on those. Please apply once your tests have gone though. Arnd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the

[patch 1/9] compat_ioctl: move common block ioctls to compat_blkdev_ioctl

2007-10-06 Thread Arnd Bergmann
Make compat_blkdev_ioctl and blkdev_ioctl reflect the respective native versions. This is somewhat more efficient and makes it easier to keep the two in sync. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6/block/Makefile

[patch 4/9] compat_ioctl: move hdio calls to block/compat_ioctl.c

2007-10-06 Thread Arnd Bergmann
These are common to multiple block drivers, so they should be handled by the block layer. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6/block/compat_ioctl.c === --- linux-2.6.orig/block/compat_ioctl.c +++ linux-2.6

[patch 6/9] compat_ioctl: move cdrom handlers to block/compat_ioctl.c

2007-10-06 Thread Arnd Bergmann
These are shared by all cd-rom drivers and should have common handlers. Do slight cosmetic cleanups in the process. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6/block/compat_ioctl.c === --- linux-2.6.orig/block

[patch 7/9] compat_ioctl: move floppy handlers to block/compat_ioctl.c

2007-10-06 Thread Arnd Bergmann
The floppy ioctls are used by multiple drivers, so they should be handled in a shared location. Also, add minor cleanups. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6/block/compat_ioctl.c === --- linux-2.6.orig

[patch 9/9] compat_ioctl: fix compat_fd_ioctl pointer access

2007-10-06 Thread Arnd Bergmann
, but assigning it to an empty string is a safer choice and gets rid of the sparse warning. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6/block/compat_ioctl.c === --- linux-2.6.orig/block/compat_ioctl.c +++ linux-2.6/block

[patch 3/9] compat_ioctl: handle blk_trace ioctls

2007-10-06 Thread Arnd Bergmann
blk_trace_setup is broken on x86_64 compat systems, this makes the code work correctly on all 64 bit architectures in compat mode. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6/block/blktrace.c === --- linux-2.6

Re: [patch 1/9] compat_ioctl: move common block ioctls to compat_blkdev_ioctl

2007-10-06 Thread Arnd Bergmann
On Saturday 06 October 2007, Christoph Hellwig wrote: +static int compat_put_u64(unsigned long arg, u64 val) +{ + return put_user(val, (compat_u64 __user *)compat_ptr(arg)); +} These should probably be in compat.h Hmm, I'm not sure. They are modeled after the

Re: [PATCH] net/core: split dev_ifsioc() according to locking

2007-10-06 Thread Arnd Bergmann
On Saturday 06 October 2007, Jeff Garzik wrote: This always bugged me:  dev_ioctl() called dev_ifsioc() either inside read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being executed. This change moves the ioctls executed inside dev_base_lock to a new function,

Re: [patch 8/9] compat_ioctl: call disk-fops-compat_ioctl without BKL

2007-10-07 Thread Arnd Bergmann
On Sunday 07 October 2007, Al Viro wrote: On Sat, Oct 06, 2007 at 08:19:10PM +0200, Arnd Bergmann wrote: It would be good to find out whether it has been using the BKL on purpose or by accident, before this patch gets applied. Leave it alone, for now - I'm rebasing my series on top

[PATCHv2 1/9] compat_ioctl: move common block ioctls to compat_blkdev_ioctl

2007-10-08 Thread Arnd Bergmann
Make compat_blkdev_ioctl and blkdev_ioctl reflect the respective native versions. This is somewhat more efficient and makes it easier to keep the two in sync. Also get rid of the bogus handling for broken_blkgetsize and the duplicate entry for BLKRASET. Signed-off-by: Arnd Bergmann [EMAIL

Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions

2007-08-31 Thread Arnd Bergmann
On Friday 31 August 2007, Joachim Fenkes wrote: The whole logic of dynamically adding and removing device is rather bogus, and it prevents autoloading of device drivers. of_platform_make_bus_id is the function that is responsible for creating unique names over there. The plaintiff

Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: On Wed, 2007-09-12 at 17:43 +1000, Michael Ellerman wrote: This patch adds DEFINE_SPUFS_ATTRIBUTE(), a wraper around DEFINE_SIMPLE_ATTRIBUTE which does the specified locking for the get routine for us. Unfortunately we need two

Re: [PATCH 11/15] Combine spufs_coredump_calls with spufs_calls

2007-09-12 Thread Arnd Bergmann
-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 10/15] Add contents of npc file to SPU coredumps

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: Signed-off-by: Michael Ellerman [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 09/15] Internal __spufs_get_foo() routines should take a spu_context *

2007-09-12 Thread Arnd Bergmann
plonking it in and out of a void * again. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 08/15] Use spufs_coredump_num_notes everywhere, and don't NULL terminate

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: The spufs_coredump_read array is NULL terminated, and we also store the size. We only need one or the other, and storing the size should save a teensy bit of memory vs NULL terminating, so do that. Given that we have another array in

Re: [PATCH 07/15] Don't return -ENOSYS as extra notes size if spufs is not loaded

2007-09-12 Thread Arnd Bergmann
is not loaded, which is interpreted by the coredump code as an extra note size of -38 bytes. This leads to a corrupt core dump. If spufs is not loaded there will be no SPU ELF notes to write, and so the extra notes size will be == 0. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] Acked-by: Arnd

Re: [PATCH 06/15] Correctly calculate the size of the local-store to dump

2007-09-12 Thread Arnd Bergmann
-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Please pull for-2.6.23 branch of cell-2.6.git

2007-07-20 Thread Arnd Bergmann
Hi Linus, Please pull from master.kernel.org:/pub/scm/linux/kernel/git/arnd/cell-2.6.git for-2.6.23 This is a number of changes that fell through the cracks because it wasn't clear how we were going to merge it in the absence of paulus. Mostly bug fixes, except a few features that

Re: [PATCH] compat_ioctl requires CONFIG_BLOCK

2007-07-20 Thread Arnd Bergmann
On Saturday 21 July 2007, Sebastian Siewior wrote: Got with randconfig include/linux/loop.h:66: error: expected specifier-qualifier-list before 'request_queue_t' make[1]: *** [fs/compat_ioctl.o] Error 1 parts of compat ioctl require CONFIG_BLOCK to be set. Signed-off-by: Sebastian

Re: [RFC, Announce] Unified x86 architecture, arch/x86

2007-07-20 Thread Arnd Bergmann
On Saturday 21 July 2007, Thomas Gleixner wrote: The topic of sharing more x86 code has been discussed on LKML a number of times. Various approaches were discussed and we decided to advance the discussion by implementing a full solution that brings the transition to a shared tree to

Re: [PATCH] compat_ioctl requires CONFIG_BLOCK

2007-07-21 Thread Arnd Bergmann
On Saturday 21 July 2007, Christoph Hellwig wrote: Adding #ifdef around an #include is considered bad style. Better just make loop.h compile without any conditionals. Does the below patch work for you? That patch looks good, but even better would be adding a compat_ioctl handler to the

Re: Need Help on compat_ioctl implementation

2007-07-24 Thread Arnd Bergmann
On Tuesday 24 July 2007, Devesh Sharma wrote: Hello all, I am facing some difficulty to implement compat_ioctl entry point in my driver code, please help me out to sort out the things. The ioctl is READ WRITE type, It takes one header structure as argument the structure is as follows,

Re: [patch] nfs: fix locking in nfs/inode.c in nfs_free_open_context

2007-07-26 Thread Arnd Bergmann
On Wednesday 25 July 2007, Trond Myklebust wrote: On Wed, 2007-07-25 at 17:08 +0200, Christian Krafft wrote: Obviously the locking code in nfs_free_open_context is wrong. Checking the list for entries and removing the entry should be an atomic operation. Wrong. It is quite safe to

Re: [patch] nfs: fix locking in nfs/inode.c in nfs_free_open_context

2007-07-26 Thread Arnd Bergmann
On Thursday 26 July 2007, Trond Myklebust wrote: Wrong. It is quite safe to test the structure member ctx-list for emptiness outside the spinlock because we have an explicit guarantee that nobody else has a reference to this structure, plus the atomic_dec_and_test() in kref_put()

Re: [patch] nfs: fix locking in nfs/inode.c in nfs_free_open_context

2007-07-27 Thread Arnd Bergmann
] Acked-by: Arnd Bergmann [EMAIL PROTECTED] From the bit of research I did on the bug yesterday, it seems that the race has been in there for ages, but may have become easier to hit with the change to kref after 2.6.22. I don't really understand why we didn't hit it in RHEL5/2.6.18 with the same test

[patch 2/5] cell: support pinhole-reset on IBM cell blades

2007-08-22 Thread Arnd Bergmann
From: Arnd Bergmann [EMAIL PROTECTED] The Cell Broadband Engine has a method of injecting a system-reset-exception from an external source into the operating system, which should trigger the regular behaviour of entering xmon or kdump. Unfortunately, the exception handler cannot distinguish

[patch 4/5] axonram: do not delete gendisks queue in error path

2007-08-22 Thread Arnd Bergmann
From: Maxim Shchetynin [EMAIL PROTECTED] On exit do not delete gendisk's queue because this is already done by del_gendisk(). Doing it twice may cause memory damage. Signed-off-by: Maximilian [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- Index: linux-2.6/arch/powerpc

[patch 0/5] (hopefully) final 2.6.23 fixes for cell platform

2007-08-22 Thread Arnd Bergmann
Hi Paul, A few bugs came up on the cell platform when testing on the lastest prototype version of a future hardware. The first three patches are all meant to track changes required for the fixes that have gone into the firmware. Patch 4 is for a bug that showed up during testing, and the final

[patch 1/5] spu_manage: use newer physical-id attribute

2007-08-22 Thread Arnd Bergmann
by spu_manage into the spu struct as spe_id. cbe_thermal has been changed to use the spu-spe_id. There's no need for the thermal code has to check devicetree attributes for itself. Signed-off-by: Christian Krafft [EMAIL PROTECTED] Cc: Jeremy Kerr [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann

[patch 3/5] Axonram module modification for latest firmware API changes

2007-08-22 Thread Arnd Bergmann
, if it is not allowed to fetch the second interrupt number from device-tree, it interpretes this as an error case and exits. Signed-off-by: Maximilian [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- Index: linux-2.6/arch/powerpc/sysdev/axonram.c

[patch 5/5] update cell_defconfig for 2.6.23

2007-08-22 Thread Arnd Bergmann
From: Arnd Bergmann [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- Index: linux-2.6/arch/powerpc/configs/cell_defconfig === --- linux-2.6.orig/arch/powerpc/configs/cell_defconfig +++ linux-2.6/arch/powerpc

git tree, Re: [patch 0/5] (hopefully) final 2.6.23 fixes for cell platform

2007-08-22 Thread Arnd Bergmann
On Wednesday 22 August 2007, Arnd Bergmann wrote: Hi Paul, A few bugs came up on the cell platform when testing on the lastest prototype version of a future hardware. The first three patches are all meant to track changes required for the fixes that have gone into the firmware. Patch 4

Re: [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id

2007-08-23 Thread Arnd Bergmann
On Thursday 23 August 2007, [EMAIL PROTECTED] wrote: Please check unit-id if physical-id doesn't exist. Because Celleb uses unit-id to provide spe_id. Ok, I need to discuss this with Christian then, to make sure we get to a version that works everywhere. Paul, please ignore this patch for now.

Re: [kvm-devel] [RFC] 9p: add KVM/QEMU pci transport

2007-08-28 Thread Arnd Bergmann
On Tuesday 28 August 2007, Eric Van Hensbergen wrote: This adds a shared memory transport for a synthetic 9p device for paravirtualized file system support under KVM/QEMU. Nice driver. I'm hoping we can do a virtio driver using a similar concept. +#define PCI_VENDOR_ID_9P 0x5002

Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions

2007-08-30 Thread Arnd Bergmann
On Wednesday 29 August 2007, Joachim Fenkes wrote: Previously, ibmebus derived a device's bus_id from its location code. The location code is not guaranteed to be unique, so we might get bus_id collisions if two devices share the same location code. The OFDT full_name, however, is unique, so

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-14 Thread Arnd Bergmann
On Tuesday 14 August 2007, Paul E. McKenney wrote: #define order(x) asm volatile( : +m (x)) There was something very similar discussed earlier in this thread, with quite a bit of debate as to exactly what the m flag should look like.  I suggested something similar named ACCESS_ONCE in the

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-15 Thread Arnd Bergmann
On Wednesday 15 August 2007, Paul E. McKenney wrote: ACCESS_ONCE() is indeed intended to be used when actually loading or storing the variable. That said, I must admit that it is not clear to me why you would want to add an extra order() rather than ACCESS_ONCE()ing one or both of the

Re: MODULE_LICENSE usage

2007-08-07 Thread Arnd Bergmann
On Tuesday 07 August 2007, Nathan Williams wrote: My company has been given documentation and the library source under the terms of an NDA with the chipset manufacturer.  We are permitted to compile the library and distribute the resultant binary blob, but not release the source to the

Re: [PATCH] powerpc: Use linux/elfcore-compat.h

2007-08-07 Thread Arnd Bergmann
On Saturday 04 August 2007, Roland McGrath wrote: This makes powerpc64's compat code use the new linux/elfcore-compat.h, reducing some hand-copied duplication. There is hardly anything interesting remaining in arch/powerpc/kernel/binfmt_elf32.c after your patch. Do you think it's reasonable

Re: SLUB doesn't work with kdump kernel on Cell

2007-08-08 Thread Arnd Bergmann
On Wednesday 08 August 2007, Christoph Lameter wrote: I found a problem with SLUB when trying to boot a kdump kernel on a Cell QS20 Blade running Fedora 7, kernel 2.6.22.5. If I use SLAB for the kdump kernel, everything works ok. The fact is that SLUB doesn't find a page frame for

Re: SLUB doesn't work with kdump kernel on Cell

2007-08-08 Thread Arnd Bergmann
On Wednesday 08 August 2007, Lucio Correia wrote:   DMA             0 -    12288   Normal      12288 -    12288 early_node_map[2] active PFN ranges     0:        0 -     2560     1:    12287 -    12288 As Christoph found, this memory map is really strange. Other machines have something like

Re: [Patch 02/18] include/linux/logfs.h

2007-08-08 Thread Arnd Bergmann
On Wednesday 08 August 2007, Jörn Engel wrote: +++ linux-2.6.21logfs/include/linux/logfs.h 2007-08-08 02:57:37.0 +0200 @@ -0,0 +1,500 @@ +/* + * fs/logfs/logfs.h + * The comment does not match the file name. Better remove the file names entirely from introduction comments.

Re: [Patch 16/18] fs/Kconfig

2007-08-08 Thread Arnd Bergmann
On Wednesday 08 August 2007, Jörn Engel wrote: +config LOGFS +   bool Log Filesystem (EXPERIMENTAL) +   depends on MTD BLOCK EXPERIMENTAL The dependency on MTD _and_ BLOCK looks correct for your code, but not necessary. How about making it depends on (MTD || BLOCK)

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-09 Thread Arnd Bergmann
On Thursday 09 August 2007, Chris Snook wrote: This patchset makes the behavior of atomic_read uniform by removing the volatile keyword from all atomic_t and atomic64_t definitions that currently have it, and instead explicitly casts the variable as volatile in atomic_read().  This leaves

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-09 Thread Arnd Bergmann
On Thursday 09 August 2007, Chris Snook wrote: a) chicken and egg: asm-generic/atomic.h depends on definitions in asm/atomic.h Ok, I see. If you can find a way to reshuffle the code and make it simpler, I personally am all for it. I'm skeptical that you'll get much to show for the

Re: [Cbe-oss-dev] SLUB doesn't work with kdump kernel on Cell

2007-08-10 Thread Arnd Bergmann
On Friday 10 August 2007, Michael Ellerman wrote: It comes out of the device tree, just like a regular kernel. The device tree for the kdump kernel is built by kexec-tools, it parses /proc/device-tree and does a bunch of logic to avoid various reserved regions: the kernel, TCE tables, RTAS

Re: [2.6.24 PATCH 02/25] dm io:ctl use constant struct size

2007-10-12 Thread Arnd Bergmann
around a bug in the compat_ioctl layer. Why not just do the compat code the right way, like the patch below? Arnd --- dm: move compat_ioctl handling to dm-ioctl.c Device mapper ioctl numbers use a variable size field Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- diff --git

<    1   2   3   4   5   6   7   8   9   10   >