Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Arnd Bergmann
On Wednesday 28 November 2012, Eli Billauer wrote: Xillybus is a general-purpose framework for communication between programmable logic (FPGA) and a host. It provides a simple connection between hardware FIFOs in the FPGA and their respective device files on the host. The user space

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Arnd Bergmann
On Friday 30 November 2012, Eli Billauer wrote: The problem is if the page size smaller than 4kB. The buffers allocated by the driver must not cross a 4kB boundary, and it's assumed that anything returned by __get_free_pages() is 4 kB-aligned. Otherwise the FPGA will generate illegal PCIe

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Arnd Bergmann
On Saturday 01 December 2012, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: Yes, I know of at least one more device other than the ones listed above that wants this type of functionality as well, so defining it in a standard user/kernel api manner would be very good to do.

Re: [PATCH 1/5] asm-generic/mmu.h: Remove unused vmlist field from mm_context_t

2012-12-03 Thread Arnd Bergmann
Whole series: Acked-by: Arnd Bergmann a...@arndb.de Do you want to include the patches in a patch set of your own, or should I put them into the asm-generic tree? Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2012, Eli Billauer wrote: I'm currently writing some documentation which will cover the API and also help reading the code, I hope. It takes some time... Until it's done, let's look at a usage example: Suppose that the FPGA's application is to receive a high-speed

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2012, Philip Balister wrote: On 12/01/2012 12:48 PM, Arnd Bergmann wrote: On Saturday 01 December 2012, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: Yes, I know of at least one more device other than the ones listed above that wants this type

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2012, Eli Billauer wrote: On 12/04/2012 10:43 PM, Arnd Bergmann wrote: On Tuesday 04 December 2012, Eli Billauer wrote: It's also a bit confusing because it doesn't appear to be a bus in the Linux sense of being something that provides an abstract interface

Re: [PATCH 04/10] USB: EHCI: make ehci-orion a separate driver

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, manjunath.gou...@linaro.org wrote: @@ -155,7 +155,7 @@ static inline unsigned ehci_read_frame_index(struct ehci_hcd *ehci) * before driver shutdown. But it also seems to be caused by bugs in cardbus * bridge shutdown: shutting down the bridge before the

Re: [char-misc-next 08/11] mei: nfc: Initial nfc implementation

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: From: Samuel Ortiz sa...@linux.intel.com NFC ME client is exported through mei bus to be consumed by the NFC subsystem. NFC is represented by two mei clients: An info one and the actual NFC one. In order for correct connection we first

Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: From: Samuel Ortiz sa...@linux.intel.com mei bus will present some of the me clients as devices for other standard subsystems Implement the probe, remove, match and the device addtion routines. A mei-bus.txt document describing the

Re: [char-misc-next 02/11] mei: bus: Implement driver registration

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: +int mei_add_driver(struct mei_bus_driver *driver) By convention, I think this should be called mei_driver_register(), matching what we do on most other subsystem. Similarly for mei_driver_unregister(). Arnd -- To unsubscribe from this

Re: [char-misc-next 03/11] mei: bus: Initial implementation for I/O routines

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: + +struct mei_bus_ops { + int (*send)(struct mei_bus_client *client, u8 *buf, size_t length); + int (*recv)(struct mei_bus_client *client, u8 *buf, size_t length); +}; + Can you have more than one set of mei_bus_ops in a driver?

Re: [char-misc-next 05/11] mei: bus: Call bus routines from the core code

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: @@ -197,6 +197,9 @@ static int mei_probe(struct pci_dev *pdev, const struct pci_device_id *ent) mei_pdev = pdev; pci_set_drvdata(pdev, dev); + err = mei_bus_init(mei_pdev); + if (err) + goto

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: +inline void *mei_bus_get_clientdata(const struct mei_bus_client *client) +{ + return dev_get_drvdata(client-dev); +} +EXPORT_SYMBOL(mei_bus_get_clientdata); + Did you really mean to export an inline function? Can you make this a

Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: +} +EXPORT_SYMBOL(mei_add_device); + +void mei_remove_device(struct mei_bus_client *client) +{ + device_unregister(client-dev); +} +EXPORT_SYMBOL(mei_remove_device); One more point: did you intentionally pick EXPORT_SYMBOL over

Re: [PATCH 0/4] Improve CLKSRC_OF matching

2013-02-07 Thread Arnd Bergmann
within the init functions. This is based on arm-soc for-next branch and commit of: fix incorrect return value of of_find_matching_node_and_match() in my DT for-next branch. Acked-by: Arnd Bergmann a...@arndb.de Conceptually this is definitely the way to go, but I noticed that you create build

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Grant Likely wrote: On Thu, Feb 7, 2013 at 3:28 PM, Alexey Brodkin Starting with register (non-data) access. The bus bindings are such that on both BE and LE systems a native 16 bit read results in the bits being in the correct order. On powerpc, you want to do a

Re: [char-misc-next 05/11] mei: bus: Call bus routines from the core code

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Winkler, Tomas wrote: Second why to register anything if the MEI device is not present on the system. Mostly to match the expectations of readers of that code. Note that no memory is wasted if you do this, because it's a static data structure. You can actually

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Michal Simek wrote: Subject: asm-generic: io: Fix ioread16/32be and iowrite16/32be Ok, thanks. If you don't mind, I think this can just go with the other patches for xsysace that come out of this discussion. Arnd -- To unsubscribe from this list: send the

Re: [PATCH 0/4] Improve CLKSRC_OF matching

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Rob Herring wrote: How so? I don't see a warning as there is no type checking on the init function since of_device_id.data is just a void *. It would be good to have type checking here if you know a way, but I don't. Ah, that's right. So it silently builds find

Re: [char-misc-next 05/11 V2] mei: bus: Call bus routines from the core code

2013-02-08 Thread Arnd Bergmann
tomas.wink...@intel.com Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [char-misc-next 02/11 V2] mei: bus: Implement driver registration

2013-02-08 Thread Arnd Bergmann
On Friday 08 February 2013 14:28:15 Tomas Winkler wrote: From: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Tomas Winkler tomas.wink...@intel.com Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line

Re: [PATCH 4/4] serial/arc-uart: switch to devicetree based probing

2013-02-09 Thread Arnd Bergmann
On Saturday 09 February 2013, Vineet Gupta wrote: On Saturday 09 February 2013 04:31 AM, Grant Likely wrote: On Fri, 11 Jan 2013 11:50:23 +0530, Vineet Gupta vineet.gup...@synopsys.com wrote: +- clock-frequency : the input clock frequency for the UART +- baud :

Re: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early()

2013-02-09 Thread Arnd Bergmann
On Friday 08 February 2013, Hiroshi Doyu wrote: +#if defined(CONFIG_ARCH_TEGRA_3x_SOC) how about using: #if IS_BUILTIN(CONFIG_ARCH_TEGRA_3x_SOC) instead ? Why is IS_BUILTIN() prefered? Inside of a function, if(IS_ENABLED(CONFIG_FOO)) or the respective IS_BUILTIN is preferred

Re: [char-misc-next 01/11 V2] mei: bus: Initial MEI bus type implementation

2013-02-11 Thread Arnd Bergmann
On Sunday 10 February 2013, Samuel Ortiz wrote: /** + * mei_bus_client I don't really understand this structure, please explain it better. This is a structure that links the MEI bus client pointer passed to the driver with the actual ME client. It also allows the ME driver to

Re: [char-misc-next 03/11] mei: bus: Initial implementation for I/O routines

2013-02-11 Thread Arnd Bergmann
On Thursday 07 February 2013, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 10:34:44PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Tomas Winkler wrote: + +struct mei_bus_ops { + int (*send)(struct mei_bus_client *client, u8 *buf, size_t length); + int

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-11 Thread Arnd Bergmann
On Thursday 07 February 2013, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 10:38:44PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Tomas Winkler wrote: +inline void *mei_bus_get_clientdata(const struct

Re: [char-misc-next 03/11] mei: bus: Initial implementation for I/O routines

2013-02-11 Thread Arnd Bergmann
On Monday 11 February 2013, Samuel Ortiz wrote: On Mon, Feb 11, 2013 at 11:52:42AM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 10:34:44PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Tomas Winkler wrote

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-11 Thread Arnd Bergmann
On Monday 11 February 2013, Michal Simek wrote: 2013/2/8 Arnd Bergmann a...@arndb.de: On Thursday 07 February 2013, Michal Simek wrote: Subject: asm-generic: io: Fix ioread16/32be and iowrite16/32be Ok, thanks. If you don't mind, I think this can just go with the other patches

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-11 Thread Arnd Bergmann
On Monday 11 February 2013, Michal Simek wrote: I have just found that it won't be so easy as I thought because I have found that microblaze wrong implementation was done because of others device drivers. It means that I have to fix all device drivers to support big and little endian

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-11 Thread Arnd Bergmann
On Monday 11 February 2013, Michal Simek wrote: Unfortunately no. Another is spi/i2c (sysace as we discuss in this thread), probably icap network drivers are ok because they are not shared. Timer when it is moved to clocksource(not important right now) xilinx gpio is using __raw IO functions

Re: [char-misc-next 03/11] mei: bus: Initial implementation for I/O routines

2013-02-11 Thread Arnd Bergmann
On Monday 11 February 2013 16:48:12 Samuel Ortiz wrote: If so, how do you know which transport to use? Through the mei_bus_client ops. Device drivers get a mei_bus_client pointer from their probe routine and the ops pointers there (If any) are set by whoever creates the device. In the NFC

Re: Oops when mounting btrfs partition

2013-02-11 Thread Arnd Bergmann
On Friday 08 February 2013, David Sterba wrote: On Mon, Feb 04, 2013 at 09:55:50PM +, Arnd Bergmann wrote: On Saturday 02 February 2013, Chris Mason wrote: I've done a full backup of all data now, without any further Ooops messages, but I did get these: [66155.429029] btrfs

Re: [PATCH v2 1/3] mfd: syscon: Removed support for unloading

2013-02-11 Thread Arnd Bergmann
On Monday 11 February 2013, Alexander Shiyan wrote: The driver can be used in various subsystems and therefore should not be unloaded when it is defined in the kernel configuration, so remove support for unloading it. Signed-off-by: Alexander Shiyan shc_w...@mail.ru Can you describe a

Re: [PATCH 2/2] tty: serial: uartlite: Support uartlite on big and little endian systems

2013-02-11 Thread Arnd Bergmann
...@xilinx.com Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Michal Simek wrote: In particular, ARM can run both big- and little-endian even though big-endian is rarely used, so you need to know the endianess for the device you are talking to rather than assume that it knows what the CPU does at the time. For high

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Benjamin Herrenschmidt wrote: It depends how the ARM core operates vs. IO when switched between BE and LE, does it keep the same lines doing byte 0 or does it keep the MSB/LSB in the same place (and thus changes which lanes contain byte 0) ? IIRC it changed between

Re: Re[2]: [PATCH v2 1/3] mfd: syscon: Removed support for unloading

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Alexander Shiyan wrote: On Monday 11 February 2013, Alexander Shiyan wrote: The driver can be used in various subsystems and therefore should not be unloaded when it is defined in the kernel configuration, so remove support for unloading it.

Re: linux-next: manual merge of the arm-soc tree with the metag tree

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Stephen Rothwell wrote: Today's linux-next merge of the arm-soc tree got conflicts in drivers/clocksource/Makefile and drivers/clocksource/Kconfig between commit 3fedb0674fbc (metag: Time keeping) from the metag tree and commits 8a4da6e36c58 (arm: arch_timer: move

Re: [v2 3/3] ARM: tegra: Unify Device tree board files

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Hiroshi Doyu wrote: static void __init paz00_init(void) @@ -129,6 +128,9 @@ static void __init tegra_dt_init_late(void) tegra_init_late(); + if (IS_ENABLED(CONFIG_PCI) IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC)) + return; I don't

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Michal Simek wrote: ok but still there should be well defined how to do it. Let's say generic Kconfig option. You cannot solve it in a generic way, since every device has different needs. In a single SoC, you may have one device that only ever exists with

Re: [PATCH 6/9] gpiolib: use descriptors internally

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Paul Mundt wrote: While I do get the point... I chatted with Grant about it and I want to talk to some toolchain people about this to see if pointers containing potential error codes can somehow be flagged by the compiler so we can enforce error checking on

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Michal Simek wrote: But on Microblaze LE is necessary to use different datain/out_le16 functions as below which are also not compatible with Microblaze and PPC BE. diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c index bbad046..8dd192c 100644 ---

Re: [v2 3/3] ARM: tegra: Unify Device tree board files

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Stephen Warren wrote: I don't think that's going to help any link issues, so I'd drop it and keep this function simple. As explained in the above, a complier will drop unnecessary functions automatically with this IS_ENABLED(), which could save many ifdefs.

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Thomas Petazzoni wrote: The pcim_*() functions are used by the libata-sff subsystem, and this subsystem is used for many SATA drivers on ARM platforms that do not necessarily have I/O ports. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc:

Re: [v2 3/3] ARM: tegra: Unify Device tree board files

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Stephen Warren wrote: I believe U-Boot enabled -ffunction-sections -fdata-sections or similar (recently?) to get this kind of behaviour. I wonder why the kernel didn't need that. Perhaps -O2 is more aggressive (within a file at least) than I thought.

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Thomas Petazzoni wrote: Any driver that requires a linear mapping of I/O ports to __iomem pointers must depend CONFIG_HAS_IOPORT with the current definition of that symbol (as mentioned before, we should really rename that to CONFIG_HAS_IOPORT_MAP). Having

Re: [char-misc-next 01/12 v3] mei: Rename mei_device to mei_host

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, gre...@linuxfoundation.org wrote: Please let's find something that makes both hw and Linux happy I still believe it makes sense to use mei_device for what we add to the MEI bus. I'd be fine with mei_bus_device as well, but that would somehow look a bit

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-04 Thread Arnd Bergmann
On Saturday 02 February 2013 04:07:59 Sergei Shtylyov wrote: On 02-02-2013 1:30, Russell King - ARM Linux wrote: because it doesn't make sense to support multiple DMA APIs. We can check from MUSB's registers if it was configured with Inventra DMA support and based on that we can register

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-04 Thread Arnd Bergmann
On Monday 04 February 2013, Michal Simek wrote: and select the CONFIG_FOO_BIG_ENDIAN and CONFIG_FOO_LITTLE_ENDIAN symbols in Kconfig based on the system you are building for. Using CONFIG_FOO_BIG/LITTLE is not good because it is just another Kconfig option. You can easily detect it at

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-04 Thread Arnd Bergmann
On Monday 04 February 2013, Linus Walleij wrote: So I think the above concerns are moot. The callback we can set on cookies is entirely optional, and it's even implemented by each DMA engine, and some may not even support it but require polling, and then it won't even be implemented by the

Re: Oops when mounting btrfs partition

2013-02-04 Thread Arnd Bergmann
On Saturday 02 February 2013, Chris Mason wrote: Feb 1 22:57:37 localhost kernel: [ 8561.599482] Kernel BUG at a01fdcf7 [verbose debug info unavailable] Jan 14 19:18:42 localhost kernel: [1060055.746373] btrfs csum failed ino 15619835 off 454656 csum 2755731641 private

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-05 Thread Arnd Bergmann
On Tuesday 05 February 2013 18:03:31 Alexey Brodkin wrote: The Xilinx System ACE Compact Flash chip is a true little-endian device and the PLB is a big-endian bus. Therefore the XPS System ACE Interface Controller will do a bit-swap in each byte when connecting the PLB data bus to the

Re: [PATCH 05/15] ASoC: fsl: fiq and dma cannot both be modules

2013-02-05 Thread Arnd Bergmann
On Tuesday 22 January 2013, Mark Brown wrote: Show Details On Tue, Jan 22, 2013 at 11:50:30AM +0800, Shawn Guo wrote: On Mon, Jan 21, 2013 at 05:15:58PM +, Arnd Bergmann wrote: Without this patch, we cannot build the ARM 'allmodconfig', or we get this error: sound/soc/fsl

Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers

2013-02-05 Thread Arnd Bergmann
On Monday 21 January 2013, Greg Kroah-Hartman wrote: On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build without the mach/hardware.h file

Re: [PATCH] OMAPDSS: enable omapdss for ARCH_MULTIPLATFORM

2013-02-05 Thread Arnd Bergmann
On Tuesday 22 January 2013, Arnd Bergmann wrote: On Tuesday 22 January 2013, Rob Clark wrote: At least core omapdss does not have any build dependencies on ARCH_OMAP2PLUS, and adding this dependency in the Kconfig breaks omapdrm for ARCH_MULTIPLATFORM builds. Signed-off-by: Rob Clark

[PATCH] ASoC: fsl: fix allyesconfig build for imx-pcm

2013-02-05 Thread Arnd Bergmann
-pcm-fiq.o:/sound/soc/fsl/imx-pcm.c:52: first defined here I originally suggested disallowing the selection of both the DMA and FIQ code in the same kernel. That is not very nice, but it resolves the build error for both built-in and modular code. Signed-off-by: Arnd Bergmann a...@arndb.de

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Arnd Bergmann
On Tuesday 05 February 2013, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [130204 07:46]: Current DMA abstraction is quite poor, for example there's no way to compile support for multiple DMA engines. Code also makes certain, IMO unnecessary, assumptions about the underlying DMA

Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers

2013-02-05 Thread Arnd Bergmann
On Tuesday 05 February 2013, Felipe Balbi wrote: [linus/master] Merge branch 'fix-max-write' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm It's building find for me: $ crossmake drivers/usb/gadget/fsl_udc_core.o \ drivers/usb/gadget/fsl_mxc_udc.o /dev/null

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-05 Thread Arnd Bergmann
On Tuesday 05 February 2013, Michal Simek wrote: I want to be sure about this. I have parsed this again with closer look and seems to me that ioread32 is equal to readl and iowrite32 to writel. Arnd: Am I right? Correct. On all the architectures you care about (most importantly, not x86),

Re: [PATCH] ASoC: fsl: fix allyesconfig build for imx-pcm

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013, Shawn Guo wrote: On Tue, Feb 05, 2013 at 04:42:25PM +, Arnd Bergmann wrote: Patch 25b8d314 ASoC: fsl: fix multiple definition of init_module changed the Makefile for imx-pcm.ko to build two modules that both contain the imx-pcm.c file, which nicely solves

Re: [PATCH 0/3] omap_hsmmc DT DMA Client support

2013-02-06 Thread Arnd Bergmann
/linux/tree/omap-hsmmc-dt-dmaengine-v1 Nice series, Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013, Geert Uytterhoeven wrote: On Wed, Feb 6, 2013 at 12:03 AM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 05 February 2013, Michal Simek wrote: I want to be sure about this. I have parsed this again with closer look and seems to me that ioread32 is equal

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013, Grant Likely wrote: The driver already handles this. It has three sets of accessors; 8-bit, 16-bit LE and 16-bit BE and when doing 16-bit it figures out on its own which set to use at runtime. There is nothing controversial here. The only problem is that the

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013, Grant Likely wrote: The only problem that I see is that the ARM and Microblaze ioread16be/iowrite16be helpers are missing barriers which smells like a bug and should be fixed. It looks correct to me on ARM, we use the same barriers in ioread and iowrite that we

Re: [PATCH] OMAPDSS: enable omapdss for ARCH_MULTIPLATFORM

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013 16:15:57 Tomi Valkeinen wrote: That would normally be me, but I've been on a long leave, and just came back. It'll take me some time to get back on track. I don't think it makes sense to add ARCH_MULTIPLATFORM only for omapdss, like this patch does. I think we

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013 17:21:37 Michal Simek wrote: I have looked at the patches from more practical side and I have tested it on microblaze big endian in 16bit mode and I have found that sysace driver stop to work. After that I have looked at ioread/iowrite microblaze implementation

Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013 17:38:20 Linus Walleij wrote: On Wed, Jan 9, 2013 at 9:43 PM, Thierry Reding thierry.red...@avionic-design.de wrote: When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by:

Re: [PATCH 12/15] sound: add missing HAS_IOPORT and GENERIC_HARDIRQS dependencies

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013 18:05:14 Takashi Iwai wrote: At Wed, 6 Feb 2013 17:24:00 +0100, Heiko Carstens wrote: Fix these two compile errors on s390 which does not have HAS_IOPORT nor GENERIC_HARDIRQS: sound/pci/lx6464es/lx6464es.c: In function ‘snd_lx6464es_free’:

Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013 18:07:53 Linus Walleij wrote: However it leaves the question of how much __init, __initdata and __initconst we have littering around. Oh, well, we'll see I guess. Actually, kbuild is pretty good at warning around the bugs there. Arnd -- To unsubscribe

Re: [PATCH 12/15] sound: add missing HAS_IOPORT and GENERIC_HARDIRQS dependencies

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013, Heiko Carstens wrote: On Wed, Feb 06, 2013 at 06:26:02PM +0100, Takashi Iwai wrote: At Thu, 07 Feb 2013 02:13:19 +0100, Arnd Bergmann wrote: No, it is intentional that the CONFIG_HAS_IOPORT symbol refers to the fact that you can use the ioport_map function

Re: [PATCH 13/14] ARM: ux500: enable AB8500 GPIO for HREF

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Stephen Warren wrote: On 02/05/2013 12:48 PM, Linus Walleij wrote: From: Lee Jones lee.jo...@linaro.org The AB8500 GPIO driver has been un-BROKEN and rewritten as a pinctrl driver. Now that it's back in use, let's ensure that it's available when booting

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Geert Uytterhoeven wrote: On Thu, Feb 7, 2013 at 9:01 AM, Michal Simek mon...@monstr.eu wrote: ok. Can you please confirm with me that the same problem is also for iowrite32be ioread16be and ioread32be? This description seems to me correct for BE and LE.

Re: [PATCH] OMAPDSS: enable omapdss for ARCH_MULTIPLATFORM

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomi Valkeinen wrote: On 2013-02-06 16:29, Arnd Bergmann wrote: On Wednesday 06 February 2013 16:15:57 Tomi Valkeinen wrote: I have patches to add the ARCH_MULTIPLATFORM for omapdss, and to fix the omap_vout and omapdrm Kconfig files. Each of them changes

Re: [PATCH] OMAPDSS: enable omapdss for ARCH_MULTIPLATFORM

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomi Valkeinen wrote: I would suggest only the first patch, since Linus quite specifically asked only for serious bug fixes. I think an allyesconfig build breakage is serious enough, but doing multiple patches for one bug should not be necessary and is much

Re: [PATCH 12/15] sound: add missing HAS_IOPORT and GENERIC_HARDIRQS dependencies

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013 14:32:06 Heiko Carstens wrote: That sounds reasonable. And a quick grep seems to indicate that s390 is the last architecture with !GENERIC_HARDIRQS. However having two completely different IRQ subsystems within one architecture will bring up some interesting

Re: [PATCH] asm-generic: io: Fix ioread16/32be and iowrite16/32be

2013-02-07 Thread Arnd Bergmann
Simek michal.si...@xilinx.com CC: Benjamin Herrenschmidt b...@kernel.crashing.org CC: Arnd Bergmann a...@arndb.de CC: Geert Uytterhoeven ge...@linux-m68k.org CC: Will Deacon will.dea...@arm.com CC: linux-a...@vger.kernel.org Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list

Re: [PATCH] dw_dmac: apply default dma_mask if needed

2013-01-29 Thread Arnd Bergmann
On Tuesday 29 January 2013, Viresh Kumar wrote: Adding Arnd in cc. On 29 January 2013 20:36, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: In some cases we got the device without dma_mask configured. We have to apply the default value to avoid crashes during memory mapping.

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-01-29 Thread Arnd Bergmann
On Tuesday 29 January 2013, Alexey Brodkin wrote: in(out)_8/in(out)_be16/in(out)_le16 are very powerpc/microblaze specific. To enable use of Xilinx System ACE driver build for other architectures (for example it's possible to use it on Xilinx ml-509 board with ARC700 in FPGA) we need to use

Re: [PATCH 1/5] ARM: sunxi: Increase the number of GPIOs available

2013-01-29 Thread Arnd Bergmann
+ default 288 if ARCH_VT8500 || ARCH_SUNXI Can I have an ACK from the ARM SoC maintainers on this? Acked-by: Arnd Bergmann a...@arndb.de for the change. Maybe you could also do a second patch on top that sorts the lines by descending numbers and adds a comment? I think for any multiplatform

Re: [PATCH v6 09/10] spi: omap2-mcspi: add generic DMA request support to the DT binding

2013-01-30 Thread Arnd Bergmann
On Wednesday 30 January 2013, Matt Porter wrote: +Optional properties: +- dmas: List of DMA controller phandle and DMA request ordered + pairs. One tx and one rx pair is required for each chip + select. The binding looks ok, but the wording is slightly incorrect here: strictly

Re: [PATCH v6 07/10] dmaengine: add dma_request_slave_channel_compat()

2013-01-30 Thread Arnd Bergmann
...@atomide.com Acked-by: Arnd Bergmann a...@arndb.de @@ -1001,6 +1001,22 @@ void dma_run_dependencies(struct dma_async_tx_descriptor *tx); struct dma_chan *dma_find_channel(enum dma_transaction_type tx_type); struct dma_chan *net_dma_find_channel(void); #define dma_request_channel(mask, x, y

Re: [PATCH v6 03/10] ARM: edma: add AM33XX support to the private EDMA API

2013-01-30 Thread Arnd Bergmann
On Wednesday 30 January 2013, Matt Porter wrote: + dma_cap_set(DMA_SLAVE, edma_filter_info.dma_cap); + of_dma_controller_register(dev-of_node, + of_dma_simple_xlate, +

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-01-30 Thread Arnd Bergmann
On Wednesday 30 January 2013 13:31:58 Michal Simek wrote: Also from my understanding of arm we should use readl/b/w functions because they have memory barriers which should be probably performed. And I haven't found any IO function which will behave on arm as LE and on PPC as BE. There are

Re: [PATCH v6 03/10] ARM: edma: add AM33XX support to the private EDMA API

2013-01-31 Thread Arnd Bergmann
On Thursday 31 January 2013, Matt Porter wrote: On Wed, Jan 30, 2013 at 09:32:58AM +, Arnd Bergmann wrote: On Wednesday 30 January 2013, Matt Porter wrote: + dma_cap_set(DMA_SLAVE, edma_filter_info.dma_cap); + of_dma_controller_register(dev-of_node

Oops when mounting btrfs partition

2013-02-02 Thread Arnd Bergmann
As mentioned on Google+, I have a partition that I can no longer mount normally, containing a lot of my personal data and all backups from my laptop. I found now that I am still able to mount it using the 'nospace_cache' option, but it takes a couple of minutes and I get INFO: task

Re: Oops when mounting btrfs partition

2013-02-02 Thread Arnd Bergmann
On Saturday 02 February 2013 10:20:35 Chris Mason wrote: Hi Arnd, First things first, nospace_cache is a safe thing to use. It is slow because it's finding free extents, but it's just a cache and always safe to discard. With your other errors, I'd just mount it readonly and then you won't

Re: [PATCH] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECK

2013-02-27 Thread Arnd Bergmann
this should instead be +lib-$(DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o No point building that file if we are not using it. Other than that, Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECK

2013-02-27 Thread Arnd Bergmann
On Wednesday 27 February 2013, Stephen Boyd wrote: On 02/27/13 12:32, Arnd Bergmann wrote: On Wednesday 27 February 2013, Stephen Boyd wrote: diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 28be08c..ae80518 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1292,6

Re: crypto: omap-sham, omap-aes and dma_request_slave_channel_compat()

2013-02-27 Thread Arnd Bergmann
however. This version incorporates feedback from Viresh Kumar, Andy Shevchenko and Russell King. Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Vinod Koul vinod.k...@linux.intel.com Cc

Re: linux-next: build warning after merge of the char-misc tree

2013-03-01 Thread Arnd Bergmann
-uninitialized gcc-option is available gcc-4-7+, so your patch is incomplete. O don't understand. The patch avoids the warnings when building with gcc-4.7 or higher with -Os. Arnd From d313219a2f2e0753b8e96105b7a944e1c22566ae Mon Sep 17 00:00:00 2001 From: Arnd Bergmann a...@arndb.de Date

Re: [patch] applicom: use correct array offset

2013-03-01 Thread Arnd Bergmann
dan.carpen...@oracle.com Acked-by: Arnd Bergmann a...@arndb.de Wow, that is a crappy driver ;-) Dave Woodhouse was apparently the last person who understood it and had something to do with it, and that was back in the 90s. It looks like the vendor actually has its own (much worse) driver

[PATCH 01/19] ARM: shmobile: fix defconfig warning on CONFIG_USB

2013-01-25 Thread Arnd Bergmann
A recent update to the marzen_defconfig introduced a duplicate CONFIG_USB=y line. This removes one of the two. arch/arm/configs/marzen_defconfig:86:warning: override: reassigning to symbol USB Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Simon Horman ho...@verge.net.au Cc: linux

[PATCH 08/19] lockdep: avoid warning about unused variables

2013-01-25 Thread Arnd Bergmann
cerfcube_defconfig results in: fs/nfsd/nfs4state.c: In function 'free_client': fs/nfsd/nfs4state.c:1047:19: error: unused variable 'nn' [-Wunused-variable] Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Peter Zijlstra pet...@infradead.org Cc: Ingo Molnar mi...@redhat.com Cc: Stanislav Kinsbursky

[PATCH 16/19] mac80211: avoid a build warning

2013-01-25 Thread Arnd Bergmann
at91sam9g45_defconfig with gcc-4.6 results in: net/mac80211/tx.c: In function 'ieee80211_subif_start_xmit': net/mac80211/tx.c:1797:22: warning: 'chanctx_conf' may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Johannes Berg johan...@sipsolutions.net

[PATCH 14/19] spi/atmel: remove incorrect __exit_p()

2013-01-25 Thread Arnd Bergmann
[-Wunused-function] Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: spi-devel-gene...@lists.sourceforge.net --- drivers/spi/spi-atmel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi

[PATCH 17/19] input/joystick: use get_cycles on ARM

2013-01-25 Thread Arnd Bergmann
, but Ben Dooks enabled it in the s3c2410_defconfig along with a bunch of other drivers, even though that platform has neither ISA nor PCI support. It still seems to be the right thing to fix this quirk. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc

[PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Arnd Bergmann
in: drivers/mfd/twl4030-power.c: In function 'load_twl4030_script': drivers/mfd/twl4030-power.c:414:5: error: 'err' may be used uninitialized in this function Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Samuel Ortiz sa...@linux.intel.com Cc: Peter Ujfalusi peter.ujfal...@ti.com Cc: Kevin Hilman khil

[PATCH 13/19] pinctrl: nomadik: nmk_prcm_gpiocr_get_mode may be unused

2013-01-25 Thread Arnd Bergmann
-nomadik.c:676:12: warning: 'nmk_prcm_gpiocr_get_mode' defined but not used [-Wunused-function] Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Jean-Nicolas Graux jean-nicolas.gr...@stericsson.com Cc: Linus Walleij linus.wall...@linaro.org Cc: Srinidhi Kasagar srinidhi.kasa...@stericsson.com

[PATCH 11/19] regmap: avoid undefined return from regmap_read_debugfs

2013-01-25 Thread Arnd Bergmann
results in: drivers/base/regmap/regmap-debugfs.c: In function 'regmap_read_debugfs': drivers/base/regmap/regmap-debugfs.c:147:9: : warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Mark Brown broo

<    4   5   6   7   8   9   10   11   12   13   >