[PATCH] proc: #68991 Fix GPF in /proc/$PID/map_files

2014-03-07 Thread Artem Fetishev
the path is not initialized but the return value is still 0. This results in 'general protection fault' inside d_path(). Steps to reproduce: CONFIG_CHECKPOINT_RESTORE=y fd = open(...); while (1) { mmap(fd, ...); munmap(fd, ...); } ls -la /proc/$PID/map_files Signed-off-by: Artem

Bug 71331 - mlock yields processor to lower priority process

2014-03-21 Thread Artem Fetishev
Hi all, I am looking at a use-case when a real-time task (B) of higher priority is sometimes preempted by another real-time task (A) of lower priority. Well, B is not really preempted. It calls mlockall() which forces task B to yield the CPU. Under certain conditions, mlockall() calls

[PATCH] drivers: staging: ft1000: Improve coding style

2014-05-09 Thread Artem Fetishev
) with _IO. - Actually these macros are not used anywhere and might be removed. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 40 +++ drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 138 -- drivers/staging

[PATCH v2 4/5] drivers: staging: ft1000: Remove typedefs

2014-05-10 Thread Artem Fetishev
Remove typedefs according to the Chapter 5: Typedefs from Documentation/CodingStyle. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 10 +- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 18 +- 2 files

[PATCH v2 1/5] drivers: staging: ft1000: Fix indentation

2014-05-10 Thread Artem Fetishev
Indentation fixes in header files. Actually only in ft1000-usb/ft1000_ioctl.h. Other headers look good. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 92 +++--- 1 file changed, 46 insertions(+), 46 deletions(-) diff

[PATCH v2 0/5] drivers: staging: ft1000: Improve coding style

2014-05-10 Thread Artem Fetishev
Hey Joe, I've made the changes you requested. Each fix is now made in a separate patch. This patch set fixes the ft1000 header files only. The inclusion of one .c file (ft1000_debug.c) is caused by typedef removal. Patch set includes: - Indentation fixes; - Fixes of IOCTL_FT1000_* marcos;

[PATCH v2 3/5] drivers: staging: ft1000: Use pr_info instead of printk

2014-05-10 Thread Artem Fetishev
Improve coding style by fixing this checkstyle warning: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_usb.h |2

[PATCH v2 5/5] drivers: staging: ft1000: Fix lines over 80 characters

2014-05-10 Thread Artem Fetishev
...plus some function arg indentation which I haven't noticed at first. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/ft1000/ft1000-pcmcia/ft1000.h| 15 +--- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 40 -- drivers/staging/ft1000

[PATCH v2 2/5] drivers: staging: ft1000: Fix IOCTL_FT1000_* marcos

2014-05-10 Thread Artem Fetishev
Fixes include: - Add closing brackets; - Remove sizeof (_IOR and _IOW macro can accept types); - Replace _IOW which size of 0 (the last arg) with _IO. - Actually these macros are not used anywhere and might be removed. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging

[PATCH v3 5/5] drivers: staging: ft1000: Fix lines over 80 characters

2014-05-11 Thread Artem Fetishev
..plus some function arg indentation which I haven't noticed at first. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/ft1000/ft1000-pcmcia/ft1000.h| 15 +--- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 40 -- drivers/staging/ft1000

[PATCH v3 3/5] drivers: staging: ft1000: Use pr_info instead of printk

2014-05-11 Thread Artem Fetishev
Improve coding style by fixing this checkstyle warning: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_usb.h |2

[PATCH v3 1/5] drivers: staging: ft1000: Fix indentation

2014-05-11 Thread Artem Fetishev
Fixes indentation in header files. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 92 +++--- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h b/drivers

[PATCH v3 4/5] drivers: staging: ft1000: Remove typedefs

2014-05-11 Thread Artem Fetishev
Remove typedefs according to the Chapter 5: Typedefs from Documentation/CodingStyle. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 10 - drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 26 +++--- 2 files

[PATCH v3 0/5] drivers: staging: ft1000: Improve coding style

2014-05-11 Thread Artem Fetishev
Hey Joe, I've made the changes you requested. Each fix is now made in a separate patch. This patch set fixes the ft1000 header files only. The inclusion of one .c file (ft1000_debug.c) is caused by typedef removal. Patch set includes: - Indentation fixes; - Fixes of IOCTL_FT1000_* marcos;

[PATCH v3 2/5] drivers: staging: ft1000: Fix IOCTL_FT1000_* marcos

2014-05-11 Thread Artem Fetishev
Fixes include: - Add closing brackets; - Remove sizeof (_IOR and _IOW macro can accept types); - Replace _IOW which size of 0 (the last arg) with _IO. - Actually these macros are not used anywhere and might be removed. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging

[PATCH] drivers: staging: line6: Add blank lines after declarations

2014-05-13 Thread Artem Fetishev
Use the more common kernel coding style. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/line6/capture.c |4 drivers/staging/line6/midi.c |2 ++ drivers/staging/line6/playback.c |5 + drivers/staging/line6/pod.c |5 + drivers/staging

[PATCH v2] drivers: staging: line6: Add blank lines after declarations

2014-05-13 Thread Artem Fetishev
Use the more common kernel coding style. Version #2 of this patch removes unnecesary blank line added in version #1. Signed-off-by: Artem Fetishev wwctr...@gmail.com --- drivers/staging/line6/capture.c |3 +++ drivers/staging/line6/midi.c |2 ++ drivers/staging/line6/playback.c

[PATCH] x86: Fix boot on uniprocessor systems

2014-03-24 Thread Artem Fetishev
be retreived for uniprocessor systems too. Enabling them also fixes rapl_pmu code. Signed-off-by: Artem Fetishev artem_fetis...@epam.com --- diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h index d35f24e..1306d11 100644 --- a/arch/x86/include/asm/topology.h +++ b/arch/x86

RE: [x86] BUG: unable to handle kernel paging request at ffff880012770000

2014-07-31 Thread Artem Fetishev
Hi Fengguang, Reproduced with your config and script. Working on locating the cause... Thanks, -Artem -Original Message- From: Fengguang Wu [mailto:fengguang...@intel.com] Sent: Wednesday, July 30, 2014 7:08 AM To: Artem Fetishev Cc: Jet Chen; Su Tao; Yuanhan Liu; LKP; linux-kernel

RE: [x86] BUG: unable to handle kernel paging request at ffff880012770000

2014-08-04 Thread Artem Fetishev
the bisect is correct. -Original Message- From: Artem Fetishev Sent: Thursday, July 31, 2014 9:42 AM To: 'Fengguang Wu' Cc: Jet Chen; Su Tao; Yuanhan Liu; LKP; linux-kernel@vger.kernel.org Subject: RE: [x86] BUG: unable to handle kernel paging request at 88001277 Hi Fengguang

[PATCH] proc: #68991 Fix GPF in /proc/$PID/map_files

2014-03-07 Thread Artem Fetishev
the path is not initialized but the return value is still 0. This results in 'general protection fault' inside d_path(). Steps to reproduce: CONFIG_CHECKPOINT_RESTORE=y fd = open(...); while (1) { mmap(fd, ...); munmap(fd, ...); } ls -la /proc/$PID/map_files Signed-off-by: Artem

Bug 71331 - mlock yields processor to lower priority process

2014-03-21 Thread Artem Fetishev
Hi all, I am looking at a use-case when a real-time task (B) of higher priority is sometimes preempted by another real-time task (A) of lower priority. Well, B is not really preempted. It calls mlockall() which forces task B to yield the CPU. Under certain conditions, mlockall() calls

[PATCH] x86: Fix boot on uniprocessor systems

2014-03-24 Thread Artem Fetishev
be retreived for uniprocessor systems too. Enabling them also fixes rapl_pmu code. Signed-off-by: Artem Fetishev --- diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h index d35f24e..1306d11 100644 --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h

[PATCH] drivers: staging: ft1000: Improve coding style

2014-05-09 Thread Artem Fetishev
) with _IO. - Actually these macros are not used anywhere and might be removed. Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 40 +++ drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 138 -- drivers/staging/ft1000/ft1000-usb

[PATCH v2 4/5] drivers: staging: ft1000: Remove typedefs

2014-05-10 Thread Artem Fetishev
Remove typedefs according to the "Chapter 5: Typedefs" from Documentation/CodingStyle. Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 10 +- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 18 +- 2 files changed, 14

[PATCH v2 1/5] drivers: staging: ft1000: Fix indentation

2014-05-10 Thread Artem Fetishev
Indentation fixes in header files. Actually only in ft1000-usb/ft1000_ioctl.h. Other headers look good. Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 92 +++--- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers

[PATCH v2 0/5] drivers: staging: ft1000: Improve coding style

2014-05-10 Thread Artem Fetishev
Hey Joe, I've made the changes you requested. Each fix is now made in a separate patch. This patch set fixes the ft1000 header files only. The inclusion of one .c file (ft1000_debug.c) is caused by typedef removal. Patch set includes: - Indentation fixes; - Fixes of IOCTL_FT1000_* marcos;

[PATCH v2 3/5] drivers: staging: ft1000: Use pr_info instead of printk

2014-05-10 Thread Artem Fetishev
Improve coding style by fixing this checkstyle warning: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-usb/ft1000_usb.h |2 +- 1 file changed

[PATCH v2 5/5] drivers: staging: ft1000: Fix lines over 80 characters

2014-05-10 Thread Artem Fetishev
...plus some function arg indentation which I haven't noticed at first. Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-pcmcia/ft1000.h| 15 +--- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 40 -- drivers/staging/ft1000/ft1000-usb

[PATCH v2 2/5] drivers: staging: ft1000: Fix IOCTL_FT1000_* marcos

2014-05-10 Thread Artem Fetishev
Fixes include: - Add closing brackets; - Remove sizeof (_IOR and _IOW macro can accept types); - Replace _IOW which size of 0 (the last arg) with _IO. - Actually these macros are not used anywhere and might be removed. Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-usb

[PATCH v3 5/5] drivers: staging: ft1000: Fix lines over 80 characters

2014-05-11 Thread Artem Fetishev
..plus some function arg indentation which I haven't noticed at first. Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-pcmcia/ft1000.h| 15 +--- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 40 -- drivers/staging/ft1000/ft1000-usb

[PATCH v3 3/5] drivers: staging: ft1000: Use pr_info instead of printk

2014-05-11 Thread Artem Fetishev
Improve coding style by fixing this checkstyle warning: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-usb/ft1000_usb.h |2 +- 1 file changed

[PATCH v3 1/5] drivers: staging: ft1000: Fix indentation

2014-05-11 Thread Artem Fetishev
Fixes indentation in header files. Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 92 +++--- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h b/drivers/staging/ft1000/ft1000

[PATCH v3 4/5] drivers: staging: ft1000: Remove typedefs

2014-05-11 Thread Artem Fetishev
Remove typedefs according to the "Chapter 5: Typedefs" from Documentation/CodingStyle. Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 10 - drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h | 26 +++--- 2 files c

[PATCH v3 0/5] drivers: staging: ft1000: Improve coding style

2014-05-11 Thread Artem Fetishev
Hey Joe, I've made the changes you requested. Each fix is now made in a separate patch. This patch set fixes the ft1000 header files only. The inclusion of one .c file (ft1000_debug.c) is caused by typedef removal. Patch set includes: - Indentation fixes; - Fixes of IOCTL_FT1000_* marcos;

[PATCH v3 2/5] drivers: staging: ft1000: Fix IOCTL_FT1000_* marcos

2014-05-11 Thread Artem Fetishev
Fixes include: - Add closing brackets; - Remove sizeof (_IOR and _IOW macro can accept types); - Replace _IOW which size of 0 (the last arg) with _IO. - Actually these macros are not used anywhere and might be removed. Signed-off-by: Artem Fetishev --- drivers/staging/ft1000/ft1000-usb

[PATCH] drivers: staging: line6: Add blank lines after declarations

2014-05-13 Thread Artem Fetishev
Use the more common kernel coding style. Signed-off-by: Artem Fetishev --- drivers/staging/line6/capture.c |4 drivers/staging/line6/midi.c |2 ++ drivers/staging/line6/playback.c |5 + drivers/staging/line6/pod.c |5 + drivers/staging/line6/toneport.c

[PATCH v2] drivers: staging: line6: Add blank lines after declarations

2014-05-13 Thread Artem Fetishev
Use the more common kernel coding style. Version #2 of this patch removes unnecesary blank line added in version #1. Signed-off-by: Artem Fetishev --- drivers/staging/line6/capture.c |3 +++ drivers/staging/line6/midi.c |2 ++ drivers/staging/line6/playback.c |5 + drivers

RE: [x86] BUG: unable to handle kernel paging request at ffff880012770000

2014-07-31 Thread Artem Fetishev
Hi Fengguang, Reproduced with your config and script. Working on locating the cause... Thanks, -Artem -Original Message- From: Fengguang Wu [mailto:fengguang...@intel.com] Sent: Wednesday, July 30, 2014 7:08 AM To: Artem Fetishev Cc: Jet Chen; Su Tao; Yuanhan Liu; LKP; linux-kernel

RE: [x86] BUG: unable to handle kernel paging request at ffff880012770000

2014-08-04 Thread Artem Fetishev
the bisect is correct. -Original Message- From: Artem Fetishev Sent: Thursday, July 31, 2014 9:42 AM To: 'Fengguang Wu' Cc: Jet Chen; Su Tao; Yuanhan Liu; LKP; linux-kernel@vger.kernel.org Subject: RE: [x86] BUG: unable to handle kernel paging request at 88001277 Hi Fengguang