[PATCH] sound: pci: pcxhr: convert timeval to ktime_t

2014-10-28 Thread Aya Mahfouz
in nanoseconds instead of microseconds. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com Reviewed-by: Arnd Bergmann a...@arndb.de --- sound/pci/pcxhr/pcxhr.c | 10 ++ sound/pci/pcxhr/pcxhr_core.c | 10 ++ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/sound

[PATCH v2] sound: pci: pcxhr: convert timeval to ktime_t

2014-10-28 Thread Aya Mahfouz
in nanoseconds instead of microseconds. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com Reviewed-by: Arnd Bergmann a...@arndb.de --- v2: changed variables names to avoid redeclaration conflicts. sound/pci/pcxhr/pcxhr.c | 10 ++ sound/pci/pcxhr/pcxhr_core.c | 10 ++ 2 files

Re: [PATCH] sound: pci: pcxhr: convert timeval to ktime_t

2014-10-28 Thread Aya Mahfouz
On Tue, Oct 28, 2014 at 12:59:59PM +0100, Takashi Iwai wrote: At Tue, 28 Oct 2014 13:29:56 +0200, Aya Mahfouz wrote: This patch is concerned with migrating the time variables in the pcxhr module found in the sound driver. The changes are concerend with the y2038 problem where timeval

[PATCH] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-10-29 Thread Aya Mahfouz
variables use monotonic time values through the function ktime_get_ts64(). This is to make sure that all the time values are calculated from a fixed point. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- v1: Arnd has advised me to provide you with options for time calculation

[PATCH v2] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-10-31 Thread Aya Mahfouz
for the sake of speed and efficiency. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- v1: Arnd has advised me to provide you with options for time calculation. The first option: accuracy is used in this patch. The second option: speed can be done through jiffies. v2

Re: [PATCH v2] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-10-31 Thread Aya Mahfouz
Kind Regards, Aya Saif El-yazal Mahfouz On Fri, 2014-10-31 at 11:18 +0200, Aya Mahfouz wrote: This patch is concerned with migrating the time variables for the s390 network driver. The changes handle the y2038 problem where timespec will overflow in the year 2038. timespec was replaced

[PATCH v3] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-10-31 Thread Aya Mahfouz
for the sake of speed and efficiency. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- v1: Arnd has advised me to provide you with options for time calculation. The first option: accuracy is used in this patch. The second option: speed can be done through jiffies. v2

[PATCH] staging: media: lirc: lirc_zilog.c: adjust debug messages

2014-11-01 Thread Aya Mahfouz
This patch removes one debug message and replaces a dev_err call by pr_err. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- drivers/staging/media/lirc/lirc_zilog.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b

[PATCH v4] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-11-03 Thread Aya Mahfouz
for the sake of speed and efficiency. ch-prof.tx_time will now hold the difference between two jiffies' values instead of the difference between two xtime values represented in microseconds. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- v1: Arnd has advised me to provide you

[no subject]

2014-11-03 Thread Aya Mahfouz
: replace dev_err by pr_err Reply-To: This patch replaces dev_err by pr_err since the value of ir is NULL when the message is displayed. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- drivers/staging/media/lirc/lirc_zilog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-03 Thread Aya Mahfouz
This patch replaces dev_err by pr_err since the value of ir is NULL when the message is displayed. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- drivers/staging/media/lirc/lirc_zilog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc

Re: [PATCH] staging: media: lirc: lirc_zilog.c: adjust debug messages

2014-11-03 Thread Aya Mahfouz
On Sun, Nov 02, 2014 at 12:40:13PM +0100, Konrad Zapalowicz wrote: On 11/01, Aya Mahfouz wrote: This patch removes one debug message and replaces a dev_err call by pr_err. Usually you would like to send this as two separate patches because replacing a debug message is way different than

[PATCH] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-11-04 Thread Aya Mahfouz
for the sake of speed and efficiency. ch-prof.tx_time will now hold the difference between two jiffies' values instead of the difference between two xtime values represented in microseconds. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com Suggested-by: Arnd Bergmann a...@arndb.de --- v1

[PATCH] staging: media: lirc: modify print calls

2014-11-04 Thread Aya Mahfouz
This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- drivers/staging/media/lirc/lirc_zilog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-05 Thread Aya Mahfouz
On Wed, Nov 05, 2014 at 12:57:38PM +0530, Sudip Mukherjee wrote: On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote: On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote: On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: This patch replaces dev_err

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Aya Mahfouz
On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote: Em Tue, 4 Nov 2014 23:43:07 +0200 Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu: This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. Also doesn't apply

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Aya Mahfouz
On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote: On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote: This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. i think you should mention in the commit message why you

[PATCH v5] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-11-05 Thread Aya Mahfouz
for the sake of speed and efficiency. ch-prof.tx_time will now hold the difference between two jiffies' values instead of the difference between two xtime values represented in microseconds. Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com Suggested-by: Arnd Bergmann a...@arndb.de --- v1

[PATCH] staging: davinci_vpfe: fix space prohibited before semicolon warning

2015-01-14 Thread Aya Mahfouz
This patch fixes the following checkpatch.pl warning: space prohibited before semicolon Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- v1: This patch applies to Greg's tree. drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH] staging: vt6655: mac.h: fix space prohibited before that ','

2015-01-22 Thread Aya Mahfouz
On Mon, Jan 19, 2015 at 02:30:25PM +0200, Mohamed Lotfy Hammad wrote: This patch fixes the following checkpatch.pl error: fix space prohibited before that ',' Signed-off-by: Mohamed Lotfy Hammad mohamed.lotfy.ham...@gmail.com Reviewed-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com

Re: [PATCH v2] staging: vt6655: fix space prohibited before that ','

2015-01-22 Thread Aya Mahfouz
On Mon, Jan 19, 2015 at 12:16:30PM +0200, Heba Aamer wrote: This patch fixes the following checkpatch.pl error: fix space prohibited before that ',' Signed-off-by: Heba Aamer heba93aa...@gmail.com Reviewed-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com --- v2: added Signed-off line

Re: [PATCH] staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)

2015-01-22 Thread Aya Mahfouz
seq_ctrl; /*22 2 */ u8 addr4[6]; /*24 6 */ /* size: 30, cachelines: 1, members: 7 */ /* last cacheline: 30 bytes */ }; Signed-off-by: Heba Aamer heba93aa...@gmail.com Reviewed-by: Aya

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Aya Mahfouz
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) I used the following coccinelle script: @@

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Aya Mahfouz
On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote: On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning

Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

2015-01-25 Thread Aya Mahfouz
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... netdev_info was used since it is a network subsystem

[PATCH v3] scripts: checkpatch.pl: add 2 new checks on memset

2015-03-01 Thread Aya Mahfouz
$stat has been restricted to handle memset function calls of the form: [identifer =]* memset(arg1, arg2, arg3) Cc: Julia Lawall julia.law...@lip6.fr Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com Signed-off-by: Joe Perches j...@perches.com --- v2: adjusted all checks on memset calls

Re: [PATCH v3] scripts: checkpatch.pl: add 2 new checks on memset

2015-03-01 Thread Aya Mahfouz
On Sun, Mar 01, 2015 at 02:13:21PM -0800, Joe Perches wrote: On Sun, 2015-03-01 at 23:43 +0200, Aya Mahfouz wrote: calls Reply-To: Add 2 new checks on memset calls in the file checkpatch.pl as follows: Hi again Aya The initial 3 lines here aren't necessary. I think it'd

[PATCH V4] checkpatch: prefer eth_foo_addr over memset(,,ETH_ALEN)

2015-03-01 Thread Aya Mahfouz
restricted to handle memset function calls of the form: [identifer =]* memset(arg1, arg2, arg3) Cc: Julia Lawall julia.law...@lip6.fr Cc: Andrew Morton a...@linux-foundation.org Acked-by: Joe Perches j...@perches.com Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com [j...@perches.com: handled all

[PATCH] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-23 Thread Aya Mahfouz
. replace memset by eth_broadcast_addr if the second argument is the broadcast address (0xff). eth_broadcast_addr is a wrapper function for memset that sets the passed array the broadcast address. The size of the address has to be ETH_ALEN. Cc: Julia Lawall julia.law...@lip6.fr Signed-off-by: Aya

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
On Tue, Feb 24, 2015 at 09:45:43PM -0800, Joe Perches wrote: On Wed, 2015-02-25 at 06:59 +0200, Aya Mahfouz wrote: On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote: On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote: On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches

[PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
. replace memset by eth_broadcast_addr if the second argument is the broadcast address (0xff). eth_broadcast_addr is a wrapper function for memset that sets the passed array the broadcast address. The size of the address has to be ETH_ALEN. Cc: Julia Lawall julia.law...@lip6.fr Signed-off-by: Aya

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote: On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote: This patch adds 2 new checks on memset calls in the file checkpatch.pl as follows: replace memset by eth_zero_addr if the second argument is an address of zeros (0x00

Re: [PATCH] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
On Mon, Feb 23, 2015 at 07:06:27PM -0800, Joe Perches wrote: On Mon, 2015-02-23 at 21:18 +0200, Aya Mahfouz wrote: This patch adds 2 new checks on memset calls in the file checkpatch.pl as follows: replace memset by eth_zero_addr if the second argument is an address of zeros (0x00

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote: On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote: On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote: On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote: This patch adds 2 new checks on memset calls in the file

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-26 Thread Aya Mahfouz
On Tue, Feb 24, 2015 at 10:20:24PM -0800, Joe Perches wrote: On Wed, 2015-02-25 at 08:08 +0200, Aya Mahfouz wrote: What is the next step? Ideally, you understanding why the suggested patch is an improvement over the patch you proposed. Beyond that, submit a patch. Then submit more

[PATCH] staging: gdm724x: constify tty_port_operations structs

2015-12-14 Thread Aya Mahfouz
Constifies tty_port_operations structure in the tty code of the gdm724x driver since it is not modified after its initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>

[PATCH] tty: serial: constify psc_ops structs

2015-12-14 Thread Aya Mahfouz
Constifies psc_ops structures in tty's serial port driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- driver

[PATCH] tty: serial: constify uartlite_reg_ops structs

2015-12-14 Thread Aya Mahfouz
Constifies uartlite_reg_ops structures in tty's serial port driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- driver

[PATCH] tty: constify tty_port_operations structs

2015-12-14 Thread Aya Mahfouz
Constifies tty_port_operations structures in the tty driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- drivers/tty/go

[PATCH] tty: serial: constify sunhv_ops structs

2015-12-14 Thread Aya Mahfouz
Constifies sunhv_ops structures in tty's serial driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- drivers/tty/serial

[PATCH] char: constify tty_port_operations structs

2015-12-14 Thread Aya Mahfouz
Constifies tty_port_operations structure in the char driver since it is not modified after its initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- drivers/char/tty

[PATCH] s390: char: constify hmcdrv_ftp_ops structs

2015-12-13 Thread Aya Mahfouz
Constifies hmcdrv_ftp_ops structures in s390's char driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- drive

Re: [PATCH] tty: serial: constify uartlite_reg_ops structs

2015-12-15 Thread Aya Mahfouz
On Tue, Dec 15, 2015 at 01:42:05AM +0200, Aya Mahfouz wrote: > Constifies uartlite_reg_ops structures in tty's > serial port driver since they are not modified > after their initialization. > > Detected and found using Coccinelle. > > Suggested-by: Julia Lawall <julia.

[PATCH v2] staging: lustre: ptlrpc: constify ptlrpc_sec_cops structs

2015-11-27 Thread Aya Mahfouz
Constifies ptlrpc_sec_cops structures in the lustre driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- Changelog:

[PATCH] staging: lustre: ptlrpc: constify ptlrpc_sec_cops structs

2015-11-23 Thread Aya Mahfouz
Constifies ptlrpc_sec_cops structures in the lustre driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- drivers/staging/l

[PATCH] net: dns_resolver: convert time_t to time64_t

2015-11-17 Thread Aya Mahfouz
Changes the definition of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in the year 2038. The change is safe because the kernel subsystems that call dns_query pass NULL. Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-b

[PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

2016-10-17 Thread Aya Mahfouz
class_devno_max is an inline function that returns MAX_OBD_DEVICES. Replace all calls to the function by MAX_OBD_DEVICES. Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +++--- drivers/staging/lustre/lustre/ob

Re: [PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

2016-10-25 Thread Aya Mahfouz
On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote: > On Oct 17, 2016, at 15:46, Aya Mahfouz <mahfouz.saif.elya...@gmail.com> wrote: > > > > class_devno_max is an inline function that returns > > MAX_OBD_DEVICES. Replace all calls to the function > >

[PATCH 2/2] staging: lustre: remove class_devno_max

2016-10-17 Thread Aya Mahfouz
class_devno_max is an inline function that is not used anymore. Hence, it is removed. Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- drivers/staging/lustre/lustre/include/obd_class.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/i

[PATCH 0/2] staging: lustre: replace and remove class_devno_max

2016-10-17 Thread Aya Mahfouz
class_devno_max is an inline function that is written with the sole purpose of returning the value of MAX_OBD_DEVICES. Since no computations are made by the class_devno_max, replace it with MAX_OBD_DEVICES. Aya Mahfouz (2): staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

[PATCH] staging: lustre: remove unused identifier OBD_INIT_CHECK

2016-10-17 Thread Aya Mahfouz
OBD_INIT_CHECK was previously used by a conditional group. This is no longer the case so it can be removed. Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com> --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/

[PATCH] sound: pci: pcxhr: convert timeval to ktime_t

2014-10-28 Thread Aya Mahfouz
in nanoseconds instead of microseconds. Signed-off-by: Aya Mahfouz Reviewed-by: Arnd Bergmann --- sound/pci/pcxhr/pcxhr.c | 10 ++ sound/pci/pcxhr/pcxhr_core.c | 10 ++ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c

[PATCH v2] sound: pci: pcxhr: convert timeval to ktime_t

2014-10-28 Thread Aya Mahfouz
in nanoseconds instead of microseconds. Signed-off-by: Aya Mahfouz Reviewed-by: Arnd Bergmann --- v2: changed variables names to avoid redeclaration conflicts. sound/pci/pcxhr/pcxhr.c | 10 ++ sound/pci/pcxhr/pcxhr_core.c | 10 ++ 2 files changed, 12 insertions(+), 8 deletions

Re: [PATCH] sound: pci: pcxhr: convert timeval to ktime_t

2014-10-28 Thread Aya Mahfouz
On Tue, Oct 28, 2014 at 12:59:59PM +0100, Takashi Iwai wrote: > At Tue, 28 Oct 2014 13:29:56 +0200, > Aya Mahfouz wrote: > > > > This patch is concerned with migrating the time variables in the pcxhr > > module found in the sound driver. The changes are concerend with the

[PATCH] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-10-29 Thread Aya Mahfouz
variables use monotonic time values through the function ktime_get_ts64(). This is to make sure that all the time values are calculated from a fixed point. Signed-off-by: Aya Mahfouz --- v1: Arnd has advised me to provide you with options for time calculation. The first option: "accuracy&quo

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-26 Thread Aya Mahfouz
On Tue, Feb 24, 2015 at 10:20:24PM -0800, Joe Perches wrote: > On Wed, 2015-02-25 at 08:08 +0200, Aya Mahfouz wrote: > > What is the next step? > > Ideally, you understanding why the suggested patch > is an improvement over the patch you proposed. > > Beyond that, subm

[PATCH v3] scripts: checkpatch.pl: add 2 new checks on memset

2015-03-01 Thread Aya Mahfouz
$stat has been restricted to handle memset function calls of the form: [ =]* memset(, , ) Cc: Julia Lawall Signed-off-by: Aya Mahfouz Signed-off-by: Joe Perches --- v2: adjusted all checks on memset calls to be in one body v3: adjusted all regular expressions per Joe Perches suggestions. Added

Re: [PATCH v3] scripts: checkpatch.pl: add 2 new checks on memset

2015-03-01 Thread Aya Mahfouz
On Sun, Mar 01, 2015 at 02:13:21PM -0800, Joe Perches wrote: > On Sun, 2015-03-01 at 23:43 +0200, Aya Mahfouz wrote: > > calls > > Reply-To: > > > > Add 2 new checks on memset calls in the file checkpatch.pl as follows: > > Hi again Aya > > The initia

[PATCH V4] checkpatch: prefer eth__addr over memset(,,ETH_ALEN)

2015-03-01 Thread Aya Mahfouz
restricted to handle memset function calls of the form: [ =]* memset(, , ) Cc: Julia Lawall Cc: Andrew Morton Acked-by: Joe Perches Signed-off-by: Aya Mahfouz [j...@perches.com: handled all regular expressions] Portions-by: Joe Perches --- v2: adjusted all checks on memset calls to be in one body v3

[PATCH] staging: davinci_vpfe: fix space prohibited before semicolon warning

2015-01-14 Thread Aya Mahfouz
This patch fixes the following checkpatch.pl warning: space prohibited before semicolon Signed-off-by: Aya Mahfouz --- v1: This patch applies to Greg's tree. drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH v2] staging: vt6655: fix space prohibited before that ','

2015-01-22 Thread Aya Mahfouz
On Mon, Jan 19, 2015 at 12:16:30PM +0200, Heba Aamer wrote: > This patch fixes the following checkpatch.pl error: > fix space prohibited before that ',' > > Signed-off-by: Heba Aamer Reviewed-by: Aya Mahfouz > --- > v2: added Signed-off line > > drivers/staging/vt6

Re: [PATCH] staging: vt6655: mac.h: fix space prohibited before that ','

2015-01-22 Thread Aya Mahfouz
On Mon, Jan 19, 2015 at 02:30:25PM +0200, Mohamed Lotfy Hammad wrote: > This patch fixes the following checkpatch.pl error: > fix space prohibited before that ',' > > Signed-off-by: Mohamed Lotfy Hammad Reviewed-by: Aya Mahfouz > --- > drivers/staging/vt6655/mac.h | 2 +- &g

Re: [PATCH] staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)

2015-01-22 Thread Aya Mahfouz
cachelines: 1, members: 7 */ > /* last cacheline: 30 bytes */ > }; > > Signed-off-by: Heba Aamer Reviewed-by: Aya Mahfouz > --- > drivers/staging/vt6656/rxtx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/rxtx.c

Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

2015-01-25 Thread Aya Mahfouz
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote: > This patch fixes the following checkpatch.pl warning: > fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then > dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... > > netdev_info was used since it is a network

[PATCH v4] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-11-03 Thread Aya Mahfouz
for the sake of speed and efficiency. ch->prof.tx_time will now hold the difference between two jiffies' values instead of the difference between two xtime values represented in microseconds. Signed-off-by: Aya Mahfouz --- v1: Arnd has advised me to provide you with options for t

[no subject]

2014-11-03 Thread Aya Mahfouz
the value of ir is NULL when the message is displayed. Signed-off-by: Aya Mahfouz --- drivers/staging/media/lirc/lirc_zilog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c index 11a7cb1..ecdd71e

[PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-03 Thread Aya Mahfouz
This patch replaces dev_err by pr_err since the value of ir is NULL when the message is displayed. Signed-off-by: Aya Mahfouz --- drivers/staging/media/lirc/lirc_zilog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers

Re: [PATCH] staging: media: lirc: lirc_zilog.c: adjust debug messages

2014-11-03 Thread Aya Mahfouz
On Sun, Nov 02, 2014 at 12:40:13PM +0100, Konrad Zapalowicz wrote: > On 11/01, Aya Mahfouz wrote: > > This patch removes one debug message and replaces a dev_err > > call by pr_err. > > Usually you would like to send this as two separate patches because > replacin

[PATCH] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-11-04 Thread Aya Mahfouz
for the sake of speed and efficiency. ch->prof.tx_time will now hold the difference between two jiffies' values instead of the difference between two xtime values represented in microseconds. Signed-off-by: Aya Mahfouz Suggested-by: Arnd Bergmann --- v1: Arnd has advised me to provide

[PATCH] staging: media: lirc: modify print calls

2014-11-04 Thread Aya Mahfouz
This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. Signed-off-by: Aya Mahfouz --- drivers/staging/media/lirc/lirc_zilog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b

Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-05 Thread Aya Mahfouz
On Wed, Nov 05, 2014 at 12:57:38PM +0530, Sudip Mukherjee wrote: > On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote: > > On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote: > > > On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: > >

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Aya Mahfouz
On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 4 Nov 2014 23:43:07 +0200 > Aya Mahfouz escreveu: > > > This patches replaces one pr_debug call by dev_dbg and > > changes the device used by one of the dev_err calls. > > Also doesn't ap

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Aya Mahfouz
On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote: > On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote: > > This patches replaces one pr_debug call by dev_dbg and > > changes the device used by one of the dev_err calls. > > i think you should mention

[PATCH v5] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-11-05 Thread Aya Mahfouz
for the sake of speed and efficiency. ch->prof.tx_time will now hold the difference between two jiffies' values instead of the difference between two xtime values represented in microseconds. Signed-off-by: Aya Mahfouz Suggested-by: Arnd Bergmann --- v1: Arnd has advised me to provide

[PATCH v2] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-10-31 Thread Aya Mahfouz
for the sake of speed and efficiency. Signed-off-by: Aya Mahfouz --- v1: Arnd has advised me to provide you with options for time calculation. The first option: "accuracy" is used in this patch. The second option: "speed" can be done through jiffies. v2: Moved on

Re: [PATCH v2] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-10-31 Thread Aya Mahfouz
ix that. Sorry! > > Regards, Ursula Braun > Kind Regards, Aya Saif El-yazal Mahfouz > On Fri, 2014-10-31 at 11:18 +0200, Aya Mahfouz wrote: > > This patch is concerned with migrating the time variables for the s390 > > network driver. The changes handle the y2038 problem where t

[PATCH v3] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

2014-10-31 Thread Aya Mahfouz
for the sake of speed and efficiency. Signed-off-by: Aya Mahfouz --- v1: Arnd has advised me to provide you with options for time calculation. The first option: "accuracy" is used in this patch. The second option: "speed" can be done through jiffies. v2: Moved on

[PATCH] staging: media: lirc: lirc_zilog.c: adjust debug messages

2014-11-01 Thread Aya Mahfouz
This patch removes one debug message and replaces a dev_err call by pr_err. Signed-off-by: Aya Mahfouz --- drivers/staging/media/lirc/lirc_zilog.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Aya Mahfouz
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > On 01/28/2015 09:53 AM, Heba Aamer wrote: > >This patch fixes the following checkpatch.pl warning: > >Prefer ether_addr_copy() over memcpy() > >if the Ethernet addresses are __aligned(2) > > > >I used the following coccinelle script:

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Aya Mahfouz
On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote: > On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: > > On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > > > On 01/28/2015 09:53 AM, Heba Aamer wrote: > > > >This patch fix

[PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
. replace memset by eth_broadcast_addr if the second argument is the broadcast address (0xff). eth_broadcast_addr is a wrapper function for memset that sets the passed array the broadcast address. The size of the address has to be ETH_ALEN. Cc: Julia Lawall Signed-off-by: Aya Mahfouz --- v2

Re: [PATCH] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
On Mon, Feb 23, 2015 at 07:06:27PM -0800, Joe Perches wrote: > On Mon, 2015-02-23 at 21:18 +0200, Aya Mahfouz wrote: > > This patch adds 2 new checks on memset calls in the file > > checkpatch.pl as follows: > > > > replace memset by eth_zero_addr if the second argument

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote: > On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote: > > This patch adds 2 new checks on memset calls in the file > > checkpatch.pl as follows: > > > > replace memset by eth_zero_addr if the second argument

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote: > On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote: > > On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote: > > > On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote: > > > > This patch add

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-24 Thread Aya Mahfouz
On Tue, Feb 24, 2015 at 09:45:43PM -0800, Joe Perches wrote: > On Wed, 2015-02-25 at 06:59 +0200, Aya Mahfouz wrote: > > On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote: > > > On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote: > > > > On Tue, Feb 24,

[PATCH] scripts: checkpatch.pl: add 2 new checks on memset calls

2015-02-23 Thread Aya Mahfouz
. replace memset by eth_broadcast_addr if the second argument is the broadcast address (0xff). eth_broadcast_addr is a wrapper function for memset that sets the passed array the broadcast address. The size of the address has to be ETH_ALEN. Cc: Julia Lawall Signed-off-by: Aya Mahfouz --- scripts

Re: [PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

2016-10-25 Thread Aya Mahfouz
On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote: > On Oct 17, 2016, at 15:46, Aya Mahfouz wrote: > > > > class_devno_max is an inline function that returns > > MAX_OBD_DEVICES. Replace all calls to the function > > by MAX_OBD_DEVICES. > > Thanks

[PATCH] staging: lustre: remove unused identifier OBD_INIT_CHECK

2016-10-17 Thread Aya Mahfouz
OBD_INIT_CHECK was previously used by a conditional group. This is no longer the case so it can be removed. Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b

[PATCH 0/2] staging: lustre: replace and remove class_devno_max

2016-10-17 Thread Aya Mahfouz
class_devno_max is an inline function that is written with the sole purpose of returning the value of MAX_OBD_DEVICES. Since no computations are made by the class_devno_max, replace it with MAX_OBD_DEVICES. Aya Mahfouz (2): staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

[PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

2016-10-17 Thread Aya Mahfouz
class_devno_max is an inline function that returns MAX_OBD_DEVICES. Replace all calls to the function by MAX_OBD_DEVICES. Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +++--- drivers/staging/lustre/lustre/obdclass/genops.c| 22

[PATCH 2/2] staging: lustre: remove class_devno_max

2016-10-17 Thread Aya Mahfouz
class_devno_max is an inline function that is not used anymore. Hence, it is removed. Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/include/obd_class.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging

[PATCH] staging: gdm724x: constify tty_port_operations structs

2015-12-14 Thread Aya Mahfouz
Constifies tty_port_operations structure in the tty code of the gdm724x driver since it is not modified after its initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/staging/gdm724x/gdm_tty.c | 2 +- 1 file changed, 1

[PATCH] tty: serial: constify sunhv_ops structs

2015-12-14 Thread Aya Mahfouz
Constifies sunhv_ops structures in tty's serial driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/tty/serial/sunhv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH] tty: serial: constify uartlite_reg_ops structs

2015-12-14 Thread Aya Mahfouz
Constifies uartlite_reg_ops structures in tty's serial port driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/tty/serial/uartlite.c | 8 1 file changed, 4 insertions

[PATCH] tty: serial: constify psc_ops structs

2015-12-14 Thread Aya Mahfouz
Constifies psc_ops structures in tty's serial port driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/tty/serial/mpc52xx_uart.c | 8 1 file changed, 4 insertions(+), 4

[PATCH] char: constify tty_port_operations structs

2015-12-14 Thread Aya Mahfouz
Constifies tty_port_operations structure in the char driver since it is not modified after its initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/char/ttyprintk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] tty: constify tty_port_operations structs

2015-12-14 Thread Aya Mahfouz
Constifies tty_port_operations structures in the tty driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/tty/goldfish.c | 2 +- drivers/tty/mxser.c| 2 +- 2 files changed, 2

Re: [PATCH] tty: serial: constify uartlite_reg_ops structs

2015-12-15 Thread Aya Mahfouz
On Tue, Dec 15, 2015 at 01:42:05AM +0200, Aya Mahfouz wrote: > Constifies uartlite_reg_ops structures in tty's > serial port driver since they are not modified > after their initialization. > > Detected and found using Coccinelle. > > Suggested-by: Julia Lawall > Si

[PATCH] net: dns_resolver: convert time_t to time64_t

2015-11-17 Thread Aya Mahfouz
Changes the definition of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in the year 2038. The change is safe because the kernel subsystems that call dns_query pass NULL. Signed-off-by: Arnd Bergmann Signed-off-by: Aya Mahfouz

[PATCH] staging: lustre: ptlrpc: constify ptlrpc_sec_cops structs

2015-11-23 Thread Aya Mahfouz
Constifies ptlrpc_sec_cops structures in the lustre driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +- drivers/staging/lustre

  1   2   >