in nanoseconds instead of microseconds.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
Reviewed-by: Arnd Bergmann a...@arndb.de
---
sound/pci/pcxhr/pcxhr.c | 10 ++
sound/pci/pcxhr/pcxhr_core.c | 10 ++
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/sound
in nanoseconds instead of microseconds.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
Reviewed-by: Arnd Bergmann a...@arndb.de
---
v2: changed variables names to avoid redeclaration conflicts.
sound/pci/pcxhr/pcxhr.c | 10 ++
sound/pci/pcxhr/pcxhr_core.c | 10 ++
2 files
On Tue, Oct 28, 2014 at 12:59:59PM +0100, Takashi Iwai wrote:
At Tue, 28 Oct 2014 13:29:56 +0200,
Aya Mahfouz wrote:
This patch is concerned with migrating the time variables in the pcxhr
module found in the sound driver. The changes are concerend with the
y2038 problem where timeval
variables use monotonic time values through the function
ktime_get_ts64(). This is to make sure that all the time values
are calculated from a fixed point.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
v1: Arnd has advised me to provide you with options for time
calculation
for the sake of speed and efficiency.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
v1: Arnd has advised me to provide you with options for time
calculation. The first option: accuracy is used in this
patch. The second option: speed can be done through
jiffies.
v2
Kind Regards,
Aya Saif El-yazal Mahfouz
On Fri, 2014-10-31 at 11:18 +0200, Aya Mahfouz wrote:
This patch is concerned with migrating the time variables for the s390
network driver. The changes handle the y2038 problem where timespec will
overflow in the year 2038. timespec was replaced
for the sake of speed and efficiency.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
v1: Arnd has advised me to provide you with options for time
calculation. The first option: accuracy is used in this
patch. The second option: speed can be done through
jiffies.
v2
This patch removes one debug message and replaces a dev_err
call by pr_err.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
drivers/staging/media/lirc/lirc_zilog.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b
for the sake of speed and efficiency.
ch-prof.tx_time will now hold the difference between two jiffies'
values instead of the difference between two xtime values
represented in microseconds.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
v1: Arnd has advised me to provide you
: replace dev_err by pr_err
Reply-To:
This patch replaces dev_err by pr_err since the value
of ir is NULL when the message is displayed.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
drivers/staging/media/lirc/lirc_zilog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This patch replaces dev_err by pr_err since the value
of ir is NULL when the message is displayed.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
drivers/staging/media/lirc/lirc_zilog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc
On Sun, Nov 02, 2014 at 12:40:13PM +0100, Konrad Zapalowicz wrote:
On 11/01, Aya Mahfouz wrote:
This patch removes one debug message and replaces a dev_err
call by pr_err.
Usually you would like to send this as two separate patches because
replacing a debug message is way different than
for the sake of speed and efficiency.
ch-prof.tx_time will now hold the difference between two jiffies'
values instead of the difference between two xtime values
represented in microseconds.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
Suggested-by: Arnd Bergmann a...@arndb.de
---
v1
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
On Wed, Nov 05, 2014 at 12:57:38PM +0530, Sudip Mukherjee wrote:
On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote:
On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote:
On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote:
This patch replaces dev_err
On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote:
Em Tue, 4 Nov 2014 23:43:07 +0200
Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu:
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
Also doesn't apply
On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote:
On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote:
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
i think you should mention in the commit message why you
for the sake of speed and efficiency.
ch-prof.tx_time will now hold the difference between two jiffies'
values instead of the difference between two xtime values
represented in microseconds.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
Suggested-by: Arnd Bergmann a...@arndb.de
---
v1
This patch fixes the following checkpatch.pl warning:
space prohibited before semicolon
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
v1: This patch applies to Greg's tree.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On Mon, Jan 19, 2015 at 02:30:25PM +0200, Mohamed Lotfy Hammad wrote:
This patch fixes the following checkpatch.pl error:
fix space prohibited before that ','
Signed-off-by: Mohamed Lotfy Hammad mohamed.lotfy.ham...@gmail.com
Reviewed-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
On Mon, Jan 19, 2015 at 12:16:30PM +0200, Heba Aamer wrote:
This patch fixes the following checkpatch.pl error:
fix space prohibited before that ','
Signed-off-by: Heba Aamer heba93aa...@gmail.com
Reviewed-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
v2: added Signed-off line
seq_ctrl; /*22 2 */
u8 addr4[6]; /*24 6 */
/* size: 30, cachelines: 1, members: 7 */
/* last cacheline: 30 bytes */
};
Signed-off-by: Heba Aamer heba93aa...@gmail.com
Reviewed-by: Aya
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote:
On 01/28/2015 09:53 AM, Heba Aamer wrote:
This patch fixes the following checkpatch.pl warning:
Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)
I used the following coccinelle script:
@@
On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote:
On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote:
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote:
On 01/28/2015 09:53 AM, Heba Aamer wrote:
This patch fixes the following checkpatch.pl warning
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
netdev_info was used since it is a network subsystem
$stat has been
restricted to handle memset function calls of the form:
[identifer =]* memset(arg1, arg2, arg3)
Cc: Julia Lawall julia.law...@lip6.fr
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
Signed-off-by: Joe Perches j...@perches.com
---
v2: adjusted all checks on memset calls
On Sun, Mar 01, 2015 at 02:13:21PM -0800, Joe Perches wrote:
On Sun, 2015-03-01 at 23:43 +0200, Aya Mahfouz wrote:
calls
Reply-To:
Add 2 new checks on memset calls in the file checkpatch.pl as follows:
Hi again Aya
The initial 3 lines here aren't necessary.
I think it'd
restricted to handle memset function calls of the form:
[identifer =]* memset(arg1, arg2, arg3)
Cc: Julia Lawall julia.law...@lip6.fr
Cc: Andrew Morton a...@linux-foundation.org
Acked-by: Joe Perches j...@perches.com
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
[j...@perches.com: handled all
.
replace memset by eth_broadcast_addr if the second argument is
the broadcast address (0xff). eth_broadcast_addr is a wrapper
function for memset that sets the passed array the broadcast
address. The size of the address has to be ETH_ALEN.
Cc: Julia Lawall julia.law...@lip6.fr
Signed-off-by: Aya
On Tue, Feb 24, 2015 at 09:45:43PM -0800, Joe Perches wrote:
On Wed, 2015-02-25 at 06:59 +0200, Aya Mahfouz wrote:
On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote:
On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote:
On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches
.
replace memset by eth_broadcast_addr if the second argument is
the broadcast address (0xff). eth_broadcast_addr is a wrapper
function for memset that sets the passed array the broadcast
address. The size of the address has to be ETH_ALEN.
Cc: Julia Lawall julia.law...@lip6.fr
Signed-off-by: Aya
On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote:
On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote:
This patch adds 2 new checks on memset calls in the file
checkpatch.pl as follows:
replace memset by eth_zero_addr if the second argument is
an address of zeros (0x00
On Mon, Feb 23, 2015 at 07:06:27PM -0800, Joe Perches wrote:
On Mon, 2015-02-23 at 21:18 +0200, Aya Mahfouz wrote:
This patch adds 2 new checks on memset calls in the file
checkpatch.pl as follows:
replace memset by eth_zero_addr if the second argument is
an address of zeros (0x00
On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote:
On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote:
On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote:
On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote:
This patch adds 2 new checks on memset calls in the file
On Tue, Feb 24, 2015 at 10:20:24PM -0800, Joe Perches wrote:
On Wed, 2015-02-25 at 08:08 +0200, Aya Mahfouz wrote:
What is the next step?
Ideally, you understanding why the suggested patch
is an improvement over the patch you proposed.
Beyond that, submit a patch. Then submit more
Constifies tty_port_operations structure in
the tty code of the gdm724x driver since it
is not modified after its initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
Constifies psc_ops structures in tty's serial
port driver since they are not modified after
their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
driver
Constifies uartlite_reg_ops structures in tty's
serial port driver since they are not modified
after their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
driver
Constifies tty_port_operations structures in
the tty driver since they are not modified
after their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
drivers/tty/go
Constifies sunhv_ops structures in tty's serial
driver since they are not modified after their
initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
drivers/tty/serial
Constifies tty_port_operations structure in
the char driver since it is not modified
after its initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
drivers/char/tty
Constifies hmcdrv_ftp_ops structures in s390's char
driver since they are not modified after their
initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
drive
On Tue, Dec 15, 2015 at 01:42:05AM +0200, Aya Mahfouz wrote:
> Constifies uartlite_reg_ops structures in tty's
> serial port driver since they are not modified
> after their initialization.
>
> Detected and found using Coccinelle.
>
> Suggested-by: Julia Lawall <julia.
Constifies ptlrpc_sec_cops structures in the lustre driver
since they are not modified after their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
Changelog:
Constifies ptlrpc_sec_cops structures in the lustre driver
since they are not modified after their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
drivers/staging/l
Changes the definition of the pointer _expiry from time_t to
time64_t. This is to handle the Y2038 problem where time_t
will overflow in the year 2038. The change is safe because
the kernel subsystems that call dns_query pass NULL.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
Signed-off-b
class_devno_max is an inline function that returns
MAX_OBD_DEVICES. Replace all calls to the function
by MAX_OBD_DEVICES.
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +++---
drivers/staging/lustre/lustre/ob
On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote:
> On Oct 17, 2016, at 15:46, Aya Mahfouz <mahfouz.saif.elya...@gmail.com> wrote:
> >
> > class_devno_max is an inline function that returns
> > MAX_OBD_DEVICES. Replace all calls to the function
> >
class_devno_max is an inline function that is not used
anymore. Hence, it is removed.
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
drivers/staging/lustre/lustre/include/obd_class.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/i
class_devno_max is an inline function that is written with
the sole purpose of returning the value of MAX_OBD_DEVICES.
Since no computations are made by the class_devno_max,
replace it with MAX_OBD_DEVICES.
Aya Mahfouz (2):
staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES
OBD_INIT_CHECK was previously used by a conditional group. This is
no longer the case so it can be removed.
Signed-off-by: Aya Mahfouz <mahfouz.saif.elya...@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/class_obd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/
in nanoseconds instead of microseconds.
Signed-off-by: Aya Mahfouz
Reviewed-by: Arnd Bergmann
---
sound/pci/pcxhr/pcxhr.c | 10 ++
sound/pci/pcxhr/pcxhr_core.c | 10 ++
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c
in nanoseconds instead of microseconds.
Signed-off-by: Aya Mahfouz
Reviewed-by: Arnd Bergmann
---
v2: changed variables names to avoid redeclaration conflicts.
sound/pci/pcxhr/pcxhr.c | 10 ++
sound/pci/pcxhr/pcxhr_core.c | 10 ++
2 files changed, 12 insertions(+), 8 deletions
On Tue, Oct 28, 2014 at 12:59:59PM +0100, Takashi Iwai wrote:
> At Tue, 28 Oct 2014 13:29:56 +0200,
> Aya Mahfouz wrote:
> >
> > This patch is concerned with migrating the time variables in the pcxhr
> > module found in the sound driver. The changes are concerend with the
variables use monotonic time values through the function
ktime_get_ts64(). This is to make sure that all the time values
are calculated from a fixed point.
Signed-off-by: Aya Mahfouz
---
v1: Arnd has advised me to provide you with options for time
calculation. The first option: "accuracy&quo
On Tue, Feb 24, 2015 at 10:20:24PM -0800, Joe Perches wrote:
> On Wed, 2015-02-25 at 08:08 +0200, Aya Mahfouz wrote:
> > What is the next step?
>
> Ideally, you understanding why the suggested patch
> is an improvement over the patch you proposed.
>
> Beyond that, subm
$stat has been
restricted to handle memset function calls of the form:
[ =]* memset(, , )
Cc: Julia Lawall
Signed-off-by: Aya Mahfouz
Signed-off-by: Joe Perches
---
v2: adjusted all checks on memset calls to be in one body
v3: adjusted all regular expressions per Joe Perches suggestions. Added
On Sun, Mar 01, 2015 at 02:13:21PM -0800, Joe Perches wrote:
> On Sun, 2015-03-01 at 23:43 +0200, Aya Mahfouz wrote:
> > calls
> > Reply-To:
> >
> > Add 2 new checks on memset calls in the file checkpatch.pl as follows:
>
> Hi again Aya
>
> The initia
restricted to handle memset function calls of the form:
[ =]* memset(, , )
Cc: Julia Lawall
Cc: Andrew Morton
Acked-by: Joe Perches
Signed-off-by: Aya Mahfouz
[j...@perches.com: handled all regular expressions]
Portions-by: Joe Perches
---
v2: adjusted all checks on memset calls to be in one body
v3
This patch fixes the following checkpatch.pl warning:
space prohibited before semicolon
Signed-off-by: Aya Mahfouz
---
v1: This patch applies to Greg's tree.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
On Mon, Jan 19, 2015 at 12:16:30PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl error:
> fix space prohibited before that ','
>
> Signed-off-by: Heba Aamer
Reviewed-by: Aya Mahfouz
> ---
> v2: added Signed-off line
>
> drivers/staging/vt6
On Mon, Jan 19, 2015 at 02:30:25PM +0200, Mohamed Lotfy Hammad wrote:
> This patch fixes the following checkpatch.pl error:
> fix space prohibited before that ','
>
> Signed-off-by: Mohamed Lotfy Hammad
Reviewed-by: Aya Mahfouz
> ---
> drivers/staging/vt6655/mac.h | 2 +-
&g
cachelines: 1, members: 7 */
> /* last cacheline: 30 bytes */
> };
>
> Signed-off-by: Heba Aamer
Reviewed-by: Aya Mahfouz
> ---
> drivers/staging/vt6656/rxtx.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/rxtx.c
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> netdev_info was used since it is a network
for the sake of speed and efficiency.
ch->prof.tx_time will now hold the difference between two jiffies'
values instead of the difference between two xtime values
represented in microseconds.
Signed-off-by: Aya Mahfouz
---
v1: Arnd has advised me to provide you with options for t
the value
of ir is NULL when the message is displayed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/media/lirc/lirc_zilog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b/drivers/staging/media/lirc/lirc_zilog.c
index 11a7cb1..ecdd71e
This patch replaces dev_err by pr_err since the value
of ir is NULL when the message is displayed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/media/lirc/lirc_zilog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b/drivers
On Sun, Nov 02, 2014 at 12:40:13PM +0100, Konrad Zapalowicz wrote:
> On 11/01, Aya Mahfouz wrote:
> > This patch removes one debug message and replaces a dev_err
> > call by pr_err.
>
> Usually you would like to send this as two separate patches because
> replacin
for the sake of speed and efficiency.
ch->prof.tx_time will now hold the difference between two jiffies'
values instead of the difference between two xtime values
represented in microseconds.
Signed-off-by: Aya Mahfouz
Suggested-by: Arnd Bergmann
---
v1: Arnd has advised me to provide
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
Signed-off-by: Aya Mahfouz
---
drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b
On Wed, Nov 05, 2014 at 12:57:38PM +0530, Sudip Mukherjee wrote:
> On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote:
> > On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote:
> > > On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote:
> >
On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote:
> Em Tue, 4 Nov 2014 23:43:07 +0200
> Aya Mahfouz escreveu:
>
> > This patches replaces one pr_debug call by dev_dbg and
> > changes the device used by one of the dev_err calls.
>
> Also doesn't ap
On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote:
> On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote:
> > This patches replaces one pr_debug call by dev_dbg and
> > changes the device used by one of the dev_err calls.
>
> i think you should mention
for the sake of speed and efficiency.
ch->prof.tx_time will now hold the difference between two jiffies'
values instead of the difference between two xtime values
represented in microseconds.
Signed-off-by: Aya Mahfouz
Suggested-by: Arnd Bergmann
---
v1: Arnd has advised me to provide
for the sake of speed and efficiency.
Signed-off-by: Aya Mahfouz
---
v1: Arnd has advised me to provide you with options for time
calculation. The first option: "accuracy" is used in this
patch. The second option: "speed" can be done through
jiffies.
v2: Moved on
ix that. Sorry!
>
> Regards, Ursula Braun
>
Kind Regards,
Aya Saif El-yazal Mahfouz
> On Fri, 2014-10-31 at 11:18 +0200, Aya Mahfouz wrote:
> > This patch is concerned with migrating the time variables for the s390
> > network driver. The changes handle the y2038 problem where t
for the sake of speed and efficiency.
Signed-off-by: Aya Mahfouz
---
v1: Arnd has advised me to provide you with options for time
calculation. The first option: "accuracy" is used in this
patch. The second option: "speed" can be done through
jiffies.
v2: Moved on
This patch removes one debug message and replaces a dev_err
call by pr_err.
Signed-off-by: Aya Mahfouz
---
drivers/staging/media/lirc/lirc_zilog.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b/drivers/staging/media/lirc
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote:
> On 01/28/2015 09:53 AM, Heba Aamer wrote:
> >This patch fixes the following checkpatch.pl warning:
> >Prefer ether_addr_copy() over memcpy()
> >if the Ethernet addresses are __aligned(2)
> >
> >I used the following coccinelle script:
On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote:
> On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote:
> > On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote:
> > > On 01/28/2015 09:53 AM, Heba Aamer wrote:
> > > >This patch fix
.
replace memset by eth_broadcast_addr if the second argument is
the broadcast address (0xff). eth_broadcast_addr is a wrapper
function for memset that sets the passed array the broadcast
address. The size of the address has to be ETH_ALEN.
Cc: Julia Lawall
Signed-off-by: Aya Mahfouz
---
v2
On Mon, Feb 23, 2015 at 07:06:27PM -0800, Joe Perches wrote:
> On Mon, 2015-02-23 at 21:18 +0200, Aya Mahfouz wrote:
> > This patch adds 2 new checks on memset calls in the file
> > checkpatch.pl as follows:
> >
> > replace memset by eth_zero_addr if the second argument
On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote:
> On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote:
> > This patch adds 2 new checks on memset calls in the file
> > checkpatch.pl as follows:
> >
> > replace memset by eth_zero_addr if the second argument
On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote:
> On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote:
> > On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote:
> > > On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote:
> > > > This patch add
On Tue, Feb 24, 2015 at 09:45:43PM -0800, Joe Perches wrote:
> On Wed, 2015-02-25 at 06:59 +0200, Aya Mahfouz wrote:
> > On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote:
> > > On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote:
> > > > On Tue, Feb 24,
.
replace memset by eth_broadcast_addr if the second argument is
the broadcast address (0xff). eth_broadcast_addr is a wrapper
function for memset that sets the passed array the broadcast
address. The size of the address has to be ETH_ALEN.
Cc: Julia Lawall
Signed-off-by: Aya Mahfouz
---
scripts
On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote:
> On Oct 17, 2016, at 15:46, Aya Mahfouz wrote:
> >
> > class_devno_max is an inline function that returns
> > MAX_OBD_DEVICES. Replace all calls to the function
> > by MAX_OBD_DEVICES.
>
> Thanks
OBD_INIT_CHECK was previously used by a conditional group. This is
no longer the case so it can be removed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/obdclass/class_obd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c
b
class_devno_max is an inline function that is written with
the sole purpose of returning the value of MAX_OBD_DEVICES.
Since no computations are made by the class_devno_max,
replace it with MAX_OBD_DEVICES.
Aya Mahfouz (2):
staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES
class_devno_max is an inline function that returns
MAX_OBD_DEVICES. Replace all calls to the function
by MAX_OBD_DEVICES.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +++---
drivers/staging/lustre/lustre/obdclass/genops.c| 22
class_devno_max is an inline function that is not used
anymore. Hence, it is removed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/include/obd_class.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd_class.h
b/drivers/staging
Constifies tty_port_operations structure in
the tty code of the gdm724x driver since it
is not modified after its initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1
Constifies sunhv_ops structures in tty's serial
driver since they are not modified after their
initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/tty/serial/sunhv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
Constifies uartlite_reg_ops structures in tty's
serial port driver since they are not modified
after their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/tty/serial/uartlite.c | 8
1 file changed, 4 insertions
Constifies psc_ops structures in tty's serial
port driver since they are not modified after
their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/tty/serial/mpc52xx_uart.c | 8
1 file changed, 4 insertions(+), 4
Constifies tty_port_operations structure in
the char driver since it is not modified
after its initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/char/ttyprintk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Constifies tty_port_operations structures in
the tty driver since they are not modified
after their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/tty/goldfish.c | 2 +-
drivers/tty/mxser.c| 2 +-
2 files changed, 2
On Tue, Dec 15, 2015 at 01:42:05AM +0200, Aya Mahfouz wrote:
> Constifies uartlite_reg_ops structures in tty's
> serial port driver since they are not modified
> after their initialization.
>
> Detected and found using Coccinelle.
>
> Suggested-by: Julia Lawall
> Si
Changes the definition of the pointer _expiry from time_t to
time64_t. This is to handle the Y2038 problem where time_t
will overflow in the year 2038. The change is safe because
the kernel subsystems that call dns_query pass NULL.
Signed-off-by: Arnd Bergmann
Signed-off-by: Aya Mahfouz
Constifies ptlrpc_sec_cops structures in the lustre driver
since they are not modified after their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +-
drivers/staging/lustre
1 - 100 of 102 matches
Mail list logo