RE: Sytem slowdown on 2.4.1-ac20 (recurring from 2.4.0)

2001-02-28 Thread Balbir Singh
Just FYI: I remember posting something a few days ago to make the serial console more reliable for such situations. Some allocations in the serial port driver are done at runtime using page_alloc, if somebody runs out of memory the serial tty driver would not work properly. I am not saying that

Is it useful to support user level drivers

2001-06-21 Thread Balbir Singh
I realize that the Linux kernel supports user level drivers (via ioperm, etc). However interrupts at user level are not supported, does anyone think it would be a good idea to add user level interrupt support ? I have a framework for it, but it still needs a lot of work. Depending on the

Re: A signal fairy tale

2001-06-26 Thread Balbir Singh
Shouldn't there be a sigclose() and other operations to make the API orthogonal. sigopen() should be selective about the signals it allows as argument. Try and make sigopen() thread specific, so that if one thread does a sigopen(), it does not imply it will do all the signal handling for all the

Re: A signal fairy tale

2001-06-27 Thread Balbir Singh
| | Let me know, when somebody has a patch or needs help, I would like to | help or take a look at it. | |Maybe we can both hack on this. | Sure, that should be interesting, did you have something in mind ? We can start right away. - To unsubscribe from this list: send the line unsubscribe

Re: Reg kdb utility

2001-07-03 Thread Balbir Singh
You need to compile with the correct kernel headers using the include path feature -I path to new headers Balbir On Tue, 3 Jul 2001, SATHISH.J wrote: |Hi, | |I tried to use kdb on my 2.2.14-12 kernel. I was able to compile the file |/usr/src/linux/arch/i386/kdb/modules/kdbm_vm.c and could

[PATCH -mm] Taskstats fix getdelays usage information

2007-04-19 Thread Balbir Singh
[]) loop = 1; break; default: - printf(Unknown option %d\n, c); + usage(); exit(-1); } } _ -- Warm Regards, Balbir Singh Linux Technology Center

[PATCH -mm] Taskstats fix the structure members alignment issue

2007-04-20 Thread Balbir Singh
,# read_char 224,# write_char 232,# read_syscalls 240,# write_syscalls 248,# read_bytes 256,# write_bytes 264,# cancelled_write_bytes ); Signed-off-by: Balbir Singh [EMAIL PROTECTED] --- include/linux/taskstats.h | 11

Re: [PATCH -mm] Taskstats fix the structure members alignment issue

2007-04-21 Thread Balbir Singh
Andrew Morton wrote: On Fri, 20 Apr 2007 22:13:41 +0530 Balbir Singh [EMAIL PROTECTED] wrote: We broke the the alignment of members of taskstats to the 8 byte boundary with the CSA patches. In the current kernel, the taskstats structure is not suitable for use by 32 bit applications in a 64

Re: [PATCH -mm] Taskstats fix the structure members alignment issue

2007-04-21 Thread Balbir Singh
Andrew Morton wrote: On Sat, 21 Apr 2007 18:29:21 +0530 Balbir Singh [EMAIL PROTECTED] wrote: The patch adds an __attribute__((aligned(8))) to the taskstats structure members so that 32 bit applications using taskstats can work with a 64 bit kernel. But there might be 32-bit applications out

Re: [PATCH 8/8] Per-container pages reclamation

2007-04-24 Thread Balbir Singh
problem I had with my RSS controller patches. + + list_move(pc-list, pc_list); + -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 8/8] Per-container pages reclamation

2007-04-24 Thread Balbir Singh
Pavel Emelianov wrote: Balbir Singh wrote: Pavel Emelianov wrote: Implement try_to_free_pages_in_container() to free the pages in container that has run out of memory. The scan_control-isolate_pages() function isolates the container pages only. Pavel, I've just started playing around

Re: [RFC][PATCH 5/7] Per-container OOM killer and page reclamation

2007-03-09 Thread Balbir Singh
Hi, Pavel, Please find my patch to add LRU behaviour to your latest RSS controller. Balbir Singh Linux Technology Center IBM, ISTL Add LRU behaviour to the RSS controller patches posted by Pavel Emelianov http://lkml.org/lkml/2007/3/6/198 which was in turn similar to the RSS controller

Re: [RFC][PATCH 2/7] RSS controller core

2007-03-11 Thread Balbir Singh
like resizing a zone, finding the right size, etc. I'll look at Mel's patches to see what is supported. Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [RFC][PATCH 2/7] RSS controller core

2007-03-12 Thread Balbir Singh
doesn't look so good for me, mainly becaus of the additional per page data and per page processing on 4GB memory, with 100 guests, 50% shared for each guest, this basically means ~1mio pages, 500k shared and 1500k x sizeof(page_container) entries, which roughly boils down to ~25MB of wasted

Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting

2007-03-12 Thread Balbir Singh
On 3/12/07, Dave Hansen [EMAIL PROTECTED] wrote: On Mon, 2007-03-12 at 19:16 +0300, Kirill Korotaev wrote: now VE2 maps the same page. You can't determine whether this page is mapped to this container or another one w/o page-container pointer. Hi Kirill, I thought we can always get from the

Re: [RFC][PATCH 2/7] RSS controller core

2007-03-12 Thread Balbir Singh
From: Pavel Emelianov [EMAIL PROTECTED] To: Andrew Morton [EMAIL PROTECTED], Paul Menage [EMAIL PROTECTED], Srivatsa Vaddagiri [EMAIL PROTECTED], Balbir Singh [EMAIL PROTECTED] Cc: [EMAIL PROTECTED], Linux Kernel Mailing List linux-kernel@vger.kernel.org Date: Tue, 06 Mar

Re: [RFC][PATCH 4/7] RSS accounting hooks over the code

2007-03-13 Thread Balbir Singh
several advantages 1. The limits can be individually set and controlled. 2. The code is broken down into simpler chunks for review and merging. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe

Re: [RFC][PATCH 4/7] RSS accounting hooks over the code

2007-03-14 Thread Balbir Singh
Nick Piggin wrote: Balbir Singh wrote: Nick Piggin wrote: And strangely, this example does not go outside the parameters of what you asked for AFAIKS. In the worst case of one container getting _all_ the shared pages, they will still remain inside their maximum rss limit. When that does

Re: taskstats accounting info

2007-03-14 Thread Balbir Singh
. It needs some cleaning up. I hope to get to it after the OLS paper submission deadline. Thanks, Thanks for bringing the issue to my notice, -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe

Re: [RFC][PATCH 4/7] RSS accounting hooks over the code

2007-03-14 Thread Balbir Singh
the containers list... does everyone still have *different* plans, or is any sort of consensus being reached? hope we'll have it soon :) Good luck ;) I think we have made some forward progress on the consensus. -- Warm Regards, Balbir Singh Linux Technology Center IBM

Re: taskstats accounting info

2007-03-15 Thread Balbir Singh
Andrew Morton wrote: On Wed, 14 Mar 2007 17:48:32 +0530 Balbir Singh [EMAIL PROTECTED] wrote: Randy.Dunlap wrote: Hi, Documentation/accounting/delay-accounting.txt says that the getdelays program has a -c cmd argument, but that option does not seem to exist in Documentation/account/getdelays.c

Re: [PATCH 3/7] containers (V7): Add generic multi-subsystem API to containers

2007-02-14 Thread Balbir Singh
(callback_mutex); multiuser_container does not apply Is anybody else seeing this problem? -- Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

[RFC][PATCH][0/4] Memory controller (RSS Control)

2007-02-18 Thread Balbir Singh
Comments criticism are welcome. Series -- memctlr-setup.patch memctlr-acct.patch memctlr-reclaim-on-limit.patch memctlr-doc.patch -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED

[RFC][PATCH][1/4] RSS controller setup

2007-02-18 Thread Balbir Singh
+1,22 @@ +/* memctlr.h - Memory Controller for containers + * + * Copyright (C) Balbir Singh, IBM Corp. 2006-2007 + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2.1 of the GNU Lesser General Public License + * as published by the Free

[RFC][PATCH][2/4] Add RSS accounting and control

2007-02-18 Thread Balbir Singh
))); page_add_anon_rmap(page, vma, addr); + memctlr_update_rss(vma-vm_mm, 1, MEMCTLR_DONT_CHECK_LIMIT); swap_free(entry); /* * Move the page to the active list so it is not _ -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line

[RFC][PATCH][3/4] Add reclaim support

2007-02-18 Thread Balbir Singh
changed to run anywhere: as the first one comes back, _ -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

[RFC][PATCH][4/4] RSS controller documentation

2007-02-18 Thread Balbir Singh
control. It is planned to add +the following components + +1. Page Cache control +2. mlock'ed memory control +3. kernel memory allocation control (memory allocated on behalf of a task) _ -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [RFC][PATCH][0/4] Memory controller (RSS Control)

2007-02-19 Thread Balbir Singh
Andrew Morton wrote: On Mon, 19 Feb 2007 12:20:19 +0530 Balbir Singh [EMAIL PROTECTED] wrote: This patch applies on top of Paul Menage's container patches (V7) posted at http://lkml.org/lkml/2007/2/12/88 It implements a controller within the containers framework for limiting memory

Re: [RFC][PATCH][1/4] RSS controller setup

2007-02-19 Thread Balbir Singh
Andrew Morton wrote: On Mon, 19 Feb 2007 12:20:26 +0530 Balbir Singh [EMAIL PROTECTED] wrote: This patch sets up the basic controller infrastructure on top of the containers infrastructure. Two files are provided for monitoring and control memctlr_usage and memctlr_limit. The patches use

Re: [ckrm-tech] [RFC][PATCH][0/4] Memory controller (RSS Control)

2007-02-19 Thread Balbir Singh
, that's a problem, but I think it's a problem that can be solved in steps. First step, add reclaim. Second step, optimize reclaim. -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [ckrm-tech] [RFC][PATCH][2/4] Add RSS accounting and control

2007-02-19 Thread Balbir Singh
Andrew Morton wrote: On Mon, 19 Feb 2007 12:20:34 +0530 Balbir Singh [EMAIL PROTECTED] wrote: This patch adds the basic accounting hooks to account for pages allocated into the RSS of a process. Accounting is maintained at two levels, in the mm_struct of each task and in the memory controller

Re: [RFC][PATCH][0/4] Memory controller (RSS Control)

2007-02-19 Thread Balbir Singh
useful for the page cache controller 2. Check if the page belongs to a particular container before the list_del(page-lru), so that those pages can be skipped. 3. Use a double LRU list by overloading the lru list_head of struct page. Paul -- Warm Regards, Balbir Singh

Re: [RFC][PATCH][0/4] Memory controller (RSS Control)

2007-02-19 Thread Balbir Singh
Magnus Damm wrote: On 2/19/07, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 19 Feb 2007 12:20:19 +0530 Balbir Singh [EMAIL PROTECTED] wrote: This patch applies on top of Paul Menage's container patches (V7) posted at http://lkml.org/lkml/2007/2/12/88 It implements a controller

Re: [RFC][PATCH][3/4] Add reclaim support

2007-02-19 Thread Balbir Singh
Andrew Morton wrote: On Mon, 19 Feb 2007 12:20:42 +0530 Balbir Singh [EMAIL PROTECTED] wrote: This patch reclaims pages from a container when the container limit is hit. The executable is oom'ed only when the container it is running in, is overlimit and we could not reclaim any pages belonging

Re: [RFC][PATCH][3/4] Add reclaim support

2007-02-19 Thread Balbir Singh
KAMEZAWA Hiroyuki wrote: On Mon, 19 Feb 2007 12:20:42 +0530 Balbir Singh [EMAIL PROTECTED] wrote: +int memctlr_mm_overlimit(struct mm_struct *mm, void *sc_cont) +{ + struct container *cont; + struct memctlr *mem; + long usage, limit; + int ret = 1

Re: [ckrm-tech] [RFC][PATCH][2/4] Add RSS accounting and control

2007-02-19 Thread Balbir Singh
Andrew Morton wrote: On Mon, 19 Feb 2007 16:07:44 +0530 Balbir Singh [EMAIL PROTECTED] wrote: +void memctlr_mm_free(struct mm_struct *mm) +{ + kfree(mm-counter); +} + +static inline void memctlr_mm_assign_container_direct(struct mm_struct *mm

Re: [RFC][PATCH][1/4] RSS controller setup

2007-02-19 Thread Balbir Singh
methods. It should be easy to add container_remove_file() instead of marking an error. Paul -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [RFC][PATCH][3/4] Add reclaim support

2007-02-19 Thread Balbir Singh
Andrew Morton wrote: On Mon, 19 Feb 2007 16:20:53 +0530 Balbir Singh [EMAIL PROTECTED] wrote: + * so, is the container over it's limit. Returns 1 if the container is above + * its limit. + */ +int memctlr_mm_overlimit(struct mm_struct *mm, void *sc_cont) +{ + struct container *cont

Re: [ckrm-tech] [RFC][PATCH][2/4] Add RSS accounting and control

2007-02-19 Thread Balbir Singh
Andrew Morton wrote: On Mon, 19 Feb 2007 16:39:33 +0530 Balbir Singh [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Mon, 19 Feb 2007 16:07:44 +0530 Balbir Singh [EMAIL PROTECTED] wrote: +void memctlr_mm_free(struct mm_struct *mm) +{ + kfree(mm-counter); +} + +static inline void

Re: [RFC][PATCH][0/4] Memory controller (RSS Control)

2007-02-19 Thread Balbir Singh
Magnus Damm wrote: On 2/19/07, Balbir Singh [EMAIL PROTECTED] wrote: Magnus Damm wrote: On 2/19/07, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 19 Feb 2007 12:20:19 +0530 Balbir Singh [EMAIL PROTECTED] wrote: This patch applies on top of Paul Menage's container patches (V7) posted

Re: taskstats accounting info

2007-03-20 Thread Balbir Singh
of: ./getdelays: invalid option -- h Unknown option 63 (or just remove that message) 3. -v does not use an optarg, so remove ':' in getopt string after 'v'; Thanks, these look good. I'll add them to my local copy. -- Warm Regards, Balbir Singh Linux Technology Center

Re: Linux-VServer example results for sharing vs. separate mappings ...

2007-03-25 Thread Balbir Singh
to listen to the maintainers when they talk of design ;) -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] Fix race between attach_task and cpuset_exit

2007-03-25 Thread Balbir Singh
, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: Linux-VServer example results for sharing vs. separate mappings ...

2007-03-25 Thread Balbir Singh
to the reclaim logic, we hope to integrate a page cache controller soon. We are also testing the patches. Hopefully soon enough, they'll be in a good state and we can request you to merge the containers and the rss limit (plus page cache) controller soon. -- Warm Regards, Balbir Singh

Re: Linux-VServer example results for sharing vs. separate mappings ...

2007-03-25 Thread Balbir Singh
Andrew Morton wrote: On Mon, 26 Mar 2007 08:06:07 +0530 Balbir Singh [EMAIL PROTECTED] wrote: Andrew Morton wrote: Don't we break the global LRU with this scheme? Sure, but that's deliberate! (And we don't have a global LRU - the LRUs are per-zone). Yes, true. But if we use zones

Re: [PATCH] Cpu statistics accounting based on Paul Menage patches

2007-04-12 Thread Balbir Singh
the same general mechanism for data communication to user space. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [ckrm-tech] [RFC][PATCH][2/4] Add RSS accounting and control

2007-02-19 Thread Balbir Singh
Paul Menage wrote: On 2/19/07, Balbir Singh [EMAIL PROTECTED] wrote: More worrisome is the potential for use-after-free. What prevents the pointer at mm-container from referring to freed memory after we're dropped the lock? The container cannot be freed unless all tasks holding references

Re: [ckrm-tech] [RFC][PATCH][2/4] Add RSS accounting and control

2007-02-19 Thread Balbir Singh
Vaidyanathan Srinivasan wrote: Balbir Singh wrote: Paul Menage wrote: On 2/19/07, Balbir Singh [EMAIL PROTECTED] wrote: More worrisome is the potential for use-after-free. What prevents the pointer at mm-container from referring to freed memory after we're dropped the lock? The container

[RFC][PATCH][0/4] Memory controller (RSS Control) (

2007-02-24 Thread Balbir Singh
Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[RFC][PATCH][1/4] RSS controller setup (

2007-02-24 Thread Balbir Singh
, 2006-2007 + * + * Author: Balbir Singh [EMAIL PROTECTED] + * + */ + +#ifndef _LINUX_MEMCONTROL_H +#define _LINUX_MEMCONTROL_H + +#ifdef CONFIG_CONTAINER_MEMCONTROL +#ifndef kB +#define kB 1024/* One Kilo Byte */ +#endif + +#else /* CONFIG_CONTAINER_MEMCONTROL */ + +#endif

[RFC][PATCH][2/4] Add RSS accounting and control (

2007-02-24 Thread Balbir Singh
to the active list so it is not _ -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

[RFC][PATCH][3/4] Add reclaim support (

2007-02-24 Thread Balbir Singh
lists and reinitialise the emptied list. * @list: the new list to add. _ -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

[RFC][PATCH][4/4] RSS controller documentation (

2007-02-24 Thread Balbir Singh
RSS control. It is planned to add +the following components + +1. Page Cache control +2. mlock'ed memory control +3. kernel memory allocation control (memory allocated on behalf of a task) _ -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe

Memcontrol patchset (was Re: [RFC][PATCH][0/4] Memory controller (RSS Control) ()

2007-02-24 Thread Balbir Singh
Hi, My script could not parse the (#2) and posted the patches as subject followed by ( instead I apologize, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[RFC][PATCH][1/4] RSS controller setup (v2)

2007-02-25 Thread Balbir Singh
, 2006-2007 + * + * Author: Balbir Singh [EMAIL PROTECTED] + * + */ + +#ifndef _LINUX_MEMCONTROL_H +#define _LINUX_MEMCONTROL_H + +#ifdef CONFIG_CONTAINER_MEMCONTROL +#ifndef kB +#define kB 1024/* One Kilo Byte */ +#endif + +#else /* CONFIG_CONTAINER_MEMCONTROL */ + +#endif

[RFC][PATCH][4/4] RSS controller documentation (v2)

2007-02-25 Thread Balbir Singh
RSS control. It is planned to add +the following components + +1. Page Cache control +2. mlock'ed memory control +3. kernel memory allocation control (memory allocated on behalf of a task) _ -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe

[RFC][PATCH][3/4] Add reclaim support (v2)

2007-02-25 Thread Balbir Singh
lists and reinitialise the emptied list. * @list: the new list to add. _ -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

[RFC][PATCH][0/4] Memory controller (RSS Control) (v2)

2007-02-25 Thread Balbir Singh
criticism are welcome. Series -- memcontrol-setup.patch memcontrol-acct.patch memcontrol-reclaim-on-limit.patch memcontrol-doc.patch -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED

[RFC][PATCH][2/4] Add RSS accounting and control (v2)

2007-02-25 Thread Balbir Singh
to the active list so it is not _ -- Warm Regards, Balbir Singh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: The performance and behaviour of the anti-fragmentation related patches

2007-03-01 Thread Balbir Singh
is very easy (with minimal changes to the core mm), supplemented with an efficient per-container reclaimer, it should be easy to implement a good per-container RSS controller. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from

Re: The performance and behaviour of the anti-fragmentation related patches

2007-03-01 Thread Balbir Singh
. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: The performance and behaviour of the anti-fragmentation related patches

2007-03-01 Thread Balbir Singh
Linus Torvalds wrote: On Fri, 2 Mar 2007, Balbir Singh wrote: My personal opinion is that while I'm not a huge fan of virtualization, these kinds of things really _can_ be handled more cleanly at that layer, and not in the kernel at all. Afaik, it's what IBM already does, and has been doing

Re: [ckrm-tech] [PATCH 1/2] rcfs core patch

2007-03-01 Thread Balbir Singh
|1 linux-2.6.20-vatsa/kernel/Makefile |1 --- The diffstat does not look quite right. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] [RSDL 1/6] lists: add list splice tail

2007-03-04 Thread Balbir Singh
Con Kolivas wrote: Add a list_splice_tail variant of list_splice. Patch-by: Peter Zijlstra [EMAIL PROTECTED] Signed-off-by: Con Kolivas [EMAIL PROTECTED] Acked-by: Balbir Singh [EMAIL PROTECTED] I had the same exact patch in my memcontrol at http://lkml.org/lkml/2007/2/24/68 (see the last

Re: [RFC][PATCH 1/7] Resource counters

2007-03-06 Thread Balbir Singh
? -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [RFC][PATCH 2/7] RSS controller core

2007-03-06 Thread Balbir Singh
, +}; + +void __init container_rss_init_early(void) +{ + container_register_subsys(rss_subsys); + init_mm.rss_container = rss_from_cont( + task_container(init_task, rss_subsys)); + css_get_current(init_mm.rss_container-css); +} -- Warm Regards, Balbir

Re: [RFC][PATCH 0/7] Resource controllers based on process containers

2007-03-06 Thread Balbir Singh
to compile without patch 5 applied. Patch 1 failed to apply with a reject in kernel/Makefile I applied it on top of 2.6.20 with all of Paul Menage's patches (all 7). -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send

Re: controlling mmap()'d vs read/write() pages

2007-03-28 Thread Balbir Singh
. Without page cache control, we could end up with too many pages moving over to the swap cache and still occupying memory, while the original intension was to avoid this scenario. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from

Re: Linux 2.6.24-rc7 Build-Failure at __you_cannot_kmalloc_that_much

2008-01-08 Thread Balbir Singh
was not being eliminated (__you_cannot_kmalloc_that_much), even though no one called that function. I suspect builtin_constant_p() and dead code elimination as the root causes of this error. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL

Re: [LTP] Container Code Coverage for 2.6.23 mainline kernel

2008-01-09 Thread Balbir Singh
On Jan 9, 2008 12:52 PM, Rishikesh K. Rajak [EMAIL PROTECTED] wrote: Hi All, You can find the code coverage data for container code which has been merged with mainline linux-2.6.23 and respective testcases are merged with ltp for the feature called SYSVIPC NAMESPACE UTS NAMESPACE . I

Re: [LTP] Container Code Coverage for 2.6.23 mainline kernel

2008-01-09 Thread Balbir Singh
On Jan 9, 2008 2:45 PM, Subrata Modak [EMAIL PROTECTED] wrote: On Wed, 2008-01-09 at 14:38 +0530, Balbir Singh wrote: On Jan 9, 2008 12:52 PM, Rishikesh K. Rajak [EMAIL PROTECTED] wrote: Hi All, You can find the code coverage data for container code which has been merged

Re: [patch 05/19] split LRU lists into anon file sets

2008-01-09 Thread Balbir Singh
on the node's zone LRU need not be active in the memory cgroup. ANON - FILE attribute can be changed dinamically (after added to LRU) ? If no, using page_file_cache(pc-page) will be easy. Thanks, -Kame -- Warm Regards, Balbir Singh Linux Technology Center IBM

Re: [patch 05/19] split LRU lists into anon file sets

2008-01-09 Thread Balbir Singh
* KAMEZAWA Hiroyuki [EMAIL PROTECTED] [2008-01-10 11:36:18]: On Thu, 10 Jan 2008 07:51:33 +0530 Balbir Singh [EMAIL PROTECTED] wrote: #define PAGE_CGROUP_FLAG_CACHE (0x1) /* charged as cache */ #define PAGE_CGROUP_FLAG_ACTIVE (0x2) /* page is active in this cgroup

Re: [patch 00/19] VM pageout scalability improvements

2008-01-11 Thread Balbir Singh
(NR_INACTIVE_FILE); -} - /* * Try to free `nr_pages' of memory, system-wide, and return the number of * freed pages. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [patch 00/19] VM pageout scalability improvements

2008-01-11 Thread Balbir Singh
or a child Killed process 6593 (pagetest) I am using a powerpc box with 64K size pages. I'll try and investigate further, just a heads up on the failure I am seeing. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send

Re: [RFC][PATCH] per-task I/O throttling

2008-01-11 Thread Balbir Singh
On Jan 11, 2008 4:15 AM, Andrea Righi [EMAIL PROTECTED] wrote: Allow to limit the bandwidth of I/O-intensive processes, like backup tools running in background, large files copy, checksums on huge files, etc. This kind of processes can noticeably impact the system responsiveness for some

Re: [patch 18/19] account mlocked pages

2008-01-11 Thread Balbir Singh
* Rik van Riel [EMAIL PROTECTED] [2008-01-08 15:59:57]: The following patch is required to compile the code with CONFIG_NORECLAIM enabled and CONFIG_NORECLAIM_MLOCK disabled. Signed-off-by: Balbir Singh [EMAIL PROTECTED] diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index c8ccf8f

Re: [RFC][PATCH] per-task I/O throttling

2008-01-12 Thread Balbir Singh
with seeks or data, it might be what CFQ does, but I've never even read the code. So far the definition of I/O bandwidth has been w.r.t time. Not all IO devices have sectors; I'd prefer bytes over a period of time. -- Warm Regards, Balbir Singh Linux Technology Center

Re: [PATCH] Assign IRQs to HPET Timers

2008-01-12 Thread Balbir Singh
Tn_FSB_EN_CNF_MASK (0x4000UL) The patch looks good overall! -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [RFC][PATCH] per-task I/O throttling

2008-01-12 Thread Balbir Singh
* Andrea Righi [EMAIL PROTECTED] [2008-01-12 19:01:14]: Peter Zijlstra wrote: On Sat, 2008-01-12 at 16:27 +0530, Balbir Singh wrote: * Peter Zijlstra [EMAIL PROTECTED] [2008-01-12 10:46:37]: On Fri, 2008-01-11 at 23:57 -0500, [EMAIL PROTECTED] wrote: On Fri, 11 Jan 2008 17:32:49 +0100

Re: [PATCH] Re: Kernel Panic - 2.6.23-rc4-mm1 ia64 - was Re: Update: [Automatic] NUMA replicated pagecache ...

2007-09-12 Thread Balbir Singh
, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Memory shortage can result in inconsistent flocks state

2007-09-13 Thread Balbir Singh
On 9/13/07, Pavel Emelyanov [EMAIL PROTECTED] wrote: J. Bruce Fields wrote: On Tue, Sep 11, 2007 at 04:38:13PM +0400, Pavel Emelyanov wrote: This is a known feature that such re-locking is not atomic, but in the racy case the file should stay locked (although by some other process), but

Re: cpuset trouble after hibernate

2007-09-17 Thread Balbir Singh
it's only the bus drivers and device drivers that do that now. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH mm] fix swapoff breakage; however...

2007-09-17 Thread Balbir Singh
amount by calling swapoff. } /* -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: 2.6.23-rc4-mm1 compile error for ppc 32

2007-09-17 Thread Balbir Singh
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH] Configurable reclaim batch size

2007-09-17 Thread Balbir Singh
heard AIM7 come up often, but never been able to push it much. I should retry. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH mm] fix swapoff breakage; however...

2007-09-17 Thread Balbir Singh
Hugh Dickins wrote: On Tue, 18 Sep 2007, Balbir Singh wrote: Hugh Dickins wrote: More fundamentally, it looks like any container brought over its limit in unuse_pte will abort swapoff: that doesn't doesn't seem contained to me. Maybe unuse_pte should just let containers go over their limits

Re: [PATCH mm] fix swapoff breakage; however...

2007-09-17 Thread Balbir Singh
Hugh Dickins wrote: On Tue, 18 Sep 2007, Balbir Singh wrote: Hugh Dickins wrote: What would make sense is (what I meant when I said swap counted along with RSS) not to count pages out and back in as they are go out to swap and back in, just keep count of instantiated pages I am not sure how

Re: 2.6.23-rc6-mm1 panic (memory controller issue ?)

2007-09-18 Thread Balbir Singh
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: 2.6.23-rc6-mm1 panic (memory controller issue ?)

2007-09-19 Thread Balbir Singh
Christoph Lameter wrote: On Wed, 19 Sep 2007, Balbir Singh wrote: The fix looks correct, radix_tree_preload() does the same thing in add_to_page_cache(). Thanks for identifying the fix Hmmm Radix tree preload can only take a limited set of flags? Yes, the whole code is very

Re: 2.6.23-rc6-mm1 panic (memory controller issue ?)

2007-09-19 Thread Balbir Singh
Christoph Lameter wrote: On Wed, 19 Sep 2007, Balbir Singh wrote: Yes, the whole code is very interesting. From add_to_page_cache() we call radix_tree_preload with __GFP_HIGHMEM cleared, but from __add_to_swap_cache(), we don't make any changes to the gfp_mask. radix_tree_preload() calls

Re: Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v5)

2007-09-20 Thread Balbir Singh
and test queue (which has gotten rather long of late). I'll test it further and get back. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v5)

2007-09-20 Thread Balbir Singh
, I see, removing the memcpy is definitely wrong. Thanks for catching it. I did not get a chance to review the patch, it's on my review queue, but since you've reviewed it, I am very glad that you have and identified potential issues. Big Thanks! -- Balbir Singh Linux Technology

Re: Revert for cgroups CPU accounting subsystem patch

2007-11-12 Thread Balbir Singh
for monitoring. cpu_acct fills this gap. I think in the long run, we should move the helper functions into cpu_acct.c and the interface logic into kernel/sched.c (cpu controller). -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list

Re: top lies ?

2007-11-12 Thread Balbir Singh
On Nov 13, 2007 12:38 PM, Al Boldi [EMAIL PROTECTED] wrote: kloczek wrote: Some data showed by top command looks like completly trashed. Fragment from top output: Mem: 2075784k total, 2053352k used,22432k free,19260k buffers Swap: 2096472k total, 136k used, 2096336k

Re: Revert for cgroups CPU accounting subsystem patch

2007-11-12 Thread Balbir Singh
Paul Menage wrote: On Nov 12, 2007 11:00 PM, Balbir Singh [EMAIL PROTECTED] wrote: Right now, one of the limitations of the CPU controller is that the moment you create another control group, the bandwidth gets divided by the default number of shares. We can't create groups just

Re: [PATCH 0/2] memcgroup: work better with tmpfs

2007-12-18 Thread Balbir Singh
in free_hot_cold_page() Hugh Thanks for the detailed review and fixes. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page

2007-12-18 Thread Balbir Singh
Based on the recommendation and observations of Hugh Dickins, page_cgroup_assign_cgroup() is not required. This patch replaces it with a VM_BUG_ON, so that we can catch them in free_hot_cold_page() Signed-off-by: Balbir Singh [EMAIL PROTECTED] --- mm/page_alloc.c |2 +- 1 file changed, 1

[PATCH] Memory controller use rcu_read_lock() in mem_cgroup_cache_charge()

2007-12-20 Thread Balbir Singh
Hugh Dickins noticed that we were using rcu_dereference() without rcu_read_lock() in the cache charging routine. The patch below fixes this problem Signed-off-by: Balbir Singh [EMAIL PROTECTED] --- mm/memcontrol.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff -puN

Re: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page

2007-12-20 Thread Balbir Singh
corrected and do not have any objections. I was going to say the same thing, page_get_page_cgroup() does not hold any references. May be _get_ in the name is confusing. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list

  1   2   3   4   5   6   7   8   9   10   >