0530
+++ linux-2.6.22-rc6-balbir/mm/filemap.c2007-07-20 13:13:26.0
+0530
@@ -445,7 +445,7 @@ int add_to_page_cache(struct page *page,
if (error == 0) {
- error = mem_container_charge(page, current->mm);
+ error = mem_container_cache_charge(page, cur
Paul Menage wrote:
> On 7/20/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>> +
>> +ssize_t res_counter_read(struct res_counter *counter, int member,
>> + const char __user *userbuf, size_t nbytes, loff_t *pos)
>> +{
>> + unsigned
Paul Menage wrote:
> On 7/20/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>>
>> +config CONTAINER_MEM_CONT
>> + bool "Memory controller for containers"
>> + select CONTAINERS
>
> Andrew asked me to not use "select" in Kconfi
Paul Menage wrote:
> On 7/20/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>
>> +void __always_inline unlock_meta_page(struct page *page)
>> +{
>> + bit_spin_unlock(PG_metapage, &page->flags);
>> +}
>
> Maybe add a BUG_ON(!test_bit(PG_me
> index 24c5aad..0ccfeae 100644
> --- a/Documentation/accounting/getdelays.c
> +++ b/Documentation/accounting/getdelays.c
> @@ -21,7 +21,6 @@
> #include
> #include
> #include
> -#include
> #include
>
> #include
Looks good!
Acked-by: Balbir Singh <[EMAI
s not acceptable. I don't like the bit
hacking for flags and moving counters to the stack either.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
; - what prevents mem_container_uncharge from freeing this meta_page
> behind us?
>
> YAMAMOTO Takashi
Hi, YAMAMOTO,
We do take the lru_lock before deleting the page from the list
and in mem_container_move_lists(). But, I guess like you point
out page = mp->page might not be a s
-by: Balbir Singh <[EMAIL PROTECTED]>
---
Documentation/controllers/memory.txt |7 +++--
include/linux/res_counter.h |6 ++--
kernel/res_counter.c | 24 +
mm/memcontrol.c | 47 +++
4
rn and useful way of describing the fs. Path to mountpoint or
> something?
>
> I suspect the namespace virtualisation guys would be interested in a new
> interface which is sending current->user->uid up to userspace. uids are
> per-namespace now. What are the implications? (cc&
Paul Menage wrote:
> On 8/29/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>> Change the interface to use kilobytes instead of pages. Page sizes can vary
>> across platforms and configurations. A new strategy routine has been added
>> to the resource counters infrastru
Dave Hansen wrote:
> On Wed, 2007-08-29 at 16:40 +0530, Balbir Singh wrote:
>>
>> @@ -352,7 +353,7 @@ int mem_container_charge(struct page *pa
>> kfree(pc);
>> pc = race_pc;
>> atomic_inc(&pc->ref_cnt);
>
Dave Hansen wrote:
> On Thu, 2007-08-30 at 03:34 +0530, Balbir Singh wrote:
>> I've thought about this before. The problem is that a user could
>> set his limit to 1 bytes, but would then see the usage and
>> limit round to the closest page boundary. This can
re it internally without truncation/
rounding is something we need to agree upon. We also need to see
how to display the data back to the user.
I chose kilobytes for two reasons
1. Several people recommended it
2. Herbert mentioned that they've moved to that interface and it
was working fin
Dave Hansen wrote:
> On Thu, 2007-08-30 at 03:57 +0530, Balbir Singh wrote:
>> True, mmap() is a good example of such an interface for developers, I
>> am not sure about system admins though.
>>
>> To quote Andrew
>>
>> Reporting tools could run getp
KAMEZAWA Hiroyuki wrote:
> On Thu, 30 Aug 2007 04:07:11 +0530
> Balbir Singh <[EMAIL PROTECTED]> wrote:
>> 1. Several people recommended it
>> 2. Herbert mentioned that they've moved to that interface and it
>>was working fine for them.
>>
>
&g
a UML setup with the config for memory control enabled.
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
---
Documentation/controllers/memory.txt | 22 +-
include/linux/res_counter.h | 10 +++---
kernel/res_counter.c | 30 +
Balbir Singh wrote:
> Change the interface to use kilobytes instead of pages. Page sizes can vary
> across platforms and configurations. A new strategy routine has been added
> to the resource counters infrastructure to format the data as desired.
>
Typo, the description should be
C
andle the notification and take
>> action (especially for containers). We already have containerstats for
>> containers (which I was planning to reuse), but I was told that we would
>> be interested in user space OOM notifications in general.
> Generic netlink can be used to pas
time;
>
> where
>
> do_posix_clock_monotonic_gettime(&uptime);
> ts = uptime - tsk->start_time;
> p->ac_btime = get_seconds() - ts.tv_sec;
> = xtime.tv_sec - (uptime - tsk->start_time);
> = (xtime.tv_sec - uptime) + tsk-&g
On 9/1/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Fri, 31 Aug 2007 00:22:46 +0530
> Balbir Singh <[EMAIL PROTECTED]> wrote:
>
> > +/*
> > + * Strategy routines for formating read/write data
> > + */
> > +int mem_container_re
e has been added
to the resource counters infrastructure to format the data as desired.
Suggested by David Rientjes, Andrew Morton and Herbert Poetzl
Tested on a UML setup with the config for memory control enabled.
---
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
---
Documentation/contro
Paul Menage wrote:
> On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>> - s += sprintf(s, "%lu\n", *val);
>> + if (read_strategy)
>> + s += read_strategy(*val, s);
>> + else
>> + s += sprintf(s,
Paul Menage wrote:
> On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>> - s += sprintf(s, "%lu\n", *val);
>> + if (read_strategy)
>> + s += read_strategy(*val, s);
>> + else
>> + s += sprintf(s,
Paul Menage wrote:
> On 9/3/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>> Paul Menage wrote:
>>> On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>>>> - s += sprintf(s, "%lu\n", *val);
>>>> + if (read_strategy)
>
t mm_s
> if (!page)
> goto oom;
>
> - if (mem_container_charge(page, mm))
> - goto oom_free_page;
> + if (mem_container_charge(page, mm))
> + goto oom_free_page;
>
> entry = mk_pte(page, vma->vm_p
and configurations. A new strategy routine has been added
to the resource counters infrastructure to format the data as desired.
Suggested by David Rientjes, Andrew Morton and Herbert Poetzl
Tested on a UML setup with the config for memory control enabled.
Signed-off-by: Balbir Singh <[EMAIL PRO
On Sun, Sep 02, 2007 at 09:53:22PM -0700, Paul Menage wrote:
> On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
> > - s += sprintf(s, "%lu\n", *val);
> > + if (read_strategy)
> > + s += read_strategy(*val, s);
> > + else
struct mem_container, css);
}
+inline struct mem_container *mm_container(struct mm_struct *mm)
+{
+ return rcu_dereference(mm->mem_container);
+}
+
void mm_init_container(struct mm_struct *mm, struct task_struct *p)
{
struct mem_container *mem;
_
--
Warm Regar
te,
.destroy = mem_container_destroy,
.populate = mem_container_populate,
+ .attach = mem_container_move_task,
.early_init = 1,
};
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the li
ration, 2007
* Author Balbir Singh <[EMAIL PROTECTED]>
*
+ * Copyright 2007 OpenVZ SWsoft Inc
+ * Author: Pavel Emelianov <[EMAIL PROTECTED]>
+ *
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published
buf[nbytes] = '\0';
+ ret = -EFAULT;
+ if (copy_from_user(buf, userbuf, nbytes))
+ goto out_free;
+
+ ret = -EINVAL;
+ tmp = simple_strtoul(buf, &end, 10);
+ if (*end != '\0')
+ goto out_free;
+
+ val
ing-setup.patch
mem-control-accounting.patch
mem-control-task-migration.patch
mem-control-lru-and-reclaim.patch
mem-control-out-of-memory.patch
mem-control-choose-rss-vs-rss-and-pagecache.patch
mem-control-per-container-page-referenced.patch
--
Warm Regards,
Balbir Singh
01:12:49.0 +0530
@@ -0,0 +1,21 @@
+/* memcontrol.h - Memory Controller
+ *
+ * Copyright IBM Corporation, 2007
+ * Author Balbir Singh <[EMAIL PROTECTED]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Publi
write_unlock_irq(&swapper_space.tree_lock);
radix_tree_preload_end();
}
+out:
return error;
}
@@ -129,6 +138,7 @@ void __delete_from_swap_cache(struct pag
BUG_ON(PageWriteback(page));
BUG_ON(PagePrivate(page));
+ mem_container_uncharge_page(page);
.isolate_pages = mem_container_isolate_pages,
+ };
+ int node;
+ struct zone **zones;
+
+ for_each_online_node(node) {
+ zones = NODE_DATA(node)->node_zonelists[ZONE_USERPAGES].zones;
+ if (do_try_to_free_pages(zones, sc.gfp_mask, &s
error = mem_container_cache_charge(page, current->mm);
if (error)
goto out;
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
_process(&points, NULL);
if (PTR_ERR(p) == -1UL)
goto out;
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTE
ong pages, int c
>
> /* Don't let a single process grow too big:
>leave 3% of the size of this process for other processes */
> - allowed -= current->mm->total_vm / 32;
> + if (current->mm)
> + allowed -= current->mm-&
Andrew Morton wrote:
> On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote:
>
>> On 8/11/07, Fengguang Wu <[EMAIL PROTECTED]> wrote:
>
> hm, both people who replied to this removed Fengguang from cc. Disagreement
> between head
WU Fengguang wrote:
> On Sun, Aug 12, 2007 at 01:48:31PM +0800, WU Fengguang wrote:
>> On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote:
>>> Andrew Morton wrote:
>>>> On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]>
&
> it seems that nothing distinguishes it from MEM_CONTAINER_TYPE_MAPPED.
>
The important types are currently MEM_CONTAINER_TYPE_MAPPED and
MEM_CONTAINER_TYPE_ALL.
I added the types for future use (may be for finer accounting of types, later).
> YAMAMOTO Takashi
--
Warm Reg
);
>> +if (mem->control_type == MEM_CONTAINER_TYPE_ALL)
>> +return mem_container_charge(page, mm);
>> +else
>> +return 0;
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe fr
atch
mem-control-per-container-page-referenced.patch
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vg
buf[nbytes] = '\0';
+ ret = -EFAULT;
+ if (copy_from_user(buf, userbuf, nbytes))
+ goto out_free;
+
+ ret = -EINVAL;
+ tmp = simple_strtoul(buf, &end, 10);
+ if (*end != '\0')
+ goto out_free;
+
+ val
23:06:11.0 +0530
@@ -0,0 +1,21 @@
+/* memcontrol.h - Memory Controller
+ *
+ * Copyright IBM Corporation, 2007
+ * Author Balbir Singh <[EMAIL PROTECTED]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Publi
-13
23:06:11.0 +0530
@@ -3,6 +3,9 @@
* Copyright IBM Corporation, 2007
* Author Balbir Singh <[EMAIL PROTECTED]>
*
+ * Copyright 2007 OpenVZ SWsoft Inc
+ * Author: Pavel Emelianov <[EMAIL PROTECTED]>
+ *
* This program is free software; you can redistribute it and/or modif
te,
.destroy = mem_container_destroy,
.populate = mem_container_populate,
+ .attach = mem_container_move_task,
.early_init = 1,
};
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the li
radix_tree_preload_end();
}
+out:
return error;
}
@@ -129,6 +138,7 @@ void __delete_from_swap_cache(struct pag
BUG_ON(PageWriteback(page));
BUG_ON(PagePrivate(page));
+ mem_container_uncharge_page(page);
radix_tree_delete(&swapper_space.page_tree, page_private(page));
set_page_private(page, 0);
ClearPageSwapCache(page);
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
))
+ return 1;
+ }
+ return 0;
+}
+#endif
+
/*
* For kswapd, balance_pgdat() will work across all this node's zones until
* they are all at pages_high.
@@ -1250,6 +1324,8 @@ static unsigned long balance_pgdat(pg_da
.swap_cluster_max = SWAP_CLUSTER_MAX,
.swappiness = vm_swappiness,
.order = order,
+ .mem_container = NULL,
+ .isolate_pages = isolate_pages_global,
};
/*
* temp_priority is used to remember the scanning priority at which
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
_process(&points, NULL);
if (PTR_ERR(p) == -1UL)
goto out;
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTE
_state.c 2007-08-13 23:06:12.0
+0530
@@ -81,7 +81,7 @@ static int __add_to_swap_cache(struct pa
error = radix_tree_preload(gfp_mask);
if (!error) {
- error = mem_container_charge(page, current->mm);
+ error = mem_container_cache_charge(page, curre
struct mem_container, css);
}
+inline struct mem_container *mm_container(struct mm_struct *mm)
+{
+ return rcu_dereference(mm->mem_container);
+}
+
void mm_init_container(struct mm_struct *mm, struct task_struct *p)
{
struct mem_container *mem;
_
--
Warm Regar
t; 10,
> +(unsigned long)(mss->pss >> 22),
> sarg.mss.shared_clean >> 10,
> sarg.mss.shared_dirty >> 10,
> sarg.mss.private_clean >> 10,
> sarg.mss.private_dirty >>
I keep forgetting to check that you are on the cc. My email client
loves dropping you from the to/cc list.
Original Message
Subject: Re: [PATCH] PSS(proportional set size) accounting in smaps
Date: Tue, 14 Aug 2007 10:56:12 +0530
From: Balbir Singh <[EMAIL PROTECTED]>
Re
%15s%15s\n"
> -" %15llu%15llu\n"
> +" %15llu%15llu\n",
> "count", "real total", "virtual total", "delay total",
> t->cpu_count, t->cpu_run_real_t
}
> na = (struct nlattr *) (GENLMSG_DATA(&msg) + len);
> }
> + sleep(2);
Is this really required? a sleep() in the code. Why do we do multiple
send_cmd()'s
in the do loop? I'll test and get back.
> } while (loop);
> done:
&
>ioac.cancelled_write_bytes;
> -#else
> - stats->read_bytes = 0;
> - stats->write_bytes = 0;
> - stats->cancelled_write_bytes = 0;
> + stats->read_bytes += p->ioac.read_bytes;
> + stats->write_bytes += p->ioac.write_bytes;
> + stats
>>> i think you need css_put here.
>> Thats correct. We do need css_put in this path.
>>
>> Thanks,
>> Vaidy
>
> v5 still seems to have the problem.
>
> YAMAMOTO Takashi
>
Hi,
I've got the fix in v6 now, thanks for spotting it.
--
Wa
sleep 2
./getdelays -p 1 -d
done
I guess your changes change getdelays and since there are other ways
to obtaining the same data, I'd remove the last bit of changes made
to send the TGID often to get data.
> Mikey
>
>
--
Warm Regards,
Balbir Si
; t->cpu_count, t->cpu_run_real_total, t->cpu_run_virtual_total,
> t->cpu_delay_total,
This is exactly what Maxim had sent as well.
Acked-by: Balbir Singh <[EMAIL PROTECTED]>
--
Warm Regards,
Balbir Singh
Linux Technology Ce
t_add_tsk(struct taskstats *sta
> rcu_read_unlock();
> stats->ac_utime = cputime_to_msecs(tsk->utime) * USEC_PER_MSEC;
> stats->ac_stime = cputime_to_msecs(tsk->stime) * USEC_PER_MSEC;
> + stats->ac_utimescaled =
> + cputime_to_msecs(tsk-&g
include/asm-powerpc/paca.h
> +++ linux-2.6-ozlabs/include/asm-powerpc/paca.h
> @@ -103,6 +103,9 @@ struct paca_struct {
> u64 user_time; /* accumulated usermode TB ticks */
> u64 system_time;/* accumulated system TB ticks */
> u64 star
LIFO batch:0
HighMem zone: 0 pages, LIFO batch:0
[boot]0015 Setup Done
Built 1 zonelists
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.23-rc2-mm2
# Thu Aug 1
l stack on secondary CPUs when starting the
> CPU. This isn't a major problem, since an appropriate entry will
> be created on demand, but this fixes that also for consistency.
>
> Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]>
>
Thanks for p
other calls to account_(user|system)_time are in arch code.
>
So the assumption here is that we ran at full frequency during
this time, is my understanding correct?
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send
buf[nbytes] = '\0';
+ ret = -EFAULT;
+ if (copy_from_user(buf, userbuf, nbytes))
+ goto out_free;
+
+ ret = -EINVAL;
+ tmp = simple_strtoul(buf, &end, 10);
+ if (*end != '\0')
+ goto out_free;
+
+ val
te,
.destroy = mem_container_destroy,
.populate = mem_container_populate,
+ .attach = mem_container_move_task,
.early_init = 1,
};
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the li
val);
total_swapcache_pages++;
__inc_zone_page_state(page, NR_FILE_PAGES);
- }
+ } else
+ mem_container_uncharge_page(page);
+
write_unlock_irq(&swapper_space.tree_lock);
radi
13:14:19.0 +0530
@@ -0,0 +1,21 @@
+/* memcontrol.h - Memory Controller
+ *
+ * Copyright IBM Corporation, 2007
+ * Author Balbir Singh <[EMAIL PROTECTED]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Publi
d.patch
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
_process(&points, NULL);
if (PTR_ERR(p) == -1UL)
goto out;
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTE
uct mem_container, css);
}
+inline struct mem_container *mm_container(struct mm_struct *mm)
+{
+ return rcu_dereference(mm->mem_container);
+}
+
void mm_init_container(struct mm_struct *mm, struct task_struct *p)
{
struct mem_container *mem;
_
--
Warm Regards,
B
_state.c 2007-08-17 13:14:20.0
+0530
@@ -82,7 +82,7 @@ static int __add_to_swap_cache(struct pa
error = radix_tree_preload(gfp_mask);
if (!error) {
- error = mem_container_charge(page, current->mm);
+ error = mem_container_cache_charge(page, curre
&sc))
+ return 1;
+ }
+ return 0;
+}
+#endif
+
/*
* For kswapd, balance_pgdat() will work across all this node's zones until
* they are all at pages_high.
@@ -1344,6 +1418,8 @@ static unsigned long balance_pgdat(pg_da
.swap_cluster
2007-08-17
13:14:19.0 +0530
@@ -3,6 +3,9 @@
* Copyright IBM Corporation, 2007
* Author Balbir Singh <[EMAIL PROTECTED]>
*
+ * Copyright 2007 OpenVZ SWsoft Inc
+ * Author: Pavel Emelianov <[EMAIL PROTECTED]>
+ *
* This program is free software; you can redistribute it and/or m
t;> __u64 write_char; /* bytes written */
>> __u64 read_syscalls; /* read syscalls */
>> __u64 write_syscalls; /* write syscalls */
>> +
>> +/* time accounting for SMT machines */
>> +__u64 ac_utimescaled;
cgroup_opera
> static int proc_cgroupstats_show(struct seq_file *m, void *v)
> {
> int i;
> - struct cgroupfs_root *root;
>
> seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\n");
> mutex_lock(&cgroup_mutex);
>
>
t; +.read_uint = cpu_usage_read,
> +},
> };
>
> static int cpu_cgroup_populate(struct cgroup_subsys *ss, struct cgroup
> *cont)
> {
> -return cgroup_add_file(cont, ss, &cpu_shares);
> +return cgroup_add_files(cont, ss, cpu_files, ARRAY_SIZE(cpu_files));
> }
&
able to cause an rmdir to fail due
>> to a concurrent read.
>>
Well, most people who care about deletion will use the notify_on_release
callback and retry. I think we have a good mechanism in place for
deletion, so I would not worry about read delaying deletion.
--
Warm Regards
Paul Menage wrote:
> On 10/23/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>> Well, most people who care about deletion will use the notify_on_release
>> callback and retry.
>
> I'm not convinced this is true. Certainly the userspace approaches
> we're de
lt;[EMAIL PROTECTED]>
Looks good to me
Acked-by: Balbir Singh <[EMAIL PROTECTED]>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
On 10/24/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>
> The patch titled
> Fix warning in cgroup.c
> has been added to the -mm tree. Its filename is
> fixing-the-warning-in-cgroupc.patch
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> See http:/
o err;
>
> - fput_light(file, fput_needed);
> return send_reply(rep_skb, info->snd_pid);
> +err:
> + nlmsg_free(rep_skb);
> }
>
> -err:
> - if (file)
> - fput_light(file, fput_needed);
> - nlmsg_free(
r: for each function it appears in.)
make[1]: *** [arch/um/kernel/sysrq.o] Error 1
make: *** [arch/um/kernel] Error 2
Use BITS_PER_LONG == 32 instead of the hardcode __i386__ as UML depends on
this header.
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
---
include/asm-x86/ptrace-abi.h |
x27;:
init/do_mounts.h:25: error: storage size of 'stat' isn't known
init/do_mounts.h:25: warning: unused variable 'stat'
init/do_mounts.h:33: warning: control reaches end of non-void function
make[1]: *** [init/do_mounts.o] Error 1
make: *** [init/do_mounts.o] Error 2
Signed-off
Fix UML build error, include linux/scatterlist.h in arch/um/drivers/ubd_kern.c,
to resolve the definition of sg_page()
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
---
arch/um/drivers/ubd_kern.c |1 +
1 file changed, 1 insertion(+)
diff -puN arch/um/drivers/ubd_kern.c~fix-uml-ub
WANG Cong wrote:
> On Thu, Oct 25, 2007 at 05:20:20PM +0530, Balbir Singh wrote:
>>
>> Fix UML build error, include linux/scatterlist.h in
>> arch/um/drivers/ubd_kern.c,
>> to resolve the definition of sg_page()
>>
>> Signed-off-by: Balbir Singh <[EMAIL
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
---
include/asm-x86/sigcontext.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN include/asm-x86/sigcontext.h~uml-fix-sigcontext-build-error
include/asm-x86/sigcontext.h
--- 2.6.24-rc1/include/asm-x86/sigcontext
Fix build errors seen in UML. Replaces #ifdef __i386__ with
#if BITS_PER_LONG == 32
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
---
include/asm-x86/signal.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff -puN include/asm-x86/signal.h~uml-fix-sigaction
x27;:
init/do_mounts.h:25: error: storage size of 'stat' isn't known
init/do_mounts.h:25: warning: unused variable 'stat'
init/do_mounts.h:33: warning: control reaches end of non-void function
make[1]: *** [init/do_mounts.o] Error 1
make: *** [init/do_mounts.o] Error 2
Signed-off
Jeff Dike wrote:
> On Thu, Oct 25, 2007 at 06:30:22PM +0530, Balbir Singh wrote:
>> Fix build errors seen in UML.
>
> Al fixed these already.
>
> FWIW, below is a rolled-up combo patch which make 2.6.24-rc1 UML build.
>
> It includes Al's build fixes, Wang Cong
lease help me with some pointers/steps to reproduce the problem?
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More
Frans Pop wrote:
> On Tuesday 16 October 2007, Balbir Singh wrote:
>> I am trying to think out loud as to what the root cause of the problem
>> might be. In one of the discussion threads, I saw utime going backwards,
>> which seemed very odd, I suspect that those are roundin
Christian Borntraeger wrote:
> Am Dienstag, 16. Oktober 2007 schrieb Balbir Singh:
>> I am trying to think out loud as to what the root cause of the problem
>> might be. In one of the discussion threads, I saw utime going backwards,
>> which seemed very odd, I suspect th
This patch was dropped from the -mm tree and not merged back. Updated with
the name change of containerstats to cgroupstats
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
---
Documentation/accounting/getdelays.c | 43 ++-
1 file changed, 42 insertions
Fix the delay accounting regression introduced by commit
75d4ef16a6aa84f708188bada182315f80aab6fa. rq no longer has sched_info
data associated with it. task_struct sched_info structure is used by delay
accounting to provide back statistics to user space.
Signed-off-by: Balbir Singh <[EM
real total virtual totaldelay total
0 535861848 0 0
This breaks existing delay accounting behaviour.
Am I missing something?
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from
This code in mm/tiny-shmem.c is under #if 0, do we really need it? This
patch removes it.
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
---
mm/tiny-shmem.c | 12
1 file changed, 12 deletions(-)
diff -puN mm/tiny-shmem.c~remove-unused-code mm/tiny-shmem.c
--- linux-2.6-
Ingo Molnar wrote:
> * Balbir Singh <[EMAIL PROTECTED]> wrote:
>
>> Hi, Ingo,
>>
>> I missed commit 75d4ef16a6aa84f708188bada182315f80aab6fa
>> "sched: fix delay accounting performance regression"
>>
>> Without these changes, I find that
Ingo Molnar wrote:
> * Balbir Singh <[EMAIL PROTECTED]> wrote:
>
>> Fix the delay accounting regression introduced by commit
>> 75d4ef16a6aa84f708188bada182315f80aab6fa. rq no longer has sched_info
>> data associated with it. task_struct sched_info structure is u
201 - 300 of 1095 matches
Mail list logo
