Re: [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set

2017-01-12 Thread Baolin Wang
Hi, On 12 January 2017 at 16:18, Kishon Vijay Abraham I <kis...@ti.com> wrote: > Hi, > > On Thursday 12 January 2017 12:13 PM, Baolin Wang wrote: >> On 3 January 2017 at 13:54, Baolin Wang <baolin.w...@linaro.org> wrote: >>> Hi Kison and Heiko, >>>

[PATCH] usb: host: xhci: Handle the right timeout command

2016-12-02 Thread Baolin Wang
it for new current command. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- This patch is based on Lu Baolu's new fix patch: usb: xhci: fix possible wild pointer --- drivers/usb/host/xhci-ring.c | 26 +- drivers/usb/host/xhci.h |1 + 2 files chan

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-12-01 Thread Baolin Wang
On 2 December 2016 at 09:17, Lu Baolu <baolu...@linux.intel.com> wrote: > Hi, > > On 12/01/2016 04:03 PM, Baolin Wang wrote: >> On 1 December 2016 at 15:44, Lu Baolu <baolu...@linux.intel.com> wrote: >>> Hi, >>> >>> On 12/01/2016 03:35 PM, B

Re: [PATCH 1/1] usb: xhci: fix possible wild pointer

2016-12-01 Thread Baolin Wang
k. Afterward, timer function > grabs the lock and go ahead with checking and setting members > of xhci->current_cmd. > > Cc: <sta...@vger.kernel.org> # v3.16+ > Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Nice catch. I was also curious where set xhci->current_

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-12-01 Thread Baolin Wang
On 1 December 2016 at 21:28, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 01.12.2016 06:54, Baolin Wang wrote: >> >> On 30 November 2016 at 22:09, Mathias Nyman >> <mathias.ny...@linux.intel.com> wrote: >>> >>> On 30.11.2016 11:02

Re: [PATCH 4/7] time: alarmtimer: Add the tracepoints for alarmtimer

2016-11-29 Thread Baolin Wang
On 29 November 2016 at 17:12, Ingo Molnar <mi...@kernel.org> wrote: > > * Baolin Wang <baolin.w...@linaro.org> wrote: > >> On 29 November 2016 at 15:23, Ingo Molnar <mi...@kernel.org> wrote: >> > >> > * John Stultz <john.stu...@lin

[RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-11-30 Thread Baolin Wang
to halt the xHCI host in xhci_stop_endpoint_command_timeout() function. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/usb/host/xhci-mem.c | 10 +-- drivers/usb/host/xhci-ring.c | 61 +- drivers/usb/host/xhci.c |8 +- d

Re: [PATCH 4/7] time: alarmtimer: Add the tracepoints for alarmtimer

2016-11-30 Thread Baolin Wang
On 29 November 2016 at 20:06, Thomas Gleixner <t...@linutronix.de> wrote: > On Mon, 28 Nov 2016, John Stultz wrote: > >> From: Baolin Wang <baolin.w...@linaro.org> >> >> For system debugging, we sometimes want to know who sets one >> alarm timer, the

Re: [PATCH] usb: host: xhci: Handle the right timeout command

2016-12-04 Thread Baolin Wang
On 2 December 2016 at 19:21, Baolin Wang <baolin.w...@linaro.org> wrote: > If a command event is found on the event ring during an interrupt, > we need to stop the command timer with del_timer(). Since del_timer() > can fail if the timer is running and waiting on the xHCI lock, then

[PATCH 1/2] usb: host: xhci: Fix possible wild pointer when handling abort command

2016-12-05 Thread Baolin Wang
When current command was supposed to be aborted, host will free the command in handle_cmd_completion() function. But it might be still referenced by xhci->current_cmd, which need to set NULL. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- This patch is based on Lu Baolu's new

[PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-05 Thread Baolin Wang
it for new current command. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/usb/host/xhci-ring.c | 29 - drivers/usb/host/xhci.h |1 + 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/us

Re: [PATCH 4/7] time: alarmtimer: Add the tracepoints for alarmtimer

2016-11-30 Thread Baolin Wang
On 29 November 2016 at 20:06, Thomas Gleixner <t...@linutronix.de> wrote: > On Mon, 28 Nov 2016, John Stultz wrote: > >> From: Baolin Wang <baolin.w...@linaro.org> >> >> For system debugging, we sometimes want to know who sets one >> alarm timer, the

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-11-30 Thread Baolin Wang
Hi Baolu, On 1 December 2016 at 13:45, Lu Baolu <baolu...@linux.intel.com> wrote: > Hi, > > On 11/30/2016 05:02 PM, Baolin Wang wrote: >> If the hardware never responds to the stop endpoint command, the >> URBs will never be completed, and we might hang the USB subsyste

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-11-30 Thread Baolin Wang
On 1 December 2016 at 14:04, Baolin Wang <baolin.w...@linaro.org> wrote: > Hi Baolu, > > On 1 December 2016 at 13:45, Lu Baolu <baolu...@linux.intel.com> wrote: >> Hi, >> >> On 11/30/2016 05:02 PM, Baolin Wang wrote: >>> If the hardware never res

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-11-30 Thread Baolin Wang
On 1 December 2016 at 14:35, Lu Baolu <baolu...@linux.intel.com> wrote: > Hi, > > On 12/01/2016 02:04 PM, Baolin Wang wrote: >> Hi Baolu, >> >> On 1 December 2016 at 13:45, Lu Baolu <baolu...@linux.intel.com> wrote: >>> Hi, >>> >>&g

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-12-01 Thread Baolin Wang
On 1 December 2016 at 15:44, Lu Baolu <baolu...@linux.intel.com> wrote: > Hi, > > On 12/01/2016 03:35 PM, Baolin Wang wrote: >> On 1 December 2016 at 14:35, Lu Baolu <baolu...@linux.intel.com> wrote: >>> Hi, >>> >>> On 12/01/2016 02:04 PM, Bao

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-11-30 Thread Baolin Wang
On 30 November 2016 at 22:09, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 30.11.2016 11:02, Baolin Wang wrote: >> >> If the hardware never responds to the stop endpoint command, the >> URBs will never be completed, and we might hang the USB subsystem. >

Re: [PATCH 1/1] usb: xhci: fix possible wild pointer

2016-12-01 Thread Baolin Wang
On 2 December 2016 at 12:40, Lu Baolu <baolu...@linux.intel.com> wrote: > Hi, > > On 12/02/2016 12:18 PM, Baolin Wang wrote: >> On 2 December 2016 at 10:29, Lu Baolu <baolu...@linux.intel.com> wrote: >>> handle_cmd_completion() frees a command structure which m

[PATCH] extcon: Add documentation for EXTCON_CHG_USB_SLOW/FAST

2017-01-02 Thread Baolin Wang
Currently there are no documentation for EXTCON_CHG_USB_SLOW/FAST charger connector. These names don't mean much and no guide to tell users how to use it, thus try to add documentation to make them clear. Suggested-by: NeilBrown <ne...@suse.com> Signed-off-by: Baolin Wang <baolin.w...@l

Re: [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set

2017-01-02 Thread Baolin Wang
Hi Kison and Heiko, On 21 December 2016 at 16:12, Baolin Wang <baolin.w...@linaro.org> wrote: > According to the documentation, we should set the EXTCON_USB when > one SDP charger connector was reported. > > Signed-off-by: Baolin Wang <baolin.w...@linaro.org> > Review

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2017-01-02 Thread Baolin Wang
On 2 January 2017 at 22:57, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 27.12.2016 05:07, Baolin Wang wrote: >> >> Hi, >> >> On 21 December 2016 at 21:00, Mathias Nyman >> <mathias.ny...@linux.intel.com> wrote: >>> >>> On

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2017-01-03 Thread Baolin Wang
On 28 December 2016 at 20:30, Janusz Dziedzic <janusz.dzied...@gmail.com> wrote: > 2016-12-27 13:16 GMT+01:00 Baolin Wang <baolin.w...@linaro.org>: >> Hi, >> >> On 27 December 2016 at 19:11, Felipe Balbi <ba...@kernel.org> wrote: >>> >>>

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2017-01-04 Thread Baolin Wang
On 3 January 2017 at 20:33, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Baolin Wang <baolin.w...@linaro.org> writes: >> On 28 December 2016 at 20:30, Janusz Dziedzic <janusz.dzied...@gmail.com> >> wrote: >>> 2016-12-27 13:16 GMT+

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2017-01-05 Thread Baolin Wang
Hi, On 5 January 2017 at 17:26, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Baolin Wang <baolin.w...@linaro.org> writes: >>>>>>>> On 27 December 2016 at 18:52, Janusz Dziedzic >>>>>>>> <janusz.dzied...@

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2017-01-05 Thread Baolin Wang
Hi, On 5 January 2017 at 19:19, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Baolin Wang <baolin.w...@linaro.org> writes: > > [...] > >>>>> and you have triggered this with mailine? How? We don't write to GEVNT* >>>>> regi

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2017-01-05 Thread Baolin Wang
Hi John, On 6 January 2017 at 03:08, John Youn wrote: > On 12/28/2016 5:29 PM, John Youn wrote: >> >> >>> Janusz Dziedzic writes: >>> On some platfroms(like x86 platform), when one core is running the >>> USB gadget >>> irq thread

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
Hi, On 20 December 2016 at 12:29, Lu Baolu <baolu...@linux.intel.com> wrote: > Hi Mathias, > > On 12/19/2016 08:13 PM, Mathias Nyman wrote: >> On 19.12.2016 13:34, Baolin Wang wrote: >>> Hi Mathias, >>> >>> On 19 December 2016 at 18:33, Mathias

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
On 20 December 2016 at 14:39, Lu Baolu <baolu...@linux.intel.com> wrote: > Hi, > > On 12/20/2016 02:06 PM, Baolin Wang wrote: >> Hi, >> >> On 20 December 2016 at 12:29, Lu Baolu <baolu...@linux.intel.com> wrote: >>> Hi Mathias, >

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-19 Thread Baolin Wang
Hi Neil, On 3 November 2016 at 09:25, NeilBrown <ne...@suse.com> wrote: > On Tue, Nov 01 2016, Baolin Wang wrote: > > >>> So I won't be responding on this topic any further until I see a genuine >>> attempt to understand and resolve the inconsistencies with >&

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
On 19 December 2016 at 20:13, Mathias Nyman <mathias.ny...@intel.com> wrote: > On 19.12.2016 13:34, Baolin Wang wrote: >> >> Hi Mathias, >> >> On 19 December 2016 at 18:33, Mathias Nyman >> <mathias.ny...@linux.intel.com> wrote: >>> >>

[PATCH v2 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
mer is pending, which means current timeout command has been handled by host and host has fetched new command and re-added the command timer, then just return and wait for new current command. If not, it means current command is timeout and need to be handled. Signed-off-by: Baolin Wang <ba

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-20 Thread Baolin Wang
Hi Mathias, On 20 December 2016 at 23:13, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 20.12.2016 09:30, Baolin Wang wrote: > ... > > Alright, I gathered all current work related to xhci races and timeouts > and put them into a branch: > > git://git.kern

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-20 Thread Baolin Wang
Hi, On 21 December 2016 at 06:07, NeilBrown <ne...@suse.com> wrote: > On Tue, Dec 20 2016, Baolin Wang wrote: > >> Hi Neil, >> >> On 3 November 2016 at 09:25, NeilBrown <ne...@suse.com> wrote: >>> On Tue, Nov 01 2016, Baolin Wang wrote: >>>

Re: [PATCH 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set

2016-12-20 Thread Baolin Wang
Hi, On 21 December 2016 at 15:29, Chanwoo Choi <cw00.c...@samsung.com> wrote: > Hi, > > On 2016년 12월 21일 15:10, Baolin Wang wrote: >> According to the documentation, we should set the EXTCON_USB when >> one SDP charger connector was reported. >> >&g

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread Baolin Wang
On 21 December 2016 at 11:48, NeilBrown <ne...@suse.com> wrote: > On Wed, Dec 21 2016, Baolin Wang wrote: > >> Hi, >> >> On 21 December 2016 at 06:07, NeilBrown <ne...@suse.com> wrote: >>> On Tue, Dec 20 2016, Baolin Wang wrote: >>> >>

Re: [PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set

2016-12-20 Thread Baolin Wang
Hi, On 21 December 2016 at 15:22, Chanwoo Choi <cw00.c...@samsung.com> wrote: > Hi, > > On 2016년 12월 21일 15:10, Baolin Wang wrote: >> According to the documentation, we should set the EXTCON_USB when >> one SDP charger connector was reported. >> >&g

Re: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_*

2016-12-20 Thread Baolin Wang
Hi, On 21 December 2016 at 15:58, Chanwoo Choi <cw00.c...@samsung.com> wrote: > Hi, > > On 2016년 12월 21일 16:53, Baolin Wang wrote: >> Hi, >> >> On 21 December 2016 at 15:20, Chanwoo Choi <cw00.c...@samsung.com> wrote: >>> Hi, >>> &g

[PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set

2016-12-21 Thread Baolin Wang
According to the documentation, we should set the EXTCON_USB when one SDP charger connector was reported. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> --- Changes since v1: - Change extcon_set_cable_state_() to extcon_se

Re: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_*

2016-12-20 Thread Baolin Wang
Hi, On 21 December 2016 at 15:20, Chanwoo Choi <cw00.c...@samsung.com> wrote: > Hi, > > On 2016년 12월 21일 15:10, Baolin Wang wrote: >> Current there is both "EXTCON_USB" and "EXTCON_CHG_USB_SDP" which >> both seem to suggest a standard downstream po

[PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set

2016-12-20 Thread Baolin Wang
According to the documentation, we should set the EXTCON_USB when one SDP charger connector was reported. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/extcon/extcon-axp288.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/

[PATCH 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set

2016-12-20 Thread Baolin Wang
According to the documentation, we should set the EXTCON_USB when one SDP charger connector was reported. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/phy/phy-rockchip-inno-usb2.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/p

[PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_*

2016-12-20 Thread Baolin Wang
d EXTCON_CHG_USB_ACA would normally appear with EXTCON_USB_HOST. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- include/linux/extcon.h |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/linux/extcon.h b/include/linux/extcon.h index b871c0c..64

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
Hi, On 20 December 2016 at 15:18, Lu Baolu <baolu...@linux.intel.com> wrote: > Hi, > > On 12/20/2016 02:46 PM, Baolin Wang wrote: >> On 20 December 2016 at 14:39, Lu Baolu <baolu...@linux.intel.com> wrote: >>> Hi, >>> >>> On 12/20/2016

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-26 Thread Baolin Wang
Hi, On 21 December 2016 at 21:00, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 21.12.2016 04:22, Baolin Wang wrote: >> >> Hi Mathias, >> >> On 20 December 2016 at 23:13, Mathias Nyman >> <mathias.ny...@linux.intel.com> wrote: &

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-26 Thread Baolin Wang
Hi, On 27 December 2016 at 10:39, Lu Baolu <baolu...@linux.intel.com> wrote: > Hi, > > On 12/26/2016 04:01 PM, Baolin Wang wrote: >> On some platfroms(like x86 platform), when one core is running the USB gadget >> irq thread handler by dwc3_thread_interrupt(), meanwhil

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-27 Thread Baolin Wang
Hi, On 27 December 2016 at 19:11, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Baolin Wang <baolin.w...@linaro.org> writes: >> Hi, >> >> On 27 December 2016 at 18:52, Janusz Dziedzic <janusz.dzied...@gmail.com> >> wrote: >>>

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-27 Thread Baolin Wang
Hi, On 27 December 2016 at 18:52, Janusz Dziedzic <janusz.dzied...@gmail.com> wrote: > 2016-12-26 9:01 GMT+01:00 Baolin Wang <baolin.w...@linaro.org>: >> On some platfroms(like x86 platform), when one core is running the USB gadget >> irq thread handler by dwc3_th

[PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-26 Thread Baolin Wang
event count in irq thread handler to make the USB function abnormal. We should add spin_lock/unlock() in dwc3_check_event_buf() to avoid this race. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/usb/dwc3/gadget.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread Baolin Wang
On 22 December 2016 at 07:47, NeilBrown <ne...@suse.com> wrote: > On Wed, Dec 21 2016, Baolin Wang wrote: > >> On 21 December 2016 at 11:48, NeilBrown <ne...@suse.com> wrote: >>> On Wed, Dec 21 2016, Baolin Wang wrote: >>> >>>> Hi, >>>

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
Hi Mathias, On 19 December 2016 at 18:33, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 13.12.2016 05:21, Baolin Wang wrote: >> >> Hi Mathias, >> >> On 12 December 2016 at 23:52, Mathias Nyman >> <mathias.ny...@linux.intel.com> wrote: &

[PATCH] usb: phy: Remove unused config

2017-03-23 Thread Baolin Wang
Since the old common Samsung USB PHY code has been removed by commit ea2fdf8423 ("usb: phy: samsung: remove old common USB PHY code"), thus remove the unused config. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/usb/phy/Kconfig |7 --- drivers/usb/phy

[PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-23 Thread Baolin Wang
, and some other helper functions to register extcon. Suggested-by: NeilBrown <ne...@suse.com> Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- Changes since v1: - Fix build errors with random config. --- drivers/usb/phy/Kconfig |6 +++--- drivers/usb/phy/ph

[PATCH v2 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister

2017-03-23 Thread Baolin Wang
Since usb phy core has added common code to register or unregister extcon device, then phy-qcom-8x16-usb driver does not need its own code to register/unregister extcon device, then remove them. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- Changes since v1: - No updates. --- d

Re: [PATCH 1/2] extcon: usb-gpio: Add level trigger support

2017-03-24 Thread Baolin Wang
Hi, On 24 March 2017 at 19:08, Chanwoo Choi <cw00.c...@samsung.com> wrote: > Hi, > > On 2017년 03월 20일 16:59, Baolin Wang wrote: >> Now extcon-usb-gpio only supports for GPIO egdge trigger, but VBUS/ID >> gpios' detection can be triggered by the level trigger on some

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-22 Thread Baolin Wang
Hi, On 22 March 2017 at 20:43, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 22.03.2017 12:40, Baolin Wang wrote: >> >> Hi, >> >> On 22 March 2017 at 17:00, Felipe Balbi <ba...@kernel.org> wrote: >>> >>> >>> Hi, >&g

Re: [PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-29 Thread Baolin Wang
Hi, On 28 March 2017 at 21:40, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Baolin Wang <baolin.w...@linaro.org> writes: >> Usually usb phy need register one extcon device to get the connection >> notifications. It will remove some duplicate code if the

[PATCH] usb: host: plat: Enable xHCI plat runtime PM

2017-03-29 Thread Baolin Wang
Enable the xHCI plat runtime PM for parent device to suspend/resume xHCI. Also call pm_runtime_forbid() in probe() function to force users to explicitly enable runtime pm using power/control in sysfs, in case some parent devices didn't implement runtime PM callbacks. Signed-off-by: Baolin Wang

Re: [PATCH v2 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister

2017-03-29 Thread Baolin Wang
Hi, On 28 March 2017 at 21:42, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Baolin Wang <baolin.w...@linaro.org> writes: >> Since usb phy core has added common code to register or unregister >> extcon device, then phy-qcom-8x16-usb driver does not need it

Re: [PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-29 Thread Baolin Wang
Hi, On 29 March 2017 at 06:56, NeilBrown <ne...@suse.com> wrote: > On Thu, Mar 23 2017, Baolin Wang wrote: > >> Usually usb phy need register one extcon device to get the connection >> notifications. It will remove some duplicate code if the extcon device >> i

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-29 Thread Baolin Wang
Hi, On 29 March 2017 at 07:04, NeilBrown <ne...@suse.com> wrote: > On Tue, Mar 07 2017, Baolin Wang wrote: > >> On 3 March 2017 at 10:23, NeilBrown <ne...@suse.com> wrote: >> >>> >>> I understand your reluctance to change drivers that you

Re: [PATCH 1/2] extcon: usb-gpio: Add level trigger support

2017-03-29 Thread Baolin Wang
Hi, On 24 March 2017 at 20:41, Rob Herring <robh...@kernel.org> wrote: > On Fri, Mar 24, 2017 at 6:56 AM, Baolin Wang <baolin.w...@linaro.org> wrote: >> Hi, >> >> On 24 March 2017 at 19:08, Chanwoo Choi <cw00.c...@samsung.com> wrote: >>> Hi, &

[PATCH 1/2] extcon: usb-gpio: Add level trigger support

2017-03-20 Thread Baolin Wang
Now extcon-usb-gpio only supports for GPIO egdge trigger, but VBUS/ID gpios' detection can be triggered by the level trigger on some platforms. Thus intoduce one property 'extcon-gpio,level-trigger' to identify this situation. Signed-off-by: Baolin Wang <baolin.w...@linaro.

[PATCH 2/2] extcon: usb-gpio: Add the GPIO level trigger support

2017-03-20 Thread Baolin Wang
GPIOs may need level trigger to detect VBUS/ID on some platforms, thus we should add GPIO level trigger to support this situation. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/extcon/extcon-usb-gpio.c | 81 -- 1 file changed, 77 inse

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-21 Thread Baolin Wang
Hi Mathias, On 21 February 2017 at 10:09, Baolin Wang <baolin.w...@linaro.org> wrote: >>>>>> Do you have any comments about this patch? Thanks. >>>>>> >>>>>>>drivers/usb/host/xhci-plat.c | 41 >>>>>>>

Re: [PATCH 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-20 Thread Baolin Wang
rove the system] > > url: > https://github.com/0day-ci/linux/commits/Baolin-Wang/usb-phy-Introduce-one-extcon-device-into-usb-phy/20170319-175509 > base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next > config: i386-randconfig-i1-201712 (attached as .conf

[PATCH 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-17 Thread Baolin Wang
, and some other helper functions to register extcon. Suggested-by: NeilBrown <ne...@suse.com> Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/usb/phy/Kconfig | 17 ++--- drivers/usb/phy/phy.c | 44 inclu

[PATCH 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister

2017-03-17 Thread Baolin Wang
Since usb phy core has added common code to register or unregister extcon device, then phy-qcom-8x16-usb driver does not need its own code to register/unregister extcon device, then remove them. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/usb/phy/phy-qcom-8x16-usb.c

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-22 Thread Baolin Wang
Hi, On 22 March 2017 at 17:00, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Baolin Wang <baolin.w...@linaro.org> writes: >>>>>> I don't yet understand why we can't just keep runtime pm disabled as a >>>>>> default for xhci plat

Re: [kbuild-all] [PATCH 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-22 Thread Baolin Wang
Hi, On 22 March 2017 at 14:32, Ye Xiaolong <xiaolong...@intel.com> wrote: > On 03/20, Baolin Wang wrote: >>Hi, >> >> >>On 19 March 2017 at 19:42, kbuild test robot <l...@intel.com> wrote: >>> Hi Baolin, >>> >>> [auto build test ERR

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-21 Thread Baolin Wang
Hi, On 21 March 2017 at 16:07, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Baolin Wang <baolin.w...@linaro.org> writes: >>>> I don't yet understand why we can't just keep runtime pm disabled as a >>>> default for xhci platform devic

Re: [PATCH] usb: host: plat: Enable xHCI plat runtime PM

2017-04-10 Thread Baolin Wang
Hi Mathias, On 30 March 2017 at 11:26, Baolin Wang <baolin.w...@linaro.org> wrote: > Enable the xHCI plat runtime PM for parent device to suspend/resume > xHCI. Also call pm_runtime_forbid() in probe() function to force users > to explicitly enable runtime pm using power/control in

Re: [PATCH] usb: host: plat: Enable xHCI plat runtime PM

2017-04-10 Thread Baolin Wang
Hi Mathias, On 10 April 2017 at 18:09, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 10.04.2017 10:57, Baolin Wang wrote: >> >> Hi Mathias, >> >> On 30 March 2017 at 11:26, Baolin Wang <baolin.w...@linaro.org> wrote: >>> >>> Ena

[PATCH v2] usb: host: plat: Enable xHCI plat runtime PM

2017-04-13 Thread Baolin Wang
Enable the xHCI plat runtime PM for parent device to suspend/resume xHCI. Also call pm_runtime_forbid() in probe() function to force users to explicitly enable runtime pm using power/control in sysfs, in case some parent devices didn't implement runtime PM callbacks. Signed-off-by: Baolin Wang

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-09 Thread Baolin Wang
On 10 March 2017 at 14:30, Jun Li wrote: >> >> > >> >> > Will generic phy need add extcon as well? >> >> >> >> Yes, will add a 'struct extcon_dev*' in 'struct usb_phy', which will >> >> be common code. >> >> >> > >> > I mean the common code need add 'struct extcon_dev' into both

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-10 Thread Baolin Wang
On 10 March 2017 at 16:27, Jun Li <jun...@nxp.com> wrote: > Hi > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Friday, March 10, 2017 3:15 PM >> To: Jun Li <jun...@nxp.com> >> Cc: NeilBrown <ne...@

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-09 Thread Baolin Wang
On 9 March 2017 at 18:34, Jun Li <jun...@nxp.com> wrote: > > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Thursday, March 09, 2017 2:11 PM >> To: Jun Li <jun...@nxp.com> >> Cc: NeilBrown <ne...@

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-09 Thread Baolin Wang
Hi, On 9 March 2017 at 09:50, Jun Li <jun...@nxp.com> wrote: > Hi, > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Tuesday, March 07, 2017 5:39 PM >> To: NeilBrown <ne...@suse.com> >> C

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-14 Thread Baolin Wang
Hi, On 14 March 2017 at 17:57, Lee Jones <lee.jo...@linaro.org> wrote: > On Mon, 20 Feb 2017, Baolin Wang wrote: > > [...] > >> drivers/power/supply/wm831x_power.c | 63 +++ >> drivers/usb/gadget/Kconfig |8 + >> drivers/usb/gadget/udc/Makefile

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-13 Thread Baolin Wang
On 13 March 2017 at 09:09, Jun Li <jun...@nxp.com> wrote: > Hi, > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Friday, March 10, 2017 6:52 PM >> To: Jun Li <jun...@nxp.com> >> Cc: NeilBrown <ne...@

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-13 Thread Baolin Wang
On 14 March 2017 at 09:10, Jun Li <jun...@nxp.com> wrote: > Hi, > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Monday, March 13, 2017 4:44 PM >> To: Jun Li <jun...@nxp.com> >> Cc: NeilBrown <ne...@

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-07 Thread Baolin Wang
On 3 March 2017 at 10:23, NeilBrown <ne...@suse.com> wrote: > On Mon, Feb 20 2017, Baolin Wang wrote: > >> Currently the Linux kernel does not provide any standard integration of this >> feature that integrates the USB subsystem with the system power regulation >

Re: [PATCH v5 1/3] pinctrl: Add sleep related state to indicate sleep related configs

2017-08-02 Thread Baolin Wang
Hi LinusW and Rob, On 14 July 2017 at 16:08, Baolin Wang <baolin.w...@spreadtrum.com> wrote: > In some scenarios, we should set some pins as input/output/pullup/pulldown > when the specified system goes into deep sleep mode, then when the system > goes into deep sleep mode, these p

Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C controller documentation

2017-08-03 Thread Baolin Wang
Hi Wolfram, On 27 July 2017 at 17:29, Baolin Wang <baolin.w...@linaro.org> wrote: > Hi Wolfram, > > On 24 July 2017 at 14:51, Baolin Wang <baolin.w...@spreadtrum.com> wrote: >> Hi Wolfram, >> >> On 五, 7月 14, 2017 at 05:01:10下午 +0800, Baolin Wang

Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C controller documentation

2017-08-03 Thread Baolin Wang
On 3 August 2017 at 16:26, Peter Rosin <p...@axentia.se> wrote: > On 2017-08-03 09:29, Baolin Wang wrote: >> Hi Wolfram, >> >> On 27 July 2017 at 17:29, Baolin Wang <baolin.w...@linaro.org> wrote: >>> Hi Wolfram, >>> >>> On 24 July 2

Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C controller documentation

2017-08-03 Thread Baolin Wang
Hi Wolfram, On 3 August 2017 at 17:00, Wolfram Sang wrote: > Hi, > >> Sorry for noise. I just afraid Wolfram missed this patchset since I >> did not get any comments from V4. > > I use patchwork. Patches don't get lost :) > > Anyway, I nearly finished a document I can point

Re: [PATCH v4 3/3] power: wm831x_power: Support USB charger current limit management

2017-08-03 Thread Baolin Wang
On 4 August 2017 at 03:16, Rob Herring <r...@kernel.org> wrote: > On Thu, Jul 27, 2017 at 01:14:38PM +0800, Baolin Wang wrote: >> Integrate with the newly added USB charger interface to limit the current >> we draw from the USB input based on the input device configuration >

[PATCH v5 2/3] usb: phy: Add USB charger support

2017-08-15 Thread Baolin Wang
-by: Baolin Wang <baolin.w...@linaro.org> --- drivers/usb/phy/phy.c | 272 +++ include/linux/usb/phy.h | 49 + 2 files changed, 321 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 032f5af..2dc48bb 100644 --- a/d

Re: [PATCH v4 0/3] Introduce USB charger support in USB phy

2017-08-15 Thread Baolin Wang
Hi Felipe, On 15 August 2017 at 17:53, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Baolin Wang <baolin.w...@linaro.org> writes: >>> Currently the Linux kernel does not provide any standard integration of this >>> feature that integrates the USB

[PATCH v5 0/3] Introduce USB charger support in USB phy

2017-08-15 Thread Baolin Wang
DT binding documentation for wm831x_power driver. - Change 'usb-phy' as one optional property for wm831x_power driver. Changes since v1: - Fix building errors. Baolin Wang (3): include: uapi: usb: Introduce USB charger type and state definition usb: phy: Add USB charger support power

[PATCH v5 3/3] power: wm831x_power: Support USB charger current limit management

2017-08-15 Thread Baolin Wang
-by: Mark Brown <broo...@kernel.org> Signed-off-by: Baolin Wang <baolin.w...@linaro.org> Acked-by: Lee Jones <lee.jo...@linaro.org> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> Acked-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> --- Doc

[PATCH v5 1/3] include: uapi: usb: Introduce USB charger type and state definition

2017-08-15 Thread Baolin Wang
Introducing USB charger type and state definition can help to support USB charging which will be added in USB phy core. Signed-off-by: Baolin Wang <baolin.w...@linaro.org> --- include/uapi/linux/usb/charger.h | 31 +++ 1 file changed, 31 insertions(+) creat

[RESEND PATCH v5 2/3] dt-bindings: pinctrl: Add Spreadtrum SC9860 pin controller

2017-08-17 Thread Baolin Wang
This patch adds the binding documentation for Spreadtrum SC9860 pin controller device. Signed-off-by: Baolin Wang <baolin.w...@spreadtrum.com> --- Changes since v4: - Remove these sleep related configs and only introduce one sleep state config to indicate this is sleep state. Changes

[RESEND PATCH v5 1/3] pinctrl: Add sleep related state to indicate sleep related configs

2017-08-17 Thread Baolin Wang
in the OS, but need to be controlled when entering sleep mode. Thus we introduce one sleep state config into pinconf-generic for users to configure. Signed-off-by: Baolin Wang <baolin.w...@spreadtrum.com> --- Changes since v4: - Add sleep-hardware-state config to indicate sleep related c

[RESEND PATCH v5 3/3] pinctrl: sprd: Add Spreadtrum pin control driver

2017-08-17 Thread Baolin Wang
This patch adds the pin control driver for Spreadtrum SC9860 platform. Signed-off-by: Baolin Wang <baolin.w...@spreadtrum.com> --- Changes since v4: - Remove sleep configs. - Use one standard sleep hardware state config to indicate sleep configs. Changes since v3: - Use the generic &qu

Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

2017-07-12 Thread Baolin Wang
Hi, On 12 July 2017 at 11:52, gustavo panizzo wrote: > The dwc3 could not release resources when the module is built-in > because this module does not have shutdown method. This causes the USB > 3.0 hub is not able to detect after warm boot. > > Original patch by Brian Kim,

[PATCH v5 3/3] pinctrl: sprd: Add Spreadtrum pin control driver

2017-07-14 Thread Baolin Wang
This patch adds the pin control driver for Spreadtrum SC9860 platform. Signed-off-by: Baolin Wang <baolin.w...@spreadtrum.com> --- Changes since v4: - Remove sleep configs. - Use one standard sleep hardware state config to indicate sleep configs. Changes since v3: - Use the generic &qu

[PATCH v5 2/3] dt-bindings: pinctrl: Add Spreadtrum SC9860 pin controller

2017-07-14 Thread Baolin Wang
This patch adds the binding documentation for Spreadtrum SC9860 pin controller device. Signed-off-by: Baolin Wang <baolin.w...@spreadtrum.com> --- Changes since v4: - Remove these sleep related configs and only introduce one sleep state config to indicate this is sleep state. Changes

[PATCH v5 1/3] pinctrl: Add sleep related state to indicate sleep related configs

2017-07-14 Thread Baolin Wang
in the OS, but need to be controlled when entering sleep mode. Thus we introduce one sleep state config into pinconf-generic for users to configure. Signed-off-by: Baolin Wang <baolin.w...@spreadtrum.com> --- Changes since v4: - Add sleep-hardware-state config to indicate sleep related c

[RESEND PATCH v4 2/2] i2c: Add Spreadtrum I2C controller driver

2017-07-14 Thread Baolin Wang
This patch adds the I2C controller driver for Spreadtrum SC9860 platform. Signed-off-by: Baolin Wang <baolin.w...@spreadtrum.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> --- Changes since v3: - Use SPDX-License-Identifier tag instead. Changes since v2: - Remove so

Re: [PATCH v4 1/3] pinctrl: Add sleep related configuration

2017-07-13 Thread Baolin Wang
Hi, On 12 July 2017 at 20:30, Linus Walleij <linus.wall...@linaro.org> wrote: > On Tue, Jun 27, 2017 at 2:06 PM, Baolin Wang <baolin.w...@spreadtrum.com> > wrote: > >> If we introduce "sleep-input-enable" config, we can set the pin's config >

<    3   4   5   6   7   8   9   10   11   12   >