From: Bartosz Golaszewski
We want to work towards phasing out the at24_platform_data structure.
There are few users and its contents can be represented using generic
device properties. Using device properties only will allow us to
significantly simplify the at24 configuration code.
Remove the
From: Bartosz Golaszewski
Stop using the at24_platform_data setup callback in favor of nvmem
notifiers.
Signed-off-by: Bartosz Golaszewski
---
arch/arm/mach-davinci/board-mityomapl138.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach
From: Bartosz Golaszewski
We want to work towards phasing out the at24_platform_data structure.
There are few users and its contents can be represented using generic
device properties. Using device properties only will allow us to
significantly simplify the at24 configuration code.
Remove the
From: Bartosz Golaszewski
We want to work towards phasing out the at24_platform_data structure.
There are few users and its contents can be represented using generic
device properties. Using device properties only will allow us to
significantly simplify the at24 configuration code.
Remove the
From: Bartosz Golaszewski
The currently used 24lc64 i2c device name doesn't match against any
of the devices supported by the at24 driver. Change it to the closest
compatible chip.
Signed-off-by: Bartosz Golaszewski
---
arch/arm/mach-davinci/board-sffsdr.c | 2 +-
1 file changed, 1 inse
From: Bartosz Golaszewski
This is now done by the emac driver using a registered nvmem cell.
Signed-off-by: Bartosz Golaszewski
---
arch/arm/mach-davinci/board-mityomapl138.c | 8
1 file changed, 8 deletions(-)
diff --git a/arch/arm/mach-davinci/board-mityomapl138.c
b/arch/arm/mach
From: Bartosz Golaszewski
We want to work towards phasing out the at24_platform_data structure.
There are few users and its contents can be represented using generic
device properties. Using device properties only will allow us to
significantly simplify the at24 configuration code.
Remove the
From: Bartosz Golaszewski
We want to work towards phasing out the at24_platform_data structure.
There are few users and its contents can be represented using generic
device properties. Using device properties only will allow us to
significantly simplify the at24 configuration code.
Remove the
From: Bartosz Golaszewski
We no longer need to register the MTD notifier to read the MAC address
as it's now being done in the emac driver.
Signed-off-by: Bartosz Golaszewski
---
arch/arm/mach-davinci/board-da850-evm.c | 28 -
1 file changed, 28 deletions(-)
From: Bartosz Golaszewski
Hi Sekhar,
I noticed some more breakage resulting from commit 587f7a694f01 ("gpio:
davinci: Use dev name for label and automatic base selection"). This
series fixes GPIO lookups in legacy mode for DaVinci.
Bartosz Golaszewski (5):
ARM: davinci: da830-evm:
From: Bartosz Golaszewski
Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.
Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic
From: Bartosz Golaszewski
Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.
Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic
From: Bartosz Golaszewski
Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.
Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic
From: Bartosz Golaszewski
Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.
Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic
From: Bartosz Golaszewski
Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.
Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic
From: Bartosz Golaszewski
Nested interrupts run inside the calling thread's context and the top
half handler is never called which means that we never read the
timestamp.
This issue came up when trying to read line events from a gpiochip
using regmap_irq_chip for interrupts.
Fix it by re
czw., 20 wrz 2018 o 18:48 Daniel Lezcano napisał(a):
>
> On 20/09/2018 18:19, Bartosz Golaszewski wrote:
> > 2018-09-20 18:09 GMT+02:00 Daniel Lezcano :
> >> On 20/09/2018 15:00, Bartosz Golaszewski wrote:
> >>
> >> [ ... ]
> >>
> >>>
it's safe to convert all memory allocations to devres.
Signed-off-by: Bartosz Golaszewski
---
drivers/mailbox/tegra-hsp.c | 41 -
1 file changed, 9 insertions(+), 32 deletions(-)
diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-h
Two threads can try to fire the irq_sim with different offsets and will
end up fighting for the irq_work asignment. To fix it: add a mutex and
lock it before firing.
Suggested-by: Uwe Kleine-König
Signed-off-by: Bartosz Golaszewski
---
include/linux/irq_sim.h | 1 +
kernel/irq/irq_sim.c| 5
We already support set_multiple(). Implement get_multiple() as well.
Signed-off-by: Bartosz Golaszewski
---
drivers/gpio/gpio-mockup.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 3cd92912c414..a4c054cf9c5f
The first patch is a fix that should go in for 4.20.
Next two patches introduce features for 4.21 - lock protection of the
dummy chip structures and implementation of the get_multiple() callback.
Bartosz Golaszewski (3):
gpio: mockup: fix indicated direction
gpio: mockup: add locking
gpio
While no user reported any race condition problems with gpio-mockup,
let's be on the safe side and use a mutex when performing any changes
on the dummy chip structures.
Suggested-by: Uwe Kleine-König
Signed-off-by: Bartosz Golaszewski
---
drivers/gpio/gpio-mockup.c
Commit 3edfb7bd76bd ("gpiolib: Show correct direction from the
beginning") fixed an existing issue but broke libgpiod tests by
changing the default direction of dummy lines to output.
We don't break user-space so make gpio-mockup behave as before.
Signed-off-by: Bartosz Golaszewsk
czw., 8 lis 2018 o 20:41 Uwe Kleine-König
napisał(a):
>
> Hello Bartosz,
>
> On Thu, Nov 08, 2018 at 05:47:48PM +0100, Bartosz Golaszewski wrote:
> > Two threads can try to fire the irq_sim with different offsets and will
> > end up fighting for the irq_work asignment. To
Make devm_kfree() signature uniform with that of kfree(). To avoid
compiler warnings: cast p to (void *) when calling devres_destroy().
Signed-off-by: Bartosz Golaszewski
Reviewed-by: Bjorn Andersson
Reviewed-by: Geert Uytterhoeven
Acked-by: Rasmus Villemoes
Reviewed-by: Andy Shevchenko
estroy the resource.
Signed-off-by: Bartosz Golaszewski
Reviewed-by: Bjorn Andersson
Acked-by: Mike Rapoport
Acked-by: Rasmus Villemoes
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Andy Shevchenko
---
drivers/base/devres.c | 31 +++
include/linux/device.h | 2 +
ferent example
- collected more tags
v4 -> v5:
- instead of providing devm_kfree_const(), make devm_kfree() check if
given pointer is not in .rodata and act accordingly
v5 -> v6:
- fixed the commit message in patch 2/4 (s/devm_kfree_const/devm_kfree/)
- collected even more tags
Bartosz Golas
ck so
it's safe to convert all memory allocations to devres.
Signed-off-by: Bartosz Golaszewski
---
drivers/mailbox/tegra-hsp.c | 41 -
1 file changed, 9 insertions(+), 32 deletions(-)
diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-h
Export this routine so that we can use it later in devm_kstrdup_const()
and devm_kfree().
Signed-off-by: Bartosz Golaszewski
Reviewed-by: Bjorn Andersson
Acked-by: Mike Rapoport
Acked-by: Rasmus Villemoes
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Andy Shevchenko
---
include/asm-generic
niedz., 14 paź 2018 o 17:20 Bartosz Golaszewski napisał(a):
>
> Hi Greg,
>
> this has been reviewed a lot and three first patches can be picked
> up. Please take it through your tree.
>
Except for patch 4/4 of course - it needs Thierry's Ack, but that can
wait until the
From: Bartosz Golaszewski
As discussed with Linus Walleij - I'm adding myself as
the co-maintainer.
Cc: Benoît Cousson
Cc: Kevin Hilman
Cc: Michael Turquette
Signed-off-by: Bartosz Golaszewski
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTA
pt., 11 maj 2018 o 18:21 Bartosz Golaszewski napisał(a):
>
> This series is a follow-up to the RFC[1] posted a couple days ago.
>
> NOTE: this series applies on top of my recent patches[2] that move the
> previous
> implementation of early platform devices to arch/sh.
>
&
wt., 16 paź 2018 o 12:53 Greg Kroah-Hartman
napisał(a):
>
> On Sun, Oct 14, 2018 at 05:20:08PM +0200, Bartosz Golaszewski wrote:
> > Export this routine so that we can use it later in devm_kstrdup_const()
> > and devm_kfree().
> >
> > Signed-off-by: Bartosz Golas
It's actually fine to read values of output lines. This was also
allowed by the legacy sysfs interface.
Signed-off-by: Bartosz Golaszewski
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
I noticed that - unlike sysfs - it's possible to set values of input
lines from user space using the character device. There's actually
even a TODO in the linehandle_ioctl() code.
This is not correct so the first patches fixes that and the second
removes a TODO that's not really n
.
Signed-off-by: Bartosz Golaszewski
---
drivers/gpio/gpiolib.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e11a3bb03820..57973524360d 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -449,7 +449,13
2018-07-16 15:40 GMT+02:00 Linus Walleij :
> On Mon, Jul 16, 2018 at 10:34 AM Bartosz Golaszewski wrote:
>
>> User space can currently both read and set values of input lines using
>> the character device. This was not allowed by the old sysfs interface
>> nor
2018-07-09 10:52 GMT+02:00 Bartosz Golaszewski :
> 2018-07-09 5:12 GMT+02:00 Chiang, AlanX :
>> Hi Robert,
>>
>>> -Original Message-
>>> From: Robert P. J. Day [mailto:rpj...@crashcourse.ca]
>>> Sent: Friday, July 6, 2018 4:24 AM
>>
Add DT bindings, relevant DT defines, DTS nodes and driver changes
required to enable the remoteprocs on sa8775p.
Signed-off-by: Bartosz Golaszewski
---
Bartosz Golaszewski (1):
arm64: dts: qcom: sa8775p-ride: enable remoteprocs
Tengfei Fan (4):
dt-bindings: remoteproc: qcom,sm8550
From: Tengfei Fan
Document the compatibles for the components used to boot the ADSP, CDSP0,
CDSP1, GPDSP0 and GPDSP1 on the SA8775p SoC.
Signed-off-by: Tengfei Fan
Co-developed-by: Bartosz Golaszewski
Signed-off-by: Bartosz Golaszewski
---
.../bindings/remoteproc/qcom,sm8550-pas.yaml
From: Tengfei Fan
Add GPDSP0 and GPDSP1 clients for SA8775p platform.
Signed-off-by: Tengfei Fan
Signed-off-by: Bartosz Golaszewski
---
include/dt-bindings/mailbox/qcom-ipcc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/dt-bindings/mailbox/qcom-ipcc.h
b/include/dt-bindings
From: Tengfei Fan
Add support for PIL loading on ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 on
SA8775p SoCs.
Signed-off-by: Tengfei Fan
Co-developed-by: Bartosz Golaszewski
Signed-off-by: Bartosz Golaszewski
---
drivers/remoteproc/qcom_q6v5_pas.c | 92 ++
1
From: Bartosz Golaszewski
Enable all remoteproc nodes on the sa8775p-ride board and point to the
appropriate firmware files.
Signed-off-by: Bartosz Golaszewski
---
arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 25 +
1 file changed, 25 insertions(+)
diff --git a/arch
From: Tengfei Fan
Add nodes for remoteprocs: ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 for
SA8775p SoCs.
Signed-off-by: Tengfei Fan
Co-developed-by: Bartosz Golaszewski
Signed-off-by: Bartosz Golaszewski
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 332 ++
1 file
On Wed, May 22, 2024 at 2:42 PM wrote:
>
> On 22/05/2024 14:08, Bartosz Golaszewski wrote:
> > From: Tengfei Fan
> >
> > Document the compatibles for the components used to boot the ADSP, CDSP0,
> > CDSP1, GPDSP0 and GPDSP1 on the SA8775p SoC.
> >
> > Si
On Wed, May 22, 2024 at 3:06 PM wrote:
>
> On 22/05/2024 15:04, Bartosz Golaszewski wrote:
> > On Wed, May 22, 2024 at 2:42 PM wrote:
> >>
> >> On 22/05/2024 14:08, Bartosz Golaszewski wrote:
> >>> From: Tengfei Fan
> >>>
> >>>
Add DT bindings, relevant DT defines, DTS nodes and driver changes
required to enable the remoteprocs on sa8775p.
Signed-off-by: Bartosz Golaszewski
---
Changes in v2:
- Move the DT bindings for sa8775p-pas into a separate file
- Link to v1:
https://lore.kernel.org/r/20240522-topic-lemans-iot
From: Bartosz Golaszewski
Document the components used to boot the ADSP, CDSP0, CDSP1, GPDSP0 and
GPDSP1 on the SA8775p SoC.
Co-developed-by: Tengfei Fan
Signed-off-by: Bartosz Golaszewski
---
.../bindings/remoteproc/qcom,sa8775p-pas.yaml | 177 +
1 file changed, 177
From: Tengfei Fan
Add GPDSP0 and GPDSP1 clients for SA8775p platform.
Signed-off-by: Tengfei Fan
Acked-by: Krzysztof Kozlowski
Signed-off-by: Bartosz Golaszewski
---
include/dt-bindings/mailbox/qcom-ipcc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/dt-bindings/mailbox
From: Tengfei Fan
Add support for PIL loading on ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 on
SA8775p SoCs.
Signed-off-by: Tengfei Fan
Co-developed-by: Bartosz Golaszewski
Signed-off-by: Bartosz Golaszewski
---
drivers/remoteproc/qcom_q6v5_pas.c | 92 ++
1
From: Tengfei Fan
Add nodes for remoteprocs: ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 for
SA8775p SoCs.
Signed-off-by: Tengfei Fan
Co-developed-by: Bartosz Golaszewski
Signed-off-by: Bartosz Golaszewski
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 332 ++
1 file
From: Bartosz Golaszewski
Enable all remoteproc nodes on the sa8775p-ride board and point to the
appropriate firmware files.
Signed-off-by: Bartosz Golaszewski
---
arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 25 +
1 file changed, 25 insertions(+)
diff --git a/arch
On Mon, May 27, 2024 at 10:56 AM Krzysztof Kozlowski wrote:
>
> On 27/05/2024 10:43, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski
> >
> > Document the components used to boot the ADSP, CDSP0, CDSP1, GPDSP0 and
> > GPDSP1 on the SA8775p SoC.
> &
-...@vger.kernel.org
Cc: linux-remotep...@vger.kernel.org
Cc: devicet...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bartosz Golaszewski
Changes in v3:
- Unify the nsp power domain names across both CDSPs
- Sort out SoB tags
- Fix firmware names in the PAS driver
- Fix cdsp0 name in
From: Bartosz Golaszewski
Document the components used to boot the ADSP, CDSP0, CDSP1, GPDSP0 and
GPDSP1 on the SA8775p SoC.
Signed-off-by: Bartosz Golaszewski
---
.../bindings/remoteproc/qcom,sa8775p-pas.yaml | 160 +
1 file changed, 160 insertions(+)
diff --git a
From: Tengfei Fan
Add GPDSP0 and GPDSP1 clients for SA8775p platform.
Signed-off-by: Tengfei Fan
Acked-by: Krzysztof Kozlowski
Signed-off-by: Bartosz Golaszewski
---
include/dt-bindings/mailbox/qcom-ipcc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/dt-bindings/mailbox
From: Tengfei Fan
Add support for PIL loading on ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 on
SA8775p SoCs.
Signed-off-by: Tengfei Fan
Co-developed-by: Bartosz Golaszewski
Signed-off-by: Bartosz Golaszewski
---
drivers/remoteproc/qcom_q6v5_pas.c | 92 ++
1
From: Tengfei Fan
Add nodes for remoteprocs: ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 for
SA8775p SoCs.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Tengfei Fan
Co-developed-by: Bartosz Golaszewski
Signed-off-by: Bartosz Golaszewski
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 332
From: Bartosz Golaszewski
Enable all remoteproc nodes on the sa8775p-ride board and point to the
appropriate firmware files.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Bartosz Golaszewski
---
arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 25 +
1 file changed, 25
On Thu, Feb 11, 2021 at 1:12 PM Jonathan Cameron
wrote:
>
[snip!]
> >
> > @@ -869,6 +891,14 @@ static struct cxl_mem *cxl_mem_create(struct pci_dev
> > *pdev, u32 reg_lo,
> > mutex_init(&cxlm->mbox_mutex);
> > cxlm->pdev = pdev;
> > cxlm->regs = regs + offset;
> > + cxlm->
On Fri, Apr 2, 2021 at 3:24 PM Claudiu Beznea
wrote:
>
> Some EEPROMs could be used only for MAC storage. In this case the
> EEPROM areas where MACs resides could be modeled as NVMEM cells
> (directly via DT bindings) such that the already available networking
> infrastructure to read properly the
On Thu, Apr 8, 2021 at 6:24 PM Andy Shevchenko
wrote:
>
> The attributes on the heap must be initialized before use.
> Neglecting that will produce an Oops in some configurations:
>
> BUG: key 000800eba398 has not been registered!
>
> Initialize attribute allocated on the heap.
>
> Fixes: 3f
On Thu, Apr 8, 2021 at 9:20 AM Linus Walleij wrote:
>
> On Tue, Apr 6, 2021 at 3:49 AM Ran Wang wrote:
>
> > Could this version be accepted, or any comment/suggestion?
>
> Andy says yes, then it is a yes :)
> FWIW
> Acked-by: Linus Walleij
>
> Yours,
> Linus Walleij
Applied, thanks!
Bartosz
rease/decrease noise reduction.
v5:
- avoid a "division by zero in kernel" if reading from an uninitialized
register
v4:
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg781119.html
Bartosz Golaszewski (3):
hwmon: ina2xx: make shunt resistance configurable at run-time
Include the rshunt and avg sysfs attributes for ina2xx in the documentation.
Signed-off-by: Bartosz Golaszewski
---
Documentation/hwmon/ina2xx | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/hwmon/ina2xx b/Documentation/hwmon/ina2xx
index 4223c2d
The averaging rate of ina226 is hardcoded to 16 in the driver.
Make it modifiable at run-time via a new sysfs attribute.
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/ina2xx.c | 125 +++--
1 file changed, 122 insertions(+), 3 deletions
The shunt resistance can only be set via platform_data or device tree. This
isn't suitable for devices in which the shunt resistance can change/isn't
known at boot-time.
Add a sysfs attribute that allows to read and set the shunt resistance.
Signed-off-by: Bartosz Golaszewski
---
dri
2014-12-10 15:20 GMT+01:00 Guenter Roeck :
>> + case INA2XX_CALIBRATION:
>> + if (data->regs[reg] == 0)
>> + val = 0;
>> + else
>> + val = data->config->calibration_factor
>> +
2014-12-10 19:31 GMT+01:00 Guenter Roeck :
> I don't really want it at all ;-). Seems to me all those options are broken
> one way or another. The only real solution would be to re-instantiate the
> driver if the chip was removed and re-inserted, and to provide parameters
> either with platform dat
e sure the registers are going to be re-read after setting the averaging
rate
v7:
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg787851.html
Bartosz Golaszewski (5):
hwmon: ina2xx: reinitialize the chip in case it's been reset
hwmon: ina2xx: remove a stray new line
hwmon
ip if needed.
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/ina2xx.c | 128 +++--
1 file changed, 91 insertions(+), 37 deletions(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index e01feba..ffbd60f 100644
--- a/drivers/hwmon/ina
Shunt resistance values greater than the chip's calibration factor make no
sense since the actual value written to the register equals:
/
Bail-out from ina2xx_probe() if the configured value is greater than the
calibration factor.
Signed-off-by: Bartosz Golaszewski
---
drivers/
in case of an unexpected chip reset.
Signed-off-by: Bartosz Golaszewski
---
Documentation/hwmon/ina2xx | 3 ++
drivers/hwmon/ina2xx.c | 129 +++--
2 files changed, 128 insertions(+), 4 deletions(-)
diff --git a/Documentation/hwmon/ina2xx b/Documenta
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/ina2xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index ffbd60f..39e017b 100644
--- a/drivers/hwmon/ina2xx.c
+++ b/drivers/hwmon/ina2xx.c
@@ -52,7 +52,6 @@
#define INA226_ALERT_LIMIT
The shunt resistance can only be set via platform_data or device tree. This
isn't suitable for devices in which the shunt resistance can change/isn't
known at boot-time.
Add a sysfs attribute that allows to read and set the shunt resistance.
Signed-off-by: Bartosz Golaszewski
---
Doc
2014-12-04 15:19 GMT+01:00 Guenter Roeck :
> The datasheet claims otherwise (0x31, specifically).
> Is this based on real chip information ?
> Can you send me the output from i2cdump for the chip ?
>
This is what I'm reading:
# i2cdump -y 1 0x4c
No size specified (using byte-data access)
0
.
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/tmp401.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c
index a5f0973..ce7e579 100644
--- a/drivers/hwmon/tmp401.c
+++ b/drivers/hwmon/tmp401
il-archive.com/linux-kernel%40vger.kernel.org/msg781930.html
Bartosz Golaszewski (2):
hwmon: tmp401: add TMP435 to the list of supported chips in docs and Kconfig
hwmon: tmp401: bail-out from tmp401_probe() in case of write errors
Patrick Titiano (1):
hwmon: tmp401: add support fo
From: Patrick Titiano
Signed-off-by: Patrick Titiano
[Bartosz Golaszewski: prepared for submission, code review fixes]
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/tmp401.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/tmp401.c b
Signed-off-by: Bartosz Golaszewski
---
Documentation/hwmon/tmp401 | 8 ++--
drivers/hwmon/Kconfig | 2 +-
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/hwmon/tmp401 b/Documentation/hwmon/tmp401
index f91e3fa..445ff7b 100644
--- a/Documentation/hwmon/tmp401
.
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/tmp401.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c
index ccd9938..f2182ee 100644
--- a/drivers/hwmon/tmp401.c
+++ b/drivers/hwmon/tmp401.c
From: Patrick Titiano
Signed-off-by: Patrick Titiano
[Bartosz Golaszewski: prepared for submission, code review fixes]
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/tmp401.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/tmp401.c b
Signed-off-by: Bartosz Golaszewski
---
Documentation/hwmon/tmp401 | 8 ++--
drivers/hwmon/Kconfig | 2 +-
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/hwmon/tmp401 b/Documentation/hwmon/tmp401
index f91e3fa..445ff7b 100644
--- a/Documentation/hwmon/tmp401
'tmp401: probe of X-00XX failed with error -121' anyway in dmesg,
v1:
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg781930.html
Bartosz Golaszewski (2):
hwmon: tmp401: add TMP435 to the list of supported chips in docs and Kconfig
hwmon: tmp401: bail-out from tmp
in case of an unexpected chip reset.
Signed-off-by: Bartosz Golaszewski
---
Documentation/hwmon/ina2xx | 4 ++
drivers/hwmon/ina2xx.c | 110 +++--
2 files changed, 110 insertions(+), 4 deletions(-)
diff --git a/Documentation/hwmon/ina2xx b/Documenta
2015-01-06 19:18 GMT+01:00 Guenter Roeck :
> ina226_avg_val() calculates the average value from ina226_avg_tab
> and then you loop through ina226_avg_tab to find the index into ina226_avg_tab
> again, only to use the thus calculated index for accessing ina226_avg_tab[]
> once more. Think about it.
2015-01-07 14:22 GMT+01:00 Guenter Roeck :
> I think I know what to do here. Can you look into the ina209 driver ?
> It uses update_interval and calculates the number of samples to use from it.
> The ina226 datasheet suggests that we can do the same, combined with the
> conversion time configuratio
2015-01-07 17:16 GMT+01:00 Guenter Roeck :
> INA219 uses the same mechanism and timing as used by INA209. This way
> it is easily possible to extend the driver to support the attribute
> for every chip. But overall this uses the existing ABI (update_interval
> is part of the hwmon ABI) instead of c
rrent configuration settings - this way we'll be able to restore the
configuration in case of an unexpected chip reset.
Signed-off-by: Bartosz Golaszewski
---
Documentation/hwmon/ina2xx | 3 +
drivers/hwmon/ina2xx.c | 133 +++--
2 files ch
2015-01-08 18:05 GMT+01:00 Guenter Roeck :
> What is the purpose of multiplying the calculated average by 2 ?
The comment above says:
> + /*
> + * Add bus and shunt voltage conversion times and multiple them
> + * by the averaging rate. Return the result in milliseconds.
> + */
rrent configuration settings - this way we'll be able to restore the
configuration in case of an unexpected chip reset.
Signed-off-by: Bartosz Golaszewski
---
Documentation/hwmon/ina2xx | 7 +++
drivers/hwmon/ina2xx.c | 140 ++---
2 files ch
2015-01-09 15:34 GMT+01:00 Guenter Roeck :
> Unfortunately that only applies to INA226 and not INA219, where the time is
> static
> (at least so far).
Oops, I must have missed this one.
> I think we'll need to store the time in ina2xx_data and use the old
> (constant)
> value for ina219. Maybe ad
rrent configuration settings - this way we'll be able to restore the
configuration in case of an unexpected chip reset.
Signed-off-by: Bartosz Golaszewski
---
Documentation/hwmon/ina2xx | 7 ++
drivers/hwmon/ina2xx.c | 164 +++--
2 files ch
current hwmon-next.
Bartosz Golaszewski (2):
hwmon: (ina2xx) remove an unnecessary dev_get_drvdata() result check
hwmon: (ina2xx) use DIV_ROUND_CLOSEST() to avoid rounding errors
drivers/hwmon/ina2xx.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
--
2.1.3
--
To
Use DIV_ROUND_CLOSEST() when dealing with the calibration values to make the
calculations less error prone.
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/ina2xx.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/ina2xx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index a16d6a2..ae110c5 100644
--- a/drivers/hwmon/ina2xx.c
+++ b/drivers/hwmon/ina2xx.c
@@ -370,9 +370,6 @@ static ssize_t
Use find_closest() to locate the closest average in ina226_avg_tab.
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/ina2xx.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index d1542b7..4d28150 100644
Replace the loop iterating over pwm_freq_cksel0 with a call to
find_closest_descending().
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/w83795.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c
index 2189413
Replace RANGE_TO_REG() and FREQ_TO_REG() implementations with
calls to find_closest().
Signed-off-by: Bartosz Golaszewski
---
drivers/hwmon/lm85.c | 26 --
1 file changed, 8 insertions(+), 18 deletions(-)
diff --git a/drivers/hwmon/lm85.c b/drivers/hwmon/lm85.c
index
me find_closest_desc() to find_closest_descending()
v2:
https://lkml.org/lkml/2015/3/10/582
v1:
https://lkml.org/lkml/2015/2/24/509
Bartosz Golaszewski (4):
util_macros.h: add find_closest() macro
hwmon: (ina2xx) replace ina226_avg_bits() with find_closest()
hwmon: (lm85) use find_c
401 - 500 of 3921 matches
Mail list logo