[PATCH v18 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-10-05 Thread Ben Levinsky
in zynqmp_r5_release, and mbox_free_channel - remove device_unregister call in zynqmp_r5_release - remove kzalloc for pdata (what is now called z_rproc) - update conditional in loop to calls of zynqmp_r5_probe - update example remoteproc zynqmp r5 compat string, remove version number

[PATCH v18 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-10-05 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v18 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-10-05 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-05 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

[PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-05 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v2: - remove

[PATCH v18 3/5] firmware: xilinx: Add RPU configuration APIs

2020-10-05 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

RE: [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-06 Thread Ben Levinsky
Hi Michael, Thanks for the review > -Original Message- > From: Michael Auchter > Sent: Monday, October 5, 2020 12:35 PM > To: Ben Levinsky > Cc: Ed T. Mooring ; sunnylian...@gmail.com; > punit1.agra...@toshiba.co.jp; Stefano Stabellini ; > Michal Simek ; devic

RE: RE: [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-06 Thread Ben Levinsky
> -Original Message- > From: Michael Auchter > Sent: Tuesday, October 6, 2020 2:32 PM > To: Ben Levinsky > Cc: Ed T. Mooring ; sunnylian...@gmail.com; > punit1.agra...@toshiba.co.jp; Stefano Stabellini ; > Michal Simek ; devicet...@vger.kernel.org; > mathieu.p

RE: RE: RE: [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-07 Thread Ben Levinsky
> -Original Message- > From: Michael Auchter > Sent: Tuesday, October 6, 2020 3:21 PM > To: Ben Levinsky > Cc: Ed T. Mooring ; Stefano Stabellini > ; Michal Simek ; > devicet...@vger.kernel.org; mathieu.poir...@linaro.org; linux- > remotep...@vger.

RE: [PATCH v17 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-02 Thread Ben Levinsky
so sorry about that... Otherwise I will fix up the memory management that is occurring in the driver as you describe. Again thank you! Ben > -Original Message- > From: Michael Auchter > Sent: Friday, October 2, 2020 11:59 AM > To: Ben Levinsky > Cc: sunnylian...@gmail.c

[PATCH v8 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-08-10 Thread Ben Levinsky
_drvdata as pdata is handled in zynqmp_r5_remoteproc_remove v8: - remove old acks, reviewed-by's in commit message Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU configuration APIs dt-bindings:

[PATCH v8 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-08-10 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Ben Levinsky Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek --- v3: - update zynqmp_r5 yaml

[PATCH v8 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-08-10 Thread Ben Levinsky
R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this remotproc driver, we can boot the R5 sub-system in different configurations. Signed-off-by: Ben Levinsky Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu --- v2

[PATCH v8 3/5] firmware: xilinx: Add RPU configuration APIs

2020-08-10 Thread Ben Levinsky
This patch adds APIs to provide access and a configuration interface to the current power state of a sub-system on Zynqmp sub-system. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add

[PATCH v8 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-08-10 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v8 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-08-10 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct - fix formatting v4: - add default values for enumv3: - add xilinx

RE: [PATCH v16 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-30 Thread Ben Levinsky
Hi Rob, > -Original Message- > From: Rob Herring > Sent: Tuesday, September 29, 2020 11:36 AM > To: Ben Levinsky > Cc: Stefano Stabellini ; Michal Simek > ; michael.auch...@ni.com; devicet...@vger.kernel.org; > mathieu.poir...@linaro.org; Ed T. Moori

[PATCH v17 3/5] firmware: xilinx: Add RPU configuration APIs

2020-10-01 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v17 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-10-01 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v17 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-01 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

[PATCH v17 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-10-01 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v17 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-01 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky Reported

[PATCH v17 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-10-01 Thread Ben Levinsky
check for pdata->pnode_id == 0 is not needed v17: - remove compatible string from tcm bank nodes - fix style for bindings - add boolean type to lockstep mode in binding - add/update descriptions memory-region, meta-memory-regions, pnode-id, mbox* properties - update driver as per kernel-te

RE: RE: RE: [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-15 Thread Ben Levinsky
Hi All, > -Original Message- > From: Michael Auchter > Sent: Tuesday, October 6, 2020 3:21 PM > To: Ben Levinsky > Cc: Ed T. Mooring ; Stefano Stabellini > ; Michal Simek ; > devicet...@vger.kernel.org; mathieu.poir...@linaro.org; linux- > remotep...@vger.

RE: [PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-08 Thread Ben Levinsky
Hi Linus, Thanks for the review Please see my comments inline > > Hi Ben, > > thanks for your patch! I noticed this today and pay some interest > because in the past I used with implementing the support for > TCM memory on ARM32. > > On Mon, Oct 5, 2020 at 6:06

RE: [PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-08 Thread Ben Levinsky
Hi Sorry there were some typos and errors in my response so I'll correct them below: > -Original Message- > From: Ben Levinsky > Sent: Thursday, October 8, 2020 7:21 AM > To: Linus Walleij ; Catalin Marinas > ; Stefano Stabellini ; Ed T. > Mooring > Cc: Ed T

[PATCH v14 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-09-17 Thread Ben Levinsky
zynqmp_r5_remoteproc::zynqmp_r5_probe if the index is valid - remove uneven dev_dbg/dev_err fn calls Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU configuration APIs dt-bindings:

[PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-17 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v2: - remove

[PATCH v14 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-09-17 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v14 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-17 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

[PATCH v14 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-09-17 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v14 3/5] firmware: xilinx: Add RPU configuration APIs

2020-09-17 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

RE: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-17 Thread Ben Levinsky
Hi Michael, Thanks for the comments, > -Original Message- > From: Michael Auchter > Sent: Thursday, September 17, 2020 3:11 PM > To: Ben Levinsky > Cc: punit1.agra...@toshiba.co.jp; Stefano Stabellini ; > Michal Simek ; devicet...@vger.kernel.org; > mathieu.poi

[PATCH v9 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-08-26 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v9 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-08-26 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Ben Levinsky Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek --- v3: - update zynqmp_r5 yaml

[PATCH v9 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-08-26 Thread Ben Levinsky
he file. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct - fix formatting v4: - add default values for enumv3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in x

[PATCH v9 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-08-26 Thread Ben Levinsky
, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Ben Levinsky Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu --- v2: - remove domain struct

[PATCH v9 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-08-26 Thread Ben Levinsky
racefully inform user via dev_dbg if not present - change lockstep_mode from u32* to u32 - update zynqmp_pm_set_rpu_mode and zynqmp_pm_set_rpu_mode documentation and remove unused args Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: x

[PATCH v9 3/5] firmware: xilinx: Add RPU configuration APIs

2020-08-26 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

RE: [PATCH v9 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-08-26 Thread Ben Levinsky
Hi Michael, Thanks for the catch, will update in v10 > -Original Message- > From: Michael Auchter > Sent: Wednesday, August 26, 2020 2:32 PM > To: Ben Levinsky > Cc: Stefano Stabellini ; Michal Simek > ; devicet...@vger.kernel.org; > mathieu.poir...@linaro.org;

[PATCH v10 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-08-26 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v10 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-08-26 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Ben Levinsky Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek --- v3: - update zynqmp_r5 yaml

[PATCH v9 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-08-26 Thread Ben Levinsky
racefully inform user via dev_dbg if not present - change lockstep_mode from u32* to u32 - update zynqmp_pm_set_rpu_mode and zynqmp_pm_set_rpu_mode documentation and remove unused args v10: - add include types.h to xlnx-zynqmp.h for compilation Ben Levinsky (5): firmware: xilinx: Add Zyn

[PATCH v10 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-08-26 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v10 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-08-26 Thread Ben Levinsky
, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Ben Levinsky Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu --- v2: - remove domain struct

[PATCH v10 3/5] firmware: xilinx: Add RPU configuration APIs

2020-08-26 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

RE: [PATCH v9 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-08-27 Thread Ben Levinsky
r comments? With that being said, I will make sure the R51 case is more completely covered. Thanks Ben > -Original Message- > From: Michael Auchter > Sent: Thursday, August 27, 2020 6:48 AM > To: Ben Levinsky > Cc: Stefano Stabellini ; Michal Simek > ; devicet...@vge

RE: [PATCH v9 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-01 Thread Ben Levinsky
Hi Michael, > -Original Message- > From: Michael Auchter > Sent: Wednesday, August 26, 2020 2:32 PM > To: Ben Levinsky > Cc: Stefano Stabellini ; Michal Simek > ; devicet...@vger.kernel.org; > mathieu.poir...@linaro.org; Ed T. Mooring ; linux- > remotep...@vger.

RE: [PATCH v9 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-01 Thread Ben Levinsky
Hi Michael, I put some comments inline on reworking the zynqmp_pm* functions Best, Ben > -Original Message- > From: Ben Levinsky > Sent: Tuesday, September 1, 2020 8:10 AM > To: Michael Auchter > Cc: devicet...@vger.kernel.org; linux-remotep...@vger.kernel.or

RE: RE: RE: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-20 Thread Ben Levinsky
Hi All, > -Original Message- > From: Wendy Liang > Sent: Friday, September 18, 2020 6:53 PM > To: Michael Auchter > Cc: Ben Levinsky ; punit1.agra...@toshiba.co.jp; > devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kern

[PATCH v15 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-09-21 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v15 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-21 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

[PATCH v15 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-09-21 Thread Ben Levinsky
zynqmp_r5_remoteproc::zynqmp_r5_probe if the index is valid - remove uneven dev_dbg/dev_err fn calls v15: - change lockstep mode device tree property from acting as boolean, to instead being used as, if it is present, then r5 is in lockstep mode. otherwise in split. - add safeguard for if 2 rpu r

[PATCH v15 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-09-21 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v15 3/5] firmware: xilinx: Add RPU configuration APIs

2020-09-21 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v15 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-21 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v2: - remove

[PATCH v23 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-11-14 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v23 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-14 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- - Rework R5

[PATCH v23 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-11-14 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- - Update grammar

[PATCH v23 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-11-14 Thread Ben Levinsky
version: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=376801 Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU configuration APIs dt-bindings: remoteproc: Add

[PATCH v23 3/5] firmware: xilinx: Add RPU configuration APIs

2020-11-14 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v23 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-11-14 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration and TCM Nodes for later use via request_node and release_node Signed-off-by: Ben Levinsky --- v23: add TCM Node IDs to be used in R5 Remoteproc driver --- include/linux/firmware/xlnx-zynqmp.h | 23 +++ 1 file changed, 23

[PATCH v20 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-10-30 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v20 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-10-30 Thread Ben Levinsky
config Previous version https://patchwork.kernel.org/project/linux-remoteproc/list/?series=367125 Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU configuration APIs dt-bi

[PATCH v20 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-10-30 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- include/linux/firmware/xlnx-zynqmp.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h index 5968df82b991

[PATCH v20 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-30 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v20: - update typos and style

[PATCH v20 3/5] firmware: xilinx: Add RPU configuration APIs

2020-10-30 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v20 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-30 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- - remove

RE: [PATCH v23 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-30 Thread Ben Levinsky
Hi Mathieu, Thanks for the tip. I will fix up the DT Schema bot output this week then Best Ben > -Original Message- > From: Mathieu Poirier > Sent: Monday, November 30, 2020 7:32 AM > To: Ben Levinsky > Cc: devicet...@vger.kernel.org; linux-remotep...@vger.kernel.or

[PATCH v24 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-11-30 Thread Ben Levinsky
minor comments in v22 review Previous version: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=384227 Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU

[PATCH v24 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-30 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- drivers

[PATCH v24 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-11-30 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v24: update for 'make

[PATCH v24 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-11-30 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration and TCM Nodes for later use via request_node and release_node Signed-off-by: Ben Levinsky --- include/linux/firmware/xlnx-zynqmp.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/linux/firmware/xlnx

[PATCH v24 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-11-30 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v24 3/5] firmware: xilinx: Add RPU configuration APIs

2020-11-30 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

RE: [PATCH v23 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-29 Thread Ben Levinsky
Ping for comments > -Original Message- > From: Ben Levinsky > Sent: Saturday, November 14, 2020 8:49 AM > To: mathieu.poir...@linaro.org > Cc: devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infra

[PATCH v12 3/5] firmware: xilinx: Add RPU configuration APIs

2020-09-03 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v12 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-09-03 Thread Ben Levinsky
_check' v12: - update signed off by so that latest developer name is last - in drivers/firmware/zynqmp.c, update zynqmp_pm_set_rpu_mode so rpu_mode is only set if no error - update args for zynqmp_pm_set_rpu_mode, zynqmp_pm_set_tcm_config fn arg's to reflect what is expected in the function and th

[PATCH v12 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-09-03 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v12 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-09-03 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v12 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-03 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

[PATCH v12 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-03 Thread Ben Levinsky
, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v2: - remove domain struct

[PATCH v13 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-04 Thread Ben Levinsky
, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v2: - remove domain struct

[PATCH v13 3/5] firmware: xilinx: Add RPU configuration APIs

2020-09-04 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v13 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-09-04 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v13 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-04 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

[PATCH v13 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-09-04 Thread Ben Levinsky
he usage in zynqmp_r5_remoteproc accordingly v13: - zynqmp_pm_get_rpu_mode argument zynqmp_pm_get_rpu_mode is only set if no error Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU

[PATCH v13 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-09-04 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

RE: [PATCH v2 1/4] dt-bindings: remoteproc: Add bindings for R5F subsystem on TI K3 SoCs

2020-08-24 Thread Ben Levinsky
> -Original Message- > From: Suman Anna > Sent: Thursday, August 20, 2020 2:54 PM > To: Stefano Stabellini ; Mathieu Poirier > ; Rob Herring ; Stefano > Stabellini ; Ben Levinsky > Cc: Bjorn Andersson ; Lokesh Vutla > ; linux-remotep...@vger.kernel.org; >

RE: [PATCH v8 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-08-24 Thread Ben Levinsky
Hi Stefano This is just response to few unanswered comments Thanks Ben > -Original Message- > From: linux-remoteproc-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Ben Levinsky > Sent: Thursday, August 20, 2020 8:13 AM > To: Stefano Stabellini > Cc: Mich

RE: [PATCH v8 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-08-24 Thread Ben Levinsky
Hi Stefano > -Original Message- > From: linux-remoteproc-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Ben Levinsky > Sent: Tuesday, August 18, 2020 7:24 AM > To: Stefano Stabellini > Cc: Michal Simek ; devicet...@vger.kernel.org; > mathieu.poir...@lina

RE: [PATCH v8 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-08-20 Thread Ben Levinsky
> -Original Message- > From: Stefano Stabellini > Sent: Wednesday, August 19, 2020 2:21 PM > To: Ben Levinsky > Cc: Stefano Stabellini ; Michal Simek > ; devicet...@vger.kernel.org; > mathieu.poir...@linaro.org; Ed T. Mooring ; linux- > remotep...@vger.

[PATCH v11 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-09-02 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v11 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-09-02 Thread Ben Levinsky
of string name - print device tree nodes with %pOF instead of %s with node name field - update tcm release to unmap VA - handle r5-1 use case - device tree binding r5 node to have link to TCMs via meta-memory-regions property - fix device tree binding so no warnings from 'make dt_binding_check'

[PATCH v11 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-02 Thread Ben Levinsky
, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Ben Levinsky Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu --- v2: - remove domain struct

[PATCH v11 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-02 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Ben Levinsky Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek --- v3: - update zynqmp_r5 yaml

[PATCH v11 3/5] firmware: xilinx: Add RPU configuration APIs

2020-09-02 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v11 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-09-02 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

RE: [PATCH v8 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-08-18 Thread Ben Levinsky
> -Original Message- > From: Stefano Stabellini > Sent: Thursday, August 13, 2020 1:36 PM > To: Ben Levinsky > Cc: Stefano Stabellini ; Michal Simek > ; devicet...@vger.kernel.org; > mathieu.poir...@linaro.org; Ed T. Mooring ; linux- > remotep...@vger.

RE: [PATCH v8 3/5] firmware: xilinx: Add RPU configuration APIs

2020-08-18 Thread Ben Levinsky
> -Original Message- > From: Stefano Stabellini > Sent: Thursday, August 13, 2020 1:36 PM > To: Ben Levinsky > Cc: Stefano Stabellini ; Michal Simek > ; devicet...@vger.kernel.org; > mathieu.poir...@linaro.org; Ed T. Mooring ; linux- > remotep...@vger.

  1   2   >