Re: [PATCH v2 0/3] arm/dts: omap: add dt data for MUSB

2012-09-11 Thread Benoit Cousson
On 09/11/2012 10:44 AM, ABRAHAM, KISHON VIJAY wrote: Hi Benoit, On Tue, Sep 11, 2012 at 1:55 PM, Benoit Cousson b-cous...@ti.com wrote: On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: No major change from the previous version. Just removed the omap-usb2 dt data and sent

Re: [PATCH v2 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-11 Thread Benoit Cousson
to control module, omap2430 will handle the register writes to control module by itself. So a new address space to represent this control module register is added to usb_otg_hs. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Acked-by: Benoit Cousson b-cous...@ti.com --- arch/arm/mach

Re: [PATCH v2 1/3] arm/dts: Add twl6030-usb data

2012-09-11 Thread Benoit Cousson
On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: Add twl6030-usb data node in twl6030 device tree file Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm/boot/dts/omap4-panda.dts |4 arch/arm/boot/dts/omap4-sdp.dts |4

Re: [PATCH v2 0/3] arm/dts: omap: add dt data for MUSB

2012-09-11 Thread Benoit Cousson
On 09/11/2012 11:16 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Tue, Sep 11, 2012 at 2:41 PM, Benoit Cousson b-cous...@ti.com wrote: On 09/11/2012 10:44 AM, ABRAHAM, KISHON VIJAY wrote: Hi Benoit, On Tue, Sep 11, 2012 at 1:55 PM, Benoit Cousson b-cous...@ti.com wrote: On 09/11/2012 08:36 AM

Re: [PATCH v2 1/3] arm/dts: Add twl6030-usb data

2012-09-11 Thread Benoit Cousson
On 09/11/2012 11:39 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Tue, Sep 11, 2012 at 2:56 PM, Benoit Cousson b-cous...@ti.com wrote: On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: Add twl6030-usb data node in twl6030 device tree file Acked-by: Felipe Balbi ba...@ti.com Signed-off

Re: [PATCH v2 2/3] arm/dts: Add twl4030-usb data

2012-09-11 Thread Benoit Cousson
On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: Add twl4030-usb data node in twl4030 device tree file. IIRC, the usb part on twl4030 was doing more than it does on twl6030. Could you describe what part of the USB is really done by the TWL in that case? Acked-by: Felipe Balbi

Re: [PATCH v2 3/3] arm/dts: omap: Add usb_otg and glue data

2012-09-11 Thread Benoit Cousson
On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-board.dts file. Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Kishon Vijay Abraham I kis...@ti.com ---

Re: [PATCH v2 0/3] arm/dts: omap: add dt data for MUSB

2012-09-11 Thread Benoit Cousson
Hi Kishon, Beside minor comments and the lack of explicit changelog to explain what part of the HW you are addressing, this series looks good. I guess that series should be rebased on top of lo/devel-dt without much trouble. On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: No major change

Re: [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware

2012-09-10 Thread Benoit Cousson
On 09/10/2012 06:52 PM, Matt Porter wrote: > On Mon, Sep 10, 2012 at 06:34:20PM +0200, Benoit Cousson wrote: >> + Tony >> >> Hi Matt, >> >> 30 minutes too late for my pull request :-( >> >> There are a couple of am33xx patches under discussion, so I

Re: [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware

2012-09-10 Thread Benoit Cousson
+ Tony Hi Matt, 30 minutes too late for my pull request :-( There are a couple of am33xx patches under discussion, so I'll take them and send a for_3.7/dts-part2 pull request if this is not too late for Tony. On 09/10/2012 06:20 PM, Matt Porter wrote: > On AM33xx, the datasheet and TRM refer

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-10 Thread Benoit Cousson
in control module. >>>>>> On detection of any events VBUS or ID, this register should be written >>>>>> to send the notification to musb core. >>>>>> >>>>>> Till we have a separate control module driver to write to control

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-10 Thread Benoit Cousson
driver to write to control module, omap2430 will handle the register writes to control module by itself. So a new address space to represent this control module register is added to usb_otg_hs. Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm

Re: [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware

2012-09-10 Thread Benoit Cousson
+ Tony Hi Matt, 30 minutes too late for my pull request :-( There are a couple of am33xx patches under discussion, so I'll take them and send a for_3.7/dts-part2 pull request if this is not too late for Tony. On 09/10/2012 06:20 PM, Matt Porter wrote: On AM33xx, the datasheet and TRM refer to

Re: [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware

2012-09-10 Thread Benoit Cousson
On 09/10/2012 06:52 PM, Matt Porter wrote: On Mon, Sep 10, 2012 at 06:34:20PM +0200, Benoit Cousson wrote: + Tony Hi Matt, 30 minutes too late for my pull request :-( There are a couple of am33xx patches under discussion, so I'll take them and send a for_3.7/dts-part2 pull request

Re: [RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-09-07 Thread Benoit Cousson
ilman [b-cous...@ti.com: Fix some checkpatch CHECK issues] Signed-off-by: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod.c | 27 ++ arch/arm/plat-omap/include/plat/omap_hwmod.h |1 + arch/arm/plat-omap/omap_device.c | 71 + 3 files cha

Re: [RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-09-07 Thread Benoit Cousson
ilman [b-cous...@ti.com: Fix some checkpatch CHECK issues] Signed-off-by: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod.c | 27 ++ arch/arm/plat-omap/include/plat/omap_hwmod.h |1 + arch/arm/plat-omap/omap_device.c | 71 + 3 fi

Re: [RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-09-07 Thread Benoit Cousson
Hilman khil...@ti.com [b-cous...@ti.com: Fix some checkpatch CHECK issues] Signed-off-by: Benoit Cousson b-cous...@ti.com --- arch/arm/mach-omap2/omap_hwmod.c | 27 ++ arch/arm/plat-omap/include/plat/omap_hwmod.h |1 + arch/arm/plat-omap/omap_device.c | 71

Re: [RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-09-07 Thread Benoit Cousson
khil...@ti.com [b-cous...@ti.com: Fix some checkpatch CHECK issues] Signed-off-by: Benoit Cousson b-cous...@ti.com --- arch/arm/mach-omap2/omap_hwmod.c | 27 ++ arch/arm/plat-omap/include/plat/omap_hwmod.h |1 + arch/arm/plat-omap/omap_device.c | 71

Re: [PATCH 0/2] OMAP: hwmod: fix hardreset handling

2012-09-06 Thread Benoit Cousson
Hi Omar, On 09/03/2012 04:29 PM, Omar Ramirez Luna wrote: > On 22 August 2012 00:42, Omar Ramirez Luna wrote: >> From: Omar Ramirez Luna >> >> The patch to expose hwmod assert/deassert functions through omap_device >> has been accepted and queued for 3.7[1], however these two patches are >>

Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-06 Thread Benoit Cousson
Hi Omar, On 08/22/2012 07:42 AM, Omar Ramirez Luna wrote: > For a reset sequence to complete cleanly, a module needs its > associated clocks to be enabled, otherwise the timeout check > in prcm code can print a false failure (failed to hardreset) > that occurs because the clocks aren't powered ON

Re: [PATCH 0/2] arm/dts: AM33XX: Add reg and interrupt property for all nodes

2012-09-06 Thread Benoit Cousson
Hi Vaihbav, On 08/27/2012 02:31 PM, Vaibhav Hiremath wrote: > This series is trivial patch-series and should be considered as > preparation for the future where we supposed to get rid of > hwmod dependency. > > 1/2: Converts all hex numbers to lowercase, fixing inconsistency > 2/2: Add reg and

Re: [PATCH 0/2] arm/dts: AM33XX: Add reg and interrupt property for all nodes

2012-09-06 Thread Benoit Cousson
Hi Vaihbav, On 08/27/2012 02:31 PM, Vaibhav Hiremath wrote: This series is trivial patch-series and should be considered as preparation for the future where we supposed to get rid of hwmod dependency. 1/2: Converts all hex numbers to lowercase, fixing inconsistency 2/2: Add reg and

Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-06 Thread Benoit Cousson
Hi Omar, On 08/22/2012 07:42 AM, Omar Ramirez Luna wrote: For a reset sequence to complete cleanly, a module needs its associated clocks to be enabled, otherwise the timeout check in prcm code can print a false failure (failed to hardreset) that occurs because the clocks aren't powered ON and

Re: [PATCH 0/2] OMAP: hwmod: fix hardreset handling

2012-09-06 Thread Benoit Cousson
Hi Omar, On 09/03/2012 04:29 PM, Omar Ramirez Luna wrote: On 22 August 2012 00:42, Omar Ramirez Luna omar.l...@linaro.org wrote: From: Omar Ramirez Luna omar.rami...@ti.com The patch to expose hwmod assert/deassert functions through omap_device has been accepted and queued for 3.7[1],

Re: [RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-08-31 Thread Benoit Cousson
On 08/31/2012 05:36 PM, Hiremath, Vaibhav wrote: > On Fri, Aug 31, 2012 at 20:54:53, Cousson, Benoit wrote: ... > I think you are getting confused between Vaibhav B and Vaibhav H :) > We have two Vaibhav's roaming around here ;-) Oops, sorry, this is the very first time I realized that two

Re: [RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-08-31 Thread Benoit Cousson
should get all the > resources from hwmod (following existing steps) > > Signed-off-by: Vaibhav Hiremath > Cc: Benoit Cousson > Cc: Tony Lindgren > Cc: Paul Walmsley > Cc: Kevin Hilman > --- > This patch is tested on BeagleBone and AM37xEVM. I'll

Re: [PATCHv3 0/4] Add device tree data for omap5

2012-08-31 Thread Benoit Cousson
Hi Sourav, While rebasing your series on top of Tony's lo/devel-dt, I realized that the keypad nodes are not located at the correct place :-( At the moment they are just floating at the top level of the dts while they belong to the ocp bus and thus should be put there. I fixed that since it

Re: [PATCHv3 0/4] Add device tree data for omap5

2012-08-31 Thread Benoit Cousson
Hi Sourav, While rebasing your series on top of Tony's lo/devel-dt, I realized that the keypad nodes are not located at the correct place :-( At the moment they are just floating at the top level of the dts while they belong to the ocp bus and thus should be put there. I fixed that since it

Re: [RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-08-31 Thread Benoit Cousson
-by: Vaibhav Hiremath hvaib...@ti.com Cc: Benoit Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com --- This patch is tested on BeagleBone and AM37xEVM. I'll try to do more testing on Panda next week. Why RFC? Still we

Re: [RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-08-31 Thread Benoit Cousson
On 08/31/2012 05:36 PM, Hiremath, Vaibhav wrote: On Fri, Aug 31, 2012 at 20:54:53, Cousson, Benoit wrote: ... I think you are getting confused between Vaibhav B and Vaibhav H :) We have two Vaibhav's roaming around here ;-) Oops, sorry, this is the very first time I realized that two different

Re: [PATCH 1/3] ARM: OMAP: hwmod: partially un-reset hwmods might not be properly enabled

2012-08-20 Thread Benoit Cousson
Hi Omar, On 07/16/2012 09:21 PM, Omar Ramirez Luna wrote: > Some IP blocks might not be using/controlling more than one > reset line, this check loosens the restriction to fully use > hwmod framework for those drivers. > > E.g.: ipu has reset lines: mmu_cache, cpu0 and cpu1. > - cpu1 might not

Re: [PATCHv3 0/4] Add device tree data for omap5

2012-08-20 Thread Benoit Cousson
On 08/20/2012 02:17 PM, Poddar, Sourav wrote: > Hi Benoit, > > On Mon, Aug 20, 2012 at 5:43 PM, Benoit Cousson wrote: >> On 08/20/2012 02:10 PM, Poddar, Sourav wrote: >>> Hi All, >>> >>> On Tue, Aug 14, 2012 at 9:54 PM, Sourav Poddar wrote: >&

Re: [PATCHv3 0/4] Add device tree data for omap5

2012-08-20 Thread Benoit Cousson
add onchip keypad dts data. >> >> Cc: Benoit Cousson >> Cc: Felipe Balbi >> Cc: Santosh Shilimkar >> >> Sourav Poddar (4): >> arm/dts: omap5-evm: Add I2C support >> arm/dts: omap5-evm: Add tmp102 sensor support >> arm/dts: omap5-evm

Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data

2012-08-20 Thread Benoit Cousson
map4-sdp" dts file. >> >> Tested on omap4430 sdp. >> >> Cc: Tony Lindgren >> Cc: Benoit Cousson >> Cc: Rob Herring >> Cc: Grant Likely >> Cc: Felipe Balbi >> Signed-off-by: Sourav Poddar >> --- >> v6->v7 >> Add key name a

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-20 Thread Benoit Cousson
Hi Omar, On 08/03/2012 05:52 PM, Omar Ramirez Luna wrote: > On 3 August 2012 00:24, Vaibhav Hiremath wrote: >> On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote: >>> So in _enable: >>> >>> _enable_clocks(oh); >>> if (soc_ops.enable_module) >>>

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-20 Thread Benoit Cousson
Hi Omar, On 08/03/2012 05:52 PM, Omar Ramirez Luna wrote: On 3 August 2012 00:24, Vaibhav Hiremath hvaib...@ti.com wrote: On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote: So in _enable: _enable_clocks(oh); if (soc_ops.enable_module) soc_ops.enable_module(oh);

Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data

2012-08-20 Thread Benoit Cousson
on omap4430 sdp. Cc: Tony Lindgren t...@atomide.com Cc: Benoit Cousson b-cous...@ti.com Cc: Rob Herring rob.herr...@calxeda.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Felipe Balbi ba...@ti.com Signed-off-by: Sourav Poddar sourav.pod...@ti.com --- v6-v7 Add key name as a comment

Re: [PATCHv3 0/4] Add device tree data for omap5

2012-08-20 Thread Benoit Cousson
keypad dts data. Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Sourav Poddar (4): arm/dts: omap5-evm: Add I2C support arm/dts: omap5-evm: Add tmp102 sensor support arm/dts: omap5-evm: Add keypad data arm/dts: omap5-evm

Re: [PATCHv3 0/4] Add device tree data for omap5

2012-08-20 Thread Benoit Cousson
On 08/20/2012 02:17 PM, Poddar, Sourav wrote: Hi Benoit, On Mon, Aug 20, 2012 at 5:43 PM, Benoit Cousson b-cous...@ti.com wrote: On 08/20/2012 02:10 PM, Poddar, Sourav wrote: Hi All, On Tue, Aug 14, 2012 at 9:54 PM, Sourav Poddar sourav.pod...@ti.com wrote: The following patch series add

Re: [PATCH 1/3] ARM: OMAP: hwmod: partially un-reset hwmods might not be properly enabled

2012-08-20 Thread Benoit Cousson
Hi Omar, On 07/16/2012 09:21 PM, Omar Ramirez Luna wrote: Some IP blocks might not be using/controlling more than one reset line, this check loosens the restriction to fully use hwmod framework for those drivers. E.g.: ipu has reset lines: mmu_cache, cpu0 and cpu1. - cpu1 might not be used

Re: [PATCHv2 0/4] Add device tree data for omap5

2012-08-14 Thread Benoit Cousson
rc1, what based did you use? Benoit > > Cc: Benoit Cousson > Cc: Felipe Balbi > Cc: Santosh Shilimkar > > Sourav Poddar (4): > arm/dts: omap5-evm: Add I2C support > arm/dts: omap5-evm: Add tmp102 sensor support > arm/dts: omap5-evm: Add keypad data >

Re: [PATCHv2 2/4] arm/dts: omap5-evm: Add tmp102 sensor support

2012-08-14 Thread Benoit Cousson
Hi Felipe, On 08/14/2012 11:59 AM, Felipe Balbi wrote: > On Tue, Aug 14, 2012 at 11:56:45AM +0200, Benoit Cousson wrote: >> On 08/13/2012 12:05 PM, Sourav Poddar wrote: >>> Add tmp102 temperature sensor data in omap5 evm dts file. >>> >>> Tested on omap5430 ev

Re: [PATCHv2 2/4] arm/dts: omap5-evm: Add tmp102 sensor support

2012-08-14 Thread Benoit Cousson
On 08/13/2012 12:05 PM, Sourav Poddar wrote: > Add tmp102 temperature sensor data in omap5 evm dts file. > > Tested on omap5430 evm with 3.5 custom kernel. > > Cc: Benoit Cousson > Cc: Felipe Balbi > Cc: Santosh Shilimkar > Acked-by: Felipe Balbi > Signed-off-by: S

Re: [PATCHv2 2/4] arm/dts: omap5-evm: Add tmp102 sensor support

2012-08-14 Thread Benoit Cousson
On 08/13/2012 12:05 PM, Sourav Poddar wrote: Add tmp102 temperature sensor data in omap5 evm dts file. Tested on omap5430 evm with 3.5 custom kernel. Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Felipe Balbi ba

Re: [PATCHv2 2/4] arm/dts: omap5-evm: Add tmp102 sensor support

2012-08-14 Thread Benoit Cousson
Hi Felipe, On 08/14/2012 11:59 AM, Felipe Balbi wrote: On Tue, Aug 14, 2012 at 11:56:45AM +0200, Benoit Cousson wrote: On 08/13/2012 12:05 PM, Sourav Poddar wrote: Add tmp102 temperature sensor data in omap5 evm dts file. Tested on omap5430 evm with 3.5 custom kernel. Cc: Benoit Cousson b

Re: [PATCHv2 0/4] Add device tree data for omap5

2012-08-14 Thread Benoit Cousson
based did you use? Benoit Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Sourav Poddar (4): arm/dts: omap5-evm: Add I2C support arm/dts: omap5-evm: Add tmp102 sensor support arm/dts: omap5-evm: Add keypad data arm

Re: [PATCH 04/11] MFD: twl4030-audio: Add DT support

2012-08-08 Thread Benoit Cousson
On 08/08/2012 04:35 PM, Peter Ujfalusi wrote: > On 08/08/2012 03:52 PM, Mark Brown wrote: >> On Wed, Aug 08, 2012 at 01:50:53PM +0200, Benoit Cousson wrote: >> >>> That being said, since we do have the clock binding now, maybe we should >>> create a clock provid

Re: [PATCH 04/11] MFD: twl4030-audio: Add DT support

2012-08-08 Thread Benoit Cousson
Hi Peter, On 08/08/2012 11:41 AM, Peter Ujfalusi wrote: > Support for loading the twl4030 audio module via devicetree. > Sub devices for codec and vibra will be created as mfd devices once the > core MFD driver is loaded when the kernel is booted with a DT blob. > > Signed-off-by: Peter Ujfalusi

Re: [PATCH 04/11] MFD: twl4030-audio: Add DT support

2012-08-08 Thread Benoit Cousson
Hi Peter, On 08/08/2012 11:41 AM, Peter Ujfalusi wrote: Support for loading the twl4030 audio module via devicetree. Sub devices for codec and vibra will be created as mfd devices once the core MFD driver is loaded when the kernel is booted with a DT blob. Signed-off-by: Peter Ujfalusi

Re: [PATCH 04/11] MFD: twl4030-audio: Add DT support

2012-08-08 Thread Benoit Cousson
On 08/08/2012 04:35 PM, Peter Ujfalusi wrote: On 08/08/2012 03:52 PM, Mark Brown wrote: On Wed, Aug 08, 2012 at 01:50:53PM +0200, Benoit Cousson wrote: That being said, since we do have the clock binding now, maybe we should create a clock provider at board level for the sys_clk and thus you

Re: [PATCH] hwmon: tmp102: Add device tree support

2012-08-03 Thread Benoit Cousson
Hi Sourav, On 08/03/2012 02:35 PM, Sourav Poddar wrote: > update tmp102 temperature sensor to also use device tree. > > Cc: Benoit Cousson > Cc: Felipe Balbi > Cc: Santosh Shilimkar > Acked-by: Felipe Balbi > Signed-off-by: Sourav Poddar > --- > dr

Re: [PATCH] hwmon: tmp102: Add device tree support

2012-08-03 Thread Benoit Cousson
Hi Sourav, On 08/03/2012 02:35 PM, Sourav Poddar wrote: update tmp102 temperature sensor to also use device tree. Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Sourav

<    1   2   3   4