Re: [PATCH v2 2/3] remoteproc: Introduce deny_sysfs_ops flag

2020-11-20 Thread Bjorn Andersson
On Fri 20 Nov 21:01 CST 2020, Suman Anna wrote: > The remoteproc framework provides sysfs interfaces for changing > the firmware name and for starting/stopping a remote processor > through the sysfs files 'state' and 'firmware'. The 'recovery' > sysfs file can also be used similarly to control the

Re: [PATCH] remoteproc: Add a rproc_set_firmware() API

2020-11-20 Thread Bjorn Andersson
t; to reuse this function to avoid code duplication. > > Signed-off-by: Suman Anna Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/remoteproc/remoteproc_core.c | 63 +++ > drivers/remoteproc/remoteproc_sysfs.c | 33 +- > include/li

Re: [PATCH V1 3/3] arm64: dts: qcom: sm8150: Add LLC support for sm8150

2020-11-19 Thread Bjorn Andersson
On Wed 30 Sep 03:14 CDT 2020, Souradeep Chowdhury wrote: > Add LLCC system cache controller entry for sm8150 to support sm8150 > for LLCC. > Thank you for your patches Souradeep, unfortunately there where some indentation issues that you would have seen if you ran ./scripts/checkpatch.pl --stric

Re: [PATCH v2] interconnect: qcom: qcs404: Remove GPU and display RPM IDs

2020-11-18 Thread Bjorn Andersson
GPU and display nodes. > Since these particular nodes aren't supported on RPM and are purely > local, we should just change their mas_rpm_id to -1 to avoid any > requests being sent for these master IDs. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Georgi Djakov

Re: [PATCH 1/2] remoteproc: qcom_q6v5_mss: Replace ioremap with memremap

2020-11-18 Thread Bjorn Andersson
On Wed 04 Nov 01:03 CST 2020, Sibi Sankar wrote: > Fix the sparse warnings reported by the kernel test bot by replacing > ioremap calls with memremap. > > Reported-by: kernel test robot Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Sibi Sankar > --- >

Re: [PATCH v7 4/4] remoteproc: qcom: Add minidump id for sm8150 modem

2020-11-18 Thread Bjorn Andersson
On Tue 03 Nov 03:19 CST 2020, Siddharth Gupta wrote: > Add minidump id for modem in sm8150 chipset so that the regions to be > included in the coredump generated upon a crash is based on the minidump > tables in SMEM instead of those in the ELF header. > Reviewed-by: Bjorn Andersso

Re: [PATCH v7 3/4] remoteproc: qcom: Add capability to collect minidumps

2020-11-18 Thread Bjorn Andersson
On Tue 03 Nov 03:19 CST 2020, Siddharth Gupta wrote: > This patch adds support for collecting minidump in the event of remoteproc > crash. Parse the minidump table based on remoteproc's unique minidump-id, > read all memory regions from the remoteproc's minidump table entry and > expose the memory

[PATCH] arm64: defconfig: Enable QCOM_SCM as builtin

2020-11-18 Thread Bjorn Andersson
peripherals. Mark QCOM_SCM as builtin, to avoid this. Cc: John Stultz Signed-off-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index d129340a7ed1..287ccf98dc41 100644 --- a/arch/arm64

Re: [PATCH v7 2/4] remoteproc: coredump: Add minidump functionality

2020-11-18 Thread Bjorn Andersson
On Tue 03 Nov 03:19 CST 2020, Siddharth Gupta wrote: > This change adds a new kind of core dump mechanism which instead of dumping > entire program segments of the firmware, dumps sections of the remoteproc > memory which are sufficient to allow debugging the firmware. This function > thus uses se

Re: [PATCH v7 1/4] remoteproc: core: Add ops to enable custom coredump functionality

2020-11-18 Thread Bjorn Andersson
in place of rproc_coredump. If the coredump op is not specified by the > remoteproc driver it will be set to rproc_coredump by default. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Siddharth Gupta > --- > drivers/remoteproc/remoteproc_core.c | 6 +- &g

Re: [PATCH v2 4/4] clk: qcom: Add support for SDX55 RPMh clocks

2020-11-18 Thread Bjorn Andersson
> Signed-off-by: Manivannan Sadhasivam Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/clk/qcom/clk-rpmh.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > index e2c66

Re: [PATCH v2] Bluetooth: btqca: Add support to read FW build version for WCN3991 BTSoC

2020-11-18 Thread Bjorn Andersson
On Wed 18 Nov 06:52 CST 2020, Venkata Lakshmi Narayana Gubba wrote: > Add support to read FW build version for WCN3991 BTSoC Your commit message doesn't describe why you need/want this? Is it somehow required for BT to come up or is it simply 57 lines of code to print a line of build info in the

Re: [PATCH v2 2/4] mtd: parsers: Add Qcom SMEM parser

2020-11-17 Thread Bjorn Andersson
On Tue 17 Nov 11:48 CST 2020, Manivannan Sadhasivam wrote: > NAND based Qualcomm platforms have the partition table populated in the > Shared Memory (SMEM). Hence, add a parser for parsing the partitions > from it. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/mtd/parsers/Kconfig

Re: [PATCH] interconnect: qcom: qcs404: Remove gpu and display nodes

2020-11-17 Thread Bjorn Andersson
On Tue 17 Nov 17:16 CST 2020, Mike Tipton wrote: > On 11/11/2020 2:07 AM, Georgi Djakov wrote: > > The following errors are noticed during boot on a QCS404 board: > > [2.926647] qcom_icc_rpm_smd_send mas 6 error -6 > > [2.934573] qcom_icc_rpm_smd_send mas 8 error -6 > > > > These errors s

Re: [PATCH 5/6] dts:qcom:sdm845: Add dt entries to support crypto engine.

2020-11-17 Thread Bjorn Andersson
On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote: > Add crypto engine (CE) and CE BAM related nodes and definitions to > "sdm845.dtsi". > > Signed-off-by: Thara Gopinath > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 > 1 file changed, 30 insertions(+) > > dif

Re: [PATCH 6/6] devicetree:bindings:crypto: Extend qcom-qce binding to add support for crypto engine version 5.4

2020-11-17 Thread Bjorn Andersson
like: "dt-bindings: crypto: qcom-qce: Add v5.4 to binding" With something like that: Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > Documentation/devicetree/bindings/crypto/qcom-qce.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/D

Re: [PATCH 4/6] drivers:crypto:qce: Fix SHA result buffer corruption issues.

2020-11-17 Thread Bjorn Andersson
oisoing. Fix this issue by ensuring that only the final hash value > is copied into the result buffer. > Looks reasonable to me Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/sha.c | 2 +- > 1 file changed, 1 inserti

Re: [PATCH 3/6] drivers:crypto:qce: Enable support for crypto engine on sdm845.

2020-11-17 Thread Bjorn Andersson
On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote: > Add support Qualcomm Crypto Engine accelerated encryption and > authentication algorithms on sdm845. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Thara Gopinath > --- > drivers/cryp

Re: [PATCH 2/6] clk:qcom:rpmh: Add CE clock on sdm845.

2020-11-17 Thread Bjorn Andersson
On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote: > Qualcomm CE clock resource that is managed by BCM is required > by crypto driver to access the core clock. > ' ' after ':' in $subject With that Reviewed-by: Bjorn Andersson Regards, bjorn &g

Re: [PATCH 1/6] dt-binding:clock: Add entry for crypto engine RPMH clock resource

2020-11-17 Thread Bjorn Andersson
#x27; Apart from that, things looks good. Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > include/dt-bindings/clock/qcom,rpmh.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/dt-bindings/clock/qcom,rpmh.h > b/include/dt-bindings/clock/qcom,rpmh.h > inde

Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

2020-11-14 Thread Bjorn Andersson
On Fri 06 Nov 03:38 CST 2020, Vinod Koul wrote: > On 05-11-20, 16:18, Manivannan Sadhasivam wrote: > > From: Naveen Yadav > > > > Add Global Clock Controller (GCC) support for SDX55 SoCs from Qualcomm. > > > > Signed-off-by: Naveen Yadav > > [mani: converted to parent_data, commented critical

[PATCH] arm64: defconfig: Enable Qualcomm OSM L3 driver

2020-11-13 Thread Bjorn Andersson
The OSM L3 interconnect driver is used for scaling the bus to the L3 cache on modern Qualcomm platforms, enable it. Signed-off-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig

Re: [PATCH] arm64: dts: qcom: sc7180: Assign numbers to eMMC and SD

2020-11-11 Thread Bjorn Andersson
On Wed 11 Nov 09:37 CST 2020, Douglas Anderson wrote: > After many years of struggle, commit fa2d0aa96941 ("mmc: core: Allow > setting slot index via device tree alias") finally allows the use of > aliases to number SD/MMC slots. Let's do that for sc7180 SoCs so that > if eMMC and SD are both use

Re: [PATCH v2 18/18] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

2020-11-11 Thread Bjorn Andersson
ke sure the "snps,dwc3"-compatible nodes are correctly > named. > > Signed-off-by: Serge Semin > Acked-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson Given the risk of merge conflicts with this patch I would prefer to take it through the qcom dts tree. Please let me k

Re: [PATCH v2 17/18] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2020-11-11 Thread Bjorn Andersson
> sure the DWC3 Qualcomm driver supports them and second falls back to the > deprecated naming so not to fail on the legacy DTS-files passed to the > newer kernels. > > Signed-off-by: Serge Semin Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/usb/dwc3/dwc3-qcom.c

Re: [PATCH v2 1/4] remoteproc: sysmon: Ensure remote notification ordering

2020-11-10 Thread Bjorn Andersson
On Tue 10 Nov 18:57 CST 2020, risha...@codeaurora.org wrote: > On 2020-11-04 20:50, Bjorn Andersson wrote: > > The reliance on the remoteproc's state for determining when to send > > sysmon notifications to a remote processor is racy with regard to > > concur

Re: [PATCH 00/25] Rid W=1 warnings in SoC

2020-11-10 Thread Bjorn Andersson
qcom patches): Reviewed-by: Bjorn Andersson and applied towards 5.11 Regards, Bjorn > Lee Jones (25): > soc: bcm: brcmstb: pm: pm-arm: Provide prototype for > brcmstb_pm_s3_finish() > soc: qcom: qcom_aoss: Remove set but unused variable 'tlen' > soc: qcom: qcom_aoss: Add

Re: [PATCH 19/25] soc: qcom: smp2p: Remove unused struct attribute provide another

2020-11-10 Thread Bjorn Andersson
: Function parameter or member 'out' > not described in 'qcom_smp2p' > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: linux-arm-...@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/soc/qcom/smp2p.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH 11/11] arm64: dts: qcom: Add support for Microsoft Lumia 950 XL (Cityman)

2020-11-10 Thread Bjorn Andersson
On Mon 05 Oct 10:14 CDT 2020, Konrad Dybcio wrote: > >+dtb-$(CONFIG_ARCH_QCOM)+= msm8994-msft-lumia-cityman.dts > > I made a typo and instead of .dtb I wrote .dts here. Could that be > fixed when applying so that I don't have to spam you guys with 11 more > mails? > Thanks for letting m

Re: [PATCH v5 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-11-10 Thread Bjorn Andersson
On Fri 30 Oct 05:47 CDT 2020, Akhil P Oommen wrote: > Add cooling-cells property and the cooling maps for the gpu tzones > to support GPU cooling. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Matthias Kaehlcke > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++---

Re: [PATCH v1] arm64: dts: sc7180: Add camera clock controller node

2020-11-10 Thread Bjorn Andersson
On Fri 06 Nov 12:38 CST 2020, Taniya Das wrote: > Add the camera clock controller node supported on SC7180. > > Signed-off-by: Taniya Das > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi >

Re: [PATCH v2 2/2] arm64: dts: qcom: clear the warnings caused by empty dma-ranges

2020-11-10 Thread Bjorn Andersson
g, and DMA will > have to go through a slow swiotlb in the absence of an IOMMU. > > Suggested-by: Arnd Bergmann > Signed-off-by: Zhen Lei Thanks for fixing this up Zhen! Reviewed-by: Bjorn Andersson and applied for 5.11. Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/ipq601

Re: [PATCH] pinctrl: qcom: sdx55: update kconfig dependency

2020-11-10 Thread Bjorn Andersson
this change for SDX55 pinctrl driver as well. > > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson > --- > drivers/pinctrl/qcom/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfi

Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region

2020-11-10 Thread Bjorn Andersson
On Mon 09 Nov 13:18 CST 2020, Evan Green wrote: > On Tue, Oct 20, 2020 at 11:37 AM Evan Green wrote: > > > > On Thu, Oct 15, 2020 at 11:28 AM Sibi Sankar wrote: > > > > > > The modem firmware memory requirements vary between 32M/140M on > > > no-lte/lte skus respectively, so fixup the modem memo

Re: [PATCH v2] pinctrl: qcom: Fix msm8953 Kconfig entry to depend on, not select PINCTRL_MSM

2020-11-10 Thread Bjorn Andersson
the msm8953 that also needs the > change. > > Applies to LinusW's pinctrl devel tree. > > Cc: Andy Gross > Cc: Prasad Sodagudi > Cc: Vladimir Lypak > Cc: Bjorn Andersson > Cc: Linus Walleij > Cc: linux-arm-...@vger.kernel.org > Cc: lin

Re: [PATCH] pinctrl: qcom: Move clearing pending IRQ to .irq_request_resources callback

2020-11-10 Thread Bjorn Andersson
t; > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > > Signed-off-by: Maulik Shah > > This looks critical so I applied it for fixes so we get some > rotation in linux-next. > > If Bjorn has other opinions he will tell us :) > No objections, the patch looks reasonable to me. Acked-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH v2 2/2] pinctrl: qcom: Add sc7280 pinctrl driver

2020-11-10 Thread Bjorn Andersson
please help me remember to not merge the tlmm node with a wakeup-parent specified before that. Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add sc7280 pinctrl bindings

2020-11-10 Thread Bjorn Andersson
On Thu 05 Nov 03:56 CST 2020, Rajendra Nayak wrote: > Add device tree binding Documentation details for Qualcomm SC7280 > TLMM block. > > Signed-off-by: Rajendra Nayak > Reviewed-by: Rob Herring Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > v2: Consolidated funct

Re: [PATCH 1/2] soc: qcom: Add tracepoints to mdt loader

2020-11-09 Thread Bjorn Andersson
On Mon 09 Nov 19:20 CST 2020, Rishabh Bhatnagar wrote: > Add trace events to the mdt loader driver. These events > can help us trace the region where we are loading the > segments and the time it takes to initialize the image > and setup the memory region. > > Signed-off-by: Rishabh Bhatnagar >

Re: [PATCH 2/2] remoteproc: qcom: Add trace events for q6v5_pas driver

2020-11-09 Thread Bjorn Andersson
On Mon 09 Nov 19:20 CST 2020, Rishabh Bhatnagar wrote: > Add tracepoints for q6v5_pas driver. These will help in > analyzing the time taken by each step in remoteproc > bootup/shutdown process and also serve as standard > checkpoints in code. > These tracepoints seems quite generic and useful to

Re: [PATCH v5 2/2] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module

2020-11-05 Thread Bjorn Andersson
e not ideal in some cases its the > only safe way I can find to avoid build errors without having > those drivers select QCOM_SCM and have to force it on (as > QCOM_SCM=n can be valid for those drivers). > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Andy Gross > Cc:

Re: [PATCH v5 1/2] pinctrl: qcom: Allow pinctrl-msm code to be loadable as a module

2020-11-05 Thread Bjorn Andersson
ecomes a maintenance > headache. > > We also add PINCTRL_MSM to the arm64 defconfig to avoid > surprises as otherwise PINCTRL_MSM/IPQ* options previously > enabled, will be off. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Cc: Catalin Marinas > Cc: Will Deacon >

Re: [PATCH] remoteproc/mtk_scp: surround DT device IDs with CONFIG_OF

2020-11-04 Thread Bjorn Andersson
On Wed 04 Nov 13:05 CST 2020, Mathieu Poirier wrote: > Hi Alexander, > > On Mon, Nov 02, 2020 at 04:40:07PM +0900, Alexandre Courbot wrote: > > Now that this driver can be compiled with COMPILE_TEST, we have no > > guarantee that CONFIG_OF will also be defined. When that happens, a > > warning ab

[PATCH v2 4/4] remoteproc: sysmon: Improve error messages

2020-11-04 Thread Bjorn Andersson
Improve the style of a few of the error messages printed by the sysmon implementation and fix the copy-pasted shutdown error in the send-event function. Signed-off-by: Bjorn Andersson --- Changes since v1: - New patch drivers/remoteproc/qcom_sysmon.c | 12 ++-- 1 file changed, 6

[PATCH v2 3/4] remoteproc: qcom: q6v5: Query sysmon before graceful shutdown

2020-11-04 Thread Bjorn Andersson
successful shutdown attempt, before doing the signal dance. Signed-off-by: Bjorn Andersson --- Changes since v1: - New patch drivers/remoteproc/qcom_q6v5.c | 8 +++- drivers/remoteproc/qcom_q6v5.h | 3 ++- drivers/remoteproc/qcom_q6v5_adsp.c | 2 +- drivers/remoteproc/qcom_q6v5_

[PATCH v2 2/4] remoteproc: sysmon: Expose the shutdown result

2020-11-04 Thread Bjorn Andersson
receive an ack back. This patch therefor track the success of the latest shutdown attempt in sysmon and exposes a new function in the API that the remoteproc driver can use to query the success and the necessity of invoking the older mechanism. Signed-off-by: Bjorn Andersson --- Changes s

[PATCH v2 1/4] remoteproc: sysmon: Ensure remote notification ordering

2020-11-04 Thread Bjorn Andersson
oc: sysmon: Inform current rproc about all active rprocs") Fixes: 1877f54f75ad ("remoteproc: sysmon: Add notifications for events") Fixes: 1fb82ee806d1 ("remoteproc: qcom: Introduce sysmon") Cc: sta...@vger.kernel.org Signed-off-by: Bjorn Andersson --- Changes since v1: - R

[PATCH v2 0/4] remoteproc: Improvement for the Qualcomm sysmon

2020-11-04 Thread Bjorn Andersson
drivers always timing out if sysmon has already successfully shut down the remote processor. Bjorn Andersson (4): remoteproc: sysmon: Ensure remote notification ordering remoteproc: sysmon: Expose the shutdown result remoteproc: qcom: q6v5: Query sysmon before graceful shutdown remoteproc

Re: [PATCH] remoteproc: sysmon: Ensure remote notification ordering

2020-11-04 Thread Bjorn Andersson
On Wed 04 Nov 10:16 CST 2020, Bjorn Andersson wrote: > The reliance on the remoteproc's state for determining when to send > sysmon notifications to a remote processor is racy with regard to > concurrent remoteproc operations. > > Further more the advertisement of the s

[PATCH] remoteproc: sysmon: Ensure remote notification ordering

2020-11-04 Thread Bjorn Andersson
t;remoteproc: sysmon: Add notifications for events") Fixes: 1fb82ee806d1 ("remoteproc: qcom: Introduce sysmon") Cc: sta...@vger.kernel.org Signed-off-by: Bjorn Andersson --- drivers/remoteproc/qcom_sysmon.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --

Re: [PATCH 29/29] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

2020-11-03 Thread Bjorn Andersson
On Mon 02 Nov 01:34 CST 2020, Jun Li wrote: > Serge Semin ???2020???10???20? > ??8:04? > > > > In accordance with the DWC USB3 bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name a

Re: [PATCH v18 2/4] iommu/arm-smmu: Add a way for implementations to influence SCTLR

2020-11-03 Thread Bjorn Andersson
; > a terminated CP read could hang the GPU by returning invalid > > command-stream data. > > > > Signed-off-by: Rob Clark > > Reviewed-by: Bjorn Andersson > > Signed-off-by: Jordan Crouse > > --- > > > > drivers/iommu/arm/arm-smmu/arm-smmu-qc

Re: [PATCH 4/4] clk: qcom: Add support for SDX55 RPMh clocks

2020-11-03 Thread Bjorn Andersson
On Wed 28 Oct 02:42 CDT 2020, Manivannan Sadhasivam wrote: > Add support for clocks maintained by RPMh in SDX55 SoCs. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/clk/qcom/clk-rpmh.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/drivers/clk/qcom/clk

Re: [PATCH 3/4] dt-bindings: clock: Introduce RPMHCC bindings for SDX55

2020-11-03 Thread Bjorn Andersson
my: Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 + > include/dt-bindings/clock/qcom,rpmh.h| 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bin

Re: [PATCH 0/4] Add GCC and RPMh clock support for SDX55

2020-11-03 Thread Bjorn Andersson
On Wed 28 Oct 12:08 CDT 2020, Manivannan Sadhasivam wrote: > On Wed, Oct 28, 2020 at 01:12:28PM +0530, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds Global Clock Controller (GCC) and RPMh clock support > > for SDX55 SoC from Qualcomm with relevant DT bindings. > > > > This ser

Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SDX55 pinctrl bindings

2020-11-03 Thread Bjorn Andersson
+ - reg > + - interrupts > + - interrupt-controller > + - '#interrupt-cells' > + - gpio-controller > + - '#gpio-cells' > + > +additionalProperties: false > + > +examples: > + - | > +#include > +pinctrl@1f0 { > +compatible = "qcom,sdx55-pinctrl"; > +reg = <0x0f10 0x30>; > +interrupts = ; > +#interrupt-cells = <2>; > +interrupt-controller; > +gpio-controller; > +#gpio-cells = <2>; Isn't gpio-ranges a required property? Perhaps that's only a functional requirement for the hogs to work? Reviewed-by: Bjorn Andersson Regards, Bjorn > +}; > + > +... > -- > 2.26.2 >

Re: [PATCH v2 2/2] pinctrl: qcom: Add SDX55 pincontrol driver

2020-11-03 Thread Bjorn Andersson
P(103, _, _, _, _, _, _, _, _, _), > + [104] = PINGROUP(104, _, _, _, _, _, _, _, _, _), > + [105] = PINGROUP(105, _, _, _, _, _, _, _, _, _), > + [106] = PINGROUP(106, emac_pps0, _, _, _, _, _, _, _, _), > + [107] = PINGROUP(107, _, _, _, _, _, _, _, _, _), > + [109] = SDC_PINGROUP(sdc1_rclk, 0x9a000, 15, 0), > + [110] = SDC_PINGROUP(sdc1_clk, 0x9a000, 13, 6), > + [111] = SDC_PINGROUP(sdc1_cmd, 0x9a000, 11, 3), > + [112] = SDC_PINGROUP(sdc1_data, 0x9a000, 9, 0), > +}; Looks better, and ngpios is good. Reviewed-by: Bjorn Andersson Thanks, Bjorn

Re: [PATCH 30/33] docs: ABI: cleanup several ABI documents

2020-11-03 Thread Bjorn Andersson
On Wed 28 Oct 09:23 CDT 2020, Mauro Carvalho Chehab wrote: [..] > .../ABI/testing/sysfs-class-remoteproc| 14 +- for this: Acked-by: Bjorn Andersson Thanks, Bjorn

[PATCH] arm64: defconfig: Enable Qualcomm Command DB driver

2020-11-02 Thread Bjorn Andersson
seconds for probe deferral of many subsystems causes the system to be completely useless. So, make Command DB builtin. Signed-off-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 5cfe

Re: [PATCH v2 2/2] hwspinlock: sprd: use module_platform_driver() instead postcore initcall

2020-11-02 Thread Bjorn Andersson
On Thu 29 Oct 22:46 CDT 2020, Chunyan Zhang wrote: > From: Chunyan Zhang > > The hardware spinlock devices are defined in the DT, there's no need for > init calls order, remove boilerplate code by using module_platform_driver. > > Signed-off-by: Chunyan Zhang Applied this patch with Baolin's

Re: [PATCH v2 1/2] hwspinlock: sprd: fixed warning of unused variable 'sprd_hwspinlock_of_match'

2020-11-02 Thread Bjorn Andersson
On Mon 02 Nov 17:34 CST 2020, Baolin Wang wrote: > On Friday, October 30, 2020, Chunyan Zhang wrote: > > From: Chunyan Zhang > > > > The macro function of_match_ptr() is NULL if CONFIG_OF is not set, then > > Clang compiler would complain the of_device_id variable is unused. > > > > But using of

Re: [PATCH v3 0/4] nvmem: qfprom: Avoid untouchable regions

2020-11-02 Thread Bjorn Andersson
On Mon 02 Nov 09:58 CST 2020, Srinivas Kandagatla wrote: > > > On 29/10/2020 00:28, Evan Green wrote: > > Certain fuses are protected by the XPU such that the AP cannot > > access them. Attempting to do so causes an SError. Introduce an > > SoC-specific compatible string, and introduce support i

Re: [PATCH v6 2/4] remoteproc: coredump: Add minidump functionality

2020-11-02 Thread Bjorn Andersson
On Thu 29 Oct 18:54 CDT 2020, Siddharth Gupta wrote: > > On 10/26/2020 2:09 PM, Bjorn Andersson wrote: > > On Fri 02 Oct 21:05 CDT 2020, Siddharth Gupta wrote: [..] > > > diff --git a/drivers/remoteproc/remoteproc_elf_helpers.h > > > b/drivers/remoteproc/remote

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi86: Replace #pwm-cells

2020-11-02 Thread Bjorn Andersson
On Fri 02 Oct 15:42 CDT 2020, Doug Anderson wrote: > Hi, > > On Wed, Sep 30, 2020 at 3:40 PM Bjorn Andersson > wrote: > > > > While the signal on GPIO4 to drive the backlight controller indeed is > > pulse width modulated its purpose is specifically to control the

Re: [PATCH 2/2] pinctrl: qcom: Add sc7280 pinctrl driver

2020-10-29 Thread Bjorn Andersson
On Fri 16 Oct 01:58 CDT 2020, Rajendra Nayak wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c > b/drivers/pinctrl/qcom/pinctrl-sc7280.c [..] > +static const struct msm_function sc7280_functions[] = { [..] > + FUNCTION(phase_flag0), > + FUNCTION(phase_flag1), > + FUNCTION(pha

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-10-29 Thread Bjorn Andersson
On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > > There are firmware versions which do not support host capability > > QMI request. We suspect either the host cap is not implemented or > > there may be firmware specific issues, but

Re: [PATCH 2/2] pinctrl: qcom: Add SDX55 pincontrol driver

2020-10-28 Thread Bjorn Andersson
On Wed 28 Oct 03:30 CDT 2020, Vinod Koul wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-sdx55.c > b/drivers/pinctrl/qcom/pinctrl-sdx55.c [..] > +static const struct msm_function sdx55_functions[] = { [..] > + FUNCTION(qdss_gpio), > + FUNCTION(qdss_gpio0), > + FUNCTION(qdss_gpio1),

Re: [PATCH v2 2/2] dt-bindings: pinctrl: qcom: add msm8953 pinctrl bindings

2020-10-28 Thread Bjorn Andersson
On Wed 07 Oct 11:06 CDT 2020, Vladimir Lypak wrote: > Add device tree bindings documentation for Qualcomm MSM8953 > pinctrl driver. > > Signed-off-by: Vladimir Lypak Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > Changes in V2: > - removed "wakeup-parent"

Re: [PATCH v2 1/2] pinctrl: qcom: add pinctrl driver for msm8953

2020-10-28 Thread Bjorn Andersson
On Wed 07 Oct 11:06 CDT 2020, Vladimir Lypak wrote: > Add inititial pinctrl driver for MSM8953 platform. Compatible SoCs are: > MSM8953, APQ8053, SDM(SDA)450, SDM(SDA)632. > Based off CAF implementation. > > Signed-off-by: Prasad Sodagudi > Signed-off-by: Vladimir Lypak

[PATCH] pinctrl: qcom: sm8250: Specify PDC map

2020-10-28 Thread Bjorn Andersson
Specify the PDC mapping for SM8250, so that gpio interrupts are propertly mapped to the wakeup IRQs of the PDC. Signed-off-by: Bjorn Andersson --- drivers/pinctrl/qcom/pinctrl-sm8250.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c

Re: [PATCH V1 resend] qcom-geni-se: remove has_opp_table

2020-10-28 Thread Bjorn Andersson
On Wed 28 Oct 01:46 CDT 2020, Viresh Kumar wrote: > has_opp_table isn't used anymore, remove it. > > Signed-off-by: Viresh Kumar Applied, thank you Viresh. > > --- > include/linux/qcom-geni-se.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/qcom-geni-se.h b/include

[RESEND PATCH] pinctrl: qcom: sm8250: Specify PDC map

2020-10-28 Thread Bjorn Andersson
Specify the PDC mapping for SM8250, so that gpio interrupts are propertly mapped to the wakeup IRQs of the PDC. Signed-off-by: Bjorn Andersson --- Resending this as it didn't seem to have hit the list. drivers/pinctrl/qcom/pinctrl-sm8250.c | 18 ++ 1 file change

Re: [PATCH v2 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-10-26 Thread Bjorn Andersson
On Mon 26 Oct 10:13 CDT 2020, Wolfram Sang wrote: > > > Wolfram, would you like to pick this patch or would you prefer that it > > goes together with the other two through the soc tree? > > Actually, I prefer the soc tree because of the functional dependency. I > am not aware of any pending qcom

Re: [PATCH v6 2/4] remoteproc: coredump: Add minidump functionality

2020-10-26 Thread Bjorn Andersson
On Fri 02 Oct 21:05 CDT 2020, Siddharth Gupta wrote: > This change adds a new kind of core dump mechanism which instead of dumping > entire program segments of the firmware, dumps sections of the remoteproc > memory which are sufficient to allow debugging the firmware. This function > thus uses se

Re: [PATCH v2 0/4] ARM: stm32: add DT properties for remote proc synchronisation

2020-10-26 Thread Bjorn Andersson
On Wed 14 Oct 07:54 CDT 2020, Arnaud Pouliquen wrote: > This series implements the DT part associated to the commit 9276536f455b3 > ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation") > > Delta vs V1 [1] > - add Rob acked-by on patch 1/4 > - simplify yaml descriptions and alig

Re: [PATCH v2 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-10-26 Thread Bjorn Andersson
On Tue 13 Oct 16:25 CDT 2020, Douglas Anderson wrote: > This reverts commit 02b9aec59243c6240fc42884acc958602146ddf6. > > As talked about in the patch ("soc: qcom: geni: More properly switch > to DMA mode"), swapping the order of geni_se_setup_m_cmd() and > geni_se_xx_dma_prep() can sometimes cau

Re: [PATCH v3 1/2] dt-bindings: arm: cpus: Document 'qcom,freq-domain' property

2020-10-26 Thread Bjorn Andersson
On Mon 26 Oct 09:32 CDT 2020, Rob Herring wrote: > On Tue, Oct 20, 2020 at 09:09:43PM +0530, Manivannan Sadhasivam wrote: > > Add devicetree documentation for 'qcom,freq-domain' property specific > > to Qualcomm CPUs. This property is used to reference the CPUFREQ node > > along with Domain ID (0/

[GIT PULL] rpmsg updates for 5.10

2020-10-22 Thread Bjorn Andersson
The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git tags/rpmsg-v5.10 for you to fetch changes up to 4e3dda0bc6

[GIT PULL] remoteproc updates for v5.10

2020-10-22 Thread Bjorn Andersson
Courbot (1): remoteproc: scp: add COMPILE_TEST dependency Bjorn Andersson (1): remoteproc/mediatek: Remove non-standard dsb() Colin Ian King (1): remoteproc/mediatek: fix null pointer dereference on null scp pointer Mathieu Poirier (1): remoteproc: stm32: Fix pointer

[PATCH v6 2/4] leds: Add driver for Qualcomm LPG

2020-10-21 Thread Bjorn Andersson
The Light Pulse Generator (LPG) is a PWM-block found in a wide range of PMICs from Qualcomm. It can operate on fixed parameters or based on a lookup-table, altering the duty cycle over time - which provides the means for e.g. hardware assisted transitions of LED brightness. Signed-off-by: Bjorn

[PATCH v6 4/4] arm64: dts: qcom: Add user LEDs on db820c

2020-10-21 Thread Bjorn Andersson
interface to the user. Signed-off-by: Bjorn Andersson --- Changes since v5: - None arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 49 1 file changed, 49 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.

[PATCH v6 0/4] Qualcomm Light Pulse Generator

2020-10-21 Thread Bjorn Andersson
ded I hope we can make some progress on the LPG support again. The dts patches are included in the series as "examples", ultimately my expectation is that the dt binding and driver patches are picked up through the leds tree, while Andy or myself take the dts patches. Bjorn Andersson (4)

[PATCH v6 1/4] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding

2020-10-21 Thread Bjorn Andersson
This adds the binding document describing the three hardware blocks related to the Light Pulse Generator found in a wide range of Qualcomm PMICs. Signed-off-by: Bjorn Andersson --- Changes since v5: - None .../bindings/leds/leds-qcom-lpg.yaml | 170 ++ 1 file changed

[PATCH v6 3/4] arm64: dts: qcom: pm(i)8994: Add mpp and lpg blocks

2020-10-21 Thread Bjorn Andersson
The pm8994 contains a 6 LPG channels and the pmi8994 contains 4 MPP channels and a 4 channel LPG, with TRILED and LUT blocks. Add nodes for these blocks. Signed-off-by: Bjorn Andersson --- Changes since v5: - None arch/arm64/boot/dts/qcom/pm8994.dtsi | 9 + arch/arm64/boot/dts/qcom

Re: [RFT PATCH] arm64: dts: sdm845: Add iommus property to qup

2020-10-21 Thread Bjorn Andersson
On Wed 21 Oct 01:50 CDT 2020, Vinod Koul wrote: > Hi Bjorn, Steve, > > On 20-10-20, 08:03, Bjorn Andersson wrote: > > From: Stephen Boyd > > > > The SMMU that sits in front of the QUP needs to be programmed properly > > so that the i2c geni driver can alloca

[RFT PATCH] arm64: dts: sdm845: Add iommus property to qup

2020-10-20 Thread Bjorn Andersson
] Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 8eb5a31346d2..7d635bc919cb 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch

Re: [PATCH v5 2/4] leds: Add driver for Qualcomm LPG

2020-10-19 Thread Bjorn Andersson
On Sun 18 Oct 15:12 CDT 2020, Andy Shevchenko wrote: > On Sat, Oct 17, 2020 at 8:41 AM Bjorn Andersson > wrote: > > > > The Light Pulse Generator (LPG) is a PWM-block found in a wide range of > > PMICs from Qualcomm. It can operate on fixed parameters or based on a > &

[PATCH v5 2/3] iommu/arm-smmu-qcom: Read back stream mappings

2020-10-19 Thread Bjorn Andersson
-smmu driver maintain the streams in bypass mode. Signed-off-by: Bjorn Andersson --- Changes since v4: - Don't increment s2cr[i]->count, as this is not actually needed to survive probe deferral drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 23 ++ 1 file changed, 23 in

[PATCH v5 3/3] iommu/arm-smmu-qcom: Implement S2CR quirk

2020-10-19 Thread Bjorn Andersson
means of configuring the stream for translation using a reserved and disabled context bank. Also circumvent the problem of configuring faulting streams by configuring the stream as bypass. Signed-off-by: Bjorn Andersson --- Changes since v4: - Made the bypass_cbndx an integer... - Separated out

[PATCH v5 1/3] iommu/arm-smmu: Allow implementation specific write_s2cr

2020-10-19 Thread Bjorn Andersson
function, to allow the Qualcomm driver to work around this behavior. Reviewed-by: Robin Murphy Signed-off-by: Bjorn Andersson --- Changes since v4: - Return early instead of indenting the rest of the function drivers/iommu/arm/arm-smmu/arm-smmu.c | 13 ++--- drivers/iommu/arm/arm-smmu

[PATCH v5 0/3] iommu/arm-smmu-qcom: Support maintaining bootloader mappings

2020-10-19 Thread Bjorn Andersson
of a context bank for bypass emulation and use of this context bank pretty much isolated to the Qualcomm specific implementation. The patchset has been tested to boot DB845c and RB5 (with splash screen) and Lenovo Yoga C630 (with EFI framebuffer). Bjorn Andersson (3): iommu/arm-smmu:

Re: [PATCH v4 3/3] iommu/arm-smmu-qcom: Implement S2CR quirk

2020-10-19 Thread Bjorn Andersson
On Mon 19 Oct 09:04 CDT 2020, Robin Murphy wrote: > On 2020-10-17 05:39, Bjorn Andersson wrote: > > The firmware found in some Qualcomm platforms intercepts writes to S2CR > > in order to replace bypass type streams with fault; and ignore S2CR > > updates of type fault.

Re: [PATCH v4 2/3] iommu/arm-smmu-qcom: Read back stream mappings

2020-10-19 Thread Bjorn Andersson
On Mon 19 Oct 09:03 CDT 2020, Robin Murphy wrote: > On 2020-10-17 05:39, Bjorn Andersson wrote: > > The Qualcomm boot loader configures stream mapping for the peripherals > > that it accesses and in particular it sets up the stream mapping for the > > display controller to b

[PATCH v4 0/3] iommu/arm-smmu-qcom: Support maintaining bootloader mappings

2020-10-16 Thread Bjorn Andersson
ntext bank for bypass emulation and use of this context bank pretty much isolated to the Qualcomm specific implementation. As before the patchset has been tested to boot DB845c (with splash screen) and Lenovo Yoga C630 (with EFI framebuffer). Bjorn Andersson (3): iommu/arm-smmu: Allow implement

[PATCH v4 2/3] iommu/arm-smmu-qcom: Read back stream mappings

2020-10-16 Thread Bjorn Andersson
-smmu driver maintain the streams in bypass mode. Signed-off-by: Bjorn Andersson --- Changes since v3: - Extracted from different patch in v3. - Now configures the stream as BYPASS, rather than translate, which should work for platforms with working S2CR handling as well. drivers/iommu/arm/arm

[PATCH v4 3/3] iommu/arm-smmu-qcom: Implement S2CR quirk

2020-10-16 Thread Bjorn Andersson
means of configuring the stream for translation using a reserved and disabled context bank. Also circumvent the problem of configuring faulting streams by configuring the stream as bypass. Signed-off-by: Bjorn Andersson --- Changes since v3: - Move the reservation of the "identity context

[PATCH v4 1/3] iommu/arm-smmu: Allow implementation specific write_s2cr

2020-10-16 Thread Bjorn Andersson
function, to allow the Qualcomm driver to work around this behavior. Signed-off-by: Bjorn Andersson --- Changes since v3: - New patch drivers/iommu/arm/arm-smmu/arm-smmu.c | 22 ++ drivers/iommu/arm/arm-smmu/arm-smmu.h | 1 + 2 files changed, 15 insertions(+), 8 deletions

[PATCH v5 0/4] Qualcomm Light Pulse Generator

2020-10-16 Thread Bjorn Andersson
ded I hope we can make some progress on the LPG support again. The dts patches are included in the series as "examples", ultimately my expectation is that the dt binding and driver patches are picked up through the leds tree, while Andy or myself take the dts patches. Bjorn Andersson (4)

[PATCH v5 3/4] arm64: dts: qcom: pm(i)8994: Add mpp and lpg blocks

2020-10-16 Thread Bjorn Andersson
The pm8994 contains a 6 LPG channels and the pmi8994 contains 4 MPP channels and a 4 channel LPG, with TRILED and LUT blocks. Add nodes for these blocks. Signed-off-by: Bjorn Andersson --- Changes since v4: - Replaced msm8996 with pm(i)8994 in subject arch/arm64/boot/dts/qcom/pm8994.dtsi

[PATCH v5 4/4] arm64: dts: qcom: Add user LEDs on db820c

2020-10-16 Thread Bjorn Andersson
interface to the user. Signed-off-by: Bjorn Andersson --- Changes since v4: - None arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 49 1 file changed, 49 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.

<    3   4   5   6   7   8   9   10   11   12   >