Re: [PATCH v16 20/20] arm: dts: qcom: sc7180: Set the compatible string for the GPU SMMU

2020-09-04 Thread Bjorn Andersson
On Tue 01 Sep 11:46 CDT 2020, Rob Clark wrote: > From: Rob Clark > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > split pagetables and per-instance pagetables for drm/msm. > Reviewed-by: Bjorn Andersson > Signed-off-by: Rob Clark > --- >

Re: [PATCH v16 19/20] arm: dts: qcom: sm845: Set the compatible string for the GPU SMMU

2020-09-04 Thread Bjorn Andersson
On Tue 01 Sep 11:46 CDT 2020, Rob Clark wrote: > From: Jordan Crouse > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > split pagetables and per-instance pagetables for drm/msm. > > Signed-off-by: Jordan Crouse > Signed-off-by: Rob Clark Reviewe

Re: [PATCH v16 14/20] iommu/arm-smmu: Prepare for the adreno-smmu implementation

2020-09-04 Thread Bjorn Andersson
le bit cleaner. So perhaps you would be interested in squashing https://lore.kernel.org/linux-arm-msm/20200904155513.282067-2-bjorn.anders...@linaro.org/ into this patch? Otherwise, feel free to add my: Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/iommu/arm/arm-smmu/arm-

[PATCH v3 4/8] iommu/arm-smmu-qcom: Emulate bypass by using context banks

2020-09-04 Thread Bjorn Andersson
SMMU. This adds a Qualcomm specific cfg_probe function, which probes for the broken behavior of the S2CR registers and implements a custom alloc_context_bank() that when necessary allocates a context bank (without translation) for these domains as well. Signed-off-by: Bjorn Andersson --- Changes

[PATCH v3 3/8] iommu/arm-smmu: Consult context bank allocator for identify domains

2020-09-04 Thread Bjorn Andersson
consulted and if it decides to use a context bank for the identity map, don't enable translation (i.e. omit ARM_SMMU_SCTLR_M). Signed-off-by: Bjorn Andersson --- Changes since v2: - Tie this to alloc_context_bank rather than carrying a Qualcomm specific quirk in the generic code. drivers/

[PATCH v3 5/8] iommu/arm-smmu-qcom: Consistently initialize stream mappings

2020-09-04 Thread Bjorn Andersson
ings might linger and reference context banks that Linux is reconfiguring. Use the fact that BYPASS writes result in FAULT type to force all stream mappings to FAULT. Signed-off-by: Bjorn Andersson --- Changes since v2: - None drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 18

[PATCH v3 2/8] iommu/arm-smmu: Delay modifying domain during init

2020-09-04 Thread Bjorn Andersson
Delay modifications to the domain during arm_smmu_init_domain_context() until we've allocated a context bank. This will allow us to postpone the special handling of identity domains until the platform specific context bank allocator has been executed, in a later patch. Signed-off-by:

[PATCH v3 1/8] iommu/arm-smmu: Refactor context bank allocation

2020-09-04 Thread Bjorn Andersson
passed object. This allows us to not assign smmu_domain->smmu before attempting to allocate the context bank and as such we don't need to roll back this assignment on failure. Signed-off-by: Bjorn Andersson --- Note that this series applies ontop of: https://lore.kernel.org/linux

[PATCH v3 0/8] iommu/arm-smmu: Support maintaining bootloader mappings

2020-09-04 Thread Bjorn Andersson
eries, which can be found at https://lore.kernel.org/linux-arm-msm/20200901164707.2645413-1-robdcl...@gmail.com/ Bjorn Andersson (8): iommu/arm-smmu: Refactor context bank allocation iommu/arm-smmu: Delay modifying domain during init iommu/arm-smmu: Consult context bank allocator for identify do

[PATCH v3 6/8] iommu/arm-smmu: Add impl hook for inherit boot mappings

2020-09-04 Thread Bjorn Andersson
Add a new operation to allow platform implementations to inherit any stream mappings from the boot loader. Signed-off-by: Bjorn Andersson --- Changes since v2: - New patch/interface drivers/iommu/arm/arm-smmu/arm-smmu.c | 11 ++- drivers/iommu/arm/arm-smmu/arm-smmu.h | 6 ++ 2

[PATCH v3 7/8] iommu/arm-smmu: Provide helper for allocating identity domain

2020-09-04 Thread Bjorn Andersson
Some platform implementations needs to be able to allocate a domain for emulating identity mappings using a context bank without translation. Provide a helper function to allocate such a domain. Signed-off-by: Bjorn Andersson --- Changes since v2: - Extracted from previous

[PATCH v3 8/8] iommu/arm-smmu-qcom: Setup identity domain for boot mappings

2020-09-04 Thread Bjorn Andersson
context bank is used and streams are diverted here during initialization. This also performs the readback of SMR registers for the Qualcomm platform, to trigger the mechanism. This is based on prior work by Thierry Reding and Laurentiu Tudor. Signed-off-by: Bjorn Andersson --- Changes since v2

Re: [PATCH 1/3] iommu: amd: Fix kerneldoc

2020-09-04 Thread Bjorn Andersson
vers/iommu/amd/init.c:1938: warning: Function parameter or member > 'iommu' not described in 'iommu_update_intcapxt' > Reviewed-by: Bjorn Andersson > Signed-off-by: Krzysztof Kozlowski > --- > drivers/iommu/amd/init.c | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH 2/3] iommu: intel: Drop kerneldoc marker from regular comment

2020-09-04 Thread Bjorn Andersson
On Tue 28 Jul 12:08 CDT 2020, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/iommu/intel/dmar.c:389: warning: Function parameter or member > 'header' not described in 'dmar_parse_one_drhd' > Reviewed-by: Bjorn And

Re: [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable

2020-09-04 Thread Bjorn Andersson
910:34: warning: 'qcom_iommu_of_match' defined > but not used [-Wunused-const-variable=] > 910 | static const struct of_device_id qcom_iommu_of_match[] = { > Reviewed-by: Bjorn Andersson > Signed-off-by: Krzysztof Kozlowski > --- > drivers/iommu/qcom_iommu.c | 4 ++-- >

Re: [PATCH v3 1/3] remoteproc: Expose remoteproc configuration through sysfs

2020-09-03 Thread Bjorn Andersson
On Thu 03 Sep 18:03 CDT 2020, Rishabh Bhatnagar wrote: > Add a feature flag to expose some of the remoteproc configuration > through sysfs. This feature is helpful in systems where debugfs is > not available/mounted. Currently the recovery and coredump > configuration is exposed through sysfs rath

Re: [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs

2020-09-03 Thread Bjorn Andersson
On Tue 01 Sep 17:05 CDT 2020, Mathieu Poirier wrote: > Hi Rishabh, > > On Thu, Aug 27, 2020 at 12:48:48PM -0700, Rishabh Bhatnagar wrote: > > From Android R onwards Google has restricted access to debugfs in user > > and user-debug builds. This restricts access to most of the features > > exposed

Re: [PATCH] PCI: qcom: Make sure PCIe is reset before init for rev 2.1.0

2020-09-01 Thread Bjorn Andersson
s U-Boot bug. > Looks sensible. Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Ansuel Smith > Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver") > Cc: sta...@vger.kernel.org # v4.19+ > --- > drivers/pci/controller/dwc/pcie-qcom.c

Re: [PATCH 01/19] drm/msm: remove dangling submitqueue references

2020-08-31 Thread Bjorn Andersson
On Tue 01 Sep 03:42 UTC 2020, Rob Clark wrote: > On Mon, Aug 31, 2020 at 7:35 PM Bjorn Andersson > wrote: > > > > On Fri 14 Aug 02:40 UTC 2020, Rob Clark wrote: > > > > > From: Rob Clark > > > > > > Currently it doesn't matter, sin

Re: [PATCH 01/19] drm/msm: remove dangling submitqueue references

2020-08-31 Thread Bjorn Andersson
On Fri 14 Aug 02:40 UTC 2020, Rob Clark wrote: > From: Rob Clark > > Currently it doesn't matter, since we free the ctx immediately. But > when we start refcnt'ing the ctx, we don't want old dangling list > entries to hang around. > > Signed-off-by: Rob

Re: [PATCH 19/19] drm/msm: show process names in gem_describe

2020-08-31 Thread Bjorn Andersson
On Thu 13 Aug 21:41 CDT 2020, Rob Clark wrote: > From: Rob Clark > > In $debugfs/gem we already show any vma(s) associated with an object. > Also show process names if the vma's address space is a per-process > address space. > Reviewed-by: Bjorn Andersson >

Re: [PATCH 18/19] iommu/arm-smmu: add a way for implementations to influence SCTLR

2020-08-31 Thread Bjorn Andersson
gt; command-stream data. > Reviewed-by: Bjorn Andersson > Signed-off-by: Rob Clark > --- > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 6 ++ > drivers/iommu/arm/arm-smmu/arm-smmu.c | 3 +++ > drivers/iommu/arm/arm-smmu/arm-smmu.h | 3 +++ > 3 files changed, 12 inser

Re: [PATCH 15/19] drm/msm: Add support for private address space instances

2020-08-31 Thread Bjorn Andersson
l return a pointer to the global address space. > Reviewed-by: Bjorn Andersson > Signed-off-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_drv.c | 13 +++-- > drivers/gpu/drm/msm/msm_drv.h | 5 + > drivers/gpu/drm/msm/m

Re: [PATCH 14/19] drm/msm: Add support to create a local pagetable

2020-08-31 Thread Bjorn Andersson
ible string and > split pagetables enabled. > Reviewed-by: Bjorn Andersson > Signed-off-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpummu.c | 2 +- > drivers/gpu/drm/msm/msm_iommu.c | 199 ++- > drivers/gpu/dr

Re: [PATCH 13/19] drm/msm: Set the global virtual address range from the IOMMU domain

2020-08-31 Thread Bjorn Andersson
On Thu 13 Aug 21:41 CDT 2020, Rob Clark wrote: > From: Jordan Crouse > > Use the aperture settings from the IOMMU domain to set up the virtual > address range for the GPU. This allows us to transparently deal with > IOMMU side features (like split pagetables). > Reviewed-b

Re: [PATCH 12/19] drm/msm: Drop context arg to gpu->submit()

2020-08-31 Thread Bjorn Andersson
On Thu 13 Aug 21:41 CDT 2020, Rob Clark wrote: > From: Jordan Crouse > > Now that we can get the ctx from the submitqueue, the extra arg is > redundant. > Reviewed-by: Bjorn Andersson > Signed-off-by: Jordan Crouse > [split out of previous patch to reduce churny noise]

Re: [PATCH 11/19] drm/msm: Add a context pointer to the submitqueue

2020-08-31 Thread Bjorn Andersson
On Thu 13 Aug 21:41 CDT 2020, Rob Clark wrote: > From: Jordan Crouse > > Each submitqueue is attached to a context. Add a pointer to the > context to the submitqueue at create time and refcount it so > that it stays around through the life of the queue. > Reviewed-by: Bjorn

Re: [PATCH 10/19] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU

2020-08-31 Thread Bjorn Andersson
with a compatible string so that they can be identified in the > arm-smmu implementation specific code. > Reviewed-by: Bjorn Andersson > Signed-off-by: Jordan Crouse > Reviewed-by: Rob Herring > Signed-off-by: Rob Clark > --- > Documentation/devicetree/bindings/iommu/arm,

Re: [PATCH 09/19] iommu/arm-smmu-qcom: Add implementation for the adreno GPU SMMU

2020-08-31 Thread Bjorn Andersson
> (TTBR1) for the domain attached to the GPU device (SID 0) and > hard code it context bank 0 so the GPU hardware can implement > per-instance pagetables. > Reviewed-by: Bjorn Andersson > Co-developed-by: Rob Clark > Signed-off-by: Jordan Crouse > Signed-off-by: Rob Clark

Re: [PATCH 07/19] drm/msm: set adreno_smmu as gpu's drvdata

2020-08-31 Thread Bjorn Andersson
On Thu 13 Aug 21:41 CDT 2020, Rob Clark wrote: > From: Rob Clark > > This will be populated by adreno-smmu, to provide a way for coordinating > enabling/disabling TTBR0 translation. > Reviewed-by: Bjorn Andersson > Signed-off-by: Rob Clark > --- > dr

Re: [PATCH 08/19] iommu/arm-smmu: constify some helpers

2020-08-31 Thread Bjorn Andersson
On Thu 13 Aug 21:41 CDT 2020, Rob Clark wrote: > From: Rob Clark > > Sprinkle a few `const`s where helpers don't need write access. > Reviewed-by: Bjorn Andersson > Signed-off-by: Rob Clark > --- > drivers/iommu/arm/arm-smmu/arm-smmu.h | 6 +++--- > 1 fil

Re: [PATCH 06/19] drm/msm/gpu: add dev_to_gpu() helper

2020-08-31 Thread Bjorn Andersson
pu->funcs->gpu_get_freq) > *freq = gpu->funcs->gpu_get_freq(gpu); > diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h > index 0db117a7339b..8bda7beaed4b 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.h > +++ b/drivers/gpu/drm/msm/msm_gpu.h

Re: [PATCH 05/19] iommu: add private interface for adreno-smmu

2020-08-31 Thread Bjorn Andersson
erface is used to > avoid adding highly driver specific things to the public iommu > interface. > > Signed-off-by: Rob Clark Reviewed-by: Bjorn Andersson > --- > include/linux/adreno-smmu-priv.h | 36 > 1 file changed, 36 insertions(+) >

Re: [PATCH 03/19] iommu/arm-smmu: Add support for split pagetables

2020-08-31 Thread Bjorn Andersson
+ cfg->asid); The old indentation seems more appropriate. Apart from that this looks sensible. Reviewed-by: Bjorn Andersson Regards, Bjorn > + > + if (pgtbl_cfg->quirks & IO_PGTABLE_QUIRK_ARM_TTBR1) > +

Re: [PATCH 02/19] iommu/arm-smmu: Pass io-pgtable config to implementation specific function

2020-08-31 Thread Bjorn Andersson
able is created. > > Signed-off-by: Jordan Crouse > Signed-off-by: Rob Clark Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 3 ++- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 11 ++- > drivers/iommu/arm/arm-smmu

Re: [PATCH 01/19] drm/msm: remove dangling submitqueue references

2020-08-31 Thread Bjorn Andersson
On Fri 14 Aug 02:40 UTC 2020, Rob Clark wrote: > From: Rob Clark > > Currently it doesn't matter, since we free the ctx immediately. But > when we start refcnt'ing the ctx, we don't want old dangling list > entries to hang around. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_

Re: [PATCH v6 2/2] drm: panel: Add novatek nt36672a panel driver

2020-08-31 Thread Bjorn Andersson
On Mon 31 Aug 13:02 UTC 2020, Sumit Semwal wrote: > Novatek NT36672a is a generic DSI IC that drives command and video mode > panels. Add the driver for it. > > Right now adding support for some Poco F1 phones that have an LCD panel > from Tianma connected with this IC, with a resolution of 1080x

Re: [PATCH v5 1/6] pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED and IRQCHIP_MASK_ON_SUSPEND flags

2020-08-31 Thread Bjorn Andersson
ation. > This seems like two different problems and both descriptions are thin on details imho. If you're respinning the series I would appreciate if you improved this. Otherwise Acked-by: Bjorn Andersson Regards, Bjorn > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip i

Re: [PATCH v5 2/6] pinctrl: qcom: Use return value from irq_set_wake() call

2020-08-31 Thread Bjorn Andersson
> instead of always returning success. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Maulik Shah > Reviewed-by: Douglas Anderson > Reviewed-by: Stephen Boyd Acked-by: Bjorn Andersson > --- > drivers/pinctrl/qcom/pinctrl-msm

Re: your mail

2020-08-30 Thread Bjorn Andersson
On Mon 17 Aug 17:12 UTC 2020, Amit Pundir wrote: > On Thu, 13 Aug 2020 at 12:38, Bjorn Andersson > wrote: > > > > On Thu 06 Aug 15:31 PDT 2020, Konrad Dybcio wrote: > > > > > Subject: Re: [PATCH v4] arm64: dts: qcom: Add support for Xiaomi Poco F1 >

Re: [PATCH v8 3/4] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block

2020-08-30 Thread Bjorn Andersson
On Wed 12 Aug 07:19 UTC 2020, Wesley Cheng wrote: > The PM8150B has a dedicated USB type C block, which can be used for type C > orientation and role detection. Create the reference node to this type C > block for further use. > Reviewed-by: Bjorn Andersson Regards, Bjorn >

Re: [PATCH v8 1/4] usb: typec: Add QCOM PMIC typec detection driver

2020-08-30 Thread Bjorn Andersson
On Wed 12 Aug 07:19 UTC 2020, Wesley Cheng wrote: > The QCOM SPMI typec driver handles the role and orientation detection, and > notifies client drivers using the USB role switch framework. It registers > as a typec port, so orientation can be communicated using the typec switch > APIs. The dri

Re: [PATCH v8 4/4] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster

2020-08-30 Thread Bjorn Andersson
On Thu 20 Aug 07:47 UTC 2020, Wesley Cheng wrote: > > > On 8/12/2020 2:34 AM, Sergei Shtylyov wrote: > > Hello! > > > > On 12.08.2020 10:19, Wesley Cheng wrote: > > > >> Add the required DTS node for the USB VBUS output regulator, which is > >> available on PM8150B.  This will provide the VBUS

Re: [PATCH v1 5/9] phy: qcom-qmp: Get dp_com I/O resource by index

2020-08-26 Thread Bjorn Andersson
On Wed 26 Aug 16:32 CDT 2020, Stephen Boyd wrote: > Quoting Bjorn Andersson (2020-08-25 21:36:16) > > On Tue 25 Aug 21:47 CDT 2020, Stephen Boyd wrote: > > > > > The dp_com resource is always at index 1 according to the dts files in > > > the kernel. Get this r

Re: [PATCH v2 2/2] soc: qcom: rpmh: Allow RPMH driver to be loaded as a module

2020-08-26 Thread Bjorn Andersson
to be a built in driver. > > Cc: Todd Kjos > Cc: Saravana Kannan > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Rajendra Nayak > Cc: linux-arm-...@vger.kernel.org > Signed-off-by: John Stultz > Signed-off-by: Bjorn Andersson > [mkshah: Fix typos in commit mess

Re: [PATCH v2 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh"

2020-08-26 Thread Bjorn Andersson
e tracepoint. Using _rcuidle tracepoint > prevented rpmh driver to be loadable module as these are not exported > symbols. > > This reverts commit efde2659b0fe835732047357b2902cca14f054d9. > > Cc: Sai Prakash Ranjan > Cc: John Stultz > Cc: Stephen Rothwell > Revi

Re: [PATCH v1 5/9] phy: qcom-qmp: Get dp_com I/O resource by index

2020-08-25 Thread Bjorn Andersson
binding for the USB/DP phy defines that there should be a reg name of "dp_com" and the current dts files all specifies this. Am I missing something? PS. Why isn't this a devm_platform_ioremap_resource{,_byname}()? Regards, Bjorn > Cc: Jeykumar Sankaran > Cc: Chandan Uddaraju

Re: [PATCH v1 3/9] phy: qcom-qmp: Remove 'initialized' in favor of 'init_count'

2020-08-25 Thread Bjorn Andersson
ykumar Sankaran > Cc: Chandan Uddaraju > Cc: Vara Reddy > Cc: Tanmay Shah > Cc: Bjorn Andersson Reviewed-by: Bjorn Andersson Regards, Bjorn > Cc: Manu Gautam > Cc: Sandeep Maheswaram > Cc: Douglas Anderson > Cc: Sean Paul > Cc: Jonathan Marek > Cc: Dmit

Re: [PATCH v1 2/9] phy: qcom-qmp: Move phy mode into struct qmp_phy

2020-08-25 Thread Bjorn Andersson
up 'struct qcom_qmp' so that it can eventually be the place where qmp > wrapper wide data is located, paving the way for the USB3+DP combo phy. > > Cc: Jeykumar Sankaran > Cc: Chandan Uddaraju > Cc: Vara Reddy > Cc: Tanmay Shah > Cc: Bjorn Andersson Reviewe

Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-08-25 Thread Bjorn Andersson
On Tue 25 Aug 02:20 CDT 2020, Stephen Boyd wrote: > Quoting Bjorn Andersson (2020-08-24 09:42:12) > > On Fri 21 Aug 14:41 PDT 2020, Stephen Boyd wrote: [..] > > > I find it odd that this is modeled as a power domain instead of some > > > Qualcomm specific message that

Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-08-24 Thread Bjorn Andersson
On Fri 21 Aug 14:41 PDT 2020, Stephen Boyd wrote: > Quoting Sibi Sankar (2020-08-21 13:49:20) > > Add GENPD_FLAG_NO_SUSPEND/RESUME flags to instruct genpd to keep the > > status of the PM domain unaltered during suspend/resume respectively. > > The flags are aimed at power domains coupled to co-pr

Re: your mail

2020-08-13 Thread Bjorn Andersson
On Thu 06 Aug 15:31 PDT 2020, Konrad Dybcio wrote: > Subject: Re: [PATCH v4] arm64: dts: qcom: Add support for Xiaomi Poco F1 > (Beryllium) > > >// This removed_region is needed to boot the device > > // TODO: Find out the user of this reserved memory > > removed_regi

Re: [RFC][PATCH] tty: serial: qcom_geni_serial: Drop __init from qcom_geni_console_setup

2020-08-10 Thread Bjorn Andersson
process_one_work+0x20c/0x4b0 > [7.209456] worker_thread+0x48/0x460 > [7.213157] kthread+0x14c/0x158 > [ 7.216432] ret_from_fork+0x10/0x18 > [7.220049] Code: bad PC value > [7.223139] ---[ end trace 73f3b21e251d5a70 ]--- > > Thus this patch removes the __init avoiding cr

[GIT PULL] hwspinlock updates for 5.9

2020-08-10 Thread Bjorn Andersson
deprecates the old, invalid, one. It also cleans up the Kconfig slightly. Bjorn Andersson (4): dt-bindings: hwlock: qcom: Migrate binding to YAML dt-bindings: hwlock: qcom: Allow device on mmio bus hwspinlock: qcom

[GIT PULL] remoteproc updates for v5.9

2020-08-10 Thread Bjorn Andersson
ent power management. Alex Elder (2): net: ipa: new notification infrastructure remoteproc: kill IPA notify code Bjorn Andersson (4): dt-bindings: remoteproc: Add Qualcomm PIL info binding remoteproc: qcom: Introduce help

[GIT PULL] rpmsg updates for v5.9

2020-08-10 Thread Bjorn Andersson
The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git tags/rpmsg-v5.9 for you to fetch changes up to 111d1089700

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-06 Thread Bjorn Andersson
On Thu 06 Aug 19:48 PDT 2020, John Stultz wrote: > On Thu, Aug 6, 2020 at 6:42 PM Bjorn Andersson > wrote: > > On Thu 06 Aug 18:22 PDT 2020, John Stultz wrote: > > > On Thu, Aug 6, 2020 at 5:43 PM Bjorn Andersson > > > wrote: > > > > On Wed 05 Aug 14:57

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-06 Thread Bjorn Andersson
On Thu 06 Aug 18:22 PDT 2020, John Stultz wrote: > On Thu, Aug 6, 2020 at 5:43 PM Bjorn Andersson > wrote: > > On Wed 05 Aug 14:57 PDT 2020, John Stultz wrote: > > > On Wed, Aug 5, 2020 at 2:47 PM Steev Klimaszewski wrote: > > > > On 8/5/20 4:16 PM, Steev Klimas

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-06 Thread Bjorn Andersson
On Wed 05 Aug 14:57 PDT 2020, John Stultz wrote: > On Wed, Aug 5, 2020 at 2:47 PM Steev Klimaszewski wrote: > > > > > > On 8/5/20 4:16 PM, Steev Klimaszewski wrote: > > > On 8/5/20 3:19 PM, Saravana Kannan wrote: > > >> On Wed, Aug 5, 2020 at 12:44 AM John Stultz > > >> wrote: > > >>> > > >>>

Re: [PATCH v3] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-04 Thread Bjorn Andersson
On Tue 04 Aug 00:35 PDT 2020, Amit Pundir wrote: > On Tue, 4 Aug 2020 at 11:46, Bjorn Andersson > wrote: > > On Sat 01 Aug 08:55 PDT 2020, Amit Pundir wrote: [..] > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-beryllium.dts > > > b/arch/arm64/boot

Re: [PATCH v3] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-03 Thread Bjorn Andersson
On Sat 01 Aug 08:55 PDT 2020, Amit Pundir wrote: > Add initial dts support for Xiaomi Poco F1 (Beryllium). > > This initial support is based on upstream Dragonboard 845c > (sdm845) device. With this dts, Beryllium boots AOSP up to > ADB shell over USB-C. > > Supported functionality includes UFS,

Re: [PATCH] phy: qcom-ufs: Fix wrong return value in ufs_qcom_phy_calibrate()

2020-08-03 Thread Bjorn Andersson
On Sun 02 Aug 04:15 PDT 2020, Tianjia Zhang wrote: > On an error exit path, a negative error code should be returned > instead of a positive return value. > > Fixes: adaafaa393ef1 ("phy: qcom-ufs: add support for QUALCOMM Technologies > UFS PHY drivers") > Cc: Yaniv Gardi > Signed-off-by: Tianj

Re: [PATCH] regulator: qcom_spmi: Improve readability for setting up enable/mode pin control

2020-07-31 Thread Bjorn Andersson
On Fri 31 Jul 22:48 PDT 2020, Axel Lin wrote: > By checking data->pin_ctrl_enable / data->pin_ctrl_hpm flags first, then > use switch-case to improve readability. > Nice! Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Axel Lin > --- > drivers/regulat

Re: [PATCH 1/1] iommu/arm-smmu: Implement qcom,skip-init

2020-07-30 Thread Bjorn Andersson
On Wed 22 Jul 13:11 PDT 2020, Konrad Dybcio wrote: > >Is the problem on SDM630 that when you write to SMR/S2CR the device > >reboots? Or that when you start writing out the context bank > >configuration that trips the display and the device reboots? > > I added some debug prints and the phone han

Re: [PATCH v2] interconnect: Add bulk API helpers

2020-07-29 Thread Bjorn Andersson
ve and to allow drivers to put > all the path names and bandwidth data into a single static icc_bulk_data > table and call the icc_bulk_* functions on that table in order to scale > all the interconnect paths in parallel. > > Suggested-by: Evan Green > Suggested-by: Bjorn Anderss

Re: [PATCH 2/2] soc: qcom: smd-rpm: Fix kerneldoc

2020-07-29 Thread Bjorn Andersson
On Wed 29 Jul 00:44 PDT 2020, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/soc/qcom/smd-rpm.c:35: warning: Function parameter or member > 'dev' not described in 'qcom_smd_rpm' > drivers/soc/qcom/smd-rpm.c:99: warning: Function parameter or member

Re: [PATCH v4 4/5] arm64: dts: sdm845: Add OPP tables and power-domains for venus

2020-07-29 Thread Bjorn Andersson
On Tue 28 Jul 13:11 PDT 2020, Lina Iyer wrote: > On Tue, Jul 28 2020 at 13:51 -0600, Stephen Boyd wrote: > > Quoting Lina Iyer (2020-07-28 09:52:12) > > > On Mon, Jul 27 2020 at 18:45 -0600, Stephen Boyd wrote: > > > >Quoting Lina Iyer (2020-07-24 09:28:25) > > > >> On Fri, Jul 24 2020 at 03:03 -0

Re: [PATCH v5 3/5] media: venus: core: Add support for opp tables/perf voting

2020-07-29 Thread Bjorn Andersson
Rajendra Nayak > Reviewed-by: Matthias Kaehlcke > Acked-by: Stanimir Varbanov Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/media/platform/qcom/venus/core.c | 2 + > drivers/media/platform/qcom/venus/core.h | 5 ++ > drivers/media/plat

Re: [PATCH v5 2/5] media: venus: core: Fix error handling in probe

2020-07-29 Thread Bjorn Andersson
On Wed 29 Jul 00:16 PDT 2020, Rajendra Nayak wrote: > Post a successful pm_ops->core_get, an error in probe > should exit by doing a pm_ops->core_put which seems > to be missing. So fix it. > > Signed-off-by: Rajendra Nayak > Acked-by: Stanimir Varbanov Revi

Re: [PATCH v5 1/5] dt-bindings: media: venus: Add an optional power domain for perf voting

2020-07-29 Thread Bjorn Andersson
his is optional in the sense that, leaving this power > domain out does not really impact the functionality but just makes > the platform a little less power efficient. > > Signed-off-by: Rajendra Nayak > Reviewed-by: Rob Herring Reviewed-by: Bjorn Andersson > --- > Document

Re: [PATCH v5 2/2] remoteproc: core: Register the character device interface

2020-07-29 Thread Bjorn Andersson
On Wed 29 Jul 10:40 PDT 2020, Siddharth Gupta wrote: > Add the character device during rproc_add. This would create > a character device node at /dev/remoteproc. Userspace > applications can interact with the remote processor using this > interface. > Reviewed-by: Bjorn Andersson

Re: [PATCH v5 1/2] remoteproc: Add remoteproc character device interface

2020-07-29 Thread Bjorn Andersson
atnagar > Signed-off-by: Siddharth Gupta Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > Documentation/userspace-api/ioctl/ioctl-number.rst | 1 + > drivers/remoteproc/Kconfig | 9 ++ > drivers/remoteproc/Makefile| 1 +

[PATCH] dt-bindings: hwlock: qcom: Remove invalid binding

2020-07-28 Thread Bjorn Andersson
...@mail.gmail.com/ Signed-off-by: Bjorn Andersson --- .../bindings/hwlock/qcom-hwspinlock.yaml | 25 +-- 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock

Re: [PATCH v3 00/13] msm8992 DTS updates, peripheral enablement

2020-07-27 Thread Bjorn Andersson
On Mon 27 Jul 11:20 PDT 2020, Konrad Dybcio wrote: > Bumping this up, in case it just got overlooked. > It was just overlooked, thanks for the bump! I think it looks good, will pick up the patches, and the previous series that it depends on. Thanks, Bjorn

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-07-27 Thread Bjorn Andersson
On Mon 27 Jul 21:40 PDT 2020, Sai Prakash Ranjan wrote: > On 2020-07-28 02:28, Bjorn Andersson wrote: > > On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > > > > > Hi Bjorn, > > > > > > On 2020-06-21 13:39, Sai Prakash Ranjan wrote: > > &

Re: [PATCH 2/2] remoteproc: qcom_q6v5_mss: Remove redundant running state

2020-07-27 Thread Bjorn Andersson
On Tue 02 Jun 09:32 PDT 2020, Sibi Sankar wrote: > Remove the redundant running state, as an equivalent is maintained in > the common q6v5 resource handling helpers. > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/qcom_q6v5_mss.c |

Re: [PATCH 1/2] remoteproc: qcom: q6v5: Update running state before requesting stop

2020-07-27 Thread Bjorn Andersson
On Wed 03 Jun 15:33 PDT 2020, Evan Green wrote: > On Tue, Jun 2, 2020 at 10:29 PM Sibi Sankar wrote: > > > > Evan, > > Thanks for taking time to review > > the series. > > > > On 2020-06-02 23:14, Evan Green wrote: > > > On Tue, Jun 2, 2020 at 9:33 AM Sibi Sankar > > > wrote: > > >> > > >> Somet

Re: [PATCH v3 2/3] remoteproc: qcom_q6v5_mss: Validate modem blob firmware size before load

2020-07-27 Thread Bjorn Andersson
kernfs_fop_write+0x140/0x230 > vfs_write+0xc4/0x208 > ksys_write+0x74/0xf8 > ... > > Fixes: 051fb70fd4ea4 ("remoteproc: qcom: Driver for the self-authenticating > Hexagon v5") > Cc: sta...@vger.kernel.org > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Ande

Re: [RESEND v1] soc: qcom: pdr: Reorder the PD state indication ack

2020-07-27 Thread Bjorn Andersson
. > > Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers") > Reported-by: Rishabh Bhatnagar > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson > --- > > I couldn't find the previous patch on patchworks. Resending the patch

Re: [PATCH v3 3/3] remoteproc: qcom_q6v5_mss: Add modem debug policy support

2020-07-27 Thread Bjorn Andersson
On Wed 22 Jul 13:10 PDT 2020, Sibi Sankar wrote: > Add modem debug policy support which will enable coredumps and live > debug support when the msadp firmware is present on secure devices. > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson > --- > > v3: &g

Re: [PATCH v3 1/3] remoteproc: qcom_q6v5_mss: Validate MBA firmware size before load

2020-07-27 Thread Bjorn Andersson
... > > Fixes: 051fb70fd4ea4 ("remoteproc: qcom: Driver for the self-authenticating > Hexagon v5") > Cc: sta...@vger.kernel.org Reviewed-by: Bjorn Andersson > Signed-off-by: Sibi Sankar > --- > drivers/remoteproc/qcom_q6v5_mss.c | 6 ++ > 1 file changed, 6 ins

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-07-27 Thread Bjorn Andersson
On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > Hi Bjorn, > > On 2020-06-21 13:39, Sai Prakash Ranjan wrote: > > Hi Bjorn, > > > > On 2020-06-21 12:52, Bjorn Andersson wrote: > > > On Tue 09 Jun 06:30 PDT 2020, Sai Prakash Ranjan wrote: >

Re: [PATCH] soc: qmi: allow user to set handle wq to hiprio

2020-07-27 Thread Bjorn Andersson
On Mon 27 Jul 08:03 PDT 2020, ? wrote: > Currently the qmi_handle is initialized single threaded and strictly > ordered with the active set to 1. This is pretty simple and safe but > sometimes ineffency. So it is better to allow user to decide whether > a high priority workqueue should be

Re: [PATCH] interconnect: Add bulk API helpers

2020-07-27 Thread Bjorn Andersson
On Thu 28 May 09:25 PDT 2020, Georgi Djakov wrote: > diff --git a/drivers/interconnect/bulk.c b/drivers/interconnect/bulk.c > new file mode 100644 > index ..9bd418594665 > --- /dev/null > +++ b/drivers/interconnect/bulk.c > @@ -0,0 +1,119 @@ > +// SPDX-License-Identifier: GPL-2.0 > + >

Re: [PATCH v10 04/13] iommu/arm-smmu-qcom: Add implementation for the adreno GPU SMMU

2020-07-26 Thread Bjorn Andersson
On Mon 20 Jul 08:40 PDT 2020, Jordan Crouse wrote: > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c [..] > +static int qcom_adreno_smmu_alloc_context_bank(struct arm_smmu_domain > *smmu_domain, > + struct device *dev, int start, int count) > +{ > + struc

Re: [PATCH 2/2] remoteproc: kill IPA notify code

2020-07-24 Thread Bjorn Andersson
emoteproc: > add IPA notification to q6v5 driver"). > > Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/remoteproc/Kconfig| 4 - > drivers/remoteproc/Makefile | 1 - > driv

Re: [PATCH 1/2] net: ipa: new notification infrastructure

2020-07-24 Thread Bjorn Andersson
me available. > Reviewed-by: Bjorn Andersson > Signed-off-by: Alex Elder > --- > David: If you approve, please only ACK; Bjorn will merge. > David, this depends on changes I carry in the rproc-next tree, so if you're okay with it I can pick this patch through my tree. Othe

Re: [PATCH V3 0/4] Add frequency / voltage scaling support for IPQ6018 SoC

2020-07-23 Thread Bjorn Andersson
On Sun 19 Jul 23:12 PDT 2020, Kathiravan T wrote: > IPQ6018 SoC uses the PMIC MP5496. SMPA2 and LDOA2 regulator of MP5496 > controls the APSS and SDCC voltage scaling respectively. Add support > for the same. > Picked up patch 1-3 for v5.10 Thanks, Bjorn > changes since V2: > - Rebased o

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-22 Thread Bjorn Andersson
On Wed 22 Jul 10:18 PDT 2020, Mathieu Poirier wrote: > On Tue, Jul 21, 2020 at 01:56:35PM -0700, Bjorn Andersson wrote: > > On Tue 21 Jul 12:16 PDT 2020, Siddharth Gupta wrote: > > > On 7/15/2020 2:51 PM, Mathieu Poirier wrote: > > > > On Wed, Jul 15, 2020 at 02:

Re: [PATCH v2 1/4] dt-bindings: hwlock: qcom: Migrate binding to YAML

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 08:13 PDT 2020, Rob Herring wrote: > On Mon, Jun 22, 2020 at 1:59 AM Bjorn Andersson > wrote: > > > > Migrate the Qualcomm TCSR mutex binding to YAML to allow validation. > > > > Reviewed-by: Vinod Koul > > Signed-off-by: Bjorn Anderss

Re: [PATCH -next] soc: qcom: geni: Fix unused lable warning

2020-07-21 Thread Bjorn Andersson
-label] > exit: > ^~~~ > > Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix > earlycon crash") Reviewed-by: Bjorn Andersson > Signed-off-by: YueHaibing and applied. Thanks, Bjorn > --- > drivers/soc/qcom/qcom-geni-se.c | 2 +- > 1 file chan

Re: [PATCH v2 2/2] remoteproc: qcom_q6v5_mss: Add MBA log extraction support

2020-07-21 Thread Bjorn Andersson
by: Sibi Sankar Reviewed-by: Bjorn Andersson Afaict this is completely independent from the other patch in the series, so I applied this. Regards, Bjorn > --- > > V2: > * Don't dump logs in mba_reclaim path [Bjorn] > * Move has_mba_logs check to q6v5_dump_mba_logs [Bjorn] >

Re: [PATCH v2 1/2] remoteproc: qcom_q6v5_mss: Add modem debug policy support

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 04:29 PDT 2020, Sibi Sankar wrote: > Add modem debug policy support which will enable coredumps and live > debug support when the msadp firmware is present on secure devices. > > Signed-off-by: Sibi Sankar > --- > > v2: > * Use request_firmware_direct [Bjorn] > * Use Bjorn's tem

Re: [PATCH V2] arm64: dts: qcom: sc7180: Include xo clock to sdhc clocks list

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 03:44 PDT 2020, Shaik Sajida Bhanu wrote: > From: Veerabhadrarao Badiganti > > Include xo clock to sdhc clocks list which will be used > in calculating MCLK_FREQ field of DLL_CONFIG2 register. > Can you please describe why this is useful, perhaps required? What difference does th

Re: [PATCH V2] arm64: dts: qcom: sc7180: SD-card GPIO pin set bias-pull up

2020-07-21 Thread Bjorn Andersson
config with bais-pull to fix this issue. > > Signed-off-by: Veerabhadrarao Badiganti > Signed-off-by: Shaik Sajida Bhanu > --- > > Changes since V1: > - Incorporated review comments by Bjorn Andersson. > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- >

Re: [PATCH 1/1] iommu/arm-smmu: Implement qcom,skip-init

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 09:20 PDT 2020, Konrad Dybcio wrote: > >The current > >focus has been on moving more of the SMMU specific bits into the > >arm-smmu-qcom > >implementation [1] and I think that is the right way to go. > > Pardon if I overlooked something obvious, but I can't seem to find a > clean w

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 12:16 PDT 2020, Siddharth Gupta wrote: > On 7/15/2020 2:51 PM, Mathieu Poirier wrote: > > On Wed, Jul 15, 2020 at 02:18:39PM -0600, Mathieu Poirier wrote: > > > On Tue, Jul 07, 2020 at 12:07:49PM -0700, Siddharth Gupta wrote: [..] > > > > diff --git a/drivers/remoteproc/remoteproc_cde

Re: [PATCH] soc: qcom: geni: Fix NULL pointer dereference

2020-07-20 Thread Bjorn Andersson
h Ranjan > Signed-off-by: Akash Asthana Reviewed-by: Bjorn Andersson Tested-by: Bjorn Andersson And applied with Matthias suggested rename of wrapper_pdev to pdev. PS. Please include linux-arm-...@vger.kernel.org among your recipients for future patches. Regards, Bjorn > --- &

Re: [PATCH V1] arm64: dts: qcom: Add bandwidth votes for eMMC and SDcard

2020-07-18 Thread Bjorn Andersson
On Fri 17 Jul 23:33 PDT 2020, Shaik Sajida Bhanu wrote: Plase add "sc7180: " between "qcom:" and "Add" > From: Pradeep P V K > > Add the bandwidth domain supporting performance state and > the corresponding OPP tables for the sdhc device on sc7180. > You need Pradeep's signed-off-by here befo

Re: [PATCH V1] arm64: dts: qcom: SD-card GPIO pin set bias-pull up

2020-07-18 Thread Bjorn Andersson
On Fri 17 Jul 23:34 PDT 2020, Shaik Sajida Bhanu wrote: > From: Veerabhadrarao Badiganti > > On some sc7180 based platforms where external pull is not present on cd-gpio, > this gpio state is getting read as HIGH when sleep config is applied on it. > This is resulting in SDcard rescan after susp

<    5   6   7   8   9   10   11   12   13   14   >