Re: [PATCH v3 00/13] msm8992 DTS updates, peripheral enablement

2020-07-28 Thread Bjorn Andersson
On Mon 27 Jul 11:20 PDT 2020, Konrad Dybcio wrote: > Bumping this up, in case it just got overlooked. > It was just overlooked, thanks for the bump! I think it looks good, will pick up the patches, and the previous series that it depends on. Thanks, Bjorn

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-07-28 Thread Bjorn Andersson
On Mon 27 Jul 21:40 PDT 2020, Sai Prakash Ranjan wrote: > On 2020-07-28 02:28, Bjorn Andersson wrote: > > On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > > > > > Hi Bjorn, > > > > > > On 2020-06-21 13:39, Sai Prakash Ranjan wrote: > > &

Re: [PATCH 2/2] remoteproc: qcom_q6v5_mss: Remove redundant running state

2020-07-28 Thread Bjorn Andersson
On Tue 02 Jun 09:32 PDT 2020, Sibi Sankar wrote: > Remove the redundant running state, as an equivalent is maintained in > the common q6v5 resource handling helpers. > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/qcom_q6v5_mss.c |

Re: [PATCH 1/2] remoteproc: qcom: q6v5: Update running state before requesting stop

2020-07-28 Thread Bjorn Andersson
On Wed 03 Jun 15:33 PDT 2020, Evan Green wrote: > On Tue, Jun 2, 2020 at 10:29 PM Sibi Sankar wrote: > > > > Evan, > > Thanks for taking time to review > > the series. > > > > On 2020-06-02 23:14, Evan Green wrote: > > > On Tue, Jun 2, 2020 at 9:33 AM Sibi Sankar > > > wrote: > > >> > > >>

Re: [PATCH v3 2/3] remoteproc: qcom_q6v5_mss: Validate modem blob firmware size before load

2020-07-28 Thread Bjorn Andersson
kernfs_fop_write+0x140/0x230 > vfs_write+0xc4/0x208 > ksys_write+0x74/0xf8 > ... > > Fixes: 051fb70fd4ea4 ("remoteproc: qcom: Driver for the self-authenticating > Hexagon v5") > Cc: sta...@vger.kernel.org > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Ande

Re: [RESEND v1] soc: qcom: pdr: Reorder the PD state indication ack

2020-07-28 Thread Bjorn Andersson
. > > Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers") > Reported-by: Rishabh Bhatnagar > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson > --- > > I couldn't find the previous patch on patchworks. Resending the patch &g

Re: [PATCH v3 3/3] remoteproc: qcom_q6v5_mss: Add modem debug policy support

2020-07-27 Thread Bjorn Andersson
On Wed 22 Jul 13:10 PDT 2020, Sibi Sankar wrote: > Add modem debug policy support which will enable coredumps and live > debug support when the msadp firmware is present on secure devices. > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson > --- > > v3

Re: [PATCH v3 1/3] remoteproc: qcom_q6v5_mss: Validate MBA firmware size before load

2020-07-27 Thread Bjorn Andersson
... > > Fixes: 051fb70fd4ea4 ("remoteproc: qcom: Driver for the self-authenticating > Hexagon v5") > Cc: sta...@vger.kernel.org Reviewed-by: Bjorn Andersson > Signed-off-by: Sibi Sankar > --- > drivers/remoteproc/qcom_q6v5_mss.c | 6 ++ > 1 file changed, 6 ins

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-07-27 Thread Bjorn Andersson
On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > Hi Bjorn, > > On 2020-06-21 13:39, Sai Prakash Ranjan wrote: > > Hi Bjorn, > > > > On 2020-06-21 12:52, Bjorn Andersson wrote: > > > On Tue 09 Jun 06:30 PDT 2020, Sai Prakash Ranjan wrote: &

Re: [PATCH] soc: qmi: allow user to set handle wq to hiprio

2020-07-27 Thread Bjorn Andersson
On Mon 27 Jul 08:03 PDT 2020, ? wrote: > Currently the qmi_handle is initialized single threaded and strictly > ordered with the active set to 1. This is pretty simple and safe but > sometimes ineffency. So it is better to allow user to decide whether > a high priority workqueue should be

Re: [PATCH] interconnect: Add bulk API helpers

2020-07-27 Thread Bjorn Andersson
On Thu 28 May 09:25 PDT 2020, Georgi Djakov wrote: > diff --git a/drivers/interconnect/bulk.c b/drivers/interconnect/bulk.c > new file mode 100644 > index ..9bd418594665 > --- /dev/null > +++ b/drivers/interconnect/bulk.c > @@ -0,0 +1,119 @@ > +// SPDX-License-Identifier: GPL-2.0 > + >

Re: [PATCH v10 04/13] iommu/arm-smmu-qcom: Add implementation for the adreno GPU SMMU

2020-07-27 Thread Bjorn Andersson
On Mon 20 Jul 08:40 PDT 2020, Jordan Crouse wrote: > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c [..] > +static int qcom_adreno_smmu_alloc_context_bank(struct arm_smmu_domain > *smmu_domain, > + struct device *dev, int start, int count) > +{ > +

Re: [PATCH 2/2] remoteproc: kill IPA notify code

2020-07-24 Thread Bjorn Andersson
emoteproc: > add IPA notification to q6v5 driver"). > > Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/remoteproc/Kconfig| 4 - > drivers/remoteproc/Makefile | 1 - > driv

Re: [PATCH 1/2] net: ipa: new notification infrastructure

2020-07-24 Thread Bjorn Andersson
me available. > Reviewed-by: Bjorn Andersson > Signed-off-by: Alex Elder > --- > David: If you approve, please only ACK; Bjorn will merge. > David, this depends on changes I carry in the rproc-next tree, so if you're okay with it I can pick this patch through my tree. Otherwise

Re: [PATCH V3 0/4] Add frequency / voltage scaling support for IPQ6018 SoC

2020-07-23 Thread Bjorn Andersson
On Sun 19 Jul 23:12 PDT 2020, Kathiravan T wrote: > IPQ6018 SoC uses the PMIC MP5496. SMPA2 and LDOA2 regulator of MP5496 > controls the APSS and SDCC voltage scaling respectively. Add support > for the same. > Picked up patch 1-3 for v5.10 Thanks, Bjorn > changes since V2: > - Rebased

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-22 Thread Bjorn Andersson
On Wed 22 Jul 10:18 PDT 2020, Mathieu Poirier wrote: > On Tue, Jul 21, 2020 at 01:56:35PM -0700, Bjorn Andersson wrote: > > On Tue 21 Jul 12:16 PDT 2020, Siddharth Gupta wrote: > > > On 7/15/2020 2:51 PM, Mathieu Poirier wrote: > > > > On Wed, Jul 15, 2020 at 02:

Re: [PATCH v2 1/4] dt-bindings: hwlock: qcom: Migrate binding to YAML

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 08:13 PDT 2020, Rob Herring wrote: > On Mon, Jun 22, 2020 at 1:59 AM Bjorn Andersson > wrote: > > > > Migrate the Qualcomm TCSR mutex binding to YAML to allow validation. > > > > Reviewed-by: Vinod Koul > > Signed-off-by: Bjorn Anderss

Re: [PATCH -next] soc: qcom: geni: Fix unused lable warning

2020-07-21 Thread Bjorn Andersson
-label] > exit: > ^~~~ > > Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix > earlycon crash") Reviewed-by: Bjorn Andersson > Signed-off-by: YueHaibing and applied. Thanks, Bjorn > --- > drivers/soc/qcom/qcom-geni-se.c | 2 +- > 1 file ch

Re: [PATCH v2 2/2] remoteproc: qcom_q6v5_mss: Add MBA log extraction support

2020-07-21 Thread Bjorn Andersson
by: Sibi Sankar Reviewed-by: Bjorn Andersson Afaict this is completely independent from the other patch in the series, so I applied this. Regards, Bjorn > --- > > V2: > * Don't dump logs in mba_reclaim path [Bjorn] > * Move has_mba_logs check to q6v5_dump_mba_logs [Bjorn] > *

Re: [PATCH v2 1/2] remoteproc: qcom_q6v5_mss: Add modem debug policy support

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 04:29 PDT 2020, Sibi Sankar wrote: > Add modem debug policy support which will enable coredumps and live > debug support when the msadp firmware is present on secure devices. > > Signed-off-by: Sibi Sankar > --- > > v2: > * Use request_firmware_direct [Bjorn] > * Use Bjorn's

Re: [PATCH V2] arm64: dts: qcom: sc7180: Include xo clock to sdhc clocks list

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 03:44 PDT 2020, Shaik Sajida Bhanu wrote: > From: Veerabhadrarao Badiganti > > Include xo clock to sdhc clocks list which will be used > in calculating MCLK_FREQ field of DLL_CONFIG2 register. > Can you please describe why this is useful, perhaps required? What difference does

Re: [PATCH V2] arm64: dts: qcom: sc7180: SD-card GPIO pin set bias-pull up

2020-07-21 Thread Bjorn Andersson
sleep config with bais-pull to fix this issue. > > Signed-off-by: Veerabhadrarao Badiganti > Signed-off-by: Shaik Sajida Bhanu > --- > > Changes since V1: > - Incorporated review comments by Bjorn Andersson. > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- >

Re: [PATCH 1/1] iommu/arm-smmu: Implement qcom,skip-init

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 09:20 PDT 2020, Konrad Dybcio wrote: > >The current > >focus has been on moving more of the SMMU specific bits into the > >arm-smmu-qcom > >implementation [1] and I think that is the right way to go. > > Pardon if I overlooked something obvious, but I can't seem to find a > clean

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-21 Thread Bjorn Andersson
On Tue 21 Jul 12:16 PDT 2020, Siddharth Gupta wrote: > On 7/15/2020 2:51 PM, Mathieu Poirier wrote: > > On Wed, Jul 15, 2020 at 02:18:39PM -0600, Mathieu Poirier wrote: > > > On Tue, Jul 07, 2020 at 12:07:49PM -0700, Siddharth Gupta wrote: [..] > > > > diff --git

Re: [PATCH] soc: qcom: geni: Fix NULL pointer dereference

2020-07-20 Thread Bjorn Andersson
Signed-off-by: Akash Asthana Reviewed-by: Bjorn Andersson Tested-by: Bjorn Andersson And applied with Matthias suggested rename of wrapper_pdev to pdev. PS. Please include linux-arm-...@vger.kernel.org among your recipients for future patches. Regards, Bjorn > --- > drivers/so

Re: [PATCH V1] arm64: dts: qcom: Add bandwidth votes for eMMC and SDcard

2020-07-18 Thread Bjorn Andersson
On Fri 17 Jul 23:33 PDT 2020, Shaik Sajida Bhanu wrote: Plase add "sc7180: " between "qcom:" and "Add" > From: Pradeep P V K > > Add the bandwidth domain supporting performance state and > the corresponding OPP tables for the sdhc device on sc7180. > You need Pradeep's signed-off-by here

Re: [PATCH V1] arm64: dts: qcom: SD-card GPIO pin set bias-pull up

2020-07-18 Thread Bjorn Andersson
On Fri 17 Jul 23:34 PDT 2020, Shaik Sajida Bhanu wrote: > From: Veerabhadrarao Badiganti > > On some sc7180 based platforms where external pull is not present on cd-gpio, > this gpio state is getting read as HIGH when sleep config is applied on it. > This is resulting in SDcard rescan after

Re: [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description

2020-07-17 Thread Bjorn Andersson
r 'variant' not described in 'pm8xxx_xoadc' > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Linus Walleij > Cc: linux-arm-...@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson > --- > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 3 ++- > 1 file chan

Re: [PATCH v6 9/9] remoteproc: Properly handle firmware name when attaching

2020-07-16 Thread Bjorn Andersson
at is loaded by the external entity. > > Signed-off-by: Mathieu Poirier > Reviewed-by: Arnaud Pouliquen > Tested-by: Arnaud Pouliquen Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/remoteproc_core.c | 18 ++ > drivers/remoteproc/remoteproc_sysfs.c

Re: [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add MBA log extraction support

2020-07-16 Thread Bjorn Andersson
On Thu 16 Jul 22:22 PDT 2020, Sibi Sankar wrote: > On 2020-07-17 10:27, Bjorn Andersson wrote: > > On Thu 16 Jul 05:36 PDT 2020, Sibi Sankar wrote: > > > > > On SC7180 the MBA firmware stores the bootup text logs in a 4K segment > > > at the beginning of the M

Re: [PATCH v4 2/2] remoteproc: core: Register the character device interface

2020-07-16 Thread Bjorn Andersson
On Tue 07 Jul 12:07 PDT 2020, Siddharth Gupta wrote: > Add the character device during rproc_add. This would create > a character device node at /dev/remoteproc. Userspace > applications can interact with the remote processor using this > interface. > > Signed-off-by: Rishabh Bhatnagar >

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-16 Thread Bjorn Andersson
On Wed 15 Jul 13:18 PDT 2020, Mathieu Poirier wrote: > On Tue, Jul 07, 2020 at 12:07:49PM -0700, Siddharth Gupta wrote: > > Add the character device interface into remoteproc framework. > > This interface can be used in order to boot/shutdown remote > > subsystems and provides a basic ioctl based

Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-16 Thread Bjorn Andersson
On Tue 07 Jul 12:07 PDT 2020, Siddharth Gupta wrote: > Add the character device interface into remoteproc framework. > This interface can be used in order to boot/shutdown remote > subsystems and provides a basic ioctl based interface to implement > supplementary functionality. An ioctl call is

Re: [PATCH v8 4/5] remoteproc: Add inline coredump functionality

2020-07-16 Thread Bjorn Andersson
agar > Tested-by: Sibi Sankar Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/remoteproc_coredump.c | 156 > +++ > include/linux/remoteproc.h | 16 > 2 files changed, 154 insertions(+), 18 deletions(-) > > diff

Re: [PATCH v8 3/5] remoteproc: Pass size and offset as arguments to segment dump function

2020-07-16 Thread Bjorn Andersson
mp functionality being added in the next > patch. > Reviewed-by: Bjorn Andersson > Signed-off-by: Rishabh Bhatnagar > --- > drivers/remoteproc/qcom_q6v5_mss.c | 10 +- > drivers/remoteproc/remoteproc_coredump.c | 5 +++-- > include/linux/remoteproc.h

Re: [PATCH v8 2/5] remoteproc: qcom_q6v5_mss: Replace mask based tracking with size

2020-07-16 Thread Bjorn Andersson
ze. > > Signed-off-by: Sibi Sankar > Signed-off-by: Rishabh Bhatnagar Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/qcom_q6v5_mss.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c

Re: [PATCH 3/3] remoteproc: qcom_q6v5_mss: Update MBA log info

2020-07-16 Thread Bjorn Andersson
On Thu 16 Jul 05:36 PDT 2020, Sibi Sankar wrote: > Update MBA text logs location/size in IMEM to aid tools extract > them after ramdump collection. > > Signed-off-by: Sibi Sankar > --- > drivers/remoteproc/qcom_q6v5_mss.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add MBA log extraction support

2020-07-16 Thread Bjorn Andersson
On Thu 16 Jul 05:36 PDT 2020, Sibi Sankar wrote: > On SC7180 the MBA firmware stores the bootup text logs in a 4K segment > at the beginning of the MBA region. Add support to extract the logs > which will be useful to debug mba boot/authentication issues. > > Signed-off-by: Sibi Sankar > --- >

Re: [PATCH 1/3] remoteproc: qcom_q6v5_mss: Add modem debug policy support

2020-07-16 Thread Bjorn Andersson
On Thu 16 Jul 05:36 PDT 2020, Sibi Sankar wrote: > Add modem debug policy support which will enable coredumps and live > debug support when the msadp firmware is present on secure devices. > > Signed-off-by: Sibi Sankar > --- > drivers/remoteproc/qcom_q6v5_mss.c | 15 ++- > 1 file

[PATCH v2 5/5] iommu/arm-smmu: Setup identity domain for boot mappings

2020-07-16 Thread Bjorn Andersson
-by: Bjorn Andersson --- Changes since v1: - Rebased to avoid conflict - Picked up tested-by drivers/iommu/arm-smmu-qcom.c | 11 + drivers/iommu/arm-smmu.c | 79 +-- drivers/iommu/arm-smmu.h | 3 ++ 3 files changed, 89 insertions(+), 4 deletions

[PATCH v2 2/5] iommu/arm-smmu: Emulate bypass by using context banks

2020-07-16 Thread Bjorn Andersson
translation. Tested-by: John Stultz Tested-by: Vinod Koul Signed-off-by: Bjorn Andersson --- Changes since v1: - Picked up tested-by drivers/iommu/arm-smmu-qcom.c | 21 + drivers/iommu/arm-smmu.c | 14 -- drivers/iommu/arm-smmu.h | 3 +++ 3 files changed

[PATCH v2 4/5] iommu/arm-smmu-qcom: Consistently initialize stream mappings

2020-07-16 Thread Bjorn Andersson
ings might linger and reference context banks that Linux is reconfiguring. Use the fact that BYPASS writes result in FAULT type to force all stream mappings to FAULT. Tested-by: John Stultz Tested-by: Vinod Koul Signed-off-by: Bjorn Andersson --- Changes since v1: - Fixed subject spelling mistak

[PATCH v2 3/5] iommu/arm-smmu: Move SMR and S2CR definitions to header file

2020-07-16 Thread Bjorn Andersson
Expose the SMR and S2CR structs in the header file, to allow platform specific implementations to populate/initialize the smrs and s2cr arrays. Tested-by: John Stultz Tested-by: Vinod Koul Signed-off-by: Bjorn Andersson --- Changes since v1: - Picked up tested-by drivers/iommu/arm-smmu.c

[PATCH v2 0/5] iommu/arm-smmu: Support maintaining bootloader mappings

2020-07-16 Thread Bjorn Andersson
to allow booting SDM845, SDM850, SM8150, SM8250 with boot splash screen setup by the bootloader. Specifically it also allows the Lenovo Yoga C630 to boot with SMMU and efifb enabled. Bjorn Andersson (5): iommu/arm-smmu: Make all valid stream mappings BYPASS iommu/arm-smmu: Emulate bypass

[PATCH v2 1/5] iommu/arm-smmu: Make all valid stream mappings BYPASS

2020-07-16 Thread Bjorn Andersson
Suggested-by: Robin Murphy Signed-off-by: Bjorn Andersson --- Changes since v1: - Mark arm_smmu_setup_identity() static - Picked up tested-by tags drivers/iommu/arm-smmu.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c

Re: [PATCH v2 1/4] dt-bindings: media: venus: Add an optional power domain for perf voting

2020-07-16 Thread Bjorn Andersson
On Wed 15 Jul 22:42 PDT 2020, Rajendra Nayak wrote: > Add an optional power domain which when specified can be used for > setting the performance state of Venus. > > Signed-off-by: Rajendra Nayak > --- > This is a resend of https://lore.kernel.org/patchwork/patch/1241077/ > >

Re: [PATCH] arm64: dts: qcom: sc7180: Move the fixed-perm property to SoC dtsi

2020-07-16 Thread Bjorn Andersson
On Thu 16 Jul 12:17 PDT 2020, Sibi Sankar wrote: > All the platforms using SC7180 SoC are expected to have the wlan firmware > memory statically mapped by the Trusted Firmware. Hence move back the > qcom,msa-fixed-perm property to the SoC dtsi. > > Fixes: 7d484566087c0 ("arm64: dts: qcom:

Re: [PATCH] drm: panel: simple: Delay HPD checking on boe_nv133fhm_n61 for 15 ms

2020-07-16 Thread Bjorn Andersson
good solution to handle that > case. > > Even though the delay was measured as 8 ms, 15 ms was chosen to give a > bit of margin. > Reviewed-by: Bjorn Andersson > Signed-off-by: Douglas Anderson > --- > I don't actually have a device in front of me that is exhibiting

[PATCH] remoteproc: qcom: pil-info: Fix shift overflow

2020-07-15 Thread Bjorn Andersson
by: Nathan Chancellor Signed-off-by: Bjorn Andersson --- drivers/remoteproc/qcom_pil_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_pil_info.c b/drivers/remoteproc/qcom_pil_info.c index 0536e3904669..5521c4437ffa 100644 --- a/drivers/remoteproc/qcom_

Re: [PATCH v2] arm64: dts: qcom: sc7180: Add missing properties for Wifi node

2020-07-15 Thread Bjorn Andersson
On Wed 15 Jul 12:01 PDT 2020, Doug Anderson wrote: > Hi, > > On Sun, Jul 12, 2020 at 9:46 PM Rakesh Pillai wrote: > > > > The wlan firmware memory is statically mapped in > > the Trusted Firmware, hence the wlan driver does > > not need to map/unmap this region dynamically. > > > > Hence add

Re: [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues

2020-07-15 Thread Bjorn Andersson
On Wed 15 Jul 05:35 PDT 2020, Lee Jones wrote: > Looks as though 'name' has now been moved into 'struct sysmod_event' > which is passed in instead. However, the parameter descriptions were > not updated at the same time. Let's do that now. > > Fixes the following W=1 kernel build warning(s): >

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-14 Thread Bjorn Andersson
On Tue 14 Jul 15:13 PDT 2020, Rob Herring wrote: > On Tue, Jul 14, 2020 at 10:33 AM Jeffrey Hugo > wrote: > > > > On Mon, Jul 13, 2020 at 5:50 PM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > > > > > > > On Mon, Jul 13, 2020 at 9:08 AM

Re: [PATCH v2 3/4] hwspinlock: qcom: Allow mmio usage in addition to syscon

2020-07-14 Thread Bjorn Andersson
On Tue 14 Jul 09:04 PDT 2020, Stephan Gerhold wrote: > Hi Bjorn, > > On Mon, Jun 22, 2020 at 12:59:55AM -0700, Bjorn Andersson wrote: > > In modern Qualcomm platforms the mutex region of the TCSR is forked off > > into its own block, all with a offset of 0 and stride of

Re: [PATCH v2] tty: serial: qcom-geni-serial: Drop the icc bw votes in suspend for console

2020-07-14 Thread Bjorn Andersson
On Mon 13 Jul 22:31 PDT 2020, Rajendra Nayak wrote: > When using the geni-serial as console, its important to be > able to hit the lowest possible power state in suspend, > even with no_console_suspend. > The only thing that prevents it today on platforms like the sc7180 > is the interconnect BW

Re: [PATCH v3 5/8] mailbox: qcom: Add msm8994 apcs compatible

2020-07-13 Thread Bjorn Andersson
On Wed 24 Jun 08:01 PDT 2020, Konrad Dybcio wrote: > MSM8994 has an APCS block similar to 8916, but > with a different clock driver due to the former > one having 2 clusters. > > Signed-off-by: Konrad Dybcio Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > ..

Re: [PATCH v3 7/7] mailbox: qcom: Add sdm660 hmss compatible

2020-07-13 Thread Bjorn Andersson
On Fri 26 Jun 08:48 PDT 2020, Alexey Minnekhanov wrote: > Tue, 23 Jun. 2020. 10:29, Bjorn Andersson : > > > > On Mon 22 Jun 12:25 PDT 2020, Konrad Dybcio wrote: > > > > > Signed-off-by: Konrad Dybcio > > > > Reviewed-by: Bjorn Andersson > >

Re: [PATCH v6 1/2] remoteproc: qcom: Add per subsystem SSR notification

2020-07-13 Thread Bjorn Andersson
On Mon 13 Jul 09:26 PDT 2020, Jon Hunter wrote: > > On 24/06/2020 03:23, Rishabh Bhatnagar wrote: > > Currently there is a single notification chain which is called whenever any > > remoteproc shuts down. This leads to all the listeners being notified, and > > is not an optimal design as kernel

Re: [PATCH -next] remoteproc: qcom: Add missing slab.h

2020-07-13 Thread Bjorn Andersson
On Sun 12 Jul 19:00 PDT 2020, Kefeng Wang wrote: > drivers/remoteproc/qcom_common.c: In function ‘qcom_ssr_get_subsys’: > drivers/remoteproc/qcom_common.c:210:9: error: implicit declaration of > function ‘kzalloc’; did you mean ‘vzalloc’? > [-Werror=implicit-function-declaration] > info =

Re: [PATCH] firmware: qcom_scm: Fix legacy convention SCM accessors

2020-07-13 Thread Bjorn Andersson
On Mon 13 Jul 09:35 PDT 2020, Elliot Berman wrote: > For the Qualcomm TrustZone firmwares which I am familiar with: > > Reviewed-by: Elliot Berman > Thanks for the patch Jonathan and thanks for the review Elliot! Applied Regards, Bjorn > On 7/4/2020 10:23 AM, Jonathan McDowell wrote: > >

Re: [PATCH 1/1] clk: qcom: smd: Add support for MSM8992/4 rpm clocks

2020-07-11 Thread Bjorn Andersson
On Wed 24 Jun 15:32 PDT 2020, Stephen Boyd wrote: > Quoting Konrad Dybcio (2020-06-24 08:09:18) > > I should also note that for quite some time a hack [1] > > has been needed on some platforms for the RPMCC to register. > > > > This includes 8992/94, 8956/76 and possibly many more. > > > > With

Re: [PATCH -next] : add stub for of_get_next_parent() to fix qcom build error

2020-07-11 Thread Bjorn Andersson
e. > Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix > earlycon crash") > Thank you, added this to the commit and... > >> Signed-off-by: Randy Dunlap > >> Cc: Rob Herring > >> Cc: Frank Rowand > >> Cc: devicet...@vger.k

Re: [PATCH 5/5] iommu/arm-smmu: Setup identity domain for boot mappings

2020-07-09 Thread Bjorn Andersson
On Thu 09 Jul 08:50 PDT 2020, Laurentiu Tudor wrote: > > > On 7/9/2020 8:01 AM, Bjorn Andersson wrote: > > With many Qualcomm platforms not having functional S2CR BYPASS a > > temporary IOMMU domain, without translation, needs to be allocated in > > order to allo

Re: [PATCH 2/5] iommu/arm-smmu: Emulate bypass by using context banks

2020-07-09 Thread Bjorn Andersson
On Thu 09 Jul 11:55 PDT 2020, Rob Clark wrote: > On Thu, Jul 9, 2020 at 9:56 AM Rob Clark wrote: > > > > On Thu, Jul 9, 2020 at 9:48 AM Bjorn Andersson > > wrote: > > > > > > On Thu 09 Jul 09:17 PDT 2020, Rob Clark wrote: > > > > &g

Re: [PATCH 2/5] iommu/arm-smmu: Emulate bypass by using context banks

2020-07-09 Thread Bjorn Andersson
On Thu 09 Jul 09:17 PDT 2020, Rob Clark wrote: > On Wed, Jul 8, 2020 at 10:01 PM Bjorn Andersson > wrote: [..] > > @@ -678,7 +680,11 @@ static int arm_smmu_init_domain_context(struct > > iommu_domain *domain, > > if (smmu_domain->smmu) > >

Re: [PATCH] pinctrl: qcom: Handle broken PDC dual edge case on sc7180

2020-07-09 Thread Bjorn Andersson
ver letting our parent see > requests for single edge interrupts on affected hardware. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Douglas Anderson Looks good to me, but did even less testing than you. Reviewed-by: Bjorn Andersson

Re: [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables

2020-07-09 Thread Bjorn Andersson
On Thu 02 Jul 13:46 PDT 2020, Sibi Sankar wrote: > Add OPP tables required to scale DDR/L3 per freq-domain on SDM845 SoCs. > > Signed-off-by: Sibi Sankar Tested-by: Bjorn Andersson and applied. Thanks, Bjorn > --- > > v2: > * Drop interconnect tags > * Add al

Re: [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables

2020-07-09 Thread Bjorn Andersson
On Wed 08 Jul 19:22 PDT 2020, Steev Klimaszewski wrote: > > On 7/2/20 3:46 PM, Sibi Sankar wrote: > > Add OPP tables required to scale DDR/L3 per freq-domain on SDM845 SoCs. > > > > Signed-off-by: Sibi Sankar > > --- > > > Hi Sibi, > > > Bjorn asked me to give this patch a whirl, and I have

[PATCH 3/5] iommu/arm-smmu: Move SMR and S2CR definitions to header file

2020-07-08 Thread Bjorn Andersson
Expose the SMR and S2CR structs in the header file, to allow platform specific implementations to populate/initialize the smrs and s2cr arrays. Signed-off-by: Bjorn Andersson --- drivers/iommu/arm-smmu.c | 14 -- drivers/iommu/arm-smmu.h | 15 +++ 2 files changed, 15

[PATCH 0/5] iommu/arm-smmu: Support maintaining bootloader mappings

2020-07-08 Thread Bjorn Andersson
to allow booting SDM845, SDM850, SM8150, SM8250 with boot splash screen setup by the bootloader. Specifically it also allows the Lenovo Yoga C630 to boot with SMMU and efifb enabled. Bjorn Andersson (5): iommu/arm-smmu: Make all valid stream mappings BYPASS iommu/arm-smmu: Emulate bypass

[PATCH 4/5] iommu/arm-smmu-qcom: Consstently initialize stream mappings

2020-07-08 Thread Bjorn Andersson
ings might linger and reference context banks that Linux is reconfiguring. Use the fact that BYPASS writes result in FAULT type to force all stream mappings to FAULT. Signed-off-by: Bjorn Andersson --- drivers/iommu/arm-smmu-qcom.c | 18 +- 1 file changed, 17 insertions(+),

[PATCH 5/5] iommu/arm-smmu: Setup identity domain for boot mappings

2020-07-08 Thread Bjorn Andersson
context bank is used and streams are diverted here during initialization. This also performs the readback of SMR registers for the Qualcomm platform, to trigger the mechanism. This is based on prior work by Thierry Reding and Laurentiu Tudor. Signed-off-by: Bjorn Andersson --- drivers/iommu/arm-smmu

[PATCH 1/5] iommu/arm-smmu: Make all valid stream mappings BYPASS

2020-07-08 Thread Bjorn Andersson
Turn all stream mappings marked as valid into BYPASS. This allows the platform specific implementation to configure stream mappings to match the boot loader's configuration for e.g. display to continue to function through the reset of the SMMU. Suggested-by: Robin Murphy Signed-off-by: Bjorn

[PATCH 2/5] iommu/arm-smmu: Emulate bypass by using context banks

2020-07-08 Thread Bjorn Andersson
translation. Signed-off-by: Bjorn Andersson --- drivers/iommu/arm-smmu-qcom.c | 21 + drivers/iommu/arm-smmu.c | 14 -- drivers/iommu/arm-smmu.h | 3 +++ 3 files changed, 36 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers

Re: [PATCH v2 0/8] arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts

2020-07-08 Thread Bjorn Andersson
On Fri 03 Jul 05:31 PDT 2020, Will Deacon wrote: > On Tue, Jun 09, 2020 at 03:40:18PM -0400, Jonathan Marek wrote: > > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > > > Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a > > few changes. Notably, the

Re: [PATCH v2 2/8] iommu: arm-smmu-impl: Use qcom impl for sm8150 and sm8250 compatibles

2020-07-08 Thread Bjorn Andersson
On Tue 09 Jun 12:40 PDT 2020, Jonathan Marek wrote: > Use the qcom implementation for IOMMU hardware on sm8150 and sm8250 SoCs. > > Signed-off-by: Jonathan Marek Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/iommu/arm-smmu-impl.c | 4 +++- > 1 file changed,

Re: [PATCH V2] pinctrl: qcom: ipq8074: route gpio interrupts to APPS

2020-07-07 Thread Bjorn Andersson
On Tue 07 Jul 00:39 PDT 2020, Kathiravan T wrote: > set target proc as APPS to route the gpio interrupts to APPS > > Co-developed-by: Rajkumar Ayyasamy > Signed-off-by: Rajkumar Ayyasamy > Signed-off-by: Kathiravan T Thanks for the quick respin. Acked-by: Bjorn Andersson

Re: [PATCH] pinctrl: qcom: ipq8074: route gpio interrupts to APPS

2020-07-06 Thread Bjorn Andersson
On Mon 06 Jul 21:58 PDT 2020, Kathiravan T wrote: > set target proc as APPS to route the gpio interrupts to APPS > > Signed-off-by: Rajkumar Ayyasamy > Signed-off-by: Kathiravan T This says "first Rajkumar certified the patch's origin, then you picked it up and certified its origin". As such

Re: [PATCH] phy: qcom: remove ufs qmp phy driver

2020-07-06 Thread Bjorn Andersson
On Mon 29 Jun 21:54 PDT 2020, Vinod Koul wrote: > Hi Bjorn, > > On 29-06-20, 12:24, Bjorn Andersson wrote: > > On Mon 29 Jun 07:54 PDT 2020, Vinod Koul wrote: > > > > > UFS QMP phy drivers are duplicate as we are supposed to use common QMP > > > phy

Re: [PATCH v2] pinctrl: qcom: sc7180: Make gpio28 non wakeup capable for google,lazor

2020-07-06 Thread Bjorn Andersson
On Mon 06 Jul 13:24 PDT 2020, Doug Anderson wrote: > Hi, > > On Fri, Jul 3, 2020 at 12:49 AM Rajendra Nayak wrote: > > > > The PDC irqchip driver currently does not handle dual-edge interrupts, > > and we have google,lazor board with sc7180 designed to configure gpio28 > > as a dual-edge

Re: [PATCH 1/1] iommu/arm-smmu: Implement qcom,skip-init

2020-07-04 Thread Bjorn Andersson
On Sat 04 Jul 06:09 PDT 2020, Will Deacon wrote: > [Adding Bjorn, Jordan and John because I really don't want a bunch of > different ways to tell the driver that the firmware is screwing things up] > Thanks Will. > On Sat, Jul 04, 2020 at 02:28:09PM +0200, Konrad Dybcio wrote: > > This adds

[PATCH] arm64: defcondfig: Enable USB ACM and FTDI drivers

2020-07-03 Thread Bjorn Andersson
Enable USB serial drivers to provide UART access to various development boards from an ARM64 host. Signed-off-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

Re: [PATCH v3 1/2] remoteproc: Add remoteproc character device interface

2020-07-01 Thread Bjorn Andersson
On Wed 01 Jul 05:13 PDT 2020, Arnaud POULIQUEN wrote: > > > On 7/1/20 12:02 AM, Siddharth Gupta wrote: > > > > On 6/30/2020 12:43 AM, Arnaud POULIQUEN wrote: > >> > >> On 6/30/20 7:38 AM, Siddharth Gupta wrote: > >>> On 6/17/2020 1:44 AM, Arnaud POULIQUEN wrote: > On 6/16/20 9:56 PM,

Re: [PATCH v3 1/2] remoteproc: Add remoteproc character device interface

2020-06-30 Thread Bjorn Andersson
On Tue 30 Jun 00:43 PDT 2020, Arnaud POULIQUEN wrote: > > > On 6/30/20 7:38 AM, Siddharth Gupta wrote: > > > > On 6/17/2020 1:44 AM, Arnaud POULIQUEN wrote: > >> > >> On 6/16/20 9:56 PM, risha...@codeaurora.org wrote: > >>> On 2020-04-30 01:30, Arnaud POULIQUEN wrote: > Hi Rishabh, >

Re: [PATCH v4 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-06-29 Thread Bjorn Andersson
On Mon 29 Jun 17:37 PDT 2020, Stefano Stabellini wrote: > On Wed, 10 Jun 2020, Rob Herring wrote: > > On Tue, May 26, 2020 at 11:40 AM Ben Levinsky wrote: > > > > > > Hi Rob, > > > > > > The Xilinx R5 Remoteproc driver has been around for a long time -- > > > admittedly we should have

Re: [PATCH -next] : add stub for of_get_next_parent() to fix qcom build error

2020-06-29 Thread Bjorn Andersson
ring > Cc: Frank Rowand > Cc: devicet...@vger.kernel.org > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: linux-arm-...@vger.kernel.org Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > include/linux/of.h |5 + > 1 file changed, 5 insertions(+) > > --- linux-ne

Re: [PATCH] phy: qcom: remove ufs qmp phy driver

2020-06-29 Thread Bjorn Andersson
On Mon 29 Jun 07:54 PDT 2020, Vinod Koul wrote: > UFS QMP phy drivers are duplicate as we are supposed to use common QMP > phy driver which is working fine on various platforms. So remove the > unused driver > This describes the current state, but the UFS QMP driver had a purpose not that long

Re: [PATCH 3/3] phy: qcom-qmp: Add QMP V4 USB3 PHY support for sm8250

2020-06-26 Thread Bjorn Andersson
On Sat 23 May 19:14 PDT 2020, Jonathan Marek wrote: > Add both the DP and UNI PHY for primary/secondary usb controllers. > > The tables are very similar to sm8150 (serdes_tbl is identical), but there > are some differences. > > Signed-off-by: Jonathan Marek Reviewed-b

Re: [PATCH 2/3] phy: qcom-qmp: Add QMP V4 USB3 UNIPHY

2020-06-26 Thread Bjorn Andersson
On Sat 23 May 19:14 PDT 2020, Jonathan Marek wrote: > Add support for the USB3 PHY used by the secondary usb controller on sm8150 > > Signed-off-by: Jonathan Marek I've not reviewed the individual register listings, but the rest looks good. Reviewed-by: Bjorn Andersson Regar

Re: [PATCH 1/3] phy: qcom-qmp: Allow different values for second lane

2020-06-26 Thread Bjorn Andersson
qcom_qmp_phy_com_init(struct qmp_phy *qphy) > { > struct qcom_qmp *qmp = qphy->qmp; > @@ -2219,16 +2245,18 @@ static int qcom_qmp_phy_enable(struct phy *phy) > } > > /* Tx, Rx, and PCS configurations */ > - qcom_qmp_phy_configure(tx, cfg->regs, cfg-

Re: [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct regulator_desc pmi8994_boost'

2020-06-26 Thread Bjorn Andersson
sed-const-variable=] > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: linux-arm-...@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson Thanks, Bjorn > --- > drivers/regulator/qcom_smd-regulator.c | 9 - > 1 file changed, 9 deletions(-) &g

Re: [PATCH 2/9] regulator: qcom-rpmh-regulator: Repair dodgy kerneldoc header formatting

2020-06-26 Thread Bjorn Andersson
init_vreg' > drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or > member 'pmic_rpmh_data' not described in 'rpmh_regulator_init_vreg' > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: linux-arm-...@vger.kernel.org > Signed-off-by: Lee Jones Revi

Re: [PATCH v6 1/6] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state

2020-06-24 Thread Bjorn Andersson
On Mon 15 Jun 05:02 PDT 2020, Rajendra Nayak wrote: > geni serial needs to express a perforamnce state requirement on CX > powerdomain depending on the frequency of the clock rates. > Use OPP table from DT to register with OPP framework and use > dev_pm_opp_set_rate() to set the clk/perf state. >

Re: [PATCH V8 0/8] Add interconnect support to QSPI and QUP drivers

2020-06-24 Thread Bjorn Andersson
On Tue 23 Jun 03:38 PDT 2020, Akash Asthana wrote: > This patch series is based on tag "next-20200622" of linux-next tree. > Series applied to the qcom tree, thank you and thanks for the Acks. Regards, Bjorn > High level design: > - QUP wrapper/common driver. >Vote for QUP core on behalf

Re: [PATCH V3 0/5] Enable USB support in IPQ8074

2020-06-24 Thread Bjorn Andersson
On Wed 24 Jun 10:18 PDT 2020, Vinod Koul wrote: > On 08-06-20, 19:41, Sivaprakash Murugesan wrote: > > IPQ8074 has two super speed USB ports, with QMP and QUSB2 PHYs. > > This patch set enables the USB PHYs and USB dwc3 in IPQ8074. > > Applied 1 thru 4. Bjorn can take the 5th one, thanks >

Re: [PATCH v2 06/12] arm64: dts: qcom: msm8994: Add SCM node

2020-06-24 Thread Bjorn Andersson
On Tue 23 Jun 16:30 PDT 2020, Konrad Dybcio wrote: > >Shouldn't this be "qcom,scm-msm8992", "qcom,scm" ? > > > >(Or rather "qcom,scm-msm8994", "qcom,scm") > > Some DTs only have the SoC-specific one, and some also > have the generic one. But I can add the generic one if > you wish. > > I went

Re: [PATCH v2 04/12] arm64: dts: qcom: msm8994: Add support for SMD RPM

2020-06-24 Thread Bjorn Andersson
On Tue 23 Jun 16:34 PDT 2020, Konrad Dybcio wrote: > Thanks for your review. > > I will send the regulators/rpm patch very soon. > > Regarding the mbox, do you know whether it should include any clocks > on 8992/4? What comes to my head is a53/57pll, but that's not there yet.. > So perhaps I

Re: [PATCH v5 1/2] remoteproc: qcom: Add per subsystem SSR notification

2020-06-23 Thread Bjorn Andersson
On Tue 23 Jun 18:41 PDT 2020, risha...@codeaurora.org wrote: > On 2020-06-23 14:45, Alex Elder wrote: > > On 6/22/20 8:04 PM, Rishabh Bhatnagar wrote: > > > Currently there is a single notification chain which is called > > > whenever any > > > remoteproc shuts down. This leads to all the

Re: [PATCH v2 12/12] arm64: dts: qcom: Add support for Sony Xperia Z5 (SoMC Sumire-RoW)

2020-06-23 Thread Bjorn Andersson
On Tue 23 Jun 15:48 PDT 2020, Konrad Dybcio wrote: > diff --git a/arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dts > b/arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dts > new file mode 100644 > index ..e70d54ed7325 > --- /dev/null > +++

Re: [PATCH v2 11/12] arm64: dts: qcom: Move msm8994-smd-rpm contents to lg-bullhead.

2020-06-23 Thread Bjorn Andersson
On Tue 23 Jun 15:48 PDT 2020, Konrad Dybcio wrote: > This was the only device using that dtsi, so no point > keeping it separate AND with a confusing name (bullhead > is based on msm8992 and the file contains regulator > values for that specific board). > > Signed-off-by: Konrad Dybcio > --- >

Re: [PATCH v2 10/12] arm64: dts: qcom: angler: Add qcom,msm-id and pmic-id

2020-06-23 Thread Bjorn Andersson
On Tue 23 Jun 15:48 PDT 2020, Konrad Dybcio wrote: > Add properties required for the bootloader to select > the correct bootloader blob. They have been removed from > the SoC device tree as they should be set on a per-device > basis. > > Signed-off-by: Konrad Dybcio Applied, thanks. > --- >

<    5   6   7   8   9   10   11   12   13   14   >